On Wed, 2 Oct 2024 05:15:04 GMT, David Holmes wrote:
> 3. I will just note that the description for this issue is "Clarify handling
> of restricted and caller-sensitive methods" but there is nothing in the
> proposed changes that relate to CS methods, and I think we have agreed that
> any doc
On Fri, 27 Sep 2024 18:03:14 GMT, Henry Jen wrote:
>> This PR split out large array/set construction into separate factory methods
>> to avoid oversized method trying to construct several of those.
>>
>> In order to do that, we will need to generate those help methods on demand
>> in the class
On Wed, 25 Sep 2024 14:50:12 GMT, Chen Liang wrote:
>> `MethodHandles.Lookup` defines a `ClassFile` for simple validations; it is
>> unnecessary and can be scalarized manually. The removal of `ClassFile` class
>> is also slightly helpful for bootstrap by reducing class loading. Also
>> improve
On Mon, 29 Apr 2024 12:39:17 GMT, Claes Redestad wrote:
>> I'm looking at ways at reducing/eliminating startup overheads the classfile
>> API in preparation of #17108, and have pushed a series of enhancements to
>> that effect already. This PR is a collection of minor improvements which add
>>
ed the pull request incrementally with one additional
> commit since the last revision:
>
> Update
> src/java.base/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java
>
> Co-authored-by: Mandy Chung
HiddenTest is not a hidden class in this test. So
ed the pull request incrementally with one additional
> commit since the last revision:
>
> Update
> src/java.base/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java
>
> Co-authored-by: Mandy Chung
`this::toString` references the hidden class by name [1] which f
On Mon, 29 Apr 2024 12:39:17 GMT, Claes Redestad wrote:
>> I'm looking at ways at reducing/eliminating startup overheads the classfile
>> API in preparation of #17108, and have pushed a series of enhancements to
>> that effect already. This PR is a collection of minor improvements which add
>>
On Fri, 26 Apr 2024 22:27:43 GMT, Claes Redestad wrote:
>> When analyzing (startup) performance of the Classfile API I found this
>> opportunity to further improve `MethodTypeDescImpl::descriptorString`.
>>
>> Performance improves across the board in existing microbenchmarks:
>>
>> Name
On Fri, 26 Apr 2024 18:41:18 GMT, Claes Redestad wrote:
>> src/java.base/share/classes/sun/invoke/util/Wrapper.java line 384:
>>
>>> 382:
>>> 383: /** A nominal descriptor of the primitive type */
>>> 384: public ClassDesc primitiveClassDescriptor() { return
>>> primitiveTypeDesc; }
>>
On Fri, 26 Apr 2024 08:07:04 GMT, Claes Redestad wrote:
>> When analyzing (startup) performance of the Classfile API I found this
>> opportunity to further improve `MethodTypeDescImpl::descriptorString`.
>>
>> Performance improves across the board in existing microbenchmarks:
>>
>> Name
On Fri, 26 Apr 2024 11:51:51 GMT, Claes Redestad wrote:
>> This PR makes ClassDesc.ofDescriptor return the shared constant for
>> primitive descriptor strings ("I" etc..), and leverages this further by
>> refactoring `MethodTypeDescImpl.ofDescriptor` to avoid the intermediate
>> substring for
due to a
> merge or a rebase. The pull request now contains 12 commits:
>
> - Rebase after integration of #18953
> - Nits, clean up constant, introduce missing constant MethodTypeDesc for
> toString
> - Make Set.of(STRONG) a constant, fix compilation, minor code improvements
On Thu, 25 Apr 2024 19:53:46 GMT, Claes Redestad wrote:
>> Splitting out the ASM-based version from #18690 to push that first under the
>> JBS (to help backporting). Keeping #18690 open to rebase and follow-up on
>> this as a subtask. See discussion in that #18690 for more details,
>> discussi
On Wed, 24 Apr 2024 19:13:43 GMT, Claes Redestad wrote:
>> This patch suggests a workaround to an issue with huge SCF MH expression
>> trees taking excessive JIT compilation resources by reviving (part of) the
>> simple bytecode-generating strategy that was originally available as an
>> all-or
On Thu, 25 Apr 2024 19:53:46 GMT, Claes Redestad wrote:
>> Splitting out the ASM-based version from #18690 to push that first under the
>> JBS (to help backporting). Keeping #18690 open to rebase and follow-up on
>> this as a subtask. See discussion in that #18690 for more details,
>> discussi
On Wed, 24 Apr 2024 14:49:55 GMT, Sonia Zaldana Calles
wrote:
>> Hi folks,
>>
>> This PR aims to fix
>> [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
>>
>> I think the regression got introduced in
>> [JDK-8315458](https://bugs.openjdk.org/browse/JDK-8315458).
>>
>> In the i
On Wed, 24 Apr 2024 10:08:42 GMT, Claes Redestad wrote:
>> This patch suggests a workaround to an issue with huge SCF MH expression
>> trees taking excessive JIT compilation resources by reviving (part of) the
>> simple bytecode-generating strategy that was originally available as an
>> all-or
On Thu, 18 Apr 2024 14:50:30 GMT, Claes Redestad wrote:
>> This patch suggests a workaround to an issue with huge SCF MH expression
>> trees taking excessive JIT compilation resources by reviving (part of) the
>> simple bytecode-generating strategy that was originally available as an
>> all-or
On Tue, 23 Apr 2024 18:21:42 GMT, Sonia Zaldana Calles
wrote:
>> Hi folks,
>>
>> This PR aims to fix
>> [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
>>
>> I think the regression got introduced in
>> [JDK-8315458](https://bugs.openjdk.org/browse/JDK-8315458).
>>
>> In the i
On Mon, 22 Apr 2024 08:59:33 GMT, Claes Redestad wrote:
> @mlchung @asotona: Alan asked me to use the ClassFile API here. As it's only
> used in what's effectively a slow path it shouldn't be blocked by the startup
> investigations we're doing there, right?
I agree that this should not be bloc
On Fri, 19 Apr 2024 19:39:09 GMT, Sonia Zaldana Calles
wrote:
>> Hi folks,
>>
>> This PR aims to fix
>> [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
>>
>> I think the regression got introduced in
>> [JDK-8315458](https://bugs.openjdk.org/browse/JDK-8315458).
>>
>> In the i
On Mon, 22 Apr 2024 14:11:41 GMT, Claes Redestad wrote:
>> This switch expression in `Locale::createLocale` is causing a somewhat large
>> startup regression on my local system. Desugaring to if statements seem like
>> the right thing to do while we investigate ways to further reduce overheads
On Fri, 19 Apr 2024 07:42:19 GMT, Claes Redestad wrote:
>> Investigating a recent regression in mainline I realized we have an
>> opportunity to improve the bootstrap overheads of ObjectMethods::bootstrap
>> by using `invokeExact` in a way similar to what we already do for LMF and
>> SCF BSMs.
On Thu, 18 Apr 2024 20:41:05 GMT, Sonia Zaldana Calles
wrote:
> Just to clarify, this would still mean converting “isStatic” and “noArgs”
> from local variables to fields so I am able to read them on the C side of
> things. Did I understand this correctly?
I'm okay with adding static boolean
On Fri, 19 Apr 2024 13:23:53 GMT, Claes Redestad wrote:
> We can reduce overhead of first use of a switch bootstrap by moving
> `typePairToName` into `TypePairs` and by explicitly overriding `hashCode` and
> `equals`. The first change avoids loading and initializing the `TypePairs`
> class in
On Wed, 17 Apr 2024 16:08:31 GMT, Adam Sotona wrote:
>> Current implementation of `LambdaMetafactory` does not allow to use lambdas
>> in hidden classes. Invocation throws `NoClassDefFoundError` instead.
>>
>> This patch includes lambda implementation in a hidden class under the
>> special han
On Wed, 17 Apr 2024 15:21:32 GMT, Adam Sotona wrote:
>> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
>> method handles.
>>
>> This patch converts ASM calls to Classfile API.
>>
>> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>>
>> Any com
On Wed, 17 Apr 2024 11:20:24 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request incremen
On Thu, 4 Apr 2024 09:20:39 GMT, Adam Sotona wrote:
>> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
>> method handles.
>>
>> This patch converts ASM calls to Classfile API.
>>
>> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>>
>> Any comm
On Wed, 3 Apr 2024 22:31:39 GMT, Mandy Chung wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Move CreateLinkableRuntimePlugin to build folder
>>
>> Keep runtim
On Mon, 15 Apr 2024 18:25:02 GMT, Sonia Zaldana Calles
wrote:
> Hi folks,
>
> This PR aims to fix
> [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
>
> I think the regression got introduced in
> [JDK-8315458](https://bugs.openjdk.org/browse/JDK-8315458).
>
> In the issue link
On Mon, 15 Apr 2024 16:10:38 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request incremen
On Fri, 12 Apr 2024 23:55:01 GMT, Joe Darcy wrote:
> Straightforward test update so it doesn't have to be trivially updated for
> each JDK version.
LGTM. Thanks for fixing this.
-
Marked as reviewed by mchung (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18769#pullrequ
On Fri, 5 Apr 2024 18:14:36 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request increment
On Fri, 5 Apr 2024 17:44:22 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request increment
On Fri, 5 Apr 2024 17:41:36 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request increment
On Fri, 5 Apr 2024 08:58:34 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request increment
On Fri, 5 Apr 2024 08:58:34 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request increment
On Fri, 5 Apr 2024 08:08:27 GMT, Suchismith Roy wrote:
>> The test should verify if `/usr/lib/libperstat.a` is present and also
>> `/usr/lib/libperfstat.so` is not present.
>>
>> Do you expect all AIX machines do not have `/usr/lib/libperfstat.so`?
>
> Yes it is expected. the hotspot code has
On Thu, 4 Apr 2024 17:35:43 GMT, Mandy Chung wrote:
>> Suchismith Roy has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add jtreg test case
>
> test/jdk/java/lang/RuntimeTests/loadLibrary/LoadLibrary
On Thu, 4 Apr 2024 11:13:43 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request increment
On Tue, 19 Mar 2024 12:16:29 GMT, Viktor Klang wrote:
> This is a draft PR with a potential solution to 8328366 without regressing
> 8327501.
>
> @DougLea To avoid regressions in the future, where would regression tests for
> this ideally be located?
Marked as reviewed by mchung (Reviewer).
On Thu, 4 Apr 2024 14:46:11 GMT, Viktor Klang wrote:
>> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1143:
>>
>>> 1141: @SuppressWarnings("removal")
>>> 1142: SecurityManager sm = System.getSecurityManager();
>>> 1143: if (sm != null
On Thu, 4 Apr 2024 11:13:43 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request increment
On Tue, 19 Mar 2024 16:55:14 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Wed, 3 Apr 2024 12:32:21 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request increment
On Thu, 14 Mar 2024 17:35:22 GMT, Mandy Chung wrote:
> Trivial fix. Improve the error message to print the cause of the module
> resolution failure if present.
This pull request has now been integrated.
Changeset: 044f4ed5
Author: Mandy Chung
URL:
https://git.openjdk.o
On Mon, 1 Apr 2024 17:07:47 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request increment
On Mon, 1 Apr 2024 17:07:47 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request increment
On Mon, 1 Apr 2024 18:02:26 GMT, Martin Doerr wrote:
> Now, I'm getting "java.lang.UnsatisfiedLinkError: no libname.a in
> java.library.path" when trying `System.loadLibrary("libname.a")` even though
> the file exists in the library path. Is this intended?
To load a library file, you should us
On Mon, 1 Apr 2024 18:24:53 GMT, Mandy Chung wrote:
>> Suchismith Roy has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> spaces
>
> src/java.base/aix/classes/jdk/internal/loader/ClassLoaderHelper.java line 4
On Mon, 1 Apr 2024 17:07:47 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request increment
On Wed, 27 Mar 2024 17:23:50 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request with a n
On Wed, 27 Mar 2024 17:40:09 GMT, Suchismith Roy wrote:
>> AFAICT from your fix for
>> [JDK-8320005](https://bugs.openjdk.org/browse/JDK-8320005) commit
>> [e85355ad](https://github.com/openjdk/jdk/commit/e85355ada4ac1061c49ee9f1247d37a437c7b5ab).
>>
>> But it needs verification as I suggest (
On Wed, 27 Mar 2024 17:30:13 GMT, Suchismith Roy wrote:
>>> Because of the VM support, we can remove `mapAlternativeName` completely.
>>
>> Does VM provide support for mapping .so to .a files ? We still have cases
>> where the entire .a file is shared and don't need to mention the member.
>
> l
On Wed, 27 Mar 2024 17:18:10 GMT, Mandy Chung wrote:
>> I think we both mean that the `if (name.contains("("))` block should get
>> removed.
>
>> We are not supporting that. Are you referring to the comment in the code ?
>> Yeah it should be resconstructi
On Wed, 27 Mar 2024 17:06:49 GMT, Martin Doerr wrote:
>>> > So we should keep the mapAlternativeName for atleast .so to .a
>>> > mapping(without any members mentioned).
>>>
>>> "libname.so(member_name)" is not a valid library name. No reason why
>>> `System.load` has to support it.
>>
>> We a
On Wed, 27 Mar 2024 08:47:10 GMT, Martin Doerr wrote:
>> @mlchung The first name constructed by Classloader is always lib.so.
>> So we need a way to map it to lib.a . Else it will search for .so and
>> fail.
>
> Right, the `loadLibraryOnlyIfPresent` change is sufficient for
> `System.load("lib
On Mon, 25 Mar 2024 09:46:50 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request incremen
On Tue, 26 Mar 2024 20:59:54 GMT, Martin Doerr wrote:
>> Suchismith Roy has updated the pull request incrementally with four
>> additional commits since the last revision:
>>
>> - coding style
>> - set false
>> - restore fil
>> - remove member check code
>
> src/java.base/aix/classes/jdk/i
On Mon, 25 Mar 2024 18:56:21 GMT, Suchismith Roy wrote:
> And it has been in J9 for long time for the exact same reason, which
> actually brought out the issue for dcstartup in OpenJDK.
dcstartup fails because it fails to load an agent library specified via
`-agentlib:am_ibm_16` that was fixe
On Mon, 25 Mar 2024 09:46:50 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request incremen
On Mon, 18 Mar 2024 17:43:45 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request incremen
On Mon, 18 Mar 2024 17:43:45 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request incremen
On Wed, 20 Mar 2024 10:24:23 GMT, Severin Gehwolf wrote:
> What we really want is some form of API to extend/patch an existing jimage
> preserving everything else. Perhaps I should look into that. Would that be
> worth doing?
I think avoiding the plugin pipeline in creating a linkable image is
On Tue, 19 Mar 2024 12:16:29 GMT, Viktor Klang wrote:
> This is a draft PR with a potential solution to 8328366 without regressing
> 8327501.
>
> @DougLea To avoid regressions in the future, where would regression tests for
> this ideally be located?
src/java.base/share/classes/java/util/conc
Vote: yes
Mandy
On 3/19/24 8:19 AM, Daniel Fuchs wrote:
Hi,
I hereby nominate Per-Ake Minborg (pminborg) [1] to Membership in the
Core Libraries Group [4].
Per-Ake is an OpenJDK Reviewer, a committer in the
Leyden and Panama projects, and a member of Oracle’s
Java Core Libraries team.
Per-
On Tue, 19 Mar 2024 16:55:14 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Mon, 18 Mar 2024 17:40:26 GMT, Mandy Chung wrote:
> A simple fix. This is caused by a bug in `VerifyAccess::isClassAccessible`
> that checks if a class is exported from `java.base` before the exports are
> fully setup.It should check if the module system is fully initialized
On Fri, 15 Mar 2024 15:19:17 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Mon, 18 Mar 2024 13:01:10 GMT, Severin Gehwolf wrote:
> Yes we do. The main reason being that the `jdk` image has more to it than
> just the image. `src.zip`, CDS data, `demo` and so on. We don't want to
> duplicate that. To us, including the `jmods` folder is something that comes
> into pl
A simple fix. This is caused by a bug in `VerifyAccess::isClassAccessible`
that checks if a class is exported from `java.base` before the exports are
fully setup.It should check if the module system is fully initialized
before checking the module exports instead.
-
Commit mes
On Fri, 15 Mar 2024 10:53:29 GMT, Severin Gehwolf wrote:
> Wasn't the intention to make "creating a linkable runtime image" a build only
> decision and make the relevant infrastructure classes build-only artefacts?
Build-only decision means that the linkable runtime image is only produced by
J
On Fri, 15 Mar 2024 09:55:15 GMT, Severin Gehwolf wrote:
> > If `--enable-runtime-link-image` is enabled, the JDK image does not include
> > the packaged modules.
>
> That's not true. Right now `--enable-runtime-link-image` modifies how the
> `lib/modules` image looks like (adds a bunch of ext
On Thu, 14 Mar 2024 14:24:57 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
Trivial fix. Improve the error message to print the cause of the module
resolution failure if present.
-
Commit messages:
- 8326979: (jdeps) improve the error message for FindException caused by
InvalidModuleDescriptorException
Changes: https://git.openjdk.org/jdk/pull/18308/file
On Thu, 25 Jan 2024 21:35:45 GMT, Sergey wrote:
> The feature allows to extract a private field value in a single expression,
> like so:
>
> object.getClass().getDeclaredField().setAccessible().get(object)
I agree with the evaluation of
[JDK-8327786](https://bugs.openjdk.org/browse/JDK-832778
On Sun, 10 Mar 2024 13:47:06 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which removes the 19 deprecated `xxObject*` alias
>> methods from `jdk.internal.misc.Unsafe`.
>>
>> These methods were added in JDK-8213043 (JDK 12), presumably to allow
>> `jsr166.jar` to be used across JDK versi
On Fri, 8 Mar 2024 17:19:41 GMT, Severin Gehwolf wrote:
>> I tried out the latest commit (a797ea69).
>>
>> The output "The default module path, '$java.home/jmods' not present. Use
>> --verbose to show the full list of plugin options applied" is bit confusing
>> as it looks like jlink failed bu
On Tue, 27 Feb 2024 15:23:09 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Wed, 6 Mar 2024 19:00:19 GMT, Alan Bateman wrote:
>> Native access is needed for modules which calls restricted methods [1].
>> AFAICT, java.base, java.desktop and jdk.incubator.vector use
>> java.lang.foreign but I don't know if they call restricted methods or not.
>>
>> https://download
On Wed, 6 Mar 2024 15:02:07 GMT, Jan Lahoda wrote:
>>> Many of these modules do not need native access in the current
>>> implementation.
>>
>> In addition this will eventually need jlink support. I view the change to
>> ModuleBootstrap initialiser to use ModuleLoaderMap.nativeAccessModules()
These deprecated methods were added to make jsr166.jar to run on
different JDK releases. I think it's time to remove these deprecated
xxxObject* methods as the renames have been done since JDK 12 for 5
years. I added a comment [1] to confirm with Doug and Martin.
Mandy
https://bugs.openjdk
On Tue, 5 Mar 2024 18:43:44 GMT, Alan Bateman wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Apply suggestions from code review
>>
>> Co-authored-by: ExE Boss <3889017+exe-b...@users.noreply.github.com>
>> Co
Vote: yes
Mandy
On 2/13/24 12:25 PM, Brian Burkhalter wrote:
I hereby nominate Raffaello Giulietti to Membership in the Core Libraries Group.
On Thu, 1 Feb 2024 01:32:42 GMT, Joe Darcy wrote:
> A double quote character doesn't need to be escaped when it is a char literal
> and single quote character doesn't need to be escaped when it is in a string.
> This change updates the toString() output of annotations to account for the
> diff
On Mon, 5 Feb 2024 20:11:43 GMT, Mandy Chung wrote:
> Trivial fix. Call `PrintWriter::format` with null `Locale` to format with no
> localization.
>
> This PR also fixes JDK-8325262 to print `FindException` message without the
> stack trace to indicate clearer that the given
On Mon, 5 Feb 2024 20:11:43 GMT, Mandy Chung wrote:
> Trivial fix. Call `PrintWriter::format` with null `Locale` to format with no
> localization.
>
> This PR also fixes JDK-8325262 to print `FindException` message without the
> stack trace to indicate clearer that the given
Trivial fix. Call `PrintWriter::format` with null `Locale` to format with no
localization.
This PR also fixes JDK-8325262 to print `FindException` message without the
stack trace to indicate clearer that the given module path is incorrect.
-
Commit messages:
- update copyright h
On Tue, 16 Jan 2024 21:18:55 GMT, Vicente Romero wrote:
> Updating ASM to version 9.6,
>
> Thanks in advance for the reviews,
> Vicente
Looks okay to me. I would rely on your testing for verification.
-
Marked as reviewed by mchung (Reviewer).
PR Review: https://git.openjdk.org
On Tue, 16 Jan 2024 21:18:55 GMT, Vicente Romero wrote:
> Updating ASM to version 9.6,
>
> Thanks in advance for the reviews,
> Vicente
The change looks okay to me. Most of the changes are doc change. I see many
files are updated just to remove the empty line at the end of the file - is
th
On Wed, 17 Jan 2024 20:51:23 GMT, Mandy Chung wrote:
> The build excludes the native debug symbols in JMOD files created for JDK
> modules (see make/CreateJmods.gmk). This PR adds a test to verify that
> native debug symbols are excluded as expected.
This pull request has
On Mon, 11 Dec 2023 16:37:38 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Mon, 11 Dec 2023 16:37:38 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Thu, 18 Jan 2024 13:37:12 GMT, Severin Gehwolf wrote:
> > If I read the code correctly, the image created with this option will
> > enable multi-hops unconditionally? i.e. no timestamp file created and
> > disable the check completely. I think the .stamp file should be present in
> > any im
The build excludes the native debug symbols in JMOD files created for JDK
modules (see make/CreateJmods.gmk). This PR adds a test to verify that native
debug symbols are excluded as expected.
-
Commit messages:
- 8159927: Add a test to verify JMOD files created in the images do n
On Tue, 16 Jan 2024 18:42:59 GMT, Claes Redestad wrote:
>> There's an unused concept of a pluginConfig that is passed into the jlink
>> compress plugins, however we always pass null here and the code seems broken
>> (the pluginConfig wouldn't have been stored properly). This seem to be a
>> le
On Tue, 16 Jan 2024 18:03:34 GMT, Claes Redestad wrote:
>> There's an unused concept of a pluginConfig that is passed into the jlink
>> compress plugins, however we always pass null here and the code seems broken
>> (the pluginConfig wouldn't have been stored properly). This seem to be a
>> le
On Fri, 12 Jan 2024 18:45:39 GMT, Glavo wrote:
> I generated runtime images using `jlink --compress 2 --add-modules
> java.se,jdk.unsupported,jdk.management` and then ran the following JMH
> benchmark:
>
>
> @Warmup(iterations = 10, time = 2)
> @Measurement(iterations = 5, time = 3)
> @Fork(v
On Wed, 8 Nov 2023 11:55:22 GMT, Glavo wrote:
> This PR significantly speeds up decompressing resources in Jimage while
> significantly reducing temporary memory allocations in the process.
>
> This will improve startup speed for runtime images generated using `jlink
> --compress 1` and `jlink
1 - 100 of 809 matches
Mail list logo