On Wed, 13 Jul 2022 04:30:39 GMT, Yoshiki Sato wrote:
> Please review this PR. The PR open sources the closed timezone tests.
1 minor comment. Looks good to me.
test/jdk/java/util/TimeZone/tools/share/Makefile line 33:
> 31: #
> 32:
> 33: TZDATA = ../../../../../../../../open/src/java.base/s
On Wed, 13 Jul 2022 04:30:39 GMT, Yoshiki Sato wrote:
> Please review this PR. The PR open sources the closed timezone tests.
Marked as reviewed by coffeys (Reviewer).
test/jdk/java/util/TimeZone/tools/share/makeZoneData.pl line 32:
> 30: # static TimeZoneData.
> 31: # For J2SE since JDK1.4,
Add a JFR Event for `java.security.Provider.getService(String type, String
algorithm)` calls.
-
Commit messages:
- Track successful getInstance calls only
- Merge branch 'master' into 8254711-jfr-jca
- Refactor and use of static Event on
- Merge branch 'master' into 8254711-jfr-j
On Wed, 27 Jul 2022 13:14:39 GMT, Sean Coffey wrote:
> Add a JFR Event for `java.security.Provider.getService(String type, String
> algorithm)` calls.
Reviewer request: @seanjmullan @egahlin
-
PR: https://git.openjdk.org/jdk/pull/9657
On Mon, 19 Sep 2022 15:27:05 GMT, Sean Coffey wrote:
>> src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java line 32:
>>
>>> 30:
>>> 31: import jdk.jfr.Event;
>>> 32: import jdk.jfr.events.*;
>>
>> Hello Sean, rest of the
On Mon, 19 Sep 2022 14:25:55 GMT, Jaikiran Pai wrote:
>> Add a JFR Event for `java.security.Provider.getService(String type, String
>> algorithm)` calls.
>
> src/java.base/share/classes/java/security/Provider.java line 1293:
>
>> 1291: }
>> 1292:
>> 1293: if (s != null && Secur
On Wed, 27 Jul 2022 13:14:39 GMT, Sean Coffey wrote:
> Add a JFR Event for `java.security.Provider.getService(String type, String
> algorithm)` calls.
>
This new event is disabled by default just like the other crypto related events
that were added some time back (e.g. `TLSHands
> Add a JFR Event for `java.security.Provider.getService(String type, String
> algorithm)` calls.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
update from review comments
-
Changes:
- all: https://git.openj
On Mon, 19 Sep 2022 16:43:26 GMT, Valerie Peng wrote:
>> Yes, I think this would generate too much noise and detract from the main
>> motivation for these events, which is to help users analyze the security of
>> algorithms that are being used by their applications at the JCE layer.
>
> Plus on
> Add a JFR Event for `java.security.Provider.getService(String type, String
> algorithm)` calls.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Correct Label annontation capitals
-
Changes:
- all:
On Wed, 27 Jul 2022 13:14:39 GMT, Sean Coffey wrote:
> Add a JFR Event for `java.security.Provider.getService(String type, String
> algorithm)` calls.
This pull request has now been integrated.
Changeset: bc2af47e
Author: Sean Coffey
URL:
https://git.openjdk.org/jdk/
New JFR event to record state of initial security properties.
Debug output is also now added for these properties via
-Djava.security.debug=properties
-
Commit messages:
- merge with master
- Correct test bug ids
- fix up imports
- Add security debug test logic
- Add JFR testc
On Tue, 27 Sep 2022 20:29:31 GMT, Sean Mullan wrote:
>> New JFR event to record state of initial security properties.
>>
>> Debug output is also now added for these properties via
>> -Djava.security.debug=properties
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java line
> New JFR event to record state of initial security properties.
>
> Debug output is also now added for these properties via
> -Djava.security.debug=properties
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Null check o
On Wed, 28 Sep 2022 07:06:30 GMT, Jaikiran Pai wrote:
> Hello Sean,
>
> > Debug output is also now added for these properties via
> > -Djava.security.debug=properties
>
> Looking at the existing code upstream, it appears that the value `properties`
> is already recognized for `java.security.d
On Wed, 28 Sep 2022 12:26:49 GMT, Sean Mullan wrote:
>> Yes - the thinking here is that since this is a one time event, we can have
>> it enabled. It's similar to the InitialSystemProperty event.
>>
>> We won't force loading of Security properties/class. We shouldn't at least.
>> If no securi
On Wed, 28 Sep 2022 16:32:17 GMT, Sean Mullan wrote:
>> Correct - this type of event period (beginChunk) will fire once when the JFR
>> recording is begun. It should capture Security Properties (if
>> java.security.Security is loaded) for any recording, no matter when it might
>> begin or end.
On Thu, 29 Sep 2022 11:41:02 GMT, Erik Gahlin wrote:
>> As per yesterday's stack trace, JFR triggers loading of the Security class -
>> so your scenario won't arise with current state. We could include the new
>> Event with period of `endChunk `instead of `beingChunk `setting. That should
>> e
On Wed, 28 Sep 2022 03:40:06 GMT, Yoshiki Sato wrote:
> Please review this PR. The change include some code changes in
> ZoneInfoFile.java and TestZoneInfo310.java since tzdata2022d breaks
> TestZoneInfo310.java.
LGTM
-
Marked as reviewed by coffeys (Reviewer).
PR: https://git.
On Fri, 30 Sep 2022 19:32:29 GMT, Sean Mullan wrote:
>> Thanks @egahlin - maybe we can leave it at beginChunk setting then.
>>
>> I've been doing some testing to satisfy myself that the impact of this event
>> on performance is minimal, Running the new `emitInitialSecurityProperties()`
>> is
> New JFR event to record state of initial security properties.
>
> Debug output is also now added for these properties via
> -Djava.security.debug=properties
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Check fo
> New JFR event to record state of initial security properties.
>
> Debug output is also now added for these properties via
> -Djava.security.debug=properties
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Address O
On Mon, 10 Oct 2022 14:19:18 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/java/security/ProtectionDomain.java line 76:
>>
>>> 74: static class JavaSecurityAccessImpl implements JavaSecurityAccess {
>>> 75: /* cache a copy for recording purposes */
>>> 76: static Pro
On Mon, 10 Oct 2022 07:19:30 GMT, Jaikiran Pai wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Check for 0 security events
>
> src/jdk.jfr/share/classes/jdk/jfr/events/InitialSecurit
On Mon, 10 Oct 2022 20:54:58 GMT, Sean Mullan wrote:
>> modified code to have Security class hold the initial properties and
>> provided an accessor method
>
> What about creating a new `JavaSecurityPropertiesAccess` class and moving the
> accessor method there? It seems it would be cleaner to
On Tue, 11 Oct 2022 12:39:14 GMT, Sean Mullan wrote:
>> @seanjmullan - I looked at that approach. The
>> `SharedSecrets.getJavaSecurityAccess().getInitialProperties();` call may
>> trigger early initialization of the `java.security.Security` class - I'm not
>> sure if we want that. Protection
On Wed, 12 Oct 2022 20:03:05 GMT, Naoto Sato wrote:
> Fixed to utilize `StaticProperty` so that the system property value for
> `java.locale.useOldISOCodes` set on the command line is honored even with
> lazy `Locale` initialization.
Marked as reviewed by coffeys (Reviewer).
src/java.base/sha
> New JFR event to record state of initial security properties.
>
> Debug output is also now added for these properties via
> -Djava.security.debug=properties
Sean Coffey has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contain
On Tue, 11 Oct 2022 12:39:14 GMT, Sean Mullan wrote:
>> @seanjmullan - I looked at that approach. The
>> `SharedSecrets.getJavaSecurityAccess().getInitialProperties();` call may
>> trigger early initialization of the `java.security.Security` class - I'm not
>> sure if we want that. Protection
> New JFR event to record state of initial security properties.
>
> Debug output is also now added for these properties via
> -Djava.security.debug=properties
Sean Coffey has updated the pull request incrementally with two additional
commits since the last revision:
- remove p
On Thu, 13 Oct 2022 19:19:05 GMT, Sean Mullan wrote:
>> Sean Coffey has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 17 commits:
>>
>> - test update
>> - Merge branch 'master' into secEve
By moving the JFR event up to the java.security.cert.CertificateFactory class,
we can record all generate cert events, including those from 3rd party
providers. I've also altered the logic so that an event is genertate for every
generate cert call (not just ones missing from the JDK provider imp
On Fri, 14 Oct 2022 19:25:54 GMT, Weibing Xiao wrote:
>> 8290313: Produce warning when user specified java.io.tmpdir directory
>> doesn't exist
>
> Weibing Xiao has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 11 commits:
>
> - Me
On Thu, 22 Sep 2022 15:57:56 GMT, Sean Coffey wrote:
> New JFR event to record state of initial security properties.
>
> Debug output is also now added for these properties via
> -Djava.security.debug=properties
This pull request has now been integrated.
Changeset: 8c40b7dc
Aut
On Tue, 8 Nov 2022 12:03:06 GMT, Erik Gahlin wrote:
> Could I have a review of PR that fixes so unsigned numbers are printed
> correctly in the jfr tool.
>
> Testing:
> test/jdk/jdk/jfr
> test/jdk/jdk/security/logging/
>
> Thanks
> Erik
Marked as reviewed by coffeys (Reviewer).
LGTM
---
On Wed, 16 Nov 2022 15:06:14 GMT, Roger Riggs wrote:
>> Weibing Xiao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> the change according to review comment
>
> src/java.base/share/classes/jdk/internal/util/SystemProps.java line 52:
>
>>
On Fri, 18 Nov 2022 18:36:51 GMT, Weibing Xiao wrote:
>> print warning message for java.io.tmpdir when it is set through the command
>> line and the value is not good for creating file folder.
>
> Weibing Xiao has updated the pull request incrementally with one additional
> commit since the las
On Mon, 21 Nov 2022 16:35:46 GMT, Weibing Xiao wrote:
>> print warning message for java.io.tmpdir when it is set through the command
>> line and the value is not good for creating file folder.
>
> Weibing Xiao has updated the pull request incrementally with one additional
> commit since the las
On Wed, 16 Nov 2022 15:12:41 GMT, Roger Riggs wrote:
>> Weibing Xiao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> the change according to review comment
>
> test/jdk/java/io/File/TempDirectoryNotExisting.java line 45:
>
>> 43:
>> 44
On Fri, 10 Feb 2023 20:35:58 GMT, Naoto Sato wrote:
> Upgrading the GB18030 charset in the JDK to the latest 2022 standard. Since
> this is not a compatible upgrade to the existing mapping, a new system
> property `jdk.charset.GB18030` is introduced. If it is set to "2000", the
> mapping falls
On Thu, 23 Feb 2023 09:03:49 GMT, Alan Bateman wrote:
>> Scratch that: as it seems to be important that we don't switch after startup
>> then what this code is really reaching for is `static final` field
>> semantics. Since `StandardCharsets` might be loaded very early a holder
>> class patter
On Thu, 23 Feb 2023 19:34:44 GMT, Naoto Sato wrote:
>> Upgrading the GB18030 charset in the JDK to the latest 2022 standard. Since
>> this is not a compatible upgrade to the existing mapping, a new system
>> property `jdk.charset.GB18030` is introduced. If it is set to "2000", the
>> mapping f
On Mon, 20 Mar 2023 12:10:04 GMT, Jan Lahoda wrote:
> If JShell is run on a system that does not have `/bin/test` (which is,
> apparently, possible for some systems, which only have `/usr/bin/test`), it
> won't switch the terminal into the raw mode, and the input will not work
> properly.
>
>
On Wed, 22 Mar 2023 18:38:08 GMT, Jan Lahoda wrote:
>> If JShell is run on a system that does not have `/bin/test` (which is,
>> apparently, possible for some systems, which only have `/usr/bin/test`), it
>> won't switch the terminal into the raw mode, and the input will not work
>> properly.
minor enhancement to have -XshowSettings launcher option display the version of
tzdata installed in the JDK
example output of the new tzdata info :
Locale settings:
default locale = English
default display locale = English
default format locale = English
tzdata version = 20
On Mon, 8 May 2023 13:14:34 GMT, Sean Coffey wrote:
> minor enhancement to have -XshowSettings launcher option display the version
> of tzdata installed in the JDK
>
> example output of the new tzdata info :
>
>
>
> Locale settings:
> default locale = En
New functionality in the -XshowSettings menu to display relevant information
about JDK security configuration
-
Commit messages:
- minor edits, copyright, descriptions etc
- Merge branch 'master' into 8281658-showsettings-security
- Merge branch 'master' into 8281658-showsettings-
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote:
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Thanks for the reviews to date. All good comments, I'll implement.
Yes, the output of `-XShowSettings` is more verb
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote:
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Thanks for the feedback to date. I've pushed new changes to reflect requested
changes. I've changed the default
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/
On Tue, 13 Jun 2023 14:30:57 GMT, Roger Riggs wrote:
>> Sean Coffey has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six addi
On Tue, 13 Jun 2023 13:57:13 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request with a new target base due to a
> merge or a rebase. T
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Incorporate review comments from Roger and tweak som
On Wed, 14 Jun 2023 12:46:36 GMT, Weijun Wang wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Incorporate review comments from Roger and tweak some code
>
> src/java.b
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request incrementally with two additional
commits since the last revision:
- Refactor out security code to helper class
- Print aliases.
On Thu, 15 Jun 2023 06:32:06 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 183:
>>
>>> 181: case "locale":
>>> 182: printLocale();
>>> 183: break;
>>
>> printLocale might need the same treatment to avoid
On Wed, 14 Jun 2023 14:06:33 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 424:
>>
>>> 422:if (!services.isEmpty()) {
>>> 423:services.stream()
>>> 424:
>>> .sorted(Comparator.comparing
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit si
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Pass PrintStream to security helper
-
Changes:
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request incrementally with two additional
commits since the last revision:
- restore more informative help message
- Split long properti
On Fri, 16 Jun 2023 15:15:59 GMT, Roger Riggs wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Pass PrintStream to security helper
>
> src/java.base/share/classes/sun/launcher/SecurityS
On Fri, 16 Jun 2023 11:23:48 GMT, Alan Bateman wrote:
>> Sean Coffey has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Refactor out security code to helper class
>> - Print aliases. Order Provider type/ser
On Sat, 17 Jun 2023 01:51:36 GMT, Weijun Wang wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Pass PrintStream to security helper
>
> src/java.base/share/classes/sun/launcher/SecurityS
On Mon, 19 Jun 2023 18:21:49 GMT, Roger Riggs wrote:
>> @RogerRiggs - do you mean to print nothing in the "bad command input"
>> scenario ? The current -XshowSettings launch behaviour prints all data if a
>> bad value is passed to it. I was mimicking this for security subcommands.
>>
>> Are
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Don't allow bad subcommand values for securit
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/
On Thu, 6 Jul 2023 17:15:20 GMT, Mandy Chung wrote:
> > The changes make me wonder if `-XshowSetting:aardvark` should be an error
> > rather than default to print all settings. Something we should look at
> > again. Same thing for `-XshowSettings:system` on non-Linux, probably should
> > have
On Thu, 6 Jul 2023 18:43:41 GMT, Roger Riggs wrote:
>> Sean Coffey has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 15 addi
On Thu, 6 Jul 2023 14:03:12 GMT, Sean Mullan wrote:
>> Sean Coffey has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 15 addi
On Fri, 7 Jul 2023 13:40:53 GMT, Sean Coffey wrote:
>> src/java.base/share/classes/sun/launcher/SecuritySettings.java line 123:
>>
>>> 121: }
>>> 122:
>>> 123: ostream.println(INDENT + "Security TLS configuration:");
>&
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request incrementally with two additional
commits since the last revision:
- Harden code to report lack of SSL support
- Testcase corr
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote:
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
This pull request has now been integrated.
Changeset: 2e12a123
Author: Sean Coffey
URL:
https://git.openjdk.o
Simple tweak to remove the "available locales" section from default
`-XshowSettings` output.
Instead, it remains available with the `-XshowSettings:locale` option
-
Commit messages:
- 8310201
Changes: https://git.openjdk.org/jdk/pull/14885/files
Webrev: https://webrevs.openjdk.or
> Simple tweak to remove the "available locales" section from default
> `-XshowSettings` output.
>
> Instead, it remains available with the `-XshowSettings:locale` option
Sean Coffey has updated the pull request incrementally with one additional
commit since the la
On Fri, 14 Jul 2023 11:02:33 GMT, Jaikiran Pai wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review feedback and bug id added to test
>
> src/java.base/share/classes/sun/launche
On Fri, 14 Jul 2023 11:21:02 GMT, Sean Coffey wrote:
>> Simple tweak to remove the "available locales" section from default
>> `-XshowSettings` output.
>>
>> Instead, it remains available with the `-XshowSettings:locale` option
>
> Sean Coffey has upd
On Fri, 14 Jul 2023 10:01:16 GMT, Sean Coffey wrote:
> Simple tweak to remove the "available locales" section from default
> `-XshowSettings` output.
>
> Instead, it remains available with the `-XshowSettings:locale` option
This pull request has now been integrated
Modify the -XshowSettings launcher option to print non-verbose settings details
of all components by default. Verbose settings details will be printed via the
-XshowSettings:all option. Modify the -XshowSettings option to reject bad
values passed to it. Print an error message in such scenarios a
sage in such scenarios
> and abort the VM launch.
Sean Coffey has updated the pull request incrementally with two additional
commits since the last revision:
- Incorporate review feedback
- modify -X output for :all
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15001/files
On Mon, 24 Jul 2023 16:00:52 GMT, Sean Coffey wrote:
> Modify the -XshowSettings launcher option to print non-verbose settings
> details of all components by default. Verbose settings details will be
> printed via the -XshowSettings:all option. Modify the -XshowSettings option
> t
On Tue, 25 Jul 2023 21:01:03 GMT, Mandy Chung wrote:
>> Sean Coffey has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Incorporate review feedback
>> - modify -X output for :all
>
> src/
sage in such scenarios
> and abort the VM launch.
Sean Coffey has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains seven additional commits since
th
On Wed, 26 Jul 2023 09:22:14 GMT, Sean Coffey wrote:
>> Modify the -XshowSettings launcher option to print non-verbose settings
>> details of all components by default. Verbose settings details will be
>> printed via the -XshowSettings:all option. Modify the -XshowSettings op
On Mon, 24 Jul 2023 16:00:52 GMT, Sean Coffey wrote:
> Modify the -XshowSettings launcher option to print non-verbose settings
> details of all components by default. Verbose settings details will be
> printed via the -XshowSettings:all option. Modify the -XshowSettings option
> t
On Tue, 15 Aug 2023 18:43:36 GMT, Lance Andersen wrote:
>> This PR updates the extra field validation added as part of
>> [JDK-8302483](https://bugs.openjdk.org/browse/JDK-8302483) to deal with
>> issues seen with 3rd party tools/libraries where a ZipException may be
>> encountered when open
Recursive initialization calls possible during loading of LoggerFinder service.
This fix detects the recursive call and returns a temporary LoggerFinder that
is backed by a lazy logger. Automated test case developed to simulate loading
of an external LoggerFinder service while also having oth
nder service while also having other threads poke
> System.getLogger during this framework initialization.
Sean Coffey has updated the pull request incrementally with two additional
commits since the last revision:
- Improve test coverage
- Incorporate review comments from Daniel
--
On Wed, 23 Aug 2023 15:41:16 GMT, Sean Coffey wrote:
> Recursive initialization calls possible during loading of LoggerFinder
> service.
>
> This fix detects the recursive call and returns a temporary LoggerFinder that
> is backed by a lazy logger. Automated test case develo
On Thu, 24 Aug 2023 10:54:19 GMT, Sean Coffey wrote:
>> Recursive initialization calls possible during loading of LoggerFinder
>> service.
>>
>> This fix detects the recursive call and returns a temporary LoggerFinder
>> that is backed by a lazy logger. Au
nder service while also having other threads poke
> System.getLogger during this framework initialization.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
fix up bootstrap loggers, patch contribution from Daniel
-
Ch
On Fri, 25 Aug 2023 10:24:23 GMT, Jaikiran Pai wrote:
>> Sean Coffey has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Improve test coverage
>> - Incorporate review comments from Daniel
>
> src/
On Fri, 25 Aug 2023 10:33:49 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/jdk/internal/logger/LazyLoggers.java line 425:
>>
>>> 423: */
>>> 424: public static final Logger getLogger(String name, Module module) {
>>> 425: BootstrapLogger.detectBackend();
>>
>> Suggest
nder service while also having other threads poke
> System.getLogger during this framework initialization.
Sean Coffey has updated the pull request incrementally with two additional
commits since the last revision:
- Tidy up SignedLoggerFinderTest.java
- Code contribution from Daniel includ
nder service while also having other threads poke
> System.getLogger during this framework initialization.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Fix up test cases
-
Changes:
- all: https://git.openjdk.org
nder service while also having other threads poke
> System.getLogger during this framework initialization.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Review comments from Daniel. Further test clean up
-
Ch
nder service while also having other threads poke
> System.getLogger during this framework initialization.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
more tidying up in tests
-
Changes:
- all: https://git.openj
On Wed, 23 Aug 2023 15:41:16 GMT, Sean Coffey wrote:
> Recursive initialization calls possible during loading of LoggerFinder
> service.
>
> This fix detects the recursive call and returns a temporary LoggerFinder that
> is backed by a lazy logger. Automated test case develo
Update the recently added LoggerFinder tests to cater for a possible condition
where the test finishes before the boot logger executor service has flushed its
pending data.
By simulating a slow thread in the ExecutorService used in BootstrapLogger, I
was able to reproduce the issue described. A
1 - 100 of 141 matches
Mail list logo
