On Mon, 23 Oct 2023 16:12:45 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 23 Oct 2023 16:12:45 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 23 Oct 2023 16:12:45 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 23 Oct 2023 16:12:45 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
> objects aren't created for the same zip file.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Update jmh test comments
-
Changes:
- all:
On Mon, 23 Oct 2023 13:04:20 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 23 Oct 2023 13:04:20 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 23 Oct 2023 13:04:20 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 23 Oct 2023 13:04:20 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 23 Oct 2023 13:04:20 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
> objects aren't created for the same zip file.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Incorporate test review comments from Jai
-
On Mon, 23 Oct 2023 09:14:06 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 23 Oct 2023 09:14:06 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 23 Oct 2023 09:14:06 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 23 Oct 2023 10:39:11 GMT, Sean Coffey wrote:
> ZipFile behaviour in the scenario where a file is re-opened and edited
> while references to the old ZipFile exist. A "invalid LOC header" needs to be
> thrown in cases where an old zip file mapping is still in use.
This PR doesn't do any
On Mon, 23 Oct 2023 09:14:06 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 23 Oct 2023 09:14:06 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 23 Oct 2023 09:14:06 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
> objects aren't created for the same zip file.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Update code comments
-
Changes:
- all:
On Wed, 18 Oct 2023 15:59:13 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Wed, 18 Oct 2023 15:59:13 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
> objects aren't created for the same zip file.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Update lastModifiedTime comment
-
Changes:
On Wed, 18 Oct 2023 10:09:29 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Wed, 18 Oct 2023 10:09:29 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
> objects aren't created for the same zip file.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Testcase feedback from Lance
-
Changes:
-
On Tue, 17 Oct 2023 19:55:19 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Tue, 17 Oct 2023 19:55:19 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
> objects aren't created for the same zip file.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
remove getCanonicalFile calls, update ZipFile jmh
On Tue, 17 Oct 2023 08:50:15 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request with a new target base due to a
> merge or a rebase. The
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
> objects aren't created for the same zip file.
Sean Coffey has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the
On Fri, 13 Oct 2023 12:18:41 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Fri, 13 Oct 2023 12:18:41 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Fri, 13 Oct 2023 12:18:41 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Fri, 13 Oct 2023 12:18:41 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Fri, 13 Oct 2023 12:18:41 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
> objects aren't created for the same zip file.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
minor test edits and comment updates
-
On Fri, 13 Oct 2023 08:45:07 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
> objects aren't created for the same zip file.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
insert back lastmodified check. enhance testcase. more
On Tue, 10 Oct 2023 12:46:22 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Tue, 10 Oct 2023 12:46:22 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
> objects aren't created for the same zip file.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
incorporate review comments
-
Changes:
-
On Tue, 10 Oct 2023 08:32:28 GMT, Sean Coffey wrote:
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
> objects aren't created for the same zip file.
src/java.base/share/classes/java/util/zip/ZipFile.java line 1418:
> 1416:
> 1417:
On Tue, 10 Oct 2023 08:32:28 GMT, Sean Coffey wrote:
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
> objects aren't created for the same zip file.
This is really ZipFile.Source.Key hashCode/equals being inconsistent so I think
we should rename the JBS/PR title
On Tue, 10 Oct 2023 08:32:28 GMT, Sean Coffey wrote:
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
> objects aren't created for the same zip file.
src/java.base/share/classes/java/util/zip/ZipFile.java line 1444:
> 1442: } else {
> 1443:
On Tue, 10 Oct 2023 08:32:28 GMT, Sean Coffey wrote:
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
> objects aren't created for the same zip file.
src/java.base/share/classes/java/util/zip/ZipFile.java line 1424:
> 1422: return
Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
objects aren't created for the same zip file.
-
Commit messages:
- Initial changes
Changes: https://git.openjdk.org/jdk/pull/16115/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=16115=00
Issue:
46 matches
Mail list logo
