[jira] [Updated] (DERBY-6801) Implement MessageUtils class so client and server can share message argument encoding/decoding

2015-07-16 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Pendleton updated DERBY-6801: --- Attachment: MessageUtilsBryan.diff Hi Abhinav, thank you for posting your patch. Once I

[jira] [Commented] (DERBY-6801) Implement MessageUtils class so client and server can share message argument encoding/decoding

2015-07-16 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630668#comment-14630668 ] Bryan Pendleton commented on DERBY-6801: The network tests do NOT run cleanly

[jira] [Commented] (DERBY-6741) User code can get the ContextManager from an EmbedConnection

2015-07-14 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627498#comment-14627498 ] Bryan Pendleton commented on DERBY-6741: Indeed, that makes the test reliable

[jira] [Updated] (DERBY-6807) XXE attack possible by using XmlVTI and the XML datatype

2015-07-13 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Pendleton updated DERBY-6807: --- Attachment: sqlxmlutil.diff Attached sqlxmlutil.diff is a proposed fix for this issue

[jira] [Updated] (DERBY-6741) User code can get the ContextManager from an EmbedConnection

2015-07-13 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Pendleton updated DERBY-6741: --- Attachment: derby.log error-stacktrace.out I saw another failure in my test

[jira] [Commented] (DERBY-6741) User code can get the ContextManager from an EmbedConnection

2015-07-13 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625693#comment-14625693 ] Bryan Pendleton commented on DERBY-6741: Perhaps: public void

[jira] [Comment Edited] (DERBY-6741) User code can get the ContextManager from an EmbedConnection

2015-07-13 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625693#comment-14625693 ] Bryan Pendleton edited comment on DERBY-6741 at 7/14/15 2:13 AM

Re: DERBY-6801: Feedback on MessageUtils_2.diff

2015-07-13 Thread Bryan Pendleton
is unable to parse carrier.getClass(), am I right ? Also I think I don't understand what would be passed as an argument for the Exception carrier, when getArgumentFerry(SQLException se, Exception carrier) is called ? On Mon, Jul 13, 2015 at 8:23 AM, Bryan Pendleton bpendleton.de...@gmail.com

Re: DERBY-6801: Feedback on MessageUtils_2.diff

2015-07-12 Thread Bryan Pendleton
Now when I included buildSqlerrmc(), It needs StandardException.getArgumentFerry() to be precise. How should we solve this ? Hi Abhinav, Another possibility would be to move StandardException.getArgumentFerry out of StandardException and into MessageUtils. It's not a very complicated

Looks like my ShutdownException change is causing sealing violations

2015-07-12 Thread Bryan Pendleton
I'll have to study this: [junit] Exception in thread Thread-117 java.lang.SecurityException: sealing violation: package org.apache.derby.shared.common.error is sealed [junit] at java.net.URLClassLoader.getAndVerifyPackage(URLClassLoader.java:394) bryan

[jira] [Commented] (DERBY-6741) User code can get the ContextManager from an EmbedConnection

2015-07-12 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624127#comment-14624127 ] Bryan Pendleton commented on DERBY-6741: Thanks Rick. If I can provoke it again

Can the engine detect if it is running under an explicit SecurityManager policy?

2015-07-11 Thread Bryan Pendleton
I'm working on a final fix for DERBY-6807 for SqlXmlUtils, but I'd prefer to make that change conditional, based on whether there is a SecurityManager policy in place for the engine. The reason for that is that if there is a SecurityManager in place, SqlXmlUtils is already fully secure, because

[jira] [Updated] (DERBY-6807) XXE attack possible by using XmlVTI and the XML datatype

2015-07-11 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Pendleton updated DERBY-6807: --- Issue fix info: Patch Available XXE attack possible by using XmlVTI and the XML datatype

[jira] [Commented] (DERBY-6824) Move ShutdownException into shared code area

2015-07-11 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14623473#comment-14623473 ] Bryan Pendleton commented on DERBY-6824: My further testing has revealed

[jira] [Commented] (DERBY-6741) User code can get the ContextManager from an EmbedConnection

2015-07-11 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14623467#comment-14623467 ] Bryan Pendleton commented on DERBY-6741: With OpenJDK 1.8.0_45 running on Fedora22

[jira] [Commented] (DERBY-6801) Implement MessageUtils class so client and server can share message argument encoding/decoding

2015-07-11 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14623474#comment-14623474 ] Bryan Pendleton commented on DERBY-6801: Hi Abhinav, Now that DERBY-6824

Review requested for DERBY-6807 secureXmlVTI.diff

2015-07-11 Thread Bryan Pendleton
Hi Rick (and any others who are interested in the XmlVTI), Can you have a quick peek at DERBY-6807 and the secureXmlVTI.diff patch? thanks, bryan

[jira] [Updated] (DERBY-6807) XXE attack possible by using XmlVTI and the XML datatype

2015-07-11 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Pendleton updated DERBY-6807: --- Attachment: secureXmlVTI.diff Attached secureXmlVTI.diff is my proposed change to make

[jira] [Resolved] (DERBY-6824) Move ShutdownException into shared code area

2015-07-11 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Pendleton resolved DERBY-6824. Resolution: Fixed Assignee: Bryan Pendleton Fix Version/s: 10.12.0.0 Move

[jira] [Commented] (DERBY-6807) XXE attack possible by using XmlVTI and the XML datatype

2015-07-11 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14623476#comment-14623476 ] Bryan Pendleton commented on DERBY-6807: Is XmlVTI documented anywhere in our

Re: DERBY-6801: Feedback on MessageUtils_2.diff

2015-07-11 Thread Bryan Pendleton
MessageUtils needs StandardException.getArgumentFerry() to be precise. How should we solve this ? Hi Abhinav, I wonder if we can handle this by introducing a new interface class. Something like: interface ExceptionCarrier { public static Exception getArgumentFerry(

[jira] [Commented] (DERBY-6826) SOA PROD - The state of datasource DifJavaDbDataSource, application domain-level is Suspended.

2015-07-08 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14619694#comment-14619694 ] Bryan Pendleton commented on DERBY-6826: In your derby.log is this exception

[jira] [Commented] (DERBY-6825) Add basic JSON support to Derby.

2015-07-08 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14619699#comment-14619699 ] Bryan Pendleton commented on DERBY-6825: They both sound like interesting bits

Re: Ancient history: question about some mysterious code in MessageService.java

2015-07-05 Thread Bryan Pendleton
Thanks Rick, for the pointers and ideas. In the code block which you are studying, the message formatting logic responds to the ShutdownException by falling through to its last chance handler. Do you think it should do something else? No, I don't propose to change its behavior, just to

[jira] [Commented] (DERBY-6801) Implement MessageUtils class so client and server can share message argument encoding/decoding

2015-07-05 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614373#comment-14614373 ] Bryan Pendleton commented on DERBY-6801: I filed DERBY-6824 to track the idea

[jira] [Updated] (DERBY-6824) Move ShutdownException into shared code area

2015-07-05 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Pendleton updated DERBY-6824: --- Attachment: refactor.diff Attached 'refactor.diff' is the proposed modification

[jira] [Created] (DERBY-6824) Move ShutdownException into shared code area

2015-07-05 Thread Bryan Pendleton (JIRA)
Bryan Pendleton created DERBY-6824: -- Summary: Move ShutdownException into shared code area Key: DERBY-6824 URL: https://issues.apache.org/jira/browse/DERBY-6824 Project: Derby Issue Type

Ancient history: question about some mysterious code in MessageService.java

2015-07-04 Thread Bryan Pendleton
I've been digging into o.a.d.iapi.services.i18n.MessageService.java. Going all the way back to the original code import (revision 37083), MessageService.getLocalizedMessage() contains this bit of code: try { msg[0] =

[jira] [Created] (DERBY-6823) Refactor uses of DB2_JCC_MAX_EXCEPTION_PARAM_LENGTH

2015-07-04 Thread Bryan Pendleton (JIRA)
Bryan Pendleton created DERBY-6823: -- Summary: Refactor uses of DB2_JCC_MAX_EXCEPTION_PARAM_LENGTH Key: DERBY-6823 URL: https://issues.apache.org/jira/browse/DERBY-6823 Project: Derby Issue

DERBY-6801: Feedback on MessageUtils_2.diff

2015-07-04 Thread Bryan Pendleton
Hi Abhinav, I spent some time thinking about MessageUtils_2.diff. I'd like to see us refine this still further, because I think we want to avoid moving many of these other classes into the shared area wholesale. In most of these cases, I think we can refine things and make a smaller and more

[jira] [Commented] (DERBY-6801) Implement MessageUtils class so client and server can share message argument encoding/decoding

2015-07-04 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14613967#comment-14613967 ] Bryan Pendleton commented on DERBY-6801: The MessageUtils_2.diff patch compiles

[jira] [Commented] (DERBY-6801) Implement MessageUtils class so client and server can share message argument encoding/decoding

2015-07-03 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14613526#comment-14613526 ] Bryan Pendleton commented on DERBY-6801: Yes, that part of our process is a bit

[jira] [Updated] (DERBY-6801) Implement MessageUtils class so client and server can share message argument encoding/decoding

2015-07-02 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Pendleton updated DERBY-6801: --- Attachment: build.out Hi Abhinav, thanks for the latest patch. The code looks much cleaner

[jira] [Updated] (DERBY-6810) Add regression tests for XXE vulnerability

2015-06-30 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Pendleton updated DERBY-6810: --- Attachment: vtiTests2.diff vtiTests2.diff seems to pass on the platforms I have access

[jira] [Commented] (DERBY-6801) Implement MessageUtils class so client and server can share message argument encoding/decoding

2015-06-30 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14609417#comment-14609417 ] Bryan Pendleton commented on DERBY-6801: I see what you mean; this is a little bit

[jira] [Created] (DERBY-6821) Include XMLOptimizerTraceTest in XMLSuite

2015-06-29 Thread Bryan Pendleton (JIRA)
Bryan Pendleton created DERBY-6821: -- Summary: Include XMLOptimizerTraceTest in XMLSuite Key: DERBY-6821 URL: https://issues.apache.org/jira/browse/DERBY-6821 Project: Derby Issue Type: Sub

[jira] [Resolved] (DERBY-6820) Improve error handling in XmlVTI

2015-06-29 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Pendleton resolved DERBY-6820. Resolution: Fixed Fix Version/s: 10.12.0.0 Committed revision 1688297. Improve

Re: XmlVTI.next() invocation of printStackTrace()

2015-06-28 Thread Bryan Pendleton
This method in XmlVTI is causing me a bit of a problem: Thanks Kristian, Mike, and Rick! This seems worth improving, so I filed DERBY-6820 and will follow-up. bryan

[jira] [Created] (DERBY-6820) Improve error handling in XmlVTI

2015-06-28 Thread Bryan Pendleton (JIRA)
Bryan Pendleton created DERBY-6820: -- Summary: Improve error handling in XmlVTI Key: DERBY-6820 URL: https://issues.apache.org/jira/browse/DERBY-6820 Project: Derby Issue Type: Sub-task

[jira] [Updated] (DERBY-6820) Improve error handling in XmlVTI

2015-06-28 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Pendleton updated DERBY-6820: --- Attachment: errorHandling.diff errorHandling.diff contains the proposed error handling

[jira] [Commented] (DERBY-6783) WHEN clause in CREATE TRIGGER for UPDATE is not working for the sql script below

2015-06-28 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14604893#comment-14604893 ] Bryan Pendleton commented on DERBY-6783: This patch seems to be working well

[jira] [Commented] (DERBY-6807) XXE attack possible by using XmlVTI and the XML datatype

2015-06-28 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14604930#comment-14604930 ] Bryan Pendleton commented on DERBY-6807: While continuing to research this issue I

[jira] [Updated] (DERBY-6810) Add regression tests for XXE vulnerability

2015-06-27 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Pendleton updated DERBY-6810: --- Attachment: vtiTests.diff Attached vtiTests.diff contains XmlVTI variants on the file access

[jira] [Commented] (DERBY-6807) XXE attack possible by using XmlVTI and the XML datatype

2015-06-27 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14604330#comment-14604330 ] Bryan Pendleton commented on DERBY-6807: I propose to do the following to resolve

XmlVTI.next() invocation of printStackTrace()

2015-06-27 Thread Bryan Pendleton
This method in XmlVTI is causing me a bit of a problem: public boolean next() throws SQLException { try { if ( _rowIdx 0 ) { readRows(); } if ( ++_rowIdx _rowCount ) { parseRow( _rowIdx ); return true;

Re: [jira] [Updated] (DERBY-6783) WHEN clause in CREATE TRIGGER for UPDATE is not working for the sql script below

2015-06-26 Thread Bryan Pendleton
The changes you suggested fixes the Derby5578 test. I've changed the return type of examineTriggerNode to int[] and I've run quite a few test suites without encountering any bugs. Wonderful! The problem that I was facing while running the tests suites was because of the junit-html in the

[jira] [Commented] (DERBY-6807) XXE attack possible by using XmlVTI and the XML datatype

2015-06-24 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14599453#comment-14599453 ] Bryan Pendleton commented on DERBY-6807: I believe that using a properly

Re: Class not found error while creating Derby Context Aware Function with ClientDataSource driver

2015-06-24 Thread Bryan Pendleton
Caused by: java.sql.SQLSyntaxErrorException: The class 'test.vti.VTITest' does not exist or is inaccessible. Is this a class that you wrote? What is the context aware function that you are trying to create? Can you use the 'derby.log' on your Derby server to isolate the specific SQL

[jira] [Commented] (DERBY-6810) Add regression tests for XXE vulnerability

2015-06-24 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600651#comment-14600651 ] Bryan Pendleton commented on DERBY-6810: An example of how to exercise XmlVTI can

[jira] [Commented] (DERBY-2245) DatabaseMetaData.getSQLKeywords() contains words that are not keywords in Derby.

2015-06-24 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600636#comment-14600636 ] Bryan Pendleton commented on DERBY-2245: Those 5 keywords are all part

[jira] [Issue Comment Deleted] (DERBY-6810) Add regression tests for XXE vulnerability

2015-06-24 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Pendleton updated DERBY-6810: --- Comment: was deleted (was: An example of how to exercise XmlVTI can be found

[jira] [Commented] (DERBY-2245) DatabaseMetaData.getSQLKeywords() contains words that are not keywords in Derby.

2015-06-24 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14599708#comment-14599708 ] Bryan Pendleton commented on DERBY-2245: Can you be as specific as possible? Which

[jira] [Commented] (DERBY-6810) Add regression tests for XXE vulnerability

2015-06-24 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600650#comment-14600650 ] Bryan Pendleton commented on DERBY-6810: An example of how to exercise XmlVTI can

[jira] [Commented] (DERBY-6783) WHEN clause in CREATE TRIGGER for UPDATE is not working for the sql script below

2015-06-23 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14597992#comment-14597992 ] Bryan Pendleton commented on DERBY-6783: Yes, this particular test is exercising

Re: [jira] [Updated] (DERBY-6783) WHEN clause in CREATE TRIGGER for UPDATE is not working for the sql script below

2015-06-23 Thread Bryan Pendleton
Hi Abhinav, I played around with TriggerTest.testDerby5578InvalidateAllStatementsProc() for a while. It seems like this test forces us through a slightly different code path with respect to how we call DataDictionaryImpl.getTriggerActionString(). The trigger we are working with in that test

[jira] [Updated] (DERBY-6783) WHEN clause in CREATE TRIGGER for UPDATE is not working for the sql script below

2015-06-21 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Pendleton updated DERBY-6783: --- Attachment: error-stacktrace.out With the latest patch I get an error

[jira] [Updated] (DERBY-6810) Add regression tests for XXE vulnerability

2015-06-21 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Pendleton updated DERBY-6810: --- Attachment: error-stacktrace.out Attached is the error I get when running XMLXXETest on Linux

[jira] [Commented] (DERBY-6810) Add regression tests for XXE vulnerability

2015-06-21 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14595189#comment-14595189 ] Bryan Pendleton commented on DERBY-6810: It seems that, if I remove

[jira] [Updated] (DERBY-6783) WHEN clause in CREATE TRIGGER for UPDATE is not working for the sql script below

2015-06-21 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Pendleton updated DERBY-6783: --- Attachment: cleanedUpDiff.patch I realize that I suggested on the derby-dev list that we take

[jira] [Updated] (DERBY-6783) WHEN clause in CREATE TRIGGER for UPDATE is not working for the sql script below

2015-06-18 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Pendleton updated DERBY-6783: --- Attachment: 6783_moreTests_bryan.diff Slightly-tweaked copy of 6783_moreTests.diff; see

[jira] [Commented] (DERBY-6810) Add regression tests for XXE vulnerability

2015-06-18 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14592904#comment-14592904 ] Bryan Pendleton commented on DERBY-6810: It looks like the XMLXXETest test suite

Re: [jira] [Updated] (DERBY-6783) WHEN clause in CREATE TRIGGER for UPDATE is not working for the sql script below

2015-06-18 Thread Bryan Pendleton
Hi Abhinav, I found a bit of time to experiment some more with your patch. The additional tests you have added are very interesting, thank you very much for constructing them! I am a bit uncertain about the new method you added: DataDictionaryImpl.sortTriggerColsAndTriggerActionCols()

Re: [jira] [Updated] (DERBY-6783) WHEN clause in CREATE TRIGGER for UPDATE is not working for the sql script below

2015-06-18 Thread Bryan Pendleton
I've edited the large inline comments in the latest patch. And added a few more tests. Hi Abhinav, Thanks for the updated patch! It seems you've made quite a bit of progress. I'll try to dig into your patch in more detail soon, but it may be a couple days until I can get to it, because I

[jira] [Commented] (DERBY-6810) Add regression tests for XXE vulnerability

2015-06-17 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590877#comment-14590877 ] Bryan Pendleton commented on DERBY-6810: I tried several experimental changes

[jira] [Commented] (DERBY-6810) Add regression tests for XXE vulnerability

2015-06-17 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590905#comment-14590905 ] Bryan Pendleton commented on DERBY-6810: Oh! In number (3) above, I had a double

[jira] [Updated] (DERBY-6807) XXE attack possible by using XmlVTI and the XML datatype

2015-06-17 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Pendleton updated DERBY-6807: --- Attachment: externalGeneralEntities.diff I ran a set of tests (tests.lang._Suite

Re: Need help understanding how ContextManager.cleanupOnError could create a 835MB errorStringBuilder

2015-06-17 Thread Bryan Pendleton
I am also a little concerned by the “forever” loop within the ContextManager.cleanupOnError. I wish I could give you more help. About all I can say is: that is some old, old code, and I don't recall it being a problem. That doesn't mean it has no bugs, but I definitely don't know of any.

[jira] [Reopened] (DERBY-6810) Add regression tests for XXE vulnerability

2015-06-17 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Pendleton reopened DERBY-6810: After further study, I realize that the new tests in XMLXXETest exercise the built-in Derby XML

Re: [jira] [Updated] (DERBY-6783) WHEN clause in CREATE TRIGGER for UPDATE is not working for the sql script below

2015-06-17 Thread Bryan Pendleton
I was trying to understand the truncation error, I changed the values of the field marks1 and marks2 in the derbyTest-6783_1 and that '20' is basically the value of the integer field marks1 that I think is being cast as a char value. But I haven't been able to track where this error is

[jira] [Resolved] (DERBY-6810) Add regression tests for XXE vulnerability

2015-06-13 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Pendleton resolved DERBY-6810. Resolution: Fixed I believe we've added the regression tests we planned to add. If more

Re: build failure because of jardriftcheck

2015-06-12 Thread Bryan Pendleton
I noticed a recent commit caused a build failure in the jardriftcheck. Hi Myrna, Thanks for noticing this. I think the problem is that I updated sane.derbyTesting.jar.lastcontents, but didn't update insane.derbyTesting.jar.lastcontents (oops). But if this check is too much work to run on

[jira] [Commented] (DERBY-6818) java.lang.OutOfMemoryError

2015-06-11 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14581990#comment-14581990 ] Bryan Pendleton commented on DERBY-6818: For this particular query, what if you

[jira] [Commented] (DERBY-6818) java.lang.OutOfMemoryError

2015-06-11 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14581947#comment-14581947 ] Bryan Pendleton commented on DERBY-6818: Thanks for the additional data. If ID

[jira] [Comment Edited] (DERBY-6818) java.lang.OutOfMemoryError

2015-06-11 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14581947#comment-14581947 ] Bryan Pendleton edited comment on DERBY-6818 at 6/11/15 2:03 PM

Re: DERBY-6873

2015-06-11 Thread Bryan Pendleton
I was hoping if you could give a feedback on the progress Hi Abhinav, In addition to the notes I posted on JIRA, here's a few other things: 1) I'd like to look for an alternate way to code the handling of the cols variable. I think it's not the best technique to convert the array of

[jira] [Updated] (DERBY-6783) WHEN clause in CREATE TRIGGER for UPDATE is not working for the sql script below

2015-06-11 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Pendleton updated DERBY-6783: --- Attachment: 6783_newTest_bryan.diff Hi Abhinav, I spent some time today studying your latest

[jira] [Resolved] (DERBY-6817) Cannot stop Query

2015-06-10 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Pendleton resolved DERBY-6817. Resolution: Duplicate Duplicate of DERBY-3908 Cannot stop Query

[jira] [Commented] (DERBY-6818) java.lang.OutOfMemoryError

2015-06-10 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14580563#comment-14580563 ] Bryan Pendleton commented on DERBY-6818: To clarify: It was the ALTER TABLE

[jira] [Commented] (DERBY-6810) Add regression tests for XXE vulnerability

2015-06-10 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14581364#comment-14581364 ] Bryan Pendleton commented on DERBY-6810: This page, which discusses non-Java XML

[jira] [Commented] (DERBY-6810) Add regression tests for XXE vulnerability

2015-06-10 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14581363#comment-14581363 ] Bryan Pendleton commented on DERBY-6810: Here is a bit of documentation about

Re: [jira] [Commented] (DERBY-6783) WHEN clause in CREATE TRIGGER for UPDATE is not working for the sql script below

2015-06-08 Thread Bryan Pendleton
I've been looking at the errors in derby.log of TriggerWhenClauseTest. Some of them seem to be syntactical errors I think that's probably expected. A lot of the Derby test suites intentionally submit SQL statements with syntax errors in them (in order to test that the syntax errors are

[jira] [Updated] (DERBY-6810) Add regression tests for XXE vulnerability

2015-06-07 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Pendleton updated DERBY-6810: --- Attachment: readPasswordFile.diff I took Abhinav's file access test from DERBY-6807 and re

[jira] [Commented] (DERBY-6807) XXE attack possible by using XmlVTI and the XML datatype

2015-06-07 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14576345#comment-14576345 ] Bryan Pendleton commented on DERBY-6807: Abhinav, I took your test case and put

Re: [jira] [Commented] (DERBY-6783) WHEN clause in CREATE TRIGGER for UPDATE is not working for the sql script below

2015-06-06 Thread Bryan Pendleton
Hi Abhinav, I'd like to study your latest 6783.diff patch. But when I download it and apply it and do a clean build, I get these errors: compile_types: [javac] Compiling 64 source files to C:\Users\Bryan\derby\trunk\classes [javac]

Re: [jira] [Commented] (DERBY-6783) WHEN clause in CREATE TRIGGER for UPDATE is not working for the sql script below

2015-06-06 Thread Bryan Pendleton
Though I noticed when I clean and apply the correct patch, the build fails while running build_toursdb.sql I'm trying to fix it and I'm attaching this patch as well. Hi Abhinav, No need to be sorry! Thanks for the updated patch. I am able to apply it, and I see the same problem you do; the

Re: [jira] [Commented] (DERBY-6783) WHEN clause in CREATE TRIGGER for UPDATE is not working for the sql script below

2015-06-05 Thread Bryan Pendleton
I tried to refactor getTriggerActionString, the way you suggested. It still doesn't solve the problem. Hi Abhinav, Thanks for attaching your work. I will try to spend some time looking at it this weekend. Please keep us updated as you continue to dig into the code and explore it in more

Re: [jira] [Commented] (DERBY-6783) WHEN clause in CREATE TRIGGER for UPDATE is not working for the sql script below

2015-06-04 Thread Bryan Pendleton
Another thing that I noticed today was, in this loop that is a part of getTriggerActionString for (ColumnReference ref : refs) { TableName tableName = ref.getQualifiedTableName(); int tableBeginOffset = tableName.getBeginOffset() - actionOffset; I suppose

Re: [jira] [Commented] (DERBY-6783) WHEN clause in CREATE TRIGGER for UPDATE is not working for the sql script below

2015-06-02 Thread Bryan Pendleton
I spent quite some time on this bug today and there was a slight problem with my sort function which I corrected, Wonderful! Thank you for the updates. I see that you have attached the new version to DERBY-6783, and I will try to download that to my sandbox and see what behavior I see.

Re: [jira] [Commented] (DERBY-6783) WHEN clause in CREATE TRIGGER for UPDATE is not working for the sql script below

2015-06-02 Thread Bryan Pendleton
Hi Abhinav, I was able to build and run your sort code, and it seemed to be behaving as you expected it to, but the test case still seemed to be generating the wrong code, such that the when clause was accessing the value of the ID column instead of accessing the value of the STATUS column.) I

[jira] [Commented] (DERBY-6807) XXE attack possible by using XmlVTI and the XML datatype

2015-06-01 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14568473#comment-14568473 ] Bryan Pendleton commented on DERBY-6807: I changed line 96

[jira] [Commented] (DERBY-6813) Undocumented ON DELETE SET DEFAULT is parsed, accepted, but not enforced

2015-05-31 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1452#comment-1452 ] Bryan Pendleton commented on DERBY-6813: Often, but not always, situations like

[jira] [Updated] (DERBY-6807) XXE attack possible by using XmlVTI and the XML datatype

2015-05-31 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Pendleton updated DERBY-6807: --- Attachment: error-stacktrace.out XXE attack possible by using XmlVTI and the XML datatype

[jira] [Commented] (DERBY-6807) XXE attack possible by using XmlVTI and the XML datatype

2015-05-31 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14566855#comment-14566855 ] Bryan Pendleton commented on DERBY-6807: The 'database not found' message

[jira] [Commented] (DERBY-6783) WHEN clause in CREATE TRIGGER for UPDATE is not working for the sql script below

2015-05-29 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14565214#comment-14565214 ] Bryan Pendleton commented on DERBY-6783: Here's a workaround: If the trigger

[jira] [Commented] (DERBY-4003) Allow user-defined functions in GROUP BY expressions

2015-05-29 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-4003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14565065#comment-14565065 ] Bryan Pendleton commented on DERBY-4003: Does this help at all? http

[jira] [Commented] (DERBY-6783) WHEN clause in CREATE TRIGGER for UPDATE is not working for the sql script below

2015-05-29 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14565277#comment-14565277 ] Bryan Pendleton commented on DERBY-6783: My theory is that the root cause

[jira] [Commented] (DERBY-6783) WHEN clause in CREATE TRIGGER for UPDATE is not working for the sql script below

2015-05-28 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564136#comment-14564136 ] Bryan Pendleton commented on DERBY-6783

Re: Sourceforce has a mirror of the Derby releases?

2015-05-28 Thread Bryan Pendleton
I don't think so, at least as far as I know no one discussed setting this up Thanks Myrna. I did a bit more research, and I think SourceForge set this up on their own. I don't actually see any harm in SourceForge having additional mirrors of our releases, and in fact they are precise copies of

[jira] [Commented] (DERBY-6801) Implement MessageUtils class so client and server can share message argument encoding/decoding

2015-05-27 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560974#comment-14560974 ] Bryan Pendleton commented on DERBY-6801: Although this is a separate task, and we

Re: [jira] [Commented] (DERBY-6783) WHEN clause in CREATE TRIGGER for UPDATE is not working for the sql script below

2015-05-27 Thread Bryan Pendleton
On 5/27/2015 1:14 PM, Abhinav Gupta wrote: Hi Bryan, I had put a few print statements in CreateTriggerNode.java to look at the values when the trigger node is created, it didn't help me much. So I looked for the piece of code that is responsible for firing the trigger based on the event, I

<    7   8   9   10   11   12   13   14   15   16   >