[GitHub] accumulo issue #32: Accumulo 3652 Refactor for slf4j string substitution. Re...

2017-08-25 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/accumulo/pull/32 Once we switch to GitBox, we should just close this issue, and work from the rebase'd version, rather than try to merge and update this PR. You don't actually want to merge, anyway, th

[GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...

2017-08-16 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/292#discussion_r133582097 --- Diff: core/src/test/java/org/apache/accumulo/core/client/impl/NamespaceTest.java --- @@ -17,38 +17,73 @@ package

[GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...

2017-08-16 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/292#discussion_r133582940 --- Diff: core/src/test/java/org/apache/accumulo/core/client/impl/NamespaceTest.java --- @@ -17,38 +17,73 @@ package

[GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...

2017-08-16 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/292#discussion_r133582248 --- Diff: core/src/test/java/org/apache/accumulo/core/client/impl/NamespaceTest.java --- @@ -17,38 +17,73 @@ package

[GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...

2017-08-16 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/292#discussion_r133536502 --- Diff: server/master/src/main/java/org/apache/accumulo/master/tableOps/Utils.java --- @@ -59,21 +57,16 @@ static void checkTableDoesNotExist(Instance

[GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...

2017-08-15 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/292#discussion_r13368 --- Diff: core/src/main/java/org/apache/accumulo/core/data/impl/KeyExtent.java --- @@ -173,9 +154,9 @@ public KeyExtent(Text flattenedExtent, Text

[GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...

2017-08-15 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/292#discussion_r15412 --- Diff: server/master/src/main/java/org/apache/accumulo/master/tableOps/Utils.java --- @@ -59,21 +57,16 @@ static void checkTableDoesNotExist(Instance

[GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...

2017-08-15 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/292#discussion_r14428 --- Diff: core/src/test/java/org/apache/accumulo/core/client/impl/NamespaceTest.java --- @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software

[GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...

2017-08-15 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/292#discussion_r15283 --- Diff: server/master/src/main/java/org/apache/accumulo/master/tableOps/Utils.java --- @@ -59,21 +57,16 @@ static void checkTableDoesNotExist(Instance

[GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...

2017-08-15 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/292#discussion_r13221 --- Diff: core/src/main/java/org/apache/accumulo/core/data/impl/KeyExtent.java --- @@ -60,28 +58,11 @@ public class KeyExtent implements

[GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...

2017-08-15 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/292#discussion_r13657 --- Diff: core/src/test/java/org/apache/accumulo/core/client/impl/NamespaceTest.java --- @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software

[GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...

2017-08-15 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/292#discussion_r13957 --- Diff: core/src/test/java/org/apache/accumulo/core/client/impl/NamespaceTest.java --- @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software

[GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...

2017-08-15 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/292#discussion_r13857 --- Diff: core/src/test/java/org/apache/accumulo/core/client/impl/NamespaceTest.java --- @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software

[GitHub] accumulo pull request #291: ACCUMULO-4693: Add instance-specific ProcessName...

2017-08-14 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/291#discussion_r133086736 --- Diff: server/base/src/main/java/org/apache/accumulo/server/metrics/MetricsSystemHelper.java --- @@ -16,20 +16,65 @@ */ package

[GitHub] accumulo pull request #291: ACCUMULO-4693: Add instance-specific ProcessName...

2017-08-14 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/291#discussion_r133086488 --- Diff: server/base/src/main/java/org/apache/accumulo/server/metrics/MetricsSystemHelper.java --- @@ -16,20 +16,65 @@ */ package

[GitHub] accumulo pull request #291: ACCUMULO-4693: Add instance-specific ProcessName...

2017-08-14 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/291#discussion_r133086237 --- Diff: server/base/src/main/java/org/apache/accumulo/server/metrics/MetricsSystemHelper.java --- @@ -16,20 +16,65 @@ */ package

[GitHub] accumulo issue #292: ACCUMULO-4681 Created Table & Namespace WeakReference m...

2017-08-14 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/accumulo/pull/292 This whole thing might be easier to implement with [`CacheBuilder.weakValues()`][1] from Guava. Eviction seems to occur if value disappears. I **think** this will do what we want, and it should

[GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...

2017-08-14 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/292#discussion_r133070150 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/Table.java --- @@ -16,24 +16,59 @@ */ package

[GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...

2017-08-14 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/292#discussion_r133068592 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/Table.java --- @@ -16,24 +16,59 @@ */ package

[GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...

2017-08-14 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/292#discussion_r133059580 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/Table.java --- @@ -16,24 +16,59 @@ */ package

[GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...

2017-08-12 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/292#discussion_r132825421 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/Table.java --- @@ -16,24 +16,59 @@ */ package

[GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...

2017-08-12 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/292#discussion_r132825236 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/Table.java --- @@ -16,24 +16,59 @@ */ package

[GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...

2017-08-12 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/292#discussion_r132823444 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/Table.java --- @@ -16,24 +16,59 @@ */ package

[GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...

2017-08-12 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/292#discussion_r132822652 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/Table.java --- @@ -16,24 +16,59 @@ */ package

[GitHub] accumulo pull request #291: ACCUMULO-4693: Add instance-specific ProcessName...

2017-08-10 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/291#discussion_r132548358 --- Diff: server/base/src/main/java/org/apache/accumulo/server/metrics/MetricsSystemHelper.java --- @@ -16,20 +16,65 @@ */ package

[GitHub] accumulo pull request #291: ACCUMULO-4693: Add instance-specific ProcessName...

2017-08-10 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/291#discussion_r132547783 --- Diff: server/base/src/main/java/org/apache/accumulo/server/metrics/MetricsSystemHelper.java --- @@ -16,20 +16,65 @@ */ package

[GitHub] accumulo pull request #291: ACCUMULO-4693: Add instance-specific ProcessName...

2017-08-10 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/291#discussion_r132547937 --- Diff: server/base/src/main/java/org/apache/accumulo/server/metrics/MetricsSystemHelper.java --- @@ -16,20 +16,65 @@ */ package

[GitHub] accumulo pull request #289: ACCUMULO-4677 Sanitizing PathParam values in RES...

2017-08-09 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/289#discussion_r132247035 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/trace/TracesResource.java --- @@ -77,12 +81,12 @@ * Generates a trace

[GitHub] accumulo pull request #289: ACCUMULO-4677 Sanitizing PathParam values in RES...

2017-08-08 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/289#discussion_r132070673 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/trace/TracesResource.java --- @@ -77,12 +81,12 @@ * Generates a trace

[GitHub] accumulo pull request #289: ACCUMULO-4677 Sanitizing PathParam values in RES...

2017-08-08 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/289#discussion_r132053160 --- Diff: server/monitor/pom.xml --- @@ -45,6 +45,10 @@ javax.servlet-api + javax.validation + validation

[GitHub] accumulo pull request #289: ACCUMULO-4677 Sanitizing PathParam values in RES...

2017-08-08 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/289#discussion_r132055156 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/util/ParameterValidator.java --- @@ -0,0 +1,48 @@ +/* + * Licensed to the

[GitHub] accumulo pull request #289: ACCUMULO-4677 Sanitizing PathParam values in RES...

2017-08-08 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/289#discussion_r132053915 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/tables/TablesResource.java --- @@ -65,6 +69,7 @@ public class

[GitHub] accumulo pull request #289: ACCUMULO-4677 Sanitizing PathParam values in RES...

2017-08-08 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/289#discussion_r132053484 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/problems/ProblemsResource.java --- @@ -96,9 +98,13 @@ public ProblemSummary

[GitHub] accumulo pull request #289: ACCUMULO-4677 Sanitizing PathParam values in RES...

2017-08-08 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/289#discussion_r132054933 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/util/ParameterValidator.java --- @@ -0,0 +1,48 @@ +/* + * Licensed to the

[GitHub] accumulo pull request #289: ACCUMULO-4677 Sanitizing PathParam values in RES...

2017-08-08 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/289#discussion_r132054185 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/trace/TracesResource.java --- @@ -77,12 +81,12 @@ * Generates a trace

[GitHub] accumulo issue #291: ACCUMULO-4693: Add instance-specific ProcessName to Had...

2017-08-08 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/accumulo/pull/291 @billoley I had forgotten that we already define `accumulo.application` system property (optional) in master for the AccumuloMonitorAppender. I suppose it's not so bad if we consistently use

[GitHub] accumulo issue #291: ACCUMULO-4693: Add instance-specific ProcessName to Had...

2017-08-07 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/accumulo/pull/291 @billoley What about just including all system properties, so it still supports this use case, but the code isn't tied to a specific launch script implementation? Is it possible to pick out

[GitHub] accumulo issue #253: ACCUMULO-4086 Improve volume chooser fallback

2017-08-03 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/accumulo/pull/253 I rebase'd again, and updated to add an enum for scopes and to simplify VolumeChooserEnvironment a bit. Other work that needs to be completed: * per-table scope needs to use the

[GitHub] accumulo issue #289: ACCUMULO-4677 Sanitizing PathParam values in REST-based...

2017-08-03 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/accumulo/pull/289 Oh, nice! Thanks for working on this @glitch ; I took a brief look and I think this is basically what we need. I didn't do a thorough review, though. I'll try to get to that soon, if n

[GitHub] accumulo issue #288: ACCUMULO-3283 MetadataTableUtil.getTabletEntries create...

2017-08-01 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/accumulo/pull/288 Thanks for the contribution, @d-hwang . I applied your change, backported to 1.7 branch. If you're not already mentioned on our https://accumulo.apache.org/people page and you wish

[GitHub] accumulo issue #285: Fixes ACCUMULO-4555 treat Version as a simple string

2017-08-01 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/accumulo/pull/285 @glitch If you'd like to be added to https://accumulo.apache.org/people/ , please provide details you want listed here, or perform a pull request to https://github.com/apache/accumulo-we

[GitHub] accumulo issue #287: ACCUMULO-4688 Turn off autocomplete for the ShellServle...

2017-08-01 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/accumulo/pull/287 This also undermines user's use of password managers for improved security. Saved passwords in secure password managers is a good thing for web security. We don't want to discourage t

[GitHub] accumulo issue #287: ACCUMULO-4688 Turn off autocomplete for the ShellServle...

2017-08-01 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/accumulo/pull/287 Why impose this inconvenience on users? Shouldn't users decide which client-side features to use themselves? Also, this servlet is removed in the master branch. This would only negatively a

[GitHub] accumulo issue #288: ACCUMULO-3283 MetadataTableUtil.getTabletEntries create...

2017-08-01 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/accumulo/pull/288 @d-hwang There's a work-related problem regarding your contribution. Please contact me. ctubbsii at apache is fine, or Google Hangouts, same user, gmail domain. --- If your project is s

[GitHub] accumulo issue #288: ACCUMULO-3283 MetadataTableUtil.getTabletEntries create...

2017-08-01 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/accumulo/pull/288 Thanks @d-hwang. Merging in progress... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] accumulo issue #285: Fixes ACCUMULO-4555 treat Version as a simple string

2017-07-31 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/accumulo/pull/285 @joshelser Should we apply to previous branches, or just master? Is this biting you in previous release lines? --- If your project is set up for it, you can reply to this email and have your

[GitHub] accumulo pull request #285: Fixes ACCUMULO-4555 treat Version as a simple st...

2017-07-31 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/285#discussion_r130346697 --- Diff: core/src/main/java/org/apache/accumulo/core/util/Version.java --- @@ -53,74 +56,13 @@ public void execute(final String[] args) throws Exception

[GitHub] accumulo pull request #285: Fixes ACCUMULO-4555 treat Version as a simple st...

2017-07-31 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/285#discussion_r130330269 --- Diff: core/src/main/java/org/apache/accumulo/core/util/Version.java --- @@ -53,74 +56,13 @@ public void execute(final String[] args) throws Exception

[GitHub] accumulo pull request #253: ACCUMULO-4086 Improve volume chooser fallback

2017-07-28 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/253#discussion_r130191638 --- Diff: server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java --- @@ -18,61 +18,146 @@ import

[GitHub] accumulo pull request #253: ACCUMULO-4086 Improve volume chooser fallback

2017-07-28 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/253#discussion_r130157740 --- Diff: server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java --- @@ -18,61 +18,146 @@ import

[GitHub] accumulo pull request #283: ACCUMULO-4687 Clean up some static-analysis warn...

2017-07-27 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/283#discussion_r129978175 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/BasicServlet.java --- @@ -264,4 +264,12 @@ protected static void banner

[GitHub] accumulo pull request #253: ACCUMULO-4086 Improve volume chooser fallback

2017-07-27 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/253#discussion_r129972561 --- Diff: test/src/main/java/org/apache/accumulo/test/VolumeChooserFailureIT.java --- @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software

[GitHub] accumulo pull request #253: ACCUMULO-4086 Improve volume chooser fallback

2017-07-27 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/253#discussion_r129969952 --- Diff: server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java --- @@ -28,5 +29,5 @@ * benefit from using per-table

[GitHub] accumulo pull request #253: ACCUMULO-4086 Improve volume chooser fallback

2017-07-27 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/253#discussion_r129968372 --- Diff: server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java --- @@ -18,61 +18,146 @@ import

[GitHub] accumulo pull request #253: ACCUMULO-4086 Improve volume chooser fallback

2017-07-27 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/253#discussion_r129964936 --- Diff: server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java --- @@ -18,61 +18,146 @@ import

[GitHub] accumulo pull request #253: ACCUMULO-4086 Improve volume chooser fallback

2017-07-27 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/253#discussion_r129964201 --- Diff: server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java --- @@ -18,61 +18,146 @@ import

[GitHub] accumulo pull request #253: ACCUMULO-4086 Improve volume chooser fallback

2017-07-27 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/253#discussion_r129963947 --- Diff: server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java --- @@ -18,61 +18,146 @@ import

[GitHub] accumulo pull request #253: ACCUMULO-4086 Improve volume chooser fallback

2017-07-27 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/253#discussion_r129895892 --- Diff: server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java --- @@ -18,61 +18,146 @@ import

[GitHub] accumulo pull request #253: ACCUMULO-4086 Improve volume chooser fallback

2017-07-27 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/253#discussion_r129888546 --- Diff: server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java --- @@ -18,61 +18,146 @@ import

[GitHub] accumulo pull request #253: ACCUMULO-4086 Improve volume chooser fallback

2017-07-27 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/253#discussion_r129914902 --- Diff: server/base/src/main/java/org/apache/accumulo/server/fs/PreferredVolumeChooser.java --- @@ -39,73 +40,139 @@ /** * A {@link

[GitHub] accumulo pull request #253: ACCUMULO-4086 Improve volume chooser fallback

2017-07-27 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/253#discussion_r129889643 --- Diff: server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java --- @@ -18,61 +18,146 @@ import

[GitHub] accumulo pull request #253: ACCUMULO-4086 Improve volume chooser fallback

2017-07-27 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/253#discussion_r129897225 --- Diff: server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java --- @@ -18,61 +18,146 @@ import

[GitHub] accumulo pull request #253: ACCUMULO-4086 Improve volume chooser fallback

2017-07-27 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/253#discussion_r129918169 --- Diff: server/base/src/test/java/org/apache/accumulo/server/fs/VolumeManagerImplTest.java --- @@ -105,7 +115,8 @@ public String choose

[GitHub] accumulo pull request #253: ACCUMULO-4086 Improve volume chooser fallback

2017-07-27 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/253#discussion_r129916561 --- Diff: server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java --- @@ -28,5 +29,5 @@ * benefit from using per-table

[GitHub] accumulo pull request #253: ACCUMULO-4086 Improve volume chooser fallback

2017-07-27 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/253#discussion_r129917175 --- Diff: server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java --- @@ -79,8 +80,15 @@ protected VolumeManagerImpl(Map volumes

[GitHub] accumulo pull request #253: ACCUMULO-4086 Improve volume chooser fallback

2017-07-27 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/253#discussion_r129899084 --- Diff: server/base/src/main/java/org/apache/accumulo/server/fs/PreferredVolumeChooser.java --- @@ -39,73 +40,139 @@ /** * A {@link

[GitHub] accumulo pull request #253: ACCUMULO-4086 Improve volume chooser fallback

2017-07-27 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/253#discussion_r129917588 --- Diff: server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java --- @@ -464,16 +472,22 @@ public ContentSummary

[GitHub] accumulo pull request #253: ACCUMULO-4086 Improve volume chooser fallback

2017-07-27 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/253#discussion_r129895600 --- Diff: server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java --- @@ -18,61 +18,146 @@ import

[GitHub] accumulo pull request #253: ACCUMULO-4086 Improve volume chooser fallback

2017-07-27 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/253#discussion_r129918530 --- Diff: test/src/main/java/org/apache/accumulo/test/VolumeChooserFailureIT.java --- @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software

[GitHub] accumulo pull request #253: ACCUMULO-4086 Improve volume chooser fallback

2017-07-27 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/253#discussion_r129890129 --- Diff: server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java --- @@ -18,61 +18,146 @@ import

[GitHub] accumulo pull request #253: ACCUMULO-4086 Improve volume chooser fallback

2017-07-27 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/253#discussion_r129887994 --- Diff: assemble/conf/accumulo-site.xml --- @@ -39,6 +39,15 @@ tserver.memory.maps.native.enabled true + --- End

[GitHub] accumulo pull request #283: ACCUMULO-4687 Clean up some static-analysis warn...

2017-07-26 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/283#discussion_r129635806 --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BoundedRangeFileInputStream.java --- @@ -95,18 +92,7 @@ public int read(final

[GitHub] accumulo pull request #283: ACCUMULO-4687 Clean up some static-analysis warn...

2017-07-26 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/283#discussion_r129629727 --- Diff: core/src/main/java/org/apache/accumulo/core/util/Jar.java --- @@ -41,8 +41,9 @@ public void execute(final String[] args) throws Exception

[GitHub] accumulo pull request #283: ACCUMULO-4687 Clean up some static-analysis warn...

2017-07-26 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/283#discussion_r129632689 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/BasicServlet.java --- @@ -264,4 +264,12 @@ protected static void banner

[GitHub] accumulo pull request #283: ACCUMULO-4687 Clean up some static-analysis warn...

2017-07-26 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/283#discussion_r129629434 --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BoundedRangeFileInputStream.java --- @@ -95,18 +92,7 @@ public int read(final

[GitHub] accumulo issue #282: Added version to the REST API

2017-07-24 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/accumulo/pull/282 Rebase'd, added test, fixed bugs found by test, and pushed. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] accumulo issue #282: Added version to the REST API

2017-07-24 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/accumulo/pull/282 Actually, upon second thought... I think I have an idea for a reasonable, fast-running test. We can write a test that verifies that the REST POJO is properly constructed from the

[GitHub] accumulo issue #282: Added version to the REST API

2017-07-24 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/accumulo/pull/282 I didn't say I didn't want to have it tested automatically. I just said I'd prefer to have the test coverage more comprehensive. My reasoning is that our current test suite takes

[GitHub] accumulo issue #282: Added version to the REST API

2017-07-24 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/accumulo/pull/282 I think such a test really only verifies that Jackson is working properly. I suppose it's reasonable to write an integration test for the REST API, but it seems to me that should be

[GitHub] accumulo issue #282: Added version to the REST API

2017-07-21 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/accumulo/pull/282 I was just confused about what kind of test you were thinking of, and hoping you could clarify. This change only adds a field to a POJO for the sole purpose of including it in the REST endpoint&#

[GitHub] accumulo issue #282: Added version to the REST API

2017-07-21 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/accumulo/pull/282 @joshelser Are you asking for a test to ensure that Jackson serializes the included value to JSON correctly? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] accumulo pull request #275: ACCUMULO-4667 Reworked the LocalityGroupIterator...

2017-07-19 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/275#discussion_r128375950 --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/system/LocalityGroupIterator.java --- @@ -16,23 +16,28 @@ */ package

[GitHub] accumulo issue #280: Added code to determine Accumulo version from running t...

2017-07-19 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/accumulo/pull/280 Does this change cause the new version field to appear in a REST endpoint anywhere? I don't see any monitor code changes, but if the object is being dumped to JSON, there may not need to b

[GitHub] accumulo issue #200: Accumulo 4558 Added shell command to display server sta...

2017-07-18 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/accumulo/pull/200 Added to ACCUMULO-4558 (https://issues.apache.org/jira/browse/ACCUMULO-4558) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] accumulo issue #200: Accumulo 4558 Added shell command to display server sta...

2017-07-18 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/accumulo/pull/200 @lstav Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] accumulo issue #200: Accumulo 4558 Added shell command to display server sta...

2017-07-18 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/accumulo/pull/200 @lstav I was thinking we could just save the commit as an attachment to the JIRA, for future reference. That way, we're not relying on an old PR if we revisit it, and can move on with anoth

[GitHub] accumulo issue #200: Accumulo 4558 Added shell command to display server sta...

2017-07-18 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/accumulo/pull/200 What @milleruntime was referring to was a conversation with @keith-turner and myself (a small subset of the overall Accumulo "team", but a team in another sense). In that conversat

[GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor

2017-07-11 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/279#discussion_r126765808 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/Namespace.java --- @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software

[GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor

2017-07-11 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/279#discussion_r126763252 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/Table.java --- @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software

[GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor

2017-07-11 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/279#discussion_r126761166 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/AbstractId.java --- @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software

[GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor

2017-07-11 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/279#discussion_r126759594 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/Namespaces.java --- @@ -100,50 +106,150 @@ private static ZooCache getZooCache(Instance

[GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor

2017-07-11 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/279#discussion_r126757396 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/Namespace.java --- @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software

[GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor

2017-07-11 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/279#discussion_r126755633 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/Table.java --- @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software

[GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor

2017-07-11 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/279#discussion_r126755404 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/AbstractId.java --- @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software

[GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor

2017-07-11 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/279#discussion_r126750554 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/Namespaces.java --- @@ -100,50 +106,150 @@ private static ZooCache getZooCache(Instance

[GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor

2017-07-11 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/279#discussion_r126746910 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/AbstractId.java --- @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software

[GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor

2017-07-11 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/279#discussion_r126746697 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/AbstractId.java --- @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software

[GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor

2017-07-11 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/279#discussion_r126745375 --- Diff: core/src/main/java/org/apache/accumulo/core/client/TableOfflineException.java --- @@ -26,7 +27,7 @@ private static String getTableName

[GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor

2017-07-11 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/279#discussion_r126742538 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/Namespaces.java --- @@ -100,50 +106,150 @@ private static ZooCache getZooCache(Instance

[GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor

2017-07-10 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/279#discussion_r126589554 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/AbstractId.java --- @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software

  1   2   3   4   5   6   7   >