Re: cvs commit: apr-util/build rules.mk.in

2000-12-03 Thread rbb
> > > Mandrake is rpm-based: > > > > > > $ rpm -q make bash > > > > > > I think the make version might actually be the most important part. > > > > I know, but I remove all rpm's just after installing Linux, and re-install > > most of the system by hand. I dislike using rpms whenever possible.

SUBDIRS in top-level makefile (was: Re: cvs commit: apr-util/build rules.mk.in)

2000-12-03 Thread Greg Stein
On Sat, Dec 02, 2000 at 04:19:13PM -0800, [EMAIL PROTECTED] wrote: >... > Yep. Quick question for you now, why does the top-level Makefile have: > > SUBDIRS = src . test build > > It seems to me this should be: > > SUBDIRTS = src test > > We aren't building anything in build or . are we? "."

Re: cvs commit: apr/shmem/unix shmem.c

2000-12-03 Thread Sam TH
On Sat, Dec 02, 2000 at 11:45:37PM -, [EMAIL PROTECTED] wrote: > rbb 00/12/02 15:45:37 > > Modified:shmem/unix shmem.c > Log: > Fix a compile break on BeOS and FreeBSD. We don't want to add the size > of the void *, we want to add the size of the apr_shmem_t * variable. W

Re: SUBDIRS in top-level makefile (was: Re: cvs commit: apr-util/build rules.mk.in)

2000-12-03 Thread rbb
> > We aren't building anything in build or . are we? > > "." is there because we build the library. It is ordered after the "src" > subdirectory. > > "build" is there so we can recurse on the various "clean" targets. > > Note that "test" is there primarily for the clean targets, too. We probab

RE: cvs commit: apr STATUS

2000-12-03 Thread William A. Rowe, Jr.
> rbb 00/12/02 19:31:12 > > Modified:.STATUS > Log: > This STATUS item doesn't belong in APR. > >* API documentation > -Status: Ben Laurie has written some hooks documentation > -(apache-2.0/htdocs/hooks.html) Q. Now that APRUTIL exists, m

RE: cvs commit: apr STATUS

2000-12-03 Thread rbb
> >* API documentation > > -Status: Ben Laurie has written some hooks documentation > > -(apache-2.0/htdocs/hooks.html) > > Q. Now that APRUTIL exists, may we please move hooks (a generally useful > entity) into that lib (and put this issue back into util? I thin

RE: cvs commit: apr STATUS

2000-12-03 Thread William A. Rowe, Jr.
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > Sent: Saturday, December 02, 2000 11:19 PM > > > >* API documentation > > > -Status: Ben Laurie has written some hooks documentation > > > -(apache-2.0/htdocs/hooks.html) > > > > Q. Now that APRUTIL exists, may we

Re: cvs commit: apr STATUS

2000-12-03 Thread Greg Stein
On Sat, Dec 02, 2000 at 11:22:54PM -0600, William A. Rowe, Jr. wrote: > > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > > Sent: Saturday, December 02, 2000 11:19 PM > > > > > >* API documentation > > > > -Status: Ben Laurie has written some hooks documentation > > > > -

RE: cvs commit: apr STATUS

2000-12-03 Thread rbb
> > > Q. Now that APRUTIL exists, may we please move hooks (a > > generally useful > > > entity) into that lib (and put this issue back into util? > > > > I think we are just waiting for some people on dev to decide how to move > > the code out of Apache and into apr-utils. Greg and I have

isascii on BeOS PPC

2000-12-03 Thread Sam TH
More fun with the BeOS. First, could someone apply the patch I posted to update the -I directories. Thanks. Second, since Subversion needs isascii() in a few places, I moved the ifdef that makes it work on the BeOS PPC into apr_lib.h (where all the other isascii() stuff is) from networkio.h.

Re: isascii on BeOS PPC

2000-12-03 Thread rbb
First of all, Sam could you please post patches in line? It makes them much easier to reply to. Thanks. Now, quick question. Index: network_io/beos/Makefile.in === RCS file: /home/cvspublic/apr/network_io/beos/Makefile.in,v retrie

Re: isascii on BeOS PPC

2000-12-03 Thread rbb
Second question about this patch, Index: include/apr_lib.h === RCS file: /home/cvspublic/apr/include/apr_lib.h,v retrieving revision 1.44 diff -u -r1.44 apr_lib.h --- include/apr_lib.h 2000/11/26 03:00:01 1.44 +++ include/apr_l

Re: isascii on BeOS PPC

2000-12-03 Thread Sam TH
On Sat, Dec 02, 2000 at 11:33:55PM -0800, [EMAIL PROTECTED] wrote: > > First of all, Sam could you please post patches in line? It makes them > much easier to reply to. Thanks. Sure. Sorry about that. > > Now, quick question. > > Index: network_io/beos/Makefile.in > ===

Re: isascii on BeOS PPC

2000-12-03 Thread Sam TH
On Sat, Dec 02, 2000 at 11:40:37PM -0800, [EMAIL PROTECTED] wrote: > > Second question about this patch, > > Index: include/apr_lib.h > === > RCS file: /home/cvspublic/apr/include/apr_lib.h,v > retrieving revision 1.44 > diff -u -r1.

Re: isascii on BeOS PPC

2000-12-03 Thread Greg Stein
On Sun, Dec 03, 2000 at 02:10:08AM -0600, Sam TH wrote: >... > --- apr_lib.h 2000/11/26 03:00:01 1.44 > +++ apr_lib.h 2000/12/03 08:09:37 > @@ -113,6 +113,9 @@ > #define apr_isdigit(c) (isdigit(((unsigned char)(c > #define apr_isgraph(c) (isgraph(((unsigned char)(c > #define apr_islo

Re: BeOS socket compilation stuff (was: Re: BeOS PPC Compilation Fixes)

2000-12-03 Thread Greg Stein
On Sun, Dec 03, 2000 at 03:39:12AM -0600, Sam TH wrote: > On Sun, Dec 03, 2000 at 01:26:28AM -0800, Greg Stein wrote: > > > > Looks like Ryan is offline, so I'll go and commit the isascii fix. I'm not > > sure on the include header stuff, though, so I'm going to pass that one up. > > Well, if you

Re: isascii on BeOS PPC

2000-12-03 Thread Greg Stein
Applied. Thanks! On Sun, Dec 03, 2000 at 02:10:08AM -0600, Sam TH wrote: >... > --- apr_lib.h 2000/11/26 03:00:01 1.44 > +++ apr_lib.h 2000/12/03 08:09:37 > @@ -113,6 +113,9 @@ > #define apr_isdigit(c) (isdigit(((unsigned char)(c > #define apr_isgraph(c) (isgraph(((unsigned char)(c >

Re: BeOS socket compilation stuff (was: Re: BeOS PPC Compilation Fixes)

2000-12-03 Thread Sam TH
On Sun, Dec 03, 2000 at 02:11:43AM -0800, Greg Stein wrote: > On Sun, Dec 03, 2000 at 03:39:12AM -0600, Sam TH wrote: > > On Sun, Dec 03, 2000 at 01:26:28AM -0800, Greg Stein wrote: > > > > > > Looks like Ryan is offline, so I'll go and commit the isascii fix. I'm not > > > sure on the include hea

Re: BeOS socket compilation stuff

2000-12-03 Thread Greg Stein
Gotcha! The patch to unix/sockaddr.c has been applied (rather than the Makefile.in change) Cheers, -g On Sun, Dec 03, 2000 at 04:52:45AM -0600, Sam TH wrote: >... > Here's the include chain. > > network_io/beos/sockaddr.c > includes > network_io/unix/sockaddr.c > includes > network_io/unix/sa

Re: isascii on BeOS PPC

2000-12-03 Thread Greg Stein
Ryan was discussing how that would be hard to use within apr_lib.h because we'd need to include apr_private.h to get the config variable. etc etc I didn't even know that check was in there, and figured the quick patch was sufficient. Please feel free to fix it: 1) update the #if stuff in apr_li

Re: cvs commit: apr/include apr_lib.h

2000-12-03 Thread Sam TH
On Sun, Dec 03, 2000 at 10:11:43AM -, [EMAIL PROTECTED] wrote: > gstein 00/12/03 02:11:43 > > Modified:include apr_lib.h > Log: > isascii() is not available on PowerPC versions of BeOS. Supply a definition. This still doesn't work. It turns out that neither BEOS nor __POWER_P

Re: cvs commit: apr/include apr_lib.h

2000-12-03 Thread Greg Stein
On Sun, Dec 03, 2000 at 07:42:55AM -0600, Sam TH wrote: > On Sun, Dec 03, 2000 at 10:11:43AM -, [EMAIL PROTECTED] wrote: > > gstein 00/12/03 02:11:43 > > > > Modified:include apr_lib.h > > Log: > > isascii() is not available on PowerPC versions of BeOS. Supply a > > definition

[PATCH] apr_make_os_sock()

2000-12-03 Thread Jeff Trawick
Hopefully I didn't miss any comments on the mailing list last night (where is that archive again?). Here is enough to look at to make sure I didn't screw anything up. I added family and type parameters too so that APR doesn't have to bend over backwards (i.e., use syscalls) to find that out. We

Re: [PATCH] apr_make_os_sock()

2000-12-03 Thread Jeff Trawick
Jeff Trawick <[EMAIL PROTECTED]> writes: > +apr_status_t apr_make_os_sock(apr_socket_t **apr_sock, apr_os_sock_t > *os_sock, > + struct sockaddr *local, struct sockaddr > *remote, > + int family, int type, apr_pool_t *cont) > +{ ... > +

Re: cvs commit: apr/include apr_lib.h

2000-12-03 Thread David Reid
> Don't worry about it... we'll get a solution worked out. I got the > impression David was looking into it :-) I've just committed a patch that should fix this. If we don't have isascii we don't really need to define it as we'll just hide it in apr_isascii, so we just define apr_isascii accordin

Re: isascii on BeOS PPC

2000-12-03 Thread rbb
> > First of all, Sam could you please post patches in line? It makes them > > much easier to reply to. Thanks. > > Sure. Sorry about that. No problem, information like this needs to go on the site, I'll try to update it all today. :-) > > INCDIR=../../include > > OSDIR=$(INCDIR)/arch/@O

Re: cvs commit: apr/include apr_lib.h

2000-12-03 Thread David Reid
Sam, can you cvs update and try the fix I committed? Thanks. david

Re: cvs commit: apr/include apr_lib.h

2000-12-03 Thread rbb
> This still doesn't work. It turns out that neither BEOS nor > __POWER_PC__ is defined at the point in Subversion that this gets used > and likely not in other APR-using apps either. So, new patch, using > HAVE_isascii, which doesn't require including apr_private.h, despite > Ryan's worry. Als

Re: cvs commit: apr/include apr_lib.h

2000-12-03 Thread Sam TH
On Sun, Dec 03, 2000 at 04:08:50PM -, David Reid wrote: > Sam, can you cvs update and try the fix I committed? Thanks. > Looks like it works. So APR appears not to have any obvious difficulties on my end. :-) Thanks lots sam th [EMAIL PROTECTED]

Re: cvs commit: apr/include apr_lib.h

2000-12-03 Thread rbb
On Sun, 3 Dec 2000, Sam TH wrote: > On Sun, Dec 03, 2000 at 04:08:50PM -, David Reid wrote: > > Sam, can you cvs update and try the fix I committed? Thanks. > > > > Looks like it works. So APR appears not to have any obvious > difficulties on my end. :-) Great! Can you try running the t

Re: [PATCH] apr_make_os_sock()

2000-12-03 Thread rbb
On Sun, 3 Dec 2000, Jeff Trawick wrote: > Hopefully I didn't miss any comments on the mailing list last night > (where is that archive again?). > > Here is enough to look at to make sure I didn't screw anything up. I > added family and type parameters too so that APR doesn't have to bend > over

Re: cvs commit: apr/include apr_lib.h

2000-12-03 Thread Sam TH
On Sun, Dec 03, 2000 at 08:21:35AM -0800, [EMAIL PROTECTED] wrote: > > > This still doesn't work. It turns out that neither BEOS nor > > __POWER_PC__ is defined at the point in Subversion that this gets used > > and likely not in other APR-using apps either. So, new patch, using > > HAVE_isascii

Re: cvs commit: apr/include apr_lib.h

2000-12-03 Thread David Reid
Well I knew that was coming :) There are a few problems with some of the test programs but as they've been so low on the priority list of things to do I haven't fixed them for BeOS. Looks like I'll have to get to them now doesn't it? :) david

Re: cvs commit: apr/include apr_lib.h

2000-12-03 Thread rbb
> As for the tests, there were a bunch of type mismatches, virtually all > related to the signedness of character strings. Then there was the The type problems probably shouldn't be solved with a cast. This is happening because we changed a bunch on arguments from apr_ssize_t to apr_size_t in t

Stand alone...

2000-12-03 Thread David Reid
If we build APR in standalone mode do we read hints.m4? I ask as on BeOS I'm seeing APR_FILES_AS_SOCKETS defined to 1 when it should be 0. We normally do this via hints.m4 but I don't see it being used when we build APR in standalone mode. Sam, you need to change the APR_FILES_AS_SOCKETS to 0 in

Re: cvs commit: apr/include apr_lib.h

2000-12-03 Thread Sam TH
On Sun, Dec 03, 2000 at 09:42:22AM -0800, [EMAIL PROTECTED] wrote: > The type problems probably shouldn't be solved with a cast. This is > happening because we changed a bunch on arguments from apr_ssize_t to > apr_size_t in the function prototypes, but neglected to update the > tests. We need t

Re: cvs commit: apr/include apr_lib.h

2000-12-03 Thread David Reid
> > After that, the only proble was testdso, which is a dynamically loaded > > binary. Naturally the syntax didn't translate well, so I just > > commented it out entirely. However, this mean that I couldn't run > > most of the tests. So, the upshot is, here's the test results: > > What do you me

Re: Stand alone...

2000-12-03 Thread rbb
> If we build APR in standalone mode do we read hints.m4? I ask as on BeOS > I'm seeing APR_FILES_AS_SOCKETS defined to 1 when it should be 0. We > normally do this via hints.m4 but I don't see it being used when we build > APR in standalone mode. We don't currently read hints.m4 from APR's con

Re: cvs commit: apr/include apr_lib.h

2000-12-03 Thread rbb
> > What do you mean the syntax doesn't translate well? Does it compile at > > all? Does it run? If this doesn't work on BeOS, we have real problems, > > because we haven't accomplished our goal of a Portable Run-Time. > > I meant the command line compiler option syntax, not the C syntax. > Na

Re: cvs commit: apr/include apr_lib.h

2000-12-03 Thread rbb
> > What do you mean the syntax doesn't translate well? Does it compile at > > all? Does it run? If this doesn't work on BeOS, we have real problems, > > because we haven't accomplished our goal of a Portable Run-Time. > > The problem is that we don't have the logic in the Makefile for the tes

Autobook (was: Re: cvs commit: apr/include apr_lib.h)

2000-12-03 Thread Sascha Schumann
For all the libtool illiterates :-)) out there, you might want to consider reading autobook, a free book featuring two chapters about libtool. The first one is directly applicable to Apache and APR: http://sources.redhat.com/autobook/ TOC: http://sources.re

Re: [PATCH] apr_make_os_sock()

2000-12-03 Thread Jeff Trawick
[EMAIL PROTECTED] writes: > On Sun, 3 Dec 2000, Jeff Trawick wrote: > > > Hopefully I didn't miss any comments on the mailing list last night > > (where is that archive again?). > > > > Here is enough to look at to make sure I didn't screw anything up. I > > added family and type parameters too

Re: [PATCH] apr_make_os_sock()

2000-12-03 Thread rbb
> > > Here is enough to look at to make sure I didn't screw anything up. I > > > added family and type parameters too so that APR doesn't have to bend > > > over backwards (i.e., use syscalls) to find that out. We don't keep > > > the type anywhere yet but it is likely to become useful in the fu

Re: cvs commit: apr/include apr_lib.h

2000-12-03 Thread Greg Stein
On Sun, Dec 03, 2000 at 09:49:11AM -0800, [EMAIL PROTECTED] wrote: > > > > What do you mean the syntax doesn't translate well? Does it compile at > > > all? Does it run? If this doesn't work on BeOS, we have real problems, > > > because we haven't accomplished our goal of a Portable Run-Time. >