Re: Question regarding Synchronization in InterleavedLedgerStorage

On Sat, Jul 15, 2017 at 8:06 AM, Charan Reddy G wrote: > Hey, > > In InterleavedLedgerStorage, since the initial version of it ( > https://github.com/apache/bookkeeper/commit/4a94ce1d8184f5f38def015d80777a > 8113b96690 and https://github.com/apache/bookkeeper/commit/ >

Question regarding Synchronization in InterleavedLedgerStorage

Hey, In InterleavedLedgerStorage, since the initial version of it ( https://github.com/apache/bookkeeper/commit/4a94ce1d8184f5f38def015d80777a8113b96690 and https://github.com/apache/bookkeeper/commit/d175ada58dcaf78f0a70b0ebebf489255ae67b5f), addEntry and processEntry methods are synchronized.

[GitHub] sijie commented on issue #205: Issue 208: Improve ledger fence logic

sijie commented on issue #205: Issue 208: Improve ledger fence logic URL: https://github.com/apache/bookkeeper/pull/205#issuecomment-315493350 @eolivelli I am currently traveling. I will spend some time on rebasing my changes ASAP when I have a large chunk of time.

[GitHub] sijie commented on issue #241: Merge script does not deal well with non-ascii names of reviewers

sijie commented on issue #241: Merge script does not deal well with non-ascii names of reviewers URL: https://github.com/apache/bookkeeper/issues/241#issuecomment-315492989 @eolivelli @jiazhai - it might be worth opening an issue to make the script handle non-ascii strings extracted from

[GitHub] sijie commented on issue #233: WIP - Issue 232: Add code-coverage report

sijie commented on issue #233: WIP - Issue 232: Add code-coverage report URL: https://github.com/apache/bookkeeper/pull/233#issuecomment-315492650 LGTM +1 This is an automated message from the Apache Git Service. To respond

[GitHub] sijie commented on a change in pull request #244: Issue#243 - asyncAddEntry fails with NPE with LedgerHandlerAdv

sijie commented on a change in pull request #244: Issue#243 - asyncAddEntry fails with NPE with LedgerHandlerAdv URL: https://github.com/apache/bookkeeper/pull/244#discussion_r127568518 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java

[GitHub] sijie commented on a change in pull request #244: Issue#243 - asyncAddEntry fails with NPE with LedgerHandlerAdv

sijie commented on a change in pull request #244: Issue#243 - asyncAddEntry fails with NPE with LedgerHandlerAdv URL: https://github.com/apache/bookkeeper/pull/244#discussion_r127567837 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandleAdv.java

[GitHub] sijie commented on issue #243: asyncAddEntry fails with NPE with LedgerHandler created with createLedgerAdv

sijie commented on issue #243: asyncAddEntry fails with NPE with LedgerHandler created with createLedgerAdv URL: https://github.com/apache/bookkeeper/issues/243#issuecomment-315491619 @eolivelli can you share the code that cause the NPE?

Re: Git protected branches

I don't think INFRA extends such admin privileges to projects. I think this is how Gitbox is working. But if we want PMC/projects want to have more privileges, that might require broader discussions in the ASF. - Sijie On Fri, Jul 14, 2017 at 3:13 PM, Enrico Olivelli wrote:

[GitHub] eolivelli opened a new pull request #244: Issue#243 - asyncAddEntry fails with NPE with LedgerHandlerAdv

eolivelli opened a new pull request #244: Issue#243 - asyncAddEntry fails with NPE with LedgerHandlerAdv URL: https://github.com/apache/bookkeeper/pull/244 Fix asyncAddEntry on LedgerHandleAdv and clean up the asyncAddEntry API, drops BKException which is never thrown in asynch functions

[GitHub] eolivelli commented on issue #243: asyncAddEntry fails with NPE with LedgerHandler created with createLedgerAdv

eolivelli commented on issue #243: asyncAddEntry fails with NPE with LedgerHandler created with createLedgerAdv URL: https://github.com/apache/bookkeeper/issues/243#issuecomment-315383045 The signature of asyncAddEntry is wrong, it does not throw BKException as it is an async function

[GitHub] eolivelli opened a new issue #243: asyncAddEntry fails with NPE with LedgerHandler created with createLedgerAdv

eolivelli opened a new issue #243: asyncAddEntry fails with NPE with LedgerHandler created with createLedgerAdv URL: https://github.com/apache/bookkeeper/issues/243 It turns out on 4.5 that "asyncAddEntry" fails with NPE with LedgerHandler created with createLedgerAdv ```

Jenkins build is back to normal : bookkeeper-master #1815

See

[GitHub] eolivelli commented on issue #232: Add code-coverage report

eolivelli commented on issue #232: Add code-coverage report URL: https://github.com/apache/bookkeeper/issues/232#issuecomment-315330556 @sijie @fpj is using CodeCov which is well integrated with PRs, I will take a look too It seems that it requires Cobertura too. Both Coveralls

[GitHub] eolivelli commented on issue #232: Add code-coverage report

eolivelli commented on issue #232: Add code-coverage report URL: https://github.com/apache/bookkeeper/issues/232#issuecomment-315330556 @sijie @fpj is using CodeCov which is well integrated with PRs, I will take a look too It seems that it requires Cobertura too. Both Coveralls

[GitHub] eolivelli closed issue #241: Merge script does not deal well with non-ascii names of reviewers

eolivelli closed issue #241: Merge script does not deal well with non-ascii names of reviewers URL: https://github.com/apache/bookkeeper/issues/241 This is an automated message from the Apache Git Service. To respond to

[GitHub] eolivelli commented on issue #241: Merge script does not deal well with non-ascii names of reviewers

eolivelli commented on issue #241: Merge script does not deal well with non-ascii names of reviewers URL: https://github.com/apache/bookkeeper/issues/241#issuecomment-315328854 closed by merging #242 This is an automated

[GitHub] eolivelli closed pull request #242: Issue 241: handle non-ascii chars in username in merge script

eolivelli closed pull request #242: Issue 241: handle non-ascii chars in username in merge script URL: https://github.com/apache/bookkeeper/pull/242 This is an automated message from the Apache Git Service. To respond to

[GitHub] eolivelli commented on issue #241: Merge script does not deal well with non-ascii names of reviewers

eolivelli commented on issue #241: Merge script does not deal well with non-ascii names of reviewers URL: https://github.com/apache/bookkeeper/issues/241#issuecomment-315326358 @jiazhai I am sorry the testcase is not usefull, the bug is on reviewers and on on the 'author', I am loking for

[GitHub] eolivelli commented on issue #241: Merge script does not deal well with non-ascii names of reviewers

eolivelli commented on issue #241: Merge script does not deal well with non-ascii names of reviewers URL: https://github.com/apache/bookkeeper/issues/241#issuecomment-315326061 @jiazhai I am checking your patch. As soon as I am OK I think we can merge without @sijie it is ery trivial

[GitHub] jiazhai commented on issue #241: Merge script does not deal well with non-ascii names of reviewers

jiazhai commented on issue #241: Merge script does not deal well with non-ascii names of reviewers URL: https://github.com/apache/bookkeeper/issues/241#issuecomment-315324040 @eolivelli, thanks a lot for the info, have a try on 234 with a fix, and it passed: ``` git:(issue_241)

[GitHub] jiazhai opened a new pull request #242: Issue 241: handle non-ascii chars in username in merge script

jiazhai opened a new pull request #242: Issue 241: handle non-ascii chars in username in merge script URL: https://github.com/apache/bookkeeper/pull/242 Descriptions of the changes in this PR: Handle handle non-ascii chars in username in merge script. --- Be sure to do all of

[GitHub] eolivelli commented on issue #231: Issue 230: Add Checkstyle to the build process (Part 1)

eolivelli commented on issue #231: Issue 230: Add Checkstyle to the build process (Part 1) URL: https://github.com/apache/bookkeeper/pull/231#issuecomment-315320256 @sigee @sijie @fpj we discussed about the TODOs at the meeting, there was consensus about creating issues for each TODO

[GitHub] eolivelli commented on issue #241: Merge script does not deal well with non-ascii names of reviewers

eolivelli commented on issue #241: Merge script does not deal well with non-ascii names of reviewers URL: https://github.com/apache/bookkeeper/issues/241#issuecomment-315319819 thank you @jiazhai I think that you can play with #234, that comes from @sigee, without actually pushing it

[GitHub] jiazhai commented on issue #241: Merge script does not deal well with non-ascii names of reviewers

jiazhai commented on issue #241: Merge script does not deal well with non-ascii names of reviewers URL: https://github.com/apache/bookkeeper/issues/241#issuecomment-315319206 would like to have a try to handle it. This is

[GitHub] jiazhai commented on issue #240: ISSUE #239: typo in class name SpeculativeRequestExecutor

jiazhai commented on issue #240: ISSUE #239: typo in class name SpeculativeRequestExecutor URL: https://github.com/apache/bookkeeper/pull/240#issuecomment-315319050 @eolivelli. thanks for the info. @sigee, From my view, your name certainly have no error, we will fix the merge script soon.

[GitHub] caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r127412474 ## File path: docker/4.4.0-alpine/Dockerfile ## @@ -0,0 +1,59 @@ +FROM

[GitHub] caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r127411473 ## File path: docker/4.4.0-alpine/run.sh ## @@ -0,0 +1,68 @@ +#/bin/bash + +# --

[GitHub] caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r127402908 ## File path: docker/4.4.0-alpine/run.sh ## @@ -0,0 +1,68 @@ +#/bin/bash + +# --

Re: Git protected branches

Yes Flavio, it is a pity that we cannot ever see in readonly mode the actual configuration. If you look at the issue, the operator attached a screenshot in order to let me see the actual configuration Maybe as PMC you or at least Sijie can ask for more privileges -- Enrico 2017-07-14 9:10

Re: Git protected branches

It's kind of odd that we have to go through infra to do this. Such a configuration feels like should be under the control of committers or at least the PMC. Thanks for doing it in any case, Enrico. -Flavio > On 13 Jul 2017, at 01:55, Jia Zhai wrote: > >  > > On Thu,