PR review request(CALCITE-4868)

2021-11-11 Thread Zhe Hu
Hi team, This PR is about supporting sorting aggregation results in Elasticsearch Adapter, please help review it in your free time. Thanks a lot! What’s more, the git workflow shows “First-time contributors need a maintainer to approve running workflows”, awaiting approval? PR:https://github

Re: [jira] [Created] (CALCITE-4896) GROUP BY might get wrong results under certain circumstances in Elasticsearch Adapter

2021-11-21 Thread Zhe Hu
Yes, when you group an Integer field in Elasticsearch Adapter, NULL and Integer.MIN_VALUE will be in the same group, which is not correct for SQL users. On 11/21/2021 19:56,Justin Swanhart wrote: If I am understanding correctly, the field2 value is NULL. Count(0) should be 2 and count(field2)==

Re: [jira] [Created] (CALCITE-4896) GROUP BY might get wrong results under certain circumstances in Elasticsearch Adapter

2021-11-21 Thread Zhe Hu
,Justin Swanhart wrote: Thanks for explaining because I did not get that at all, but it makes sense. Some column stores use a reserved value for NULL too which reduces the overall range of values available. On Sun, Nov 21, 2021 at 7:09 AM Zhe Hu wrote: Yes, when you group an Integer field in

[DISCUSS] Upgrading Elasticsearch in Calcite from 7.0.1 to 7.15

2021-11-22 Thread Zhe Hu
sticsearch cluster, current use case might need to be adjusted. Nevertheless, I’m still wondering if we can upgrade the Elasticsearch version to 7.15, which could enrich ES Adapter's ablility as much as possible. Best regards, Zhe Hu

Re: [DISCUSS] Apache Calcite Online Meetup January 2022

2021-11-22 Thread Zhe Hu
+1 for online meetup. And I’m curious about if there is any playback for this meetup, because somebody might couldn't attend due to timezone variety or any other reasons. On 11/22/2021 22:26,xiong duan wrote: Great idea. +1 for an online meetup. Justin Swanhart 于2021年11月20日周六 上午12:42写道: +

Re: [DISCUSS] Apache Calcite Online Meetup January 2022

2021-11-22 Thread Zhe Hu
Got it. Thanks! | | Replied Message | From | xiong duan | | Date | 11/22/2021 23:09 | | To | dev | | Subject | Re: [DISCUSS] Apache Calcite Online Meetup January 2022 | Yes. You can find the relative talks in http://calcite.apache.org/community/#talks . Zhe Hu 于2021年11月22日周一 下午10:50写

Re: [DISCUSS] Upgrading Elasticsearch in Calcite from 7.0.1 to 7.15

2021-11-22 Thread Zhe Hu
rest client to currently supported version. On Mon, Nov 22, 2021, 19:00 Julian Hyde wrote: +1 Sounds like a good idea. On Nov 22, 2021, at 6:40 AM, Zhe Hu wrote: Hi, community. Recently, when I tried to fix bugs in Elasticsearch Adapter, I’ve found that some new features in rel

Re:Calcite to build a query

2021-11-24 Thread Zhe Hu
rTest illustrates how to assemble a SQL by RelNode. Hope it’s helpful for you. Best, Zhe Hu On 11/24/2021 18:38,Sandeep Nayak wrote: Hello, I have been looking for a library which will allow me to use an object tree to generate a SQL. Calcite came up in my search but after taking a look a

Re: [DISCUSS] Upgrading Elasticsearch in Calcite from 7.0.1 to 7.15

2021-11-28 Thread Zhe Hu
Hu On 11/23/2021 09:08,Zhe Hu wrote: That’s very helpful, thanks for your reminder. I will look into whether ES rest client is backward compatible. On 11/23/2021 07:34,Andrei Sereda wrote: +1 Also take a look at vendor's official support schedule: https://www.elastic.co/support/e

Re:[DISCUSS] JIRA vs GitHub Issues

2021-11-28 Thread Zhe Hu
do we process the existing issues in JIRA? Moving all of them to Github or just the open issues? Best, Zhe Hu On 11/29/2021 00:43,Vladimir Sitnikov wrote: Hi, What do you think of moving to GitHub Issues for Calcite? Currently, my (Calcite) development workflow focuses on pull requests. Th

Re: [Calcite Release] Preparing for 1.29.0 Release

2021-12-17 Thread Zhe Hu
//issues.apache.org/jira/browse/CALCITE-4737> (Thomas Rebele) * https://issues.apache.org/jira/browse/CALCITE-4860 < https://issues.apache.org/jira/browse/CALCITE-4860> (Zhe Hu / Duan Xiong) * https://issues.apache.org/jira/browse/CALCITE-4907 < https://issues.apache.org/jira/browse/CA

Re:[ANNOUNCE] New committer: Alessandro Solimando

2021-12-18 Thread Zhe Hu
Congratulations! Alessandro Solimando. On 12/18/2021 22:08,Stamatis Zampetakis wrote: Apache Calcite's Project Management Committee (PMC) has invited Alessandro Solimando to become a committer, and we are pleased to announce that he has accepted. Alessandro has been in the community for quite so

Re: [DISCUSS] Java 16 and 17 support

2021-12-21 Thread Zhe Hu
Hi, Julian. I’m happy to do those tasks. Just one question, where or how can I ensure CI tests for JDK16 and JDK17. Best, | Zhe Hu | Replied Message | From | Julian Hyde | | Date | 12/22/2021 07:37 | | To | dev@calcite.apache.org | | Subject | [DISCUSS] Java 16 and 17 support | Does

Re: [QUESTION] Calcite Learning Resources

2021-12-23 Thread Zhe Hu
Hi, Givre. You can find some very useful talks at http://calcite.apache.org/community/#talks. Moreover, the website https://calcite.apache.org/develop/#download-source-build-and-run-tests is a good start for starters, which I find very instructive at least. Best, ZheHu | | Replied Mess

Re: [SITE-IMPROVEMENT] Issue need to confirm about the API web

2021-12-28 Thread Zhe Hu
+1 for removing the redundant lowercase “calcite”/”calcite-avatica”. Best, ZheHu On 12/29/2021 10:44,Chunwei Lei wrote: Sounds reasonable to me. Best, Chunwei On Wed, Dec 29, 2021 at 6:44 AM xiong duan wrote: After checking the regenerate the Web, I noticed a small problem with the Calc

Re:[SITE-IMPROVEMENT] Issue need to confirm about the API web

2022-01-07 Thread Zhe Hu
Hi, I have one small suggestion for the SITE_IMPROVEMENT. Recently,when I browse howto.html through Chrome Explorer, I’ve found that some lines are too long, which causes a little bit format disorder(just based on my personal preference). I’ll pick several cases in howto.md below: (1) Line 73: Ho

Re: [ANNOUNCE] New Calcite PMC chair: Ruben Q L

2022-01-19 Thread Zhe Hu
Congratulations to Ruben! Thanks for serving as Chair during the last year, Haisheng! Best regards, ZheHu On 01/20/2022 13:09,Jacques Nadeau wrote: Ditto, thanks Haisheng and congrats Ruben! On Wed, Jan 19, 2022, 6:35 PM Julian Hyde wrote: Congratulations, Ruben, and good luck! Haishe

Re: [DISCUSS] New community section for articles/blogs/papers

2022-01-24 Thread Zhe Hu
It’s definitely a terrific proposal, especially for those new comers and people who want to share something useful with the community. I totally agree with what Jing Zhan and Ruben Q L mentioned, those useful stuff has higher requirements for authors and reviewers. What’s more, for each releas

Question about creating a SqlBasicCall

2022-01-29 Thread Zhe Hu
Hi, community. I have one small question about how to create a SqlBasicCall in Parser.jj correctly. Take TimestampAddFunctionCall as an example, we create it by: SqlStdOperatorTable.TIMESTAMP_ADD.createCall(s.end(this), args) As a result, call like “TIMESTAMPADD(arg0, arg1, arg2)” will b

Re:List of tables & Columns

2022-02-06 Thread Zhe Hu
Hi, Sharma. As far as I can tell, Calcite doesn’t provide a simple way to get table names or column names for a query(or maybe I miss something). But you can take a look at SqlSelect、SqlOrderBy and SqlWith if you want to do such things. Based on my own experience, SqlVisitor seems the only way t

Re:Connect Calcite to Sqlite

2022-02-14 Thread Zhe Hu
Hi, Pan. It will be much better to go through your issue if you show us how you use Calcite to connect Sqlite and what the StackTrace is. There is one demo in core/src/test/resources/mysql-foodmart-model.json you can take a look. By adding a new file(like sqlite.json) which stores connection p

Re:[VOTE] Release Apache Calcite 1.30.0 (release candidate 0)

2022-03-05 Thread Zhe Hu
Hi, Fan Liya. Thanks for your great job of releasing Calcite 1.30.0. I’m trying to read the release notes in https://github.com/apache/calcite/blob/calcite-1.30.0-rc0/site/_docs/history.md. However, the latest version of this page is still 1.29.0. I’m not sure if it’s my permission issue or not

Duplicate ConnectionHandle-id when using Avatica

2022-10-27 Thread Zhe Hu
Hi, fellows, I have an issue when using Avatica. In AvaticaConnection, ConnectionHandle is used to make each connection unique, whose id is generated by “UUID.randomUUID().toString()”. On the server side(like JdbcMeta), client’s connection id is used as key in connectionCache. Here is what happen

PR Approval for CI

2023-04-23 Thread Zhe Hu
Hi, community! I’ve submitted a PR(https://github.com/apache/calcite/pull/3173) for supporting CONVERT/TRANSLATE(value USING transcodingName), which requires approval from a maintainer. Can someone help to approve the CI? Many thanks! Best, ZheHu | |

Re: subscribe calcite

2023-05-23 Thread Zhe Hu
Hi Jacky. The following website will provide more useful information you need. https://calcite.apache.org/community/#mailing-lists Best ZheHu Replied Message | From | Francis Chuang | | Date | 05/23/2023 14:59 | | To | dev, liuyongvs2 | | Subject | Re: subscribe calcite | Hey Jacky, P

Re: [ANNOUNCE] New committer: Oliver Lee

2023-06-13 Thread Zhe Hu
Congrats Oliver! Replied Message | From | xiong duan | | Date | 06/13/2023 19:17 | | To | dev | | Subject | Re: [ANNOUNCE] New committer: Oliver Lee | Congratulations Oliver! Dan Zou 于2023年6月13日周二 19:16写道: > Congratulations Oliver! > > Best, > Dan Zou > > > > > > > 2023年6月13日 18:44,Sta

PR 3258 Review Request

2023-06-15 Thread Zhe Hu
Hi, community. I’ve submitted a PR for applying two different NULL semantics for CONCAT function, because this function now returns NULL when any of the arguments is NULL, however Postgresql and MSSQL have different behavior(they treat NULL as empty string). BTW, CONCAT enabled in Oracle(we call

Re: [ANNOUNCE] New committer: Zhe Hu

2023-06-28 Thread Zhe Hu
really like the atmosphere here, and I learned many from our members. I hope I can bring more for the community in the future. Best regards, Zhe Hu Replied Message | From | Tanner Clary | | Date | 06/28/2023 21:29 | | To | | | Subject | Re: [ANNOUNCE] New committer: Zhe Hu

Re: [ANNOUNCE] New committer: Dan Zou

2023-07-04 Thread Zhe Hu
Congrats! Dan. Replied Message | From | Francis Chuang | | Date | 07/04/2023 15:18 | | To | dev | | Subject | Re: [ANNOUNCE] New committer: Dan Zou | Congrats, Dan! On 4/07/2023 5:16 pm, Stamatis Zampetakis wrote: > Apache Calcite's Project Management Committee (PMC) has invited Dan Zou

Re: [ANNOUNCE] New committer: TJ Banghart

2023-07-04 Thread Zhe Hu
Congrats! TJ. Replied Message | From | Francis Chuang | | Date | 07/04/2023 15:18 | | To | dev | | Subject | Re: [ANNOUNCE] New committer: TJ Banghart | Congrats, TJ! On 4/07/2023 5:17 pm, Stamatis Zampetakis wrote: > Apache Calcite's Project Management Committee (PMC) has invited TJ Ban

Java Doc about RexProgramBuilderBase

2023-07-06 Thread Zhe Hu
file a JIRA case to record and fix it. Best regards, Zhe Hu

Re: Java Doc about RexProgramBuilderBase

2023-07-07 Thread Zhe Hu
Jira ticket) Zhe Hu 于2023年7月7日周五 14:45写道: Hi community. Recently, when I review CALCITE-5769( https://github.com/apache/calcite/pull/3296), I found something a little confusing. First, the java doc in RexProgramBuilderBase.vParamNotNull(), which meant to create non-nullable variable, but it’s

Missing column alia after RelFieldTrimmer

2023-10-23 Thread Zhe Hu
Hi, community. I encounter a problem when I try RelFieldTrimmer. I run the following SQL in SqlToRelConverterTest: select ename as did from emp where ename='a' limit 10 I get planA without RelFieldTrimmer: LogicalSort(fetch=[10]) LogicalProject(DID=[$1]) LogicalFilter(condition=[=($1, '

Re:Re: Missing column alia after RelFieldTrimmer

2023-10-23 Thread Zhe Hu
AM, Benchao Li wrote: >> >> AFAIK, usually we cannot guarantee the columns names in the >> optimization phase. However, I think we can still try our best to >> preserve it while not introducing too much complexity. >> >> For this case, I'd like to take it

Re: [ANNOUNCE] New committer: Mihai Budiu

2023-10-26 Thread Zhe Hu
Congrats, Mihai ! Best ZheHu Replied Message | From | Bertil Chapuis | | Date | 10/26/2023 21:09 | | To | | | Subject | Re: [ANNOUNCE] New committer: Mihai Budiu | Congratulations and welcome! Bertil On 26 Oct 2023, at 10:56, Stamatis Zampetakis wrote: Apache Calcite's Project Ma

JavaType with charset

2023-12-02 Thread Zhe Hu
Hi, community. Recently, when I try to fix CALCITE-6146, I’ve find something confusing about createTypeWithCharsetAndCollation() method in SqlTypeFactoryImpl. I want to create a new RelDataType with different charset(for deriving type in CONVERT function) based on a JavaType like “JavaType(class