Re: Welcome Jordan West and Stefan Miklosovic as Cassandra PMC members!

2024-09-01 Thread Jacek Lewandowski
Congrats Stefan and Jordan!!! This is great! sob., 31 sie 2024, 22:21 użytkownik Jordan West napisał: > Thanks all!!! > > On Sat, Aug 31, 2024 at 07:55 J. D. Jordan > wrote: > >> Two great additions to the PMC. Congratulations to you both! >> >> -Jeremiah Jordan >> >> > On Aug 30, 2024, at 3:21

Re: Cassandra PMC Chair Rotation, 2024 Edition

2024-06-20 Thread Jacek Lewandowski
Congratulations!!! - - -- --- - - Jacek Lewandowski czw., 20 cze 2024 o 21:00 lorinapoland napisał(a): > Congrats, Dinesh! > > > > Sent from my Verizon, Samsung Galaxy smartphone > > > Original message > From: Josh McKe

Re: [DISCUSS] Stream Pipelines on hot paths

2024-05-31 Thread Jacek Lewandowski
Usages of them in tests are ok I think. We have a separate checkstyle file for the test code. - - -- --- - - Jacek Lewandowski pt., 31 maj 2024 o 19:14 David Capwell napisał(a): > I am cool for forbidding with a callout that tests are ok. I am cool with > forb

Re: [DISCUSS] Stream Pipelines on hot paths

2024-05-31 Thread Jacek Lewandowski
+1 to either forbid them entirely or not at all. pt., 31 maj 2024, 16:05 użytkownik Benjamin Lerer napisał: > For me the definition of hot path is too vague. We had arguments with > Berenger multiple times and it is more a waste of time than anything else > at the end. If we are truly concerned

Re: CCM and CASSANDRA_USE_JDK11

2024-05-24 Thread Jacek Lewandowski
BTW. I've created a simple workflow for GitHub Actions - https://github.com/riptano/ccm/pull/771 - feel free to review - - -- --- - - Jacek Lewandowski sob., 25 maj 2024 o 06:09 Jacek Lewandowski napisał(a): > Thank you for all the opinions. That is useful fo

Re: CCM and CASSANDRA_USE_JDK11

2024-05-24 Thread Jacek Lewandowski
en we update the installation directory, which we do when testing upgrades. Such simplification would also remove some clutter from the logs. Can you remember the whole environment logged frequently and twice when running a node? Can we make this discussion conclusive? Thanks! - - -- --- - ---

CCM and CASSANDRA_USE_JDK11

2024-05-23 Thread Jacek Lewandowski
configured for Java 11, we have to have CASSANDRA_USE_JDK11 and if not, we cannot have it. Therefore, CCM can be based solely on the current Java version and not include the existence of CASSANDRA_USE_JDK11 in the Java version selection process. WDYT? - - -- --- - - Jacek

Re: [DISCUSS] ccm as a subproject

2024-05-16 Thread Jacek Lewandowski
+1 (my personal opinion) How to deal with the DSE-supporting code is a separate discussion IMO - - -- --- - - Jacek Lewandowski czw., 16 maj 2024 o 10:21 Berenguer Blasi napisał(a): > +1 ccm is super useful > On 16/5/24 10:09, Mick Semb Wever wrote: > >

Re: Schema Disagreement Issue for Cassandra 4.1

2024-04-05 Thread Jacek Lewandowski
- - -- --- - - Jacek Lewandowski wt., 2 kwi 2024 o 20:26 Cheng Wang via dev napisał(a): > And it seems that the main fix for the > https://issues.apache.org/jira/browse/CASSANDRA-18291 is to change the > order of updating the schema version in the system.lo

Re: Schema Disagreement Issue for Cassandra 4.1

2024-04-02 Thread Jacek Lewandowski
Please cc me when you create a ticket pon., 1 kwi 2024, 14:13 użytkownik Bowen Song via dev < dev@cassandra.apache.org> napisał: > It sounds worthy of a Jira ticket. > > On 01/04/2024 06:23, Cheng Wang via dev wrote: > > Hello, > > > > I have recently encountered a problem concerning schema disag

Re: Default table compression defined in yaml.

2024-03-21 Thread Jacek Lewandowski
s that we should not add to that mess and try to group the new stuff. "default_compression" under ""sstable" key sounds good to me. - - -- --- - - Jacek Lewandowski czw., 21 mar 2024 o 08:32 Claude Warren, Jr via dev < dev@cassandra.apache.or

Re: Default table compression defined in yaml.

2024-03-20 Thread Jacek Lewandowski
Compression params for sstables should be under the "sstable" key. - - -- --- - ----- Jacek Lewandowski wt., 19 mar 2024 o 13:10 Ekaterina Dimitrova napisał(a): > Any new settings are expected to be added in the new format > > On Tue, 19 Mar 2024 at 5

[DISCUSS] Types compatibility

2024-03-08 Thread Jacek Lewandowski
Hey, I was going through the different kinds of types compatibility and found that I need help in understanding them. Therefore, I tried to figure out what is used where, in particular, what means that two types are "compatible", "valueCompatible" or "serializationCompatible". I found https://iss

Re: Welcome Brad Schoening as Cassandra Committer

2024-02-22 Thread Jacek Lewandowski
Congrats Brad! - - -- --- - - Jacek Lewandowski czw., 22 lut 2024 o 01:29 Štefan Miklošovič napisał(a): > Congrats Brad, great work in the Python department :) > > On Wed, Feb 21, 2024 at 9:46 PM Josh McKenzie > wrote: > >> The Apache Cassan

Re: [Discuss] Improving CI workflows

2024-02-20 Thread Jacek Lewandowski
Let's not start another thread and discuss that directly on the ticket. - - -- --- - - Jacek Lewandowski wt., 20 lut 2024 o 11:31 Berenguer Blasi napisał(a): > Hi All, > > after the recent discussion that came up in CASSANDRA-18753's discuss >

Re: [Discuss] "Latest" configuration for testing and evaluation (CASSANDRA-18753)

2024-02-16 Thread Jacek Lewandowski
We should conclude this discussion by answering Branimir's original question.* I vote for merging that and exposing issues to the CI.* For pre-commit optimization I've opened https://issues.apache.org/jira/browse/CASSANDRA-19406 epic and we should add exact tasks there to make this valuable discus

Re: [Discuss] "Latest" configuration for testing and evaluation (CASSANDRA-18753)

2024-02-15 Thread Jacek Lewandowski
Brandon, that should be doable with the current filters I think - that is, select only those tests which do not support vnodes. Do you know about such in-jvm dtests as well? - - -- --- - - Jacek Lewandowski czw., 15 lut 2024 o 18:21 Brandon Williams napisał(a): >

Re: [Discuss] "Latest" configuration for testing and evaluation (CASSANDRA-18753)

2024-02-15 Thread Jacek Lewandowski
Great summary Josh, > >- JDK-based test suites on highest supported jdk using other config > > Do you mean a smoke test suite by that ^ ? - - -- --- - ----- Jacek Lewandowski czw., 15 lut 2024 o 18:12 Josh McKenzie napisał(a): > Would it make sens

Re: [Discuss] "Latest" configuration for testing and evaluation (CASSANDRA-18753)

2024-02-14 Thread Jacek Lewandowski
I fully understand you. Although I have that luxury to use more containers, I simply feel that rerunning the same code with different configurations which do not impact that code is just a waste of resources and money. - - -- --- - - Jacek Lewandowski czw., 15 lut 2024

Re: [Discuss] "Latest" configuration for testing and evaluation (CASSANDRA-18753)

2024-02-14 Thread Jacek Lewandowski
ration for >> each branch and minimally require precommit tests for that configuration. >> Assignees and reviewers can determine if additional test variants are >> required based on the patch scope. >> >> Nightly and prerelease tests can be run to catch any issues

Re: [Discuss] "Latest" configuration for testing and evaluation (CASSANDRA-18753)

2024-02-14 Thread Jacek Lewandowski
śr., 14 lut 2024 o 17:30 Josh McKenzie napisał(a): > When we have failing tests people do not spend the time to figure out if > their logic caused a regression and merge, making things more unstable… so > when we merge failing tests that leads to people merging even more failing > tests... > > Wh

Re: [Discuss] Introducing Flexible Authentication in Cassandra via Feature Flag

2024-02-14 Thread Jacek Lewandowski
let the administrators enable/disable and reconfigure authentication without a restart so we could discuss whether such transitional mode would be needed at all in that case. Thanks, - - -- --- - - Jacek Lewandowski wt., 13 lut 2024 o 07:04 Jeff Jirsa napisał(a

Re: [Discuss] "Latest" configuration for testing and evaluation (CASSANDRA-18753)

2024-02-14 Thread Jacek Lewandowski
We should not block merging configuration changes given it is a valid configuration - which I understand as it is correct, passes all config validations, it matches documented rules, etc. And this provided latest config matches those requirements I assume. The failures should block release or we s

Re: Welcome Maxim Muzafarov as Cassandra Committer

2024-01-08 Thread Jacek Lewandowski
Congratulations Maxim, well deserved, it's a pleasure to work with you! - - -- --- - - Jacek Lewandowski pon., 8 sty 2024 o 19:35 Lorina Poland napisał(a): > Congratulations Maxim! > > On 2024/01/08 18:19:04 Josh McKenzie wrote: > > The Apache Cass

Re: Harry in-tree (Forked from "Long tests, Burn tests, Simulator tests, Fuzz tests - can we clarify the diffs?")

2023-12-22 Thread Jacek Lewandowski
Obviously +1 Thank you Alex pt., 22 gru 2023, 16:45 użytkownik Sumanth Pasupuleti < sumanth.pasupuleti...@gmail.com> napisał: > +1, thank you for your efforts in bringing Harry in-tree. Anything that > improves the testing ecosystem for Cassandra, particularly around complex > scenarios / edge c

Re: [ATTENTION] Forced push on cassandra-5.0 branch !!!

2023-12-16 Thread Jacek Lewandowski
pushed has no such merge (I pushed this branch also to my personal fork: https://github.com/jacek-lewandowski/cassandra/commits/cassandra-5.0) I am really curious about what went wrong as I want to avoid that in the future - - -- --- - ----- Jacek Lewandowski niedz., 17 gru 20

Moving Semver4j from test to main dependencies

2023-12-15 Thread Jacek Lewandowski
l for it. Maybe at some point we can replace our custom implementation of CassandraVersion as well. Thanks, - - -- --- - - Jacek Lewandowski

Re: Long tests, Burn tests, Simulator tests, Fuzz tests - can we clarify the diffs?

2023-12-12 Thread Jacek Lewandowski
of how this would actually > benefit our test suites? > > On 12 Dec 2023, at 10:51, Jacek Lewandowski > wrote: > >  > I have two major pros for JUnit 5: > - much better support for parameterized tests > - global test hooks (automatically detectable extensions) + > mul

Re: Long tests, Burn tests, Simulator tests, Fuzz tests - can we clarify the diffs?

2023-12-12 Thread Jacek Lewandowski
less well justified, which it may be - > just not immediately obvious to me. > > On 11 Dec 2023, at 08:33, Jacek Lewandowski > wrote: > >  > Nobody referred so far to the idea of moving to JUnit 5, what are the > opinions? > > > > niedz., 10 gru 2023 o 11:03 Ben

Re: Ext4 data corruption in stable kernels

2023-12-11 Thread Jacek Lewandowski
; affected, just that some stable kernels are affected. Adding to the > problem is that it might be vendor specific as well. For example, RH might > backport an upstream patch in the kernel they ship that's non-standard. > > Hopefully someone compiles a list. > > Jon > >

Re: Ext4 data corruption in stable kernels

2023-12-11 Thread Jacek Lewandowski
Aren't only specific kernels affected? If we can detect the kernel version, the feature can be force disabled with the problematic kernels pon., 11 gru 2023, 20:45 użytkownik Jon Haddad napisał: > Hey folks, > > Just wanted to raise awareness about a I/O issue that seems to be > affecting some

Re: Long tests, Burn tests, Simulator tests, Fuzz tests - can we clarify the diffs?

2023-12-11 Thread Jacek Lewandowski
Nobody referred so far to the idea of moving to JUnit 5, what are the opinions? niedz., 10 gru 2023 o 11:03 Benedict napisał(a): > Alex’s suggestion was that we meta randomise, ie we randomise the config > parameters to gain better rather than lesser coverage overall. This means > we cover the

Re: Welcome Mike Adamson as Cassandra committer

2023-12-08 Thread Jacek Lewandowski
Awesome, congratulations Mike !!! - - -- --- - - Jacek Lewandowski pt., 8 gru 2023 o 16:10 Miklosovic, Stefan via dev napisał(a): > Wow, great news! Congratulations on your committership, Mike. > > > From: Be

Re: Long tests, Burn tests, Simulator tests, Fuzz tests - can we clarify the diffs?

2023-12-08 Thread Jacek Lewandowski
> > It would be great to setup a JUnitRunner using the simulator and find out > though. > I like this idea - this is what I meant when asking about the current unit tests - to me, a test is either simulation or a fuzz. Due to pretty random execution order of unit tests, all of them can be consider

Re: [DISCUSS] CASSANDRA-19104: Standardize tablestats formatting and data units

2023-12-04 Thread Jacek Lewandowski
This looks great, I'd consider limiting the number of significant digits to 3 in the human readable format. In the above example it would translate to: Space used (live): 1.46 TiB Space used (total): 1.46 TiB Bytes repaired: 0.00 KiB Bytes unrepaired: 4.31 TiB Bytes pending repair: 0.000 KiB I

Re: Long tests, Burn tests, Simulator tests, Fuzz tests - can we clarify the diffs?

2023-12-01 Thread Jacek Lewandowski
Thanks for the exhaustive response, Alex :) Let me bring my point of view: 1. Since long tests are just unit tests that take a long time to run, it makes sense to separate them for efficient parallelization in CI. Since we are adding new tests, modifying the existing ones, etc., that should be so

Re: Long tests, Burn tests, Simulator tests, Fuzz tests - can we clarify the diffs?

2023-11-30 Thread Jacek Lewandowski
/apache/cassandra/pull/2554/files#diff-a4c4d1d91048841f76d124386858bda9944644cfef8ccb4ab84319cedaf5b3feR237-R267> > would make things a lot easier to wrap our heads around and maintain I > think. > > As for what qualifies as burn vs. long... /shrug couldn't tell you. Would > hav

Long tests, Burn tests, Simulator tests, Fuzz tests - can we clarify the diffs?

2023-11-30 Thread Jacek Lewandowski
Hi, I'm getting a bit lost - what are the exact differences between those test scenarios? What are the criteria for qualifying a test to be part of a certain scenario? I'm working a little bit with tests and build scripts and the number of different configurations for which we have a separate tar

Re: [VOTE] Release Apache Cassandra 5.0-beta1

2023-11-29 Thread Jacek Lewandowski
> > If we end up not releasing a final 5.0 artifact by a Cassandra Summit it > will signal to the community that we’re prioritizing stability and it could > be a good opportunity to get people to test the beta or RC before we stamp > it as production ready. > I agree with Paulo's comment czw., 30

Re: Welcome Francisco Guerrero Hernandez as Cassandra Committer

2023-11-28 Thread Jacek Lewandowski
Congrats!!! wt., 28 lis 2023, 23:08 użytkownik Abe Ratnofsky napisał: > Congrats Francisco! > > > On Nov 28, 2023, at 1:56 PM, C. Scott Andreas > wrote: > > > > Congratulations, Francisco! > > > > - Scott > > > >> On Nov 28, 2023, at 10:53 AM, Dinesh Joshi wrote: > >> > >> The PMC members are

Re: Include CASSANDRA-18464 in 5.0-beta1 (direct I/O support for commitlog write)

2023-11-28 Thread Jacek Lewandowski
Should I assume it's an agreement? - - -- --- - - Jacek Lewandowski wt., 28 lis 2023 o 12:05 Mick Semb Wever napisał(a): > > > So, assuming beta2, can it be merged to cassandra-5.0 now? >> > > > Yes from me. > And I would interpret Bra

Re: Include CASSANDRA-18464 in 5.0-beta1 (direct I/O support for commitlog write)

2023-11-28 Thread Jacek Lewandowski
So, assuming beta2, can it be merged to cassandra-5.0 now? - - -- --- - - Jacek Lewandowski pon., 27 lis 2023 o 16:02 Mick Semb Wever napisał(a): > > I don't want to veto the 5.0-beta1 release for this. > > I would rather cut and include it in th

Re: [DISCUSS] Harry in-tree

2023-11-27 Thread Jacek Lewandowski
+1 - - -- --- - - Jacek Lewandowski pon., 27 lis 2023 o 22:11 Ekaterina Dimitrova napisał(a): > +1, also, Alex, just an idea - maybe you want to make a virtual talk, as > part of the contributors meetings? > > > На понеделник, 27 ноември 2023 г. Yi

Re: [VOTE] Release Apache Cassandra 5.0-beta1

2023-11-27 Thread Jacek Lewandowski
I propose to consider including https://issues.apache.org/jira/browse/CASSANDRA-18464 (started a separate thread) pon., 27 lis 2023 o 13:06 Benjamin Lerer napisał(a): > Looking at the board it is unclear to me why CASSANDRA-19011 > , CASS

Include CASSANDRA-18464 in 5.0-beta1 (direct I/O support for commitlog write)

2023-11-27 Thread Jacek Lewandowski
Hey, I'd like to ask if we can include https://issues.apache.org/jira/browse/CASSANDRA-18464 in the 5.0-beta1 release. This introduces the ability to write to the commitlog using direct I/O and bringing some noticeable performance improvements when enabled (disabled by default). Since it introduc

Re: CEP-21 - Transactional cluster metadata merged to trunk

2023-11-27 Thread Jacek Lewandowski
Hi, I'm happy to hear that the feature got merged. Though, I share Benjamin's worries about that being a bad precedent. I don't think it makes sense to do repeated runs in this particular case. Detecting flaky tests would not prove anything; they can be caused by this patch, but we would not know

Re: Push TCM (CEP-21) and Accord (CEP-15) to 5.1 (and cut an immediate 5.1-alpha1)

2023-10-27 Thread Jacek Lewandowski
focus accordingly to participate in the remaining work. Thanks, - - -- --- - - Jacek Lewandowski pt., 27 paź 2023 o 10:26 Benjamin Lerer napisał(a): > I would be interested in testing Maxim's approach. We need more visibility > on big features and their progres

Re: [VOTE] Release Apache Cassandra 5.0-alpha1 (take3)

2023-09-08 Thread Jacek Lewandowski
Ok, +1 czw., 7 wrz 2023, 21:33 użytkownik Mick Semb Wever napisał: > > > On Thu, 7 Sept 2023 at 13:53, Jacek Lewandowski < > lewandowski.ja...@gmail.com> wrote: > >> Mick, is the documentation / website ok? >> > > > Can you elaborate on what is ok

Re: [VOTE] Release Apache Cassandra 5.0-alpha1 (take3)

2023-09-07 Thread Jacek Lewandowski
Mick, is the documentation / website ok? If so, +1 Best Regards, - - -- --- - - Jacek Lewandowski czw., 7 wrz 2023 o 12:58 Brandon Williams napisał(a): > +1 > > Kind Regards, > Brandon > > On Mon, Sep 4, 2023 at 3:26 PM Mick Semb Wever wrote: >

Re: [DISCUSSION] Shall we remove ant javadoc task?

2023-08-02 Thread Jacek Lewandowski
With or without outputting JavaDoc to HTML, there are some errors which we should maybe fix. We want to keep the documentation, but there can be syntax errors which may prevent IDE generating a proper preview. So, the question is - should we validate the JavaDoc comments as a precommit task? Can it

Re: Fwd: [DISCUSS] Formalizing requirements for pre-commit patches on new CI

2023-07-12 Thread Jacek Lewandowski
., 12 lip 2023 o 14:52 Jacek Lewandowski napisał(a): > Would it be re-opening the ticket or creating a new ticket with "revert of > fix" ? > > > > śr., 12 lip 2023 o 14:51 Ekaterina Dimitrova > napisał(a): > >> jenkins_jira_integration >> <http

Re: Fwd: [DISCUSS] Formalizing requirements for pre-commit patches on new CI

2023-07-12 Thread Jacek Lewandowski
ke a lot less than we're facing >> today. We could even get clever as a day 2 effort and define packages in >> the primary codebase where changes take place and multiplex (on a smaller >> scale) their respective packages of unit tests in the future if we see >> problems

Re: Fwd: [DISCUSS] Formalizing requirements for pre-commit patches on new CI

2023-07-12 Thread Jacek Lewandowski
Isn't novnodes a special case of vnodes with n=1 ? We should rather select a subset of tests for which it makes sense to run with different configurations. The set of configurations against which we run the tests currently is still only the subset of all possible cases. I could ask - why don't ru

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-07-10 Thread Jacek Lewandowski
just gotten sidetracked by things and also realized how little I've >> actually modified locally since I just run most of the linting against >> delta'ed files only to keep my changed work in compliance. Still a very >> noisy mess when SpotBugs is run against the

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-07-10 Thread Jacek Lewandowski
ant publish -Dno-tests -Dno-checks >>> >>> >>> I'm not saying what you've proposed is bad, in fact, we're not >>> currently doing the pipeline I'm talking about, but adding an >>> additional endpoint is something we should con

Re: [DISCUSS] Limiting query results by size (CASSANDRA-11745)

2023-07-10 Thread Jacek Lewandowski
age returned to the user when the full row > is queried without transformation. For all the other case the difference > can be really significant. For a group by queries doing a count(*), the > approach suggested will return a page size that is totally off with what > was requested. > >

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-07-06 Thread Jacek Lewandowski
;>> >>> Best regards, >>> Ekaterina >>> >>> On Thu, 29 Jun 2023 at 10:52, Josh McKenzie >>> wrote: >>> >>> >>> I really prefer separate tasks than flags. Flags are not listed in the >>> help message like "ant -p

Re: [DISCUSS] Formalizing requirements for pre-commit patches on new CI

2023-07-05 Thread Jacek Lewandowski
Perhaps pre-commit checks should include mostly the typical configuration of Cassandra rather than some subset of possible combinations. Like it was said somewhere above - test with the default number of vnodes, test with the default compression settings, and test with the default heap/off-heap buf

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-29 Thread Jacek Lewandowski
Regards, > Brandon > > On Thu, Jun 29, 2023 at 3:22 AM Jacek Lewandowski > wrote: > > > > So given all the feedback, I'm going to do the following: > > > > "jar" will depend on "check" target > > "build-project", "buil

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-29 Thread Jacek Lewandowski
rat and eclipse-warnings There is an additional flag "no-check" to disable checks in the "jar" target. Will not introduce any Git hook. wt., 27 cze 2023 o 18:35 Jacek Lewandowski napisał(a): > With git you can always opt-out by adding --no-verify flag to either push > or

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-27 Thread Jacek Lewandowski
With git you can always opt-out by adding --no-verify flag to either push or commit I really prefer separate tasks than flags. Flags are not listed in the help message like "ant -p" and are not auto-completed in the terminal. That makes them almost undiscoverable for newcomers. Want to have jar i

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-27 Thread Jacek Lewandowski
the best one is valid, and we should rather think about pre-commit - - -- --- - - Jacek Lewandowski wt., 27 cze 2023 o 09:25 Miklosovic, Stefan napisał(a): > I am doing all git-related operations in the console / bash (IDEA > terminal, alt+f12 in IDEA). I know ID

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-27 Thread Jacek Lewandowski
recognize the sender and know the content is >> safe. >> >> >> >> not running it automatically with the targets which devs usually run >> locally. >> >> The checks tend to have an opt-out, such as -Dno-checkstyle=true… so its >> really easy to s

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-26 Thread Jacek Lewandowski
That would work as well Brandon, basically what is proposed in CASSANDRA-18618, that is "check" target, actually needs to build the project to perform some verifications - I suppose running "ant check" should be sufficient. - - -- --- - ---- ----- Jacek Lewand

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-26 Thread Jacek Lewandowski
consistently by adding a Git hook. Do you think we can encounter some particular problems with this approach? Maxim, this is a great idea, and I fully support it - but this does not address the issues I've raised there. - - -- --- - - Jacek Lewandowski pon., 26 cze 2023 o

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-26 Thread Jacek Lewandowski
Yes, I've mentioned that there is a property we can set to skip checkstyle. Currently such a goal is "artifacts" which basically validates everything. - - -- --- - - Jacek Lewandowski pon., 26 cze 2023 o 13:09 Mike Adamson napisał(a): > While I lik

[DISCUSS] When to run CheckStyle and other verificiations

2023-06-25 Thread Jacek Lewandowski
E and do not even touch Ant commands directly Checks can take time; to optimize that, they could be enforced locally to verify only the modified files in the same way as we currently determine the tests to be repeated for CircleCI. Thanks - - -- --- - - Jacek Lewandowski

Re: [DISCUSSIONS] Replace ant eclipse-warnings with CheckerFramework

2023-06-16 Thread Jacek Lewandowski
Later, we may enable more checks than just leaked resources to improve the code gradually. - - -- --- - - Jacek Lewandowski pt., 16 cze 2023 o 13:48 Ekaterina Dimitrova napisał(a): > Got so excited that I forgot to say which of the two options exactly I >

Re: [DISCUSSIONS] Replace ant eclipse-warnings with CheckerFramework

2023-06-16 Thread Jacek Lewandowski
Additional question is whether we want to run the checks against the whole project or just against the file changes between the feature branch and the target release branch? - - -- --- - - Jacek Lewandowski pt., 16 cze 2023 o 13:09 Aleksey Yeshchenko napisał(a

Re: [DISCUSS] Limiting query results by size (CASSANDRA-11745)

2023-06-12 Thread Jacek Lewandowski
Josh, that answers my question exactly; thank you. I will not implement limiting the result set in CQL (that is, by LIMIT clause) and stay with just paging. Whether the page size is defined in bytes or rows can be determined by a flag - there are many unused bits for that. So my other question -

Re: [DISCUSS] Limiting query results by size (CASSANDRA-11745)

2023-06-12 Thread Jacek Lewandowski
then is > is really confusing and can be a problem for some usecases. We have users > keeping their session open and the page information to display page of data. > > Le lun. 12 juin 2023 à 09:08, Jacek Lewandowski < > lewandowski.ja...@gmail.com> a écrit : > >> Hi, &g

Re: [DISCUSS] Limiting query results by size (CASSANDRA-11745)

2023-06-12 Thread Jacek Lewandowski
he size of the resultset, or we instead want to use this >> mechanism to limit the amount of memory used internally for the data and >> prevent problems (assuming restricting size and rows number can be used >> simultaneously in a way that we stop when we reach any of the specified >> limits). >> >> https://issues.apache.org/jira/browse/CASSANDRA-11745 >> >> thanks, >> - - -- --- - - >> Jacek Lewandowski >> >

[DISCUSS] Limiting query results by size (CASSANDRA-11745)

2023-06-12 Thread Jacek Lewandowski
browse/CASSANDRA-11745 thanks, - - -- --- - - Jacek Lewandowski

[DISCUSS] CEP-31 negotiated authentication

2023-05-26 Thread Jacek Lewandowski
ation+and+authorization thanks, - - -- --- - - Jacek Lewandowski

Re: [CASSANDRA-11471] Authentication mechanism negotiation (OPTIONS/SUPPORTED)

2023-05-26 Thread Jacek Lewandowski
I'll start a separate thread on that topic soon. thanks - - -- --- - - Jacek Lewandowski pt., 26 maj 2023 o 04:08 Dinesh Joshi napisał(a): > Leaving the naming aside (the hardest part of any software), I am > generally positive about your idea. A protoco

Re: [EXTERNAL] Re: (CVE only) support for 3,11 beyond published EOL

2023-04-13 Thread Jacek Lewandowski
nd of validation whether that effort is justified. btw. We have recently agreed to keep support for M sstables format (3.0 - 3.11). thanks, - - -- --- - - Jacek Lewandowski czw., 13 kwi 2023 o 21:59 Mick Semb Wever napisał(a): > Yes, this would be great. Right now u

Re: [DISCUSS] Introduce DATABASE as an alternative to KEYSPACE

2023-04-05 Thread Jacek Lewandowski
ation config, like simple 1, so that creating a names boils down to a simply CREATE KEYSPACE|SCHEMA|DATABASE|NAMESPACE ; thanks, - - -- --- - - Jacek Lewandowski czw., 6 kwi 2023 o 04:09 guo Maxwell napisał(a): > either KEYSPACE or DATABASE or SCHEMA is better than N

Re: [DISCUSS] Introduce DATABASE as an alternative to KEYSPACE

2023-04-04 Thread Jacek Lewandowski
While for someone who already knows Cassandra keyspace is something natural, for newcomers it is yet another concept to understand. If namespace is used in PostgreSQL, it sounds even better to me. Thanks, - - -- --- - - Jacek Lewandowski wt., 4 kwi 2023 o 19:07 Rahul

Re: [VOTE] CEP-26: Unified Compaction Strategy

2023-04-04 Thread Jacek Lewandowski
+1 - - -- --- - - Jacek Lewandowski wt., 4 kwi 2023 o 15:01 Berenguer Blasi napisał(a): > +1 > On 4/4/23 14:36, J. D. Jordan wrote: > > +1 > > On Apr 4, 2023, at 7:29 AM, Brandon Williams > wrote: > >  > +1 > > On Tue, Apr 4,

Re: [DISCUSS] Moving system property names to the CassandraRelevantProperties

2023-03-30 Thread Jacek Lewandowski
I'll do - - -- --- - - Jacek Lewandowski czw., 30 mar 2023 o 22:09 Miklosovic, Stefan napisał(a): > Hi list, > > we are looking for one more committer to take a look at this patch (1, 2). > > It looks like there is a lot to go through becaus

Re: Welcome our next PMC Chair Josh McKenzie

2023-03-23 Thread Jacek Lewandowski
Congrats Josh! - - -- --- - - Jacek Lewandowski czw., 23 mar 2023 o 09:32 Berenguer Blasi napisał(a): > Congrats Josh! > On 23/3/23 9:22, Mick Semb Wever wrote: > > It is time to pass the baton on, and on behalf of the Apache Cassandra > Project Manag

Re: [DISCUSS] Drop support for sstable formats m* (in trunk)

2023-03-14 Thread Jacek Lewandowski
many people are still on 3.11 and we should not make their life harder when they consider upgrading directly to 5.0. Though clear rules for that would help the users and us. thanks, - - -- --- - - Jacek Lewandowski wt., 14 mar 2023 o 15:36 C. Scott Andreas napisał(a):

Re: Should we cut some new releases?

2023-03-13 Thread Jacek Lewandowski
+1 pon., 13 mar 2023, 20:36 użytkownik Miklosovic, Stefan < stefan.mikloso...@netapp.com> napisał: > Yes, I was waiting for CASSANDRA-18125 to be in. > > I can release 4.1.1 to staging tomorrow morning CET if nobody objects that. > > Not sure about 4.0.9. We released 4.0.8 just few weeks ago. I w

Re: Role of Hadoop code in Cassandra 5.0

2023-03-10 Thread Jacek Lewandowski
I've experimentally added https://issues.apache.org/jira/browse/CASSANDRA-16984 to https://issues.apache.org/jira/browse/CASSANDRA-18306 (post 4.0 cleanup) - - -- --- - - Jacek Lewandowski pt., 10 mar 2023 o 09:56 Berenguer Blasi napisał(a): > +1 deprecate +

Re: Role of Hadoop code in Cassandra 5.0

2023-03-09 Thread Jacek Lewandowski
Is there a ticket for that? - - -- --- - - Jacek Lewandowski czw., 9 mar 2023 o 20:27 Mick Semb Wever napisał(a): > > > On Thu, 9 Mar 2023 at 18:54, Brandon Williams wrote: > >> I think if we reach consensus here that decides it. I too vote to >

Re: Role of Hadoop code in Cassandra 5.0

2023-03-09 Thread Jacek Lewandowski
Is it possible to deprecate it in the 4.1.x patch release? :) - - -- --- - - Jacek Lewandowski czw., 9 mar 2023 o 18:11 Brandon Williams napisał(a): > This is my feeling too, but I think we should accomplish this by > deprecating it first. I don't expe

Re: Role of Hadoop code in Cassandra 5.0

2023-03-09 Thread Jacek Lewandowski
Lewandowski czw., 9 mar 2023 o 18:08 Jacek Lewandowski napisał(a): > I vote for removing it entirely. > > thanks > - - -- --- - ----- > Jacek Lewandowski > > > czw., 9 mar 2023 o 18:07 Miklosovic, Stefan > napisał(a): > >> Derek, >> >&

Re: Role of Hadoop code in Cassandra 5.0

2023-03-09 Thread Jacek Lewandowski
I vote for removing it entirely. thanks - - -- --- - - Jacek Lewandowski czw., 9 mar 2023 o 18:07 Miklosovic, Stefan napisał(a): > Derek, > > I have couple more points ... I do not think that extracting it to a > separate repository is "win".

Re: Downgradability

2023-03-06 Thread Jacek Lewandowski
A bit of organization - I've created https://issues.apache.org/jira/browse/CASSANDRA-18300 epic to track tickets related to the downgradability. Please add the tickets you are aware of. thanks - - -- --- - - Jacek Lewandowski czw., 23 lut 2023 o 17:47 Benedict na

Merging CEP-17

2023-02-27 Thread Jacek Lewandowski
x27;m gonna merge it this week. I'm also open for doing some follow-up work if something is missing or something more is needed. Thanks, - - -- --- - ----- Jacek Lewandowski

Re: Downgradability

2023-02-23 Thread Jacek Lewandowski
Running upgrade tests backwards is great idea which does not require extra work. For stats metadata it already supports writing in previous serialization version We need a small fix in compression metadata and that's it. A flag with the write format version is probably LHF. Maybe let's try, we

Re: [DISCUSSION] Cassandra's code style and source code analysis

2023-02-22 Thread Jacek Lewandowski
I suppose it can be easy for the existing feature branches if they have a single commit. Don't we need to adjust each commit for multi-commit feature branches? śr., 22 lut 2023, 19:48 użytkownik Maxim Muzafarov napisał: > Hello everyone, > > I have created an issue CASSANDRA-18277 that may help

Re: Downgradability

2023-02-20 Thread Jacek Lewandowski
rsion ranges, like one impl for ma-nz, other for oa+, etc. without having a confusing implementation with a lot of conditional blocks. Old formats in such case could be maintained separately from the main code and easily switched any time. thanks - - -- --- - - Jacek Lewand

Re: [VOTE] CEP-21 Transactional Cluster Metadata

2023-02-07 Thread Jacek Lewandowski
+1 - - -- --- - - Jacek Lewandowski wt., 7 lut 2023 o 10:12 Benjamin Lerer napisał(a): > +1 > > Le mar. 7 févr. 2023 à 06:21, a écrit : > >> +1 nb >> >> On Feb 6, 2023, at 9:05 PM, Ariel Weisberg wrote: >> >> +1 &

Re: Welcome Patrick McFadin as Cassandra Committer

2023-02-02 Thread Jacek Lewandowski
Congrats !!! - - -- --- - - Jacek Lewandowski czw., 2 lut 2023 o 19:10 Melissa Logan napisał(a): > Congrats, Patrick! > > On Thu, Feb 2, 2023 at 9:58 AM Benjamin Lerer wrote: > >> The PMC members are pleased to announce that Patrick McFadin h

Re: Merging CEP-15 to trunk

2023-01-16 Thread Jacek Lewandowski
/index.html but for unreleased Cassandra version or a blog post, so that the syntax is known to the users and they can quickly get into speed, hopefully reporting any problems soon. - - -- --- - - Jacek Lewandowski On Mon, 16 Jan 2023 at 17:52, Benedict wrote: > That’s f

[DISCUSS] Clear rules about sstable versioning and downgrade support

2023-01-13 Thread Jacek Lewandowski
with version (X-1)* and X* (which means that all the minor future versions X. Perhaps we could make some commitment to change major sstable format only with new major release? What do you think? Thanks - - -- --- - - Jacek Lewandowski

Re: Introducing mockito-inline library among test dependencies

2023-01-12 Thread Jacek Lewandowski
Will it work with Java17? czw., 12 sty 2023, 12:56 użytkownik Brandon Williams napisał: > +1 > > Kind Regards, > Brandon > > On Wed, Jan 11, 2023 at 2:02 PM Miklosovic, Stefan > wrote: > > > > Hi list, > > > > the test for (1) is using mockito-inline dependency for mocking static > methods as m

Re: upgrade sstable selection

2023-01-11 Thread Jacek Lewandowski
like the mentioned compactor would get wrong order. I suggest creating a ticket and fix the upgrader code by explicitly ordering sstables by their id. The comparator for SSTableId is available in SSTableIdFactory.COMPARATOR. Thanks, - - -- --- - - Jacek Lewandowski On Tue

Re: [VOTE] CEP-25: Trie-indexed SSTable format

2022-12-19 Thread Jacek Lewandowski
+1 - - -- --- - - Jacek Lewandowski On Mon, Dec 19, 2022 at 2:00 PM Branimir Lambov wrote: > Hi everyone, > > I'd like to propose CEP-25 for approval. > > Proposal: > https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-25%3A+Trie

  1   2   >