Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-217370720
Hi @mike-tutkowski,
I trust you either addressed all my previous remarks, or have a good reason
not to.
I've skimmed (very quickly throug
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-217091053
I think `/test/integration/plugins/solidfire` is a good place to keep the
integration tests. I wouldn't disable or skip them because, IMH, it's no
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-216987677
Hi @mike-tutkowski
It has indeed been a long time :)
None the less, it's great that you took the time time write that
integration test. I
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1479#issuecomment-207838857
@kiwiflyer I can't seem to find that PR discussion you mention. Maybe you
got the wrong handle?
---
If your project is set up for it, you can rep
Github user miguelaferreira closed the pull request at:
https://github.com/apache/cloudstack/pull/1285
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1294#issuecomment-172460540
@remibergsma @DaanHoogland I've fixed a concurency issue in a unit tests
(pointed out by @borisroman) and in the process rebased this branch on latest
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1293#discussion_r49728823
--- Diff:
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java ---
@@ -821,9 +819,9 @@ protected boolean
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1293#discussion_r49728579
--- Diff:
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/resource/wrapper/NiciraCheckHealthCommandWrapper.java
---
@@ -0,0
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1285#discussion_r48496732
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
---
@@ -111,19 +114,27 @@ public
GitHub user miguelaferreira opened a pull request:
https://github.com/apache/cloudstack/pull/1294
Implement a NSX API request execution counter per thread
The NSX plugin has a execution counter to prevent infinite recursion (and
as a result a stack overflow exception). However, the
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1293#issuecomment-167586479
I've built the entire project running the existing and additional unit
tests. I've also deployed this jar into our beta environment to che
GitHub user miguelaferreira opened a pull request:
https://github.com/apache/cloudstack/pull/1293
Add Health Check Command to NSX plugin
The NSX plugin does not support the HeathCheckCommand. Instead it fakes a
PingCommand as a call tot he control cluster status API.
However
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1292#issuecomment-167586010
closing since this should not target master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user miguelaferreira closed the pull request at:
https://github.com/apache/cloudstack/pull/1292
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user miguelaferreira opened a pull request:
https://github.com/apache/cloudstack/pull/1292
Add Health Check Command to NSX plugin
The NSX plugin does not support the HeathCheckCommand. Instead it fakes a
PingCommand as a call tot he control cluster status API.
However
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-167517043
@DaanHoogland @remibergsma (cc @nvazquez) can we merge this PR before
master drifts away again?
---
If your project is set up for it, you can reply to
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-167149518
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-167111401
@DaanHoogland I can't figure out why the rats build is failing. Can you
please help us?
---
If your project is set up for it, you can reply to this
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-167105359
I've tested this PR with the additional
[commits](https://github.com/nvazquez/cloudstack/pull/1) that I've requested to
be merged here.
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r48408287
--- Diff: tools/marvin/marvin/lib/base.py ---
@@ -3876,7 +3876,12 @@ def add(cls, apiclient, services, physicalnetworkid,
else
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1285#issuecomment-166936459
I've tested this PR manually in our beta environment, however ince there is
a marvin test for this functionality I would also like to run that. I ha
GitHub user miguelaferreira opened a pull request:
https://github.com/apache/cloudstack/pull/1285
Map LDAP group to Cloudstack account
The LDAP plugin authenticates Cloudstack users against users in an LDAP
group, and when doing so creates a Cloudstack account with the same name as
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1284#issuecomment-166936174
I've tested this PR manually in our beta environment, however ince there is
a marvin test for this functionality I would also like to run that. I ha
Github user miguelaferreira closed the pull request at:
https://github.com/apache/cloudstack/pull/1284
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1284#issuecomment-166936278
Closing as this should have been directed at 4.7 branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user miguelaferreira opened a pull request:
https://github.com/apache/cloudstack/pull/1284
Map ldap group to Cloudstack account
The LDAP plugin authenticates Cloudstack users against users in an LDAP
group, and when doing so creates a Cloudstack account with the same name as
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r48029359
--- Diff: tools/marvin/marvin/lib/base.py ---
@@ -3876,7 +3876,12 @@ def add(cls, apiclient, services, physicalnetworkid,
else
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1236#issuecomment-164376707
@borisroman slf4j sits in a layer above log4j. I?m not sure about the
particular case you are dealing with, however if we were using slf4j with log4j
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-164169523
Thanks for the instructions @serg38
I will attempt to reproduce this early this week.
---
If your project is set up for it, you can reply to this
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164169391
And btw LGTM! Nice one @borisroman
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164169348
Since no one is making a PR to improve all modules, I would say that
incremental improvement is better than no improvement at all. I have done the
same to
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-163586170
@nvazquez I suggested to add the config to the test itself, but I gave it
some more thought and I agree with you that the test should just assume the
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1195#issuecomment-163192866
I don't see a reason why the tests would break after being moved to a
different folder, but hey, better safe than sorry, so thanks @wilderrodrigues
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-162321883
@serg38 I will use CIDR 1 and disconnect the switch from the router, to se
if that works. I haven't' seen any think left behind after testing. Tha
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-162302939
@nvazquez I've been able to verify that the existing tests did not break
with your PR, however I can't seem to get an NSX configuration for runnin
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1178#issuecomment-162225746
ping @nvazquez would you be able to test this PR?
The new marvin test I added requires two hosts in order to test the NSX
tunnel between them
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1178#issuecomment-162225661
As for testing, I've built the entire project executing all unit tests
(including the one I've added to prevent a regression on this issue), the
GitHub user miguelaferreira opened a pull request:
https://github.com/apache/cloudstack/pull/1178
Prevent live-lock in NSX API client
The NSX api client relies on a sequence of responses to identify the need
to authenticate and to follow redirects. In order to avoid live-locks, the
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-162211138
I'm finishing my own test, and will test this PR asap.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-161317452
I'm working on adding a new test case to the test file we already have, but
unfortunately I don't know how to cover your change. What I do k
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-161235643
@nvazquez I have one more request for you, and (if you agree, of course)
that should be the end of it on a code level. With the marvin test then this
would
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46392407
--- Diff:
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/resource/wrapper
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46391389
--- Diff:
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/element/NiciraNvpElement.java
---
@@ -239,8 +244,51 @@ public
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46265732
--- Diff:
api/src/com/cloud/network/guru/NetworkGuruAdditionalFunctions.java ---
@@ -0,0 +1,12 @@
+package com.cloud.network.guru
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46264185
--- Diff: api/src/com/cloud/network/Networks.java ---
@@ -251,6 +252,10 @@ public static URI fromString(String candidate
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46263781
--- Diff: api/src/com/cloud/network/Networks.java ---
@@ -251,6 +252,10 @@ public static URI fromString(String candidate
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46115019
--- Diff: setup/db/db/schema-460to470.sql ---
@@ -18,3 +18,5 @@
--;
-- Schema upgrade from 4.6.0 to 4.7.0;
--;
+
+ALTER
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46115024
--- Diff: setup/db/db/schema-461to470.sql ---
@@ -18,3 +18,5 @@
--;
-- Schema upgrade from 4.6.1 to 4.7.0;
--;
+
+ALTER
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-160545614
@nvazquez I've just read through you code and I made some comments that I
would be happy to discuss with you.
Nice to see effort being put in
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46114822
--- Diff: setup/db/db/schema-460to470.sql ---
@@ -18,3 +18,5 @@
--;
-- Schema upgrade from 4.6.0 to 4.7.0;
--;
+
+ALTER
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46114825
--- Diff: setup/db/db/schema-461to470.sql ---
@@ -18,3 +18,5 @@
--;
-- Schema upgrade from 4.6.1 to 4.7.0;
--;
+
+ALTER
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46114748
--- Diff:
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/resource/wrapper
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46114722
--- Diff:
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/resource/wrapper
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46114716
--- Diff:
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/resource/wrapper
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46114701
--- Diff:
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/resource/wrapper
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46114646
--- Diff:
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/guru/NiciraNvpGuestNetworkGuru.java
---
@@ -102,11 +112,11
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46114312
--- Diff:
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/element/NiciraNvpElement.java
---
@@ -239,8 +244,51 @@ public
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46114230
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
---
@@ -671,8 +672,19 @@ public void
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46114108
--- Diff: api/src/org/apache/cloudstack/api/response/NicResponse.java ---
@@ -102,6 +102,14 @@
@Param(description = "Id of the
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46114122
--- Diff: api/src/org/apache/cloudstack/api/response/NicResponse.java ---
@@ -102,6 +102,14 @@
@Param(description = "Id of the
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46114035
--- Diff:
api/src/com/cloud/network/guru/NetworkGuruAdditionalFunctions.java ---
@@ -0,0 +1,12 @@
+package com.cloud.network.guru
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46113829
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
---
@@ -671,8 +672,19 @@ public void
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46113758
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
---
@@ -671,8 +672,19 @@ public void
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46113707
--- Diff: api/src/com/cloud/network/Networks.java ---
@@ -251,6 +252,10 @@ public static URI fromString(String candidate
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1084#discussion_r45184075
--- Diff: utils/src/main/java/com/cloud/utils/StringUtils.java ---
@@ -310,6 +310,11 @@ public static String mapToString(final Map map
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-156985757
@nvazquez last Friday 4.6.0 was released so current master is now 4.7.0.
Could you please rebase your branch on latest master?
Then @wilderrodrigues
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1056#issuecomment-155703549
I don't think so @DaanHoogland. But if I've miss interpreted what you said,
I'll be happy to have you explain to me what that is.
---
If
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1056#issuecomment-155702506
@DaanHoogland both Optional and Exception will give the opportunity to
handle the "null case", the difference is in the semantics. Optional means
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1056#issuecomment-155679945
We don't need Java 8 to use optional. And yes, optional is meant for
expressing that a value may be present or not. The API is quite clear, I don'
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1056#issuecomment-155525984
If there will be no error recovery for the exception thrown on host ==
null, then you will probably be better off with using Optional. It's in
Java8
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1055#issuecomment-155431369
JVM died:
```
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.324 sec -
in org.apache.cloudstack.privategw.AclOnPrivateGwTest
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1056#issuecomment-155411442
That intention opens up an entire category of errors, null dereferencing).
In addition forces defensive coding, just like what you introduce in this PR
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1055#issuecomment-155410264
I'm testing this PR with a 2 KVM host setup to run a set of basic Marvin
tests. Will also grep the logs for the private key.
---
If your project is s
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1056#issuecomment-155409591
Wouldn't it be better to make sure
`endPointSelector.selectHypervisorHost(...)` never returns null?
---
If your project is set up for it, you can rep
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-155396401
@nvazquez I've built and tested your PR in our environment and the
functionality we have tests for remains stable. :+1:
What I did:
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153701940
JVM died:
https://builds.apache.org/job/cloudstack-pull-analysis/1150/org.apache.cloudstack$cloud-server/console
---
If your project is set up for it, you
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/950#issuecomment-153468603
@borisroman That's what I thought, but no, the `common.loader` property (in
[0] is not what does the trick). I've tried that too and that did not
Github user miguelaferreira closed the pull request at:
https://github.com/apache/cloudstack/pull/950
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/950#issuecomment-153390623
@remibergsma @borisroman I'm closing this PR since I've been able to figure
out how the mysql driver is being loaded in the RPM install. It ha
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/950#issuecomment-153289366
I've searched the legal section of Apache's JIRA and found several posts
about including GPL licensed products in builds and test runs. One in
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/950#issuecomment-153287336
That seems to be LGPL and as such not allowed by apache policy:
http://www.apache.org/legal/resolved.html
The issue to me is more on where do the
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/950#issuecomment-153259670
Hi @borisroman
The travis buld fails ont he unit tests because it would need the developer
profile (`-Pdeveloper`) in this line
https://github.com
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/961#issuecomment-152490396
After digging in a bit more, I've debugged the browser session when hitting
the home page with `session="false"` what I see is that the p
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/961#issuecomment-152474694
In tomcat I see the following errors:
```
Oct 30, 2015 9:39:13 AM org.apache.catalina.core.ApplicationDispatcher
invoke
SEVERE: Servlet.service
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-152197682
@nvazquez I havent' forgotten your PR. I'm having some trouble with the
automation to re-create a NSX cluster with a KVM host in our test enviro
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/996#issuecomment-152124858
@karuturi @remibergsma This is the second PR I look into and find that
Travis is nor running any Marvin tests!
As I said in PR #997, fire few Travis
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/983#issuecomment-152120849
@karuturi I would be very much interested in seeing the results of the
tests that have passed in that environment were you could not get a router to
come up
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/983#issuecomment-152114469
@karuturi How is it possible that "All the tests in BVT tests pass on
xenserver 6.5 host" and "I started seeing below error messages on
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/981#issuecomment-151842878
Hi @serbaut I sometimes have trouble with nose after installing marvin. So
what I do, is to install marvin, and then reinstall nose (forcing it to
actually
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/997#issuecomment-151826908
@runseb Travis is green but no tests are running.
I checked all the builds and the first few say this:
```
$ ./tools/travis/script.sh $TESTS
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-151511065
btw, I'm testing your PR in our setup
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/986#issuecomment-151480065
Built the entire projects with:
`mvn clean install -T4 -Pdeveloper,systemvm`
Result:
```
(...)
Running
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/986#issuecomment-151475377
awesome stuff. Checking it out now to build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/950#issuecomment-151057998
It's already included as a dependency in the `noredist` profile. This PR
includes it as a dependency in the `developer` profile, and forces the MySQL
d
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/950#issuecomment-151050165
The erros, travis and Jenkins report are due to missing mysql connector
jar. Shall I make Travis build with the developer profile (i.e. `-Pdeveloper`)?
Or
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/950#issuecomment-150900045
@borisroman @remibergsma I've rebased on latest master and force pushed it
---
If your project is set up for it, you can reply to this email and have
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/967#issuecomment-150630220
Cool. Will run the build again with this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/971#issuecomment-150604553
@michaelandersen you did not specify `required_hardware=true` are you sure
the tests have actually ran?
---
If your project is set up for it, you can reply
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/972#issuecomment-150602167
I've tested this in a 2 KVM hosts setup (a.k.a
[mct-zone1-kvm1-kvm2.cfg](https://github.com/schubergphilis/MCT-shared/blob/master/marvin/mct-zone1-kvm1
GitHub user miguelaferreira opened a pull request:
https://github.com/apache/cloudstack/pull/972
Fix error message in test_isolate_network_FW_PF_default_routes
While running test_isolate_network_FW_PF_default_routes it is expected
that SSH'ing into a VM does not work immedi
1 - 100 of 244 matches
Mail list logo
