Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

Anything special required to do this POST? Just read this thread when searching for "userdata 2k" and noticed that POST is supposed to be supported, but if I run the following it doesn't work: curl --request POST 'http://localhost:8096/client/api' --data 'command=listVirtualMachines' On Wed, Ap

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/#review18704 --- Is there any automated testing of this feature today? Marvin tests

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/#review18713 --- As long as we have query based API, the overall base64 encoded paylo

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

> On April 5, 2013, 4:03 p.m., Chip Childers wrote: > > Is there any automated testing of this feature today? Marvin tests of the > > HTTP service? Unit tests? > > > > If not, now seems like a good time to add some. I realize you are just > > updating the size of the data field, but IMO we

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

> On April 5, 2013, 5:46 p.m., Rohit Yadav wrote: > > As long as we have query based API, the overall base64 encoded payload in > > the url cannot exceed this limit as per a RFC (I recall discussing this > > issue on ML when I applied this feature from previous ports). > > If we handle POST req

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/ --- (Updated April 5, 2013, 10:22 p.m.) Review request for cloudstack, Chip Childer

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

> On April 5, 2013, 5:46 p.m., Rohit Yadav wrote: > > As long as we have query based API, the overall base64 encoded payload in > > the url cannot exceed this limit as per a RFC (I recall discussing this > > issue on ML when I applied this feature from previous ports). > > If we handle POST req

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

> On April 5, 2013, 5:46 p.m., Rohit Yadav wrote: > > As long as we have query based API, the overall base64 encoded payload in > > the url cannot exceed this limit as per a RFC (I recall discussing this > > issue on ML when I applied this feature from previous ports). > > If we handle POST req

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/ --- (Updated April 10, 2013, 9:59 p.m.) Review request for cloudstack, Chip Childer

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/#review19030 --- server/src/com/cloud/vm/UserVmManagerImpl.java

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/#review19032 --- In your description, you mentioned that it is not extensively tested

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

> On April 11, 2013, 8:54 p.m., Min Chen wrote: > > server/src/com/cloud/vm/UserVmManagerImpl.java, line 2581 > > > > > > Based on your comment, for GET, maxBytes = 4K, for POST, maxBytes = > > 32K. Why not define th

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/ --- (Updated April 16, 2013, 2:53 a.m.) Review request for cloudstack, Chip Childer

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

> On April 11, 2013, 8:55 p.m., Min Chen wrote: > > In your description, you mentioned that it is not extensively tested yet. > > Is this still true? If not, please revise your description to avoid > > confusing people. Not true anymore - apologies for the confusion. I'll put in details of all

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/#review19245 --- tools/marvin/marvin/cloudstackConnection.py

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

> On April 16, 2013, 4:31 a.m., Prasanna Santhanam wrote: > > tools/marvin/marvin/cloudstackConnection.py, line 61 > > > > > > How and when does marvin decide to use POST? Which commands will call > > the POST httpmeth

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

On Wed, Apr 17, 2013 at 11:00 AM, Venkata Siva Vijayendra Bhamidipati < vijayendra.bhamidip...@citrix.com> wrote: > > > > On April 16, 2013, 4:31 a.m., Prasanna Santhanam wrote: > > > tools/marvin/marvin/cloudstackConnection.py, line 61 > > > < > https://reviews.apache.org/r/10294/diff/4/?file=281

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/ --- (Updated April 17, 2013, 5:44 a.m.) Review request for cloudstack, Chip Childer

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

On Wed, Apr 17, 2013 at 11:10:01AM +0530, Rohit Yadav wrote: > > > If it does not cost much, let's introduce a new dependency for requesting > stuff (get or post etc.) using "requests" [1] for both marvin and > cloudmonkey. Vijay, you can write your own requester, as it's not much > effort requir

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

On Wed, Apr 17, 2013 at 11:52:08AM +0530, Prasanna Santhanam wrote: > On Wed, Apr 17, 2013 at 11:10:01AM +0530, Rohit Yadav wrote: > > > > > > If it does not cost much, let's introduce a new dependency for requesting > > stuff (get or post etc.) using "requests" [1] for both marvin and > > cloudm

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

On 17 April 2013 17:10, Prasanna Santhanam wrote: > On Wed, Apr 17, 2013 at 11:52:08AM +0530, Prasanna Santhanam wrote: >> On Wed, Apr 17, 2013 at 11:10:01AM +0530, Rohit Yadav wrote: >> > >> > >> > If it does not cost much, let's introduce a new dependency for requesting >> > stuff (get or post e

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

Would be great if it passes pep8 also.(just my nitpicky self) On 4/17/13 6:49 AM, "prasanna" wrote: >On 17 April 2013 17:10, Prasanna Santhanam wrote: >> On Wed, Apr 17, 2013 at 11:52:08AM +0530, Prasanna Santhanam wrote: >>> On Wed, Apr 17, 2013 at 11:10:01AM +0530, Rohit Yadav wrote: >>> > >>

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

On 17 April 2013 23:13, Chiradeep Vittal wrote: > Would be great if it passes pep8 also.(just my nitpicky self) > Done - I'll clean up the rest of the marvin modules gradually.

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/ --- (Updated April 23, 2013, 1:49 a.m.) Review request for cloudstack, Chip Childer

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/ --- (Updated April 23, 2013, 1:52 a.m.) Review request for cloudstack, Chip Childer

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/ --- (Updated April 23, 2013, 1:55 a.m.) Review request for cloudstack, Chip Childer

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/#review19572 --- - Venkata Siva Vijayendra Bhamidipati On April 23, 2013, 1:55 a.m.

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/ --- (Updated April 23, 2013, 1:57 a.m.) Review request for cloudstack, Chip Childer

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/#review19574 --- The patch doesn't apply for me: ~/workspace/cloudstack/incubator-cl

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

Vijay - Min applied the patch in the branch http_post. I made changes to your test to make it use libraries from marvin appropriately. Don't hesitate to go change marvin if it makes sense to next time. What I'm seeing is that in your examples you've attached - you send all the request for deployVM

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

Also - you need to run a RAT test before the merge (if and when it happens). The test file doesn't have a license header for ASF. -- Prasanna., On Wed, Apr 24, 2013 at 12:13:33AM +0530, Prasanna Santhanam wrote: > Vijay - Min applied the patch in the branch http_post. I made changes > to your te

RE: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

[mailto:t...@apache.org] Sent: Tuesday, April 23, 2013 11:51 AM To: Vijayendra Bhamidipati; Min Chen; Chip Childers; CloudStack Dev Subject: Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request Also - you need to run a RAT test before the merge (i

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/ --- (Updated April 23, 2013, 9:45 p.m.) Review request for cloudstack, Chip Childer

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

On Tue, Apr 23, 2013 at 02:08:09PM -0700, Vijayendra Bhamidipati wrote: > Hi Prasanna, > > Thanks for catching the absence of license in the new file - I'll make the > required changes. > > Regarding the POST, the whole query needs to be sent in as a POST > query and not only the userdata as POS

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

On Tue, Apr 23, 2013 at 02:08:09PM -0700, Vijayendra Bhamidipati wrote: > Hi Prasanna, > > Thanks for catching the absence of license in the new file - I'll make the > required changes. > > Regarding the POST, the whole query needs to be sent in as a POST > query and not only the userdata as POS

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/#review19680 --- Ship it! Ship It! - Min Chen On April 23, 2013, 9:45 p.m., Venka

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

> On April 24, 2013, 11:29 p.m., Min Chen wrote: > > Ship It! Prasanna has fixed the marvin test and pushed to master. These are the rebased commits on master: 4e9e7937ed5e56cbd7f678b2ed9863a56af16635 Fix Vijay's test to use the marvin integratin libararies b0caae6b33347f36721f28dca1fa12e7b18f1