Re: [commons-text] Additional CaseUtils type functionality that can handle snake, kebab, camel, pascal, and others

2023-08-09 Thread Daniel Watson
I would think it's possible to hide that "configuration" from the user such that the implementation can only be reconfigured via extension. But I'm not in love with the configurable base class either way. It was convenient to have the common functionality in one place, but it's not a big deal to

Re: [commons-text] Additional CaseUtils type functionality that can handle snake, kebab, camel, pascal, and others

2023-08-09 Thread Elliotte Rusty Harold
On Wed, Aug 9, 2023 at 11:36 PM Daniel Watson wrote: > > Meant to add... > > The reason I would favor exceptions is that the underlying implementation > can be easily customized. If the user needs to allow non alphanumeric > characters there is a boolean flag in the underlying abstract class >

Re: [commons-text] Additional CaseUtils type functionality that can handle snake, kebab, camel, pascal, and others

2023-08-09 Thread Elliotte Rusty Harold
On Wed, Aug 9, 2023 at 11:50 PM Daniel Watson wrote: > my-component-1 > > Is a valid kebab cased string, with tokens my,component,1 > > However this cannot be formatted in camel case or Pascal case, because they > are delimited by alpha characters. > Not necessarily so. The last implementation

Re: [Crypto] Compile From Source and Openssl3 Support

2023-08-09 Thread Daniel Thertell
Okay thanks Alex, I haven't looked at the Docker file! I just called make in the root of the project. I will be digging into it more tomorrow! Dan Thertell On Wed, Aug 9, 2023, 8:21 p.m. Alex Remily wrote: > I've been meaning to add openssl3 support to common crypto for a while > now. Maybe

Re: [Crypto] Compile From Source and Openssl3 Support

2023-08-09 Thread Alex Remily
I've been meaning to add openssl3 support to common crypto for a while now. Maybe this will give me the push that I need. I'm on my phone now without access to the branch, but I recall a docker file that provided a lot of build information on the main branch. You may consider having a look if

Re: [commons-text] Additional CaseUtils type functionality that can handle snake, kebab, camel, pascal, and others

2023-08-09 Thread Daniel Watson
Currently those exceptions do capture token and character index information, but i think im just using it to create the message. I get what you're saying but without them testing becomes less accurate. If IAE is being thrown all over the place then asserting a failure can't actually guarantee that

Re: [commons-text] Additional CaseUtils type functionality that can handle snake, kebab, camel, pascal, and others

2023-08-09 Thread Gary Gregory
IMO, these can all be replaced by IAE because there is nothing I would do as a call site if I caught one of these custom exceptions vs. another, it's all the same issue, probably bad user input. The only reason to create a custom exception would be to wrap additional information like a location

[ANNOUNCEMENT] Apache Commons DbUtils 1.8.0

2023-08-09 Thread Gary Gregory
The Apache Commons DbUtils team is pleased to announce the release of Apache Commons DbUtils 1.8.0. The Apache Commons DbUtils package is a set of Java utility classes for easing JDBC development. This is a feature and bug fix release, read the change log here:

Re: [commons-text] Additional CaseUtils type functionality that can handle snake, kebab, camel, pascal, and others

2023-08-09 Thread Daniel Watson
Meant to add... The reason I would favor exceptions is that the underlying implementation can be easily customized. If the user needs to allow non alphanumeric characters there is a boolean flag in the underlying abstract class (AbstractConfigurableCase) that will simply turn that validation off.

Re: [commons-text] Additional CaseUtils type functionality that can handle snake, kebab, camel, pascal, and others

2023-08-09 Thread Daniel Watson
Currently I'm planning a set of exceptions that are thrown for various reasons. I created multiple classes to allow for clearer testing. ReservedCharacterException (extends InvalidCharacterException below) - thrown specifically when a reserved character is encountered within a token.

Re: [commons-text] Additional CaseUtils type functionality that can handle snake, kebab, camel, pascal, and others

2023-08-09 Thread Gary Gregory
How is null helpful when you provide a string with a typo for example? I would expect something like "Illegal character '[' at index 34". Gary On Wed, Aug 9, 2023, 6:52 PM Hasan Diwan wrote: > [content inline] > > On Wed, 9 Aug 2023 at 15:47, Elliotte Rusty Harold > wrote: > > > Checked

Re: [commons-text] Additional CaseUtils type functionality that can handle snake, kebab, camel, pascal, and others

2023-08-09 Thread Hasan Diwan
[content inline] On Wed, 9 Aug 2023 at 15:47, Elliotte Rusty Harold wrote: > Checked exception is almost certainly wrong. But I'm not sure we need > any exception at all here. I don't think these methods need any > exceptions at all aside from NullPointerException for null inputs. > Otherwise,

Re: [commons-text] Additional CaseUtils type functionality that can handle snake, kebab, camel, pascal, and others

2023-08-09 Thread Elliotte Rusty Harold
Checked exception is almost certainly wrong. But I'm not sure we need any exception at all here. I don't think these methods need any exceptions at all aside from NullPointerException for null inputs. Otherwise, every string should have a deterministic representation in camel case, pascal case,

Re: [commons-text] Additional CaseUtils type functionality that can handle snake, kebab, camel, pascal, and others

2023-08-09 Thread Hasan Diwan
[content inline] On Wed, 9 Aug 2023 at 15:08, Elliotte Rusty Harold wrote: > What happens when a token contains an unpermitted character? > Three possibilities: 1. null -- favoured by Square's HTTP implementation. 2. a checked Exception --preferred by the JDK. 3. an unchecked Exception --

Re: [commons-text] Additional CaseUtils type functionality that can handle snake, kebab, camel, pascal, and others

2023-08-09 Thread Gary Gregory
Probably should be an IAE...? Gary On Wed, Aug 9, 2023, 6:07 PM Elliotte Rusty Harold wrote: > What happens when a token contains an unpermitted character? > > On Wed, Aug 9, 2023 at 8:30 PM Daniel Watson wrote: > > > > Here's my stab at a spec. Wanted to clarify some parts of the Case > >

Re: [Codec] clearing input byte array vs not

2023-08-09 Thread Gary Gregory
The class comment says the code originates in FreeBSD C. Gary On Wed, Aug 9, 2023, 6:03 PM Elliotte Rusty Harold wrote: > This makes sense to me. The existing behavior seems surprising and > incorrect. Is there a reason for it? > > On Wed, Aug 9, 2023 at 6:53 PM Gary Gregory > wrote: > > > >

Re: [commons-text] Additional CaseUtils type functionality that can handle snake, kebab, camel, pascal, and others

2023-08-09 Thread Elliotte Rusty Harold
What happens when a token contains an unpermitted character? On Wed, Aug 9, 2023 at 8:30 PM Daniel Watson wrote: > > Here's my stab at a spec. Wanted to clarify some parts of the Case > interface first before jumping into the implementations. Wondering what a > good package name for this stuff

Re: [Codec] clearing input byte array vs not

2023-08-09 Thread Elliotte Rusty Harold
This makes sense to me. The existing behavior seems surprising and incorrect. Is there a reason for it? On Wed, Aug 9, 2023 at 6:53 PM Gary Gregory wrote: > > Hi all, > > Any thoughts on https://github.com/apache/commons-codec/pull/197 > > Gary -- Elliotte Rusty Harold elh...@ibiblio.org

Re: [Crypto] Compile From Source and Openssl3 Support

2023-08-09 Thread Daniel Thertell
ya that's totally fine! I will continue to try and figure this out. Thanks, Dan Thertell On Wed, Aug 9, 2023 at 4:53 PM Gary Gregory wrote: > The branch is work in progress from a while ago, and it did not work > completely, that much i remember. I can't take the time today to look at it >

Re: [Crypto] Compile From Source and Openssl3 Support

2023-08-09 Thread Gary Gregory
The branch is work in progress from a while ago, and it did not work completely, that much i remember. I can't take the time today to look at it today, I'm looking at other issues in Commons. Gary On Wed, Aug 9, 2023, 4:27 PM Daniel Thertell wrote: > Hey Gary > > I believe I managed to get it

Re: [Codec] clearing input byte array vs not

2023-08-09 Thread Gary D. Gregory
Done and done in git master. Next, is how to document or change org.apache.commons.codec.digest.Crypt.crypt(byte[], String): The method clears the input byte array for all input types _except_ when calling UnixCrypt [1]. I could: (1) Document the inconsistency (right now, I left it unsaid)

Re: [commons-text] Additional CaseUtils type functionality that can handle snake, kebab, camel, pascal, and others

2023-08-09 Thread Daniel Watson
Here's my stab at a spec. Wanted to clarify some parts of the Case interface first before jumping into the implementations. Wondering what a good package name for this stuff is, given that "case" is a reserved word? Case (interface) The Case interface defines two methods: * String format(Iterable

Re: [Crypto] Compile From Source and Openssl3 Support

2023-08-09 Thread Daniel Thertell
Hey Gary I believe I managed to get it to build, however I do have a few questions. 1. Why were the make targets for the header files commented out and pointing to the wrong locations (in the make file)? 2. After successfully running make, how do I package everything into a JAR for testing?

Re: [Codec] clearing input byte array vs not

2023-08-09 Thread Mark Thomas
Reject it. And document the existing behavior. Mark On 09/08/2023 19:52, Gary Gregory wrote: Hi all, Any thoughts on https://github.com/apache/commons-codec/pull/197 Gary - To unsubscribe, e-mail:

Re: [commons-math] function or Number class to count/track number of significant figures

2023-08-09 Thread Daniel Watson
I believe the convention is to take the *least* precise term and apply that precision (here "precision" != "sigfigs" - Ive been using both terms to mean sigfigs, but for these purposes precision is actually defined as how small a fraction the measurement is able to convey - e.g 0.01 is more

[Codec] clearing input byte array vs not

2023-08-09 Thread Gary Gregory
Hi all, Any thoughts on https://github.com/apache/commons-codec/pull/197 Gary

Re: [Crypto] Compile From Source and Openssl3 Support

2023-08-09 Thread Daniel Thertell
Hey Gary, lol ya I also have that note keeping issue! By any chance do you know what the version env variable should be? I am using 3_0_X right now. Thanks, Dan Thertell On Wed, Aug 9, 2023 at 2:10 PM Gary Gregory wrote: > I should have kept notes! > > Gary > > On Wed, Aug 9, 2023, 1:49 PM

Re: [Crypto] Compile From Source and Openssl3 Support

2023-08-09 Thread Gary Gregory
I should have kept notes! Gary On Wed, Aug 9, 2023, 1:49 PM Daniel Thertell wrote: > Hey All, > > I am looking to compile Commons Crypto from source and I am wondering if > there is any documentation for this process? I am trying to build Gary > Gregory's OpenSSL3 branch but I am encountering

Re: [commons-math] function or Number class to count/track number of significant figures

2023-08-09 Thread Alex Herbert
On Wed, 9 Aug 2023 at 17:13, Daniel Watson wrote: > BigSigFig result = new BigSigFig("1.1").multiply(new BigSigFig("2")) Multiply is easy as you take the minimum significant figures. What about addition? 12345 + 0.0001 Here the significant figures should remain at 5. And for this: 12345 +

[crypto] Compiling from source

2023-08-09 Thread Daniel Thertell
Hey All, I am looking to compile Commons Crypto from source and I am wondering if there is any documentation for this process? I am trying to build Gary Gregory's OpenSSL3 branch but I am encountering the following error, I know this isn't the main branch but I am hoping someone will still be

[Crypto] Compile From Source and Openssl3 Support

2023-08-09 Thread Daniel Thertell
Hey All, I am looking to compile Commons Crypto from source and I am wondering if there is any documentation for this process? I am trying to build Gary Gregory's OpenSSL3 branch but I am encountering the following error. I know this isn't the main branch but I am hoping someone will still be

Re: [commons-math] function or Number class to count/track number of significant figures

2023-08-09 Thread Daniel Watson
Ah I see what you were asking. Yes it is up to the human entering data to understand that 1 has exactly one sigfig according to standard convention. If you need it to have more then you must write it in full scientific notation. Obviously If a specific precision is required due to some flaw in

Re: [commons-math] function or Number class to count/track number of significant figures

2023-08-09 Thread Alex Herbert
On Wed, 9 Aug 2023 at 15:43, Daniel Watson wrote: > > Hope that answers more questions than it creates! It does not address the issue of the last significant zero, e.g: 1 (4 sf) 1 (3 sf) 1 (2 sf) One way to solve this with standard parsing would be to use scientific notation:

Re: [commons-math] function or Number class to count/track number of significant figures

2023-08-09 Thread Daniel Watson
Before I answer your questions - I'll say that looking at the commons-math codebase it is apparent that it's focused on specific functional computation, rather than util-like features. So I agree this probably doesn't fit well there. I honestly did not know commons-numbers existed. I'll check

Re: [commons-math] function or Number class to count/track number of significant figures

2023-08-09 Thread Alex Herbert
Hi, On Wed, 9 Aug 2023 at 12:27, Daniel Watson wrote: > This feature is necessary when working with scientific/clinical data which > was reported with significant figures in mind, and for which calculation > results must respect the sigfig count. As far as I could tell there is no > Number

[commons-math] function or Number class to count/track number of significant figures

2023-08-09 Thread Daniel Watson
I noticed there is not (or I could not find) a function within commons-math to count the number of significant figures in a number string. I wrote a function to do it and want to make sure I'm not missing something within commons-math before submitting a PR. This feature is necessary when working