onNativeReady and FirefoxOS

2013-06-25 Thread Piotr Zalewa
Hi, Here is me again. I commented out the reinstantiating window.navigator to make it not throw SecurityError under FxOS. I then realized the 'deviceready' isn't fired. It should be fired in https://github.com/apache/cordova-firefoxos/blob/master/lib/cordova.firefoxos.js#L5977 after

Re: onNativeReady and FirefoxOS

2013-06-25 Thread Andrew Grieve
likely you want to add a bootstrap.firefoxos.js file On Tue, Jun 25, 2013 at 3:40 AM, Piotr Zalewa pzal...@mozilla.com wrote: Hi, Here is me again. I commented out the reinstantiating window.navigator to make it not throw SecurityError under FxOS. I then realized the 'deviceready' isn't

Re: Android - Removing the .api namespace

2013-06-25 Thread Marcel Kinard
Sounds like I missed something. What firm date? On Jun 24, 2013, at 2:04 PM, Joe Bowser bows...@gmail.com wrote: Unlike other releases, 3.0 is the only one with a firm date.

Re: onNativeReady and FirefoxOS

2013-06-25 Thread Gord Tanner
I could have swore there was one at one point ;) but it is going to look exactly like the webos one [1] [1] - https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;a=blob_plain;f=lib/scripts/bootstrap-webos.js;hb=HEAD On Tue, Jun 25, 2013 at 10:52 AM, Andrew Grieve

Re: Cordova Blog

2013-06-25 Thread Brian LeRoux
ya for sure, its basically a jekyll like clone now On Mon, Jun 24, 2013 at 9:05 PM, Carlos Santana csantan...@gmail.com wrote: Brian you mean port the whole site to JekyII? On Tue, Jun 25, 2013 at 12:03 AM, Brian LeRoux b...@brian.io wrote: +1 lets port the whole template over On Jun 24,

Re: Cordova 2.9.0 Final

2013-06-25 Thread Andrew Grieve
Coho introduces no change in process, but it does automate some steps of the existing process. On Mon, Jun 24, 2013 at 6:51 PM, Brian LeRoux b...@brian.io wrote: Yes. The idea would be, as it always has been, the platform maintainers tag as their vote. That tag says, 'hey this part is

Re: Android - Removing the .api namespace

2013-06-25 Thread Brian LeRoux
July 19. In the past we've aimed at the last tues of every month. On Tue, Jun 25, 2013 at 8:34 AM, Marcel Kinard cmarc...@gmail.com wrote: Sounds like I missed something. What firm date? On Jun 24, 2013, at 2:04 PM, Joe Bowser bows...@gmail.com wrote: Unlike other releases, 3.0 is the only

Which repo?

2013-06-25 Thread Don Coleman
Should fixes for Media Capture go in cordova-android or cordova-plugin-media-capture or both?

Re: Which repo?

2013-06-25 Thread Simon MacDonald
Bug fixes should probably go into both. The cordova-android repo will be the long lived one for the 2.9.x stream and cordova-plugin-media-capture will be used in 3.x. Simon Mac Donald http://hi.im/simonmacdonald On Tue, Jun 25, 2013 at 12:00 PM, Don Coleman don.cole...@gmail.com wrote: Should

Re: Cordova 2.9.0 Final

2013-06-25 Thread Joe Bowser
Coho does introduce a change in the process, because instead of all the platform maintainers tagging their code, we have one person tagging everything. If a tag is the vote, this is stuffing the ballot box. It's bad enough that we can vote twice. Now, I'm personally OK with us decoupling

Clone Plugin Repos via coho

2013-06-25 Thread Andrew Grieve
To quickly clone all plugin repos: ./cordova-coho/coho repo-clone -r plugins

Re: Cordova 2.9.0 Final

2013-06-25 Thread Andrew Grieve
Ahh, okay, I see what you mean about the change. The jira bug says to tag them all in one command, which doesn't fit in with the using a tag as a vote idea. I'll update the JIRA issue to not use -r active-platform flag. Joe - I just pushed a change that adds a --pretend flag to the tag-release

Re: Cordova 2.9.0 Final

2013-06-25 Thread Andrew Grieve
Also - if coho is not working for you or that you feel like it's slowing you down, feel free to just run the same old git commands directly. On Tue, Jun 25, 2013 at 12:49 PM, Andrew Grieve agri...@chromium.orgwrote: Ahh, okay, I see what you mean about the change. The jira bug says to tag

Re: [plugins] xmls in cordova plugin.xml

2013-06-25 Thread Filip Maj
For the record the spec doc is located inside the cordova-plugman repo [1]. [1] https://github.com/apache/cordova-plugman/blob/master/plugin_spec.md On 6/24/13 2:23 PM, Benn Mapes benn.ma...@gmail.com wrote: I've noticed two different xmls namespaces for the core cordova plugins :

Re: Cordova 2.9.0 Final

2013-06-25 Thread Joe Bowser
I don't have a --short for symbolic-ref, and I already posted the stack trace: Here's what I get when I'm on the 2.9.x branch. Am I supposed to be on something else? Shouldn't coho be smart enough to deal? Can we make it easier to debug when things go off the rails?

Gave up on coho for now, errors with grunt

2013-06-25 Thread Joe Bowser
Hey I gave up on coho, so just to do sanity, I tried using grunt to generate the packages, and I get the following after the unit tests finish. Fatal error: undefined is not a function So, what runs after the tests again? Should we just not care about this? I'm not familiar with grunt enough to

Re: building cordova 3.0

2013-06-25 Thread Filip Maj
One method that I've used is with cordova-cli. You can point cordova-cli to use a local copy of a particular platform implementation. So, I would clone down and check out the 3.0 branch for cordova-ios, android, etc. Create a project with `cordova create tmp`. Edit tmp/.cordova/config.json so it

Re: Cordova 2.9.0 Final

2013-06-25 Thread Andrew Grieve
Hey Joe - not sure what happened, but would love to know what errors you're now seeing. Looks like the tagging of Android didn't go quite right: https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=log;h=df1536ea77e97b7d362a19582f8beddd168c5ec3 There shouldn't be a merge commit (I

Re: cordova-plugin-vibration?

2013-06-25 Thread Andrew Grieve
Okay, filed a JIRA issue: https://issues.apache.org/jira/browse/INFRA-6458 On Tue, Jun 25, 2013 at 4:53 PM, Steven Gill stevengil...@gmail.com wrote: Sorry I wasn't very clear. Vibration code will go into cordova-plugin-vibration. This is where the vibration + notification code currently

Re: cordova-plugin-vibration?

2013-06-25 Thread Steven Gill
Both of the repos already exist! Cordova-plugin-vibration has all of the vibration + notification code already. The notification code needs to be split up from vibration and moved into the cordova-plugin-dialogs repo. On Tue, Jun 25, 2013 at 4:08 PM, Andrew Grieve agri...@chromium.org wrote:

[cordova-js] Order of internal cordova events and docs

2013-06-25 Thread Benn Mapes
Not sure if this is doc'ed anywhere, I looked on the wiki but I didn't see anything. Currently the order of events for page-load/cordova start-up is this (on windows phone): 1.) onDOMContentLoaded 2.) onPluginsReady 3.) onNativeReady 4.) onCordovaReady 5.) onCordovaInfoReady 6.) deviceready

Re: Cordova 2.9.0 Final

2013-06-25 Thread Joe Bowser
I pushed to the 2.9.0 branch, but someone snuck a commit in on run. I then decided to re-tag it, since this is a script change, and not anything that required re-testing. On Tue, Jun 25, 2013 at 4:04 PM, Andrew Grieve agri...@chromium.org wrote: Hey Joe - not sure what happened, but would love

Re: [cordova-js] Order of internal cordova events and docs

2013-06-25 Thread Andrew Grieve
The order isn't meant to be serially defined. Many platforms fire onNativeReady as the first channel fired. Some do have dependencies though, and you can see them in code by looking for where channel.join() is called. Your options: If you want your code to run as soon as possible, you should put

Re: Cordova 2.9.0 Final

2013-06-25 Thread Shazron
iOS, OS X tagged On Tue, Jun 25, 2013 at 3:41 PM, Steven Gill stevengil...@gmail.com wrote: Hey All, I would really appreciate if we could get the tags rolling. I am heading out for nodeconf on Thursday and want to get the release out tomorrow before I leave. Are there any issues holding

Plugin Loading method

2013-06-25 Thread Jesse
Open question: How do we plan to load plugins in 3.0.0 ? a) Load cordova_plugins.json via XHR b) Load cordova_plugins.js via script injection Currently we attempt (a) and failing that attempt (b). [1] Currently (a) fails on WP7+8, part of which is the subject of the 'events' thread. [2] It

Re: Cordova 2.9.0 Final

2013-06-25 Thread Andrew Grieve
A couple git tips that I learned recently: git pull --rebase will eliminate merge commits that are due to pulling when a local commit has been made. If you failed to --rebase and have a merge commit: git rebase origin/master (assuming you're on master) will reorder your commits to make your

Re: Plugin Loading method

2013-06-25 Thread Andrew Grieve
Yeah, I don't like that we have two approaches. We have a valid reason to use b (windows phone), so let's use it. On Tue, Jun 25, 2013 at 7:36 PM, Jesse purplecabb...@gmail.com wrote: Open question: How do we plan to load plugins in 3.0.0 ? a) Load cordova_plugins.json via XHR b) Load

[Android] config.xml: What is url-filter?

2013-06-25 Thread Joe Bowser
Hey What's the URL filter tag for? Is it in our current XML schema? If not, I'm tempted to just rip this thing out, since I have no idea what it does. Joe

Re: [Android] config.xml: What is url-filter?

2013-06-25 Thread Andrew Grieve
Looking at the code, it looks like it allows plugins to handle shouldOverrideUrlLoading(). That said, I don't know why it needs a config.xml entry instead of just looping through the plugins always (like most other plugin hooks) On Tue, Jun 25, 2013 at 8:08 PM, Joe Bowser bows...@gmail.com

Re: Cordova 2.9.0 Final

2013-06-25 Thread Andrew Grieve
A personal preference perhaps, but an Apache no-no? Are you sure? This isn't re-writing upstream history, and would go along the same lines as saying that you should never squash your work-in-progress commits, which we've been advocating that you do on all of our wiki pages. We also tell