Hi John,
Thanks for that bug and sorry for overlooking it. I've been swamped by iOS
8 issues lately, but I will respond in the issue.
On Thu, Sep 18, 2014 at 12:08 PM, John M. Wargo jwarg...@gmail.com wrote:
Back in January I did a bunch of research on the issue I identified
regarding how
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/26#issuecomment-56139405
Rebased. @purplecabbage, pls. review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/43#issuecomment-56139471
Rebased. @purplecabbage, pls. review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/64
Windows implementation fixes and improvements
1. Added {keepCallback: true} so that it can propagate several navigation
events
2. calc(100% - 80px) style instead of
Github user nowned closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/44
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user nowned commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/44#issuecomment-5614
Oh sorry, I missed your first message.
Closed now!
---
If your project is set up for it, you can reply to this email and have your
reply
Thank you Jesse!
Media-capture PR has been rebased.
https://github.com/apache/cordova-plugin-media-capture/pull/26#issuecomment-56118695
InAppBrowser - I've closed my original PR but sent another one since it
contains one critical fix to make it working correct (keepCallback), more
details
Github user sgrebnov closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/53
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/53#issuecomment-56141194
Closing sine PR#52 was merged (same functionality)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
OK. Thanks for this information!
Regards,
Shingo
-Original Message-
From: Shazron [mailto:shaz...@gmail.com]
Sent: Friday, September 19, 2014 2:05 AM
To: dev@cordova.apache.org
Subject: Re: iOS8 support
It should. The updates to support iOS 8 are all in the plugins, which are in a
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-windows/pull/46
CB-7601 Build fails due to capabilities with m: prefixes are incorrectly
sorted
https://issues.apache.org/jira/browse/CB-7601
You can merge this pull request into a Git repository by
Nope. This discussion is about tweaking our process going forward. I want to
get 3.6 live as soon as the voting is complete, which is happening in the
thread titled [Vote] Tools Release 3.6.3-0.2.13. Hmm, there are no other
votes there yet besides mine. Folks, please review, vote, and let's get
Well...with that in mind. If this is something you think would be useful in
Cordova - you can go ahead and use it.
I've signed a CLA and I'm already contributing (not code, but stuff with the
APIs and so on, hopefully docs in the near future), so if the project thinks
it's useful, I can
Hi,
Currently LIB is on response for handling config.xml params and updating
platforms, for example on Android[1] LIB edits AndroidManifest.xml as per
config.xml, handles icons and splash images, etc. Moving forward with
independed platform releases I see how it would be valuable to be able
I vote +1:
* Verified signatures and hashes
* Verified ability to create and run Cordova app with windows and wp8 platforms
* Installed from npm via npm -g install cordova@rc to check that all the
correct versions were loaded, created and built windows and wp8 projects
Thx!
Sergey
-Original
Jesse - any chance you can merge this pull request? :)
https://github.com/phonegap-build/PushPlugin/pull/253
On Thu, Sep 18, 2014 at 3:56 PM, Jesse purplecabb...@gmail.com wrote:
I have also recently published this one:
com.phonegap.plugins.pushplugin@2.2.1
With recently added support for
No strong opinion, but I'm leaning with Michael. Have there been examples
of nested dependency version mismatches actually biting us that we are
insistent on shrinkwrap?
For the record, last time I looked into this, npm commands were a bit
limited when it comes to easily managing dependency
Not sure about this. On the surface the request seems fine, but I think
its easier to do lib updates than platform updates, and the reverse problem
would happen if we made the switch: if we want to improve the way we do
parsing (say to add a new config option), we now have to do a full platform
Michal, I see your point, but in this particular example we can still implement
this inside LIB or rely on platform implementation/release. Platform prepare is
just a step of main prepare, both can add changes. Another point is that
platforms could be used w/o CLI so new configuration parameter
It would seem that the separation in that case should be between what and
how -- make -lib responsible for what needs to be done (add an icon,
add a splash screen, set the start page), and the platforms responsible for
actually implementing it.
(Obviously easy to say; I'm sure there are a hundred
..and just found this: https://github.com/alanshaw/david
On Fri, Sep 19, 2014 at 9:57 AM, Michal Mocny mmo...@chromium.org wrote:
No strong opinion, but I'm leaning with Michael. Have there been examples
of nested dependency version mismatches actually biting us that we are
insistent on
I vote +1
- Verified signatures and hashes
- installed rc via npm
- created, built and ran an android project on OS X
Github user puneetgkaur commented on the pull request:
https://github.com/apache/cordova-lib/pull/83#issuecomment-56190394
I rebased to merge conflicts and appveyor is failing, can someone help ?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user martincgg commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/117#discussion_r17791920
--- Diff: framework/src/org/apache/cordova/CordovaChromeClient.java ---
@@ -123,7 +128,8 @@ public boolean onKey(DialogInterface dialog, int
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-lib/pull/83#issuecomment-56194993
The PR should list only your new commits, it currently shows 123 commits.
To handle appveyor problem I would recommend to start from running 'npm test
locally to
Github user puneetgkaur commented on the pull request:
https://github.com/apache/cordova-lib/pull/83#issuecomment-56195274
Thanks, resolved it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user puneetgkaur commented on the pull request:
https://github.com/apache/cordova-lib/pull/83#issuecomment-56195332
It shows commit because I had rebased to resolve the merge conflicts
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user puneetgkaur commented on the pull request:
https://github.com/apache/cordova-lib/pull/83#issuecomment-56196138
Can someone please merge this pull request and for more details regarding
the project have a look here : http://sugarcordova.blogspot.in/ and
Github user puneetgkaur commented on the pull request:
https://github.com/apache/cordova-lib/pull/83#issuecomment-56196433
Would request the cordova committers to kindly review this pull request and
merge it.
---
If your project is set up for it, you can reply to this email and have
On Sep 18, 2014, at 1:32 PM, Parashuram Narasimhan (MS OPEN TECH)
panar...@microsoft.com wrote:
If we do have shrinkwrap in git at all times, who would be responsible for
updating not only the versions of our dependencies, but also the dependencies
of these dependencies?
One thought on
I really like this metaphor / approach, and would love to see it guide future
work in lib and platforms.
On Sep 19, 2014, at 10:09 AM, Ian Clelland iclell...@chromium.org wrote:
It would seem that the separation in that case should be between what and
how. -- make -lib responsible for what
When do we plan to release updated docs? - Can't find any discussion regarding
this.
Thx!
Sergey
I've already got the 3.6 docs built locally, but was waiting to publish them
until we cleared the votes on platforms and tools for 3.6. Hopefully the vote
will clear at the end of today.
On Sep 19, 2014, at 1:00 PM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com
wrote:
When do we plan to
Thanks, Marcel!
-Original Message-
From: Marcel Kinard [mailto:cmarc...@gmail.com]
Sent: Friday, September 19, 2014 9:04 PM
To: dev@cordova.apache.org
Subject: Re: 3.6.0 docs release
I've already got the 3.6 docs built locally, but was waiting to publish them
until we cleared the votes
I'm w/ Mike on this. No idea why we started using shrinkwrap, its always
had a flaky rep, and if we don't remember why then I'm guessing we might
have decided to use it for reasons that may have been more defensive than
actually solving a problem we had. Lets turf it. If bugs get reported then
we
GitHub user bryanhiggins opened a pull request:
https://github.com/apache/cordova-lib/pull/88
CB-7572 Serve - respond with 304 when resource not modified
This will prevent a lot of unnecessary network traffic, especially in
situations such as a list control which has the same icon
@Brian shrinkwrap was implemented in the release process because it was
discuss in the mailing list and agreed, no -1 votes
http://markmail.org/thread/j6bv5bk5ndlokobj
can someone show me a jira issue or contributor having problems with having
npm-shrinkwrap.json in the npm package only?
On
So I think its neat we had a vote but was there a technical reason for it?
Nope. Lets kill it.
On Fri, Sep 19, 2014 at 11:23 AM, Carlos Santana csantan...@gmail.com
wrote:
@Brian shrinkwrap was implemented in the release process because it was
discuss in the mailing list and agreed, no -1
+ 1 leave it in npm package
+ 1 take it out from git
Technical reasons:
1. better architecture to have all end user use the same version of all the
code.
2. when we test here in ibm and install cordova from npm we know that all
testers are testing the same code,
Legal related reason:
1. We need
On Sep 18, 2014, at 1:28 PM, Parashuram Narasimhan (MS OPEN TECH)
panar...@microsoft.com wrote:
About the release branches, is the idea that we continue to push stuff on
master and then create a new 3.7.0 branch when we would like to release 3.7.0?
For plugins and tools, I suggest that we
ha, legal! thats why but thats not a technical reason. =)
we could argue all day about subjective things like architecture but
generally speaking in the node community the feeling is that shrinkwrap is
harmful … we do not have a technical issue here, nor have we, but we do
have deployment
Ping. No other votes yet. So where are we at with this?
On Sep 18, 2014, at 2:53 PM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com
wrote:
Hi, I'm still waiting for the following PRs to be reviewed/merged. Most of
them are critical to have plugins working on Windows 8.1 and Windows Phone
These have/are being merged, but nothing should block anything.
If we need to release some plugins next week, then we can do that. Nothing
should ever stop the train, if it doesn't make into this one it can go in
the next one.
@purplecabbage
risingj.com
On Fri, Sep 19, 2014 at 11:58 AM, Marcel
It's working fine today being present in the npm package, I don't think we
should remove it just because of a feeling
On Fri, Sep 19, 2014 at 2:51 PM, Brian LeRoux b...@brian.io wrote:
ha, legal! thats why but thats not a technical reason. =)
we could argue all day about subjective things
nothing should stop the train I like that motto Jesse. We're the
Snowpiercer!
I'll try to see if I have time later today to verify plugins, seeing that
they are important for iOS 8 and all.
On Fri, Sep 19, 2014 at 12:01 PM, Jesse purplecabb...@gmail.com wrote:
These have/are being merged, but
kidding aside if the community feels strongly to take it out from both npm
and git, I would respect the decision and shut up !
I live and die by the community :-)
On Fri, Sep 19, 2014 at 3:11 PM, Carlos Santana csantan...@gmail.com
wrote:
It's working fine today being present in the npm
Bryan - yes I can. Why the changes to Android though?
deleted: src/android/com/plugin/android-support-v13.jar
https://github.com/phonegap-build/PushPlugin/pull/253/files#diff-2
plugin.xml
+ dependency id=android.support.v4 /
@purplecabbage
risingj.com
On Fri, Sep 19, 2014 at 6:56 AM, Bryan
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/46
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
I am totally behind the idea of nightly builds! Great summary Marcel.
My plan has been to start work on a nightly build system after independent
platform releases are out the door.
Release branches
For indy releases, my plan was to remove cutting release branches for
cordova-js. Cordova-js
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-media-capture/pull/26
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/64
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Done
@purplecabbage
risingj.com
On Thu, Sep 18, 2014 at 11:46 PM, Sergey Grebnov (Akvelon)
v-seg...@microsoft.com wrote:
Thank you Jesse!
Media-capture PR has been rebased.
https://github.com/apache/cordova-plugin-media-capture/pull/26#issuecomment-56118695
InAppBrowser - I've closed my
There are some apps pointing at the BlackBerry fork which have another
plugin installed that also uses the Android support library.
The jar file in the PGBuild repo has a bunch of classes stripped out of it
(FileProvider was needed in this case). I guess that was done to reduce APK
size rather
GitHub user sosahvictor opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/65
CB-7471 cordova-plugin-inappbrowser documentation translation
cordova-plugin-inappbrowser automatic translation
You can merge this pull request into a Git repository by
Github user sosahvictor closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/65
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
GitHub user sosahvictor opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/30
CB-7471 cordova-plugin-media documentation translation
cordova-plugin-media automatic translation
You can merge this pull request into a Git repository by running:
$ git pull
Err, my opinion is for a balanced approach:
- Don't expect perfection because it will never happen. Thus don't wait for it.
- Cook the best meal you can. If something substantial goes wrong, don't be
afraid to toss it because the goal is for the customer to have a good
experience, not for the
OK, so if the consensus is that these are not blocking, then the only thing
remaining for this plugins release is two more +1 votes.
On Sep 19, 2014, at 3:01 PM, Jesse purplecabb...@gmail.com wrote:
These have/are being merged, but nothing should block anything.
On Fri, Sep 19, 2014 at
The vote has now closed. The results are:
Positive Binding Votes: 4
- Mark Koudritsky
- Bryan Higgins
- Sergey Grebnov
- Marcel Kinard
Negative Binding Votes: 0
The vote has passed.
I don't think it is a good idea for a significant upgrade to go live on a
Friday evening, so I will wait until
+1 from my side. All things look good for current plugins on amazon-fireos.
On Fri, Sep 19, 2014 at 2:58 PM, Marcel Kinard cmarc...@gmail.com wrote:
OK, so if the consensus is that these are not blocking, then the only
thing remaining for this plugins release is two more +1 votes.
On Sep 19,
I vote +1:
* Ran coho verify-archive over the relevant repos (all verified)
* Ran coho audit-license-headers over the relevant repos (all had 0, except:
-- network-information iOS Reachability (Apple license - BSD
compatible it's ok http://markmail.org/message/3ok5cottuxt5wpub)
--
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/43#issuecomment-56250918
These tests are failing for me. What commit is required to make this pass?
or is there an environment setting I need to change?
Creating Cordova
62 matches
Mail list logo
