Re: [DISCUSS] Cordova-Android 5.0.x

+! My team is hiring! @purplecabbage risingj.com On Fri, Oct 23, 2015 at 3:46 AM, Shazron wrote: > +1 > > On Thu, Oct 22, 2015 at 10:38 AM, Joe Bowser wrote: > > BUMP! I'd like to start the vote thread on Monday! > > > > On Tue, Oct 20, 2015 at 10:01 AM,

Re: [DISCUSS] Cordova-Android 5.0.x

+1 On Thu, Oct 22, 2015 at 10:38 AM, Joe Bowser wrote: > BUMP! I'd like to start the vote thread on Monday! > > On Tue, Oct 20, 2015 at 10:01 AM, Joe Bowser wrote: > >> Hey >> >> I would like to release Cordova-Android 5.0.x soon so that I can then move >>

Re: [DISCUSS] Removing Tizen From Support Matrix

+1 On Thu, Oct 22, 2015 at 1:39 PM, Dmitry Blotsky wrote: > Hey folks, > > A few weeks back I heard someone mention that we should strike Tizen from > this matrix: > http://cordova.apache.org/docs/en/5.1.1/guide/support/index.html. Should I > proceed with that? Should

[GitHub] cordova-docs pull request: Master

GitHub user Krishnarajd opened a pull request: https://github.com/apache/cordova-docs/pull/401 Master orubase tools information added. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/cordova-docs master Alternatively you

[GitHub] cordova-docs pull request: orubase

Github user Krishnarajd commented on the pull request: https://github.com/apache/cordova-docs/pull/389#issuecomment-150552416  Could please use this attached

Re: [DISCUSS] cordova-ios 4.0.0 release

Sorry for the late reply -- took a sick day. I'd really like to just get cordova-ios 4.x out without a patch release in between, since there are just a few more issues left before we can clear the board (I'll triage it again), and a 4.x release would follow closely a 3.9.2 release. After mulling

[GitHub] cordova-plugin-wkwebview-engine pull request: Handle opening links...

GitHub user srgpqt opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2 Handle opening links in new window Makes links with target="_blank" behave as expected. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-device pull request: add isSimulator for iOS & Andr...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-150621997 Yes. Except it is only useful for plugins that depends on device. Accelerometer should not depend on device. I would like to move this directly

[GitHub] cordova-docs pull request: Master

Github user Krishnarajd closed the pull request at: https://github.com/apache/cordova-docs/pull/401 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-device pull request: add isSimulator for iOS & Andr...

Github user alsorokin commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-150563793 @nikhilkh this is essentially what I needed so I will use this to pend unsupported tests on iOS simulator I guess this will add a

[GitHub] cordova-plugin-device pull request: add isSimulator for iOS & Andr...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-150561368 @alsorokin Isn't this what you needed for disabling failing tests on iOS simulator? --- If your project is set up for it, you can reply to this email

[GitHub] cordova-windows pull request: CB-8307: Adding a 25-year expiration...

Github user pke commented on the pull request: https://github.com/apache/cordova-windows/pull/65#issuecomment-150586166 This somehow prevents me from specifying a publisherId myself for store submissions. I always get "CN=Apache Cordova Team". What do I have to do, to prevent that?

[GitHub] cordova-plugin-file-transfer pull request: uploadResponse encoding...

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/71#discussion_r42854285 --- Diff: src/ios/CDVFileTransfer.m --- @@ -552,6 +552,8 @@ - (void)connectionDidFinishLoading:(NSURLConnection*)connection

[GitHub] cordova-plugin-file-transfer pull request: Added note about iOS9 a...

Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/103#issuecomment-150545749 The next version of the CLI will automatically convert `access` and `allow-navigation` tags to the correct ATS directives. If you are using

[GitHub] cordova-plugin-camera pull request: CB-9193: Add 'showLibraryButto...

Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-150526428 @purplecabbage On Android, the strings were previously

[GitHub] cordova-docs pull request: Master

GitHub user Krishnarajd opened a pull request: https://github.com/apache/cordova-docs/pull/400 Master orubase tools information added. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/cordova-docs master Alternatively you

[GitHub] cordova-plugin-file pull request: CB-9851 Document cdvfile protoco...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-file/pull/141 CB-9851 Document cdvfile protocol quirk - using cdvfile:// in the DOM… … is not supported on Windows [Jira issue](https://issues.apache.org/jira/browse/CB-9851) You can

[GitHub] cordova-docs pull request: Master

Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-docs/pull/400#issuecomment-150544323 I think you did something wrong Files changed 19,185 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-docs pull request: Master

Github user Krishnarajd closed the pull request at: https://github.com/apache/cordova-docs/pull/400 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-docs pull request: Orubase tool information added

Github user Krishnarajd closed the pull request at: https://github.com/apache/cordova-docs/pull/390 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-file-transfer pull request: uploadResponse encoding...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/71#discussion_r42891905 --- Diff: src/ios/CDVFileTransfer.m --- @@ -552,6 +552,8 @@ - (void)connectionDidFinishLoading:(NSURLConnection*)connection

[GitHub] cordova-plugin-file-transfer pull request: uploadResponse encoding...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/71#discussion_r42887803 --- Diff: src/ios/CDVFileTransfer.m --- @@ -552,6 +552,8 @@ - (void)connectionDidFinishLoading:(NSURLConnection*)connection

Re: npm install on cordova platform/plugin add

It's still a requirement, I didn't say I was going to skip it :-) maybe we print a warning that requirement is not met, or something like that On Fri, Oct 23, 2015 at 10:19 PM Steven Gill wrote: > I agree that we should use exact versions for dependencies of Cordova >

[GitHub] cordova-plugin-camera pull request: CB-9490 Fixed cleanup function

Github user cojomojo commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-150748364 @infil00p Yes, it would still have the problem. I submitted this fix still because it is trivial (this PR won't change how the plugin is used at all,

Re: [Android][Discuss] Change name of CordovaWebView to CordovaWebInterface

it is! My team is hiring! @purplecabbage risingj.com On Fri, Oct 23, 2015 at 7:15 PM, Carlos Santana wrote: > +1 if what Simon and Jesse are saying is the same thing :-) > > > On Fri, Oct 23, 2015 at 7:42 PM Jesse wrote: > > > Let's go ahead

Re: Introduction

Welcome Ryan, feel free to use the dev mailing list and Slack for any questions On Mon, Oct 19, 2015 at 6:39 PM Tommy Williams wrote: > Welcome, indeed. > > > On 20 October 2015 at 04:08:16, Ryan J. Salva (rsa...@microsoft.com) > wrote: > > Welcome, Ryan! > > > rjs > >

RE: [DISCUSS] Tools Release

+1 - I'm hoping we'll release iOS as well before the next CLI release. -Nikhil -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com] Sent: Friday, October 23, 2015 12:48 PM To: dev@cordova.apache.org Subject: [DISCUSS] Tools Release I think we should release a version

RE: npm install on cordova platform/plugin add

Ah, it makes sense in both platforms and plugins. Thanks, -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, October 22, 2015 4:46 PM To: dev@cordova.apache.org Subject: Re: npm install on cordova platform/plugin add Yeah. Cordova-common is the main

RE: [Android][Discuss] Change name of CordovaWebView to CordovaWebInterface

I understand that it won't break currently and it will break on the next major version bump. IMHO it's just not worth it for this name change. Historically, we've had challenges with giving sufficient notice from breaking changes. I would avoid them unless absolutely needed. -Nikhil

[DISCUSS] Tools Release

I think we should release a version of the CLI now, from what Steve told me there is a lot changes going in, and also contains the switch to use npm instead of CPR, and other changes around npm3 and nodejs4 This will allow for trains to move forward and get feedback on the releases. Propose

[GitHub] cordova-plugin-device-motion pull request: add JIRA issue tracker ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/36 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-device-motion pull request: Returning an OK PluginR...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-device-motion pull request: Update index.md

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/23 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

Re: [DISCUSS] Curating Apps

YES! Removing the "add a tool" and "add a plugin" is the best way to go. Those PRs require way to much management. Leave it up to PMC to nominate apps. On Fri, Oct 23, 2015 at 5:41 PM, Nikhil Khandelwal wrote: > I like Carlos' proposal. Reviewing PRs for these apps and

[GitHub] cordova-plugin-device-motion pull request: CB-8096 Pended auto tes...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/22 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

Re: [Discuss] Cordova-common release

Not excited about putting this on npm, I feel you can just name it cordova-lib2 But if we are going to do it let's at least follow the npm way: The version should be 1.0.0, because shipping 0.x is kind lame this days What is the API of this first release? I hope there is a good README that will be

Re: [DISCUSS] Curating Apps

Just want to add that I feel offended that no one from the PhoneGap team has added Untappd Shame on you all !!! On Fri, Oct 23, 2015 at 9:01 PM Steven Gill wrote: > YES! Removing the "add a tool" and "add a plugin" is the best way to go. > Those PRs require way to much

Re: [DISCUSS] Curating Apps

Sure, I’m also down for removing the “add your app” option. Switching to putting apps up only at our own discretion makes sense. My only concern is that I personally haven’t tried out many Cordova apps, so I would expect us to have a shortage of apps this way. But if other PMC members have apps

Re: [Discuss] Cordova-common release

Those are good points about the readme. I thought the same thing about the version but was going to let it slide :P. On Fri, Oct 23, 2015 at 6:14 PM, Carlos Santana wrote: > Not excited about putting this on npm, I feel you can just name it > cordova-lib2 > But if we are

Re: [Discuss] Cordova-common release

I'm disappointed Steve, the npm team will remember you as the guy that keeps publishing 0.x packages like it was 2013 LOL On Fri, Oct 23, 2015 at 9:24 PM Steven Gill wrote: > Those are good points about the readme. I thought the same thing about the > version but was

Re: npm install on cordova platform/plugin add

The requirement will be that 3rd party plugins put exact versions of dependencies, not assuming that user will need to run npm install or npm update after adding the plugin to refresh the npm dependencies Apache Foundation Cordova Platforms and Plugins should ship with it's dependencies bundled,

Re: [Android][Discuss] Change name of CordovaWebView to CordovaWebInterface

+1 if what Simon and Jesse are saying is the same thing :-) On Fri, Oct 23, 2015 at 7:42 PM Jesse wrote: > Let's go ahead with renaming CordovaWebView => CordovaWebInterface, and > keeping around a CordovaWebView object so that nothing breaks. > > We should also

Re: npm install on cordova platform/plugin add

I agree that we should use exact versions for dependencies of Cordova Platforms and Plugins and still bundle dependencies. I don't think we should enforce that requirement on plugin authors. We can have our plugin docs suggest that they use exact versions but I don't think we should skip npm

Re: [DISCUSS] CocoaPods dependencies for iOS plugins

I mean is that I should be allow to add a plugin from a windows/linux machine where cocoapod client is not present, then compile on a Mac where the pod client is available and "pod install" can run Will need to work out the details with engine, I just want to make sure that engine tag doesn't

[GitHub] cordova-plugin-camera pull request: Marshmallow/Cordova Android 5....

Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/128#issuecomment-150695843 Closing pull request. Code has now been rebased and merged. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-wp8 pull request: CB-9836 Add .gitattributes to prevent CR...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-wp8/pull/89 CB-9836 Add .gitattributes to prevent CRLF line endings in repos [Jira issue](https://issues.apache.org/jira/browse/CB-9836) You can merge this pull request into a Git repository by running:

[GitHub] cordova-plugin-camera pull request: CB-9490 Fixed cleanup function

Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-150703173 @cojomojo Won't this still have the problem you found when you filed this? https://issues.apache.org/jira/browse/CB-9506 --- If your project is set up

Re: [VOTE] Cordova-common release

+1 * Ran coho audit-license-headers over the repo * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ran coho verify-archive successfully. On Fri, Oct 23, 2015 at 1:34 AM, Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > Please

Re: [DISCUSS] CocoaPods dependencies for iOS plugins

How does this discussion repo works again? Do we create a github issue pointing to the proposal to have the discussion there with comments? One thing I notice is that engine the way they work today this will not work, since we want to allow the plugin to be installed, and cocoapod is only need

[GitHub] cordova-plugin-file-transfer pull request: uploadResponse encoding...

Github user codable commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/71#discussion_r42926656 --- Diff: src/ios/CDVFileTransfer.m --- @@ -552,6 +552,8 @@ - (void)connectionDidFinishLoading:(NSURLConnection*)connection

[GitHub] cordova-plugin-file-transfer pull request: uploadResponse encoding...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/71#discussion_r42926950 --- Diff: src/ios/CDVFileTransfer.m --- @@ -552,6 +552,8 @@ - (void)connectionDidFinishLoading:(NSURLConnection*)connection

Re: [DISCUSS] CocoaPods dependencies for iOS plugins

Send PR's or comment on a line in a commit. I think. Not sure what you mean -- the purpose of Cocoapods is to install/uninstall a pod. It is thus a plugin add/install step. On Fri, Oct 23, 2015 at 5:12 PM, Carlos Santana wrote: > How does this discussion repo works again?

Re: [DISCUSS] Curating Apps

I think we make it more simpler, a PMC member to propose to add an app that he/she tried out and feels that it deserves to be show case as a good example of a great Cordova App. - remove the "add your app" - PMC members mails the list, that he evaluated the app and a short description on why to

[GitHub] cordova-coho pull request: Adding docs around JIRA issue triage

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-coho/pull/97#issuecomment-150727908 I made some more tweaks based on feedback. Please take another look. Thanks! What should we do with auto-assignment behavior?

[GitHub] cordova-docs pull request: Add ReactEurope App to Showcase

Github user csantanapr closed the pull request at: https://github.com/apache/cordova-docs/pull/379 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-whitelist pull request: Update whitelist version to...

GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-plugin-whitelist/pull/14 Update whitelist version to 2.0.0 to support older versions of the CLI Older versions of the CLI using cordova-app-hello-world template that references v1 of this plugin and

Re: npm install on cordova platform/plugin add

Issue: https://issues.apache.org/jira/browse/CB-9858 On Fri, Oct 23, 2015 at 1:05 PM, Mefire O. wrote: > Ah, it makes sense in both platforms and plugins. > > Thanks, > > -Original Message- > From: Steven Gill [mailto:stevengil...@gmail.com] > Sent: Thursday,

Re: [Android][Discuss] Change name of CordovaWebView to CordovaWebInterface

Let's go ahead with renaming CordovaWebView => CordovaWebInterface, and keeping around a CordovaWebView object so that nothing breaks. We should also deprecate CordovaWebView, and document the change so that people who are using it have some notice, and people who are new know what NOT to use.

[GitHub] cordova-plugin-camera pull request: Marshmallow/Cordova Android 5....

Github user infil00p closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/128 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-cli pull request: CB-9836 Add .gitattributes to prevent CR...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-cli/pull/225 CB-9836 Add .gitattributes to prevent CRLF line endings in repos [Jira issue](https://issues.apache.org/jira/browse/CB-9836) You can merge this pull request into a Git repository by running:

[GitHub] cordova-windows pull request: remove publisherId since its overrid...

GitHub user pke opened a pull request: https://github.com/apache/cordova-windows/pull/127 remove publisherId since its overridden by the certficate during build 1. The publisherId set here is __always__ overridden by the `CN` from the projects associated certificate. That is by

[GitHub] cordova-webos pull request: CB-9836 Add .gitattributes to prevent ...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-webos/pull/6 CB-9836 Add .gitattributes to prevent CRLF line endings in repos [Jira issue](https://issues.apache.org/jira/browse/CB-9836) You can merge this pull request into a Git repository by running:

[GitHub] cordova-windows pull request: Replace the "CordovaApp" description...

Github user pke closed the pull request at: https://github.com/apache/cordova-windows/pull/128 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-windows pull request: remove publisherId since its overrid...

Github user pke commented on the pull request: https://github.com/apache/cordova-windows/pull/127#issuecomment-150705467 There seem to be more places where this needs to be removed. Will create a more complete PR. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-windows pull request: remove publisherId since its overrid...

Github user pke closed the pull request at: https://github.com/apache/cordova-windows/pull/127 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-coho pull request: CB-9836 Add .gitattributes to prevent C...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-coho/pull/98 CB-9836 Add .gitattributes to prevent CRLF line endings in repos [Jira issue](https://issues.apache.org/jira/browse/CB-9836) You can merge this pull request into a Git repository by running:

Re: [DISCUSS] Tools Release

Okay. I will start work on this release Monday unless anyone has concerns. -Steve On Fri, Oct 23, 2015 at 12:57 PM, Nikhil Khandelwal wrote: > +1 - I'm hoping we'll release iOS as well before the next CLI release. > > -Nikhil > > -Original Message- > From:

[GitHub] cordova-ios pull request: CB-9836 Add .gitattributes to prevent CR...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-ios/pull/173 CB-9836 Add .gitattributes to prevent CRLF line endings in repos [Jira issue](https://issues.apache.org/jira/browse/CB-9836) You can merge this pull request into a Git repository by running:

[GitHub] cordova-windows pull request: Replace the "CordovaApp" description...

GitHub user pke opened a pull request: https://github.com/apache/cordova-windows/pull/128 Replace the "CordovaApp" description with the real description from config.xml The description was read from the `config.xml` but never used to modify the apps manifest files. You can merge

[GitHub] cordova-ubuntu pull request: CB-9836 Add .gitattributes to prevent...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-ubuntu/pull/17 CB-9836 Add .gitattributes to prevent CRLF line endings in repos [Jira issue](https://issues.apache.org/jira/browse/CB-9836) You can merge this pull request into a Git repository by running:

[GitHub] cordova-windows pull request: Replace the "CordovaApp" description...

Github user pke commented on the pull request: https://github.com/apache/cordova-windows/pull/128#issuecomment-150705390 Hmm something wrong with that. Have to test locally. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-windows pull request: CB-9836 Add .gitattributes to preven...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/126 CB-9836 Add .gitattributes to prevent CRLF line endings in repos [Jira issue](https://issues.apache.org/jira/browse/CB-9836) You can merge this pull request into a Git repository by

[GitHub] cordova-docs pull request: Remove misleading reference to "publish...

GitHub user pke opened a pull request: https://github.com/apache/cordova-docs/pull/402 Remove misleading reference to "publisherId" cause it is ignored The only way to override the `Publisher` value in the generated `AppxManifest.xml` is to provide a custom signing certificate.

[GitHub] cordova-blackberry pull request: CB-9836 Add .gitattributes to pre...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-blackberry/pull/193 CB-9836 Add .gitattributes to prevent CRLF line endings in repos [Jira issue](https://issues.apache.org/jira/browse/CB-9836) You can merge this pull request into a Git repository by

[GitHub] cordova-browser pull request: CB-9836 Add .gitattributes to preven...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-browser/pull/22 CB-9836 Add .gitattributes to prevent CRLF line endings in repos [Jira issue](https://issues.apache.org/jira/browse/CB-9836) You can merge this pull request into a Git repository by

[GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...

Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/164#issuecomment-150498299 Sounds good, can you get the code in a new pull request and reference the same CB-9685? I'll re-open it once you do so. --- If your project is set up for it, you

[VOTE] Cordova-common release

Please review and vote on this Cordova-common Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9850 Both tools have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-9850/ The