Re: Verified Plugins Marketplace

2014-07-11 Thread Andrew Grieve
Looks really nice! Thanks Rob! Reason for forking is that they've cleaned them up a bit. E.g.: https://github.com/Telerik-Verified-Plugins/BarcodeScanner/commits/master has added wp support, bug fix, better description On Fri, Jul 11, 2014 at 11:34 AM, Michal Mocny mmo...@chromium.org wrote:

Re: Pointing docs to edge

2014-07-11 Thread Andrew Grieve
...@google.com agri...@google.com on behalf of Andrew Grieve agri...@chromium.org Sent: Friday, July 11, 2014 11:39 AM To: dev Subject: Re: Pointing docs to edge Yeah, plugin docs are already gone from docs.cordova.io. This change is strictly for guides platform docs. The main

Re: Introduction Florian BERTON/Touchify

2014-07-10 Thread Andrew Grieve
Welcome Florian, Thanks for the introduction :). Looking forward to having you help out. On Thu, Jul 10, 2014 at 6:21 AM, Florian Berton fber...@touchify.co wrote: Hi, My name is Florian BERTON, I’m 25 years old, live in Paris and I have worked for 5 years on web technologies. I’m a

Re: [iOS] CDVPluginResult breaking change

2014-07-10 Thread Andrew Grieve
Likely most will not be affected and the fix is easy. go for it. On Thu, Jul 10, 2014 at 2:30 PM, Shazron shaz...@gmail.com wrote: I would like to apply this fix: https://issues.apache.org/jira/browse/CB-6165 Essentially, right now if the plugin result is OK (or any other status) without a

Re: whitelist as a plugin

2014-07-09 Thread Andrew Grieve
at 6:52 AM, Andrew Grieve agri...@chromium.org wrote: I don't think moving the whitelist to a plugin would aid in its understanding. Right now the whitelist is used for two things: 1. Whether to allow network requests through (although this is broken for audio/video on iOS, and broken

Re: iOS: add target-device and MinimumOSVersion support to config.xml

2014-07-09 Thread Andrew Grieve
] On Behalf Of Andrew Grieve Sent: Tuesday, July 8, 2014 5:45 PM To: dev Subject: Re: iOS: add target-device and MinimumOSVersion support to config.xml Agree with this. These are in the same vein as app icons, where they go in the CLI config.xml, not the runtime config.xml. On Mon, Jul 7

Re: webview as fragment on Android

2014-07-09 Thread Andrew Grieve
I think it's been brought up a few times and is a real issue that we could address. Perhaps in 4.0.x? On Tue, Jul 8, 2014 at 11:20 PM, Marcel Kinard cmarc...@gmail.com wrote: Someone asked me today about using a Cordova webview as a fragment on Android. Is this something that should work as

Re: [Android] API changes

2014-07-09 Thread Andrew Grieve
Most of the commits to cordova-android as of late were mine. I'm hoping 4.0.x can be a commit-then-review kind of branch. We're a long way out from it being ready, so I think this will work well for now and as we get closer to release we should be more cautious. It would be super-slow to ask

Re: webview as fragment on Android

2014-07-09 Thread Andrew Grieve
the API of CordovaActivity. On Wed, Jul 9, 2014 at 11:55 AM, Joe Bowser bows...@gmail.com wrote: We should push this to 5.x. We're breaking too much stuff in 4.x. On Jul 9, 2014 8:49 AM, Andrew Grieve agri...@chromium.org wrote: I think it's been brought up a few times and is a real issue

Re: [Android] API changes

2014-07-09 Thread Andrew Grieve
On Wed, Jul 9, 2014 at 2:57 PM, Joe Bowser bows...@gmail.com wrote: On Jul 9, 2014 10:22 AM, Andrew Grieve agri...@chromium.org wrote: Most of the commits to cordova-android as of late were mine. I'm hoping 4.0.x can be a commit-then-review kind of branch. Why? Branching is super cheap

Re: Tools release blog post review

2014-07-09 Thread Andrew Grieve
Good point about highlighting experimental flags. Not sure if browserify made it into this release, but if so worth a mention as well. Should link to Gorkem's blog post I think. Michal recently discovered that npm update -g cordova grabs alpha versions, and is not based on the latest dist-tag.

Re: Directory Structure - CLI directory config proposal

2014-07-08 Thread Andrew Grieve
Wondering what this will look like. config.xml settings? .cordova/config.json? A new config file? On Mon, Jul 7, 2014 at 2:43 PM, Parashuram Narasimhan (MS OPEN TECH) panar...@microsoft.com wrote: +1 to this proposal. If we are able to agree on a proposal, we can contribute with code too.

Re: iOS: add target-device and MinimumOSVersion support to config.xml

2014-07-08 Thread Andrew Grieve
these are really build time preferences and probably the domain of the CLI since they modify the Info.plist and .pbxproj files. On Mon, Jul 7, 2014 at 6:34 AM, tommy-carlos williams to...@devgeeks.org wrote: +1 On 7 July 2014 at 23:29:46, Andrew Grieve (agri...@chromium.org) wrote: +1

Re: whitelist as a plugin

2014-07-08 Thread Andrew Grieve
I don't think moving the whitelist to a plugin would aid in its understanding. Right now the whitelist is used for two things: 1. Whether to allow network requests through (although this is broken for audio/video on iOS, and broken for them + websockets on Android 2. Whether to allow top frame

Re: Ripple as a Cordova platform - experiment

2014-07-08 Thread Andrew Grieve
Haven't tried it, but love the approach. On Mon, Jul 7, 2014 at 11:41 PM, Parashuram Narasimhan (MS OPEN TECH) panar...@microsoft.com wrote: My bad, did not realize the WWW did not exist. It was just a sample app, which used the camera API. You can use the camera API and it will work with

Re: Android: add support of min/max/target SDK to config.xml

2014-07-07 Thread Andrew Grieve
I'd love to see this added. On Mon, Jul 7, 2014 at 7:29 AM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: Propose to add support of the following Android specific settings to config.xml similar to PG Build[2]. Optional, could be used to override default template values. I think

Re: iOS: add target-device and MinimumOSVersion support to config.xml

2014-07-07 Thread Andrew Grieve
+1 On Mon, Jul 7, 2014 at 8:39 AM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: Phonegap build already supports[2] preferences below and we could make this a part of Cordova. I can implement this if we agree. Thoughts? #1 target-device For targeting a specific device; possible

Re: Directory Structure - CLI directory config proposal

2014-07-07 Thread Andrew Grieve
Which paths do you want to be configurable? On Mon, Jul 7, 2014 at 10:41 AM, Lisa Seacat DeLuca ldel...@us.ibm.com wrote: I wanted to start a discussion on this dev list about potentially adding a config setting for the CLI that defines the directory structure to use for creating and

Re: volume button support on Android

2014-07-06 Thread Andrew Grieve
I believe it works on Android. Have you tried it? On Sat, Jul 5, 2014 at 8:45 AM, Eduardo Schettino schettin...@gmail.com wrote: Hi, I would like to use the event volumeupbutton on android. But the docs says that as of cordova 3.5 the only platform support is BlackBerry [1]. I found an

Re: [VOTE] Tools Release

2014-07-03 Thread Andrew Grieve
+1 * Confirmed sigs hashes with `coho verify-archive` On Thu, Jul 3, 2014 at 11:36 AM, Mark Koudritsky kam...@google.com wrote: Please review and vote on this Tools Release. This is from branches with some patches applied: - revert windows universal app support - fix cordova serve

Re: Saying Hello and Problem with Jira

2014-07-03 Thread Andrew Grieve
I've added you to the JIRA project. Try it again and let me know if you still can't assign it to yourself. On Thu, Jul 3, 2014 at 1:33 PM, Eric Weiterman eweit@gmail.com wrote: Hi everyone, Marcel K introduced me on here a couple weeks ago. I just started with IBM out of college and

Re: [Android] SecureToken/NoFrak feature addition

2014-07-03 Thread Andrew Grieve
Finally got around to this. Might be nice if someone wanted to do a code review of the changes. Commits are linked off of the JIRA issue. On Fri, Feb 7, 2014 at 10:22 AM, Andrew Grieve agri...@chromium.org wrote: Created a bug: https://issues.apache.org/jira/browse/CB-5988 Won't get

Re: Inconsistent behavior when opening inappbrowser window

2014-07-02 Thread Andrew Grieve
It's certainly not ideal. It would be better for this to be consistent. That said, probably low priority to fix (pull requests welcome). Could maybe even fix it on the JS side (existing.close() before open() next) On Wed, Jul 2, 2014 at 3:20 PM, Li, Jonathan jonathan...@sap.com wrote: When

Re: Questions about FileSystem documentation and paths

2014-07-02 Thread Andrew Grieve
Thanks for putting together this blog post Ray! Assume this is addressed in https://github.com/apache/cordova-plugin-file/pull/59? (Which is an awesome change! Thanks Kerri!) As a nit: you can simplify your code a bit by skipping the .getFile() call:

Re: Add build status to github

2014-06-27 Thread Andrew Grieve
Make it happen :) On Fri, Jun 27, 2014 at 10:02 AM, Mark Koudritsky kam...@google.com wrote: Would be nice to have this. Specifically Travis will only run on Linux (and maybe OSX). Here is a random similar service I found that can also run on windows. http://www.appveyor.com/

Re: Contacts API, iOS

2014-06-27 Thread Andrew Grieve
wrote: As a note - pickContact functionality exists in repo/master only and has not been released to plugins registry yet. Thx! Sergey -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Monday, June

Re: Stale documentation PR

2014-06-27 Thread Andrew Grieve
done! Thanks Martin. On Wed, Jun 25, 2014 at 3:05 AM, Martin Bektchiev martin.bektch...@telerik.com wrote: Hi, I just noticed that thishttps://github.com/apache/cordova-docs/pull/210 pull request (Document CB-6344-and-CB-6698:

Googlers off for Canada Day Mon Tues

2014-06-27 Thread Andrew Grieve
Just as an FYI - we won't be around.

Re: [Vote] Tools Release

2014-06-26 Thread Andrew Grieve
Sergey - could you clarify what the bug here is? E.g. Is there a regression? Does this make cordova run not work? If it really does need to be applied - checking in commented-out code is not the way to go about. You should add if (version = 3.6.0) checks around things like is done here:

Chrome App Developer Tool for Mobile

2014-06-26 Thread Andrew Grieve
Chrome team has a new toy if anyone wants to try it out! Chrome App Developer Tool is a downstream version of cordova-app-harness Any mobile Chrome App or Cordova app that uses CCA plugins or core Cordova plugins should work with it. Instructions are here:

Re: [VOTE] Network information plugin release

2014-06-26 Thread Andrew Grieve
+1 * verified signature hash * verified archive contents matches git hash On Tue, Jun 24, 2014 at 3:55 PM, Ian Clelland iclell...@chromium.org wrote: Please review and vote on the release of this plugins release. Release issue: https://issues.apache.org/jira/browse/CB-7019 The plugins

platform_parser.check_requirements() not needed?

2014-06-26 Thread Andrew Grieve
Android and iOS have empty functions for check_requirements(), and I think that's the right way to go. Never really discussed it on list though, so wanted to share why I think this. Originally, the motivation was to run some checks *before* downloading the platform. It turned out that

Re: GitHub write access

2014-06-25 Thread Andrew Grieve
Your push to master on your own github worked. It's just your CB-6773cordova-plugin-vibration branch that didn't work. To update that branch: git checkout CB-6773cordova-plugin-vibration git pull --rebase git push origin CB-6773cordova-plugin-vibration To merge your change into apache: git

Re: plugin test framework

2014-06-24 Thread Andrew Grieve
-framework, installed manually or automatically? Also Andrew points are good, improve it to make tests fast, avoid timers, identify if its running on the simulator/emulator or not. Any input, ideas, suggestions about this, it would be great. 2014-06-21 10:22 GMT-05:00 Andrew Grieve agri

Re: Brief intro: Lou Franco (possible new contributor)

2014-06-24 Thread Andrew Grieve
Patch looks good! I think actually that .svg files suffer the same fate (ran into this for chrome-extension: custom URL provider). Also - cool site! On Tue, Jun 24, 2014 at 7:36 PM, Lou Franco lfra...@greenwave-solutions.com wrote: Hi, my name is Lou Franco -- I am a software developer,

Re: Contacts API, iOS

2014-06-23 Thread Andrew Grieve
Yes - meant plugins registry. right now the plugin links point to github, so you always see master I don't think we should concern ourselves with correcting docs for old versions of plugins. It's a similar argument to fix bugs in old versions of plugins (any changes create a new version). On

Re: [iOS] Keyboard plugin maintenance

2014-06-23 Thread Andrew Grieve
Yep, sounds good. My interest for it dropped once iOS7 made keyboard-shrinks-view the default (much better for apps). On Mon, Jun 23, 2014 at 5:31 PM, Shazron shaz...@gmail.com wrote: This plugin has been moved to the org.apache.cordova.labs namespace so it doesn't affect our plugin releases.

Re: Should use only drawable folder for single application icon

2014-06-21 Thread Andrew Grieve
Jan, I think the rationale here is sound. Are you interested in adding this feature? On Sat, Jun 21, 2014 at 6:03 AM, Jan Velecký vve...@seznam.cz wrote: It is a thing of a concrete developer if he place more icons in different dimensions or not. In iOS developing, there must be more icons,

Re: Contacts API, iOS

2014-06-21 Thread Andrew Grieve
One clear task: We need to update our http://cordova.apache.org/docs/en/3.5.0/cordova_plugins_pluginapis.md.html#Plugin%20APIs to point to the npm registry instead of github. On Sat, Jun 21, 2014 at 9:54 AM, Ray Camden rayca...@adobe.com wrote: My test was very simple -trying to use

Re: Should use only drawable folder for single application icon

2014-06-20 Thread Andrew Grieve
No: Leave template icons It's a subtle change, but a good one I think. On Thu, Jun 19, 2014 at 10:03 PM, Joe Bowser bows...@gmail.com wrote: On Thu, Jun 19, 2014 at 6:01 PM, Andrew Grieve agri...@chromium.org wrote: I don't think it should resize it, but I do agree we should delete

Re: [DISCUSS] Tools release

2014-06-20 Thread Andrew Grieve
Now that the dust has settled on the android library change, I'd like to try this again. Created bug: https://issues.apache.org/jira/browse/CB-7002 I hope to put together RCs tomorrow morning. Likely not too many people checking email any more since it's the weekend, but feeling like we're

Re: Browserify JS is in

2014-06-19 Thread Andrew Grieve
bump On Mon, Jun 16, 2014 at 12:51 PM, Andrew Grieve agri...@chromium.org wrote: Cool, yes! Thanks for the update! Is there a JIRA for this? Was asked in https://issues.apache.org/jira/browse/CB-5671. On Mon, Jun 16, 2014 at 10:21 AM, Michal Mocny mmo...@chromium.org wrote: Awesome

Re: Browserify JS is in

2014-06-19 Thread Andrew Grieve
? On Thu, Jun 19, 2014 at 9:28 AM, Andrew Grieve agri...@chromium.org wrote: bump On Mon, Jun 16, 2014 at 12:51 PM, Andrew Grieve agri...@chromium.org wrote: Cool, yes! Thanks for the update! Is there a JIRA for this? Was asked in https://issues.apache.org/jira/browse/CB-5671

Re: Should use only drawable folder for single application icon

2014-06-19 Thread Andrew Grieve
I don't think it should resize it, but I do agree we should delete the template ones if any are present. Right now you aren't sure if the icon tag even did anything if you fail to replace the right size. Android and iOS both do a pretty good job at resizing at runtime if only one large icon is

Re: File-transfer: delete target file on process error

2014-06-18 Thread Andrew Grieve
iclell...@chromium.org: On Tue, Jun 17, 2014 at 9:34 PM, Andrew Grieve agri...@chromium.org wrote: If it's cached... won't it exist? Exactly this. A 304 request should only be received in response to a conditional GET request. There's generally no reason to send a conditional GET

Re: [Android] URI routing

2014-06-18 Thread Andrew Grieve
Change looks good to me! On Wed, Jun 18, 2014 at 7:51 PM, Joe Bowser bows...@gmail.com wrote: Hey After looking at the breakout code, it seems that there may actually be a lot of duplicate code between Crosswalk, default AndroidWebView and others, so I created a helper class that could be

Re: File-transfer: delete target file on process error

2014-06-17 Thread Andrew Grieve
:01 GMT+02:00 Andrew Grieve agri...@chromium.org: I think this behaviour has been around for a while, and makes sense in the majority of cases. Yep, I did a git blame and this fragment of code was there from the beginning. Best practice is to download to a temporary location

Re: File-transfer: delete target file on process error

2014-06-17 Thread Andrew Grieve
transfer was unable to download anything due to the 304 response so IMO the error callback could do the job. 2014-06-17 16:27 GMT+02:00 Andrew Grieve agri...@chromium.org: How about adding a second parameter to the callback? Android and iOS bridges both support this natively, and you can

Re: WKWebView for iOS8

2014-06-16 Thread Andrew Grieve
Awesome. Shaz (or anyone else), curious if you've tested yet to see if the whitelist still works with WKWebView? (e.g. does it go through NSURLProtocol?) On Sat, Jun 14, 2014 at 8:16 PM, tommy-carlos williams to...@devgeeks.org wrote: This looks promising. Thanks for the update, Shazron.

Re: File-transfer: delete target file on process error

2014-06-16 Thread Andrew Grieve
I think this behaviour has been around for a while, and makes sense in the majority of cases. Best practice is to download to a temporary location, and then upon success move the file to its final spot. That said, I think it'd be fine to add an option for not delete on error. On Mon, Jun 16,

Re: Plugman support for Android libraries

2014-06-16 Thread Andrew Grieve
please write some? :) Martin Bektchiev AppBuilder Core Team -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Friday, June 13, 2014 5:40 PM To: dev Subject: Re: Plugman support for Android libraries Ah, okay. Yeah, when I tried

Re: Browserify JS is in

2014-06-16 Thread Andrew Grieve
Cool, yes! Thanks for the update! Is there a JIRA for this? Was asked in https://issues.apache.org/jira/browse/CB-5671. On Mon, Jun 16, 2014 at 10:21 AM, Michal Mocny mmo...@chromium.org wrote: Awesome Anis. Will gladly take a look at this later today. Just wanted to send a quick thanks

Re: plugin test framework

2014-06-16 Thread Andrew Grieve
Yeah, really exciting. Thanks for taking this on. On Mon, Jun 16, 2014 at 3:42 PM, Michal Mocny mmo...@chromium.org wrote: Fantastic! I'll try to keep an eye out on the PR's, and please ping me if you would like any help. -Michal On Mon, Jun 16, 2014 at 3:25 PM, Marcel Kinard

Re: [Proposal] Cordova guidelines part of ContributorWorkflow

2014-06-16 Thread Andrew Grieve
I haven't seen our style guide followed, and generally don't think style is a thing that can really be enforced without tools or code review. How about deleting the wiki page and doubling down on jshint? Can we tell jshint to force ;s while allowing comma-first? On Mon, Jun 16, 2014 at 5:00 PM,

Re: Questions about iOS Cordova plugin

2014-06-13 Thread Andrew Grieve
They should work fine, but if you have a reproducible failing case, then please file a bug with it attached and we'll see what's up. There are definitely known freezes if you try to use remote web inspector on iOS in these cases, but freezes without the inspector are expected to work. On Fri,

Re: Plugman support for Android libraries

2014-06-13 Thread Andrew Grieve
element (as was my initial intention). Looking forward to your thoughts on this! ~Martin Bektchiev -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Friday, June 6, 2014 11:26 PM To: dev Subject: Re: Plugman support

Re: [VOTE] Tools release

2014-06-13 Thread Andrew Grieve
I think the main motivation for this release is the android library project support. But... looks like it wasn't baked enough ( https://github.com/apache/cordova-lib/pull/29). I think we should wait for this PR to land before launching the feature. On Thu, Jun 12, 2014 at 2:19 PM, Ian Clelland

Re: Hangout

2014-06-10 Thread Andrew Grieve
https://plus.google.com/hangouts/_/hoaevent/AP36tYejLubDhewihYuAduHW7TPvpaFthvff21pfFYUZ550eoSNqJg?authuser=0hl=en On Tue, Jun 10, 2014 at 4:08 PM, Andrew Grieve agri...@chromium.org wrote: And it is... On Tue, Jun 10, 2014 at 4:07 PM, Ian Clelland iclell...@chromium.org wrote: Turns out

Re: Hangout

2014-06-10 Thread Andrew Grieve
And it is... On Tue, Jun 10, 2014 at 4:07 PM, Ian Clelland iclell...@chromium.org wrote: Turns out it is. Andrew has the *real* link now. On Tue, Jun 10, 2014 at 4:05 PM, Joe Bowser bows...@gmail.com wrote: Isn't that just for watching? On Tue, Jun 10, 2014 at 1:04 PM, Ian Clelland

Re: Hangout

2014-06-10 Thread Andrew Grieve
there. On Tue, Jun 10, 2014 at 4:10 PM, Carlos Santana csantan...@gmail.com wrote: ding ding ding ! On Tue, Jun 10, 2014 at 4:09 PM, Andrew Grieve agri...@chromium.org wrote: https://plus.google.com/hangouts/_/hoaevent/AP36tYejLubDhewihYuAduHW 7T

Re: [VOTE] Plugins Release (attempt 2)

2014-06-09 Thread Andrew Grieve
+1 - Verified that hashes match the tags. - Verified hashes sigs - Verified contents of plugin-camera (assuming others are fine) On Mon, Jun 9, 2014 at 1:48 PM, Steven Gill stevengil...@gmail.com wrote: Please review and vote on the release of this plugins release. Release issue:

Re: minor bump to cordova-lib

2014-06-09 Thread Andrew Grieve
I think all releases require votes. Only difference is that for urgent releases we can have a shorter vote period. Looking at your commit - there's now two package.json files with the same name. I don't think that's allowed by npm. Your goal was to make configparser its own package right?

Re: minor bump to cordova-lib

2014-06-09 Thread Andrew Grieve
Marvin's email came across to me as respectful. Brian and Joe - your responses came across as disrespectful to me. Slow claps and sarcasm should probably be avoided in email. This issue has been covered at length, and the a very clear conclusion was made that unless policies change, anything

Re: Coho updates

2014-06-09 Thread Andrew Grieve
, whether there are any differences (would help with release) On Fri, Jun 6, 2014 at 9:18 AM, Andrew Grieve agri...@chromium.org wrote: Spent some time on it yesterday today. Highlights: - Much faster start-up on node 0.10 (made some requires lazy) - Much faster repo-clone and repo-update

Re: Plugins Release Blog Post Review!

2014-06-08 Thread Andrew Grieve
Nice work. Clean up extended notes and added re-did call-out of file changes: https://github.com/cordova/apache-blog-posts/pull/5 On Fri, Jun 6, 2014 at 7:36 PM, Steven Gill stevengil...@gmail.com wrote: Please review the blog post at

Re: I want to contribute code to cordova project

2014-06-08 Thread Andrew Grieve
Awesome! There's some info for how to contribute here: http://cordova.apache.org/#contribute For starters - what would you like to change about camera? and on what platform(s)? On Sun, Jun 8, 2014 at 3:16 AM, kazami hayato kazamiz...@gmail.com wrote: Hello, I am Kazami. I can program on

Re: wip on cordova-lib? pls let us know

2014-06-07 Thread Andrew Grieve
, such as reading config files from disk once and then modifying in-memory, but I'm not sure if we actyally have that problem. -Michal On Fri, Jun 6, 2014 at 1:12 PM, Andrew Grieve agri...@chromium.org wrote: On Fri, Jun 6, 2014 at 12:37 PM, Brian LeRoux b...@brian.io wrote

Re: [VOTE] Plugins Release

2014-06-06 Thread Andrew Grieve
I don't see the tag for inappbrowser. Forgot to push it? On Fri, Jun 6, 2014 at 10:46 AM, Marcel Kinard cmarc...@gmail.com wrote: Steve, to clarify, a single vote is for all the plugins listed below, correct? On Jun 5, 2014, at 5:44 PM, Steven Gill stevengil...@gmail.com wrote: Please

Re: wip on cordova-lib? pls let us know

2014-06-06 Thread Andrew Grieve
Exciting! I tried the check in node_modules approach in cordova-app-harness and it works really well there: https://github.com/apache/cordova-app-harness/tree/master/harness-push It's a simpler case since there's a strict parent/child relationship. The main unknown for me is how to make

Re: wip on cordova-lib? pls let us know

2014-06-06 Thread Andrew Grieve
/CordovaError then all is well. Easy to answer with a quick test :) On Fri, Jun 6, 2014 at 9:14 AM, Andrew Grieve agri...@chromium.org wrote: Exciting! I tried the check in node_modules approach in cordova-app-harness and it works really well there: https://github.com/apache/cordova-app

Re: publish coho to npm

2014-06-06 Thread Andrew Grieve
There's definitely some upside, but some downsides as well: - would add some overhead for us to have to remember to version publish it after every change - you then need to npm update coho separately from updating all your other repos (via coho repo-update) - coho currently puts all repos as

Parent for browserify?

2014-06-06 Thread Andrew Grieve
Was asked in https://issues.apache.org/jira/browse/CB-5671 Couldn't find one after a quick search though.

Re: Plugman support for Android libraries

2014-06-06 Thread Andrew Grieve
/browse/CB-6698 I suggest the syntax in plugin.xml to be framework src=path/to/library /. Do you think that it will be good to require specification of the custom=true attribute or not? -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew

Re: [Android] CB-6630: Use okhttp as a library

2014-06-04 Thread Andrew Grieve
What is the problem with it? And would moving it to library project fix the problem at all (or do you mean make it a plugin?). On Wed, Jun 4, 2014 at 2:57 PM, Joe Bowser bows...@gmail.com wrote: So, recently I've heard from Greg from Untappd that he was in dependency hell. So, I'm wondering

Re: [Android] CB-6630: Use okhttp as a library

2014-06-04 Thread Andrew Grieve
and replace it with a less nasty hack if possible, since Android has problems with library dependencies. We shouldn't make this a plugin, because it's required by CordovaResourceApi, which is now core, and isn't going away any time soon. On Wed, Jun 4, 2014 at 1:18 PM, Andrew Grieve agri

Re: adding platforms to npm for dependency sanity

2014-06-04 Thread Andrew Grieve
: not invented here On Tue, Jun 3, 2014 at 10:17 AM, Andrew Grieve agri...@chromium.org wrote: On Tue, Jun 3, 2014 at 12:19 PM, Brian LeRoux b...@brian.io wrote: Actually that was 0 LOC which is a fine argument if you ask me. And we both know

Re: [Android] Why does the CordovaResourceApi require a pluginManager in the constructor?

2014-06-04 Thread Andrew Grieve
I think I did that just to be dependency-injection friendly. E.g. try not to deep into nested dependencies. On Wed, Jun 4, 2014 at 5:37 PM, Joe Bowser bows...@gmail.com wrote: Hey I'm looking at various JIRA issues (one of which makes me want to completely re-write Camera), and I'm trying

Re: adding platforms to npm for dependency sanity

2014-06-04 Thread Andrew Grieve
about. The alternative is patchbombing and a massive delete of google employee commits which is probably not productive. On Wed, Jun 4, 2014 at 2:16 PM, Andrew Grieve agri...@chromium.org wrote: Brian's and Carlos' examples have a very important difference: Brian's: platforms

Re: npm based cordova platform add

2014-06-03 Thread Andrew Grieve
is already insane. Has anyone here submitted a cross device app to a store? Made anything more complicated than hello world? I feel like we're losing touch. Worrisome that you feel this way, but this is not actionable feedback. Sent from my iPhone On Jun 2, 2014, at 7:49 PM, Andrew Grieve

Re: npm based cordova platform add

2014-06-03 Thread Andrew Grieve
. Has anyone here submitted a cross device app to a store? Made anything more complicated than hello world? I feel like we're losing touch. Sent from my iPhone On Jun 2, 2014, at 7:49 PM, Andrew Grieve agri...@chromium.org wrote: Tried it out. Seemed to work fine: $ cordova

Re: adding platforms to npm for dependency sanity

2014-06-03 Thread Andrew Grieve
platforms/ Does what Mark has implemented not address a use-case of yours? Or are we going back forth over personal preference? On Tue, Jun 3, 2014 at 9:07 AM, Andrew Grieve agri...@chromium.org wrote: On Tue, Jun 3, 2014 at 11:34 AM, Brian LeRoux b...@brian.io wrote: Andrew, you

Re: adding platforms to npm for dependency sanity

2014-06-03 Thread Andrew Grieve
at last test upgrades when we ship new platform versions). -Michal On Tue, Jun 3, 2014 at 1:28 PM, Brian LeRoux b...@brian.io wrote: NIH: not invented here On Tue, Jun 3, 2014 at 10:17 AM, Andrew Grieve agri...@chromium.org wrote: On Tue, Jun 3, 2014

Re: ngCordova

2014-06-03 Thread Andrew Grieve
Looks great! I love the explicit examples. On Tue, Jun 3, 2014 at 8:27 PM, Michal Mocny mmo...@chromium.org wrote: I remember seeing someone do a presentation about exactly this about a year ago. I see the repo is new -- Was that you with a previous project? Anyway good stuff, just hoping

Re: adding platforms to npm for dependency sanity

2014-06-02 Thread Andrew Grieve
Not sure what your question is. On Mon, Jun 2, 2014 at 2:03 PM, Brian LeRoux b...@brian.io wrote: *ahem On Wed, May 28, 2014 at 11:20 AM, Brian LeRoux b...@brian.io wrote: npm i cordova-ios@3.5.0 Right? On May 27, 2014 11:06 PM, Andrew Grieve agri...@chromium.org wrote: Lazy

Re: adding platforms to npm for dependency sanity

2014-06-02 Thread Andrew Grieve
separately, and scriptable without having to spawn subshells. And if I have it completely wrong, then let me know -- I'll just go back to fixing File bugs ;) On Mon, Jun 2, 2014 at 3:29 PM, Andrew Grieve agri...@chromium.org wrote: Not sure what your question is. On Mon, Jun 2

Re: jira permissions

2014-06-02 Thread Andrew Grieve
I've always made a habit of adding everyone to the PMC list since that's required to be able to assign issues to yourself. We've never had problems with JIRA abuse. On Mon, Jun 2, 2014 at 8:19 PM, sebb seb...@gmail.com wrote: On 2 June 2014 21:43, Shazron shaz...@gmail.com wrote: I don't

Re: Android: Deprecate WebView.sendJavascript()?

2014-06-02 Thread Andrew Grieve
Filed: https://issues.apache.org/jira/browse/CB-6851 On Mon, May 26, 2014 at 9:42 PM, Andrew Grieve agri...@chromium.org wrote: I believe this is the common case that the function is used for. The way to do it without eval is: 1. Have your app receive the intent. If the app is still

Re: npm based cordova platform add

2014-06-02 Thread Andrew Grieve
Tried it out. Seemed to work fine: $ cordova --usenpm platform update ios npm http GET https://registry.npmjs.org/cordova-ios/3.5.0 npm http 200 https://registry.npmjs.org/cordova-ios/3.5.0 npm http GET https://registry.npmjs.org/cordova-ios/-/cordova-ios-3.5.0.tgz npm http 200

Re: Unknown committer

2014-05-29 Thread Andrew Grieve
On Wed, May 28, 2014 at 8:55 PM, Josh Soref jso...@blackberry.com wrote: Shazron wrote: https://git-wip-us.apache.org/repos/asf?p=cordova-blackberry.git;a=commit ; h=b128ad7c6dcf0061c8616ba3e145c07faeaa8e02 Rowell Cruz, from BlackBerry. He has a listed CLA but is definitely not an Apache

Re: Android Plugin API

2014-05-29 Thread Andrew Grieve
Even even nicer might be to use annotations: @ExecCall private void someCall(JSONArray args, CallbackContext callbackContext) On Thu, May 29, 2014 at 4:01 PM, Joe Bowser bows...@gmail.com wrote: This plugin illustrates why applying this to the general case is a terrible idea. Here it's

Re: Android Plugin API

2014-05-28 Thread Andrew Grieve
Another reasonable approach would be to use a MapString, Runnable, but that can be implemented on top of what is currently exposed. I'm quite wary of Reflection as well. On Wed, May 28, 2014 at 10:06 AM, Joe Bowser bows...@gmail.com wrote: The execute command exists for security reasons. We

Re: Unknown committer

2014-05-28 Thread Andrew Grieve
The guidance for how to do pull requests is here: https://github.com/apache/cordova-coho/blob/master/docs/processing-pull-requests.md Sounds like it should be updated to include --sign-off or --no-ff or both? On Wed, May 28, 2014 at 8:23 PM, Steven Gill stevengil...@gmail.com wrote: I use

Re: adding platforms to npm for dependency sanity

2014-05-27 Thread Andrew Grieve
Lazy loading is what will give us the ability to support multiple versions of platforms. If we don't support users choosing the version of the platform they want, then they will resist updating their version of CLI (like they do right now). I'm very keen to allow users to chose their platform

Re: Issue building docs :(

2014-05-26 Thread Andrew Grieve
Thanks Shaz, I had started to run bin/generate and then forgot about it. It's finished now, so I've rebased and uploaded the non-en 3.5.0 docs. On Sun, May 25, 2014 at 12:27 AM, Shazron shaz...@gmail.com wrote: Docs uploaded. On Sat, May 24, 2014 at 9:50 AM, Shazron shaz...@gmail.com wrote:

Android: Deprecate WebView.sendJavascript()?

2014-05-26 Thread Andrew Grieve
From: https://issues.apache.org/jira/browse/CB-6746 It's a fairly common anti-pattern to use sendJavascript() to communicate with native side. Not sure if deprecating the call is the right move, but wanted to pitch the idea. There are multiple pitfalls: 1. As in the bug, it doesn't work if

Re: Issue building docs :(

2014-05-26 Thread Andrew Grieve
Also - just updated the docs.cordova.io redirect. On Mon, May 26, 2014 at 10:22 AM, Andrew Grieve agri...@chromium.orgwrote: Thanks Shaz, I had started to run bin/generate and then forgot about it. It's finished now, so I've rebased and uploaded the non-en 3.5.0 docs. On Sun, May 25, 2014

Re: Android: Deprecate WebView.sendJavascript()?

2014-05-26 Thread Andrew Grieve
PluginResults and swap the implementation on native-side? -Michal On Mon, May 26, 2014 at 1:02 PM, Ian Clelland iclell...@chromium.org wrote: It's probably a good candidate for removal in the 4.0 branch, if we really don't want to support it On Mon, May 26, 2014 at 12:59 PM, Andrew Grieve

Re: Android: Deprecate WebView.sendJavascript()?

2014-05-26 Thread Andrew Grieve
the implementation on native-side? -Michal On Mon, May 26, 2014 at 1:02 PM, Ian Clelland iclell...@chromium.org wrote: It's probably a good candidate for removal in the 4.0 branch, if we really don't want to support it On Mon, May 26, 2014 at 12:59 PM, Andrew Grieve agri

Re: Android: Deprecate WebView.sendJavascript()?

2014-05-26 Thread Andrew Grieve
On Mon, May 26, 2014 at 2:04 PM, Joe Bowser bows...@gmail.com wrote: On Mon, May 26, 2014 at 9:59 AM, Andrew Grieve agri...@chromium.org wrote: From: https://issues.apache.org/jira/browse/CB-6746 Given that you can implement sendJavascript via PluginResults by just eval()ing the results

Re: Android: Deprecate WebView.sendJavascript()?

2014-05-26 Thread Andrew Grieve
I believe this is the common case that the function is used for. The way to do it without eval is: 1. Have your app receive the intent. If the app is still starting up, then store it in a variable. 2. When cordova.js runs, have a plugin whose JS runs on start-up via a runs/ tag. It would call

<    1   2   3   4   5   6   7   8   9   10   >