Re: DISCUSS: Remove Classic connection handling

2017-07-24 Thread Mike Drob
To clarify, this means that folks still on Curator 2.x will see a change in behavior if they go straight to 4.x? It's a major version, so that should be fine but let's make sure it shows up in the release notes. On Mon, Jul 24, 2017 at 12:01 AM, Jordan Zimmerman < jor...@jordanzimmerman.com>

[jira] [Resolved] (CURATOR-313) Verify that Curator logging is appropriate

2017-07-23 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved CURATOR-313. --- Resolution: Not A Problem Thanks for looking, Jordan. I knew that it wasn't an issue anymore

[jira] [Assigned] (CURATOR-313) Verify that Curator logging is appropriate

2017-07-22 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob reassigned CURATOR-313: - Assignee: (was: Mike Drob) > Verify that Curator logging is appropri

[jira] [Resolved] (CURATOR-414) Typo in TestingZooKeeperMain

2017-05-16 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved CURATOR-414. --- Resolution: Fixed LGTM. Thanks for the patch, [~coheigea]! > Typo in TestingZooKeeperM

[jira] [Assigned] (CURATOR-414) Typo in TestingZooKeeperMain

2017-05-16 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob reassigned CURATOR-414: - Assignee: Mike Drob (was: Jordan Zimmerman) > Typo in TestingZooKeeperM

[jira] [Commented] (CURATOR-404) AsyncTransactionOp#create returns the wrong DSL type

2017-04-30 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990146#comment-15990146 ] Mike Drob commented on CURATOR-404: --- Why 99.9%? What's the client that breaks? Looks completely

[jira] [Commented] (CURATOR-200) Proposal: Remove references to guava library from public APIs

2017-01-09 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15812670#comment-15812670 ] Mike Drob commented on CURATOR-200: --- Ah! I misread the diff and see this now. Thank you for clarifying

[jira] [Commented] (CURATOR-200) Proposal: Remove references to guava library from public APIs

2017-01-07 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15808524#comment-15808524 ] Mike Drob commented on CURATOR-200: --- I think we also need to relocate that classes, otherwise they're

Re: [VOTE] Release Apache Curator version 2.11.0 and 3.2.0

2016-06-20 Thread Mike Drob
Yea, as long as you doc it somewhere, it shouldn't be a blocker. On Sat, Jun 18, 2016 at 4:59 PM, Cameron McKenzie wrote: > That's fine with me. You OK with it Mike? > On 19 Jun 2016 1:21 AM, "Jordan Zimmerman" > wrote: > > > Can we solve

Re: [VOTE] Release Apache Curator version 2.11.0 and 3.2.0

2016-06-17 Thread Mike Drob
-1 Downloaded artifacts from staging repos. Signatures are good. Checksums are good. Source zips does not match tag: $ diff --recursive . /tmp/curator/2.11/apache-curator-2.11.0/ Only in /tmp/curator/2.11/apache-curator-2.11.0/curator-framework: test-output Only in

[jira] [Created] (CURATOR-313) Verify that Curator logging is appropriate

2016-03-29 Thread Mike Drob (JIRA)
Mike Drob created CURATOR-313: - Summary: Verify that Curator logging is appropriate Key: CURATOR-313 URL: https://issues.apache.org/jira/browse/CURATOR-313 Project: Apache Curator Issue Type

[jira] [Updated] (CURATOR-262) Issue with ExponentialBackoffRetry

2016-02-25 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated CURATOR-262: -- Labels: newbie (was: ) > Issue with ExponentialBackoffRe

[jira] [Commented] (CURATOR-280) LeaderLatch doesn't work when using a zookeeper chroot

2015-11-10 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14998792#comment-14998792 ] Mike Drob commented on CURATOR-280: --- Does the chroot exist beforehand? Not sure if it needs

[jira] [Commented] (CURATOR-280) LeaderLatch doesn't work when using a zookeeper chroot

2015-11-10 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14998877#comment-14998877 ] Mike Drob commented on CURATOR-280: --- I suspect that it will work with an existing chroot node, please

Namespace client must be started

2015-11-10 Thread Mike Drob
Curators, I noticed earlier today that client.usingNamespace() has a precondition check for whether it's been started or not. Is there a reason for this? I could imagine a scenario where you prepare a client by namespacing it and then don't start it until later when you need to do your actual

[jira] [Commented] (CURATOR-278) In transactions compressed option does not work with some fluent api combinations

2015-11-10 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14999359#comment-14999359 ] Mike Drob commented on CURATOR-278: --- Also, need to check for conflicts with CURATOR-148

[jira] [Assigned] (CURATOR-278) In transactions compressed option does not work with some fluent api combinations

2015-11-10 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob reassigned CURATOR-278: - Assignee: Mike Drob The patch looks pretty good, thank you for submitting it, Grant! I need

Re: [VOTE] Release Apache Curator version 2.9.1

2015-10-29 Thread Mike Drob
+1 Verified signatures and checksums. Verified compatibility with 2.9.0 release. Contents of zip file have 777 permissions, which probably isn't a huge issue but is mildly annoying/surprising. Cam, are you building on Windows, by chance? On Thu, Oct 29, 2015 at 12:48 PM, Jordan Zimmerman <

Re: [VOTE] Release Apache Curator version 2.9.1

2015-10-29 Thread Mike Drob
I'm looking at the RC in between other [dayjob] responsibilities right now, and should get a chance to post a vote in the next couple hours. Not sure if I'll make the 72 hours, I hope that's not a strict deadline and more of a guideline. Mike On Thu, Oct 29, 2015 at 12:11 PM, Jordan Zimmerman <

Re: ETA on Curator 2.9.1

2015-10-20 Thread Mike Drob
It should be prompting you for what to name the tags, unless something changed recently. If not, check out the arguments for batch mode: http://maven.apache.org/maven-release/maven-release-plugin/examples/non-interactive-release.html Might need to specify -Dtag=apache-curator-2.9.1

Re: https://github.com/apache/curator/pull/99

2015-10-16 Thread Mike Drob
Sorry for the delay, Jordan, I've been traveling recently. My implementing in the PR is not complete, if I'm holding up a release probably safe to bump to the next version. I'll try to wrap things up next week. On Fri, Oct 16, 2015, 1:32 PM Jordan Zimmerman wrote:

Re: [ANNOUNCE] Apache Curator 2.9.0 released

2015-09-10 Thread Mike Drob
Jordan, can you mark the fix version as released in JIRA when you get a chance? https://issues.apache.org/jira/browse/CURATOR/fixforversion/12332392 On Thu, Sep 10, 2015 at 12:21 PM, Mike Drob <md...@mdrob.com> wrote: > Hello, > > The Apache Curator team is pleased to annou

Re: Git Push Summary

2015-09-03 Thread Mike Drob
ng to branch off this tag so I could run the tests etc. > > On Thu, Sep 3, 2015 at 4:18 AM, Jordan Zimmerman < > jor...@jordanzimmerman.com > > wrote: > > > I meant Maven encryption. You had the right ref. > > > > > > > > On September 2, 2015 at 11:16:47 AM, Mike Drob (md...@apache.org) > wrote: > > > > https://maven.apache.org/guides/mini/guide-encryption.html > >

Re: Git Push Summary

2015-09-02 Thread Mike Drob
In the wiki page https://cwiki.apache.org/confluence/display/CURATOR/For+Curator+Committers#ForCuratorCommitters-maven-settings it tells me to use APACHE-PASSWORD-ENCODED. I thought this meant to use an encrypted password a la https://maven.apache.org/guides/mini/guide-encryption.html When I

Re: [VOTE] Release Apache Curator version 2.9.0

2015-09-02 Thread Mike Drob
Yes. Did you import it? On Wed, Sep 2, 2015, 4:07 PM Jordan Zimmerman <jor...@jordanzimmerman.com> wrote: > gpg: Signature made Wed Sep 2 10:59:33 2015 PDT using RSA key ID EF362B9E > > gpg: Good signature from "Mike Drob (CODE SIGNING KEY) <md...@apache.org>&quo

[jira] [Commented] (CURATOR-256) Provide curator artifact in Maven Central with Guava shaded away

2015-08-31 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14724619#comment-14724619 ] Mike Drob commented on CURATOR-256: --- I think I would prefer the approach in CURATOR-200, since we still

[jira] [Commented] (CURATOR-253) Use new injectSessionExpiration() in the test module

2015-08-28 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14720439#comment-14720439 ] Mike Drob commented on CURATOR-253: --- bq. Hmm - the only problem is where to put it. We

[jira] [Commented] (CURATOR-233) Bug in double barrier

2015-08-26 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715219#comment-14715219 ] Mike Drob commented on CURATOR-233: --- Yea, that's probably ok. I didn't see a 2.9.1

DistributedDoubleBarrier semantics

2015-08-25 Thread Mike Drob
Devs, I was working on CURATOR-233 and I realized that I don't really understand the semantics of the DistributedDoubleBarrier when there are more clients than the given member quantity. Note that I'm not asking about what the code currently does (because I suspect it has a few inconsistencies)

Re: Build failed in Jenkins: Curator-3.0 #4

2015-08-25 Thread Mike Drob
Apologies for the noise here. When I initially configured the Curator-3.0 job, I missed that it needed to be Java 7, so we're ending up with a few failed builds because of that. On Tue, Aug 25, 2015 at 1:19 PM, Apache Jenkins Server jenk...@builds.apache.org wrote: See

[jira] [Commented] (CURATOR-161) Support Watcher Removal

2015-08-25 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14711780#comment-14711780 ] Mike Drob commented on CURATOR-161: --- {noformat} [INFO] Missing header in: curator

[jira] [Commented] (CURATOR-161) Support Watcher Removal

2015-08-25 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14711894#comment-14711894 ] Mike Drob commented on CURATOR-161: --- Oh, I didn't know we had that. Ran it and pushed

[jira] [Commented] (CURATOR-252) TestLeaderSelectorEdges::createProtectedNodeInBackgroundTest failed

2015-08-24 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14709289#comment-14709289 ] Mike Drob commented on CURATOR-252: --- When there are timing related failures, then we

[jira] [Resolved] (CURATOR-234) Add test logging back to modules

2015-08-24 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved CURATOR-234. --- Resolution: Fixed Added test logging to curator-x modules and verified output manually. Add test

[jira] [Commented] (CURATOR-167) All registered watchers should be cleared on close

2015-08-24 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14709470#comment-14709470 ] Mike Drob commented on CURATOR-167: --- [~cammckenzie] - Can you make sure that the PR

[DISCUSS] Releasing Curator 2.9

2015-08-24 Thread Mike Drob
Devs, First, a big thanks to Jordan for fixing the two test failures that we've been seeing. I'm going to try and get Curator 2.9 ready for release. There is one remaining issue open - CURATOR-167 https://issues.apache.org/jira/browse/CURATOR-167 Once that is resolved, I'm going to run through

[jira] [Commented] (CURATOR-217) Use new Watcher Removal APIs in Curator Recipes

2015-08-24 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14709486#comment-14709486 ] Mike Drob commented on CURATOR-217: --- The PR is closed, was this merged in? Can

[jira] [Commented] (CURATOR-233) Bug in double barrier

2015-08-24 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14709692#comment-14709692 ] Mike Drob commented on CURATOR-233: --- Ah, I think I see what you are saying. I did

[jira] [Assigned] (CURATOR-233) Bug in double barrier

2015-08-24 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob reassigned CURATOR-233: - Assignee: Mike Drob Bug in double barrier - Key

Re: CURATOR-217?

2015-08-24 Thread Mike Drob
if you're going to tray that, here's what you want to do (assuming command line) git checkout CURATOR-167 # start with the branch that you are changing git rebase -i master # rebase the current branch on top of the given branch On Mon, Aug 24, 2015 at 5:07 PM, Cameron McKenzie

Re: CURATOR-217?

2015-08-24 Thread Mike Drob
? On Tue, Aug 25, 2015 at 8:48 AM, Cameron McKenzie mckenzie@gmail.com wrote: Thanks Mike, Will give it a spin today some time. cheers On Tue, Aug 25, 2015 at 8:36 AM, Mike Drob mad...@cloudera.com wrote: if you're going to tray that, here's what you want to do (assuming command

[jira] [Updated] (CURATOR-252) TestLeaderSelectorEdges::createProtectedNodeInBackgroundTest failed

2015-08-21 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated CURATOR-252: -- Affects Version/s: (was: 2.9.0) Priority: Blocker (was: Major) Fix Version/s

[jira] [Commented] (CURATOR-233) Bug in double barrier

2015-08-21 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14707361#comment-14707361 ] Mike Drob commented on CURATOR-233: --- Hi J D! Thanks for attaching your test case, I

[jira] [Resolved] (CURATOR-250) CURATOR-224 caused regression of CURATOR-56

2015-08-21 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved CURATOR-250. --- Resolution: Duplicate Dup of CURATOR-231? CURATOR-224 caused regression of CURATOR-56

[jira] [Commented] (CURATOR-243) TestDistributedIdQueue.testRequeuingWithLock is failing

2015-08-21 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14707133#comment-14707133 ] Mike Drob commented on CURATOR-243: --- Does this need to be merged into 3.0

Re: Next Steps

2015-08-21 Thread Mike Drob
Is there a curator-3.0 jenkins job? On Wed, Aug 19, 2015 at 4:47 PM, Cameron McKenzie mckenzie@gmail.com wrote: Nope, all sorted. Thanks. On Thu, Aug 20, 2015 at 6:29 AM, Jordan Zimmerman jor...@jordanzimmerman.com wrote: Resending - is there something I need to do on watchers?

[jira] [Commented] (CURATOR-243) TestDistributedIdQueue.testRequeuingWithLock is failing

2015-08-17 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699588#comment-14699588 ] Mike Drob commented on CURATOR-243: --- The logs from this test make me think

Re: Next Steps

2015-08-16 Thread Mike Drob
hear anything, I'm going to go ahead and push the updates. I will leave old branch markers on the old stuff to avoid being destructive. On Fri, Aug 14, 2015 at 3:24 PM, Mike Drob mad...@cloudera.com wrote: Once we have a stable 3.0

[jira] [Commented] (CURATOR-234) Add test logging back to modules

2015-08-14 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697781#comment-14697781 ] Mike Drob commented on CURATOR-234: --- I pushed this, but the added logging made

[jira] [Resolved] (CURATOR-234) Add test logging back to modules

2015-08-14 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved CURATOR-234. --- Resolution: Fixed Fix Version/s: 2.9.0 Jenkins is back to completing. Add test logging back

[jira] [Work started] (CURATOR-234) Add test logging back to modules

2015-08-14 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on CURATOR-234 started by Mike Drob. - Add test logging back to modules

[jira] [Resolved] (CURATOR-129) Two of PathChildrenCache's constructors need better doc

2015-08-11 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved CURATOR-129. --- Resolution: Fixed Assignee: Mike Drob Fix Version/s: 2.9.0 Thanks for looking

[jira] [Created] (CURATOR-242) TestDistributedQueue.testCustomExecutor() is failing

2015-08-11 Thread Mike Drob (JIRA)
Mike Drob created CURATOR-242: - Summary: TestDistributedQueue.testCustomExecutor() is failing Key: CURATOR-242 URL: https://issues.apache.org/jira/browse/CURATOR-242 Project: Apache Curator

[jira] [Created] (CURATOR-243) TestDistributedIdQueue.testRequeuingWithLock is failing

2015-08-11 Thread Mike Drob (JIRA)
Mike Drob created CURATOR-243: - Summary: TestDistributedIdQueue.testRequeuingWithLock is failing Key: CURATOR-243 URL: https://issues.apache.org/jira/browse/CURATOR-243 Project: Apache Curator

[jira] [Commented] (CURATOR-129) Two of PathChildrenCache's constructors need better doc

2015-08-07 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662282#comment-14662282 ] Mike Drob commented on CURATOR-129: --- I just pushed this change. Can somebody look

[jira] [Commented] (CURATOR-231) TestDistributedQueue.testRetryAfterFailure_Curator56 fails

2015-08-03 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652442#comment-14652442 ] Mike Drob commented on CURATOR-231: --- Note that this is still failing. https

[jira] [Commented] (CURATOR-240) Severe memory leak in TreeCache when path does not exist

2015-07-31 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14649738#comment-14649738 ] Mike Drob commented on CURATOR-240: --- I had spent a little bit of time looking

Re: [ANN] Apache Curator welcomes Mike Drob as a new Committer and PMC member.

2015-07-28 Thread Mike Drob
, Cameron McKenzie mckenzie@gmail.com wrote: The Apache Curator project is happy to announce that Mike Drob (md...@apache.org dragonsi...@apache.org) is a now a committer and PMC member of the project. Mike has been a great member of the Curator community and will be a great addition

[jira] [Commented] (CURATOR-228) A serious death cycle error(一个严重的死循环错误)

2015-07-22 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14638099#comment-14638099 ] Mike Drob commented on CURATOR-228: --- Logging a message is a reasonable first cut

[jira] [Created] (CURATOR-238) Create code style file for NetBeans

2015-07-20 Thread Mike Drob (JIRA)
Mike Drob created CURATOR-238: - Summary: Create code style file for NetBeans Key: CURATOR-238 URL: https://issues.apache.org/jira/browse/CURATOR-238 Project: Apache Curator Issue Type: Sub-task

[jira] [Commented] (CURATOR-238) Create code style file for NetBeans

2015-07-20 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634113#comment-14634113 ] Mike Drob commented on CURATOR-238: --- Yea, this is meant to be more of a guideline than

[jira] [Created] (CURATOR-237) [Parent] Create code style files for other IDEs

2015-07-20 Thread Mike Drob (JIRA)
Mike Drob created CURATOR-237: - Summary: [Parent] Create code style files for other IDEs Key: CURATOR-237 URL: https://issues.apache.org/jira/browse/CURATOR-237 Project: Apache Curator Issue

[jira] [Commented] (CURATOR-232) Consolidate test code

2015-07-19 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14632917#comment-14632917 ] Mike Drob commented on CURATOR-232: --- Updated PR that adds features to BaseClassForTests

Re: Can somebody look at open PRs?

2015-07-15 Thread Mike Drob
. -JZ On July 14, 2015 at 12:35:15 PM, Mike Drob (md...@apache.org) wrote: Hey Curator Devs! I've got a few open PRs, and was hoping somebody would be willing to take a look at some/all of them. In roughly priority order - https://issues.apache.org/jira/browse/CURATOR-234 - Test Logging

[jira] [Commented] (CURATOR-231) TestDistributedQueue.testRetryAfterFailure_Curator56 fails

2015-07-13 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624569#comment-14624569 ] Mike Drob commented on CURATOR-231: --- According to git bisect, the test failure comes

[jira] [Commented] (CURATOR-231) TestDistributedQueue.testRetryAfterFailure_Curator56 fails

2015-07-13 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624584#comment-14624584 ] Mike Drob commented on CURATOR-231: --- Yea, CURATOR-224 ended up being an effective

[jira] [Commented] (CURATOR-232) Consolidate test code

2015-07-13 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624626#comment-14624626 ] Mike Drob commented on CURATOR-232: --- I understand that this diff might be kind of large

[jira] [Commented] (CURATOR-218) TreeCache initialization problem with non existant root path

2015-07-08 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618806#comment-14618806 ] Mike Drob commented on CURATOR-218: --- Progress! In {{ConnectionState.process}}, we call

[jira] [Created] (CURATOR-231) TestDistributedQueue.testRetryAfterFailure_Curator56 fails

2015-07-08 Thread Mike Drob (JIRA)
Mike Drob created CURATOR-231: - Summary: TestDistributedQueue.testRetryAfterFailure_Curator56 fails Key: CURATOR-231 URL: https://issues.apache.org/jira/browse/CURATOR-231 Project: Apache Curator

[jira] [Commented] (CURATOR-218) Race condition in client.blockUntilConnected()

2015-07-08 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618913#comment-14618913 ] Mike Drob commented on CURATOR-218: --- I'm happy to work the issue, but my understanding

[jira] [Created] (CURATOR-232) Consolidate test code

2015-07-08 Thread Mike Drob (JIRA)
Mike Drob created CURATOR-232: - Summary: Consolidate test code Key: CURATOR-232 URL: https://issues.apache.org/jira/browse/CURATOR-232 Project: Apache Curator Issue Type: Improvement

[jira] [Commented] (CURATOR-218) TreeCache initialization problem with non existant root path

2015-06-25 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14601301#comment-14601301 ] Mike Drob commented on CURATOR-218: --- bq. The tests never fail for me. Do I have to run

[jira] [Commented] (CURATOR-219) Avoid use of Throwable

2015-06-24 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14599938#comment-14599938 ] Mike Drob commented on CURATOR-219: --- I'm commenting on the issue instead of the pull

[jira] [Commented] (CURATOR-225) Add a new mode ErrorMode.KEEP

2015-06-24 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14599862#comment-14599862 ] Mike Drob commented on CURATOR-225: --- Is the intent for the consumer to leave

[jira] [Commented] (CURATOR-167) All registered watchers should be cleared on close

2015-06-24 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14599957#comment-14599957 ] Mike Drob commented on CURATOR-167: --- Are we going to drop this in favor of the complete

[jira] [Commented] (CURATOR-221) ACLProvider is not respected on parent nodes after calling CuratorFramework.usingNamespace

2015-05-18 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14549276#comment-14549276 ] Mike Drob commented on CURATOR-221: --- I'm not sure this is a bug in Curator. When you

[jira] [Commented] (CURATOR-221) ACLProvider is not respected on parent nodes after calling CuratorFramework.usingNamespace

2015-05-18 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14549279#comment-14549279 ] Mike Drob commented on CURATOR-221: --- Can you create the namespace root separately? Also

[jira] [Created] (CURATOR-219) Avoid use of Throwable

2015-05-12 Thread Mike Drob (JIRA)
Mike Drob created CURATOR-219: - Summary: Avoid use of Throwable Key: CURATOR-219 URL: https://issues.apache.org/jira/browse/CURATOR-219 Project: Apache Curator Issue Type: Bug

Re: Last chance for comments on https://github.com/apache/curator/pull/77

2015-05-12 Thread Mike Drob
Actually, a few things came up, a couple of hours would be appreciated. On Tue, May 12, 2015 at 11:00 AM, Mike Drob mad...@cloudera.com wrote: I'll take a look, please give me an hour or so. On Tue, May 12, 2015 at 10:58 AM, Jordan Zimmerman jor...@jordanzimmerman.com wrote: Any comments

[jira] [Commented] (CURATOR-145) TreeCache should implement maxDepth

2015-05-12 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14540060#comment-14540060 ] Mike Drob commented on CURATOR-145: --- [~dragonsinth] - what version was this fixed in? I

Re: [VOTE] Release Apache Curator version 2.8.0 - Candidate 2

2015-05-09 Thread Mike Drob
I would expect the source zip to match what is in version control, and would prefer a version without the extra files. Compatibility checks pass. Unit tests pass. +1 non binding On Sat, May 9, 2015 at 5:27 PM, Jordan Zimmerman jor...@jordanzimmerman.com wrote: Reminder we have a vote going

Re: [VOTE] Release Apache Curator version 2.8.0

2015-05-08 Thread Mike Drob
a script, please share and I’ll put it on the wiki. -Jordan On May 7, 2015 at 6:31:50 PM, Mike Drob (mad...@cloudera.com) wrote: I'm using the java-api-compatibility-checker [1] I think I ran into a bug with it, so I had to run using Java 7 instead of Java 8, but that probably does

Re: [VOTE] Release Apache Curator version 2.8.0

2015-05-08 Thread Mike Drob
...@jordanzimmerman.com) wrote: I’ll take a stab at the script given your description below. You can modify later. Thank you. On May 8, 2015 at 12:26:44 PM, Mike Drob (mad...@cloudera.com) wrote: Just to set expectations, I'm not sure I'll have time for this today. This release might still have

Re: [VOTE] Release Apache Curator version 2.8.0

2015-05-07 Thread Mike Drob
a org.codehaus.jackson.JsonNode from a com.fasterxml.jackson.databind.JsonNode? Not easily I imagine. I agree though that we should be moving this to 3.0.0 if we cannot make the change without breaking compatibility. cheers On Thu, May 7, 2015 at 10:41 AM, Mike Drob mad...@cloudera.com wrote: -1 non

Re: [VOTE] Release Apache Curator version 2.8.0

2015-05-06 Thread Mike Drob
-1 non-binding We break backward compatibility in this release. Here are reports run via the java-api-compliance-checker: http://people.apache.org/~mdrob/curator-2.8.0/x-discovery-server-back.html http://people.apache.org/~mdrob/curator-2.8.0/x-rpc-back.html The rest of the modules came up

Re: Testing server restart

2015-04-28 Thread Mike Drob
Thanks for getting this straightened out, Cameron! On Tue, Apr 28, 2015 at 12:31 AM, Cameron McKenzie mckenzie@gmail.com wrote: Build seems to be back to normal now too. On Tue, Apr 28, 2015 at 1:59 PM, Cameron McKenzie mckenzie@gmail.com wrote: Changes are merged into master now.

[jira] [Commented] (CURATOR-164) curator-x-discovery: unregisterService is not guaranteed to remove the service, due to reconnectListener concurrency issue

2015-04-27 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14516154#comment-14516154 ] Mike Drob commented on CURATOR-164: --- I think this broke the build? https

[jira] [Commented] (CURATOR-204) Use the latest apache parent pom

2015-04-21 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14505637#comment-14505637 ] Mike Drob commented on CURATOR-204: --- We can do parallel tests with CURATOR-142. Use

[jira] [Commented] (CURATOR-164) curator-x-discovery: unregisterService is not guaranteed to remove the service, due to reconnectListener concurrency issue

2015-04-21 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14505829#comment-14505829 ] Mike Drob commented on CURATOR-164: --- I think the ServiceInstance is fine to sync

[jira] [Commented] (CURATOR-164) curator-x-discovery: unregisterService is not guaranteed to remove the service, due to reconnectListener concurrency issue

2015-04-21 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14505864#comment-14505864 ] Mike Drob commented on CURATOR-164: --- The new solution includes a lot more

[jira] [Commented] (CURATOR-164) curator-x-discovery: unregisterService is not guaranteed to remove the service, due to reconnectListener concurrency issue

2015-04-21 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14505817#comment-14505817 ] Mike Drob commented on CURATOR-164: --- Your version is still susceptible to incorrect

[jira] [Commented] (CURATOR-164) curator-x-discovery: unregisterService is not guaranteed to remove the service, due to reconnectListener concurrency issue

2015-04-21 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14505917#comment-14505917 ] Mike Drob commented on CURATOR-164: --- Can you show a test case that the original patch

[jira] [Commented] (CURATOR-148) Order of modifiers on framework commands matters

2015-04-21 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14505943#comment-14505943 ] Mike Drob commented on CURATOR-148: --- I was under the impression that we'd be sticking

[jira] [Commented] (CURATOR-164) curator-x-discovery: unregisterService is not guaranteed to remove the service, due to reconnectListener concurrency issue

2015-04-21 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14506027#comment-14506027 ] Mike Drob commented on CURATOR-164: --- I'll post review comments here so that I can batch

[jira] [Commented] (CURATOR-164) curator-x-discovery: unregisterService is not guaranteed to remove the service, due to reconnectListener concurrency issue

2015-04-21 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14505793#comment-14505793 ] Mike Drob commented on CURATOR-164: --- The JVM has been pretty good about biased locking

[jira] [Commented] (CURATOR-148) Order of modifiers on framework commands matters

2015-04-21 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14505922#comment-14505922 ] Mike Drob commented on CURATOR-148: --- [~randgalt] On the ML you said you'd like

[jira] [Updated] (CURATOR-168) Error 'Path must start with / character' caused by code 'setNode(event.getName());' in line 487 of LeaderLatch.class source file in which 'event.getName()' sometimes

2015-04-08 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated CURATOR-168: -- Attachment: CURATOR-168.patch [~zhaogang], [~osmanscam] - Can either of you try applying the patch

[jira] [Commented] (CURATOR-168) Error 'Path must start with / character' caused by code 'setNode(event.getName());' in line 487 of LeaderLatch.class source file in which 'event.getName()' sometime

2015-04-08 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14485632#comment-14485632 ] Mike Drob commented on CURATOR-168: --- Is this the same issue as CURATOR-165? Error

[jira] [Commented] (CURATOR-99) Java 8 refactoring

2015-04-07 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14483492#comment-14483492 ] Mike Drob commented on CURATOR-99: -- You are correct. I just checked and it looks like ZK

[jira] [Commented] (CURATOR-200) Proposal: Remove references to guava library from public APIs

2015-04-07 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14483457#comment-14483457 ] Mike Drob commented on CURATOR-200: --- Since Guava is Apache licensed, we can always just

  1   2   >