Re: [DISCUSS] Should Configuration support getting value based on String key?

2023-12-13 Thread Rui Fan
re already > used in this kind of scenarios. > If it just needs to read some of the config, why not using the proposed > way to read and parse the config? Pre-defined ConfigOptions are better > for configuration maintenance, compared to arbitrary strings > > Thanks, > Zhu &

Re: [DISCUSS] Should Configuration support getting value based on String key?

2023-12-13 Thread Rui Fan
gt; On Wed, Dec 13, 2023 at 12:15 PM Rui Fan <1996fan...@gmail.com> wrote: > > > > Hi Martijn, > > > > Thanks for your reply! > > > > I noticed the 2.0 is doing some work related to clean configuration. > > But this discussion is different from othe

Re: [DISCUSS] Should Configuration support getting value based on String key?

2023-12-13 Thread Rui Fan
m if they are still used. > > > > -Max > > > > On Wed, Dec 13, 2023 at 4:59 AM Rui Fan <1996fan...@gmail.com> wrote: > > > > > > Hi devs, > > > > > > I'd like to start a discussion to discuss whether Configuration > supports > &

[jira] [Created] (FLINK-33814) Autoscaler Standalone control loop supports multiple thread

2023-12-13 Thread Rui Fan (Jira)
Rui Fan created FLINK-33814: --- Summary: Autoscaler Standalone control loop supports multiple thread Key: FLINK-33814 URL: https://issues.apache.org/jira/browse/FLINK-33814 Project: Flink Issue

[jira] [Created] (FLINK-33813) Improve time formatting for easier reading inside the autoscaler

2023-12-12 Thread Rui Fan (Jira)
Rui Fan created FLINK-33813: --- Summary: Improve time formatting for easier reading inside the autoscaler Key: FLINK-33813 URL: https://issues.apache.org/jira/browse/FLINK-33813 Project: Flink

[DISCUSS] Should Configuration support getting value based on String key?

2023-12-12 Thread Rui Fan
Hi devs, I'd like to start a discussion to discuss whether Configuration supports getting value based on the String key. In the FLIP-77[1] and FLINK-14493[2], a series of methods of Configuration are marked as @Deprecated, for example: - public String getString(String key, String defaultValue) -

[jira] [Created] (FLINK-33801) Revert to last scaling when job becomes unhealthy after scaling

2023-12-12 Thread Rui Fan (Jira)
Rui Fan created FLINK-33801: --- Summary: Revert to last scaling when job becomes unhealthy after scaling Key: FLINK-33801 URL: https://issues.apache.org/jira/browse/FLINK-33801 Project: Flink Issue

Re: [DISCUSS] Change the default restart-strategy to exponential-delay

2023-12-11 Thread Rui Fan
ing > I > > found helpful in the past is to refer to Kubernetes--for example, the > > default strategy is exponential for pod restarts and we could draw > > inspiration from what they have set as a general purpose default config. > > > > Best, > > Mason >

Re: [VOTE] FLIP-396: Trial to test GitHub Actions as an alternative for Flink's current Azure CI infrastructure

2023-12-11 Thread Rui Fan
+1(binding) Best, Rui On Tue, Dec 12, 2023 at 11:58 AM weijie guo wrote: > Thanks Matthias for this efforts. > > +1(binding) > > > Best regards, > > Weijie > > > Matthias Pohl 于2023年12月11日周一 21:51写道: > > > Hi everyone, > > I'd like to start a vote on FLIP-396 [1]. It covers enabling GitHub >

Re: [DISCUSS] Release Flink 1.18.1

2023-12-09 Thread Rui Fan
Thanks Jing for driving this release, +1 Best, Rui On Sat, Dec 9, 2023 at 7:33 AM Leonard Xu wrote: > Thanks Jing for driving this release, +1 > > Best, > Leonard > > > 2023年12月9日 上午1:23,Danny Cranmer 写道: > > > > +1 > > > > Thanks for driving this > > > > On Fri, 8 Dec 2023, 12:05 Timo

Re: SQL return type change from 1.17 to 1.18

2023-12-07 Thread Rui Fan
Hi all, +1 for reverting it. Also, I’m not sure should we release 1.18.1 as soon as possible after it’s merged. If I understand correctly, users cannot upgrade flink job from 1.18.0 to 1.18.1 directly if we reverting it in 1.18.1, right? If so, it’s better to release 1.18.1 asap, and try to

Re: [PROPOSAL] Contribute Flink CDC Connectors project to Apache Flink

2023-12-06 Thread Rui Fan
It's cool! Thanks for the great work of CDC, +1 for this donation. Best, Rui On Thu, Dec 7, 2023 at 12:28 PM Hongshun Wang wrote: > So cool, Big +1 for this exciting work. > > Best > Hongshun > > On Thu, Dec 7, 2023 at 12:20 PM Qingsheng Ren wrote: > > > Thanks for kicking this off, Leonard!

[jira] [Created] (FLINK-33752) When Duration is greater than or equal to 1 day, the display unit is ms.

2023-12-05 Thread Rui Fan (Jira)
Rui Fan created FLINK-33752: --- Summary: When Duration is greater than or equal to 1 day, the display unit is ms. Key: FLINK-33752 URL: https://issues.apache.org/jira/browse/FLINK-33752 Project: Flink

[jira] [Created] (FLINK-33739) Document FLIP-364: Improve the exponential-delay restart-strategy

2023-12-04 Thread Rui Fan (Jira)
Rui Fan created FLINK-33739: --- Summary: Document FLIP-364: Improve the exponential-delay restart-strategy Key: FLINK-33739 URL: https://issues.apache.org/jira/browse/FLINK-33739 Project: Flink

[jira] [Created] (FLINK-33738) Make exponential-delay restart-strategy the default restart strategy

2023-12-04 Thread Rui Fan (Jira)
Rui Fan created FLINK-33738: --- Summary: Make exponential-delay restart-strategy the default restart strategy Key: FLINK-33738 URL: https://issues.apache.org/jira/browse/FLINK-33738 Project: Flink

[jira] [Created] (FLINK-33737) Merge multiple Exceptions into one attempt for exponential-delay restart-strategy

2023-12-04 Thread Rui Fan (Jira)
Rui Fan created FLINK-33737: --- Summary: Merge multiple Exceptions into one attempt for exponential-delay restart-strategy Key: FLINK-33737 URL: https://issues.apache.org/jira/browse/FLINK-33737 Project

[jira] [Created] (FLINK-33736) Update default value of exponential-delay.max-backoff and exponential-delay.backoff-multiplier

2023-12-04 Thread Rui Fan (Jira)
Rui Fan created FLINK-33736: --- Summary: Update default value of exponential-delay.max-backoff and exponential-delay.backoff-multiplier Key: FLINK-33736 URL: https://issues.apache.org/jira/browse/FLINK-33736

[jira] [Created] (FLINK-33735) FLIP-364: Improve the exponential-delay restart-strategy

2023-12-04 Thread Rui Fan (Jira)
Rui Fan created FLINK-33735: --- Summary: FLIP-364: Improve the exponential-delay restart-strategy Key: FLINK-33735 URL: https://issues.apache.org/jira/browse/FLINK-33735 Project: Flink Issue Type

[RESULT][VOTE] FLIP-364: Improve the exponential-delay restart-strategy

2023-12-04 Thread Rui Fan
) - Matthias Pohl (binding) - Jing Ge (binding) - Rui Fan (binding) Thanks to all participants for the discussion, voting, and providing valuable feedback. [1] https://cwiki.apache.org/confluence/x/uJqzDw [2] https://lists.apache.org/thread/xo03tzw6d02w1vbcj5y9ccpqyc7bqrh9 Best, Rui

Re: [VOTE] FLIP-364: Improve the restart-strategy

2023-12-04 Thread Rui Fan
hao Chen 于2023年11月30日周四 23:31写道: > > > > > > > +1 (non-binding) > > > > > > > > Best, > > > > Zhanghao Chen > > > > > > > > From: Rui Fan <1996fan...@gmail.com> > > > > Sent: Monday, N

[jira] [Created] (FLINK-33731) failover.flip1 package can be rename to failover

2023-12-03 Thread Rui Fan (Jira)
Rui Fan created FLINK-33731: --- Summary: failover.flip1 package can be rename to failover Key: FLINK-33731 URL: https://issues.apache.org/jira/browse/FLINK-33731 Project: Flink Issue Type: Technical

[jira] [Created] (FLINK-33701) restart.time-tracking doc is wrong

2023-11-30 Thread Rui Fan (Jira)
Rui Fan created FLINK-33701: --- Summary: restart.time-tracking doc is wrong Key: FLINK-33701 URL: https://issues.apache.org/jira/browse/FLINK-33701 Project: Flink Issue Type: Technical Debt

Re: [VOTE] FLIP-364: Improve the restart-strategy

2023-11-30 Thread Rui Fan
+1(binding) Best, Rui On Mon, Nov 13, 2023 at 11:01 AM Rui Fan <1996fan...@gmail.com> wrote: > Hi everyone, > > Thank you to everyone for the feedback on FLIP-364: Improve the > restart-strategy[1] > which has been discussed in this thread [2]. > > I would like to st

Re: [VOTE] FLIP-379: Dynamic source parallelism inference for batch jobs

2023-11-30 Thread Rui Fan
+1(binding) Best, Rui On Thu, Nov 30, 2023 at 3:56 PM Lijie Wang wrote: > +1 (binding) > > Best, > Lijie > > Zhu Zhu 于2023年11月30日周四 13:13写道: > > > +1 > > > > Thanks, > > Zhu > > > > Xia Sun 于2023年11月30日周四 11:41写道: > > > > > Hi everyone, > > > > > > I'd like to start a vote on FLIP-379:

[ANNOUNCE] Apache Flink 1.16.3 released

2023-11-29 Thread Rui Fan
The Apache Flink community is very happy to announce the release of Apache Flink 1.16.3, which is the third bugfix release for the Apache Flink 1.16 series. Apache Flink® is an open-source stream processing framework for distributed, high-performing, always-available, and accurate data

[jira] [Created] (FLINK-33693) The disable unaligned checkpoint isn't respected when the aligned checkpoint timeout is enabled

2023-11-29 Thread Rui Fan (Jira)
Rui Fan created FLINK-33693: --- Summary: The disable unaligned checkpoint isn't respected when the aligned checkpoint timeout is enabled Key: FLINK-33693 URL: https://issues.apache.org/jira/browse/FLINK-33693

Re: [DISCUSS] FLIP-364: Improve the restart-strategy

2023-11-29 Thread Rui Fan
org/thread/xo03tzw6d02w1vbcj5y9ccpqyc7bqrh9 Best, Rui On Fri, Nov 17, 2023 at 12:02 PM Mingliang Liu wrote: > Thank you Rui. It makes sense to me now. > > On Thu, Nov 16, 2023 at 2:57 AM Rui Fan <1996fan...@gmail.com> wrote: > > > Hi all, > > > > Zhu and I had

Re: [VOTE] Release flink-shaded 18.0, release candidate #1

2023-11-29 Thread Rui Fan
Sorry, it's non-binding. On Wed, Nov 29, 2023 at 5:19 PM Rui Fan <1996fan...@gmail.com> wrote: > Thanks Matthias for the clarification! > > After I import the latest KEYS, it works fine. > > +1(binding) > > - Validated checksum hash > - Verified signature >

Re: [VOTE] Release flink-shaded 18.0, release candidate #1

2023-11-29 Thread Rui Fan
2023 at 9:41 AM Rui Fan <1996fan...@gmail.com> wrote: > > > Hey Sergey, > > > > Thank you for driving this release. > > > > I try to check this signature, the whole key is > > F7529FAE24811A5C0DF3CA741596BBF0726835D8, > > it matches you

Re: [ANNOUNCE] Experimental Java 21 support now available on master

2023-11-29 Thread Rui Fan
Thanks Sergey for the great work! Best, Rui On Wed, Nov 29, 2023 at 4:42 PM Leonard Xu wrote: > Cool ! > > Thanks Sergey for the great effort and all involved. > > > Best, > Leonard > > > 2023年11月29日 下午4:31,Swapnal Varma 写道: > > > > Congratulations Sergey, and everyone involved! > > > >

Re: [VOTE] Release flink-shaded 18.0, release candidate #1

2023-11-29 Thread Rui Fan
Hey Sergey, Thank you for driving this release. I try to check this signature, the whole key is F7529FAE24811A5C0DF3CA741596BBF0726835D8, it matches your 1596BBF0726835D8, but I cannot find it from the Flink KEYS[1]. Please correct me if my operation is wrong, thanks~ [1]

Re: [VOTE] FLIP-391: Deprecate RuntimeContext#getExecutionConfig

2023-11-27 Thread Rui Fan
+1(binding) Best, Rui On Tue, Nov 28, 2023 at 12:34 PM Junrui Lee wrote: > Hi everyone, > > Thank you to everyone for the feedback on FLIP-391: Deprecate > RuntimeContext#getExecutionConfig[1] which has been discussed in this > thread [2]. > > I would like to start a vote for it. The vote will

[RESULT] [VOTE] Release 1.16.3, release candidate #1

2023-11-26 Thread Rui Fan
I'm happy to announce that we have unanimously approved this release. There are 11 approving votes, 3 of which are binding: - Yun Tang - Rui Fan - Matthias Pohl (binding) - Leonard Xu(binding) - Sergey Nuyanzin - Jiabao Sun - Hang Ruan - Feng Jin - Jing Ge - Martijn Visser (binding) - Lincoln

Re: [VOTE] Release 1.16.3, release candidate #1

2023-11-26 Thread Rui Fan
from t1; > +++ > | EXPR$0 | k | > +++ > | false | 7facac057b5bcb0966285ffe132... | > | false | ce142d9f2e2543f386ab880c4ae... | > +++ > 2 rows

Re: [VOTE] Release 1.16.3, release candidate #1

2023-11-26 Thread Rui Fan
gt; > > > > > >> > > > > > > >> - verified signatures > > > > > > >> - verified hashsums > > > > > > >> - checked that all POM files point to the same version 1.16.3 > > > > > > >> - s

[jira] [Created] (FLINK-33650) Checkpoint Storage doc is missed

2023-11-25 Thread Rui Fan (Jira)
Rui Fan created FLINK-33650: --- Summary: Checkpoint Storage doc is missed Key: FLINK-33650 URL: https://issues.apache.org/jira/browse/FLINK-33650 Project: Flink Issue Type: Technical Debt

[jira] [Created] (FLINK-33649) Exponential Delay doc is missed

2023-11-24 Thread Rui Fan (Jira)
Rui Fan created FLINK-33649: --- Summary: Exponential Delay doc is missed Key: FLINK-33649 URL: https://issues.apache.org/jira/browse/FLINK-33649 Project: Flink Issue Type: Technical Debt

Re: [VOTE] Release flink-connector-gcp-pubsub v3.0.2, release candidate #2

2023-11-24 Thread Rui Fan
+1 (non-binding) - Validated checksum hash - Verified signature - Verified that no binaries exist in the source archive - Build the source with Maven and jdk8 - Verified licenses - Verified web PRs, left a minor comment Best, Rui On Fri, Nov 24, 2023 at 10:26 PM Martijn Visser wrote: > +1

Re: [VOTE] Apache Flink Kafka Connectors v3.0.2, RC #1

2023-11-24 Thread Rui Fan
+1 (non-binding) - Validated checksum hash - Verified signature - Verified that no binaries exist in the source archive - Build the source with Maven and jdk8 - Verified licenses - Verified web PRs Best, Rui On Sat, Nov 25, 2023 at 2:05 AM Tzu-Li (Gordon) Tai wrote: > +1 (binding) > > -

[jira] [Created] (FLINK-33636) Implement JdbcAutoScalerEventHandler

2023-11-23 Thread Rui Fan (Jira)
Rui Fan created FLINK-33636: --- Summary: Implement JdbcAutoScalerEventHandler Key: FLINK-33636 URL: https://issues.apache.org/jira/browse/FLINK-33636 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-33625) FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-23 Thread Rui Fan (Jira)
Rui Fan created FLINK-33625: --- Summary: FLIP-390: Support System out and err to be redirected to LOG or discarded Key: FLINK-33625 URL: https://issues.apache.org/jira/browse/FLINK-33625 Project: Flink

[RESULT][VOTE] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-22 Thread Rui Fan
Dear developers, FLIP-390 [1] has been accepted and voted through this thread [2]. The proposal received 6 approving votes, 5 of which are binding, and there is no disapproval. Hangxiang Yu (binding) Piotr Nowojski (binding) Roman Khachatryan (binding) Leonard Xu (binding) Feng Jin Rui Fan

Re: [VOTE] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-22 Thread Rui Fan
> > On Wed, Nov 22, 2023, 10:08 AM Piotr Nowojski < > piotr.nowoj...@gmail.com> > > > wrote: > > > > > >> Thanks Rui! > > >> > > >> +1 (binding) > > >> > > >> Best, > > >> Piotrek > > >> &g

Re: [VOTE] FLIP-386: Support adding custom metrics in Recovery Spans

2023-11-22 Thread Rui Fan
+1(binding) Thanks for driving this proposal! Best, Rui On Wed, Nov 22, 2023 at 7:44 PM Piotr Nowojski wrote: > Hi All, > > I'd like to start a vote on the FLIP-386: Support adding custom metrics in > Recovery Spans [1]. The discussion thread is here [2]. > > The vote will be open for at

Re: [VOTE] FLIP-384: Introduce TraceReporter and use it to create checkpointing and recovery traces

2023-11-21 Thread Rui Fan
+1(binding) Best, Rui On Wed, Nov 22, 2023 at 6:43 AM Jing Ge wrote: > +1(binding) Thanks! > > Best regards, > Jing > > On Tue, Nov 21, 2023 at 6:17 PM Piotr Nowojski > wrote: > > > Hi All, > > > > I'd like to start a vote on the FLIP-384: Introduce TraceReporter and use > > it to create

Re: [VOTE] FLIP-385: Add OpenTelemetryTraceReporter and OpenTelemetryMetricReporter

2023-11-21 Thread Rui Fan
+1(binding) Best, Rui On Wed, Nov 22, 2023 at 1:20 AM Piotr Nowojski wrote: > Hi All, > > I'd like to start a vote on the FLIP-385: Add OpenTelemetryTraceReporter > and OpenTelemetryMetricReporter [1]. The discussion thread is here [2]. > > The vote will be open for at least 72 hours unless

Re: [VOTE] Release 1.16.3, release candidate #1

2023-11-20 Thread Rui Fan
rom source code, and it looks good > * Verified that jar packages are built with maven-3.2.5 and JDK8 > * Reviewed the flink-web PR > * Start a local standalone cluster and submit examples > > Best > Yun Tang > ________ > From: Rui Fan <1996fan

Re: [DISCUSS] Change the default restart-strategy to exponential-delay

2023-11-19 Thread Rui Fan
se to me. Given that the new >> default feels more complex than the current behavior, if we decide to do >> this I think it will be important to include the rationale you've shared in >> the documentation. >> >> David >> >> On Wed, Nov 15, 2023 at 10:17 P

[VOTE] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-19 Thread Rui Fan
Hi everyone, Thank you to everyone for the feedback on FLIP-390: Support System out and err to be redirected to LOG or discarded[1] which has been discussed in this thread [2]. I would like to start a vote for it. The vote will be open for at least 72 hours unless there is an objection or not

Re: [DISCUSS] FLIP-394: Add Metrics for Connector Agnostic Autoscaling

2023-11-17 Thread Rui Fan
gt; > >> For Kafka, we always read from all splits but I like how for the > >> generic interface we take note of both assigned and unassigned splits. > >> This allows for more flexible integration with other sources where we > >> might have additional splits we read

Re: [VOTE] Apache Flink Kubernetes Operator Release 1.7.0, release candidate #1

2023-11-17 Thread Rui Fan
+1(non-binding) - Downloaded artifacts from dist - Verified SHA512 checksums - Verified GPG signatures - Build the source with java-11 and java-17 - Verified the license header - Verified that chart and appVersion matches the target release - RC repo works as Helm rep(helm repo add

Re: [DISCUSS] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-16 Thread Rui Fan
Hi all, Unless there are some objections or new suggestions, I will open a voting thread next Monday, thanks~ Best, Rui On Wed, Nov 15, 2023 at 4:11 PM Rui Fan <1996fan...@gmail.com> wrote: > Thanks to Hangxiang and Feng's feedback! > > Best, > Rui > > On Wed, Nov 15,

Re: [DISCUSS] FLIP-394: Add Metrics for Connector Agnostic Autoscaling

2023-11-16 Thread Rui Fan
Hi Mason, Thank you for driving this proposal! Currently, Autoscaler only supports the maximum source parallelism of KafkaSource. Introducing the generic metric to support it is good to me, +1 for this proposal. I have a question: You added the metric in the flink repo, and Autoscaler will

Re: [DISCUSS] FLIP-364: Improve the restart-strategy

2023-11-16 Thread Rui Fan
[1] https://issues.apache.org/jira/browse/FLINK-33565 Best, Rui On Thu, Nov 16, 2023 at 11:48 AM Rui Fan <1996fan...@gmail.com> wrote: > Hi Zhu and Matthias: > > > 3. failure counting > > Flink currently will try to recognize concurrent failures and group them > > to

Re: [DISCUSS] Release 1.17.2

2023-11-16 Thread Rui Fan
tly I am not aware > of any unresolved blockers. > > I will kick off the release process and start preparing for the RC1 > version from today. > > > Best > Yun Tang > > From: Leonard Xu > Sent: Wednesday, November 8, 2023 11:10

Re: [DISCUSS] Release Flink 1.16.3

2023-11-16 Thread Rui Fan
They are included. Best, Rui On Thu, Nov 16, 2023 at 4:12 PM Jun Qin wrote: > Thanks Rui Fan for driving the release. > > Just wanted to double check whether the following two fixes will be > included in 1.16.3 release: > > https://issues.apache.org/jira/browse/F

Re: [DISCUSS] FLIP-391: Deprecate RuntimeContext#getExecutionConfig

2023-11-15 Thread Rui Fan
licEvolving > Map getGlobalJobParameters()" in this FLIP. And this method > will provide users with global job parameters. > I would appreciate it if you could share your thoughts on whether this > addition adequately resolves your concerns. > > Best, > Junrui > > Rui

Re: [VOTE] Release 1.17.2, release candidate #1

2023-11-15 Thread Rui Fan
+1 (non-binding) - Verified signatures - Reviewed the flink-web PR, left a couple of comments - The source archives do not contain any binaries - Build the source with Maven 3 and java8 (Checked the license as well) - bin/start-cluster.sh with java8, it works fine and no any unexpected LOG - Ran

Re: [DISCUSS] FLIP-391: Deprecate RuntimeContext#getExecutionConfig

2023-11-15 Thread Rui Fan
Thanks Junrui for driving this proposal! Overall looks good to me! I have a question: How do the flink users to getGlobalJobParameters if RuntimeContext#getExecutionConfig is removed? Is there any alternative api? Or is this feature removed? Maybe this is a noob question and I may have missed

Re: [DISCUSS] FLIP-364: Improve the restart-strategy

2023-11-15 Thread Rui Fan
ug. WDYT? Thanks Zhu mentioned the concurrentExceptions, and thanks Matthias help double check. [1] https://issues.apache.org/jira/browse/FLINK-33565 Best, Rui On Thu, Nov 16, 2023 at 11:39 AM Rui Fan <1996fan...@gmail.com> wrote: > Hi Zhu, Jing and Mingliang: > > Thanks for your

Re: [DISCUSS] FLIP-364: Improve the restart-strategy

2023-11-15 Thread Rui Fan
ed-delay.attempts`). The > wording `before-reset-backoff ` makes me think it's setting the backoff > interval to its initial value after this max attempt, instead of failing > the job. > > On Tue, Nov 14, 2023 at 8:16 PM Rui Fan <1996fan...@gmail.com> wrote: > >>

[DISCUSS] Change the default restart-strategy to exponential-delay

2023-11-15 Thread Rui Fan
Hi dear flink users and devs: FLIP-364[1] intends to make some improvements to restart-strategy and discuss updating some of the default values of exponential-delay, and whether exponential-delay can be used as the default restart-strategy. After discussing at dev mail list[2], we hope to collect

[jira] [Created] (FLINK-33565) The concurrentExceptions doesn't work

2023-11-15 Thread Rui Fan (Jira)
Rui Fan created FLINK-33565: --- Summary: The concurrentExceptions doesn't work Key: FLINK-33565 URL: https://issues.apache.org/jira/browse/FLINK-33565 Project: Flink Issue Type: Bug

Re: [DISCUSS] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-15 Thread Rui Fan
enarios in the future, we can consider adding > additional parameters to redirect stdout to a separate file. > > > Best, > Feng > > On Wed, Nov 15, 2023 at 2:23 PM Hangxiang Yu wrote: > > > Hi, Rui. > > Overall LGTM now. > > Thanks for driving this

Re: [DISCUSS] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-14 Thread Rui Fan
LOG.info("taskName {} : {}", taskName, > > userLogContext)? > > > > Yes, That's what I mean. > > On Sat, Nov 11, 2023 at 12:54 AM Piotr Nowojski > wrote: > > > Thanks! :) > > > > Best, Piotrek > > > > czw., 9 lis 2023 o 16:15 Rui Fan

Re: [DISCUSS] FLIP-364: Improve the restart-strategy

2023-11-14 Thread Rui Fan
all out that making exponential-delay > the default is a good change. At Netflix, we have enabled this as the > default restart strategy 2 quarters ago and it has been working well. > Keeping it restarting indefinitely by default makes sense to me. > > On Mon, Oct 16, 2023 at 10:11 P

Re: [DISCUSS] FLIP-364: Improve the restart-strategy

2023-11-14 Thread Rui Fan
failure counting with the concurrent failures computing? This can make it > > more consistent and easier for understanding. It will require changes to > > the concurrent failures computing though, i.e. taking the backoff time > > into consideration. So maybe we can open a seperate FLIP

[VOTE] Release 1.16.3, release candidate #1

2023-11-13 Thread Rui Fan
Hi everyone, Please review and vote on the release candidate #1 for the version 1.16.3, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes

[VOTE] FLIP-364: Improve the restart-strategy

2023-11-12 Thread Rui Fan
Hi everyone, Thank you to everyone for the feedback on FLIP-364: Improve the restart-strategy[1] which has been discussed in this thread [2]. I would like to start a vote for it. The vote will be open for at least 72 hours unless there is an objection or not enough votes. [1]

[jira] [Created] (FLINK-33527) Clear all pysical states after autoscaler is disabled

2023-11-12 Thread Rui Fan (Jira)
Rui Fan created FLINK-33527: --- Summary: Clear all pysical states after autoscaler is disabled Key: FLINK-33527 URL: https://issues.apache.org/jira/browse/FLINK-33527 Project: Flink Issue Type

Re: [DISCUSS] FLIP-364: Improve the restart-strategy

2023-11-10 Thread Rui Fan
I'll start voting next Monday if there isn't any other comment. Best, Rui On Thu, Oct 19, 2023 at 6:59 PM Rui Fan <1996fan...@gmail.com> wrote: > Hi Konstantin and Max, > > Thanks for your feedback! > > Sorry, I forgot to mention the default value of > `restart-strate

Re: [VOTE] FLIP-381: Deprecate configuration getters/setters that return/set complex Java objects

2023-11-10 Thread Rui Fan
+1(binding) Best, Rui On Fri, Nov 10, 2023 at 11:58 AM Junrui Lee wrote: > Hi everyone, > > Thank you to everyone for the feedback on FLIP-381: Deprecate configuration > getters/setters that return/set complex Java objects[1] which has been > discussed in this thread [2]. > > I would like to

Re: [DISCUSS] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-09 Thread Rui Fan
ByteBuffer.wrap(array, ..., ...).equals(ByteBuffer.wrap(array2, ..., ...)) > > This shouldn't have overheads as far as I remember. > > Or implement your own loop? It shouldn't be more than a couple of lines. > > Best, > Piotrek > > czw., 9 lis 2023 o 06:43 Rui Fan <1996fan

Re: [DISCUSS] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-08 Thread Rui Fan
> Hi Rui, > > > > > > Thanks for the proposal. > > > > > > +1 I don't have any major comments :) > > > > > > One nit. In `SystemOutRedirectToLog` in this code: > > > > > > System.arraycopy(buf,

Re: [DISCUSS] FLIP-384: Introduce TraceReporter and use it to create checkpointing and recovery traces

2023-11-08 Thread Rui Fan
> > > > > This is done just for the sake of simplicity, and test out the > basic > > > > > functionality. But I think, > > > > > those currently missing features should be added at some point in > > > > > the future. > > > > >

Re: [DISCUSS] Release Flink 1.16.3

2023-11-08 Thread Rui Fan
Hi All, Thank you for your feedback! As there are no other concerns or objections, and currently I am not aware of any unresolved blockers. I will kick off the release process and start preparing for the RC1 version from today. Best, Rui On Wed, Nov 8, 2023 at 4:23 PM ConradJam wrote: > +1

[DISCUSS] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-08 Thread Rui Fan
Hi all! I would like to start a discussion of FLIP-390: Support System out and err to be redirected to LOG or discarded[1]. In various production environments, either cloud native or physical machines, the disk space that Flink TaskManager can use is limited. In general, the flink users

Re: [DISCUSS] FLIP-384: Introduce TraceReporter and use it to create checkpointing and recovery traces

2023-11-07 Thread Rui Fan
Hi Piotr, Thanks for driving this proposal! The trace reporter is useful to check a lot of duration monitors inside of Flink. I have some questions about this proposal: 1. I see the trace just supports Span? Does it support trace events? I'm not sure whether tracing events is reasonable for

[DISCUSS] Release Flink 1.16.3

2023-11-05 Thread Rui Fan
Hi all, I would like to discuss creating a new 1.16 patch release (1.16.3). The last 1.16 release is over five months old, and since then, 50 tickets have been closed [1], of which 10 are blocker/critical [2]. Some of them are quite important, such as FLINK-32296 [3], FLINK-32548 [4] and

Re: Request to release flink 1.6.3

2023-11-04 Thread Rui Fan
] https://lists.apache.org/thread/szq23kr3rlkm80rw7k9n95js5vqpsnbv > > > On Fri, Nov 3, 2023 at 7:38 PM Rui Fan <1996fan...@gmail.com> wrote: > > > Thanks Yun and Yu, > > > > That would be great! Let's move forward! > > > > Best, > > Rui > > &g

Re: Request to release flink 1.6.3

2023-11-03 Thread Rui Fan
e forward and make it. > > Best > Yun Tang > ____________ > From: Rui Fan <1996fan...@gmail.com> > Sent: Tuesday, October 31, 2023 23:06 > To: dev@flink.apache.org > Subject: Re: Request to release flink 1.6.3 > > Thanks Vikas for the ask! > > Hi

[jira] [Created] (FLINK-33452) A series of improvements of Autoscaler Standalone

2023-11-03 Thread Rui Fan (Jira)
Rui Fan created FLINK-33452: --- Summary: A series of improvements of Autoscaler Standalone Key: FLINK-33452 URL: https://issues.apache.org/jira/browse/FLINK-33452 Project: Flink Issue Type

[jira] [Created] (FLINK-33450) Implement JdbcAutoScalerStateStore

2023-11-03 Thread Rui Fan (Jira)
Rui Fan created FLINK-33450: --- Summary: Implement JdbcAutoScalerStateStore Key: FLINK-33450 URL: https://issues.apache.org/jira/browse/FLINK-33450 Project: Flink Issue Type: Sub-task

Re: [DISCUSS] FLIP-381: Deprecate configuration getters/setters that return/set complex Java objects

2023-11-01 Thread Rui Fan
Thanks Junrui for driving this proposal! ConfigOption is easy to use for flink users, easy to manage options for flink platform maintainers, and easy to maintain for flink developers and flink community. So big +1 for this proposal! Best, Rui On Thu, Nov 2, 2023 at 10:10 AM Junrui Lee wrote:

Re: Request to release flink 1.6.3

2023-10-31 Thread Rui Fan
helping it? Thanks~ Best, Rui On Tue, 31 Oct 2023 at 21:42, vikas patil wrote: > Hello Rui, > > Do we need more votes for this or are we good to go with the release of > 1.6.3 ? Please let me know. Thanks. > > -Vikas > > On Tue, Oct 24, 2023 at 9:27 AM Rui Fan <

Re: [DISCUSS] Kubernetes Operator 1.7.0 release planning

2023-10-31 Thread Rui Fan
Thanks Gyula for driving this release! I'd like to check with you and community, could we postpone the code freeze by a week? I'm developing the FLINK-33099[1], and the prod code is done. I need some time to develop the tests. I hope this feature is included in 1.7.0 for two main reasons: 1. We

[jira] [Created] (FLINK-33403) Bump flink version to 1.18.0 for flink-kubernetes-operator

2023-10-30 Thread Rui Fan (Jira)
Rui Fan created FLINK-33403: --- Summary: Bump flink version to 1.18.0 for flink-kubernetes-operator Key: FLINK-33403 URL: https://issues.apache.org/jira/browse/FLINK-33403 Project: Flink Issue Type

[ANNOUNCE] Apache Flink Kubernetes Operator 1.6.1 released

2023-10-30 Thread Rui Fan
://hub.docker.com/r/apache/flink-kubernetes-operator The full release notes are available in Jira: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353784 We would like to thank all contributors of the Apache Flink community who made this release possible! Regards, Rui Fan

Re: [ANNOUNCE] Apache Flink 1.18.0 released

2023-10-26 Thread Rui Fan
Thanks for the great work! Best, Rui On Fri, Oct 27, 2023 at 10:03 AM Paul Lam wrote: > Finally! Thanks to all! > > Best, > Paul Lam > > > 2023年10月27日 03:58,Alexander Fedulov 写道: > > > > Great work, thanks everyone! > > > > Best, > > Alexander > > > > On Thu, 26 Oct 2023 at 21:15, Martijn

[RESULT] [VOTE] Apache Flink Kubernetes Operator Release 1.6.1, release candidate #1

2023-10-26 Thread Rui Fan
I'm happy to announce that we have unanimously approved this release. There are 7 approving votes, 4 of which are binding: * Gyula Fora (binding) * Thomas Weise (binding) * Marton Balassi (binding) * Maximilian Mixhels (binding) * Mate Czagany (non-binding) * Samrat Deb (non-binding) * Rui Fan

Re: [VOTE] Apache Flink Kubernetes Operator Release 1.6.1, release candidate #1

2023-10-26 Thread Rui Fan
nk-kubernetes-operator/139454270?tag=51eeae1 > > > And notice that it does not have a description . Is this correct? > > > > > > 1. I get this in the gpg verification . Is this ok? > > > > > > > > > gpg --verify flink-kubernetes-operator-1.6.

Re: [VOTE] Apache Flink Kubernetes Operator Release 1.6.1, release candidate #1

2023-10-25 Thread Rui Fan
ts.java:187) > > Thanks, > Thomas > > > On Sat, Oct 21, 2023 at 7:35 AM Rui Fan <1996fan...@gmail.com> wrote: > > > Hi Everyone, > > > > Please review and vote on the release candidate #1 for the version 1.6.1 > of > > Apache Flink Kuberne

[jira] [Created] (FLINK-33359) Kubernetes operator supports Java 17

2023-10-25 Thread Rui Fan (Jira)
Rui Fan created FLINK-33359: --- Summary: Kubernetes operator supports Java 17 Key: FLINK-33359 URL: https://issues.apache.org/jira/browse/FLINK-33359 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-33354) Reuse the TaskInformation for multiple slots

2023-10-24 Thread Rui Fan (Jira)
Rui Fan created FLINK-33354: --- Summary: Reuse the TaskInformation for multiple slots Key: FLINK-33354 URL: https://issues.apache.org/jira/browse/FLINK-33354 Project: Flink Issue Type: Sub-task

Re: Request to release flink 1.6.3

2023-10-24 Thread Rui Fan
Hi Vikas, Thanks for your feedback! Do you mean flink 1.16.3 instead of 1.6.3? The 1.16.2 and 1.17.1 were released on 2023-05-25, it’s been 5 months. And the flink community has fixed many bugs in the past 5 months. Usually, there is a fix(minor) version every three or four months, so I propose

Re: [VOTE] FLIP-370: Support Balanced Tasks Scheduling

2023-10-22 Thread Rui Fan
+1(binding) Thanks to Yuepeng and to everyone who participated in the discussion! Best, Rui On Mon, Oct 23, 2023 at 11:55 AM Roc Marshal wrote: > Hi all, > > Thanks for all the feedback on FLIP-370[1][2]. > I'd like to start a vote for FLIP-370. The vote will last for at least 72 > hours

Re: [VOTE] Apache Flink Kubernetes Operator Release 1.6.1, release candidate #1

2023-10-21 Thread Rui Fan
, 2023 at 7:33 PM Rui Fan <1996fan...@gmail.com> wrote: > Hi Everyone, > > Please review and vote on the release candidate #1 for the version 1.6.1 of > Apache Flink Kubernetes Operator, > as follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the relea

[VOTE] Apache Flink Kubernetes Operator Release 1.6.1, release candidate #1

2023-10-21 Thread Rui Fan
Hi Everyone, Please review and vote on the release candidate #1 for the version 1.6.1 of Apache Flink Kubernetes Operator, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) **Release Overview** As an overview, the release consists of

Re: [VOTE] Release 1.18.0, release candidate #3

2023-10-21 Thread Rui Fan
+1(non-binding) - Downloaded artifacts from dist[1] - Verified SHA512 checksums - Verified GPG signatures - Build the source with java-1.8 and verified the licenses together - Verified web PR [1] https://dist.apache.org/repos/dist/dev/flink/flink-1.18.0-rc3/ Best, Rui On Fri, Oct 20, 2023 at

Re: [DISCUSS] Creating Kubernetes Operator release 1.6.1

2023-10-20 Thread Rui Fan
cus on critical fixes / regressions to make > the changes minimal given that the 1.7.0 is not so far anyway :) > > Cheers, > Gyula > > > On Thu, Oct 19, 2023 at 8:20 AM Rui Fan <1996fan...@gmail.com> wrote: > > > Hi Gyula, > > > > Thank you for driving

<    1   2   3   4   5   6   >