Re: filtering huge request bodies (like 650MB files)

2003-12-11 Thread William A. Rowe, Jr.
I've been thinking the same thing driving around this evening... One major goal of httpd-3.0 is *finally* arriving at something that starts looking async. We've kicked it around some time, but perhaps it's time to start looking at the async poll implementation, to get some idea of how we can 'pol

Re: [PATCH] Page Fault in mod_mem_cache-steaming response

2003-12-11 Thread Bill Stoddard
Jean-Jacques Clar wrote: Bugzilla Defect #21285 This is a rework of the already posted patch. It address the following situation; 1- request comes in for streaming response 2- before that request could be completed, the entry is ejected from the cache 3- when completing the write body step, the

[PATCH] mod_mem_cache - removing deprecated struct fields

2003-12-11 Thread Jean-Jacques Clar
The fields:  apr_size_t cache_size apr_size_t object_cntfrom the struct mem_cache_conf are useless since the introduction of the cache_pqueue stuff. Just removing them.   Thanks,   Jean-Jacques mod_mem_cache.patch Description: Binary data

[PATCH] Page Fault in mod_mem_cache-steaming response

2003-12-11 Thread Jean-Jacques Clar
Bugzilla Defect #21285 This is a rework of the already posted patch.   It address the following situation; 1- request comes in for streaming response 2- before that request could be completed, the entry is ejected from the cache 3- when completing the write body step, the incomplete entry is remo

Re: Thread terminatinos ?

2003-12-11 Thread Jeff White
From: "Nick Kew" > > Hello everyone. > > I have Apache 2 module running under Windows.In each Apache's > thread I have a separate ODBC connection to a database. > > Why every thread? Wouldn't it be more efficient to share a connection > pool between your threads? You might possibly want

Re: [PATCH] Create plog pool before pconf

2003-12-11 Thread Bill Stoddard
William A. Rowe, Jr. wrote: So you propose an inversion here? Won't that break as many modules making the (currently) correct assumptions, w.r.t. config data? Logs are created *from* values in the configuration, ergo they should go away *before* the values that created them are also destroyed. E.g

Re: [PATCH 25137] atomics in worker mpm

2003-12-11 Thread Joe Orton
On Thu, Dec 11, 2003 at 12:47:37PM -0800, Aaron Bannert wrote: > On Thu, Dec 11, 2003 at 08:39:27AM -0500, Brian Akins wrote: > > I wonder if this > > >binary would run on an older processor (running a modern version of linux). > > > > AFAIK, yes. It's standard x86 assembly. > > > > > > All: P

Re: [PATCH 25137] atomics in worker mpm

2003-12-11 Thread Aaron Bannert
On Thu, Dec 11, 2003 at 08:39:27AM -0500, Brian Akins wrote: > I wonder if this > >binary would run on an older processor (running a modern version of linux). > > AFAIK, yes. It's standard x86 assembly. > > > All: Please correct me if I am wrong. I'm sure you will ;) I'm no x86 asm expert, s

Re: filtering huge request bodies (like 650MB files)

2003-12-11 Thread Aaron Bannert
On Thu, Dec 11, 2003 at 01:50:46PM -0600, William A. Rowe, Jr. wrote: > But the 2.0 architecture is entirely different. We need a poll but it's not entirely > obvious where to put one... > > One suggestion raised in a poll bucket: when a connection level filter cannot > read anything more, it pas

Re: filtering huge request bodies (like 650MB files)

2003-12-11 Thread Glenn
[snip] (wrowe's exposition of a possible non-blocking filter chain implementation) Your poll bucket idea would be welcome for input, although it would only save a bit of work since we already have APR_NONBLOCK_READ apr_bucket_read(b, &bdata, &blen, APR_NONBLOCK_READ); For polling output, I had

Re: Thread terminatinos ?

2003-12-11 Thread Nick Kew
On Thu, 11 Dec 2003, Nasko wrote: (can you please fix your mailer to post text and use a sensible line length?) > Hello everyone. > I have Apache 2 module running under Windows.In each Apache's thread I have a separate ODBC connection to a database. Why every thread? Wouldn't it be more

[PATCH] --enable-mods-shared=max

2003-12-11 Thread Mads Toftum
This is really a minor thing, but every once in a while it pops up. In 1.3 we have: --enable-shared=max In 2.x we have: --enable-mods-shared= either most or all (no difference between the two). This trivial patch adds max with the same effect as most and all: Index: acinclude.m4 =

Re: filtering huge request bodies (like 650MB files)

2003-12-11 Thread William A. Rowe, Jr.
At 07:01 PM 12/10/2003, Bill Stoddard wrote: >Aaron Bannert wrote: >> >>[slightly off-topic] >>Actually, I believe that mod_cgi and mod_cgid are currently broken >>WRT the CGI spec. The spec says that a CGI may read as much of an >>incoming request body as it wishes and may return data as soon as >

Re: [PATCH] Create plog pool before pconf

2003-12-11 Thread William A. Rowe, Jr.
So you propose an inversion here? Won't that break as many modules making the (currently) correct assumptions, w.r.t. config data? Logs are created *from* values in the configuration, ergo they should go away *before* the values that created them are also destroyed. E.g., if my module creates a

Re: [Patch] Hook to allow insertion of filters during error processing

2003-12-11 Thread Paul J. Reder
Geoffrey Young wrote: I can see how that might work in some (even most) circumstances. but requiring filters to rewrite things like default_handler just because it makes it difficult to behave properly is asking a bit much. but default_handler and mod_autoindex are the only core things I can th

what response code filters should return when they see c->aborted?

2003-12-11 Thread Stas Bekman
If the connection is aborted filters need to know how to deal with that situation and not waste resources processing data which is going to be dumped anyway. It's easy to do by checking c->aborted every so often. The question is, what's the proper response code should the filter return if it decide

Re: [Patch] Hook to allow insertion of filters during error processing

2003-12-11 Thread Geoffrey Young
> >> the way Apache chose to work around this was to add the filter_init >> callback >> to allow filters to add processing just prior to content generation. >> presumably, this is where filters could call ap_update_mtime or >> whatnot to >> add their information in the conditional GET calculation

Re: [Patch] Hook to allow insertion of filters during error processing

2003-12-11 Thread Paul J. Reder
Geoffrey Young wrote: Jeff Trawick wrote: Geoffrey Young wrote: I've griped a bit before about having default_handler make conditional GET decisions, and this is probably another instance where having ap_meets_conditions in it's own filter could avoid inevitable problems. I'm up for laying out

Re: [Patch] Hook to allow insertion of filters during error processing

2003-12-11 Thread Rodent of Unusual Size
Geoffrey Young wrote: > > I've griped a bit before about having default_handler make conditional GET > decisions, and this is probably another instance where having > ap_meets_conditions in it's own filter could avoid inevitable problems. i see how paul's patch would reawaken thinking on the subj

Re: [PATCH 25137] atomics in worker mpm

2003-12-11 Thread Brian Akins
Aaron Bannert wrote: Does it use this atomics implementation by default? AFAIK, no. By default, (ie, without non-portable-atomics), apr_atomic uses mutexes. I wonder if this binary would run on an older processor (running a modern version of linux). AFAIK, yes. It's standard x86 assembly. Al

Thread terminatinos ?

2003-12-11 Thread Nasko
  Hello everyone.     I have Apache 2 module running under Windows.In each Apache's thread I have a separate ODBC connection to a database. I want when a thread is destoyed for some reason to close that connection too. My questions are :     1) What could be a reason for one Apache thread to

Re: filtering huge request bodies (like 650MB files)

2003-12-11 Thread Sander Striker
On Thu, 2003-12-11 at 09:54, Stas Bekman wrote: > Sander Striker wrote: > > On Thu, 2003-12-11 at 07:44, Stas Bekman wrote: > > > > > >>I now know what the problem is. It is not a problem in httpd or its filters, > >>but mod_perl, allocated filter struct from the pool. With many bucket brigades

Re: [PATCH] bug #18756 ldap cache and shared memory - cache init

2003-12-11 Thread Matthieu Estrade
Hi, st->cache_rmm is now invalid because due to non SHM plateform, bnicholes changed the alloc function util_ald_alloc to receive now util_ald_cache_t and no more apr_rmm_t. As we are just before the cache alloc, it's impossible to give util_ald_alloc a cache object, that's why there, i did a b

Re: filtering huge request bodies (like 650MB files)

2003-12-11 Thread Stas Bekman
Sander Striker wrote: On Thu, 2003-12-11 at 07:44, Stas Bekman wrote: I now know what the problem is. It is not a problem in httpd or its filters, but mod_perl, allocated filter struct from the pool. With many bucket brigades there were many filter invocations during the same request, resulting

Re: filtering huge request bodies (like 650MB files)

2003-12-11 Thread Sander Striker
On Thu, 2003-12-11 at 07:44, Stas Bekman wrote: > I now know what the problem is. It is not a problem in httpd or its filters, > but mod_perl, allocated filter struct from the pool. With many bucket brigades > there were many filter invocations during the same request, resulting in > multiple m