reschke merged PR #1337:
URL: https://github.com/apache/jackrabbit-oak/pull/1337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reschke commented on PR #1336:
URL: https://github.com/apache/jackrabbit-oak/pull/1336#issuecomment-1973433681
Oh, wow.
I'm somewhat concerned by the amount of changes over on the elastic search
side. Either these need to be double-checked by the right people
(@fabriziofortino ???),
reschke opened a new pull request, #1338:
URL: https://github.com/apache/jackrabbit-oak/pull/1338
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
kwin merged PR #1311:
URL: https://github.com/apache/jackrabbit-oak/pull/1311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reschke merged PR #1335:
URL: https://github.com/apache/jackrabbit-oak/pull/1335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reschke opened a new pull request, #1337:
URL: https://github.com/apache/jackrabbit-oak/pull/1337
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
mbaedke opened a new pull request, #1336:
URL: https://github.com/apache/jackrabbit-oak/pull/1336
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
reschke opened a new pull request, #1335:
URL: https://github.com/apache/jackrabbit-oak/pull/1335
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
t-rana commented on code in PR #1329:
URL: https://github.com/apache/jackrabbit-oak/pull/1329#discussion_r1508497917
##
oak-upgrade/src/test/java/org/apache/jackrabbit/oak/upgrade/cli/container/SegmentAzureServicePrincipalNodeStoreContainer.java:
##
@@ -0,0 +1,100 @@
+package
nfsantos merged PR #1331:
URL: https://github.com/apache/jackrabbit-oak/pull/1331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reschke merged PR #1334:
URL: https://github.com/apache/jackrabbit-oak/pull/1334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reschke opened a new pull request, #1334:
URL: https://github.com/apache/jackrabbit-oak/pull/1334
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
smiroslav commented on PR #1329:
URL: https://github.com/apache/jackrabbit-oak/pull/1329#issuecomment-1970690588
@t-rana for new files please add license headers
```
[INFO] BUILD FAILURE
[INFO]
steffenvan commented on PR #1331:
URL: https://github.com/apache/jackrabbit-oak/pull/1331#issuecomment-1969463801
Don't have anything to add LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mbaedke merged PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reschke merged PR #1333:
URL: https://github.com/apache/jackrabbit-oak/pull/1333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reschke opened a new pull request, #1333:
URL: https://github.com/apache/jackrabbit-oak/pull/1333
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
reschke commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506112813
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java:
##
@@ -354,6 +358,39 @@ private void
reschke commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506104757
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreService.java:
##
@@ -181,6 +181,8 @@ public class
reschke commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506101202
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java:
##
@@ -869,6 +872,11 @@ public int getMemory() {
mbaedke commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506099419
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java:
##
@@ -571,6 +571,8 @@ public Long apply(@Nullable String
stefan-egli commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506097290
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java:
##
@@ -354,6 +358,39 @@ private void
stefan-egli commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506094311
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java:
##
@@ -869,6 +872,11 @@ public int getMemory() {
rishabhdaim commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506077322
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java:
##
@@ -571,6 +571,8 @@ public Long apply(@Nullable
stefan-egli commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506066452
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java:
##
@@ -869,6 +872,11 @@ public int getMemory() {
stefan-egli commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506066095
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java:
##
@@ -354,6 +358,39 @@ private void
rishabhdaim commented on PR #1332:
URL: https://github.com/apache/jackrabbit-oak/pull/1332#issuecomment-1969118364
thanks for review @stefan-egli
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
rishabhdaim merged PR #1332:
URL: https://github.com/apache/jackrabbit-oak/pull/1332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mbaedke commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506060798
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java:
##
@@ -127,6 +127,7 @@ public class
mbaedke commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506059960
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java:
##
@@ -571,6 +571,8 @@ public Long apply(@Nullable String
rishabhdaim commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506058504
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreService.java:
##
@@ -181,6 +181,8 @@ public class
rishabhdaim commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506057283
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java:
##
@@ -127,6 +127,7 @@ public class
rishabhdaim commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506056762
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java:
##
@@ -869,6 +872,11 @@ public int getMemory() {
rishabhdaim commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506050953
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java:
##
@@ -571,6 +571,8 @@ public Long apply(@Nullable
rishabhdaim commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506046428
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java:
##
@@ -354,6 +358,39 @@ private void
reschke commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506016539
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java:
##
@@ -869,6 +872,11 @@ public int getMemory() {
Joscorbe commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506008713
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java:
##
@@ -354,6 +358,39 @@ private void
reschke commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506010020
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java:
##
@@ -354,6 +358,39 @@ private void
stefan-egli commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1505997636
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java:
##
@@ -354,6 +358,39 @@ private void
smiroslav commented on code in PR #1329:
URL: https://github.com/apache/jackrabbit-oak/pull/1329#discussion_r1505962367
##
oak-upgrade/src/test/java/org/apache/jackrabbit/oak/upgrade/cli/container/SegmentAzureServicePrincipalNodeStoreContainer.java:
##
@@ -0,0 +1,100 @@
Joscorbe commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1505968214
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java:
##
@@ -354,7 +360,27 @@ private void
rishabhdaim opened a new pull request, #1332:
URL: https://github.com/apache/jackrabbit-oak/pull/1332
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
nfsantos commented on code in PR #1331:
URL: https://github.com/apache/jackrabbit-oak/pull/1331#discussion_r1505604811
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/PipelinedMongoDownloadTask.java:
##
@@ -184,65 +181,70 @@
nfsantos commented on code in PR #1331:
URL: https://github.com/apache/jackrabbit-oak/pull/1331#discussion_r1505604037
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/PipelinedMongoDownloadTask.java:
##
@@ -184,65 +181,70 @@
reschke commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1505586923
##
oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/ManyChildrenIT.java:
##
@@ -82,7 +80,7 @@ public void addRemoveNodes() throws Exception {
}
fabriziofortino commented on code in PR #1331:
URL: https://github.com/apache/jackrabbit-oak/pull/1331#discussion_r150551
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/PipelinedMongoDownloadTask.java:
##
@@ -184,65
Joscorbe commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504557325
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentRevisionCleaner.java:
##
@@ -0,0 +1,270 @@
+/*
+ * Licensed to the
Joscorbe commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504533722
##
oak-run/src/main/groovy/org/apache/jackrabbit/oak/console/GroovyConsole.groovy:
##
@@ -124,6 +124,7 @@ class GroovyConsole {
new
stefan-egli commented on PR #1315:
URL: https://github.com/apache/jackrabbit-oak/pull/1315#issuecomment-1966884398
ah, you right away merged it, ok :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rishabhdaim merged PR #1315:
URL: https://github.com/apache/jackrabbit-oak/pull/1315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
fabriziofortino merged PR #1327:
URL: https://github.com/apache/jackrabbit-oak/pull/1327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
stefan-egli commented on PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#issuecomment-1966670655
It's generally speaking a bit difficult to review as the code doesn't
compile at this point (therefore eg you can't debug through it, to understand
it better). As I understand
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504318420
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentRevisionCleaner.java:
##
@@ -0,0 +1,270 @@
+/*
+ * Licensed to
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504315202
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentRevisionCleaner.java:
##
@@ -0,0 +1,270 @@
+/*
+ * Licensed to
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504314717
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentRevisionCleaner.java:
##
@@ -0,0 +1,270 @@
+/*
+ * Licensed to
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504309300
##
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentRevisionCleanerTest.java:
##
@@ -0,0 +1,549 @@
+package
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504304416
##
oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java:
##
@@ -460,6 +494,97 @@ private void sweep(RevisionsOptions options, Closer
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504293588
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentRevisionCleaner.java:
##
@@ -0,0 +1,270 @@
+/*
+ * Licensed to
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504290603
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##
@@ -1053,6 +1053,28 @@ private void
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504288687
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentRevisionCleaner.java:
##
@@ -0,0 +1,270 @@
+/*
+ * Licensed to
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504283327
##
oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java:
##
@@ -82,6 +97,7 @@ public class RevisionsCommand implements Command {
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504280658
##
oak-run/src/main/groovy/org/apache/jackrabbit/oak/console/GroovyConsole.groovy:
##
@@ -124,6 +124,7 @@ class GroovyConsole {
new
stefan-egli commented on PR #1326:
URL: https://github.com/apache/jackrabbit-oak/pull/1326#issuecomment-1966567441
thx for merging @mbaedke !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
stefan-egli commented on PR #1315:
URL: https://github.com/apache/jackrabbit-oak/pull/1315#issuecomment-1966558849
@rishabhdaim , thx for the review, applied all comments, please revisit, thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please
stefan-egli commented on code in PR #1315:
URL: https://github.com/apache/jackrabbit-oak/pull/1315#discussion_r1504238312
##
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollectorIT.java:
##
@@ -1182,6 +1201,362 @@ public void
stefan-egli commented on code in PR #1315:
URL: https://github.com/apache/jackrabbit-oak/pull/1315#discussion_r1504230368
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##
@@ -1255,28 +1305,40 @@ public void
stefan-egli commented on code in PR #1315:
URL: https://github.com/apache/jackrabbit-oak/pull/1315#discussion_r1504229448
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##
@@ -1255,28 +1305,40 @@ public void
fabriziofortino commented on code in PR #1327:
URL: https://github.com/apache/jackrabbit-oak/pull/1327#discussion_r1504204826
##
oak-search/src/main/java/org/apache/jackrabbit/oak/plugins/index/search/FulltextIndexConstants.java:
##
@@ -436,4 +437,12 @@ public static
fabriziofortino commented on code in PR #1327:
URL: https://github.com/apache/jackrabbit-oak/pull/1327#discussion_r1504202939
##
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticIndexHelper.java:
##
@@ -52,8 +53,12 @@ class
mbaedke commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1504104485
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java:
##
@@ -127,6 +127,7 @@ public class
reschke merged PR #1330:
URL: https://github.com/apache/jackrabbit-oak/pull/1330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reschke commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1504079086
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java:
##
@@ -354,7 +357,42 @@ private void
rishabhdaim commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1504075464
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java:
##
@@ -2111,6 +2115,11 @@ public T
rishabhdaim commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1504075464
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java:
##
@@ -2111,6 +2115,11 @@ public T
reschke commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1504075099
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentStore.java:
##
@@ -571,4 +571,16 @@ default List findAndUpdate(final
rishabhdaim commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1504073020
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentStore.java:
##
@@ -571,4 +571,16 @@ default List findAndUpdate(final
rishabhdaim commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1504068496
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java:
##
@@ -354,7 +357,42 @@ private void
rishabhdaim commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1504048284
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java:
##
@@ -318,6 +319,16 @@ public Feature
reschke opened a new pull request, #1330:
URL: https://github.com/apache/jackrabbit-oak/pull/1330
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
mbaedke merged PR #1326:
URL: https://github.com/apache/jackrabbit-oak/pull/1326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
t-rana opened a new pull request, #1329:
URL: https://github.com/apache/jackrabbit-oak/pull/1329
Azure Service Principal Support in oak-segment-azure. Goal is to allow Azure
authentication via:
clientId - Id of the Service Principal object / App registered with the
Active Directory.
rishabhdaim commented on code in PR #1315:
URL: https://github.com/apache/jackrabbit-oak/pull/1315#discussion_r1503852893
##
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollectorIT.java:
##
@@ -1182,6 +1201,362 @@ public void
rishabhdaim commented on code in PR #1315:
URL: https://github.com/apache/jackrabbit-oak/pull/1315#discussion_r1503852893
##
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollectorIT.java:
##
@@ -1182,6 +1201,362 @@ public void
rishabhdaim commented on code in PR #1315:
URL: https://github.com/apache/jackrabbit-oak/pull/1315#discussion_r1503845105
##
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollectorIT.java:
##
@@ -1182,6 +1201,362 @@ public void
nfsantos commented on code in PR #1327:
URL: https://github.com/apache/jackrabbit-oak/pull/1327#discussion_r1503753351
##
oak-search/src/main/java/org/apache/jackrabbit/oak/plugins/index/search/FulltextIndexConstants.java:
##
@@ -436,4 +437,12 @@ public static IndexingMode
steffenvan commented on code in PR #1327:
URL: https://github.com/apache/jackrabbit-oak/pull/1327#discussion_r1503743424
##
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticIndexHelper.java:
##
@@ -52,8 +53,12 @@ class
Joscorbe opened a new pull request, #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328
Introduce a way to safely detect and delete old revisions in a document.
This could be useful to cleanup documents that sometimes grows above the
supported size in MongoDB (16MB).
This
stefan-egli commented on code in PR #1315:
URL: https://github.com/apache/jackrabbit-oak/pull/1315#discussion_r1503044724
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##
@@ -1255,28 +1305,40 @@ public void
stefan-egli commented on code in PR #1315:
URL: https://github.com/apache/jackrabbit-oak/pull/1315#discussion_r1503043793
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##
@@ -1255,28 +1305,40 @@ public void
stefan-egli commented on code in PR #1315:
URL: https://github.com/apache/jackrabbit-oak/pull/1315#discussion_r1503042672
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##
@@ -942,21 +949,63 @@ public void
rishabhdaim commented on code in PR #1315:
URL: https://github.com/apache/jackrabbit-oak/pull/1315#discussion_r1502951816
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##
@@ -942,21 +949,63 @@ public void
fabriziofortino opened a new pull request, #1327:
URL: https://github.com/apache/jackrabbit-oak/pull/1327
Some indexes, like elasticsearch have a concept of an internal version (or
mapping version) to handle breaking changes. This information is sometimes
needed from external tools that do
mbaedke commented on PR #1326:
URL: https://github.com/apache/jackrabbit-oak/pull/1326#issuecomment-1964345672
I removed Julian's initial changes. Tests behave as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
stefan-egli commented on PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#issuecomment-1964277787
@reschke , @mbaedke , did a draft of an alternative that doesnt need the new
wiring : check https://github.com/apache/jackrabbit-oak/pull/1326
--
This is an automated
stefan-egli opened a new pull request, #1326:
URL: https://github.com/apache/jackrabbit-oak/pull/1326
…without additional wiring
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
stefan-egli commented on PR #1315:
URL: https://github.com/apache/jackrabbit-oak/pull/1315#issuecomment-1964120375
PS: now the flaky test succeeded but the build failed with the known
```
The plugin [java] does not support Java 11.0.22
```
I'd suggest to ignore this failure
stefan-egli commented on PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#issuecomment-1963832706
Also
[commented](https://issues.apache.org/jira/browse/OAK-10660?focusedCommentId=17820636=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17820636)
rishabhdaim commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1502313352
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java:
##
@@ -354,7 +360,27 @@ private void
fabriziofortino merged PR #1316:
URL: https://github.com/apache/jackrabbit-oak/pull/1316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reschke merged PR #1325:
URL: https://github.com/apache/jackrabbit-oak/pull/1325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
1101 - 1200 of 3904 matches
Mail list logo
