Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/356
Sorry, don't have enough time to complete this, so I will close it for now.
Thanks for merging some of the changes and I'll try to submit smaller ones
in future :smile:
---
Github user ham1 closed the pull request at:
https://github.com/apache/jmeter/pull/356
---
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/365
Thanks for committing!
---
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/375
Update checkstyle to 8.8.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter update_checkstyle
Alternatively you can review and apply
Github user ham1 commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/374#discussion_r165516098
--- Diff: xdocs/stylesheets/website-style.xsl ---
@@ -143,6 +144,13 @@
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/372
Remove unused variable assignment.
I've manually tested a save fragment which works and I can't see any
obvious side effects in `GuiPackage.getInstance().getCurrentSubTree()`.
You can merge
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/370
ConstantPoissonProcessGenerator sonar fix
Fix sonar 'bug'. It also makes it more obvious we are changing the `i`
declared outside the `do while` instead of redeclaring another `i` for the
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/231
Is there a better name which makes the difference between the Constant
Throughput Timer clearer, or should that be deprecated or just replaced with
this?
---
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/368
Csv sample reader fix
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter CsvSampleReader_fix
Alternatively you can review and apply
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/367
Improved SampleMetadataParserSpec
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter
SampleMetadataParserSpec_improvements
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/356
I've split up the PR into multiple commits, hopefully these are easier to
merge; please let me know if not.
---
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/366
Set max line length to 160 (eventual target 120).
## Description
Added new checkstyle rule for max line length of 160; with the view to,
eventually, make it around 120. I will create another PR
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/365
Expanded Checkstyle to files in src and test; fixed newly checked files
## Description
Added `test` to the files being checked.
## Motivation and Context
Felix and Philippe found some
Github user ham1 commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/364#discussion_r158429468
--- Diff: src/core/org/apache/jmeter/gui/util/MenuInfo.java ---
@@ -74,4 +75,16 @@ public String getClassName(){
public int getSortOrder
Github user ham1 commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/364#discussion_r158423992
--- Diff: src/core/org/apache/jmeter/gui/JMeterGUIComponent.java ---
@@ -220,4 +220,12 @@
* @see org.apache.jmeter.gui.util.MenuFactory
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/363
Re-added missing menu items
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter fix_menu_regression
Alternatively you can review and
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/362
Fix sonar issue in PR #355
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter boundary_extractor_refactor
Alternatively you can review
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/358
Sorry, yeah I see how this is difficult to review. I tend to change things
as I see them in the file I'm editing. I will revise and split it up into one
type of change per commit, is that ok? It
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/355
Rebased :)
---
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/360
Reordered menus. With some drive-by tidying up.
## Description
Added ability for MenuFactory to add separators to menus.
Some TestBeanGUI refactoring for reformatting.
New Spock test
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/359
Added finals to fields where possible
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter final
Alternatively you can review and apply
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/358
Checkstyle: LineLength max 165, AnonInnerLength 45 and other whitespace
checks
Also removed some unnecessary `StringBuilder`s
## How Has This Been Tested?
`ant checkstyle test`
You can
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/357
Refactoring/formatting in preparation for alternate menu sorting
## Description
Refactoring/formatting in preparation for alternate menu sorting
## How Has This Been Tested?
Looking
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/356
Sonar fixes
## Description
* Removed `clone()` methods which just called `super.clone()`
* Reduced size/complexity of methods by breaking them into smaller ones
and/or reducing nesting
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/355
BoundaryExtractor refactor
## Description
* Refactored `BoundaryExtractor`
* Ported tests to Spock
* Added more tests
* Other code tidyup while in the vicinity
## Motivation
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/354
Corrected spelling and spacing and some wording in messages
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter messages
Alternatively
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/353
Re-wrote some existing tests in Spock
## Description
Re-wrote some existing tests in Spock:
* ThroughputControllerSpec
* MD5HexAssertionSpec
* RandomOrderControllerSpec
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/350
Not sure. I can reproduce on trunk but It doesn't happen on this PR for me.
Should have time at the weekend to investigate,
---
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/351
Can't see how this changed caused a test failure...
---
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/352
Menu bar - added mnemonics to more menu items
## Description
* added mnemonics to more menu items
* general refactor/tidy of code
## Motivation and Context
To make navigation
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/351
Fixed about dialog position on first view
## Description
When viewing "About JMeter" dialog it was positioned with the top corner in
the middle rather than in the centre of the screen b
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/350
Parallelised unit tests
## Description
introduced `JMeterSerialTest` interface for tests which need to be run in
sequence not concurrently.
Re-wrote `TestFileServer` in Spock to use
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/343
Deleted the wrong branch...
---
GitHub user ham1 reopened a pull request:
https://github.com/apache/jmeter/pull/343
Reduced the size of all screenshots.
## Description
Reduced size of all png screenshots using: `pngquant -f --ext .png
--quality 70-95 *.png`.
Most were only reduced marginally but some were
Github user ham1 closed the pull request at:
https://github.com/apache/jmeter/pull/343
---
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/343
I've updated the PR:
* removed an unused screenshot
* de-duped a screenshot and
* compressed all png images with an individual saving of more than 2048
bytes using the command lin
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/348
Yes it is picked up by the GUI there, but there isn't any way to configure
it in the GUI (as confirmed by the docs) so I can't see how it's useful. The
default constructor is blank thus
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/348
Happy for someone to show me how this is used and useful and I will close
the PR and learn from it :)
---
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/348
Removed LogFilter and associated uses.
Also formatted JavaDocs in SessionFilter.
## Description
I was about to write some Spock tests for `LogFilter` but, apart from the
file not having
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/346
Bug 61827 - TextFile always adds newline to end of string
## Description
Re-wrote `getText` (and `setText` while I was there) for `TextFile` because
`getText` always appends a newline separator at
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/345
@romani, sorry I'm not clear on what, if anything, you'd want me to
do/change?
---
Github user ham1 commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/344#discussion_r153870336
--- Diff:
src/components/org/apache/jmeter/extractor/json/jsonpath/JSONPathAssertion.java
---
@@ -0,0 +1,218 @@
+/*
+ * Licensed to the Apache
Github user ham1 commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/344#discussion_r154070701
--- Diff: test/src/org/apache/jmeter/assertions/TestJSONPathAssertion.java
---
@@ -0,0 +1,383 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/345
Yes, that's correct, I some how missed it in the docs.
I've suggested on https://github.com/checkstyle/checkstyle/issues/5305 that
the error message is changed to something like:
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/345
@romani it's commented out to stop this PR failing but where you see it
commented out was where I had:
```
```
---
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/345
Checkstyle
## Description
* Updated to latest checkstyle (v8.5)
* Added many more rules to checkstyle
* Included checking of test files and more file types
## Motivation and
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/343
Reduced the size of all screenshots.
## Description
Reduced size of all png screenshots using: `pngquant -f --ext .png
--quality 70-95 *.png`.
Most were only reduced marginally but some were
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/332
Thank you for merging!
---
Github user ham1 commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/342#discussion_r153054513
--- Diff: src/functions/org/apache/jmeter/functions/ChangeCase.java ---
@@ -127,19 +129,14 @@ public String getReferenceKey() {
return DESC
Github user ham1 commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/342#discussion_r153049075
--- Diff: test/src/org/apache/jmeter/functions/TestChangeCaseExamples.java
---
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user ham1 commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/342#discussion_r153048260
--- Diff: test/src/org/apache/jmeter/functions/TestChangeCaseExamples.java
---
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user ham1 commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/342#discussion_r153048235
--- Diff: test/src/org/apache/jmeter/functions/TestChangeCaseExamples.java
---
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/332
Great, thank you. If someone could merge #337 first then I can make there
are no conflicts.
---
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/332
I've added some more tests:
* `ApdexSummaryConsumer` and
* `ListResultData`
Plus some code tidy up.
Any thoughts?
---
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/339
Refactored TestChangeCase.
Improved readability.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter casechange-test-improvment
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/332
I've fixed any conflicts now.
So far I've migrated and added to:
* RunTime
* HTTPUtils
I've added new tests for:
* UniformRandomTimer
* JDBCSampler -
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/337
Tidy JavaDoc and fix error in getTop5ErrorMetrics method.
## Description
Fixed bug whereby calling `registerError` with the following data set
`["A", "B", "C", &quo
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/336
Fixed some docs regarding removal of WorkBench
Removed some references to WorkBench from docs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/335
Removed functions.util.* as they don't seem to be used (for many years).
## Description
Remove files which don't seem to be used, they have a TODO comment from
2008 and hasn't be
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/334
Enable running of JUnit tests from within IntelliJ with default config
## Description
With the default IntelliJ config tests are not run in the `bin` or project
root folder which meant tests
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/333
Added header check to checkstyle, fixed errors and minor cleanup
## Description
Added Java Apache licence header check, used a regex so that we don't have
to change 100s of files and it still
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/332
Oh, failed due to tabs from isVar/PropDefined function patch.
---
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/332
Added Spock framework and some tests, both old and new
## Description
WIP for adding Spock to JMeter. Created some new tests and translated some
old ones.
## Motivation and Context
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/331
Removed (some more) commented out code
## Description
Removing more commented out code
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/329
I think this is useful for people who are exploring the xml responses.
I agree that this could be removed if the XPath tester was improved with
the same view.
---
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/324
@pmouawad Thank you for committing my changes - in future I'm happy to
rebase and fix merge issues so you don't have to :)
There were only a few minor things:
- formatting of s
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/329
Expansion of "Add expand/collapse all menu in render XML view" (PR #294)
## Description
Update and expansion to PR #294. I hope @max3163 doesn't mind. It improves
upon the UX
Github user ham1 commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/320#discussion_r150891448
--- Diff:
src/protocol/http/org/apache/jmeter/protocol/http/api/auth/DigestParameters.java
---
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache
Github user ham1 commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/320#discussion_r150905177
--- Diff:
src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java ---
@@ -215,22 +269,128 @@ public long getKeepAliveDuration(HttpResponse
Github user ham1 commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/320#discussion_r150895140
--- Diff:
src/protocol/http/org/apache/jmeter/protocol/http/control/DynamicKerberosSchemeFactory.java
---
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the
Github user ham1 commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/320#discussion_r150891784
--- Diff:
src/protocol/http/org/apache/jmeter/protocol/http/control/AuthManager.java ---
@@ -97,10 +94,33 @@
private static final boolean
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/328
Improve wording and formatting of jmeter.properties
- fixed some typos,
- re-formatted some lines to aid readability and
- removed extra whitespace.
You can merge this pull request into a Git
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/327
Utilising more modern Java, simplifying code and formatting code and
comments
## Description
Three commits covering three types of change:
- Formatting and comment tidy up
- Use modern
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/326
How can this PR affect code coverage? Do we have tests which are
non-deterministic and then change the test coverage each run?
---
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/326
Improved PR template
## Description
Removed checkboxes from items which don't all have to be checked.
Added link to code style guidelines (the wiki page should be further
updated).
Yo
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/324
Save backup refactor
Further refactoring for readability to `createBackupFile` and other minor
improvements.
## Description
Refactoring `createBackupFile` and minor tidy up of surrounding
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/323
Extracted method and used streams to improve readability
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter save_refactor
Alternatively
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/322
General JavaDoc cleanup
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter javadoc_tidy
Alternatively you can review and apply these
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/319
Removed commented out code
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter remove_commented_out_code
Alternatively you can review and
Github user ham1 closed the pull request at:
https://github.com/apache/jmeter/pull/257
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ham1 closed the pull request at:
https://github.com/apache/jmeter/pull/260
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ham1 commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/254#discussion_r99697856
--- Diff: src/core/org/apache/jmeter/gui/logging/LogEventObject.java ---
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/262
Updated README.md
Updated:
* formatting
* grammar
* wording
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter readme-update
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/260
Manually synchronized on synchronizedMap as per docs and bz55827
Fixes issue identified in
[bz55827](https://bz.apache.org/bugzilla/show_bug.cgi?id=55827)
You can merge this pull request into a Git
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/259
Refactored and reformatted SmtpSampler
* Makes sample method much easier to read.
* Minor changes to SendMailCommand
I understand this is a fairly big change with no tests but I thought
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/257
After reviewing my changes to `org.apache.jmeter.control` they were all
suggested by my IDE (IntelliJ) so I am confident they are correct - however I
understand if you don't want to apply some of
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/257
Thanks for looking at the PR and commenting.
I will take another look at the changes to `org.apache.jmeter.control` and
either revert or justify them.
I'd gladly add more tests if we
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/257
Static Analysis Fixes
Hopefully each commit is small enough to review and apply (and at least
some of this is useful) please let me know if not.
Improvements based largely upon static
Github user ham1 closed the pull request at:
https://github.com/apache/jmeter/pull/255
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/255
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/255
Sorry, updated now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/255
Utilised Java 8 (and 7) features to tidy up code
Used lambdas, method references, multi-catch blocks and
`ThreadLocal.withInitial` to improve code readability.
Also removed unnecessary types.
You
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/174
I've created multiple commits, does this help?
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/174
Any comments? Is there something that needs doing before merging?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user ham1 commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/174#discussion_r62420814
--- Diff: src/core/org/apache/jmeter/reporters/ResultCollector.java ---
@@ -386,16 +384,14 @@ public void loadExistingFile
Github user ham1 closed the pull request at:
https://github.com/apache/jmeter/pull/131
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ham1 commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/174#discussion_r57560546
--- Diff: test/src/org/apache/jmeter/resources/PackageTest.java ---
@@ -136,9 +136,9 @@ private int readRF(String res, List l) throws
Exception
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/174
Used multi-catch, enhanced for loops, contains and minor formatting
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter java_7
Github user ham1 commented on the pull request:
https://github.com/apache/jmeter/pull/131#issuecomment-199507116
@FSchumacher thank you for applying most of my changes. I've updated the PR
and there are a few more minor things left. Regarding the spelling of that
constant, I
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/131
Refactoring of HTTPSamplerBase
Removal of unused method.
Minor simplifications of some boolean expressions.
Code formatting.
Spelling.
I've split the removal of the method an
1 - 100 of 114 matches
Mail list logo
