Confluence wiki not editable

2013-10-07 Thread Magnus Edenhill
Hi, it seems the confluence wiki is not editable by mere (logged in) mortals anymore. E.g.: https://cwiki.apache.org/confluence/display/KAFKA/Clients Is this intentional? Can it be remedied? At least for the Clients page that really should be updatable by us external people. Regards, Magnus

Changed ordering guarantee with multiple in-flight messages

2013-11-21 Thread Magnus Edenhill
Hi, I noticed Joel Koshy's update to the protocol guide wiki at https://cwiki.apache.org/confluence/display/KAFKA/A+Guide+To+The+Kafka+Protocol This sentence was added: The broker allows only a single in-flight request per connection in order to guarantee this ordering Adding such a constraint

librdkafka 0.8.0 released

2013-11-22 Thread Magnus Edenhill
This announces the 0.8.0 release of librdkafka - The Apache Kafka client C library - now with 0.8 protocol support. Features: * Producer (~800K msgs/s) * Consumer (~3M msgs/s) * Compression (Snappy, gzip) * Proper failover and leader re-election support - no message is ever lost. * Configuration

Re: librdkafka 0.8.0 released

2013-11-25 Thread Magnus Edenhill
, 2013 6:59 AM, Magnus Edenhill mag...@edenhill.se javascript:; wrote: This announces the 0.8.0 release of librdkafka - The Apache Kafka client C library - now with 0.8 protocol support. Features: * Producer (~800K msgs/s) * Consumer (~3M msgs/s) * Compression

Re: Heads up: KAFKA-1697 - remove code related to ack1 on the broker

2015-01-15 Thread Magnus Edenhill
I very much agree on what Joe is saying, let's use the version field as intended and be very strict with not removing nor altering existing behaviour without bumping the version. Old API versions could be deprecated (documentation only?) immediately and removed completely in the next minor version

Re: Compatibility + Unknown APIs

2015-01-16 Thread Magnus Edenhill
It is a bit hacky, with multiple requests in transit on the wire how do you know which request wasn't supported if the returned correlationId is -1? Requests are currently responded to in the order they were sent, so the corrId is not yet critical, but with will this always be true? One could

Re: [DISCUSS] KIPs

2015-01-23 Thread Magnus Edenhill
Wouldn't it make sense to move away from these rich binary broker descriptors ({ host, port, proto }) (which require protocol churning on change), and simply use URIs instead? E.g.: kafka://host[:port]/ -- cleantext proto on standard port 9092 kafkas://host[:port] -- SSL enveloped

Re: [Discussion] Limitations on topic names

2015-07-13 Thread Magnus Edenhill
Hi, since dots seem to be a problem on the metrics side, why not let the metrics side handle it by escaping troublesome characters? E.g. foo.my\.topic.feh Let's not push the problem upstream. Replacing . with another set of allowed characters __ seems like a bad idea since it is ambigious:

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2015-10-07 Thread Magnus Edenhill
ich lets them surface a helpful error to the user. This is much > > better than retrying indefinitely which is probably how most current > > clients handle this case. > > > > -Jason > > > > On Tue, Oct 6, 2015 at 2:25 PM, Magnus Edenhill <mag...@edenhill.se&

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2015-10-06 Thread Magnus Edenhill
nd leave it out of the > BrokerMetadataRequest/Response (even for the defaults) since these are > really topic-specific fields. Rack-info on the other hand should > probably be there (at some point) in the BrokerMetadataResponse, and > this should perhaps be just a raw string that would need

Re: [DISCUSS] KIP-37 - Add namespaces in Kafka

2015-10-10 Thread Magnus Edenhill
Good write-up Ashish. Looking at one of the rejected alternatives got me thinking: "Modify request/ response formats to take namespace specifically. Solves the issue of delimiting string required in proposed approach and the issue with existing regex consumers. This definitely is the cleanest

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2015-09-30 Thread Magnus Edenhill
erformance. > > Are > > > > any nodes in the same AZ considered on the same rack or do you need > > > special > > > > guarantees to be on the same "rack". In general, I don't think > there's > > a > > > > generic "rack"

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2015-09-30 Thread Magnus Edenhill
e'll have a 0.10.0.0? > This > > > > might > > > > > > seem > > > > > > > > like a trivial consideration, but after fighting versioning > in > > > > > > different > > > > > > > > packaging systems,

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2015-09-30 Thread Magnus Edenhill
o the code" - which clients does this refer to? For > example, will the Java clients continue to behave the same way they do > today? I'm curious because empty responses seem *very* different from > closing connections. > > I'm assuming here (and I will verify this), but all

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2015-09-30 Thread Magnus Edenhill
gt; > > > > > * rack: I think there's a ton of demand for something like this, > > but > > > > I'd > > > > > > really like to think through it more before exposing anything. > > "rack" > > > > is > > > > >

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2015-09-30 Thread Magnus Edenhill
ersion between brokers with different versions. User-provided tags (server.properties), examples: "aws.zone" = "eu-central-1" "rack" = "r8a9" "cluster" = "kafka3" User provided tags are configure

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2015-09-30 Thread Magnus Edenhill
gt; determined > > just via the broker version. Is there a good reason for including them? > > Perhaps explicit info >> implicit info? > > * "All existing clients should be able to handle this gracefully without > > any alterations to the code" - w

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2015-09-30 Thread Magnus Edenhill
t; > > generic "rack" identifier we can expose -- we'll need to do something > > > specialized depending on different environments. This is a case where > > > extensibility in the format is probably really useful. > > > * Properties like supported.compression.c

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2015-09-30 Thread Magnus Edenhill
> > > adapting the terminology, but the meaning can change drastically, > > even > > > > > under seemingly similar deployments. For example, if you deploy in > > EC2, > > > > you > > > > > might create instances in multiple AZs. W

Re: [DISCUSS] KIP-31 - Message format change proposal

2015-09-30 Thread Magnus Edenhill
The BrokerMetadataRequest API could be used to propagate supported message.formats from broker to client. This is currently discussed in the KIP-35 thread. /Magnus 2015-09-30 1:50 GMT+02:00 Jiangjie Qin : > Hi Joel and other folks. > > I updated the KIP page with

[DISCUSS] KIP-35 - Retrieve protocol version

2015-09-25 Thread Magnus Edenhill
Good evening, KIP-35 was created to address current and future broker-client compatibility. https://cwiki.apache.org/confluence/display/KAFKA/KIP-35+-+Retrieving+protocol+version Summary: * allow clients to retrieve the broker's protocol version * make broker handle unknown protocol requests

Re: [DISCUSS] KIP-47 - Add timestamp-based log deletion policy

2016-06-03 Thread Magnus Edenhill
Bumping this thread so Wes can reply to it. Ignore this mail. 2016-02-24 0:36 GMT+01:00 Joel Koshy : > Great - thanks for clarifying. > > Joel > > On Tue, Feb 23, 2016 at 1:47 PM, Bill Warshaw wrote: > > > Sorry that I didn't see this comment before the

Re: ConsumerMetadataRequest

2016-02-07 Thread Magnus Edenhill
Hi Abejide, the ConsumerMetadataRequest was renamed to GroupCoordinatorRequest to indicate its more generic use than just consumer groups. See the protocol guide for more info:

Re: JIRA access

2016-01-28 Thread Magnus Edenhill
Thanks! 2016-01-28 17:36 GMT+01:00 Guozhang Wang <wangg...@gmail.com>: > Done. > > Guozhang > > On Thu, Jan 28, 2016 at 4:16 AM, Magnus Edenhill <mag...@edenhill.se> > wrote: > > > Hey, > > > > could I have access to assign myself to

JIRA access

2016-01-28 Thread Magnus Edenhill
Hey, could I have access to assign myself to issues in the Apache JIRA? Username is edenhill. Looking to provide some patches for KAFKA-3160. Regards, Magnus

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2016-03-10 Thread Magnus Edenhill
Hi all, sorry for joining late in the game, the carribean got in the way. My thoughts: There is no way around the chicken problem, so the sooner we can add protocol versioning functionality the better and we'll add heuristics in clients to handle the migration period (e.g, what Dana has done in

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2016-03-10 Thread Magnus Edenhill
gt; < > > > > > > > > > j...@confluent.io > > > > > > > > > > > > > > > > > > > > > > > >> wrote: > > > > > > > > > > > > >> >> > > > > > > > > > > >

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2016-03-15 Thread Magnus Edenhill
Hey Jay, as discussed earlier it is not safe to cache/relay a broker's version or its supported API versions, by the time the client connects the broker might have upgraded to another version which effectively makes this information useless in a cached form. The complexity of querying for

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2016-03-11 Thread Magnus Edenhill
; >> How will clients handle the fact that some 0.10.0-SNAPSHOT will have > >> different protocol than others (because we modify the protocol > >> multiple times between releases)? > >> > >> Gwen > >> > >> On Thu, Mar 10, 2016 at 1:52 PM, Magnus

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2016-03-12 Thread Magnus Edenhill
ed > changes sound good, I can update the KIP-35 wiki, WIP PR and start a Vote > thread. > > On Fri, Mar 11, 2016 at 12:48 PM, Magnus Edenhill <mag...@edenhill.se> > wrote: > > > I'm not sure supporting specific interim versions between releases are > > really that

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2016-03-16 Thread Magnus Edenhill
rtitions with info about the answering broker. > > -Jay > > On Tue, Mar 15, 2016 at 4:25 PM, Magnus Edenhill <mag...@edenhill.se> > wrote: > > Hey Jay, > > > > as discussed earlier it is not safe to cache/relay a broker's version or > > its supporte

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2016-04-05 Thread Magnus Edenhill
Empty arrays are already used in MetadataRequest to retrieve all topics in the cluster, ApiVersion request will have the same standard semantics. 2016-04-05 19:01 GMT+02:00 Ewen Cheslack-Postava : > Also, just a thought but is empty list the sentinel we really want to >

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2016-04-05 Thread Magnus Edenhill
at this point. Thanks, Magnus 2016-04-05 19:40 GMT+02:00 Magnus Edenhill <mag...@edenhill.se>: > Ashish, thanks, didnt know that. > > For ApiVersionRequest requesting no Apis to be returned doesnt make sense > so the distinction isn't necessary, > but I'm fine with adding Nu

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2016-04-05 Thread Magnus Edenhill
> . > > On Tue, Apr 5, 2016 at 10:23 AM, Magnus Edenhill <mag...@edenhill.se> > wrote: > > > Empty arrays are already used in MetadataRequest to retrieve all topics > in > > the cluster, > > ApiVersion request will have the same standard semantics. > &

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2016-04-11 Thread Magnus Edenhill
2016-04-11 3:01 GMT+02:00 Jun Rao : > Thinking about ApiVersionRequest a bit more. There are quite a few things > special about it. In the ideal case, (1) its version should never change; > The only thing we know of the future is that we dont know anything, we can't think of

Re: [DISCUSS] KIP-43: Kafka SASL enhancements

2016-04-06 Thread Magnus Edenhill
Engineers, sorry to stir up some dust on this KIP but following yesterday's discussion on the KIP call I'm a bit concerned about the way the SASL handshake protocol is diverging even more from the main Kafka protocol. The SASL handshake is already its own special protocol and the latest addition

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2016-04-11 Thread Magnus Edenhill
wo clients, Java and C, currently supports the existing SASL handshake so far. > > Thanks, > > Jun > > On Mon, Apr 11, 2016 at 12:20 AM, Magnus Edenhill <mag...@edenhill.se> > wrote: > > > 2016-04-11 3:01 GMT+02:00 Jun Rao <j...@confluent.io>: > >

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2016-04-11 Thread Magnus Edenhill
Hi Jun, the "send empty response instead of disconnect on unsupported protocol" was actually a sub-proposal and was never meant as an alternative to the proper feature detection proposed by KIP-35. I've added it back to the list of rejected alternatives on the wiki page, thanks for pointing

Re: [VOTE] KIP-35: Retrieving protocol version

2016-03-19 Thread Magnus Edenhill
+1 (nonbinding) 2016-03-18 0:09 GMT+01:00 Ashish Singh : > As the KIP has been modified since we started this vote, the vote is > restarted from now. > > The updated KIP is available at > >

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2016-03-19 Thread Magnus Edenhill
API request version ranges need to be used. This is obviously more > > tedious for more complex client-server interactions such as the new > > consumer's rebalance process; but not so much for other features such as > > KIP-32; or reading throttle time in produce/fetch responses that w

Re: How will KIP-35 and KIP-43 play together?

2016-04-04 Thread Magnus Edenhill
As Jun says the SASL (and SSL) handshake is not done using the Kafka protocol and is performed before any Kafka protocol requests pass between client and server. It might make sense to move the SASL handshake from its custom protocol format into the Kafka protocol and make it use the proper Kafka

Re: [VOTE] KIP-35: Retrieve protocol version - Round 2

2016-04-22 Thread Magnus Edenhill
Good point Rajini, I will clarify that. Thanks, Magnus 2016-04-22 12:35 GMT-07:00 Rajini Sivaram : > +1 (non-binding) > > One minor comment: > > "11: The broker returns its full list of supported ApiKeys and versions > regardless of current authentication state

Re: [VOTE] KIP-57: Interoperable LZ4 Framing

2016-04-25 Thread Magnus Edenhill
+1 (non-binding) 2016-04-25 14:26 GMT-07:00 Dana Powers : > Hi all, > > Initiating a vote thread because the KIP-57 proposal is specific to > the 0.10 release. > > KIP-57 can be accessed here: > < >

Re: [DISCUSS] KIP-43: Kafka SASL enhancements

2016-04-24 Thread Magnus Edenhill
Rajini, the KIP wiki is a bit unclear on the protocol changes. Could you document the proposed Kafka protocol requests in the standard format (as on "A guide to the Kafka protocol"). This information should also be added to that page when the KIP is accepted. I think it would also be good to

Re: [VOTE] KIP-57: Interoperable LZ4 Framing

2016-05-03 Thread Magnus Edenhill
Good work on this Dana. I'll test it with librdkafka (which uses the official liblz4) and report back. 2016-05-03 20:02 GMT+02:00 Dana Powers : > Yes, great point. The intent of adding "naive" support for the > remaining LZ4 header flags (contentsize and contentchecksum)

Re: [DISCUSS] KIP-43: Kafka SASL enhancements

2016-05-02 Thread Magnus Edenhill
updated KIP-43 to include a section with the handshake > request/response format. Have also added some more text to distinguish the > actual authentication flow from the Kafka handshake/request flow. > > Thank you, > > Rajini > > > On Mon, Apr 25, 2016 at 3:41 AM, Ma

Re: [VOTE] KIP-57: Interoperable LZ4 Framing

2016-05-09 Thread Magnus Edenhill
I have verified this functionality on kafka trunk using librdkafka lz4 branch and it works as intended. 2016-05-07 18:07 GMT+02:00 Dana Powers : > Vote Passed! I will update the wiki. > > -Dana > On May 7, 2016 3:48 AM, "Ismael Juma" wrote: > > >

Re: [DISCUSS] KIP-110: Add Codec for ZStandard Compression

2017-01-31 Thread Magnus Edenhill
Hi Dongjin and good work on the KIP, I understand that ZStandard is generally considered an improvement over LZ4, but the benchmark you provided on the KIP-110 wiki doesn't really reflect that, and even makes a note that they are comparable: *> As you can see above, ZStandard shows outstanding

Re: [DISCUSS] KIP-82 - Add Record Headers

2017-02-17 Thread Magnus Edenhill
Big +1 on VarInts. CPUs are fast, memory is slow. I agree with Jason that we'll want to continue verifying messages, including their headers, so while I appreciate the idea of the opaque header blob it won't be useful in practice. /Magnus 2017-02-17 10:41 GMT-08:00 Jason Gustafson

Re: [DISCUSS] KIP-79 - ListOffsetRequest v1 and offsetForTime() method in new consumer.

2016-09-06 Thread Magnus Edenhill
Good write-up Qin, the API looks promising. I have one comment: 2016-09-03 5:20 GMT+02:00 Becket Qin : > The currently offsetsForTimes() API obviously does not support querying > multiple timestamps for the same partition. It doesn't seems a feature for > ListOffsetRequest

Re: [DISCUSS] KIP-87 - Add Compaction Tombstone Flag

2016-10-26 Thread Magnus Edenhill
the magic byte > > to 1 for this change. > > But since we are not adding an actual field, we can do away with bumping > up > > the magic byte. > > > > If we really want to go the standard route of bumping up the magic byte > for > > any change to message format

Re: [DISCUSS] KIP-84: Support SASL/SCRAM mechanisms

2016-11-08 Thread Magnus Edenhill
Hey, I'm probably going to argue against bumping the SaslHandshake version, it is redundant to the existing SaslHandshakeResponse.enabled_mechanisms field. With SaslHandshake version bump: * Client performs ApiVersionRequest * If SaslHandshake >= v1: use SCRAM * If SaslHandshake < v1: use

Re: [DISCUSS] KIP-82 - Add Record Headers

2016-11-07 Thread Magnus Edenhill
Hi, I'm +1 for adding generic message headers, but I do share the concerns previously aired on this thread and during the KIP meeting. So let me propose a slimmer alternative that does not require any sort of global header registry, does not affect broker performance or operations, and adds as

Re: [DISCUSS] KIP-82 - Add Record Headers

2016-11-09 Thread Magnus Edenhill
> >> >> >>> message. > >> >> >>>>> > >> >> >>>>> > >> >> >>>>> > >> >> >>>>> I love strings as much as the next guy (we had them in Flume), >

Re: [DISCUSS] KIP-87 - Add Compaction Tombstone Flag

2016-10-25 Thread Magnus Edenhill
ric knowledge so was hoping it would be flagged up in this discussion > thread ☺ > > Cheers > Mike > > On 10/25/16, 5:36 PM, "Magnus Edenhill" <mag...@edenhill.se> wrote: > > Hi Michael, > > With the version bumps for Produce and Fetch request

Re: [DISCUSS] KIP-87 - Add Compaction Tombstone Flag

2016-10-25 Thread Magnus Edenhill
Hi Michael, With the version bumps for Produce and Fetch requests, do you really need to bump MagicByte too? Regards, Magnus 2016-10-25 18:09 GMT+02:00 Michael Pearce : > Hi All, > > I would like to discuss the following KIP proposal: >

Re: [VOTE] 0.10.1.0 RC3

2016-10-19 Thread Magnus Edenhill
+1 (non-binding) passes librdkafka test suites 2016-10-19 15:55 GMT+02:00 Ismael Juma : > +1 (non-binding). > > Verified source and Scala 2.11 binary artifacts, ran ./gradlew test with > JDK 7u80, quick start on source artifact and Scala 2.11 binary artifacts. > > Thanks for

Re: [DISCUSS] KIP-87 - Add Compaction Tombstone Flag

2016-10-26 Thread Magnus Edenhill
would do this. > I dont believe this is needed since it is already attributed through the request's API version. Producer: * if a client sends ProduceRequest V4 then attributes.bit5 indicates a tombstone * if a clients sends ProduceRequest On Tue, Oct 25, 2016 at 10:17 AM, Magnus E

Re: [VOTE] 0.10.2.1 RC2

2017-04-18 Thread Magnus Edenhill
+1 (non-binding) - passes librdkafka regression tests 2017-04-18 17:38 GMT+02:00 Edoardo Comar : > Thanks Gwen > KAFKA-5075 is not included in the > http://home.apache.org/~gwenshap/kafka-0.10.2.1-rc2/RELEASE_NOTES.html > > -- >

Re: [DISCUSS] KIP-140: Add administrative RPCs for adding, deleting, and listing ACLs

2017-05-04 Thread Magnus Edenhill
Hey Colin, good KIP! Some comments: 1a. For operation, permission_type and resource_type: is there any reason for having the any and unknown enums as negative values? Since neither of these fields has an integer significance (unlike for example offsets which use negative offsets for logical

Re: [DISCUSS] KIP-152 - Improve diagnostics for SASL authentication failures

2017-05-04 Thread Magnus Edenhill
Hi Rajini, great KIP! This solution was proposed on the original KIP-43 thread but voted down, so let's hope it does better this time :) /Magnus 2017-05-04 13:37 GMT+02:00 Rajini Sivaram : > Hi all, > > I have created a KIP to improve diagnostics for SASL

Re: [DISCUSS] KIP-191: KafkaConsumer.subscribe() overload that takes just Pattern

2017-08-30 Thread Magnus Edenhill
For what it is worth: librdkafka-based clients will treat any subscribed topic string that is prefixed with the regexp start-of-line anchor ("^") as a regexp, thus providing regex and actual topic subscriptions with the same API, also allowing a mix of actuals and regexps: E.g.:

Re: TLS settings in librdkafka

2018-05-28 Thread Magnus Edenhill
ltimate goal > of the PR is allowing us to avoid even offering insecure algorithms > during the TLS handshake. I.e: avoid the usage of certificate > signature algorithms involving SHA1. > > Magnus Edenhill mentioned in PR[3] some ongoing work/discussion about > keeping librdkafka

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

2018-04-26 Thread Magnus Edenhill
t; > order, into this buffer at the current position, and then increments > > the > > > > position by eight. > > > > > > > > The implementation will be defined in > > > > org.apache.kafka.common.protocol.types with the other protocol types

Re: [DISCUSS]: KIP-339: Create a new ModifyConfigs API

2018-07-16 Thread Magnus Edenhill
Thanks for driving this KIP, Colin. I agree with Dong that a new similar modifyConfigs API (and protocol API) is confusing and that we should try to extend the current alterConfigs interface to support the incremental mode instead, deprecating the non-incremental mode in the process. Another

Re: [DISCUSS] KIP-110: Add Codec for ZStandard Compression (Updated)

2018-09-06 Thread Magnus Edenhill
> Ismael wrote: > Jason, that's an interesting point regarding the Java client. Do we know > what clients in other languages do in these cases? librdkafka (and its bindings) passes unknown/future errors through to the application, the error code remains intact while the error string will be set

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

2018-07-04 Thread Magnus Edenhill
t; >> >> in ZK.> >> >> From this perspective I'd leave the the > > command there but put a> >> >> warning that the tool is deprecated and > > should only be used for> >> >> setting up SCRAM credentials. > > >>> >>>

Re: [VOTE] KIP-322: Return new error code for DeleteTopics API when topic deletion disabled.

2018-07-04 Thread Magnus Edenhill
+1 (non-binding) 2018-07-04 13:40 GMT+02:00 Satish Duggana : > +1 > > Thanks, > Satish. > > On Wed, Jul 4, 2018 at 4:11 PM, Daniele Ascione > wrote: > > > +1 > > > > Thanks, > > Daniele > > > > Il giorno mar 3 lug 2018 alle ore 23:55 Harsha ha > > scritto: > > > > > +1. > > > > > > Thanks, > >

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

2018-04-09 Thread Magnus Edenhill
Hi Viktor, since serialization of floats isn't as straight forward as integers, please specify the exact serialization format of DOUBLE in the protocol docs (e.g., IEEE 754), including endianness (big-endian please). This will help the non-java client ecosystem. Thanks, Magnus 2018-04-09

Re: [VOTE] 2.1.0 RC0

2018-10-29 Thread Magnus Edenhill
+1 (non-binding) passes librdkafka integration test suite Den fre 26 okt. 2018 kl 15:58 skrev Manikumar : > minor observation: config sections are empty in the documentation page. > http://kafka.apache.org/21/documentation.html#producerconfigs > > On Wed, Oct 24, 2018 at 10:49 PM Ted Yu wrote:

Re: [VOTE] 2.0.1 RC0

2018-10-30 Thread Magnus Edenhill
+1 (non-binding) Passes librdkafka integration test suite Den mån 29 okt. 2018 kl 18:08 skrev Manikumar : > Hi Eno, > > This looks like an existing issue occuring only on source artifacts. We > are able to generate aggregate docs on cloned repo. > I am getting similar error on previous release

Re: [VOTE] KIP-228 Negative record timestamp support

2018-12-06 Thread Magnus Edenhill
Sorry for getting in the game this late, and on the wrong thread! I think negative timestamps makes sense and is a good addition, but I have a couple of concerns with the proposal: 1. I believe any change to the protocol format or semantics require a protocol bump, in this case for

Re: [VOTE] 2.1.1 RC2

2019-02-08 Thread Magnus Edenhill
+1 Passes librdkafka test suite. Den fre 8 feb. 2019 kl 21:02 skrev Colin McCabe : > Hi all, > > This is the third candidate for release of Apache Kafka 2.1.1. This > release includes many bug fixes for Apache Kafka 2.1. > > Compared to rc1, this release includes the following changes: > *

Re: [DISCUSS] KIP-430 - Return Authorized Operations in Describe Responses

2019-02-13 Thread Magnus Edenhill
Hey Rajini, good work on the KIP! I'm personally not thrilled with piggy-backing the authorized_operations on existing APIs, it seems like a mix of concerns. Since there is already the notion of generic ResourceType,ResourceName tuples in the Admin API, I believe it would make more sense to add

Re: [VOTE] KIP-360: Improve handling of unknown producer when using EOS

2019-04-10 Thread Magnus Edenhill
+1 (non-binding) Den ons 10 apr. 2019 kl 02:38 skrev Guozhang Wang : > +1 (binding). Thanks for the written KIP! The approach lgtm. > > One minor thing: the name of "last epoch" maybe a bit misleading (although > it is for internal usage only and will not be exposed to users) for future >

Re: [DISCUSS] KIP-482: The Kafka Protocol should Support Optional Fields

2019-08-26 Thread Magnus Edenhill
Great KIP as always, Colin! Some comments: > If the flexible versions are not specified, it is assumed that all versions are flexible. This is ambiguous, if a protocol-generator is pointed to an older Kafka protocol specification it can't know if the lack of flexibleVersions field means

Re: [DISCUSS] KIP-511: Collect and Expose Client's Name and Version in the Brokers

2019-08-23 Thread Magnus Edenhill
Great proposal, this feature is well overdue! 1) >From an operator's perspective I don't think the kafka client implementation name and version are sufficient, I also believe the application name and version are of interest. You could have all applications in your cluster run the same kafka

Re: [DISCUSS] KIP-467: Augment ProduceResponse error messaging

2019-09-09 Thread Magnus Edenhill
Hey Guozhang, I'm late to the game, again, but if it is not too late I'd recommend that instead of having a single error code for all failed records, instead provide per-record error codes by having an array of [relative_offset, error_code], where they're both varint-encoded for space-efficiency.

Re: [DISCUSS] KIP-467: Augment ProduceResponse error messaging

2019-09-09 Thread Magnus Edenhill
. 2019 kl 08:49 skrev Magnus Edenhill : > Hey Guozhang, > > I'm late to the game, again, but if it is not too late I'd recommend that > instead > of having a single error code for all failed records, instead provide > per-record > error codes by having an array of [relati

Re: [VOTE] KIP-511: Collect and Expose Client's Name and Version in the Brokers

2019-09-18 Thread Magnus Edenhill
> I think we should force client software names and versions to follow a regular expression and disconnect if they do not. Disconnecting is not really a great error propagation method since it leaves the client oblivious to what went wrong. Instead suggest we return an ApiVersionResponse with an

Re: [VOTE] KIP-482: The Kafka Protocol should Support Optional Tagged Fields

2019-09-28 Thread Magnus Edenhill
Den mån 23 sep. 2019 kl 14:42 skrev Colin McCabe : > On Fri, Sep 20, 2019, at 18:05, Jun Rao wrote: > > 101. We already use varInt in the message format. I assume that the > > protocol uses the same varInt representation? > > It uses a slightly different varint representation. Basically, the >

Re: [DISCUSS] KIP-551: Expose disk read and write metrics

2019-12-10 Thread Magnus Edenhill
Hi Colin, aren't those counters (ever increasing), rather than gauges (fluctuating)? You also mention CPU usage as a side note, you could use getrusage(2)'s ru_utime (user) and ru_stime (sys) to allow the broker to monitor its own CPU usage. /Magnus Den tis 10 dec. 2019 kl 19:33 skrev Colin

Re: [DISCUSSION] Upgrade system tests to python 3

2020-10-07 Thread Magnus Edenhill
;> > https://github.com/apache/kafka/pull/9196/files#diff-9235a7bdb1ca9268681c0e56f3f3609bR39 > >>> > >>>> 16 сент. 2020 г., в 07:32, Guozhang Wang > >>> написал(а): > >>>> > >>>> Hello Nikolay, > >>>> > >>

Re: [DISCUSS] KIP-363

2020-07-08 Thread Magnus Edenhill
Hi Tom, I think it would be useful with some real world (or made up!) numbers on how much relative/% space is saved for the most error-dense protocol requests. E.g., an OffsetCommitResponse with 10 topics and 100 failing partitions would reduce the overall size by % bytes. Thanks, Magnus Den

Re: [DISCUSS] KIP-709: Extend OffsetFetch requests to accept multiple group ids

2021-01-27 Thread Magnus Edenhill
Hey Thomas, I'm late to the game. It looks like the "top level" ErrorCode moved from the top-level to the Group array, which makes sense, but it would be good if it was marked as // MOVED in the KIP and also a note that top level errors that are unrelated to the group will be returned as

Re: [DISCUSS] KIP-714: Client metrics and observability

2021-06-16 Thread Magnus Edenhill
tor", so the opt-out appears to be the only motivation. Am I missing > something? > > Ryanne > > On Wed, Jun 2, 2021 at 7:46 AM Magnus Edenhill wrote: > > > Hey all, > > > > I'm proposing KIP-714 to add remote Client metrics and observability. > > This

Re: [DISCUSS] KIP-714: Client metrics and observability

2021-06-16 Thread Magnus Edenhill
; client > and the end result of easy-panels would be the same. > > In summary, > > - Metrics are more of an organizational concern, not specifically a broker > operator concern. > > - The proposal seems to hijack how metrics are gathered within > organizations > > -

[DISCUSS] KIP-714: Client metrics and observability

2021-06-02 Thread Magnus Edenhill
Hey all, I'm proposing KIP-714 to add remote Client metrics and observability. This functionality will allow centralized monitoring and troubleshooting of clients and their internals. Please see https://cwiki.apache.org/confluence/display/KAFKA/KIP-714%3A+Client+metrics+and+observability

Re: [DISCUSS] KIP-714: Client metrics and observability

2021-06-29 Thread Magnus Edenhill
Thanks for your feedback, Colin, see response below. Den tors 17 juni 2021 kl 00:28 skrev Colin McCabe : > On Sun, Jun 13, 2021, at 21:51, Travis Bischel wrote: > ... > > Another downside is that by dictating the important metrics, this KIP > either > > has two choices: try to choose what is

Re: [DISCUSS] KIP-714: Client metrics and observability

2021-06-29 Thread Magnus Edenhill
Hey Tom, Den mån 21 juni 2021 kl 21:08 skrev Tom Bentley : > > 1. Did you consider using a `default ClientTelemetryReceiver > clientReceiver() { return null; }` method on the existing MetricsReporter > interface, avoiding the need for the ClientTelemetry trait? > I'll let Xavier answer this one

Re: [DISCUSS] KIP-714: Client metrics and observability

2021-06-29 Thread Magnus Edenhill
Den tors 17 juni 2021 kl 00:52 skrev Colin McCabe : > Hi Magnus, > > Thanks for the KIP. This is certainly something I've been wishing for for > a while. > > Maybe we should emphasize more that the metrics that are being gathered > here are Kafka metrics, not general application business logic

Re: [DISCUSS] KIP-714: Client metrics and observability

2021-06-29 Thread Magnus Edenhill
) scenario is true, then hooks would still be a > great > > > alternative, because then Confluent could provide drop-in hooks for > any client > > > and the end result of easy-panels would be the same. > > > > > > > In general, if a feature

Re: [VOTE] 3.0.0 RC1

2021-09-01 Thread Magnus Edenhill
Hi Konstantine, Some findings from running 3.0.0-RC1 with the librdkafka test suite: * Compaction seems to take slightly longer to kick in when segment sizes exceed their threshold. (Used to take less than 20 seconds, now takes 20..30 seconds.) * CreateTopic seems to take slightly longer to

Re: [DISCUSS] KIP-714: Client metrics and observability

2021-09-14 Thread Magnus Edenhill
Thanks for your feedback Colin, see my updated proposal below. Den tors 22 juli 2021 kl 03:17 skrev Colin McCabe : > On Tue, Jun 29, 2021, at 07:22, Magnus Edenhill wrote: > > Den tors 17 juni 2021 kl 00:52 skrev Colin McCabe : > > > A few critiques: > > > > &

Re: [DISCUSS] KIP-714: Client metrics and observability

2021-10-19 Thread Magnus Edenhill
the client is producing to/consuming from. I'll add some sizes to the KIP for some typical use-cases. Thanks, Magnus > Thanks > > On Tue, Oct 19, 2021 at 5:06 PM Magnus Edenhill > wrote: > > > > Den tis 19 okt. 2021 kl 13:22 skrev Tom Bentley : > > > > > Hi

Re: [DISCUSS] KIP-714: Client metrics and observability

2021-10-19 Thread Magnus Edenhill
; that may be included as a metrics label if it has been set by the user", so > I'm confused whether non-Kafka Streams clients should set an application_id > or not. > I'll clarify this in the KIP, but basically we would need to add an ` application.id` config property for non-st

[VOTE] KIP-714: Client Metrics and Observability

2021-10-18 Thread Magnus Edenhill
Hi all, I'd like to start a vote on KIP-714. https://cwiki.apache.org/confluence/x/2xRRCg Discussion thread: https://www.mail-archive.com/dev@kafka.apache.org/msg119000.html Thanks, Magnus

Re: [DISCUSS] KIP-714: Client metrics and observability

2021-10-07 Thread Magnus Edenhill
. Regards, Magnus Den mån 4 okt. 2021 kl 20:57 skrev Magnus Edenhill : > Hi Gwen, > > I'm finishing up the KIP based on the last couple of discussion points in > this thread > and will call the Vote later this week. > > Best, > Magnus > > Den lör 2 okt. 20

Re: [DISCUSS] KIP-714: Client metrics and observability

2021-09-22 Thread Magnus Edenhill
Den tis 21 sep. 2021 kl 06:58 skrev Colin McCabe : > On Mon, Sep 20, 2021, at 17:35, Feng Min wrote: > > Thanks Magnus & Colin for the discussion. > > > > Based on KIP-714's stateless design, Client can pretty much use any > > connection to any broker to send metrics. We are not associating >

Re: [DISCUSS] KIP-714: Client metrics and observability

2021-09-22 Thread Magnus Edenhill
Den mån 20 sep. 2021 kl 20:41 skrev Colin McCabe : > On Tue, Sep 14, 2021, at 00:47, Magnus Edenhill wrote: > > Thanks for your feedback Colin, see my updated proposal below. > > ... > > Hi Magnus, > > Thanks for the update. > > > > > Splitting up the A

  1   2   >