lmccay merged PR #938:
URL: https://github.com/apache/knox/pull/938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
For
lmccay opened a new pull request, #938:
URL: https://github.com/apache/knox/pull/938
## What changes were proposed in this pull request?
TokenServiceResourceTest - testLimitingTokensPerUser method acquires many
tokens within a tight for loop and does not insure that the tokenIds are u
pzampino merged PR #937:
URL: https://github.com/apache/knox/pull/937
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
F
pzampino commented on code in PR #937:
URL: https://github.com/apache/knox/pull/937#discussion_r1792399333
##
gateway-service-definitions/src/main/resources/services/iceberg-rest/0.0.1/rewrite.xml:
##
@@ -0,0 +1,22 @@
+
+
+
+
Review Comment:
Right, and I'm not convinced
lmccay commented on code in PR #937:
URL: https://github.com/apache/knox/pull/937#discussion_r1792335405
##
gateway-service-definitions/src/main/resources/services/iceberg-rest/0.0.1/rewrite.xml:
##
@@ -0,0 +1,22 @@
+
+
+
+
Review Comment:
We need REST in the name since
moresandeep commented on code in PR #937:
URL: https://github.com/apache/knox/pull/937#discussion_r1792321094
##
gateway-service-definitions/src/main/resources/services/iceberg-rest/0.0.1/rewrite.xml:
##
@@ -0,0 +1,22 @@
+
+
+
+
Review Comment:
Looks like the service nam
pzampino opened a new pull request, #937:
URL: https://github.com/apache/knox/pull/937
## What changes were proposed in this pull request?
Add a service definition and rewrite rules for Apache Iceberg REST Catalog
API service.
--
This is an automated message from the Ap
lmccay commented on PR #918:
URL: https://github.com/apache/knox/pull/918#issuecomment-2362370420
Hi @bonampak - could you add a unit test for this to clearly show what the
failure was and that it is fixed and doesn't regress? Sorry for the delayed
review here!
--
This is an automated me
pzampino commented on PR #934:
URL: https://github.com/apache/knox/pull/934#issuecomment-2346219759
Thank you for this contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
pzampino commented on PR #931:
URL: https://github.com/apache/knox/pull/931#issuecomment-2346220343
Thank you for this contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
pzampino merged PR #934:
URL: https://github.com/apache/knox/pull/934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
F
pzampino merged PR #931:
URL: https://github.com/apache/knox/pull/931
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
F
pzampino merged PR #935:
URL: https://github.com/apache/knox/pull/935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
F
hanicz commented on PR #935:
URL: https://github.com/apache/knox/pull/935#issuecomment-2340805328
No, locally it is working fine. The builds are failing on GitHub.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
hanicz opened a new pull request, #935:
URL: https://github.com/apache/knox/pull/935
…xceptions
## What changes were proposed in this pull request?
The below tests are failing with NullPointerException during the build
BadUrlTest.setUpBeforeClass:122->startGatewayServer:
hanicz opened a new pull request, #934:
URL: https://github.com/apache/knox/pull/934
## What changes were proposed in this pull request?
Added monitorInterval property to the Configuration tag in the log4j2
configuration file. With this change Knox can change log level at runtime ther
moresandeep closed pull request #933: KNOX-3062 - Fix an issue where group
headers were not added to POST and PUT requests
URL: https://github.com/apache/knox/pull/933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
Johnbad2000 commented on PR #931:
URL: https://github.com/apache/knox/pull/931#issuecomment-2330538280
Good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
pzampino merged PR #930:
URL: https://github.com/apache/knox/pull/930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
F
moresandeep merged PR #932:
URL: https://github.com/apache/knox/pull/932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
moresandeep opened a new pull request, #932:
URL: https://github.com/apache/knox/pull/932
## What changes were proposed in this pull request?
Fix an issue which can throw error in token deserialization.
## How was this patch tested?
This patch was tested locally on a loca
hanicz opened a new pull request, #930:
URL: https://github.com/apache/knox/pull/930
## What changes were proposed in this pull request?
Changed the scope for the MySQL Connector dependency to provided.
## How was this patch tested?
Ran tests locally
--
This is an
pzampino merged PR #929:
URL: https://github.com/apache/knox/pull/929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
F
pzampino commented on code in PR #929:
URL: https://github.com/apache/knox/pull/929#discussion_r1725734265
##
gateway-server/src/main/java/org/apache/knox/gateway/GatewayServer.java:
##
@@ -962,10 +985,32 @@ private void processApplicationPathAliases(File warDir,
Topology topol
pzampino commented on code in PR #929:
URL: https://github.com/apache/knox/pull/929#discussion_r1725038551
##
gateway-server/src/main/java/org/apache/knox/gateway/GatewayServer.java:
##
@@ -962,10 +985,32 @@ private void processApplicationPathAliases(File warDir,
Topology topol
pzampino commented on code in PR #929:
URL: https://github.com/apache/knox/pull/929#discussion_r1725029902
##
gateway-server/src/main/java/org/apache/knox/gateway/GatewayServer.java:
##
@@ -717,6 +723,21 @@ void createJetty() throws IOException,
CertificateException, NoSuchAlgo
pzampino commented on code in PR #929:
URL: https://github.com/apache/knox/pull/929#discussion_r1725022591
##
gateway-server/src/main/java/org/apache/knox/gateway/GatewayServer.java:
##
@@ -962,10 +985,32 @@ private void processApplicationPathAliases(File warDir,
Topology topol
moresandeep commented on code in PR #929:
URL: https://github.com/apache/knox/pull/929#discussion_r1724146320
##
gateway-server/src/main/java/org/apache/knox/gateway/GatewayServer.java:
##
@@ -717,6 +723,21 @@ void createJetty() throws IOException,
CertificateException, NoSuchA
lmccay commented on code in PR #929:
URL: https://github.com/apache/knox/pull/929#discussion_r1724053568
##
gateway-server/src/main/java/org/apache/knox/gateway/GatewayServer.java:
##
@@ -962,10 +985,32 @@ private void processApplicationPathAliases(File warDir,
Topology topolog
pzampino commented on code in PR #929:
URL: https://github.com/apache/knox/pull/929#discussion_r1724039838
##
gateway-server/src/main/java/org/apache/knox/gateway/GatewayServer.java:
##
@@ -962,10 +985,32 @@ private void processApplicationPathAliases(File warDir,
Topology topol
pzampino commented on code in PR #929:
URL: https://github.com/apache/knox/pull/929#discussion_r1724039838
##
gateway-server/src/main/java/org/apache/knox/gateway/GatewayServer.java:
##
@@ -962,10 +985,32 @@ private void processApplicationPathAliases(File warDir,
Topology topol
lmccay commented on code in PR #929:
URL: https://github.com/apache/knox/pull/929#discussion_r1724026595
##
gateway-server/src/main/java/org/apache/knox/gateway/GatewayServer.java:
##
@@ -962,10 +985,32 @@ private void processApplicationPathAliases(File warDir,
Topology topolog
pzampino opened a new pull request, #929:
URL: https://github.com/apache/knox/pull/929
## What changes were proposed in this pull request?
Modified error handling when a topology is being redeployed, such that the
response is not HTTP 404 'Not Found', but rather HTTP 503 'Service
Una
pzampino merged PR #928:
URL: https://github.com/apache/knox/pull/928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
F
slankka commented on code in PR #921:
URL: https://github.com/apache/knox/pull/921#discussion_r1718184062
##
gateway-service-definitions/src/main/resources/services/yarnui/2.7.0/rewrite.xml:
##
@@ -23,8 +23,8 @@
e.g. http://host.com:8088
-->
-
-
+
Review Comment:
slankka commented on code in PR #921:
URL: https://github.com/apache/knox/pull/921#discussion_r1718181732
##
gateway-service-definitions/src/main/resources/services/yarnui/2.7.0/rewrite.xml:
##
@@ -23,8 +23,8 @@
e.g. http://host.com:8088
-->
-
-
+
Review Comment:
slankka commented on code in PR #921:
URL: https://github.com/apache/knox/pull/921#discussion_r1718181732
##
gateway-service-definitions/src/main/resources/services/yarnui/2.7.0/rewrite.xml:
##
@@ -23,8 +23,8 @@
e.g. http://host.com:8088
-->
-
-
+
Review Comment:
slankka commented on code in PR #921:
URL: https://github.com/apache/knox/pull/921#discussion_r1718137155
##
gateway-service-definitions/src/main/resources/services/yarnui/2.7.0/rewrite.xml:
##
@@ -23,8 +23,8 @@
e.g. http://host.com:8088
-->
-
-
+
Review Comment:
slankka commented on code in PR #921:
URL: https://github.com/apache/knox/pull/921#discussion_r1718137155
##
gateway-service-definitions/src/main/resources/services/yarnui/2.7.0/rewrite.xml:
##
@@ -23,8 +23,8 @@
e.g. http://host.com:8088
-->
-
-
+
Review Comment:
slankka commented on code in PR #921:
URL: https://github.com/apache/knox/pull/921#discussion_r1718124840
##
gateway-service-definitions/src/main/resources/services/yarnui/2.7.0/rewrite.xml:
##
@@ -23,8 +23,8 @@
e.g. http://host.com:8088
-->
-
-
+
Review Comment:
slankka commented on code in PR #921:
URL: https://github.com/apache/knox/pull/921#discussion_r1718124840
##
gateway-service-definitions/src/main/resources/services/yarnui/2.7.0/rewrite.xml:
##
@@ -23,8 +23,8 @@
e.g. http://host.com:8088
-->
-
-
+
Review Comment:
hanicz commented on code in PR #928:
URL: https://github.com/apache/knox/pull/928#discussion_r1703882471
##
gateway-server/src/main/java/org/apache/knox/gateway/GatewayFilter.java:
##
@@ -203,6 +208,8 @@ public void doFilter( ServletRequest servletRequest,
ServletResponse servl
moresandeep commented on code in PR #921:
URL: https://github.com/apache/knox/pull/921#discussion_r1700425734
##
gateway-service-definitions/src/main/resources/services/yarnui/2.7.0/rewrite.xml:
##
@@ -23,8 +23,8 @@
e.g. http://host.com:8088
-->
-
-
+
Review Commen
pzampino commented on code in PR #921:
URL: https://github.com/apache/knox/pull/921#discussion_r1700421971
##
gateway-service-definitions/src/main/resources/services/yarnui/2.7.0/rewrite.xml:
##
@@ -23,8 +23,8 @@
e.g. http://host.com:8088
-->
-
-
+
Review Comment:
pzampino merged PR #925:
URL: https://github.com/apache/knox/pull/925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
F
pzampino commented on code in PR #928:
URL: https://github.com/apache/knox/pull/928#discussion_r1700416016
##
gateway-server/src/main/java/org/apache/knox/gateway/GatewayFilter.java:
##
@@ -203,6 +208,8 @@ public void doFilter( ServletRequest servletRequest,
ServletResponse ser
hanicz opened a new pull request, #928:
URL: https://github.com/apache/knox/pull/928
## What changes were proposed in this pull request?
Modern browsers ignore caching headers as meta elements. Due to this Firefox
loads index.html from cache and the user won't be redirected to the Kno
moresandeep merged PR #920:
URL: https://github.com/apache/knox/pull/920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
moresandeep merged PR #924:
URL: https://github.com/apache/knox/pull/924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
pzampino merged PR #927:
URL: https://github.com/apache/knox/pull/927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
F
hanicz opened a new pull request, #927:
URL: https://github.com/apache/knox/pull/927
…od call
## What changes were proposed in this pull request?
Moved the mock setup before the actual method call in
testTopologyDiscoveryTriggerHandlesInvalidDescriptorContent(org.apache.knox.ga
smolnar82 commented on PR #912:
URL: https://github.com/apache/knox/pull/912#issuecomment-2238157427
@stoty , @moresandeep - I'm closing this now, feel free to re-open when
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
smolnar82 closed pull request #912: KNOX-3033 Add option to set the correct
path for sticky session cookies
URL: https://github.com/apache/knox/pull/912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
hanicz opened a new pull request, #925:
URL: https://github.com/apache/knox/pull/925
## What changes were proposed in this pull request?
A new path /usr/share/java/*.jar is added on the classpath which is located
outside of the Knox installation folder. Users can place 3rd-party JARs
moresandeep commented on code in PR #924:
URL: https://github.com/apache/knox/pull/924#discussion_r1672073246
##
gateway-server/src/main/java/org/apache/knox/gateway/services/token/impl/DefaultTokenAuthorityService.java:
##
@@ -83,6 +84,8 @@ public class DefaultTokenAuthoritySer
moresandeep commented on code in PR #924:
URL: https://github.com/apache/knox/pull/924#discussion_r1672044065
##
gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/JWTFederationFilter.java:
##
@@ -149,6 +153,30 @@ public void init(
moresandeep commented on code in PR #924:
URL: https://github.com/apache/knox/pull/924#discussion_r1672037317
##
gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/JWTFederationFilter.java:
##
@@ -110,7 +114,7 @@ public void init(
moresandeep commented on code in PR #924:
URL: https://github.com/apache/knox/pull/924#discussion_r1672034656
##
gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/AbstractJWTFilter.java:
##
@@ -115,7 +116,7 @@ public abstract clas
moresandeep commented on code in PR #924:
URL: https://github.com/apache/knox/pull/924#discussion_r1672031543
##
gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/JWTMessages.java:
##
@@ -123,4 +123,7 @@ public interface JWTMessages {
smolnar82 commented on code in PR #924:
URL: https://github.com/apache/knox/pull/924#discussion_r1671617962
##
gateway-server/src/main/java/org/apache/knox/gateway/services/token/impl/DefaultTokenAuthorityService.java:
##
@@ -83,6 +84,8 @@ public class DefaultTokenAuthorityServi
moresandeep opened a new pull request, #924:
URL: https://github.com/apache/knox/pull/924
## What changes were proposed in this pull request?
This PR is a followup to KNOX-3040 and adds support for multiple JWKS
endpoints. Users can specify one JWKS endpoint or multiple comma separate
moresandeep commented on PR #912:
URL: https://github.com/apache/knox/pull/912#issuecomment-2217316719
> Thanks for the review @moresandeep .
>
> At the moment this is on hold, as we are pursuing another solution.
>
> I will come back to this and try to address your comments lat
stoty commented on PR #912:
URL: https://github.com/apache/knox/pull/912#issuecomment-2217043726
Thanks for the review @moresandeep .
At the moment this is on hold, as we are pursuing another solution.
I will come back to this and try to address your comments later.
--
This i
moresandeep merged PR #923:
URL: https://github.com/apache/knox/pull/923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
moresandeep opened a new pull request, #923:
URL: https://github.com/apache/knox/pull/923
## What changes were proposed in this pull request?
`auth/api/v1/pre` endpoint was only supporting GET, with this patch other
http verbs such as DELETE, PATCH, POST, PUT are now supported.
NOT
smolnar82 merged PR #882:
URL: https://github.com/apache/knox/pull/882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
smolnar82 merged PR #919:
URL: https://github.com/apache/knox/pull/919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
senthh commented on PR #919:
URL: https://github.com/apache/knox/pull/919#issuecomment-2182121268
@moresandeep , @lmccay could you please review this trivial changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
senthh commented on PR #917:
URL: https://github.com/apache/knox/pull/917#issuecomment-2174774476
@lmccay and @moresandeep Please let me know if any changes/suggestions can
help in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
senthh commented on PR #917:
URL: https://github.com/apache/knox/pull/917#issuecomment-2174215125
> > @lmccay Thank you. I have added more description about root cause of
this issue in description. We were getting this issue due to improper build of
gateway-server. and we feel having good e
lmccay commented on PR #917:
URL: https://github.com/apache/knox/pull/917#issuecomment-2174185937
> @lmccay Thank you. I have added more description about root cause of this
issue in description. We were getting this issue due to improper build of
gateway-server. and we feel having good exc
bonampak opened a new pull request, #918:
URL: https://github.com/apache/knox/pull/918
(It is very **important** that you created an Apache Knox JIRA for this
change and that the PR title/commit message includes the Apache Knox JIRA ID!)
## What changes were proposed in this pull requ
senthh commented on code in PR #917:
URL: https://github.com/apache/knox/pull/917#discussion_r1642649948
##
gateway-server/src/main/java/org/apache/knox/gateway/util/KnoxCLI.java:
##
@@ -2570,10 +2570,16 @@ public String getUsage() {
private static Properties loadBuildPrope
moresandeep commented on code in PR #917:
URL: https://github.com/apache/knox/pull/917#discussion_r1642588449
##
gateway-server/src/main/java/org/apache/knox/gateway/util/KnoxCLI.java:
##
@@ -2570,10 +2570,16 @@ public String getUsage() {
private static Properties loadBuild
senthh commented on PR #917:
URL: https://github.com/apache/knox/pull/917#issuecomment-2171032184
> Hi Senthil - thanks for your PR. Are you able to reproduce the NPE in a
unit test and show that it is fixed? Can you also add more information to the
PR description, explain how you have test
senthh commented on PR #917:
URL: https://github.com/apache/knox/pull/917#issuecomment-2170640234
@pzampino Could you please review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
senthh opened a new pull request, #917:
URL: https://github.com/apache/knox/pull/917
(It is very **important** that you created an Apache Knox JIRA for this
change and that the PR title/commit message includes the Apache Knox JIRA ID!)
## What changes were proposed in this pull reques
kardolus commented on code in PR #914:
URL: https://github.com/apache/knox/pull/914#discussion_r1640568668
##
gateway-server/src/main/java/org/apache/knox/gateway/GatewayServlet.java:
##
@@ -282,33 +281,15 @@ public Enumeration getInitParameterNames() {
}
}
- private
kardolus commented on code in PR #914:
URL: https://github.com/apache/knox/pull/914#discussion_r1640541031
##
gateway-server/src/main/java/org/apache/knox/gateway/GatewayServlet.java:
##
@@ -282,33 +281,15 @@ public Enumeration getInitParameterNames() {
}
}
- private
kardolus commented on code in PR #914:
URL: https://github.com/apache/knox/pull/914#discussion_r1640541031
##
gateway-server/src/main/java/org/apache/knox/gateway/GatewayServlet.java:
##
@@ -282,33 +281,15 @@ public Enumeration getInitParameterNames() {
}
}
- private
kardolus commented on code in PR #914:
URL: https://github.com/apache/knox/pull/914#discussion_r1640541031
##
gateway-server/src/main/java/org/apache/knox/gateway/GatewayServlet.java:
##
@@ -282,33 +281,15 @@ public Enumeration getInitParameterNames() {
}
}
- private
pzampino commented on code in PR #914:
URL: https://github.com/apache/knox/pull/914#discussion_r1639811375
##
gateway-server/src/main/java/org/apache/knox/gateway/GatewayServlet.java:
##
@@ -282,33 +281,15 @@ public Enumeration getInitParameterNames() {
}
}
- private
pzampino commented on PR #914:
URL: https://github.com/apache/knox/pull/914#issuecomment-2168011045
> @pzampino @moresandeep I implemented the `SanitizedException`. It makes
the code a lot cleaner. I am not happy with the fact though that an
`IOException` or a `RuntimeException` can be conv
kardolus commented on code in PR #914:
URL: https://github.com/apache/knox/pull/914#discussion_r1639761224
##
gateway-server/src/main/java/org/apache/knox/gateway/GatewayServlet.java:
##
@@ -282,33 +281,15 @@ public Enumeration getInitParameterNames() {
}
}
- private
pzampino commented on code in PR #914:
URL: https://github.com/apache/knox/pull/914#discussion_r1639056815
##
gateway-server/src/main/java/org/apache/knox/gateway/GatewayServlet.java:
##
@@ -282,33 +281,15 @@ public Enumeration getInitParameterNames() {
}
}
- private
smolnar82 commented on code in PR #914:
URL: https://github.com/apache/knox/pull/914#discussion_r1638622431
##
gateway-server/src/main/java/org/apache/knox/gateway/SanitizedException.java:
##
@@ -0,0 +1,9 @@
+package org.apache.knox.gateway;
Review Comment:
You need to add t
moresandeep merged PR #916:
URL: https://github.com/apache/knox/pull/916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
moresandeep opened a new pull request, #916:
URL: https://github.com/apache/knox/pull/916
## What changes were proposed in this pull request?
Minor changes to messages and added a unit test
--
This is an automated message from the Apache Git Service.
To respond to the messag
kardolus commented on PR #914:
URL: https://github.com/apache/knox/pull/914#issuecomment-2156049693
@pzampino @moresandeep I implemented the `SanitizedException`. It makes the
code a lot cleaner. I am not happy with the fact though that an `IOException`
can be converted to a `ServletExcepti
kardolus commented on code in PR #914:
URL: https://github.com/apache/knox/pull/914#discussion_r1632041927
##
gateway-server/src/main/java/org/apache/knox/gateway/GatewayServlet.java:
##
@@ -277,4 +278,34 @@ public Enumeration getInitParameterNames() {
return config.getIn
kardolus commented on code in PR #914:
URL: https://github.com/apache/knox/pull/914#discussion_r1632041927
##
gateway-server/src/main/java/org/apache/knox/gateway/GatewayServlet.java:
##
@@ -277,4 +278,34 @@ public Enumeration getInitParameterNames() {
return config.getIn
moresandeep merged PR #915:
URL: https://github.com/apache/knox/pull/915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
kardolus commented on PR #914:
URL: https://github.com/apache/knox/pull/914#issuecomment-2152733663
@moresandeep I think that is a great idea! I will start a discussion on the
Apache mailing list to explore implementing custom 4xx and 5xx error pages.
--
This is an automated message from
moresandeep commented on PR #914:
URL: https://github.com/apache/knox/pull/914#issuecomment-2152660341
It would be nice to have a 4xx and 5xx page for errors. So instead of
showing the ugly page with an exception we can show a custom page with a UUID
corresponding the the error. This UUID w
kardolus commented on PR #914:
URL: https://github.com/apache/knox/pull/914#issuecomment-2152623061
@moresandeep @pzampino Now that we made the pattern configurable, I am
wondering if it should be an array. I mean, now that you can create patterns
for [IP
addresses](https://github.com/kard
moresandeep opened a new pull request, #915:
URL: https://github.com/apache/knox/pull/915
## What changes were proposed in this pull request?
This PR adds the ability to validate a JWT token using multiple ways at the
same time. Previously, we could only authenticate JWT token using **eit
kardolus commented on code in PR #914:
URL: https://github.com/apache/knox/pull/914#discussion_r1629596054
##
gateway-server/src/main/java/org/apache/knox/gateway/GatewayServlet.java:
##
@@ -277,4 +278,34 @@ public Enumeration getInitParameterNames() {
return config.getIn
kardolus commented on code in PR #914:
URL: https://github.com/apache/knox/pull/914#discussion_r1627810537
##
gateway-server/src/main/java/org/apache/knox/gateway/GatewayServlet.java:
##
@@ -277,4 +278,34 @@ public Enumeration getInitParameterNames() {
return config.getIn
kardolus commented on code in PR #914:
URL: https://github.com/apache/knox/pull/914#discussion_r1626532127
##
gateway-server/src/main/java/org/apache/knox/gateway/GatewayServlet.java:
##
@@ -277,4 +278,34 @@ public Enumeration getInitParameterNames() {
return config.getIn
pzampino commented on code in PR #914:
URL: https://github.com/apache/knox/pull/914#discussion_r1626493087
##
gateway-server/src/main/java/org/apache/knox/gateway/GatewayServlet.java:
##
@@ -277,4 +278,34 @@ public Enumeration getInitParameterNames() {
return config.getIn
1 - 100 of 737 matches
Mail list logo
