[GitHub] [lucene-solr] thomaswoeckinger edited a comment on issue #855: SOLR-13739: Improve performance on huge schema updates

2019-09-09 Thread GitBox
thomaswoeckinger edited a comment on issue #855: SOLR-13739: Improve performance on huge schema updates URL: https://github.com/apache/lucene-solr/pull/855#issuecomment-529448374 > Overall looks good. Do "ant precommit" and "ant test" pass? Yes they pass. > I presume you did

[GitHub] [lucene-solr] thomaswoeckinger commented on a change in pull request #855: SOLR-13739: Improve performance on huge schema updates

2019-09-09 Thread GitBox
thomaswoeckinger commented on a change in pull request #855: SOLR-13739: Improve performance on huge schema updates URL: https://github.com/apache/lucene-solr/pull/855#discussion_r322213237 ## File path: solr/core/src/java/org/apache/solr/rest/RestManager.java ## @@ -76,7

[GitHub] [lucene-solr] thomaswoeckinger commented on issue #855: SOLR-13739: Improve performance on huge schema updates

2019-09-09 Thread GitBox
thomaswoeckinger commented on issue #855: SOLR-13739: Improve performance on huge schema updates URL: https://github.com/apache/lucene-solr/pull/855#issuecomment-529448374 > Overall looks good. Do "ant precommit" and "ant test" pass? > I presume you did manual inspection to see this has

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #855: SOLR-13739: Improve performance on huge schema updates

2019-09-09 Thread GitBox
dsmiley commented on a change in pull request #855: SOLR-13739: Improve performance on huge schema updates URL: https://github.com/apache/lucene-solr/pull/855#discussion_r322209342 ## File path: solr/core/src/java/org/apache/solr/rest/RestManager.java ## @@ -76,7 +76,7 @@

[GitHub] [lucene-solr] iverase merged pull request #771: LUCENE-8620: Update Tessellator logic to label if triangle edges belongs to the original polygon

2019-09-09 Thread GitBox
iverase merged pull request #771: LUCENE-8620: Update Tessellator logic to label if triangle edges belongs to the original polygon URL: https://github.com/apache/lucene-solr/pull/771 This is an automated message from the

[GitHub] [lucene-solr] thomaswoeckinger commented on issue #855: SOLR-13739: Improve performance on huge schema updates

2019-09-09 Thread GitBox
thomaswoeckinger commented on issue #855: SOLR-13739: Improve performance on huge schema updates URL: https://github.com/apache/lucene-solr/pull/855#issuecomment-529367883 @gerlowskija or @dsmiley: if anyone of you has time to review this very easy fix, that would be great

[GitHub] [lucene-solr] chatman commented on issue #863: SOLR-13677: reverting the last commit

2019-09-08 Thread GitBox
chatman commented on issue #863: SOLR-13677: reverting the last commit URL: https://github.com/apache/lucene-solr/pull/863#issuecomment-529239167 LGTM! This is an automated message from the Apache Git Service. To respond to

[GitHub] [lucene-solr] noblepaul opened a new pull request #863: SOLR-13677: reverting the last commit

2019-09-08 Thread GitBox
noblepaul opened a new pull request #863: SOLR-13677: reverting the last commit URL: https://github.com/apache/lucene-solr/pull/863 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [lucene-solr] msokolov opened a new pull request #862: LUCENE-8971: Enable constructing JapaneseTokenizer with custom dictio…

2019-09-06 Thread GitBox
msokolov opened a new pull request #862: LUCENE-8971: Enable constructing JapaneseTokenizer with custom dictio… URL: https://github.com/apache/lucene-solr/pull/862 …nary # Description Extends the API of JapaneseTokenizer so it can accept a dictionary other than the built-in

[GitHub] [lucene-solr] janhoy opened a new pull request #861: SOLR-10665 POC for a PF4J based plugin system

2019-09-06 Thread GitBox
janhoy opened a new pull request #861: SOLR-10665 POC for a PF4J based plugin system URL: https://github.com/apache/lucene-solr/pull/861 Creating PR for this old issue This is an automated message from the Apache Git

[GitHub] [lucene-solr] dsmiley commented on issue #828: LUCENE-8753: UniformSplitPostingsFormat

2019-09-06 Thread GitBox
dsmiley commented on issue #828: LUCENE-8753: UniformSplitPostingsFormat URL: https://github.com/apache/lucene-solr/pull/828#issuecomment-528935783 Merged: https://github.com/apache/lucene-solr/commit/b963b7c3dbecda86c2917ad341caee63b93815ac

[GitHub] [lucene-solr] dsmiley closed pull request #828: LUCENE-8753: UniformSplitPostingsFormat

2019-09-06 Thread GitBox
dsmiley closed pull request #828: LUCENE-8753: UniformSplitPostingsFormat URL: https://github.com/apache/lucene-solr/pull/828 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [lucene-solr] nknize commented on issue #771: LUCENE-8620: Update Tessellator logic to label if triangle edges belongs to the original polygon

2019-09-06 Thread GitBox
nknize commented on issue #771: LUCENE-8620: Update Tessellator logic to label if triangle edges belongs to the original polygon URL: https://github.com/apache/lucene-solr/pull/771#issuecomment-528893586 Awesome. LGTM! Thanks!

[GitHub] [lucene-solr] cpoerschke commented on issue #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)

2019-09-06 Thread GitBox
cpoerschke commented on issue #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch) URL: https://github.com/apache/lucene-solr/pull/300#issuecomment-528868837 > ... Will also annotate specific observations (and spoiler alert) one unexpected test failure

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)

2019-09-06 Thread GitBox
cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch) URL: https://github.com/apache/lucene-solr/pull/300#discussion_r321742912 ## File path:

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)

2019-09-06 Thread GitBox
cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch) URL: https://github.com/apache/lucene-solr/pull/300#discussion_r321740457 ## File path:

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)

2019-09-06 Thread GitBox
cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch) URL: https://github.com/apache/lucene-solr/pull/300#discussion_r321734947 ## File path:

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)

2019-09-06 Thread GitBox
cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch) URL: https://github.com/apache/lucene-solr/pull/300#discussion_r321732406 ## File path:

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)

2019-09-06 Thread GitBox
cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch) URL: https://github.com/apache/lucene-solr/pull/300#discussion_r321730287 ## File path:

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)

2019-09-06 Thread GitBox
cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch) URL: https://github.com/apache/lucene-solr/pull/300#discussion_r321726345 ## File path:

[GitHub] [lucene-solr] nknize commented on a change in pull request #771: LUCENE-8620: Update Tessellator logic to label if triangle edges belongs to the original polygon

2019-09-06 Thread GitBox
nknize commented on a change in pull request #771: LUCENE-8620: Update Tessellator logic to label if triangle edges belongs to the original polygon URL: https://github.com/apache/lucene-solr/pull/771#discussion_r321719110 ## File path:

[GitHub] [lucene-solr] nknize commented on a change in pull request #771: LUCENE-8620: Update Tessellator logic to label if triangle edges belongs to the original polygon

2019-09-06 Thread GitBox
nknize commented on a change in pull request #771: LUCENE-8620: Update Tessellator logic to label if triangle edges belongs to the original polygon URL: https://github.com/apache/lucene-solr/pull/771#discussion_r321719788 ## File path:

[GitHub] [lucene-solr] nknize commented on a change in pull request #771: LUCENE-8620: Update Tessellator logic to label if triangle edges belongs to the original polygon

2019-09-06 Thread GitBox
nknize commented on a change in pull request #771: LUCENE-8620: Update Tessellator logic to label if triangle edges belongs to the original polygon URL: https://github.com/apache/lucene-solr/pull/771#discussion_r321718297 ## File path:

[GitHub] [lucene-solr] nknize commented on a change in pull request #771: LUCENE-8620: Update Tessellator logic to label if triangle edges belongs to the original polygon

2019-09-06 Thread GitBox
nknize commented on a change in pull request #771: LUCENE-8620: Update Tessellator logic to label if triangle edges belongs to the original polygon URL: https://github.com/apache/lucene-solr/pull/771#discussion_r321718707 ## File path:

[GitHub] [lucene-solr] nknize commented on a change in pull request #771: LUCENE-8620: Update Tessellator logic to label if triangle edges belongs to the original polygon

2019-09-06 Thread GitBox
nknize commented on a change in pull request #771: LUCENE-8620: Update Tessellator logic to label if triangle edges belongs to the original polygon URL: https://github.com/apache/lucene-solr/pull/771#discussion_r321718778 ## File path:

[GitHub] [lucene-solr] nknize commented on a change in pull request #771: LUCENE-8620: Update Tessellator logic to label if triangle edges belongs to the original polygon

2019-09-06 Thread GitBox
nknize commented on a change in pull request #771: LUCENE-8620: Update Tessellator logic to label if triangle edges belongs to the original polygon URL: https://github.com/apache/lucene-solr/pull/771#discussion_r321718513 ## File path:

[GitHub] [lucene-solr] nknize commented on a change in pull request #771: LUCENE-8620: Update Tessellator logic to label if triangle edges belongs to the original polygon

2019-09-06 Thread GitBox
nknize commented on a change in pull request #771: LUCENE-8620: Update Tessellator logic to label if triangle edges belongs to the original polygon URL: https://github.com/apache/lucene-solr/pull/771#discussion_r321719001 ## File path:

[GitHub] [lucene-solr] nknize commented on a change in pull request #771: LUCENE-8620: Update Tessellator logic to label if triangle edges belongs to the original polygon

2019-09-06 Thread GitBox
nknize commented on a change in pull request #771: LUCENE-8620: Update Tessellator logic to label if triangle edges belongs to the original polygon URL: https://github.com/apache/lucene-solr/pull/771#discussion_r321718163 ## File path:

[GitHub] [lucene-solr] nknize commented on a change in pull request #771: LUCENE-8620: Update Tessellator logic to label if triangle edges belongs to the original polygon

2019-09-06 Thread GitBox
nknize commented on a change in pull request #771: LUCENE-8620: Update Tessellator logic to label if triangle edges belongs to the original polygon URL: https://github.com/apache/lucene-solr/pull/771#discussion_r321721428 ## File path:

[GitHub] [lucene-solr] nknize commented on a change in pull request #771: LUCENE-8620: Update Tessellator logic to label if triangle edges belongs to the original polygon

2019-09-06 Thread GitBox
nknize commented on a change in pull request #771: LUCENE-8620: Update Tessellator logic to label if triangle edges belongs to the original polygon URL: https://github.com/apache/lucene-solr/pull/771#discussion_r321718423 ## File path:

[GitHub] [lucene-solr] nknize commented on a change in pull request #771: LUCENE-8620: Update Tessellator logic to label if triangle edges belongs to the original polygon

2019-09-06 Thread GitBox
nknize commented on a change in pull request #771: LUCENE-8620: Update Tessellator logic to label if triangle edges belongs to the original polygon URL: https://github.com/apache/lucene-solr/pull/771#discussion_r321722381 ## File path:

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)

2019-09-06 Thread GitBox
cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch) URL: https://github.com/apache/lucene-solr/pull/300#discussion_r321724239 ## File path:

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)

2019-09-06 Thread GitBox
cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch) URL: https://github.com/apache/lucene-solr/pull/300#discussion_r321722336 ## File path: solr/solr-ref-guide/src/result-grouping.adoc ##

[GitHub] [lucene-solr] cpoerschke commented on issue #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)

2019-09-06 Thread GitBox
cpoerschke commented on issue #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch) URL: https://github.com/apache/lucene-solr/pull/300#issuecomment-528843185 Thanks @diegoceccarelli for the pushes and the documentation additions too! > ... precommit

[GitHub] [lucene-solr] janhoy commented on issue #860: SOLR-13734 JWTAuthPlugin to support multiple issuers

2019-09-06 Thread GitBox
janhoy commented on issue #860: SOLR-13734 JWTAuthPlugin to support multiple issuers URL: https://github.com/apache/lucene-solr/pull/860#issuecomment-528818950 Reviewers: This PR includes changes from #852 and therefore looks bigger than it is. A diff between the two can be seen here:

[GitHub] [lucene-solr] janhoy opened a new pull request #860: SOLR-13734 JWTAuthPlugin to support multiple issuers

2019-09-06 Thread GitBox
janhoy opened a new pull request #860: SOLR-13734 JWTAuthPlugin to support multiple issuers URL: https://github.com/apache/lucene-solr/pull/860 # Description See https://issues.apache.org/jira/browse/SOLR-13734 # Checklist Please review the following and check all that

[GitHub] [lucene-solr] iverase commented on issue #857: LUCENE-8968: Improve performance of WITHIN and DISJOINT queries for Shape queries

2019-09-06 Thread GitBox
iverase commented on issue #857: LUCENE-8968: Improve performance of WITHIN and DISJOINT queries for Shape queries URL: https://github.com/apache/lucene-solr/pull/857#issuecomment-528770584 I have run the performance benchmark defined

[GitHub] [lucene-solr] noblepaul opened a new pull request #859: SOLR-13731: javabin must support a 1:1 mapping of the JSON update format

2019-09-05 Thread GitBox
noblepaul opened a new pull request #859: SOLR-13731: javabin must support a 1:1 mapping of the JSON update format URL: https://github.com/apache/lucene-solr/pull/859 This is an automated message from the Apache Git

[GitHub] [lucene-solr] jpountz commented on issue #858: Harden Up TestDiversifiedTopDocsCollector

2019-09-05 Thread GitBox
jpountz commented on issue #858: Harden Up TestDiversifiedTopDocsCollector URL: https://github.com/apache/lucene-solr/pull/858#issuecomment-528489114 Thanks @atris. This is an automated message from the Apache Git Service. To

[GitHub] [lucene-solr] jpountz merged pull request #858: Harden Up TestDiversifiedTopDocsCollector

2019-09-05 Thread GitBox
jpountz merged pull request #858: Harden Up TestDiversifiedTopDocsCollector URL: https://github.com/apache/lucene-solr/pull/858 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [lucene-solr] atris commented on issue #769: LUCENE-8905: Better Error Handling For Illegal Arguments

2019-09-05 Thread GitBox
atris commented on issue #769: LUCENE-8905: Better Error Handling For Illegal Arguments URL: https://github.com/apache/lucene-solr/pull/769#issuecomment-528487667 > TestDiversifiedTopDocsCollector Thanks for taking a look. The test failure is not really a code issue but a test

[GitHub] [lucene-solr] atris opened a new pull request #858: Harden Up TestDiversifiedTopDocsCollector

2019-09-05 Thread GitBox
atris opened a new pull request #858: Harden Up TestDiversifiedTopDocsCollector URL: https://github.com/apache/lucene-solr/pull/858 TestDiversifiedTopDocsCollector.testInvalidArguments should check for exceptions and corresponding messages, post LUCENE-8905

[GitHub] [lucene-solr] jpountz commented on issue #769: LUCENE-8905: Better Error Handling For Illegal Arguments

2019-09-05 Thread GitBox
jpountz commented on issue #769: LUCENE-8905: Better Error Handling For Illegal Arguments URL: https://github.com/apache/lucene-solr/pull/769#issuecomment-528440603 I'm seeing test failures such as ``` 17:50:42[junit4] Suite:

[GitHub] [lucene-solr] iverase commented on issue #857: LUCENE-8968: Improve performance of WITHIN and DISJOINT queries for Shape queries

2019-09-05 Thread GitBox
iverase commented on issue #857: LUCENE-8968: Improve performance of WITHIN and DISJOINT queries for Shape queries URL: https://github.com/apache/lucene-solr/pull/857#issuecomment-528425823 Thanks @jpountz , I agree we should not be keeping a state in the visitor. I updated the PR going

[GitHub] [lucene-solr] jpountz merged pull request #769: LUCENE-8905: Better Error Handling For Illegal Arguments

2019-09-05 Thread GitBox
jpountz merged pull request #769: LUCENE-8905: Better Error Handling For Illegal Arguments URL: https://github.com/apache/lucene-solr/pull/769 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene-solr] jpountz commented on a change in pull request #857: LUCENE-8968: Improve performance of WITHIN and DISJOINT queries for Shape queries

2019-09-05 Thread GitBox
jpountz commented on a change in pull request #857: LUCENE-8968: Improve performance of WITHIN and DISJOINT queries for Shape queries URL: https://github.com/apache/lucene-solr/pull/857#discussion_r321278855 ## File path:

[GitHub] [lucene-solr] jpountz commented on a change in pull request #857: LUCENE-8968: Improve performance of WITHIN and DISJOINT queries for Shape queries

2019-09-05 Thread GitBox
jpountz commented on a change in pull request #857: LUCENE-8968: Improve performance of WITHIN and DISJOINT queries for Shape queries URL: https://github.com/apache/lucene-solr/pull/857#discussion_r321276057 ## File path:

[GitHub] [lucene-solr] iverase opened a new pull request #857: LUCENE-8968: Improve performance of WITHIN and DISJOINT queries for Shape queries

2019-09-05 Thread GitBox
iverase opened a new pull request #857: LUCENE-8968: Improve performance of WITHIN and DISJOINT queries for Shape queries URL: https://github.com/apache/lucene-solr/pull/857 We are currently walking the tree twice for INTERSECTS and WITHIN queries in ShapeQuery when we can do it in just

[GitHub] [lucene-solr] atris commented on issue #769: LUCENE-8905: Better Error Handling For Illegal Arguments

2019-09-05 Thread GitBox
atris commented on issue #769: LUCENE-8905: Better Error Handling For Illegal Arguments URL: https://github.com/apache/lucene-solr/pull/769#issuecomment-528333650 @jpountz Updated the PR. Ran the test suite, came in clean. Also, beasted `TestGrouping` 20 times, ran clean.

[GitHub] [lucene-solr] jpountz commented on issue #769: LUCENE-8905: Better Error Handling For Illegal Arguments

2019-09-05 Thread GitBox
jpountz commented on issue #769: LUCENE-8905: Better Error Handling For Illegal Arguments URL: https://github.com/apache/lucene-solr/pull/769#issuecomment-528328729 Hmm I got confused indeed, we shouldn't check that start is less than howMany since howMany is not the rank of the last

[GitHub] [lucene-solr] atris commented on issue #769: LUCENE-8905: Better Error Handling For Illegal Arguments

2019-09-05 Thread GitBox
atris commented on issue #769: LUCENE-8905: Better Error Handling For Illegal Arguments URL: https://github.com/apache/lucene-solr/pull/769#issuecomment-528310009 @jpountz Thinking more about this, should we be asserting if howMany is greater than start? Would that still be true for

[GitHub] [lucene-solr] jpountz commented on issue #769: LUCENE-8905: Better Error Handling For Illegal Arguments

2019-09-05 Thread GitBox
jpountz commented on issue #769: LUCENE-8905: Better Error Handling For Illegal Arguments URL: https://github.com/apache/lucene-solr/pull/769#issuecomment-528264657 Could you confirm all tests pass now, including the grouping ones that failed previously?

[GitHub] [lucene-solr] atris commented on a change in pull request #769: LUCENE-8905: Better Error Handling For Illegal Arguments

2019-09-05 Thread GitBox
atris commented on a change in pull request #769: LUCENE-8905: Better Error Handling For Illegal Arguments URL: https://github.com/apache/lucene-solr/pull/769#discussion_r321140473 ## File path: lucene/core/src/java/org/apache/lucene/search/TopDocsCollector.java ## @@

[GitHub] [lucene-solr] jpountz commented on a change in pull request #769: LUCENE-8905: Better Error Handling For Illegal Arguments

2019-09-05 Thread GitBox
jpountz commented on a change in pull request #769: LUCENE-8905: Better Error Handling For Illegal Arguments URL: https://github.com/apache/lucene-solr/pull/769#discussion_r321139006 ## File path: lucene/core/src/java/org/apache/lucene/search/TopDocsCollector.java ## @@

[GitHub] [lucene-solr] jpountz commented on a change in pull request #769: LUCENE-8905: Better Error Handling For Illegal Arguments

2019-09-05 Thread GitBox
jpountz commented on a change in pull request #769: LUCENE-8905: Better Error Handling For Illegal Arguments URL: https://github.com/apache/lucene-solr/pull/769#discussion_r321139330 ## File path: lucene/core/src/java/org/apache/lucene/search/TopDocsCollector.java ## @@

[GitHub] [lucene-solr] jpountz commented on a change in pull request #769: LUCENE-8905: Better Error Handling For Illegal Arguments

2019-09-05 Thread GitBox
jpountz commented on a change in pull request #769: LUCENE-8905: Better Error Handling For Illegal Arguments URL: https://github.com/apache/lucene-solr/pull/769#discussion_r321138932 ## File path: lucene/core/src/java/org/apache/lucene/search/TopDocsCollector.java ## @@

[GitHub] [lucene-solr] atris commented on issue #823: LUCENE-8939: Introduce Shared Count Early Termination In Parallel Search

2019-09-05 Thread GitBox
atris commented on issue #823: LUCENE-8939: Introduce Shared Count Early Termination In Parallel Search URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-528262274 Thank you for merging and reviewing, @jpountz ! and thank you @jimczi and @mikemccand for reviewing!

[GitHub] [lucene-solr] atris commented on issue #769: LUCENE-8905: Better Error Handling For Illegal Arguments

2019-09-05 Thread GitBox
atris commented on issue #769: LUCENE-8905: Better Error Handling For Illegal Arguments URL: https://github.com/apache/lucene-solr/pull/769#issuecomment-528260449 @jpountz Updated, please see This is an automated message

[GitHub] [lucene-solr] jpountz merged pull request #823: LUCENE-8939: Introduce Shared Count Early Termination In Parallel Search

2019-09-05 Thread GitBox
jpountz merged pull request #823: LUCENE-8939: Introduce Shared Count Early Termination In Parallel Search URL: https://github.com/apache/lucene-solr/pull/823 This is an automated message from the Apache Git Service. To

[GitHub] [lucene-solr] atris commented on issue #854: Shared PQ Based Early Termination for Concurrent Search

2019-09-05 Thread GitBox
atris commented on issue #854: Shared PQ Based Early Termination for Concurrent Search URL: https://github.com/apache/lucene-solr/pull/854#issuecomment-528247486 > I thought that the follow up for LUCENE-8939 would be to allow the sharing of the minimum score (could be extended to a

[GitHub] [lucene-solr] atris commented on issue #816: LUCENE-8942: Tighten Up LRUQueryCache's Methods

2019-09-05 Thread GitBox
atris commented on issue #816: LUCENE-8942: Tighten Up LRUQueryCache's Methods URL: https://github.com/apache/lucene-solr/pull/816#issuecomment-528242381 Thank you for merging! This is an automated message from the Apache Git

[GitHub] [lucene-solr] jpountz merged pull request #816: LUCENE-8942: Tighten Up LRUQueryCache's Methods

2019-09-05 Thread GitBox
jpountz merged pull request #816: LUCENE-8942: Tighten Up LRUQueryCache's Methods URL: https://github.com/apache/lucene-solr/pull/816 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [lucene-solr] jpountz commented on issue #816: LUCENE-8942: Tighten Up LRUQueryCache's Methods

2019-09-05 Thread GitBox
jpountz commented on issue #816: LUCENE-8942: Tighten Up LRUQueryCache's Methods URL: https://github.com/apache/lucene-solr/pull/816#issuecomment-528239928 This looks great. This is an automated message from the Apache Git

[GitHub] [lucene-solr] atris commented on issue #816: LUCENE-8942: Tighten Up LRUQueryCache's Methods

2019-09-05 Thread GitBox
atris commented on issue #816: LUCENE-8942: Tighten Up LRUQueryCache's Methods URL: https://github.com/apache/lucene-solr/pull/816#issuecomment-528239294 @jpountz Updated, please let me know if it looks fine This is an

[GitHub] [lucene-solr] atris commented on issue #823: LUCENE-8939: Introduce Shared Count Early Termination In Parallel Search

2019-09-05 Thread GitBox
atris commented on issue #823: LUCENE-8939: Introduce Shared Count Early Termination In Parallel Search URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-528237811 Thanks for approving, @mikemccand ! @jpountz , @jimczi Does this look ok to merge now?

[GitHub] [lucene-solr] atris commented on issue #816: LUCENE-8942: Tighten Up LRUQueryCache's Methods

2019-09-05 Thread GitBox
atris commented on issue #816: LUCENE-8942: Tighten Up LRUQueryCache's Methods URL: https://github.com/apache/lucene-solr/pull/816#issuecomment-528235852 Yeah, I will move it in this PR itself -- sorry, this one fell off my radar.

[GitHub] [lucene-solr] jpountz commented on issue #816: LUCENE-8942: Tighten Up LRUQueryCache's Methods

2019-09-05 Thread GitBox
jpountz commented on issue #816: LUCENE-8942: Tighten Up LRUQueryCache's Methods URL: https://github.com/apache/lucene-solr/pull/816#issuecomment-528225965 To avoid any confusion, I was expecting you would move the CHANGES entry on this PR rather than after the merge.

[GitHub] [lucene-solr] jpountz merged pull request #775: LUCENE-8910: upgrade to icu 62.1 must be completed

2019-09-05 Thread GitBox
jpountz merged pull request #775: LUCENE-8910: upgrade to icu 62.1 must be completed URL: https://github.com/apache/lucene-solr/pull/775 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [lucene-solr] jpountz commented on a change in pull request #769: LUCENE-8905: Better Error Handling For Illegal Arguments

2019-09-05 Thread GitBox
jpountz commented on a change in pull request #769: LUCENE-8905: Better Error Handling For Illegal Arguments URL: https://github.com/apache/lucene-solr/pull/769#discussion_r321097309 ## File path: lucene/core/src/java/org/apache/lucene/search/TopDocsCollector.java ## @@

[GitHub] [lucene-solr] jpountz commented on a change in pull request #769: LUCENE-8905: Better Error Handling For Illegal Arguments

2019-09-05 Thread GitBox
jpountz commented on a change in pull request #769: LUCENE-8905: Better Error Handling For Illegal Arguments URL: https://github.com/apache/lucene-solr/pull/769#discussion_r321097236 ## File path: lucene/core/src/java/org/apache/lucene/search/TopDocsCollector.java ## @@

[GitHub] [lucene-solr] jpountz commented on a change in pull request #769: LUCENE-8905: Better Error Handling For Illegal Arguments

2019-09-05 Thread GitBox
jpountz commented on a change in pull request #769: LUCENE-8905: Better Error Handling For Illegal Arguments URL: https://github.com/apache/lucene-solr/pull/769#discussion_r321098166 ## File path: lucene/core/src/java/org/apache/lucene/search/TopDocsCollector.java ## @@

[GitHub] [lucene-solr] gus-asf commented on a change in pull request #838: SOLR-13705 Double-checked locking bug is fixed.

2019-09-04 Thread GitBox
gus-asf commented on a change in pull request #838: SOLR-13705 Double-checked locking bug is fixed. URL: https://github.com/apache/lucene-solr/pull/838#discussion_r321052124 ## File path: solr/core/src/java/org/apache/solr/handler/admin/SecurityConfHandler.java ## @@

[GitHub] [lucene-solr] gus-asf commented on a change in pull request #838: SOLR-13705 Double-checked locking bug is fixed.

2019-09-04 Thread GitBox
gus-asf commented on a change in pull request #838: SOLR-13705 Double-checked locking bug is fixed. URL: https://github.com/apache/lucene-solr/pull/838#discussion_r321052124 ## File path: solr/core/src/java/org/apache/solr/handler/admin/SecurityConfHandler.java ## @@

[GitHub] [lucene-solr] gus-asf commented on a change in pull request #838: SOLR-13705 Double-checked locking bug is fixed.

2019-09-04 Thread GitBox
gus-asf commented on a change in pull request #838: SOLR-13705 Double-checked locking bug is fixed. URL: https://github.com/apache/lucene-solr/pull/838#discussion_r321050856 ## File path: solr/core/src/java/org/apache/solr/handler/admin/SecurityConfHandler.java ## @@

[GitHub] [lucene-solr] gus-asf commented on a change in pull request #838: SOLR-13705 Double-checked locking bug is fixed.

2019-09-04 Thread GitBox
gus-asf commented on a change in pull request #838: SOLR-13705 Double-checked locking bug is fixed. URL: https://github.com/apache/lucene-solr/pull/838#discussion_r321050532 ## File path: solr/core/src/java/org/apache/solr/handler/admin/SecurityConfHandler.java ## @@

[GitHub] [lucene-solr] gus-asf commented on a change in pull request #838: SOLR-13705 Double-checked locking bug is fixed.

2019-09-04 Thread GitBox
gus-asf commented on a change in pull request #838: SOLR-13705 Double-checked locking bug is fixed. URL: https://github.com/apache/lucene-solr/pull/838#discussion_r321050532 ## File path: solr/core/src/java/org/apache/solr/handler/admin/SecurityConfHandler.java ## @@

[GitHub] [lucene-solr] gus-asf commented on a change in pull request #838: SOLR-13705 Double-checked locking bug is fixed.

2019-09-04 Thread GitBox
gus-asf commented on a change in pull request #838: SOLR-13705 Double-checked locking bug is fixed. URL: https://github.com/apache/lucene-solr/pull/838#discussion_r321050511 ## File path: solr/core/src/java/org/apache/solr/handler/admin/SecurityConfHandler.java ## @@

[GitHub] [lucene-solr] yonik commented on issue #850: SOLR-13727: Bug fix for V2Request handling in HttpSolrClient

2019-09-04 Thread GitBox
yonik commented on issue #850: SOLR-13727: Bug fix for V2Request handling in HttpSolrClient URL: https://github.com/apache/lucene-solr/pull/850#issuecomment-528167851 Committed manually to master & 8x. Thanks Megan! This is

[GitHub] [lucene-solr] yonik closed pull request #850: SOLR-13727: Bug fix for V2Request handling in HttpSolrClient

2019-09-04 Thread GitBox
yonik closed pull request #850: SOLR-13727: Bug fix for V2Request handling in HttpSolrClient URL: https://github.com/apache/lucene-solr/pull/850 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene-solr] gus-asf commented on a change in pull request #838: SOLR-13705 Double-checked locking bug is fixed.

2019-09-04 Thread GitBox
gus-asf commented on a change in pull request #838: SOLR-13705 Double-checked locking bug is fixed. URL: https://github.com/apache/lucene-solr/pull/838#discussion_r321050422 ## File path: solr/core/src/java/org/apache/solr/handler/admin/SecurityConfHandler.java ## @@

[GitHub] [lucene-solr] yonik commented on a change in pull request #850: SOLR-13727: Bug fix for V2Request handling in HttpSolrClient

2019-09-04 Thread GitBox
yonik commented on a change in pull request #850: SOLR-13727: Bug fix for V2Request handling in HttpSolrClient URL: https://github.com/apache/lucene-solr/pull/850#discussion_r321048686 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClient.java

[GitHub] [lucene-solr] gus-asf commented on a change in pull request #856: LUCENE-8965 SometimesConcurrentMergeScheduler

2019-09-04 Thread GitBox
gus-asf commented on a change in pull request #856: LUCENE-8965 SometimesConcurrentMergeScheduler URL: https://github.com/apache/lucene-solr/pull/856#discussion_r321035131 ## File path: lucene/core/src/java/org/apache/lucene/index/SometimesConcurrentMergeScheduler.java ##

[GitHub] [lucene-solr] gus-asf commented on a change in pull request #856: LUCENE-8965 SometimesConcurrentMergeScheduler

2019-09-04 Thread GitBox
gus-asf commented on a change in pull request #856: LUCENE-8965 SometimesConcurrentMergeScheduler URL: https://github.com/apache/lucene-solr/pull/856#discussion_r321034932 ## File path: lucene/core/src/java/org/apache/lucene/index/SometimesConcurrentMergeScheduler.java ##

[GitHub] [lucene-solr] rmuir commented on issue #775: LUCENE-8910: upgrade to icu 62.1 must be completed

2019-09-04 Thread GitBox
rmuir commented on issue #775: LUCENE-8910: upgrade to icu 62.1 must be completed URL: https://github.com/apache/lucene-solr/pull/775#issuecomment-528146605 looks good to me. This is an automated message from the Apache Git

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #823: LUCENE-8939: Introduce Shared Count Early Termination In Parallel Search

2019-09-04 Thread GitBox
mikemccand commented on a change in pull request #823: LUCENE-8939: Introduce Shared Count Early Termination In Parallel Search URL: https://github.com/apache/lucene-solr/pull/823#discussion_r320956707 ## File path:

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #823: LUCENE-8939: Introduce Shared Count Early Termination In Parallel Search

2019-09-04 Thread GitBox
mikemccand commented on a change in pull request #823: LUCENE-8939: Introduce Shared Count Early Termination In Parallel Search URL: https://github.com/apache/lucene-solr/pull/823#discussion_r320956589 ## File path:

[GitHub] [lucene-solr] dsmiley opened a new pull request #856: LUCENE-8965 SometimesConcurrentMergeScheduler

2019-09-04 Thread GitBox
dsmiley opened a new pull request #856: LUCENE-8965 SometimesConcurrentMergeScheduler URL: https://github.com/apache/lucene-solr/pull/856 The initial version here is copied with simple modifications from one I wrote at Salesforce. I do not propose we actually commit this version, it's

[GitHub] [lucene-solr] jimczi commented on issue #854: Shared PQ Based Early Termination for Concurrent Search

2019-09-04 Thread GitBox
jimczi commented on issue #854: Shared PQ Based Early Termination for Concurrent Search URL: https://github.com/apache/lucene-solr/pull/854#issuecomment-528035227 I thought that the follow up for LUCENE-8939 would be to allow the sharing of the minimum score (could be extended to a

[GitHub] [lucene-solr] dsmiley commented on issue #828: LUCENE-8753: UniformSplitPostingsFormat

2019-09-04 Thread GitBox
dsmiley commented on issue #828: LUCENE-8753: UniformSplitPostingsFormat URL: https://github.com/apache/lucene-solr/pull/828#issuecomment-527974721 Thanks; looks good Bruno. This is an automated message from the Apache Git

[GitHub] [lucene-solr] bruno-roustant closed pull request #676: LUCENE-8753: SharedTerms UniformSplit

2019-09-04 Thread GitBox
bruno-roustant closed pull request #676: LUCENE-8753: SharedTerms UniformSplit URL: https://github.com/apache/lucene-solr/pull/676 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [lucene-solr] bruno-roustant commented on issue #676: LUCENE-8753: SharedTerms UniformSplit

2019-09-04 Thread GitBox
bruno-roustant commented on issue #676: LUCENE-8753: SharedTerms UniformSplit URL: https://github.com/apache/lucene-solr/pull/676#issuecomment-527962140 Moved to #828 so I am closing this. This is an automated message from

[GitHub] [lucene-solr] bruno-roustant commented on issue #828: LUCENE-8753: UniformSplitPostingsFormat

2019-09-04 Thread GitBox
bruno-roustant commented on issue #828: LUCENE-8753: UniformSplitPostingsFormat URL: https://github.com/apache/lucene-solr/pull/828#issuecomment-527941283 I added a new commit to integrate SharedTerms (same as PR#676 now obsolete). It also fixes the lack of BlockEncoder for the FST.

[GitHub] [lucene-solr] dsmiley commented on issue #838: SOLR-13705 Double-checked locking bug is fixed.

2019-09-04 Thread GitBox
dsmiley commented on issue #838: SOLR-13705 Double-checked locking bug is fixed. URL: https://github.com/apache/lucene-solr/pull/838#issuecomment-527874693 +1 to the code you have here. This is an automated message from the

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #797: LUCENE-8921: IndexSearcher.termStatistics requires docFreq totalTermFreq instead of TermStates

2019-09-04 Thread GitBox
bruno-roustant commented on a change in pull request #797: LUCENE-8921: IndexSearcher.termStatistics requires docFreq totalTermFreq instead of TermStates URL: https://github.com/apache/lucene-solr/pull/797#discussion_r320722038 ## File path:

[GitHub] [lucene-solr] jpountz commented on a change in pull request #797: LUCENE-8921: IndexSearcher.termStatistics requires docFreq totalTermFreq instead of TermStates

2019-09-04 Thread GitBox
jpountz commented on a change in pull request #797: LUCENE-8921: IndexSearcher.termStatistics requires docFreq totalTermFreq instead of TermStates URL: https://github.com/apache/lucene-solr/pull/797#discussion_r320717177 ## File path:

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #797: LUCENE-8921: IndexSearcher.termStatistics requires docFreq totalTermFreq instead of TermStates

2019-09-04 Thread GitBox
dsmiley commented on a change in pull request #797: LUCENE-8921: IndexSearcher.termStatistics requires docFreq totalTermFreq instead of TermStates URL: https://github.com/apache/lucene-solr/pull/797#discussion_r320713838 ## File path:

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #797: LUCENE-8921: IndexSearcher.termStatistics requires docFreq totalTermFreq instead of TermStates

2019-09-04 Thread GitBox
dsmiley commented on a change in pull request #797: LUCENE-8921: IndexSearcher.termStatistics requires docFreq totalTermFreq instead of TermStates URL: https://github.com/apache/lucene-solr/pull/797#discussion_r320713047 ## File path:

[GitHub] [lucene-solr] thomaswoeckinger opened a new pull request #855: SOLR-13739: Improve performance on huge schema updates

2019-09-04 Thread GitBox
thomaswoeckinger opened a new pull request #855: SOLR-13739: Improve performance on huge schema updates URL: https://github.com/apache/lucene-solr/pull/855 Affects schemas containing ResourceLoaderAware components, increases creation of a new collection with a huge schema by a factor 60

[GitHub] [lucene-solr] atris commented on issue #854: Shared PQ Based Early Termination for Concurrent Search

2019-09-04 Thread GitBox
atris commented on issue #854: Shared PQ Based Early Termination for Concurrent Search URL: https://github.com/apache/lucene-solr/pull/854#issuecomment-527823824 cc @jpountz. This PR builds on top of #831 This is an

[GitHub] [lucene-solr] atris opened a new pull request #854: Shared PQ Based Early Termination for Concurrent Search

2019-09-04 Thread GitBox
atris opened a new pull request #854: Shared PQ Based Early Termination for Concurrent Search URL: https://github.com/apache/lucene-solr/pull/854 NOCOMMIT. This is a WIP PR which implements a shared PQ based early termination. Each collector collects independently into a thread

<    1   2   3   4   5   6   7   8   9   10   >