Build failed in Jenkins: mesos-reviewbot #809

See -- [URLTrigger] A change within the response URL invocation (log) Building remotely on ubuntu3 (Ubuntu ubuntu) in workspace > git rev-parse --is-in

Review Request 22257: Fixed spelling of "Authentication" in 0.19 CHANGELOG

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22257/ --- Review request for mesos and Ben Mahler. Repository: mesos-git Description --

Re: Review Request 22257: Fixed spelling of "Authentication" in 0.19 CHANGELOG

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22257/#review44802 --- Ship it! Ship It! - Vinod Kone On June 5, 2014, 6:45 a.m., Adam

Build failed in Jenkins: mesos-reviewbot #808

See -- [URLTrigger] A change within the response URL invocation (log) Building remotely on ubuntu4 (Ubuntu ubuntu) in workspace > git rev-parse --is-in

Re: Review Request 22224: Added an abstraction for launching operations in a subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/ --- (Updated June 5, 2014, 5:57 a.m.) Review request for mesos, Benjamin Hindman, I

Build failed in Jenkins: mesos-reviewbot #807

See -- [...truncated 343 lines...] Removing src/linux/routing/link/.deps/ Removing src/linux/routing/queueing/.deps/ Removing src/local/.deps/ Removing src/local/.dirstamp Removing src/local/.libs/ Removin

Re: Review Request 22224: Added an abstraction for launching operations in a subprocess.

> On June 4, 2014, 6:13 p.m., Vinod Kone wrote: > > src/Makefile.am, line 200 > > > > > > we already use "launcher" in containerizer. can we use some other name > > for this to avoid confusion? how about operator? or

Build failed in Jenkins: mesos-reviewbot #806

See -- [URLTrigger] A change within the response URL invocation (log) Building remotely on ubuntu2 (Ubuntu ubuntu) in workspace > git rev-parse --is-in

Re: Review Request 22160: Added setns utilities to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22160/ --- (Updated June 5, 2014, 4:33 a.m.) Review request for mesos, Ben Mahler, Ian Dow

[jira] [Comment Edited] (MESOS-886) Slave should wait until resources are isolated before launching tasks

[ https://issues.apache.org/jira/browse/MESOS-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018398#comment-14018398 ] Yifan Gu edited comment on MESOS-886 at 6/5/14 1:25 AM: I see. I th

[jira] [Commented] (MESOS-886) Slave should wait until resources are isolated before launching tasks

[ https://issues.apache.org/jira/browse/MESOS-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018398#comment-14018398 ] Yifan Gu commented on MESOS-886: I see. I think what I will do this this issue is very clos

Build failed in Jenkins: mesos-reviewbot #805

See Changes: [niklas] Prevented slave from (re-)registering when TERMINATING. -- [...truncated 390 lines...] Removing src/log/tool/liblog_la-read.o Removing src/log/tool/liblog_la-replica.lo Remov

Re: Review Request 22250: A one-off fix for MESOS-1456: it ties the lifetime of metrics in SchedulerProcess to its runstate and not lifetime.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22250/#review44786 --- Dominic and I went over this together and it seems this does not fix

[jira] [Commented] (MESOS-1456) Metric lifetime should be tied to process runstate, not lifetime.

[ https://issues.apache.org/jira/browse/MESOS-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018375#comment-14018375 ] Benjamin Mahler commented on MESOS-1456: To generalize a bit, there are some curre

[jira] [Created] (MESOS-1458) Restore "cpus" metric in addition to cpu_*_secs counters in container stats

Kevin Sweeney created MESOS-1458: Summary: Restore "cpus" metric in addition to cpu_*_secs counters in container stats Key: MESOS-1458 URL: https://issues.apache.org/jira/browse/MESOS-1458 Project: Me

Re: Review Request 21968: MESOS-878: Prevented slave from (re-)registering when TERMINATING.

I highly recommend using the git pre-commit hook. $ ln -s ../../support/hooks/pre-commit .git/hooks/pre-commit On Wed, Jun 4, 2014 at 4:58 PM, Yifan Gu wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21968/ > Review request for mesos, Ad

Re: Review Request 22148: Fixed a bug in scheduler driver to properly erase 'savedOffers'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22148/#review44785 --- Patch looks great! Reviews applied: [22148] All tests passed. - M

Jenkins build is back to normal : mesos-reviewbot #804

See

Re: Review Request 22223: MESOS-1312: Added orphan_tasks and unknown_frameworks in state.json

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3/ --- (Updated June 5, 2014, 12:23 a.m.) Review request for mesos, Adam B, Niklas Nie

Re: Review Request 22223: MESOS-1312: Added orphan_tasks and unknown_frameworks in state.json

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3/ --- (Updated June 5, 2014, 12:17 a.m.) Review request for mesos, Adam B, Niklas Nie

Re: Review Request 22251: Give the command executor some cpu and memory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22251/ --- (Updated June 4, 2014, 5:15 p.m.) Review request for mesos, Ben Mahler, Jie Yu,

Re: Review Request 22252: Change MesosContainerizer::update to not return failure for unknown container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22252/ --- (Updated June 4, 2014, 5:16 p.m.) Review request for mesos, Ben Mahler, Jie Yu,

Re: Review Request 22160: Added setns utilities to stout.

> On June 4, 2014, 6:47 p.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/setns.hpp, line 41 > > > > > > This is true for all namespaces *except* PID namespaces where setns() > > means tha

Re: Review Request 22255: Style fixed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22255/#review44782 --- Ship it! Thanks for fixing these! - Adam B On June 4, 2014, 5:09

Jenkins build is back to normal : Mesos-Ubuntu-distcheck #117

See

Re: Review Request 22255: Style fixed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22255/ --- (Updated June 5, 2014, 12:09 a.m.) Review request for mesos, Adam B, Niklas Nie

Re: Review Request 22251: Give the command executor some cpu and memory.

> On June 4, 2014, 4:37 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 2304 > > > > > > pull these out into constants. > > > > DEFAULT_EXECUTOR_CPUS > > DEFAULT_EXECUTOR_MEM > > > > Also t

Re: Review Request 21968: MESOS-878: Prevented slave from (re-)registering when TERMINATING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21968/ --- (Updated June 4, 2014, 11:58 p.m.) Review request for mesos, Adam B, Niklas Nie

[jira] [Commented] (MESOS-1456) Metric lifetime should be tied to process runstate, not lifetime.

[ https://issues.apache.org/jira/browse/MESOS-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018348#comment-14018348 ] Dominic Hamon commented on MESOS-1456: -- Moving metric add/remove to initialize/finali

Re: Review Request 22252: Change MesosContainerizer::update to not return failure for unknown container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22252/#review44777 --- Ship it! src/slave/containerizer/mesos_containerizer.cpp

[jira] [Commented] (MESOS-1417) Slave should not send terminal status update before containerizer update is finished

[ https://issues.apache.org/jira/browse/MESOS-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018342#comment-14018342 ] Ian Downes commented on MESOS-1417: --- Reviews: https://reviews.apache.org/r/22251/ https:

Re: Review Request 22251: Give the command executor some cpu and memory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22251/#review44776 --- src/slave/slave.cpp

Review Request 22253: Wait on Containerizer::update to complete before sending status update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22253/ --- Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. Bugs: MESOS-1417

Re: Review Request 22251: Give the command executor some cpu and memory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22251/ --- (Updated June 4, 2014, 4:36 p.m.) Review request for mesos, Ben Mahler, Jie Yu,

Re: Review Request 22252: Change MesosContainerizer::update to not return failure for unknown container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22252/ --- (Updated June 4, 2014, 4:36 p.m.) Review request for mesos, Ben Mahler, Jie Yu,

Review Request 22252: Change MesosContainerizer::update to not return failure for unknown container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22252/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-1417 https

Review Request 22251: Give the command executor some cpu and memory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22251/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-1417 https

Re: Review Request 22066: Added timeout to rescind unused offers

> On May 31, 2014, 8:47 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [22066] > > > > Failed command: git apply --index 22066.patch > > > > Error: > > error: patch failed: src/master/flags.hpp:229 > > error: src/master/flags.hpp: patch does not apply > > 22066.patch:139

Re: Review Request 22223: MESOS-1312: Added orphan_tasks and unknown_frameworks in state.json

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3/ --- (Updated June 4, 2014, 11:13 p.m.) Review request for mesos, Adam B, Niklas Nie

Re: Review Request 22190: Added MockAuthorizer and more authorization tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22190/ --- (Updated June 4, 2014, 11:10 p.m.) Review request for mesos, Benjamin Hindman a

[jira] [Commented] (MESOS-1456) Metric lifetime should be tied to process runstate, not lifetime.

[ https://issues.apache.org/jira/browse/MESOS-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018315#comment-14018315 ] Yan Xu commented on MESOS-1456: --- A one-off fix for ShedulerProcess: https://reviews.apache.o

Re: Review Request 22162: Pulled common Framework (re-)registration validation into a helper method.

> On June 4, 2014, 3:50 p.m., Ben Mahler wrote: > > src/master/master.hpp, lines 622-630 > > > > > > What is the longer term strategy for message validation? Having a > > single generically named 'validate' suggests a

Re: Review Request 22250: A one-off fix for MESOS-1456: it ties the lifetime of metrics in SchedulerProcess to its runstate and not lifetime.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22250/#review44771 --- Ship it! Ship It! - Dominic Hamon On June 4, 2014, 3:51 p.m., Ji

Review Request 22250: A one-off fix for MESOS-1456: it ties the lifetime of metrics in SchedulerProcess to its runstate and not lifetime.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22250/ --- Review request for mesos, Ben Mahler and Dominic Hamon. Bugs: MESOS-1456 ht

Re: Review Request 22162: Pulled common Framework (re-)registration validation into a helper method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22162/#review44770 --- src/master/master.hpp

Re: Review Request 22248: Allowed parsing JSON array flags.

> On June 4, 2014, 10:32 p.m., Ben Mahler wrote: > > What was the motivation for this patch? > > Jie Yu wrote: > The port mapping isolator will pass an array of port ranges (in JSON > array) to the launcher to execute it a subprocess (using the new Operation > interface). OK, figured out

Re: Review Request 22248: Allowed parsing JSON array flags.

> On June 4, 2014, 10:32 p.m., Ben Mahler wrote: > > What was the motivation for this patch? The port mapping isolator will pass an array of port ranges (in JSON array) to the launcher to execute it a subprocess (using the new Operation interface). - Jie

Re: Review Request 22248: Allowed parsing JSON array flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22248/#review44766 --- What was the motivation for this patch? - Ben Mahler On June 4, 2

Review Request 22248: Allowed parsing JSON array flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22248/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos-git De

[jira] [Updated] (MESOS-1453) Update reconciliation semantics send statuses for each task.

[ https://issues.apache.org/jira/browse/MESOS-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Mahler updated MESOS-1453: --- Summary: Update reconciliation semantics send statuses for each task. (was: Update reconcili

[jira] [Commented] (MESOS-1453) Update reconciliation semantics to take only task ids and send statuses for each task.

[ https://issues.apache.org/jira/browse/MESOS-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018282#comment-14018282 ] Benjamin Mahler commented on MESOS-1453: Actually, we need two things for reconcil

[jira] [Updated] (MESOS-1453) Update reconciliation semantics send statuses for each task.

[ https://issues.apache.org/jira/browse/MESOS-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Mahler updated MESOS-1453: --- Description: Currently, we only reply to a reconciliation request when the task state differ

Re: Review Request 21968: MESOS-878: Prevented slave from (re-)registering when TERMINATING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21968/ --- (Updated June 4, 2014, 10:19 p.m.) Review request for mesos, Adam B, Niklas Nie

Re: Review Request 21968: MESOS-878: Prevented slave from reregistering when TERMINATING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21968/ --- (Updated June 4, 2014, 10:15 p.m.) Review request for mesos, Adam B, Niklas Nie

Re: Review Request 21968: MESOS-878: Prevented slave from reregistering when TERMINATING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21968/ --- (Updated June 4, 2014, 10:14 p.m.) Review request for mesos, Adam B, Niklas Nie

Re: Review Request 21968: MESOS-878: Prevented slave from reregistering when TERMINATING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21968/ --- (Updated June 4, 2014, 10:10 p.m.) Review request for mesos, Adam B, Niklas Nie

Re: Review Request 21968: MESOS-878: Prevented slave from reregistering when TERMINATING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21968/ --- (Updated June 4, 2014, 10:08 p.m.) Review request for mesos, Adam B, Niklas Nie

Re: Review Request 21968: MESOS-878: Prevented slave from reregistering when TERMINATING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21968/ --- (Updated June 4, 2014, 10:01 p.m.) Review request for mesos, Adam B, Niklas Nie

[jira] [Created] (MESOS-1457) Process IDs should be required to be human-readable

Dominic Hamon created MESOS-1457: Summary: Process IDs should be required to be human-readable Key: MESOS-1457 URL: https://issues.apache.org/jira/browse/MESOS-1457 Project: Mesos Issue Type

[jira] [Created] (MESOS-1456) Metric lifetime should be tied to process runstate, not lifetime.

Dominic Hamon created MESOS-1456: Summary: Metric lifetime should be tied to process runstate, not lifetime. Key: MESOS-1456 URL: https://issues.apache.org/jira/browse/MESOS-1456 Project: Mesos

Re: Review Request 21968: Fix issue #878 Slave should not register with the master when in TERMINATING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21968/#review44765 --- Ship it! Ship It! - Adam B On June 4, 2014, 2:51 p.m., Yifan Gu

Re: Review Request 21968: Fix issue #878 Slave should not register with the master when in TERMINATING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21968/ --- (Updated June 4, 2014, 9:51 p.m.) Review request for mesos, Adam B, Niklas Niel

Re: Review Request 21968: Fix issue #878 Slave should not register with the master when in TERMINATING.

> On May 29, 2014, 5:13 p.m., Vinod Kone wrote: > > src/tests/slave_tests.cpp, line 815 > > > > > > I dont think you need this abstraction. Just advance the clock and make > > sure there is no registration message sen

Re: Review Request 21968: Fix issue #878 Slave should not register with the master when in TERMINATING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21968/ --- (Updated June 4, 2014, 9:46 p.m.) Review request for mesos, Adam B, Niklas Niel

Re: Review Request 21968: Fix issue #878 Slave should not register with the master when in TERMINATING.

> On June 4, 2014, 9:19 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/include/process/gmock.hpp, line 51 > > > > > > This looks great but what about including the prefix EXPECT_? > > > > EXPECT_NO_FUTU

Re: Review Request 21968: Fix issue #878 Slave should not register with the master when in TERMINATING.

> On June 4, 2014, 7:20 p.m., Adam B wrote: > > src/tests/slave_tests.cpp, lines 736-739 > > > > > > Should all fit on one line, especially after removing "this->" Done > On June 4, 2014, 7:20 p.m., Adam B wrote: >

[jira] [Updated] (MESOS-1451) Remove 'offer_id' field from LaunchTasksMessage.

[ https://issues.apache.org/jira/browse/MESOS-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Mahler updated MESOS-1451: --- Sprint: Q2'14 Sprint 3 > Remove 'offer_id' field from LaunchTasksMessage. > -

Re: Review Request 21968: Fix issue #878 Slave should not register with the master when in TERMINATING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21968/ --- (Updated June 4, 2014, 9:25 p.m.) Review request for mesos, Adam B, Niklas Niel

Re: Review Request 22223: Patch for issue-1312, added orphan_tasks: see https://issues.apache.org/jira/browse/MESOS-1312 for detail

> On June 4, 2014, 7:12 p.m., Vinod Kone wrote: > > src/master/http.cpp, lines 543-561 > > > > > > How about pushing this into slave model? > > Yifan Gu wrote: > Yes, putting the "orphan_tasks" in their parent sla

Re: Review Request 21968: Fix issue #878 Slave should not register with the master when in TERMINATING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21968/#review44759 --- 3rdparty/libprocess/include/process/gmock.hpp

Re: Review Request 21968: Fix issue #878 Slave should not register with the master when in TERMINATING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21968/ --- (Updated June 4, 2014, 9:18 p.m.) Review request for mesos, Adam B, Niklas Niel

Re: Review Request 22223: Patch for issue-1312, added orphan_tasks: see https://issues.apache.org/jira/browse/MESOS-1312 for detail

> On June 4, 2014, 7:12 p.m., Vinod Kone wrote: > > src/master/http.cpp, lines 543-561 > > > > > > How about pushing this into slave model? Yes, putting the "orphan_tasks" in their parent slaves seems more structural.

Re: Review Request 21968: Fix issue #878 Slave should not register with the master when in TERMINATING.

> On June 4, 2014, 7:20 p.m., Adam B wrote: > > src/tests/slave_tests.cpp, line 719 > > > > > > "this->" is unnecessary here and elsewhere in this function. > > Yifan Gu wrote: > Yes, I agree. But in slave_recove

Re: 0.19.0 Testing

Tagging 0.19.0-rc3 with the following three trivial cherry-picks off master: * 4feeb9e Ignore slave cgroup during isolator recovery. * ff8f287 Fixed a segfault in libprocess. * aa5d491 Updated CHANGELOG for 0.19.0. Here's what it looks like off of rc2: * 51e0475 (HEAD) Updated CHANGELOG for 0.19

Re: Review Request 21968: Fix issue #878 Slave should not register with the master when in TERMINATING.

> On June 4, 2014, 12:20 p.m., Adam B wrote: > > src/tests/slave_tests.cpp, line 767 > > > > > > Re: "when the master comes back" - The detector.appoint call doesn't > > actually failover the master, it just notifies

[jira] [Updated] (MESOS-873) Crash in os::killtree on Mavericks

[ https://issues.apache.org/jira/browse/MESOS-873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Mahler updated MESOS-873: -- Summary: Crash in os::killtree on Mavericks (was: Crash in os::killtree on Mavericks ) > Crash

[jira] [Updated] (MESOS-1087) Display warning for credentials file permissions

[ https://issues.apache.org/jira/browse/MESOS-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Mahler updated MESOS-1087: --- Summary: Display warning for credentials file permissions (was: Display warning for credenti

[jira] [Updated] (MESOS-1449) Isolator::recover will attempt to remove slave cgroup when using --slave_subsystems

[ https://issues.apache.org/jira/browse/MESOS-1449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Mahler updated MESOS-1449: --- Fix Version/s: 0.19.0 > Isolator::recover will attempt to remove slave cgroup when using > -

Re: Review Request 21968: Fix issue #878 Slave should not register with the master when in TERMINATING.

> On June 4, 2014, 7:20 p.m., Adam B wrote: > > src/tests/slave_tests.cpp, line 719 > > > > > > "this->" is unnecessary here and elsewhere in this function. > > Yifan Gu wrote: > Yes, I agree. But in slave_recove

Re: Review Request 21451: Add sampling support to the perf_event isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21451/#review44751 --- src/slave/containerizer/isolators/cgroups/perf_event.cpp

Review Request 22247: Fixed a segfault in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22247/ --- Review request for mesos and Benjamin Hindman. Bugs: MESOS-1455 https://iss

[jira] [Commented] (MESOS-1207) Please create a DOAP file for your TLP

[ https://issues.apache.org/jira/browse/MESOS-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018115#comment-14018115 ] Sebb commented on MESOS-1207: - PING > Please create a DOAP file for your TLP > --

Re: Review Request 21968: Fix issue #878 Slave should not register with the master when in TERMINATING.

> On June 4, 2014, 7:20 p.m., Adam B wrote: > > src/tests/slave_tests.cpp, line 719 > > > > > > "this->" is unnecessary here and elsewhere in this function. Yes, I agree. But in slave_recovery_tests.cpp and master_te

[jira] [Commented] (MESOS-1455) Segfault in libprocess during Process linking.

[ https://issues.apache.org/jira/browse/MESOS-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018111#comment-14018111 ] Benjamin Mahler commented on MESOS-1455: https://reviews.apache.org/r/22247/ > Se

[jira] [Updated] (MESOS-1455) Segfault in libprocess during Process linking.

[ https://issues.apache.org/jira/browse/MESOS-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Mahler updated MESOS-1455: --- Sprint: Q2'14 Sprint 3 > Segfault in libprocess during Process linking. > ---

Re: Review Request 22247: Fixed a segfault in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22247/#review44752 --- Ship it! Ship It! - Benjamin Hindman On June 4, 2014, 8:26 p.m.,

Re: 0.19.0 Testing

There's also a regression in libprocess that I'll get fixed: https://issues.apache.org/jira/browse/MESOS-1455 On Mon, Jun 2, 2014 at 12:03 PM, Tom Arnfeld wrote: > That's exciting! I'd also love if anyone could try out the Docker > Containerizer I've been working on... > https://github.com/dued

[jira] [Created] (MESOS-1455) Segfault in libprocess during Process linking.

Benjamin Mahler created MESOS-1455: -- Summary: Segfault in libprocess during Process linking. Key: MESOS-1455 URL: https://issues.apache.org/jira/browse/MESOS-1455 Project: Mesos Issue Type:

Re: Review Request 21968: Fix issue #878 Slave should not register with the master when in TERMINATING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21968/#review44746 --- Ship it! lgtm modulo adam's comments. - Vinod Kone On June 2, 20

Re: Review Request 21968: Fix issue #878 Slave should not register with the master when in TERMINATING.

> On May 29, 2014, 5:13 p.m., Vinod Kone wrote: > > src/tests/slave_tests.cpp, line 815 > > > > > > I dont think you need this abstraction. Just advance the clock and make > > sure there is no registration message sen

Re: Review Request 21968: Fix issue #878 Slave should not register with the master when in TERMINATING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21968/#review44741 --- Ship it! Looks great! Only minor nits & suggestions remaining. sr

Re: Review Request 22223: Patch for issue-1312, added orphan_tasks: see https://issues.apache.org/jira/browse/MESOS-1312 for detail

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3/#review44738 --- src/master/http.cpp

Re: Review Request 22160: Added setns utilities to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22160/#review44736 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/setns.hpp

Re: Review Request 22224: Added an abstraction for launching operations in a subprocess.

> On June 4, 2014, 6:31 p.m., Dominic Hamon wrote: > > src/tests/launcher_tests.cpp, line 70 > > > > > > we should be able to inject this. we can start with a default for > > production and have tests have access to a

Re: Review Request 21799: Fixes to enable cgroup + systemd.slice behavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21799/#review44734 --- src/linux/cgroups.hpp

Re: Review Request 22224: Added an abstraction for launching operations in a subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/#review44737 --- src/tests/launcher_tests.cpp

Re: Review Request 22224: Added an abstraction for launching operations in a subprocess.

> On June 4, 2014, 6:13 p.m., Vinod Kone wrote: > > src/tests/launcher_tests.cpp, line 70 > > > > > > do the users even need to know the path of the "mesos-launcher"? why > > can't "operation" figure that out because i

Re: External Containerizer / 0.19.0 / Mesos+Docker

Hi Jay, > Could you go into details on this? Are you saying deimos doesn't work with the latest mesos in the github.com tree? I've been speaking to Jason the past couple of days, and Deimos has now been brought inline with the RC External Containerizer API. On 4 June 2014 19:21, Jay Buffington

[jira] [Commented] (MESOS-1454) Command executor should have nonzero resources

[ https://issues.apache.org/jira/browse/MESOS-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017964#comment-14017964 ] Ian Downes commented on MESOS-1454: --- No, I don't believe so. This was discovered during

Re: External Containerizer / 0.19.0 / Mesos+Docker

+ solidsnack, the deimos guy. On Sun, Jun 1, 2014 at 10:14 AM, Tom Arnfeld wrote: > > 2) Specifically relating to Mesos and Docker (Deimos + @Mesosphere) > > Correct me if i’m wrong (and if there’s something un-pushed to Github) but > it seems the Deimos (Docker Containerizer) has fallen behind t

  1   2   >