---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27760/#review60767
---
Looks great, but I'm not convinced you need a hashmap of
On Nov. 10, 2014, 7:56 p.m., Niklas Nielsen wrote:
LGTM. I agree with Alex that this ended up being duplicated too many times
and will become a pain to maintain consistently. We haven't had this
problem before, but maybe it's worth a JIRA ticket?
On Nov. 5, 2014, 11:50 a.m., Ben Mahler wrote:
src/slave/slave.cpp, lines 1195-1200
https://reviews.apache.org/r/27567/diff/1/?file=748326#file748326line1195
A comment here as to why we don't need to send TASK_LOST would be much
appreciated! It's not obvious so someone might come
On Nov. 11, 2014, 1:59 a.m., Michael Park wrote:
3rdparty/libprocess/include/process/node.hpp, line 42
https://reviews.apache.org/r/27446/diff/6/?file=754587#file754587line42
Does this compile...? It should be `!(this-operator == (that));` for
it to be valid. Preferably we simply
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27446/
---
(Updated Nov. 11, 2014, 12:54 p.m.)
Review request for mesos, Dominic Hamon,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review60778
---
src/slave/flags.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/
---
Review request for mesos.
Repository: mesos-git
Description
---
While
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/#review60781
---
3rdparty/libprocess/src/encoder.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/#review60783
---
Patch looks great!
Reviews applied: [27865]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27497/
---
(Updated Nov. 11, 2014, 4:52 p.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27499/
---
(Updated Nov. 11, 2014, 4:52 p.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27503/
---
(Updated Nov. 11, 2014, 4:53 p.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27501/
---
(Updated Nov. 11, 2014, 4:52 p.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27500/
---
(Updated Nov. 11, 2014, 4:52 p.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27502/
---
(Updated Nov. 11, 2014, 4:53 p.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27498/
---
(Updated Nov. 11, 2014, 4:52 p.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27506/
---
(Updated Nov. 11, 2014, 4:53 p.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27496/
---
(Updated Nov. 11, 2014, 4:52 p.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27507/
---
(Updated Nov. 11, 2014, 4:53 p.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27509/
---
(Updated Nov. 11, 2014, 4:55 p.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27508/
---
(Updated Nov. 11, 2014, 4:55 p.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27510/
---
(Updated Nov. 11, 2014, 4:55 p.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27510/#review60800
---
Patch looks great!
Reviews applied: [27496, 27497, 27498, 27499,
+1
Successfully deployed to our test clusters.
On Mon, Nov 10, 2014 at 2:23 PM, Ian Downes idow...@twitter.com.invalid
wrote:
Hi all,
Please vote on releasing the following candidate as Apache Mesos 0.21.0.
0.21.0-rc2 added the following commits to 0.21.0-rc1:
$ git cherry -v 0.21.0-rc1
Ben,
there are two scenarios: executor shutdown and killTask() in
CommandExecutor. For the first use case, each custom executor is affected
through the ExecutorProcess, that means two levels are involved
(containerizer and executor) and should be synchronized.
In the second scenario, each task
On Oct. 18, 2014, 2:50 p.m., Ben Mahler wrote:
src/tests/slave_tests.cpp, line 528
https://reviews.apache.org/r/26894/diff/1/?file=724949#file724949line528
Hm.. this doesn't look like the right usage of shell=false (which
should use the `arguments` field):
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27769/#review60812
---
Ship it!
module the fix for duplicate task ids, which i'm assuming
Now, I am proceeding with my work :)
Thanks to all of You.
Sweta
On Tue Nov 11 2014 at 10:02:14 AM Dave Lester daveles...@gmail.com wrote:
Yes, I noticed a spelling error in the mesos-containerizer.md YAML header
and pushed the changes. The website should build properly now.
On Mon, Nov 10,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/
---
(Updated Nov. 11, 2014, 11:13 a.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27499/#review60820
---
3rdparty/libprocess/include/process/clock.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27843/#review60816
---
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review60826
---
Thomas, can you expand a bit on what is going on? It looks like you
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27446/#review60827
---
3rdparty/libprocess/include/process/node.hpp
On Nov. 11, 2014, 7:25 p.m., Vinod Kone wrote:
src/master/master.cpp, line 1889
https://reviews.apache.org/r/27843/diff/1/?file=757343#file757343line1889
Hmm. Not sure why ended up using Error() instead of string? The string
version was concise and readable. AFAICT, there were
On Nov. 11, 2014, 7:25 p.m., Vinod Kone wrote:
src/master/master.cpp, line 1998
https://reviews.apache.org/r/27843/diff/1/?file=757343#file757343line1998
why pull this down?
Oh, that's because the following changes. I need to validate all
task.executor().resources() first before
On Oct. 18, 2014, 9:50 p.m., Ben Mahler wrote:
src/tests/slave_tests.cpp, line 528
https://reviews.apache.org/r/26894/diff/1/?file=724949#file724949line528
Hm.. this doesn't look like the right usage of shell=false (which
should use the `arguments` field):
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27806/#review60836
---
Ship it!
Ship It!
- Vinod Kone
On Nov. 10, 2014, 1:27 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27496/#review60832
---
LGTM - see comment below
On Nov. 11, 2014, 7:28 p.m., Niklas Nielsen wrote:
Thomas, can you expand a bit on what is going on? It looks like you are
doing more than just enabling the configuration of the master endpoint?
That's really it. To allow configuration of the master endpoint, a config
dialog and
On Nov. 11, 2014, 11:39 a.m., Niklas Nielsen wrote:
3rdparty/libprocess/include/process/timer.hpp, line 14
https://reviews.apache.org/r/27496/diff/1/?file=747095#file747095line14
I would really love more documentation on these concepts. I see that
the timer class had static
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27493/#review60837
---
src/authentication/cram_md5/authenticatee.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27769/
---
(Updated Nov. 11, 2014, 7:55 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27843/
---
(Updated Nov. 11, 2014, 7:59 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27843/#review60845
---
Patch looks great!
Reviews applied: [27769, 27843]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27494/#review60846
---
src/messages/messages.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27497/#review60850
---
Ship it!
Ship It!
- Niklas Nielsen
On Nov. 11, 2014, 8:52 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27675/#review60851
---
docs/upgrades.md
https://reviews.apache.org/r/27675/#comment102248
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27500/#review60860
---
Ship it!
Ship It!
- Niklas Nielsen
On Nov. 11, 2014, 8:52 a.m.,
+1 Mac OS X 10.9.5 and Ubuntu trusty
Niklas
On 11 November 2014 10:11, Vinod Kone vinodk...@gmail.com wrote:
+1
Successfully deployed to our test clusters.
On Mon, Nov 10, 2014 at 2:23 PM, Ian Downes idow...@twitter.com.invalid
wrote:
Hi all,
Please vote on releasing the following
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27040/#review60868
---
3rdparty/libprocess/include/process/reap.hpp~
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27413/#review60869
---
is this now out of date? can you discard it if it has been replaced
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27354/#review60871
---
note: waiting for comments from ben hindman before committing.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27356/#review60872
---
Ship it!
Ship It!
- Dominic Hamon
On Oct. 29, 2014, 3:51 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26914/#review60873
---
src/webui/master/static/js/controllers.js
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27356/#review60877
---
What happened with https://reviews.apache.org/r/27351/diff/# ?
-
On Nov. 11, 2014, 2:34 p.m., Niklas Nielsen wrote:
What happened with https://reviews.apache.org/r/27351/diff/# ?
i thought i'd seen this somewhere before!
pick one, close the other please :)
- Dominic
---
This is an automatically
On Nov. 11, 2014, 2:34 p.m., Niklas Nielsen wrote:
What happened with https://reviews.apache.org/r/27351/diff/# ?
Dominic Hamon wrote:
i thought i'd seen this somewhere before!
pick one, close the other please :)
ah, this is mesos. the other is libprocess.
- Dominic
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27498/#review60852
---
It would be really helpful if we could put together a sequence
We found a bug in production that causes driver to send ACKs despite
scheduler throwing an exception.
https://issues.apache.org/jira/browse/MESOS-2078
The fix is worth including in 0.21.0. I'll prep a fix and we can cut rc3.
On Tue, Nov 11, 2014 at 1:59 PM, Niklas Nielsen nik...@mesosphere.io
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27499/#review60887
---
3rdparty/libprocess/src/process.cpp
+till
FYI for Mac OS X 10.10.
Had to install subversion and apr:
$ brew tap homebrew/versions
$ brew tap homebrew/apache
$ brew install subversion apr
There is a flaky test in libprocess:
[ RUN ] IO.Write
make[5]: *** [check-local] Broken pipe: 13
Filed:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27501/#review60866
---
3rdparty/libprocess/src/process.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27503/#review60880
---
3rdparty/libprocess/src/clock.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27502/#review60883
---
Can you expand a little bit on why you needed a new async watcher?
Here's the patch for 10.10 that we should cherry-pick:
commit 8adb36e3f72b575dea53013e7e790cb6c7957ae0
Author: Benjamin Mahler bmah...@twitter.com
Date: Tue Nov 11 15:11:32 2014 -0800
Added missing ZooKeeper patch file to the Makefile.
I'll mark
Thanks for the report and offer to help!
Granted you perms. Let me know if you are still having issues.
On Mon, Nov 10, 2014 at 3:27 AM, Dharmesh Kakadia dhkaka...@gmail.com
wrote:
It looks like I don't have enough permissions to remove them. Can someone
grant me?
Also, is there a way we can
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27446/
---
(Updated Nov. 12, 2014, 12:28 a.m.)
Review request for mesos, Dominic Hamon,
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2273/changes
Changes:
[bmahler] Added missing ZooKeeper patch file to the Makefile.
--
[...truncated 70619 lines...]
I1112 00:59:55.652917 944 group.cpp:313] Group process
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27496/#review60911
---
Hey Ben, would love to help review these. Any chance you could link
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27896/
---
Review request for mesos, Benjamin Hindman, Ben Mahler, and Bill Farner.
Bugs:
On Nov. 11, 2014, 5:04 p.m., Ben Mahler wrote:
Hey Ben, would love to help review these. Any chance you could link a
ticket in here with the context? And/or update the description on these
changes to say a bit more than See summary?
It's a bit tough to navigate this chain of
On Nov. 12, 2014, 1:04 a.m., Ben Mahler wrote:
Hey Ben, would love to help review these. Any chance you could link a
ticket in here with the context? And/or update the description on these
changes to say a bit more than See summary?
It's a bit tough to navigate this chain of
+tim and niklas
Looks like this is still flaky?
On Tue, Nov 11, 2014 at 5:00 PM, Apache Jenkins Server
jenk...@builds.apache.org wrote:
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2273/changes
Changes:
[bmahler] Added missing ZooKeeper patch file to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27896/#review60928
---
Patch looks great!
Reviews applied: [27896]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27843/#review60929
---
Ship it!
Ship It!
- Vinod Kone
On Nov. 11, 2014, 7:59 p.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27903/
---
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27903/#review60946
---
Patch looks great!
Reviews applied: [27769, 27843, 27903]
All
Done. Thanks Vinod.
The removed pages are in the trash if required to be restored.
Thanks,
Dharmesh
On Wed, Nov 12, 2014 at 5:25 AM, Vinod Kone vinodk...@gmail.com wrote:
Thanks for the report and offer to help!
Granted you perms. Let me know if you are still having issues.
On Mon, Nov 10,
On Nov. 7, 2014, 10:40 p.m., Adam B wrote:
Ship It!
Looks like this already got committed elsewhere:
commit 2061b360f1da370ca42b2ccb41ab2f718d2624e4
Author: Dave Lester d...@davelester.org
Date: Mon Nov 10 20:04:15 2014 -0800
Fixes YAML header in Mesos containerizer doc.
You can
79 matches
Mail list logo
