Re: Review Request 29905: Changed mesos local to use Collector interface.

2015-01-14 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29905/#review68218 --- Ship it! Ship It! - Alexander Rukletsov On Jan. 15, 2015, 12:55

Re: Review Request 29904: Changed slave to use collector interface.

2015-01-14 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29904/#review68217 --- Ship it! src/slave/main.cpp

Re: Review Request 29903: Added collector interface.

2015-01-14 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29903/#review68216 --- Ship it! src/slave/monitor.hpp

Re: Review Request 29918: Introduced checkpoint function for Resources.

2015-01-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29918/#review68208 --- Bad patch! Reviews applied: [29730, 28562, 28608, 29179, 28720, 287

Re: Review Request 29913: Added persisted resources validation on the slave.

2015-01-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29913/#review68206 --- Bad patch! Reviews applied: [28697, 29911, 29742, 29730, 28562, 286

Re: Review Request 29913: Added persisted resources validation on the slave.

2015-01-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29913/ --- (Updated Jan. 15, 2015, 5:19 a.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 29918: Introduced checkpoint function for Resources.

2015-01-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29918/ --- (Updated Jan. 15, 2015, 5:19 a.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 29913: Added persisted resources validation on the slave.

2015-01-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29913/ --- (Updated Jan. 15, 2015, 5:19 a.m.) Review request for mesos. Summary (updated

Re: Review Request 29918: Introduced checkpoint function for Resources.

2015-01-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29918/ --- (Updated Jan. 15, 2015, 5:16 a.m.) Review request for mesos. Repository: meso

Re: Review Request 29918: Introduced checkpoint function for Resources.

2015-01-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29918/#review68205 --- src/slave/slave.cpp

Review Request 29918: Introduced checkpoint function for Resources.

2015-01-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29918/ --- Review request for mesos. Repository: mesos-git Description --- Introduc

Re: Review Request 29913: Added persisted resources validation on the slave side.

2015-01-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29913/ --- (Updated Jan. 15, 2015, 5:03 a.m.) Review request for mesos. Repository: meso

Re: Review Request 29887: Fixed SASL auxprop plugin handling.

2015-01-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29887/#review68201 --- Bad patch! Reviews applied: [29887] Failed command: ./support/appl

Re: Review Request 29887: Fixed SASL auxprop plugin handling.

2015-01-14 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29887/ --- (Updated Jan. 15, 2015, 3:57 a.m.) Review request for mesos, Adam B, Ben Mahler

Re: Review Request 29887: Fixed SASL auxprop plugin handling.

2015-01-14 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29887/ --- (Updated Jan. 15, 2015, 3:55 a.m.) Review request for mesos and Adam B. Chang

Re: Review Request 29903: Added collector interface.

2015-01-14 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29903/#review68197 --- Ship it! Ship It! - Kapil Arya On Jan. 14, 2015, 7:55 p.m., Nikl

Re: Review Request 28697: Add ReservationType for dynamic reservations.

2015-01-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28697/ --- (Updated Jan. 15, 2015, 2:10 a.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 29913: Added persisted resources validation on the slave side.

2015-01-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29913/#review68190 --- src/slave/slave.cpp

Re: Review Request 29913: Added persisted resources validation on the slave side.

2015-01-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29913/#review68189 --- Bad patch! Reviews applied: [29911, 29742, 29274, 29380] Failed co

Review Request 29913: Added persisted resources validation on the slave side.

2015-01-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29913/ --- Review request for mesos. Repository: mesos-git Description --- Added pe

Review Request 29911: Added Resources(const std::vector

2015-01-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29911/ --- Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vino

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2671

2015-01-14 Thread Apache Jenkins Server
See

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2390

2015-01-14 Thread Apache Jenkins Server
See

Review Request 29906: Changed tests to use collector interface.

2015-01-14 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29906/ --- Review request for mesos. Bugs: MESOS-2219 https://issues.apache.org/jira/b

Review Request 29904: Changed slave to use collector interface.

2015-01-14 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29904/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2219 https://issues.ap

Review Request 29903: Added collector interface.

2015-01-14 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29903/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2219 https://issues.ap

Review Request 29905: Changed mesos local to use Collector interface.

2015-01-14 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29905/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2219 https://issues.ap

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2670

2015-01-14 Thread Apache Jenkins Server
See Changes: [yujie.jay] Supported accept offers in C++ scheduler driver. -- [...truncated 292328 lines...] I0115 00:10:59.044044 27

Re: Review Request 29887: Fixed SASL auxprop plugin handling.

2015-01-14 Thread Till Toenshoff
> On Jan. 14, 2015, 11:19 p.m., Vinod Kone wrote: > > src/authentication/cram_md5/authenticator.hpp, lines 465-480 > > > > > > I think it's simpler to use 'Once'? > > > > ``` > > static process::Once* auxp

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2389

2015-01-14 Thread Apache Jenkins Server
See Changes: [yujie.jay] Supported accept offers in C++ scheduler driver. -- [...truncated 128408 lines...] I0114 23:59:11.950073 19114 auxprop.cpp:121] Skipping au

Re: Review Request 29890: Refactored allocator interface to support general implementations.

2015-01-14 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29890/#review68160 --- Very nice refactor, Alex! RR comment: This patch touches quite a fe

Re: Review Request 29887: Fixed SASL auxprop plugin handling.

2015-01-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29887/#review68161 --- src/authentication/cram_md5/authenticator.hpp

Re: Review Request 29887: Fixed SASL auxprop plugin handling.

2015-01-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29887/#review68159 --- Patch looks great! Reviews applied: [29887] All tests passed. - M

Re: Review Request 29887: Fixed SASL auxprop plugin handling.

2015-01-14 Thread Till Toenshoff
> On Jan. 14, 2015, 10:21 p.m., Vinod Kone wrote: > > src/authentication/cram_md5/auxprop.cpp, lines 33-35 > > > > > > Isn't the bug here that there *are* multiple masters/authenticators > > running at the same time (i

Re: Review Request 29887: Fixed SASL auxprop plugin handling.

2015-01-14 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29887/ --- (Updated Jan. 14, 2015, 10:50 p.m.) Review request for mesos and Adam B. Chan

Re: Review Request 29870: Supported accept offers in C++ scheduler driver.

2015-01-14 Thread Jie Yu
> On Jan. 14, 2015, 2:09 a.m., Ben Mahler wrote: > > src/sched/sched.cpp, line 964 > > > > > > _pure_ language schedulers Fixed. > On Jan. 14, 2015, 2:09 a.m., Ben Mahler wrote: > > src/sched/sched.cpp, line 1026 >

Re: Review Request 29887: Fixed SASL auxprop plugin handling.

2015-01-14 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29887/#review68148 --- src/authentication/cram_md5/authenticator.hpp

Re: Review Request 29887: Fixed SASL auxprop plugin handling.

2015-01-14 Thread Till Toenshoff
> On Jan. 14, 2015, 10:10 p.m., Ben Mahler wrote: > > src/authentication/cram_md5/authenticator.hpp, lines 465-480 > > > > > > What is this fixing? It looks like `initialized` will already gate this > > block of code

Re: Review Request 29887: Fixed SASL auxprop plugin handling.

2015-01-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29887/#review68144 --- src/authentication/cram_md5/auxprop.cpp

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2388

2015-01-14 Thread Apache Jenkins Server
See Changes: [benjamin.mahler] Removed the torque / MPI document. -- [...truncated 171300 lines...] I0114 22:21:26.443619 10025 auxprop.cpp:121] Skipping auxiliary

Re: Review Request 29887: Fixed SASL auxprop plugin handling.

2015-01-14 Thread Till Toenshoff
> On Jan. 14, 2015, 10:10 p.m., Ben Mahler wrote: > > src/authentication/cram_md5/authenticator.hpp, lines 465-480 > > > > > > What is this fixing? It looks like `initialized` will already gate this > > block of code

Re: Review Request 29887: Fixed SASL auxprop plugin handling.

2015-01-14 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29887/ --- (Updated Jan. 14, 2015, 10:18 p.m.) Review request for mesos and Adam B. Chan

Re: Review Request 29887: Fixed SASL auxprop plugin handling.

2015-01-14 Thread Ben Mahler
> On Jan. 14, 2015, 5:43 p.m., Alexander Rukletsov wrote: > > src/authentication/cram_md5/authenticator.hpp, line 465 > > > > > > Shouldn't this check be under the critical section? Since it's not a > > libprocess pro

Re: Review Request 29887: Fixed SASL auxprop plugin handling.

2015-01-14 Thread Adam B
> On Jan. 14, 2015, 2:10 p.m., Ben Mahler wrote: > > src/authentication/cram_md5/authenticator.hpp, lines 465-480 > > > > > > What is this fixing? It looks like `initialized` will already gate this > > block of code f

Re: Review Request 29887: Fixed SASL auxprop plugin handling.

2015-01-14 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29887/#review68134 --- src/authentication/cram_md5/authenticator.hpp

Re: Review Request 29887: Fixed SASL auxprop plugin handling.

2015-01-14 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29887/ --- (Updated Jan. 14, 2015, 10:09 p.m.) Review request for mesos and Adam B. Chan

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2669

2015-01-14 Thread Apache Jenkins Server
See Changes: [benjamin.mahler] Removed the torque / MPI document. -- [...truncated 148401 lines...] I0114 22:01:44.430701 1719 auxp

Re: Review Request 29887: Fixed SASL auxprop plugin handling.

2015-01-14 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29887/#review68130 --- Ship it! Ship It! - Adam B On Jan. 14, 2015, 1:58 p.m., Till Toe

Re: Review Request 29887: Fixed SASL auxprop plugin handling.

2015-01-14 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29887/ --- (Updated Jan. 14, 2015, 9:58 p.m.) Review request for mesos and Adam B. Chang

Re: Review Request 29496: Added example hook module.

2015-01-14 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29496/ --- (Updated Jan. 14, 2015, 4:22 p.m.) Review request for mesos and Niklas Nielsen.

Re: Review Request 29896: Added a slave flag to turn off disk quota enforcement.

2015-01-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29896/#review68126 --- Patch looks great! Reviews applied: [29892, 29815, 29687, 29688, 29

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2387

2015-01-14 Thread Apache Jenkins Server
See Changes: [tnachen] Clarify slave log about disk usage. [benjamin.mahler] Added initial Call handler in the Master for accepting offers. [benjamin.mahler] Added initial operational guide to document m

Review Request 29896: Added a slave flag to turn off disk quota enforcement.

2015-01-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29896/ --- Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. Bugs: MESOS-1

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2668

2015-01-14 Thread Apache Jenkins Server
See Changes: [tnachen] Clarify slave log about disk usage. [benjamin.mahler] Added initial Call handler in the Master for accepting offers. [benjamin.mahler] Added initial

Re: Review Request 29688: Added DiskQuotaIsolator to enforce disk quota.

2015-01-14 Thread Jie Yu
> On Jan. 14, 2015, 8:30 p.m., Vinod Kone wrote: > > src/slave/containerizer/isolators/posix/disk.cpp, line 270 > > > > > > Are you planning to implement this soon? Without this it is hard to > > know the disk usage o

Re: Review Request 29688: Added DiskQuotaIsolator to enforce disk quota.

2015-01-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29688/#review68113 --- Ship it! src/slave/containerizer/isolators/posix/disk.cpp

Review Request 29895: Added disk usage statistics reporting.

2015-01-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29895/ --- Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. Bugs: MESOS-1

Re: Review Request 29688: Added DiskQuotaIsolator to enforce disk quota.

2015-01-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29688/ --- (Updated Jan. 14, 2015, 8:28 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 29890: Refactored allocator interface to support general implementations.

2015-01-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29890/#review68108 --- Patch looks great! Reviews applied: [29890] All tests passed. - M

MesosCon Early-Bird Registration Now Open

2015-01-14 Thread Dave Lester
A limited number of early-bird tickets are now available for #MesosCon 2015 , an annual conference organized by the Apache Mesos community. MesosCon brings together users and developers to share and learn about the project and its growing ecosystem, and will take place in Seatt

Re: Review Request 29887: Fixed SASL auxprop plugin handling.

2015-01-14 Thread Till Toenshoff
> On Jan. 14, 2015, 5:43 p.m., Alexander Rukletsov wrote: > > src/authentication/cram_md5/authenticator.hpp, line 465 > > > > > > Shouldn't this check be under the critical section? Since it's not a > > libprocess pro

Re: Review Request 29887: Fixed SASL auxprop plugin handling.

2015-01-14 Thread Till Toenshoff
> On Jan. 14, 2015, 5:43 p.m., Alexander Rukletsov wrote: > > src/authentication/cram_md5/authenticator.hpp, line 465 > > > > > > Shouldn't this check be under the critical section? Since it's not a > > libprocess pro

Re: Review Request 29892: Added three tuples overload for process::await.

2015-01-14 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29892/#review68095 --- Ship it! 3rdparty/libprocess/include/process/collect.hpp

Re: Review Request 29560: Added basic cache data structures to the fetcher process.

2015-01-14 Thread Alexander Rukletsov
> On Jan. 13, 2015, 3:55 p.m., Alexander Rukletsov wrote: > > src/slave/containerizer/fetcher.cpp, lines 186-187 > > > > > > `fetcher_cache_dir` is not optional, while `cache_directory` is. Maybe > > we should conside

Re: Review Request 29690: Added an integration test for enforcing disk quota.

2015-01-14 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29690/#review68086 --- Ship it! Ship It! - Timothy Chen On Jan. 14, 2015, 7:29 p.m., Ji

Re: Review Request 29869: Added initial Call handler in the Master for accepting offers.

2015-01-14 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29869/ --- (Updated Jan. 14, 2015, 7:36 p.m.) Review request for mesos, Jie Yu, Michael Pa

Re: Review Request 29887: Fixed SASL auxprop plugin handling.

2015-01-14 Thread Till Toenshoff
> On Jan. 14, 2015, 6:09 p.m., Adam B wrote: > > Were you able to reproduce the issue without your changes and prove that it > > was fixed with your changes, or are you guessing here? > > Adam B wrote: > Pasting in Till's summary of the problem: > "After some investigation, it turns out

Re: Review Request 29869: Added initial Call handler in the Master for accepting offers.

2015-01-14 Thread Ben Mahler
> On Jan. 13, 2015, 11:29 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 1380-1381 > > > > > > Curious, why you want acceptOffers() call into this method instead of > > the current way. I imagine each opera

Re: Review Request 29887: Fixed SASL auxprop plugin handling.

2015-01-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29887/#review68090 --- What is the bug here? Mind adding it to the description? - Vinod Ko

Re: Review Request 29887: Fixed SASL auxprop plugin handling.

2015-01-14 Thread Adam B
> On Jan. 14, 2015, 10:09 a.m., Adam B wrote: > > Were you able to reproduce the issue without your changes and prove that it > > was fixed with your changes, or are you guessing here? Pasting in Till's summary of the problem: "After some investigation, it turns out that my two-fold solution ha

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2667

2015-01-14 Thread Adam Bordelon
; > '*cmusaslsecretCRAM-MD5' since SASL_AUXPROP_AUTHZID == true >> > I0114 09:10:09.359560 6555 auxprop.cpp:171] Looking up auxiliary >> property >> > '*cmusaslsecretCRAM-MD5' >> > I0114 09:10:09.359565 6564 auxprop.cpp:99] Request to look

Re: Review Request 29690: Added an integration test for enforcing disk quota.

2015-01-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29690/ --- (Updated Jan. 14, 2015, 7:29 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 29689: Added tests for verifying DiskUsageChecker.

2015-01-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29689/ --- (Updated Jan. 14, 2015, 7:28 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 29689: Added tests for verifying DiskUsageChecker.

2015-01-14 Thread Jie Yu
> On Jan. 12, 2015, 11:34 p.m., Ben Mahler wrote: > > Could you pause the clock in these tests? That might help you test that the > > interval is respected (if you want to add a test for that). Added a TODO. Pausing the clock is problematic for subprocess related tests. - Jie --

Re: Review Request 29688: Added DiskQuotaIsolator to enforce disk quota.

2015-01-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29688/ --- (Updated Jan. 14, 2015, 7:27 p.m.) Review request for mesos, Benjamin Hindman,

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2667

2015-01-14 Thread Vinod Kone
27; server FQDN: ' > > penates.apache.org' SASL_AUXPROP_VERIFY_AGAINST_HASH: false > > SASL_AUXPROP_OVERRIDE: false SASL_AUXPROP_AUTHZID: true > > I0114 09:10:09.359590 6564 auxprop.cpp:99] Request to lookup properties > > for user: 'test-principal'

Re: Review Request 29869: Added initial Call handler in the Master for accepting offers.

2015-01-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29869/#review68081 --- Ship it! Ship It! - Vinod Kone On Jan. 14, 2015, 1:25 a.m., Ben

Re: Review Request 29891: Clarify slave log about disk usage.

2015-01-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29891/#review68080 --- Ship it! Ship It! - Vinod Kone On Jan. 14, 2015, 6:59 p.m., Timo

Review Request 29892: Added three tuples overload for process::await.

2015-01-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29892/ --- Review request for mesos and Ben Mahler. Repository: mesos-git Description --

Re: Review Request 29809: Enhanced Fetcher program with cache actions.

2015-01-14 Thread Bernd Mathiske
> On Jan. 13, 2015, 11:25 a.m., Timothy Chen wrote: > > src/launcher/fetcher.cpp, line 285 > > > > > > So I think the reason I think the method looks like it needed to be > > refactored, it's just that it seems very c

Re: Review Request 29869: Added initial Call handler in the Master for accepting offers.

2015-01-14 Thread Ben Mahler
> On Jan. 14, 2015, 5:51 a.m., Jie Yu wrote: > > src/master/master.cpp, line 1318 > > > > > > Any reason keeps the scheduler:: namespace prefix? It seems nice to differentiate `scheduler::Call` from `executor::Call`

Re: Review Request 29869: Added initial Call handler in the Master for accepting offers.

2015-01-14 Thread Ben Mahler
> On Jan. 13, 2015, 11:29 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 1380-1381 > > > > > > Curious, why you want acceptOffers() call into this method instead of > > the current way. I imagine each opera

Re: Review Request 29891: Clarify slave log about disk usage.

2015-01-14 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29891/ --- (Updated Jan. 14, 2015, 6:59 p.m.) Review request for mesos, Benjamin Hindman a

Review Request 29891: Clarify slave log about disk usage.

2015-01-14 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29891/ --- Review request for mesos, Benjamin Hindman and Vinod Kone. Repository: mesos-gi

Re: Review Request 29891: Clarify slave log about disk usage.

2015-01-14 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29891/ --- (Updated Jan. 14, 2015, 6:59 p.m.) Review request for mesos and Vinod Kone. R

Re: Review Request 29869: Added initial Call handler in the Master for accepting offers.

2015-01-14 Thread Vinod Kone
> On Jan. 13, 2015, 11:29 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 1337 > > > > > > We should consider using 'OneOf' protobuf type to get this check for > > free. > > > > https://developers.g

Re: Review Request 29869: Added initial Call handler in the Master for accepting offers.

2015-01-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29869/#review68067 --- src/master/master.cpp

Re: Review Request 29742: Added useful utility functions to determine types of resources.

2015-01-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29742/ --- (Updated Jan. 14, 2015, 6:55 p.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 29796: Added initial operational guide to document master quorum changes.

2015-01-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29796/#review68069 --- Ship it! Ship It! - Jie Yu On Jan. 14, 2015, 6:44 p.m., Ben Mahl

Review Request 29890: Refactored allocator interface to support general implementations.

2015-01-14 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29890/ --- Review request for mesos, Bernd Mathiske and Niklas Nielsen. Bugs: MESOS-2213

Re: Review Request 29688: Added DiskQuotaIsolator to enforce disk quota.

2015-01-14 Thread Jie Yu
> On Jan. 12, 2015, 11:11 p.m., Ben Mahler wrote: > > Should there be a flag in here to make the enforcement optional for those > > that need to incrementally turn this on? Will do it in a following patch. > On Jan. 12, 2015, 11:11 p.m., Ben Mahler wrote: > > src/slave/containerizer/isolators

Re: Review Request 29796: Added initial operational guide to document master quorum changes.

2015-01-14 Thread Ben Mahler
> On Jan. 11, 2015, 1:42 a.m., Jie Yu wrote: > > docs/operational-guide.md, line 34 > > > > > > Maybe we should also say something about cases like: > > > > if changing from 7 masters to 3 masters are safe or n

Re: Review Request 29796: Added initial operational guide to document master quorum changes.

2015-01-14 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29796/ --- (Updated Jan. 14, 2015, 6:44 p.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 29889: Recover Docker containers when mesos slave is in a container

2015-01-14 Thread Timothy Chen
> On Jan. 14, 2015, 6:38 p.m., Dominic Hamon wrote: > > can you use the 'depends on' to avoid containing other RBs? This review is not meant to be merged, sorry probably should have put this on the description. Since my changes spans lots of reviews, it's easier to have one diff to see everyth

Re: Review Request 29889: Recover Docker containers when mesos slave is in a container

2015-01-14 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29889/#review68064 --- can you use the 'depends on' to avoid containing other RBs? - Domin

Review Request 29889: Recover Docker containers when mesos slave is in a container

2015-01-14 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29889/ --- Review request for mesos and Benjamin Hindman. Repository: mesos-git Descript

Re: Review Request 29887: Fixed SASL auxprop plugin handling.

2015-01-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29887/#review68063 --- Patch looks great! Reviews applied: [29887] All tests passed. - M

Re: Review Request 29887: Fixed SASL auxprop plugin handling.

2015-01-14 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29887/#review68061 --- Were you able to reproduce the issue without your changes and prove

Re: Review Request 29887: Fixed SASL auxprop plugin handling.

2015-01-14 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29887/#review68058 --- src/authentication/cram_md5/authenticator.hpp

Review Request 29887: Fixed SASL auxprop plugin handling.

2015-01-14 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29887/ --- Review request for mesos and Adam B. Bugs: MESOS-2050 https://issues.apache

  1   2   >