Review Request 32656: Refactor statistics helper out of PortMappingIsolatorTest for easier reuse.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32656/ --- Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. Bugs: mesos-233

Re: Suggestion: Mesos 0.22.1 point release

+1 to get it to our users ASAP > On 31 Mar 2015, at 03:01, Niklas Nielsen wrote: > > Hi all, > > Joris and Ben H recently located and fixed a resident bug in the state > abstraction which caused many crashes in the JVM (mostly in conjunction > with Marathon) at scale (https://issues.apache.org/

Re: [Style Proposal] Disallow Capture by Constant Reference to temporary

> > Great link, it looks as though many of our Try / Option / Result / > Future functions that return different results based on parameters / > runtime conditions (e.g. t, None(), Error("..."), Failure("...")) will not > have copies elided via NRVO? (these look similar to cases N and O in the > doc

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32655/ --- (Updated March 31, 2015, 5:35 a.m.) Review request for mesos, Chi Zhang, Ian Do

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32655/#review78341 --- Patch looks great! Reviews applied: [32655] All tests passed. - M

Re: Review Request 32653: Replace busy look on ready file with a more relaxed loop

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32653/#review78329 --- Patch looks great! Reviews applied: [32653] All tests passed. - M

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32655/ --- (Updated March 31, 2015, 3:55 a.m.) Review request for mesos, Chi Zhang, Ian Do

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32655/ --- (Updated March 31, 2015, 3:52 a.m.) Review request for mesos, Chi Zhang, Ian Do

Re: Review Request 32653: Replace busy look on ready file with a more relaxed loop

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32653/ --- (Updated March 31, 2015, 3:33 a.m.) Review request for mesos, Chi Zhang, Ian Do

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32655/#review78322 --- Bad patch! Reviews applied: [32655] Failed command: ./support/appl

Re: Review Request 32558: Improve compile time of mesos by splitting flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32558/#review78320 --- Patch looks great! Reviews applied: [32558] All tests passed. - M

Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32655/ --- Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. Bugs: mesos-233

Re: Review Request 32558: Improve compile time of mesos by splitting flags

> On March 27, 2015, 4:41 p.m., Timothy Chen wrote: > > src/slave/flags.cpp, line 29 > > > > > > How about keeping the same style with namespaces? Just to be consistent > > with everywhere else in the code base. > > C

Re: Review Request 30546: MemIsolator: expose memory pressures for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30546/#review78314 --- Patch looks great! Reviews applied: [31008, 30545, 30546] All test

Re: Review Request 32558: Improve compile time of mesos by splitting flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32558/ --- (Updated March 31, 2015, 2:16 a.m.) Review request for mesos, Joris Van Remoort

Re: Review Request 32558: Improve compile time of mesos by splitting flags

> On March 31, 2015, 1:36 a.m., Ben Mahler wrote: > > Great work Cody! For posterity, how did you pinpoint flags.hpp? Manual experimentation a while ago with Joris. We were searching for general compile time improvements. A conversation recently reminded me of this and that we never pushed a p

Re: [Style Proposal] Disallow Capture by Constant Reference to temporary

Great link, it looks as though many of our Try / Option / Result / Future functions that return different results based on parameters / runtime conditions (e.g. t, None(), Error("..."), Failure("...")) will not have copies elided via NRVO? (these look similar to cases N and O in the doc). On Mon,

Re: Suggestion: Mesos 0.22.1 point release

Hi Niklas, Assuming that you'd like to be release manager for this bugfix release, could you create a JIRA issue to track this and add it to the release planning wiki? https://cwiki.apache.org/confluence/display/MESOS/Mesos+Release+Planning I've already updated the page to reflect the previous rel

Re: Review Request 32509: Documented the scheduler Event/Call protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32509/#review78304 --- Patch looks great! Reviews applied: [32500, 32501, 32502, 32504, 32

Re: Review Request 32558: Improve compile time of mesos by splitting flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32558/#review78303 --- Great work Cody! For posterity, how did you pinpoint flags.hpp? - B

Re: Suggestion: Mesos 0.22.1 point release

+1 for stability. On Mar 30, 2015 6:26 PM, "Benjamin Hindman" wrote: > Obviously a +1, this is a stability fix we should get to our users as soon > as possible. > > On Mon, Mar 30, 2015 at 9:01 PM, Niklas Nielsen > wrote: > > > Hi all, > > > > Joris and Ben H recently located and fixed a residen

Re: Suggestion: Mesos 0.22.1 point release

Obviously a +1, this is a stability fix we should get to our users as soon as possible. On Mon, Mar 30, 2015 at 9:01 PM, Niklas Nielsen wrote: > Hi all, > > Joris and Ben H recently located and fixed a resident bug in the state > abstraction which caused many crashes in the JVM (mostly in conjun

Suggestion: Mesos 0.22.1 point release

Hi all, Joris and Ben H recently located and fixed a resident bug in the state abstraction which caused many crashes in the JVM (mostly in conjunction with Marathon) at scale (https://issues.apache.org/jira/browse/MESOS-1795) We therefore wanted to suggest doing a point release with this fix alon

Re: Review Request 32654: Clean up HostIPNetwork since every use performs the same extract & stringify operation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32654/#review78293 --- Patch looks great! Reviews applied: [32654] All tests passed. - M

Re: Review Request 30546: MemIsolator: expose memory pressures for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30546/#review78290 --- The code looks good to me. See my comments for the tests. src/slav

Re: Review Request 32508: Added version to the scheduler protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32508/ --- (Updated March 31, 2015, 12:10 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 32509: Documented the scheduler Event/Call protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32509/ --- (Updated March 31, 2015, 12:11 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 32507: Moved REGISTER and REREGISTER out of scheduler Calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32507/ --- (Updated March 31, 2015, 12:10 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 32506: Added output stream operators for scheduler Calls and Events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32506/ --- (Updated March 31, 2015, 12:09 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 32505: Added SHUTDOWN scheduler call.

> On March 27, 2015, 3:22 p.m., Alexander Rojas wrote: > > src/scheduler/scheduler.cpp, lines 679-680 > > > > > > Do you mind adding a comment why an exited executor is always marked as > > a failure? It is not clear

Re: Review Request 32505: Added SHUTDOWN scheduler call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32505/ --- (Updated March 31, 2015, 12:09 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 32504: Removed MasterInfo from REGISTER and REREGISTER scheduler calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32504/ --- (Updated March 31, 2015, 12:08 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 32502: Updated RECONCILE call to always specifiy slave id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32502/ --- (Updated March 31, 2015, 12:07 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 32501: Removed REQUEST call from scheduler.proto.

> On March 26, 2015, 1:32 a.m., Ben Mahler wrote: > > Should you be adding a TODO on 'Request' to remove it when the old driver > > goes away? Or is there a reason to leave it indefinitely? > > Vinod Kone wrote: > Added TODOs in master.hpp and mesos.proto. Thanks. NNFR. - Vinod ---

Re: Review Request 32501: Removed REQUEST call from scheduler.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32501/ --- (Updated March 31, 2015, 12:06 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 32501: Removed REQUEST call from scheduler.proto.

> On March 26, 2015, 1:32 a.m., Ben Mahler wrote: > > Should you be adding a TODO on 'Request' to remove it when the old driver > > goes away? Or is there a reason to leave it indefinitely? Added TODOs in master.hpp and mesos.proto. Thanks. - Vinod --

Re: Review Request 30546: MemIsolator: expose memory pressures for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30546/ --- (Updated March 31, 2015, 12:02 a.m.) Review request for mesos, Dominic Hamon, I

Re: Review Request 32653: Replace busy look on ready file with a more relaxed loop

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32653/#review78287 --- Patch looks great! Reviews applied: [32653] All tests passed. - M

Re: Review Request 32500: Removed LAUNCH call from scheduler.proto.

> On March 26, 2015, 12:51 a.m., Ben Mahler wrote: > > include/mesos/scheduler/scheduler.proto, line 124 > > > > > > Ditto here, the tag numbers don't matter much, but are you planning to > > fill in the holes since w

Re: Review Request 32500: Removed LAUNCH call from scheduler.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32500/ --- (Updated March 30, 2015, 11:59 p.m.) Review request for mesos, Ben Mahler and J

Re: Review Request 32351: Added http::streaming::get/post for client-side streaming responses.

> On March 30, 2015, 6:40 p.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/http.hpp, line 587 > > > > > > Can you put a TODO here you wrote in the description of this review: > > ``` > > Long term I'

Re: Review Request 32654: Clean up HostIPNetwork since every use performs the same extract & stringify operation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32654/#review78283 --- src/tests/port_mapping_tests.cpp

Re: Review Request 32346: Added failure semantics for http::Pipe::Writer.

> On March 25, 2015, 10:12 p.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/http.hpp, line 173 > > > > > > Indent. Weird, the indent is actually ok but in reviewboard it looks offset due to the "moved from

Re: Review Request 32347: Added a StreamingResponseDecoder.

> On March 27, 2015, 12:20 a.m., Jie Yu wrote: > > 3rdparty/libprocess/src/tests/decoder_tests.cpp, lines 177-178 > > > > > > Do you want to move this up right after > > ``` > > decoder.decode(body.data(), body

Review Request 32654: Clean up HostIPNetwork since every use performs the same extract & stringify operation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32654/ --- Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. Bugs: mesos-233

Review Request 32653: Replace busy look on ready file with a more relaxed loop

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32653/ --- Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. Bugs: mesos-233

Re: Review Request 32133: Refactor port isolator tests to break out helper functions for testing of bandwidth limit statistics

> On March 18, 2015, 8:58 p.m., Jie Yu wrote: > > Looking at all the port mapping isolator tests here, they are pretty much > > duplicating logics in MesosContainerier (e.g., launchHelper, > > statisticsHelper). It's not good for readability. > > > > It would be cool if we can simply write int

Re: Review Request 32133: Refactor port isolator tests to break out helper functions for testing of bandwidth limit statistics

> On March 17, 2015, 5:51 p.m., Ian Downes wrote: > > src/tests/port_mapping_tests.cpp, line 196 > > > > > > Why an empty JSON object rather than a Try? Current implementation of the mesos-network-helper has the helpe

Re: Review Request 32336: Moved http::Request::accepts from header into cpp file.

> On March 25, 2015, 1:01 a.m., Isabel Jimenez wrote: > > 3rdparty/libprocess/src/http.cpp, line 20 > > > > > > I know this was just submitted but just a small question: > > why are we duplicating these includes he

Re: [Style Proposal] Disallow Capture by Constant Reference to temporary

There is a fairly comprehensive overview of what compilers do / don't do for RVO + NRVO at: http://www.byte-physics.de/index.php?eID=tx_nawsecuredl&u=0&g=0&t=1427845187&hash=d85e8402f1e5b835e3ff4f266a0a7256516ea57e&file=fileadmin/user_upload/kundenbereich/copy-elision-revisited-v1.0.pdf Move const

Re: [Style Proposal] Disallow Capture by Constant Reference to temporary

IIRC, it was when we changed Option:::get to return a const ref. Some callers of 'Option hashmap::get()' were grabbing a const ref to the temporary coming from the option (case 1 in your markdown), and it then became a temporary to a temporary's member (case 2 in your markdown): E.g.: https://revi

Re: Review Request 30546: MemIsolator: expose memory pressures for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30546/#review78267 --- src/slave/containerizer/isolators/cgroups/mem.cpp

Re: [Style Proposal] Disallow Capture by Constant Reference to temporary

I am a +1 on this too. We had a similar bug long time ago when we changed the return value of Try::get() to be const ref. On Mon, Mar 30, 2015 at 11:52 AM, Niklas Nielsen wrote: > Big +1; You could also mention the recent bug in the Two fold > authentication patch that you guys discovered with t

Re: [Style Proposal] Disallow Capture by Constant Reference to temporary

Big +1; You could also mention the recent bug in the Two fold authentication patch that you guys discovered with this bug. Niklas On 30 March 2015 at 10:49, Joris Van Remoortere wrote: > I would like to propose we disallow capturing temporaries using a constant > reference: > const T& val = f()

Re: Review Request 32351: Added http::streaming::get/post for client-side streaming responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32351/#review78111 --- Ship it! 3rdparty/libprocess/include/process/http.hpp

Re: Review Request 32558: Improve compile time of mesos by splitting flags

> On March 27, 2015, 4:41 p.m., Timothy Chen wrote: > > src/slave/flags.cpp, line 29 > > > > > > How about keeping the same style with namespaces? Just to be consistent > > with everywhere else in the code base. > > C

Re: Review Request 32630: Add style change proposal for constant reference to temporaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32630/#review78229 --- Patch looks great! Reviews applied: [32630] All tests passed. - M

Re: Review Request 32558: Improve compile time of mesos by splitting flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32558/#review78228 --- I know the code-base is currently inconsistent, but let's follow the

Re: Review Request 31838: Fixed authentication failure triggered slave crash.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31838/#review78226 --- I think the bigger problem here is that slave shuts down all the run

Re: Review Request 32630: Add style change proposal for constant reference to temporaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32630/#review78225 --- +1. I'd really like if we could at least try to introduce a tool to

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review78222 --- Ship it! Ship It! - Vinod Kone On March 28, 2015, 2:25 a.m., Til

[Style Proposal] Disallow Capture by Constant Reference to temporary

I would like to propose we disallow capturing temporaries using a constant reference: const T& val = f(); *The reasons, and examples for this are outlined in the proposal here:* [Review Board]: https://reviews.apache.org/r/32630/ [original markdown version]: https://gist.github.com/jmlvanre/8a3de5

Review Request 32630: Add style change proposal for constant reference to temporaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32630/ --- Review request for mesos, Benjamin Hindman and switched to 'mcypark'. Repositor

Re: Review Request 32558: Improve compile time of mesos by splitting flags

> On March 27, 2015, 4:41 p.m., Timothy Chen wrote: > > src/slave/flags.cpp, line 29 > > > > > > How about keeping the same style with namespaces? Just to be consistent > > with everywhere else in the code base. What

Re: Mesos Hadoop Framework 0.1.0

Does this have any pros / cons over Myriad, which runs Yarn on Mesos? Other than not requiring Yarn :) On Saturday, March 28, 2015, Tom Arnfeld wrote: > Hey everyone, > > I thought it best to send an email to the list before merging and tagging > a 0.1.0 release for the Hadoop on Mesos framewor

RE: Open Source re: Code Licensing & Contribution Terms

Adam: Thank you for the note and I apologize for the belated response. At this point we are surveying the terms (licensing, governance, and otherwise) associated with a number of open source projects. I do not have visibility into our use of Mesos, but I have reached out to some people interna

Re: Review Request 31016: Added slave run task decorator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31016/#review78193 --- Looks good. Just some minor cleanup suggestions. include/mesos/hoo

Re: Review Request 30962: Enabled environment decorator to override.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30962/#review78191 --- src/hook/manager.cpp

Re: Review Request 30961: Enabled label decorator to override.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30961/#review78189 --- Minor cleanup/suggestions, but otherwise good. We'll definitely need

Re: Splitting reviews and build emails into their own mailing lists

+1 > On 27 Mar 2015, at 20:19, Vinod Kone wrote: > > Hi, > > What do you guys think about moving the review and build (CI) emails to > their own mailing lists (reviews@ and builds@). > > Quite a few people that I have talked to have mentioned that there is too > much noise on our dev list to g