statusUpdate always RUNNING even after job has finished

I'm building a simple framework as a proof of concept. I launchTasks() successfully and my job (which is nothing but a sleep and an echo) runs fine. I can see its output in the trace files. Mesos UI says "FINSIHED" but statusUpdate keeps returning RUNNING to me over and over again. Any ideas? Zac

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/ --- (Updated April 22, 2015, 8:21 a.m.) Review request for mesos, Ben Mahler, Marco

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

> On April 21, 2015, 11:25 p.m., Jie Yu wrote: > > src/slave/slave.cpp, lines 3065-3078 > > > > > > Instead of doing that in your way, can we just try to make sure > > `containerizer->wait` here will return a failure

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

> On April 21, 2015, 11:25 p.m., Jie Yu wrote: > > src/slave/slave.cpp, lines 3065-3078 > > > > > > Instead of doing that in your way, can we just try to make sure > > `containerizer->wait` here will return a failure

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

> On April 21, 2015, 11:25 p.m., Jie Yu wrote: > > src/slave/slave.cpp, lines 3065-3078 > > > > > > Instead of doing that in your way, can we just try to make sure > > `containerizer->wait` here will return a failure

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

> On April 21, 2015, 11:25 p.m., Jie Yu wrote: > > src/slave/slave.cpp, lines 3065-3078 > > > > > > Instead of doing that in your way, can we just try to make sure > > `containerizer->wait` here will return a failure

Re: Review Request 33376: MESOS-2633 Moved struct Framework methods to their own implementation class.

> On April 21, 2015, 3:27 a.m., Joris Van Remoortere wrote: > > Hey Marco, great first patch! > > Some high level comments: > > - Can you check your editor settings to make sure you don't modify lines > > you don't intend? > > - Just do a quick look over the 'diff' section before publishing a re

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33249/#review81090 --- src/slave/slave.cpp

Re: Review Request 33241: docs: Add documentation on observability metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33241/#review81087 --- Patch looks great! Reviews applied: [33241] All tests passed. - M

Re: Review Request 32843: Updated KILL to include SlaveID.

> On April 20, 2015, 10:46 p.m., Ben Mahler wrote: > > src/master/master.cpp, line 2736 > > > > > > It looks like we can do this without having the extra `killTask` > > method: just have this convert to the `Kill` `C

Re: Review Request 32843: Updated KILL to include SlaveID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32843/ --- (Updated April 21, 2015, 10:57 p.m.) Review request for mesos and Ben Mahler.

Re: Build failed in Jenkins: Mesos » clang,docker||Hadoop,ubuntu:14.10 #159

Thanks for the catch/forward and the jira ticket, is this actively being worked on? Tim On Tue, Apr 21, 2015 at 3:28 PM, Vinod Kone wrote: > https://issues.apache.org/jira/browse/MESOS-1303 > > On Tue, Apr 21, 2015 at 2:50 PM, Apache Jenkins Server > wrote: >> >> See >>

Re: Review Request 33415: Changed launchers and isolators to adapt to the new orphan cleanup semantics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33415/#review81079 --- Bad patch! Reviews applied: [33412, 33413, 33414] Failed command:

Re: Build failed in Jenkins: Mesos » clang,docker||Hadoop,ubuntu:14.10 #159

https://issues.apache.org/jira/browse/MESOS-1303 On Tue, Apr 21, 2015 at 2:50 PM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See < > https://builds.apache.org/job/Mesos/COMPILER=clang,LABEL=docker%7C%7CHadoop,OS=ubuntu%3A14.10/159/changes > > > > Changes: > > [tnachen] Fix destro

Re: Review Request 33241: docs: Add documentation on observability metrics.

> On April 21, 2015, 10:03 a.m., Joe Smith wrote: > > docs/metrics.md, line 227 > > > > > > hm.. offhand I don't recall what this means, but we should get a > > definition here Unless somebody knows what this is, I'm

Re: Review Request 33412: Made the launcher recover interface to return a set of orphan containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33412/#review81077 --- Patch looks great! Reviews applied: [33412] All tests passed. - M

Re: Review Request 33241: docs: Add documentation on observability metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33241/ --- (Updated April 21, 2015, 3:09 p.m.) Review request for mesos. Changes ---

Build failed in Jenkins: Mesos » clang,docker||Hadoop,ubuntu:14.10 #159

See Changes: [tnachen] Fix destroying containerizer during isolator prepare. -- [...truncated 92645 lines...] I0421 21:50:26.543983 23235 replica.c

Review Request 33415: Changed launchers and isolators to adapt to the new orphan cleanup semantics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33415/ --- Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. Bugs: MESOS-2

Review Request 33414: Made MesosContainerizer not fail on recovery if the destroy of orphan containers fails.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33414/ --- Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. Bugs: MESOS-2

Review Request 33413: Changed the isolator recover interface to take a set of orphan containers detected by the launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33413/ --- Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. Bugs: MESOS-2

Review Request 33412: Made the launcher recover interface to return a set of orphan containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33412/ --- Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. Bugs: MESOS-2

Re: Review Request 32140: Enabled 'Resources' to handle 'Resource::ReservationInfo'.

> On March 25, 2015, 5:07 p.m., Timothy Chen wrote: > > include/mesos/resources.hpp, line 182 > > > > > > I'm not sure the following comment adds any value? > > > > "If the optional ReservationInfo is given, t

Re: Review Request 29334: Add option to launch docker containers with helper containers.

> On Jan. 18, 2015, 12:18 p.m., Bernd Mathiske wrote: > > src/slave/containerizer/docker.cpp, line 982 > > > > > > Not checking the outcome of this? > > Timothy Chen wrote: > This is actually reverted in the last

Re: Review Request 32140: Enabled 'Resources' to handle 'Resource::ReservationInfo'.

> On March 18, 2015, 12:27 a.m., Alexander Rukletsov wrote: > > src/common/resources.cpp, lines 69-74 > > > > > > Not yours, but resently, Vinod did a cleanup in equivalence operators > > for our proto messages in `typ

Re: Review Request 33372: Added decorator documentation and described the semantic change in Mesos 0.23.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33372/#review81063 --- Patch looks great! Reviews applied: [30961, 30962, 31016, 31028, 32

Re: Review Request 32139: Added 'Resource::ReservationInfo' protobuf message.

> On April 15, 2015, 5:35 p.m., Alexander Rukletsov wrote: > > include/mesos/mesos.proto, line 409 > > > > > > While `required` here, `principal` is `optional` in `FrameworkInfo`. > > Let's update the comment there to

Re: Review Request 32139: Added 'Resource::ReservationInfo' protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32139/ --- (Updated April 21, 2015, 8:35 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 33372: Added decorator documentation and described the semantic change in Mesos 0.23.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33372/ --- (Updated April 21, 2015, 1:13 p.m.) Review request for mesos and Adam B. Bugs

Re: Review Request 33241: docs: Add documentation on observability metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33241/#review81050 --- High-level comment, this looks good. Ideally, we would be using mark

Re: Review Request 33376: MESOS-2633 Moved struct Framework methods to their own implementation class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33376/#review81049 --- Patch looks great! Reviews applied: [33376] All tests passed. - M

Re: Review Request 32502: Updated RECONCILE call to always specifiy slave id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32502/ --- (Updated April 21, 2015, 7:18 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 33376: MESOS-2633 Moved struct Framework methods to their own implementation class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33376/ --- (Updated April 21, 2015, 7:06 p.m.) Review request for mesos and Joris Van Remo

Re: Review Request 31263: Refactored TestAllocator and allocator text fixture.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31263/#review81040 --- Ship it! Ship It! - Niklas Nielsen On April 21, 2015, 12:02 p.m.

Re: Review Request 31263: Refactored TestAllocator and allocator text fixture.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31263/ --- (Updated April 21, 2015, 7:02 p.m.) Review request for mesos, Kapil Arya, Micha

Re: Review Request 33329: Removed unnecessary freeaddrinfo in getIP if getaddrinfo returns error.

> On April 21, 2015, 4:25 p.m., Evelina Dumitrescu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 200 > > > > > > I wanted to say to keep the freeaddrinfo and initialize result with NULL > >

Re: Review Request 31265: Provided a factory for allocator in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31265/#review81038 --- Ship it! Ship It! - Niklas Nielsen On April 21, 2015, 11:45 a.m.

Re: Review Request 33376: MESOS-2633 Moved struct Framework methods to their own implementation class.

> On April 21, 2015, 3:27 a.m., Joris Van Remoortere wrote: > > Hey Marco, great first patch! > > Some high level comments: > > - Can you check your editor settings to make sure you don't modify lines > > you don't intend? > > - Just do a quick look over the 'diff' section before publishing a re

Re: Review Request 33090: Removed unmaintained frameworks code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33090/#review81036 --- Patch looks great! Reviews applied: [33090] All tests passed. - M

Re: Review Request 32123: Fix destroying containerizer during isolator prepare.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32123/#review81031 --- Ship it! src/slave/containerizer/mesos/containerizer.hpp

Re: Review Request 33329: Removed unnecessary freeaddrinfo in getIP if getaddrinfo returns error.

> On April 21, 2015, 4:25 p.m., Evelina Dumitrescu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 200 > > > > > > I wanted to say to keep the freeaddrinfo and initialize result with NULL I s

Re: Review Request 29947: Fixed a race condition in hook tests for remove-executor hook.

> On April 17, 2015, 1:56 p.m., Niklas Nielsen wrote: > > src/tests/hook_tests.cpp, line 71 > > > > > > Symbol doesn't describe if it is going to be a function or just a > > variable. I wonder if we can come up with a

Re: Review Request 29947: Fixed a race condition in hook tests for remove-executor hook.

> On Feb. 11, 2015, 5:27 a.m., Adam B wrote: > > src/examples/test_hook_module.cpp, line 120 > > > > > > Why would this get called multiple times? > > Kapil Arya wrote: > If for example, someone writes a test case

Re: Review Request 31265: Provided a factory for allocator in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31265/ --- (Updated April 21, 2015, 6:45 p.m.) Review request for mesos, Kapil Arya, Micha

Re: Review Request 29947: Fixed a race condition in hook tests for remove-executor hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29947/ --- (Updated April 21, 2015, 2:44 p.m.) Review request for mesos and Niklas Nielsen

Re: Changing Mesos Minimum Compiler Version

Re: GCC 5.x, specifically section [2] https://gcc.gnu.org/gcc-5/changes.html#offload Although these changes are great, I'm not sure we currently need them for Mesos itself. I agree with you that they could make lots of frameworks rock, and I don't think the gcc version for mesos prevents that:

Re: Review Request 31265: Provided a factory for allocator in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31265/ --- (Updated April 21, 2015, 6:31 p.m.) Review request for mesos, Kapil Arya, Micha

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33249/#review81024 --- Patch looks great! Reviews applied: [33249] All tests passed. - M

Re: Review Request 32505: Added SHUTDOWN scheduler call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32505/#review81020 --- Ship it! Ship It! - Alexander Rukletsov On April 20, 2015, 8:01

Re: Review Request 31265: Provided a factory for allocator in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31265/ --- (Updated April 21, 2015, 6:03 p.m.) Review request for mesos, Kapil Arya, Micha

Re: Review Request 32845: Renamed UNREGISTER call to UNSUBSCRIBE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32845/#review81018 --- Ship it! Ship It! - Alexander Rukletsov On April 20, 2015, 8:04

Re: Review Request 32845: Renamed UNREGISTER call to UNSUBSCRIBE.

> On April 8, 2015, 5:52 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, lines 1626-1628 > > > > > > Shall we check `framework->pid == from` as we do in > > `Master::unregisterFramework()`? > > > >

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/#review81014 --- src/slave/containerizer/docker.cpp

Re: Review Request 33090: Removed unmaintained frameworks code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33090/#review81007 --- Ship it! Also update docs/site as necessary. - Vinod Kone On Apr

Re: Review Request 32844: Added SUBSCRIBE call and SUBSCRIBED event.

> On April 8, 2015, 5:52 p.m., Alexander Rukletsov wrote: > > Looks good to me, mind update the design doc? > > Vinod Kone wrote: > isabel has kindly agreed to update the doc by EOD. Great! - Alexander --- This is an automatically

Re: Review Request 32975: MESOS-1790 Adds chown option to CommandInfo.URI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32975/#review81006 --- Patch looks great! Reviews applied: [32975] All tests passed. - M

Re: Changing Mesos Minimum Compiler Version

The main holdup at the moment is simply cycles I have to convert our internal infrastructure for packaging mesos on all the distributions to use newer compilers on all those distributions. I want the infrastructure for supporting the change in place before we make it. I have about 1/3 of the work d

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33249/ --- (Updated April 21, 2015, 5:14 p.m.) Review request for mesos, Ben Mahler, Timot

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

> On April 21, 2015, 6:03 a.m., Timothy Chen wrote: > > src/slave/slave.cpp, line 3104 > > > > > > mesos namespace should been imported? There are already two TaskStates in slave.cpp, one from the protobuf and one f

Review Request 33090: Removed unmaintained frameworks code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33090/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2640 https://issues.ap

Re: Review Request 33241: docs: Add documentation on observability metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33241/#review80995 --- docs/metrics.md

Re: Review Request 32975: MESOS-1790 Adds chown option to CommandInfo.URI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32975/ --- (Updated April 21, 2015, 5 p.m.) Review request for mesos. Bugs: MESOS-1790

Re: Review Request 32975: MESOS-1790 Adds chown option to CommandInfo.URI

Latest diff on review site looks to have all the fixes. I'm probably not using the review site correctly (closing issues before I upload a diff?) but still the code that's up there matches what I have locally. On Mon, Apr 20, 2015 at 10:20 PM, Adam B wrote: >This is an automatically generate

Re: Review Request 32975: MESOS-1790 Adds chown option to CommandInfo.URI

> On April 13, 2015, 5:45 p.m., Ian Downes wrote: > > src/tests/fetcher_tests.cpp, line 729 > > > > > > Why not use a random username here, like a UUID. Or, check if the user > > exist. fixed as suggested using UUID

Re: Review Request 32506: Added output stream operators for scheduler Calls and Events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32506/#review80992 --- Ship it! Ship It! - Alexander Rukletsov On April 20, 2015, 8:02

Re: Review Request 32843: Updated KILL to include SlaveID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32843/#review80990 --- Ship it! Modulo Ben's comments. - Alexander Rukletsov On April 2

Re: Review Request 33329: Removed unnecessary freeaddrinfo in getIP if getaddrinfo returns error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33329/#review80984 --- 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp

Re: Review Request 32502: Updated RECONCILE call to always specifiy slave id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32502/#review80985 --- Ship it! src/master/master.cpp

Re: Review Request 33358: Moved implementation of StatusUpdateStream to a compilation unit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33358/#review80972 --- Ship it! LGTM assuming no functional changes, just code move. src

Re: Review Request 33358: Moved implementation of StatusUpdateStream to a compilation unit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33358/#review80971 --- Patch looks great! Reviews applied: [33358] All tests passed. - M

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review80968 --- Patch looks great! Reviews applied: [32198, 32163, 30612] All test

Re: Review Request 33296: Added a flag which controls libprocess firewall initialzation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33296/#review80959 --- Patch looks great! Reviews applied: [33295, 33296] All tests passe

Re: Review Request 33358: Moved implementation of StatusUpdateStream to a compilation unit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33358/ --- (Updated April 21, 2015, 2:38 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/ --- (Updated April 21, 2015, 2:07 p.m.) Review request for mesos, Ben Mahler, Marco

Re: Review Request 32163: Added a function which checks if a json object is contained within another.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32163/ --- (Updated April 21, 2015, 2:07 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 32198: Added a not equal operator for json objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32198/ --- (Updated April 21, 2015, 2:06 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 33358: Moved implementation of StatusUpdateStream to a compilation unit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33358/ --- (Updated April 21, 2015, 2:04 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 33296: Added a flag which controls libprocess firewall initialzation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33296/ --- (Updated April 21, 2015, 2:02 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/ --- (Updated April 21, 2015, 2:01 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

> On April 21, 2015, 2:51 a.m., Marco Massenzio wrote: > > src/master/http.cpp, line 298 > > > > > > argubaly this should be DEBUG (but don't really feel strongly about > > this) Agree with you, but every other requ

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

> On April 21, 2015, 12:51 a.m., Marco Massenzio wrote: > > src/master/http.cpp, line 300 > > > > > > can we have all routes patters as CONSTANTS defined in the class > > header? definitely easier to debug etc. Marc

Re: Changing Mesos Minimum Compiler Version

Folks, let's summarize and move on here. Proposal out on April 9, 2015. Current status (as of April 21, 2015): +1 (Binding) -- Vinod Kone Timothy Chen Yan Xu Brenden Matthews +1 (Non-binding) -- Cody Maloney Joris Van Remoortere Jeff Schro

Re: Review Request 32163: Added a function which checks if a json object is contained within another.

> On April 21, 2015, 1:50 a.m., Marco Massenzio wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp, line 315 > > > > > > while I appreciate being thorough, strictly speaking this should not be > > here