Re: [Performance Isolation] Meeting on Thursday May 12 5pm PST

2016-05-05 Thread Niklas Nielsen
talk about additional CFS settings for our cpu isolators I will update the Apache Mesos calendar accordingly. Thanks! Niklas On Thu, Apr 28, 2016 at 12:16 PM, Kevin Klues wrote: > I won't be able to call today. I am on vacation until the 9th. > > On Fri, Apr 29, 2016 at 2:30 A

Re: [Performance Isolation] Meeting on Thursday April 21 2016 5pm PST

2016-04-28 Thread Niklas Nielsen
We will use the same hangout link: https://hangouts.google.com/hangouts/_/intel.com/isolation?hl=en&authuser=1 On Thu, Apr 28, 2016 at 7:30 AM, Niklas Nielsen wrote: > Ian, Kevin: Would you be able to dial in this afternoon instead? > > On Mon, Apr 25, 2016 at 9:00 AM, Niklas N

Re: [Performance Isolation] Meeting on Thursday April 21 2016 5pm PST

2016-04-28 Thread Niklas Nielsen
Ian, Kevin: Would you be able to dial in this afternoon instead? On Mon, Apr 25, 2016 at 9:00 AM, Niklas Nielsen wrote: > Hi all, > > I apologize! this was on me: I got stuck in traffic and couldn't dial in > (and accept the external calls). > Do you have time to reschedu

Re: [Performance Isolation] Meeting on Thursday April 21 2016 5pm PST

2016-04-25 Thread Niklas Nielsen
g but no one was hosting the meeting. > > On Fri, Apr 22, 2016 at 10:04 AM, Kevin Klues wrote: > > > I tried calling into this last night, but no one was there. Was it > > post-poned again? > > > > On Mon, Apr 18, 2016 at 12:03 PM, Niklas Nielsen wrote: > >

[Performance Isolation] Meeting on Thursday April 21 2016 5pm PST

2016-04-18 Thread Niklas Nielsen
Hi everyone, Per our conversation about Intel CAT enablement in Mesos, we are scheduling a Performance Isolation Working Group meeting at Thursday April 21 2016 5pm-6pm PST. Feel free to suggest agenda topics here: https://docs.google.com/document/d/11mlGPZSABItP47J6VX-zB0fAK6Qr1mCIOI7nhlATMqk/ed

Re: [Isolation][Containerization] - Add Intel Cache Allocation Technology(CAT) Isolator Support

2016-04-18 Thread Niklas Nielsen
Hi everyone, Moving off this thread but wanted to bring up that Ian can't join today. Proposing a new time in another thread. Niklas On Mon, Apr 11, 2016 at 10:53 AM, Niklas Nielsen wrote: > Suggesting Monday April 18 5pm PST - I will send out a hangout link when > we get closer.

Re: [Isolation][Containerization] - Add Intel Cache Allocation Technology(CAT) Isolator Support

2016-04-11 Thread Niklas Nielsen
:00 PM PST time is 8:00 AM on my timezone(UTC + 08:00) > I think time slot after 5:00 PM PST will be ok for me. > > Thanks Nik! > > > On 2016/4/9 6:11, Niklas Nielsen wrote: > >> Alright - with that in mind. Will morning, midday or evening PST be >>

Re: [Isolation][Containerization] - Add Intel Cache Allocation Technology(CAT) Isolator Support

2016-04-08 Thread Niklas Nielsen
Alright - with that in mind. Will morning, midday or evening PST be preferred compared to your time zone? On Thu, Apr 7, 2016 at 10:35 PM, Du, Fan wrote: > > > On 2016/4/7 9:18, Niklas Nielsen wrote: > >> On Tue, Apr 5, 2016 at 7:51 PM, Du, Fan wrote: >> >> >

Re: [Isolation][Containerization] - Add Intel Cache Allocation Technology(CAT) Isolator Support

2016-04-06 Thread Niklas Nielsen
most ready in Mesos, > that’s all perf stuff. > Check MESOS-4955 and MESOS-4595 for details. Yep - Bartek had a patch for this > > > > > > On 2016/4/5 23:13, Niklas Nielsen wrote: > >> My gut feeling is that it won't be very useful to expose LLC as a first

Re: [Isolation][Containerization] - Add Intel Cache Allocation Technology(CAT) Isolator Support

2016-04-05 Thread Niklas Nielsen
My gut feeling is that it won't be very useful to expose LLC as a first class resource type at this point. It's very hard to pick for the user and requires framework support everywhere. Also, as Kevin mentioned, Mesos doesn't pin your tasks so you don't know which cores your tasks will be running o

Re: RFC: RevocableInfo Changes

2016-03-28 Thread Niklas Nielsen
Echoing Ben Mahler's comment. I still don't find the ThrottleInfo very intuitive. Did you discuss the general notion of resource quality further? On Mon, Mar 21, 2016 at 11:50 PM, Klaus Ma wrote: > @benm/joris, > > here's the user scenario in my mind: > > 1. master offers resources to the framew

Re: [Proposal] Use dev mailing list for working groups

2016-03-25 Thread Niklas Nielsen
SGTM - let's do it :) On Fri, Mar 25, 2016 at 12:44 AM, Jay JN Guo wrote: > +1 > > Although we really need to agree on one single style and stick to it. > > I thought all mails sending to dev@mesos.apache.org would be [MESOS-dev] > by > default. > So I don't know how much sense it would make to

Re: RFC: RevocableInfo Changes

2016-03-14 Thread Niklas Nielsen
d the performance isolation working group are > > discussing similar annotations and we should meet and talk about the > > options. > > > +1 > > Would love to understand the relationship between this and the > task/executor level annotations. > > - Jie >

Re: RFC: RevocableInfo Changes

2016-03-14 Thread Niklas Nielsen
Hi Ben, Just a quick note: Ian D. and the performance isolation working group are discussing similar annotations and we should meet and talk about the options. Niklas On Sat, Mar 12, 2016 at 12:05 AM, Klaus Ma wrote: > Yes, I think that's true for now; so we define `ThrottleInfo` as message to

Re: Performance isolation working group meeting on Friday 10am PST

2016-02-29 Thread Niklas Nielsen
at 10:09 AM, Ian Downes > wrote: > > > > > we're a little late to get started, it will become accessible shortly > > > > > > > On Feb 26, 2016, at 10:03, Kevin Klues wrote: > > > > > > > > I'm having trouble joining the call.

Performance isolation working group meeting on Friday 10am PST

2016-02-24 Thread Niklas Nielsen
Hi all, We will meet and talk performance isolation on Friday 10am PST, with the agenda: 1) New proposal for core affinity 2) CFS configuration status 3) Workload Benchmarking 4) Discussion on actuating isolation for resources that are accounted / not accounted by Mesos For now, this will be the

Re: Experimentation harnesses?

2016-02-22 Thread Niklas Nielsen
Hi Michael, We are working on this in context of generating workloads (with many different combinations of latency critical workloads co-located with best-effort ones) and testing scenarios for oversubscription and would love to chat Cheers, Niklas On Mon, Feb 22, 2016 at 4:14 PM, James Peach w

Re: [RESULT][VOTE] Release Apache Mesos 0.27.0 (rc2)

2016-02-04 Thread Niklas Nielsen
; > > > - Jie > > > > On Thu, Feb 4, 2016 at 1:22 AM, Niklas Nielsen wrote: > > > >> Awesome guys! > >> > >> Kapil, we usually linked to the user documentation in the blog to the > new > >> features. Do you have a link to the docs o

Re: [RESULT][VOTE] Release Apache Mesos 0.27.0 (rc2)

2016-02-04 Thread Niklas Nielsen
Awesome guys! Kapil, we usually linked to the user documentation in the blog to the new features. Do you have a link to the docs on multiple disk resources? On Wed, Feb 3, 2016 at 11:27 PM, Kapil Arya wrote: > And here is the blog post: > http://mesos.apache.org/blog/mesos-0-27-0-released. > >

Re: Core affinity in Mesos

2016-02-01 Thread Niklas Nielsen
Ben, I agree that isolation encompass more than performance isolation, but instead of inflating with too granular working groups, I thought we could start work under the 'isolation' working group. The group was passive before but had an entry in the document. I have no real preference and can rena

Re: Please review design doc for task resizing

2015-12-09 Thread Niklas Nielsen
7;t done any work yet, I'd maybe defer until we at least have the placement of the 'resize operation' nailed down. > > I'd like to have an online sync up with you, can you please let me know > when you will be online in IRC usually? Or you prefer other ways to syn

Re: Please review design doc for task resizing

2015-12-04 Thread Niklas Nielsen
Hi Qian, Thanks for the update and I apologize the response time. Do you have a PoC implementation of your proposal? I have trouble understanding the motivation of _not_ adding resizing as a usual operation. It seems much cleaner in my mind. To David G's and Alex R's comment: if you want to resi

Re: Finish Oversubscription before 0.26.0?

2015-11-05 Thread Niklas Nielsen
Nope - go ahead and close On Thu, Nov 5, 2015 at 10:24 AM, Jie Yu wrote: > I would say the MVP is done. Of course, there'll be some followup > improvement to the feature, and all the remaining issues are within that > category. I am fine resolving this epic. Any one has any objection? > > - Jie

Re: NetworkInfo change - MESOS-3788

2015-10-22 Thread Niklas Nielsen
n't clear how multiple IP addresses might or might not > be assigned to multiple virtual network interfaces. Would you get one > interface with several IP addresses, or several interfaces with an IP > address each? > > How do we fix it? > > We've coll

Notes from off-line sync on processes for Mesos road maps

2015-10-22 Thread Niklas Nielsen
Hi everyone, Yesterday, a few of us met up to discuss processes for Mesos road maps: how to capture core values of the project, how to prioritize features from users running different workloads and how to delegate specifics of road mapping to the working groups. The meeting notes are available he

Re: Contribution Request for Mesos

2015-10-14 Thread Niklas Nielsen
Hi Yong, You should be on the list now. Looking forward to your contributions! Niklas On 14 October 2015 at 12:29, Yong Tang wrote: > Hi > After using Mesos and following Mesos project for quite some time, I would > like to participate and contribute to the Mesos project. Could I be added > t

[RESULT][VOTE] Release Apache Mesos 0.25.0 (rc3)

2015-10-12 Thread Niklas Nielsen
Hi all, The vote for Mesos 0.25.0 (rc3) has passed with the following votes. +1 (Binding) -- Joris Van Remoortere Michael Park Brenden Matthews +1 (Non-binding) -- Kapil Arya There were no 0 or -1 votes. Please find the releas

Re: [VOTE] Release Apache Mesos 0.25.0 (rc3)

2015-10-12 Thread Niklas Nielsen
t;) on OS X El Capitan >> with >> clang >> >> On Sat, Oct 10, 2015 at 5:44 PM Kapil Arya wrote: >> >> > +1 (non-binding) >> > >> > On Sat, Oct 10, 2015 at 9:58 AM, Joris Van Remoortere < >> jo...@mesosphere.io >> > &g

[VOTE] Release Apache Mesos 0.25.0 (rc3)

2015-10-09 Thread Niklas Nielsen
Hi all, Following up with an RC with the build fix suggested by Kapil: Please vote on releasing the following candidate as Apache Mesos 0.25.0. 0.25.0 includes the following: * [MESOS-1474] - Experimental suppo

Re: [VOTE] Release Apache Mesos 0.25.0 (rc2)

2015-10-09 Thread Niklas Nielsen
;> > ../3rdparty/libprocess/3rdparty/gmock-1.7.0/gtest/include/gtest/gtest.h:1448:16: > >> error: comparison between signed and unsigned integer expressions > >> [-Werror=sign-compare] > >> > >> [17:18:48][Step 4/6]if (expected == actual) { > >&g

Re: Proposal: moving Mesos website to project codebase

2015-10-09 Thread Niklas Nielsen
+1 On 9 October 2015 at 09:50, Yan Xu wrote: > +1 for making it easier for contributors to understand the website code and > collaboratively maintain it! > > -- > Jiang Yan Xu @xujyan > > On Fri, Oct 9, 2015 at 5:21 PM, Paul Brett > wrote: > > > +1 > > > > On Fri, O

[VOTE] Release Apache Mesos 0.25.0 (rc2)

2015-10-05 Thread Niklas Nielsen
Hi all, Please vote on releasing the following candidate as Apache Mesos 0.25.0. 0.25.0 includes the following: * [MESOS-1474] - Experimental support for maintenance primitives. * [MESOS-2600] - Added master e

Re: Patch for the website's Rakefile

2015-10-05 Thread Niklas Nielsen
I can help out; Where can I find the patch? Niklas On 4 October 2015 at 12:31, Dave Lester wrote: > If anyone is attending MesosCon Europe this upcoming week and would like > to make enhancements here I should be available and could pair. There's > lots of low-hanging fruit to make large improv

Re: [VOTE] Release Apache Mesos 0.21.2 (rc1)

2015-10-02 Thread Niklas Nielsen
+1 (binding) On 1 October 2015 at 20:27, Michael Park wrote: > +1 (binding) > > *make distcheck* passed with the Jenkins Build script with > > *OS=ubuntu:15.04 COMPILER=gcc CONFIGURATION="--enable-optimize" > ./support/jenkins_build.sh* > > On Fri, Sep 25, 2015 at 5:29 PM Vinod Kone wrote:

Re: Problems with deprecation cycles for critical/hard to adapt dependencies

2015-09-30 Thread Niklas Nielsen
> still allowing them to move forward at a reasonable pace. > > > > On Mon, Sep 28, 2015 at 2:19 PM, Niklas Nielsen > > wrote: > > > > > Hi everyone, > > > > > > With a (targeted) release cadence of *one month*, we should revisit our > >

Re: Request : Add to contributor list

2015-09-28 Thread Niklas Nielsen
You should be on the list now :) Niklas On 28 September 2015 at 20:04, Mandeep Chadha < mandeep_cha...@yahoo.com.invalid> wrote: > Thanks in advance ! > Best,Mandeep

Problems with deprecation cycles for critical/hard to adapt dependencies

2015-09-28 Thread Niklas Nielsen
Hi everyone, With a (targeted) release cadence of *one month*, we should revisit our deprecation cycles of 3 releases (e.g. in version N, we warn. In version N+1, support both old and new API. In Version N+2, we break compatibility). Sometimes we cannot do the first step, and we deprecate in versi

Re: Testing Mesos 0.25.0 RCs

2015-09-25 Thread Niklas Nielsen
://dist.apache.org/repos/dist/release/mesos/KEYS The JAR is up in Maven in a staging repository here: https://repository.apache.org/content/repositories/orgapachemesos-1076 On 25 September 2015 at 11:14, Niklas Nielsen wrote: > Hi everyone, > > Mesos 0.25.0 rc1 should now be ready for te

Testing Mesos 0.25.0 RCs

2015-09-25 Thread Niklas Nielsen
Hi everyone, Mesos 0.25.0 rc1 should now be ready for testing! [1] While we already know of documentation additions we want in RC2, this is our chance to test and bake the release bits. *Please keep us posted with any failures, crashes, flaky test, unintuitive upgrade paths or deprecations we di

Re: Mesos 0.25.0

2015-09-25 Thread Niklas Nielsen
RCs (again, only regressions, test fixes and documentation at this point). Thanks! Mpark, Joris and Niklas On 24 September 2015 at 17:03, Niklas Nielsen wrote: > Hi everyone! > > We promised to have 0.25.0 RC tagged yesterday and it slipped into this > morning; we are currentl

Re: Mesos 0.25.0

2015-09-24 Thread Niklas Nielsen
Hi everyone! We promised to have 0.25.0 RC tagged yesterday and it slipped into this morning; we are currently working on https://issues.apache.org/jira/browse/MESOS-3510 to make sure the API versioning is in place before tagging. We will base the RC off HEAD as off today at 5:30PM and cherry pic

Re: [VOTE] Release Apache Mesos 0.23.1 (rc1)

2015-09-24 Thread Niklas Nielsen
+1 (binding) Tested on centos7 and ubuntu 14.04 On 24 September 2015 at 07:53, Alexander Rojas wrote: > +1 (non binding) > > Tested Ubuntu 14.04, OSX > > > On 22 Sep 2015, at 03:06, Adam Bordelon wrote: > > > > Hi friends, > > > > Please vote on releasing the following candidate as Apache Meso

Re: [2/2] mesos git commit: Added masterSlaveLostHook.

2015-09-23 Thread Niklas Nielsen
the code. Niklas On 23 September 2015 at 17:10, Benjamin Mahler wrote: > My understanding was that it doesn't apply to all hooks because some hooks > mutate data (e.g. add labels), whereas some hooks are "read-only" > event-like hooks. > > On Wed, Sep 23, 2015 at 4:37 PM,

Re: [2/2] mesos git commit: Added masterSlaveLostHook.

2015-09-23 Thread Niklas Nielsen
ne adding it as it isn't an alternative (yet). Niklas On 23 September 2015 at 16:29, Benjamin Mahler wrote: > Ok, any plan to add TODOs with this context? > > On Wed, Sep 23, 2015 at 4:11 PM, Niklas Nielsen > wrote: > > > On 23 September 2015 at 15:47, Benjamin Mahler

Re: [2/2] mesos git commit: Added masterSlaveLostHook.

2015-09-23 Thread Niklas Nielsen
rg/repos/asf/mesos/repo > > Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/1d86932c > > Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/1d86932c > > Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/1d86932c > > > > Branch: refs/heads/master > &

Re: [VOTE] Release Apache Mesos 0.24.1 (rc1)

2015-09-22 Thread Niklas Nielsen
+1 (binding) On 21 September 2015 at 11:46, Vinod Kone wrote: > +1 (binding) > > Tested on CI for CentOS5 and CentOS6. > > On Fri, Sep 18, 2015 at 6:21 PM, Adam Bordelon wrote: > >> Hi friends, >> >> Please vote on releasing the following candidate as Apache Mesos 0.24.1. >> >> 0.24.1 includes

Working Group List

2015-09-18 Thread Niklas Nielsen
Hi folks, Per our last community meeting, I created a list on our Confluence Wiki to keep track of and increase visibility into the running working groups. We have previously created these groups implicitly, and as the community grow, we unfortunately ended up with duplicate meetings with differen

Re: Mesos 0.25.0

2015-09-09 Thread Niklas Nielsen
. Please tag your tickets you want in this release with 0.25.0 target or fix version and we will track the progress of the tickets up to the deadlines. Let us know if this doesn't make sense or if you have any objections. Cheers, Joris, Mpark and Niklas On 31 August 2015 at 11:34, Niklas Ni

Re: [VOTE] Release Apache Mesos 0.24.0 (rc2)

2015-09-03 Thread Niklas Nielsen
+1 - tested on our CI On Tuesday, September 1, 2015, Vinod Kone wrote: > Hi all, > > > Please vote on releasing the following candidate as Apache Mesos 0.24.0. > > > 0.24.0 includes the following: > > > > > Experime

Re: Mesos 0.25.0

2015-08-31 Thread Niklas Nielsen
gt; primitives (dynamic reservation + persistent volume): > > > > > >- Operator API > > >- Authorization > > > > > > Thanks, > > > > > > MPark. > > > > > > On Thu, Aug 27, 2015 at 7:24 PM Niklas Nielsen > >

Mesos 0.25.0

2015-08-27 Thread Niklas Nielsen
Hi folks, While we have 0.24.0 in flight (voting and fixing is in progress), with a release cadence of 1 month, we should consider to start thinking about 0.25.0. I have cycles to release manage this one (and bring some of the newer committers on for shadowing). If others want to take this on (or

Re: [VOTE] Release Apache Mesos 0.24.0 (rc1)

2015-08-27 Thread Niklas Nielsen
or /bin, lib, and /lib64 when preparing test root > filesystem. > > Review: https://reviews.apache.org/r/37684 > > > > On Thu, Aug 27, 2015 at 3:30 PM, Niklas Nielsen > wrote: > >> -1: sudo make check on centos 7 >> >> [--] Global test en

Re: [VOTE] Release Apache Mesos 0.24.0 (rc1)

2015-08-27 Thread Niklas Nielsen
-1: sudo make check on centos 7 [--] Global test environment tear-down [==] 793 tests from 121 test cases ran. (606946 ms total) [ PASSED ] 786 tests. [ FAILED ] 7 tests, listed below: [ FAILED ] UserCgroupIsolatorTest/1.ROOT_CGROUPS_UserCgroup, where TypeParam = mesos::i

Re: Why does allocator keep track of the revocable resources separately from regular resources

2015-08-24 Thread Niklas Nielsen
On 16 August 2015 at 02:56, Qian AZ Zhang wrote: > Thanks Niklas and Christos. > > To Niklas, we'd like to try oversubscription feature with our framework. > However, I do not quite understand your example below: > >> For example: cpus: 0.5; cpus{REV}: 1.89; mem: 512. > >> Here, schedulers wo

Re: Why does allocator keep track of the revocable resources separately from regular resources

2015-08-15 Thread Niklas Nielsen
Hi Qian, Yes; frameworks will have to: 1) Register with the revocable resources framework capability set; the important bit here, is that frameworks running on oversubscribed resources will have to cope with frequent preemptions of their tasks. We wanted to gain experience with this (experimental

Re: Add klaus1982 as contributor for MESOS-3023

2015-07-14 Thread Niklas Nielsen
You should have been added by now On 14 July 2015 at 09:12, wrote: > Hi team, > > I'm working on MESOS-3023 (Factoring out the pattern for URL generation), > and have a fix for it; would you help to add me into contributor list? so I > can assign it to myself and trigger review process :). > > M

Re: Regarding old frameworks in Mesos repository

2015-06-24 Thread Niklas Nielsen
On 24 June 2015 at 10:55, Yan Xu wrote: > If we anticipated further development we wouldn't have proposed moving them > out. :) > So I think it's safe to say that we are just looking for a graveyard for > them. Do the policies still apply? > That said, if they cannot be moved out, we should still

Re: Native code error

2015-06-09 Thread Niklas Nielsen
gards, > > 2015-06-03 19:36 GMT+02:00 Niklas Nielsen : > >> Hi Alberto, >> >> Can you share the full crash report with us? >> >> Niklas >> >> On 2 June 2015 at 02:37, Alberto Rodriguez wrote: >> >> > Hi all, >> > >> >

Re: Shepherd for MESOS-2637

2015-06-05 Thread Niklas Nielsen
I can help you out. On 5 June 2015 at 09:51, Colin Williams wrote: > Can I get a shepherd for https://issues.apache.org/jira/browse/MESOS-2637 > ? > It's been completed for a while and I think I've addressed all of the > concerns raised. > > Thanks, > Colin >

Re: Native code error

2015-06-03 Thread Niklas Nielsen
Hi Alberto, Can you share the full crash report with us? Niklas On 2 June 2015 at 02:37, Alberto Rodriguez wrote: > Hi all, > > I've got a bunch of tests that are checking whether my spark process is > able to connect to a mesos cluster. The "happy path" (mesos up & running) > is working fine

Re: Custom Mesos Allocation module

2015-05-26 Thread Niklas Nielsen
Hi Dariia, Allocator modules was first added to the master May 14th (git sha 614efe18cf3c7b02a2f3c8269c8eb76cbbe4ddd4), which version of the source are you looking into? You should be able to configure your allocator module as usual ( https://github.com/apache/mesos/blob/master/docs/modules.md) a

Re: Scaling Proposal: MAINTAINERS Files

2015-05-15 Thread Niklas Nielsen
anks for this Ben! > > > > > > > > > > > On Feb 10, 2015, at 8:56 PM, Cody Maloney > > > wrote: > > > > > > > > > > > > +1 > > > > > > > > > > > > It would be nice if there was way t

Re: Virtual Floating specific, or non-specific IP(v4/v6), addresses for tasks

2015-05-13 Thread Niklas Nielsen
We are several folks (organizations and companies) that are working on Mesos Networking (which is awesome btw!) I revived our ticket on per-container IP and I think we have the critical mass to start a *community meeting* on this :) I suggest we fill in more thoughts and ideas in the suggested arc

Re: Enabling 'network' namespace for custom network isolators

2015-05-11 Thread Niklas Nielsen
(inlined) On 11 May 2015 at 14:30, Kapil Arya wrote: > On Mon, May 11, 2015 at 4:58 PM, Jie Yu wrote: > > > > > > > Yes. The simplest (cleanest?) way that I see would be to refactor the > > > launcher to take the desired flags when executing the executor, i.e., > > > (Linux)Launcher::fork() tak

Re: [VOTE] Release Apache Mesos 0.22.1 (rc6)

2015-05-04 Thread Niklas Nielsen
+1 Verified with test cluster On 4 May 2015 at 15:45, Timothy Chen wrote: > +1 Verified with test cluster and running make check myself. > > Tim > > On Fri, May 1, 2015 at 2:28 PM, Alexander Rojas > wrote: > > +1 non binding (Tested in OSX and 3 VM’s cluster running Ubuntu 12.10) > > > >> On 30

Re: Review Request 33372: Added decorator documentation and described the semantic change in Mesos 0.23.0

2015-04-21 Thread Niklas Nielsen
. Bugs: MESOS-2622 https://issues.apache.org/jira/browse/MESOS-2622 Repository: mesos Description --- See summary. Diffs (updated) - docs/modules.md a8b471541cdfa584eeb89fbe96643f93c712cfd4 Diff: https://reviews.apache.org/r/33372/diff/ Testing --- Thanks, Niklas Nielsen

Re: Review Request 31263: Refactored TestAllocator and allocator text fixture.

2015-04-21 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31263/#review81040 --- Ship it! Ship It! - Niklas Nielsen On April 21, 2015, 12:02 p.m

Re: Review Request 31265: Provided a factory for allocator in tests.

2015-04-21 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31265/#review81038 --- Ship it! Ship It! - Niklas Nielsen On April 21, 2015, 11:45 a.m

Re: Review Request 32859: Add Camel-case libprocess variable and method names sample.

2015-04-20 Thread Niklas Nielsen
> On April 6, 2015, 8:06 p.m., Joris Van Remoortere wrote: > > Hi haosdent, > > I added some higher level comments in the JIRA ticket for you :-) > > Niklas Nielsen wrote: > haosdent, did you get a chance to take a look at Joris' comments? Do you > need to u

Re: Review Request 31017: Fixed comment for remove executor hook.

2015-04-20 Thread Niklas Nielsen
Thanks, Niklas Nielsen

Re: Review Request 32948: Refactored VerifyMasterLaunchTaskHook to _not_ use command executor.

2015-04-20 Thread Niklas Nielsen
check (test broke previously with an assert as the TestContainerizer cannot be used with a command executor) Thanks, Niklas Nielsen

Re: Review Request 31028: Added slave run task hook tests.

2015-04-20 Thread Niklas Nielsen
-mail. To reply, visit: https://reviews.apache.org/r/31028/#review80822 ----------- On April 20, 2015, 1:17 p.m., Niklas Nielsen wrote: > > --- > This is an automatically generated e-

Re: Review Request 33372: Added decorator documentation and described the semantic change in Mesos 0.23.0

2015-04-20 Thread Niklas Nielsen
sting --- Thanks, Niklas Nielsen

Re: Review Request 33372: Added decorator documentation and described the semantic change in Mesos 0.23.0

2015-04-20 Thread Niklas Nielsen
. Changes --- added JIRA Repository: mesos Description --- See summary. Diffs - docs/modules.md a8b471541cdfa584eeb89fbe96643f93c712cfd4 Diff: https://reviews.apache.org/r/33372/diff/ Testing --- Thanks, Niklas Nielsen

Re: Review Request 31028: Added slave run task hook tests.

2015-04-20 Thread Niklas Nielsen
track > > all these label k/v strings. > > Niklas Nielsen wrote: > I would prefer if we could defer this to a subsequent review; we use foo, > bar, baz, qux quite a few places for label testing. Is that OK with you? I > can create a JIRA for it now if you'd like. > &g

Re: Review Request 31016: Added slave run task decorator.

2015-04-20 Thread Niklas Nielsen
7744df55a2a31446327da7bd2b16457e90711d22 src/tests/mesos.cpp fc534e9febed1e293076e00e0f5c3879a78df90f Diff: https://reviews.apache.org/r/31016/diff/ Testing --- make check Thanks, Niklas Nielsen

Review Request 33372: Added decorator documentation and described the semantic change in Mesos 0.23.0

2015-04-20 Thread Niklas Nielsen
--- See summary. Diffs - docs/modules.md a8b471541cdfa584eeb89fbe96643f93c712cfd4 Diff: https://reviews.apache.org/r/33372/diff/ Testing --- Thanks, Niklas Nielsen

Re: Review Request 31016: Added slave run task decorator.

2015-04-20 Thread Niklas Nielsen
> this is wedged between setting up different unschedule calls. Seems like we > > should either decorate the labels as early as possible, right after (or > > before?) the pid/id/state checks; or, if we need to delay it, we could do > > it after the unschedules. > > Nikla

Re: Review Request 31017: Fixed comment for remove executor hook.

2015-04-20 Thread Niklas Nielsen
Thanks, Niklas Nielsen

Re: Review Request 31028: Added slave run task hook tests.

2015-04-20 Thread Niklas Nielsen
bb9de25bd2c4601d333a3ca1aec13820c7df7378 Diff: https://reviews.apache.org/r/31028/diff/ Testing --- make check (with newly added VerifySlaveRunTaskHook test) Thanks, Niklas Nielsen

Re: Review Request 32948: Refactored VerifyMasterLaunchTaskHook to _not_ use command executor.

2015-04-20 Thread Niklas Nielsen
check (test broke previously with an assert as the TestContainerizer cannot be used with a command executor) Thanks, Niklas Nielsen

Re: Review Request 31016: Added slave run task decorator.

2015-04-20 Thread Niklas Nielsen
> this is wedged between setting up different unschedule calls. Seems like we > > should either decorate the labels as early as possible, right after (or > > before?) the pid/id/state checks; or, if we need to delay it, we could do > > it after the unschedules. > > Nikla

Re: Review Request 30962: Enabled environment decorator to override.

2015-04-20 Thread Niklas Nielsen
7a4cb09bc221af502e867cfb7fff2900b599ff1f Diff: https://reviews.apache.org/r/30962/diff/ Testing --- make check Thanks, Niklas Nielsen

Re: Review Request 30961: Enabled label decorator to override.

2015-04-20 Thread Niklas Nielsen
modified VerifyMasterLaunchTaskHook test) Thanks, Niklas Nielsen

Re: Review Request 31645: Added upgrade path test script

2015-04-20 Thread Niklas Nielsen
and upload a new review request :) - Niklas Nielsen On March 2, 2015, 3:44 p.m., Niklas Nielsen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32999: Added a document for engineering principles and practices.

2015-04-20 Thread Niklas Nielsen
tps://reviews.apache.org/r/32999/#comment130914> Long lines :) Do you think it is worth applying the 80 col style? If so, we should do a scan. s/**high quality**, **robust** code/**high quality** and **robust** code/? - Niklas Nielsen On April 8, 2015, 5:30 p.m., Ben Mahler

Re: Review Request 32998: Split committer's guide into code reviewing and committing documents.

2015-04-20 Thread Niklas Nielsen
-- > > (Updated April 8, 2015, 5:30 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Jie Yu, Niklas Nielsen, > and Vinod Kone. > > > Bugs: MESOS-2581 > https://issues.apache.org/jira/browse/MESOS-2581 > >

Re: Review Request 32996: Updated roadmap document to link to 'Epic' tickets.

2015-04-20 Thread Niklas Nielsen
996/#comment130903> It sounds a bit hostile (it may just be me), how about something like "For comments and suggestions for the Mesos roadmap, feel free to reach out to the Mesos dev list" - Niklas Nielsen On April 8, 2015, 5:30 p.m.,

Re: Review Request 32995: Split up documentation for reporting bugs and submitting patches.

2015-04-20 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32995/#review80784 --- Ship it! Ship It! - Niklas Nielsen On April 8, 2015, 5:30 p.m

Re: Review Request 32859: Add Camel-case libprocess variable and method names sample.

2015-04-20 Thread Niklas Nielsen
t; > > Review request for mesos, Joris Van Remoortere and Niklas Nielsen. > > > Bugs: MESOS-2576 > https://issues.apache.org/jira/browse/MESOS-2576 > > > Repository: mesos > > > Description > --- > > Add Camel-case libprocess variabl

Re: Review Request 32198: Added a not equal operator for json objects.

2015-04-20 Thread Niklas Nielsen
tps://reviews.apache.org/r/32198/#comment130593> How about also checking for a larger array? - Niklas Nielsen On March 23, 2015, 7:19 a.m., Alexander Rojas wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 30961: Enabled label decorator to override.

2015-04-17 Thread Niklas Nielsen
rated e-mail. To reply, visit: https://reviews.apache.org/r/30961/#review79454 ------- On April 7, 2015, 5:57 p.m., Niklas Nielsen wrote: > > --- > This is a

Re: Review Request 31028: Added slave run task hook tests.

2015-04-17 Thread Niklas Nielsen
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31028/#review79804 ----------- On April 11, 2015, 3:03 a.m., Niklas Nielsen wrote: > >

Re: Review Request 31016: Added slave run task decorator.

2015-04-17 Thread Niklas Nielsen
src/hook/manager.cpp 7a4cb09bc221af502e867cfb7fff2900b599ff1f > src/slave/slave.hpp 19e6b44bc344c0ca509674803f401cbb4e1f47ae > src/slave/slave.cpp 9fec023b643d410f4d511fa6f80e9835bab95b7e > > Diff: https://reviews.apache.org/r/31016/diff/ > > > Testing > --- > > make check > > > Thanks, > > Niklas Nielsen > >

Re: Review Request 31028: Added slave run task hook tests.

2015-04-17 Thread Niklas Nielsen
ly generated e-mail. To reply, visit: https://reviews.apache.org/r/31028/#review79804 ------- On April 11, 2015, 3:03 a.m., Niklas Nielsen wrote: > > --- > This is an auto

Re: Review Request 29947: Fixed a race condition in hook tests for remove-executor hook.

2015-04-17 Thread Niklas Nielsen
che.org/r/29947/#comment130422> This is the part I hoped we could get around. Can you add a todo with the jira referring to the technical debt? src/tests/hook_tests.cpp <https://reviews.apache.org/r/29947/#comment130423> s/ / / - Niklas Niels

Re: Review Request 30961: Enabled label decorator to override.

2015-04-15 Thread Niklas Nielsen
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30961/#review79454 --- On April 7, 2015, 5:57 p.m., Niklas Nielsen wrote: > > ---

Re: Review Request 32961: Allow framework re-registeration to update master http fields.

2015-04-15 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32961/#review80204 --- Ship it! Ship It! - Niklas Nielsen On April 14, 2015, 9:30 a.m

Oversubscription design doc

2015-04-14 Thread Niklas Nielsen
Hi everyone, In context of some of the recent discussions on 'Resource overcommittal', we are very interested and invested in enabling oversubscription in Mesos in a safe and efficient way. Some of the community members have been working on an architecture document and prototypes recently and feel

Re: Review Request 32948: Refactored VerifyMasterLaunchTaskHook to _not_ use command executor.

2015-04-11 Thread Niklas Nielsen
(test broke previously with an assert as the TestContainerizer cannot be used with a command executor) Thanks, Niklas Nielsen

  1   2   3   4   5   6   7   8   9   10   >