Review Request 26775: Added module loading support for local clusters.

- src/local/local.cpp 66de798 Diff: https://reviews.apache.org/r/26775/diff/ Testing --- make check & functional check using upcoming module related patches. Thanks, Till Toenshoff

Large changes on the codebase due to MESOS-1872

Hey Everyone, I would like to reach out to the developer community for making sure that we find a consensus on https://issues.apache.org/jira/browse/MESOS-1872 and other, entire code-base affecting changes. Evelina has bravely proposed three r

Re: Review Request 26605: Cleanup right angle bracket in the code base.

> On Oct. 13, 2014, 9:17 a.m., Till Toenshoff wrote: > > Thanks for proposing this patch Evelina. > > > > Could you please split this into seperate patches for stout, libprocess and > > mesos itself? > > Evelina Dumitrescu wrote: > What do you mean

Re: Review Request 26605: Cleanup right angle bracket in the code base.

this into seperate patches for stout, libprocess and mesos itself? - Till Toenshoff On Oct. 11, 2014, 6:31 p.m., Evelina Dumitrescu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 26629: Replace cerr/exit with EXIT when parsing master flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26629/#review56361 --- Ship it! Ship It! - Till Toenshoff On Oct. 12, 2014, 8:11 p.m

Re: Review Request 26509: Added --module flag for Mesos slave.

--- On Oct. 11, 2014, 1:25 a.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26509/ > --- > > (Updated Oct. 11, 2014, 1:25 a

Re: Review Request 26509: Added --module flag for Mesos slave.

> On Oct. 10, 2014, 11:26 p.m., Till Toenshoff wrote: > > src/slave/main.cpp, line 117 > > <https://reviews.apache.org/r/26509/diff/5/?file=717907#file717907line117> > > > > Not yours but this would trigger a glog warning as it has not yet been > > in

Re: Review Request 26588: Fixed small typo in master module flags description.

Niklas Nielsen. Repository: mesos-git Description --- see summary. Diffs - src/master/flags.hpp 44249f8 Diff: https://reviews.apache.org/r/26588/diff/ Testing --- Thanks, Till Toenshoff

Review Request 26588: Fixed small typo in master module flags description.

Description --- see summary. Diffs - src/master/flags.hpp 44249f8 Diff: https://reviews.apache.org/r/26588/diff/ Testing --- Thanks, Till Toenshoff

Re: Review Request 26571: Fixed ZooKeeper 3.4.5 OSX Yosemite build.

ated e-mail. To reply, visit: https://reviews.apache.org/r/26571/#review56234 --- On Oct. 10, 2014, 7:19 p.m., Till Toenshoff wrote: > > --- > This is an automatically generated

Re: Review Request 26509: Added --module flag for Mesos slave.

some point. - Till Toenshoff On Oct. 10, 2014, 10:04 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Review Request 26571: Fixed ZooKeeper 3.4.5 OSX Yosemite build.

it - I will update this accordingly. Diffs - 3rdparty/zookeeper-3.4.5.patch PRE-CREATION Diff: https://reviews.apache.org/r/26571/diff/ Testing --- make check (OSX 10.10 BETA5) Thanks, Till Toenshoff

Re: Review Request 26508: Added --module flag for Mesos master.

> On Oct. 10, 2014, 1:17 p.m., Till Toenshoff wrote: > > src/master/flags.hpp, line 319 > > <https://reviews.apache.org/r/26508/diff/4/?file=717127#file717127line319> > > > > Seems you should rephrase this towards "path" or adapt the protobuf >

Re: Review Request 26508: Added --module flag for Mesos master.

508/#comment96461> Seems you should rephrase this towards "path" or adapt the protobuf within messages.proto to use "file" instead. - Till Toenshoff On Oct. 9, 2014, 11:19 p.m., Kapil Arya wrote: > > --- > T

Re: Review Request 26352: Add --with-curl to libprocess since needs it.

> On Oct. 6, 2014, 1:30 p.m., Till Toenshoff wrote: > > 3rdparty/libprocess/configure.ac, line 99 > > <https://reviews.apache.org/r/26352/diff/1/?file=714029#file714029line99> > > > > Is there a reason you are not adhering to that without_bundled_xxx

Re: Review Request 26352: Add --with-curl to libprocess since needs it.

g/r/26352/#comment95882> Is there a reason you are not adhering to that without_bundled_xxx scheme we are using for other bundled libraries? - Till Toenshoff On Oct. 5, 2014, 9:02 a.m., Michael Park wrote: > > --- > This is a

Re: Review Request 26229: Expose poll interval from the reaper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26229/#review55492 --- Ship it! Ship It! - Till Toenshoff On Oct. 1, 2014, 2:12 p.m

Re: Review Request 26229: Expose poll interval from the reaper.

g/r/26229/#comment95879> Did we decide on our auto use-cases yet? If I remember correctly, then we did definitely say that iterators are a perfect use case for auto and that Option/Try are an antipattern use case. - Till Toenshoff On Oct. 1, 2014, 2:12 p.m., Alexander Rukletsov

Re: [VOTE] Release Apache Mesos 0.20.1 (rc3)

+1 make check on OSX 10.9.5, clang 3.5 (Xcode 6) ->all tests passed On Sep 19, 2014, at 3:03 AM, Vinod Kone wrote: > +1 (binding) > > sudo make check on CentOS 5.5 w/ gcc-4.8.2 > > On Thu, Sep 18, 2014 at 4:05 PM, Adam Bordelon wrote: > Hi all, > > Please vote on releasing the following can

Re: Review Request 25434: Propagate slave shutdown grace period to Executor and CommandExecutor.

hutdown in 100% of all attempts once the user supplies a period below 3 seconds (due to the fact that the reaper has a period of 1 second, hence at least 1 second should be waited before triggering a SIGKILL). - Till Toenshoff On Sept. 8, 2

Re: Review Request 22169: Added External Containerizer documentation.

--- Thanks, Till Toenshoff

Re: Review Request 25334: Fixed python egg proto imports.

mesos.interface Python egg generation. Diffs (updated) - src/Makefile.am 5526189 Diff: https://reviews.apache.org/r/25334/diff/ Testing --- make check (OSX and linux) functional test by running build/src/examples/python/test-containerizer Thanks, Till Toenshoff

Re: Review Request 25334: Fixed python egg proto imports.

s://reviews.apache.org/r/25334/#review52316 --- On Sept. 4, 2014, 11:46 a.m., Till Toenshoff wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 25334: Fixed python egg proto imports.

s, will do - thanks for reviewing. - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25334/#review52331 --- On Sept

Re: The mesos.interface python egg

> Has someone been changing things relating to the new *mesos.interface* python > egg on pypi? I don't seem to be able to install it anymore.. which is > strange as it's listed as available on the pypi site. > > Here's some output: https://gist.github.com/tarnfeld/dcf936eb247c7bd5d2d1 I am gettin

Review Request 25334: Fixed python egg proto imports.

://reviews.apache.org/r/25334/diff/ Testing --- make check (OSX and linux) functional test by running build/src/examples/python/test-containerizer Thanks, Till Toenshoff

Re: Review Request 22169: Added External Containerizer documentation.

-seqdiag.png PRE-CREATION docs/images/ec-recover-seqdiag.png PRE-CREATION Diff: https://reviews.apache.org/r/22169/diff/ Testing --- Thanks, Till Toenshoff

libprocess Protocol usage problem

Hey Devs, I got a tough nut to crack and my progress is severely slowed down by this beast; For testing the ExternalContainerizer, I had implemented a shim daemon that wraps the MesosContainerizerProcess. That daemon appears to work fine, it is the command exchange with that daemon that seems

Re: External Containerizer / 0.19.0 / Mesos+Docker

Hey Tom et Al, > I’m in the process of attempting to productionize the external containerizer > (well, we’re still in the mesos proof-of-concept phase but treating it as we > would production) and have a couple of things I wanted to bring up. It’d be > great to get some feedback from anyone wor

Review Request 22169: Added External Containerizer documentation.

markdown document describing the ExternalContainerizer. Diffs - docs/external-containerizer.md PRE-CREATION docs/home.md 6a512de Diff: https://reviews.apache.org/r/22169/diff/ Testing --- Thanks, Till Toenshoff

[jira] [Commented] (MESOS-1385) clang: error: unknown argument: '-fstack-protector-strong'

[ https://issues.apache.org/jira/browse/MESOS-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14013194#comment-14013194 ] Till Toenshoff commented on MESOS-1385: --- When running {{python-config --cf

Re: Review Request 22028: Cut 0.19.0 off of master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22028/#review44280 --- Ship it! Ship It! - Till Toenshoff On May 29, 2014, 6:13 p.m

[jira] [Commented] (MESOS-1431) io::splice usage needs special care - especially in connection with process::subprocess

[ https://issues.apache.org/jira/browse/MESOS-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14012037#comment-14012037 ] Till Toenshoff commented on MESOS-1431: --- co

[jira] [Commented] (MESOS-1431) io::splice usage needs special care - especially in connection with process::subprocess

[ https://issues.apache.org/jira/browse/MESOS-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14012026#comment-14012026 ] Till Toenshoff commented on MESOS-1431: --- co

[jira] [Created] (MESOS-1434) MesosContainerizerIsolatorPreparationTest.ScriptFails seems flaky

Till Toenshoff created MESOS-1434: - Summary: MesosContainerizerIsolatorPreparationTest.ScriptFails seems flaky Key: MESOS-1434 URL: https://issues.apache.org/jira/browse/MESOS-1434 Project: Mesos

Re: Review Request 22001: Fixed missing cloexec and switched to io::redirect in MesosContainerizer.

://reviews.apache.org/r/22001/diff/ Testing --- make check Thanks, Till Toenshoff

Re: Review Request 21966: Fixed ExternalContainerizer fd leak and premature close.

://reviews.apache.org/r/21966/diff/ Testing --- make check as well as Deimos (ECP) intergration tests Thanks, Till Toenshoff

Re: Review Request 22001: Fixed missing cloexec and switched to io::redirect in MesosContainerizer.

th for 'to' > > instead of a file descriptor? Then this code would be really slim! Aye, doing that in few moments. - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.a

Re: Review Request 21966: Fixed ExternalContainerizer fd leak and premature close.

sense - will fix that here and in the MC RR as well. - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21966/#review44227 -----

[jira] [Commented] (MESOS-1431) io::splice usage needs special care - especially in connection with process::subprocess

[ https://issues.apache.org/jira/browse/MESOS-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011987#comment-14011987 ] Till Toenshoff commented on MESOS-1431: --- https://reviews.apache.org/r/2

Re: Review Request 21966: Fixed ExternalContainerizer fd leak and premature close.

e of this danger, MESOS-1431 was created. - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21966/#review44193 ---

Re: Review Request 21966: Fixed ExternalContainerizer fd leak and premature close.

/r/21966/diff/ Testing --- make check as well as Deimos (ECP) intergration tests Thanks, Till Toenshoff

Re: Review Request 21966: Fixed ExternalContainerizer fd leak and premature close.

tests Thanks, Till Toenshoff

Re: Review Request 21966: Fixed ExternalContainerizer fd leak and premature close.

) intergration tests Thanks, Till Toenshoff

Review Request 22001: Fixed missing cloexec and switched to io::redirect in MesosContainerizer.

https://issues.apache.org/jira/browse/MESOS-1431 Repository: mesos-git Description --- see summary. Diffs - src/slave/containerizer/mesos_containerizer.cpp d01d443 Diff: https://reviews.apache.org/r/22001/diff/ Testing --- make check Thanks, Till Toenshoff

Re: Review Request 21966: Fixed ExternalContainerizer fd leak and premature close.

debugging. - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21966/#review44193 --- On May 28, 2014, 8:26 p.m., Till Toenshoff wrote: > > --

[jira] [Commented] (MESOS-1427) clang++ 3.2 build error: calling a private constructor of class 'mesos::internal::state::protobuf::Variable'

[ https://issues.apache.org/jira/browse/MESOS-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011889#comment-14011889 ] Till Toenshoff commented on MESOS-1427: --- Are we supporting clang 3.2? I was u

[jira] [Commented] (MESOS-1432) Atomically set close-on-exec where possible.

[ https://issues.apache.org/jira/browse/MESOS-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011886#comment-14011886 ] Till Toenshoff commented on MESOS-1432: --- Some pretty helpful debug code on

[jira] [Commented] (MESOS-1431) io::splice usage needs special care - especially in connection with process::subprocess

[ https://issues.apache.org/jira/browse/MESOS-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011881#comment-14011881 ] Till Toenshoff commented on MESOS-1431: --- Fixes for mesos_containerizer

[jira] [Updated] (MESOS-1431) io::splice usage needs special care - especially in connection with process::subprocess

[ https://issues.apache.org/jira/browse/MESOS-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Toenshoff updated MESOS-1431: -- Assignee: Till Toenshoff > io::splice usage needs special care - especially in connection w

[jira] [Commented] (MESOS-1431) io::splice usage needs special care - especially in connection with process::subprocess

[ https://issues.apache.org/jira/browse/MESOS-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011864#comment-14011864 ] Till Toenshoff commented on MESOS-1431: --- Addendum; the better fix would be u

[jira] [Created] (MESOS-1431) io::splice usage needs special care - especially in connection with process::subprocess

Till Toenshoff created MESOS-1431: - Summary: io::splice usage needs special care - especially in connection with process::subprocess Key: MESOS-1431 URL: https://issues.apache.org/jira/browse/MESOS-1431

Re: Review Request 21964: Adding maven to docs

or if --disable" for the sake of consistency, or what do you think? - Till Toenshoff On May 28, 2014, 5:39 a.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request 21966: Fixed ExternalContainerizer fd leak and premature close.

/containerizer/external_containerizer.cpp b39c845 Diff: https://reviews.apache.org/r/21966/diff/ Testing (updated) --- make check as well as Deimos (ECP) intergration tests Thanks, Till Toenshoff

Re: Review Request 21950: Verbose Maven configure error

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21950/#review44092 --- Ship it! Ship It! - Till Toenshoff On May 28, 2014, 2:43 a.m

Review Request 21966: Fixed ExternalContainerizer fd leak.

summary. Diffs - src/slave/containerizer/external_containerizer.cpp b39c845 Diff: https://reviews.apache.org/r/21966/diff/ Testing --- make check Thanks, Till Toenshoff

Re: Review Request 21950: Verbose Maven configure error

ly, you may setup the MAVEN_HOME environment variable pointing to your Maven installation." Please feel free to adjust this to a better/shorter english as that definitely is not my mother tongue ;) - Till Toenshoff On May 28, 2014, 12:52 a.m., Isab

[jira] [Closed] (MESOS-1413) MesosContainerizerExecuteTest.IoRedirection fails on OSX

[ https://issues.apache.org/jira/browse/MESOS-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Toenshoff closed MESOS-1413. - > MesosContainerizerExecuteTest.IoRedirection fails on

[jira] [Commented] (MESOS-1413) MesosContainerizerExecuteTest.IoRedirection fails on OSX

[ https://issues.apache.org/jira/browse/MESOS-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14010464#comment-14010464 ] Till Toenshoff commented on MESOS-1413: --- co

Re: Review Request 21833: Fixed MesosContainerizerExecuteTest.IoRedirection for OSX.

works for me! :-) Suggested a proper cleanup in MESOS-1424. For the sake of consistency, I will drop this issue. - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21

Re: Review Request 21833: Fixed MesosContainerizerExecuteTest.IoRedirection for OSX.

/r/21833/diff/ Testing --- make check (OSX and linux) Thanks, Till Toenshoff

[jira] [Created] (MESOS-1424) Mesos tests should not rely on echo

Till Toenshoff created MESOS-1424: - Summary: Mesos tests should not rely on echo Key: MESOS-1424 URL: https://issues.apache.org/jira/browse/MESOS-1424 Project: Mesos Issue Type: Improvement

Re: Review Request 21424: Fixed orphaned container handling in the ExternalContainerizer recover implementation.

> On May 24, 2014, 9:09 p.m., Niklas Nielsen wrote: > > Modulo a clarifying comment. > > Niklas Nielsen wrote: > Just took this patch for a spin and I am running into problems with EC > recovery during startup. Would you mind reaching out before committing? >

Re: Review Request 21424: Fixed orphaned container handling in the ExternalContainerizer recover implementation.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21424/#review43901 --- On May 24, 2014, 12:14 a.m., Till Toenshoff wrote: > >

[jira] [Commented] (MESOS-1257) ExternalContainerizerTest.Launch is flaky

[ https://issues.apache.org/jira/browse/MESOS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14007966#comment-14007966 ] Till Toenshoff commented on MESOS-1257: --- https://reviews.apache.org/r/2

Re: Review Request 21424: Fixed orphaned container handling in the ExternalContainerizer recover implementation.

74c src/slave/containerizer/external_containerizer.cpp ac3dd18 Diff: https://reviews.apache.org/r/21424/diff/ Testing --- make check against upcoming SlaveRecoveryTests (enabled locally) Thanks, Till Toenshoff

Re: Review Request 21677: Added workaround to allow the ExternalContainerizer containers to get recovered via slave state.

) Thanks, Till Toenshoff

Re: Review Request 21677: Added workaround to allow the ExternalContainerizer containers to get recovered via slave state.

-- > > src/slave/containerizer/external_containerizer.cpp f9811c4 > > Diff: https://reviews.apache.org/r/21677/diff/ > > > Testing > --- > > make check (in upcoming EC test suite) > > > Thanks, > > Till Toenshoff > >

Re: Review Request 21681: Fixed ExternalContainerizer wait behavior when getting destroyed.

- Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21681/#review43765 --- On May 23, 2014, 3:20 a.m., Till Toensh

Re: Review Request 21681: Fixed ExternalContainerizer wait behavior when getting destroyed.

Termination message accordingly as it can not get delivered by the external containerizer program itself. Diffs (updated) - src/slave/containerizer/external_containerizer.cpp f9811c4 Diff: https://reviews.apache.org/r/21681/diff/ Testing --- make check (using the upcoming EC test su

Re: Review Request 21718: Update gitignore template

tps://reviews.apache.org/r/21718/#comment78090> Haven't seen this getting created yet on any of my build systems. But given that it appears to be kinda standard (https://github.com/github/gitignore/blob/master/Autotools.gitignore) to exclude it, I guess that is fine. - Till Toenshoff On May 20, 201

[jira] [Commented] (MESOS-1413) MesosContainerizerExecuteTest.IoRedirection fails on OSX

[ https://issues.apache.org/jira/browse/MESOS-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14006663#comment-14006663 ] Till Toenshoff commented on MESOS-1413: --- https://reviews.apache.org/r/2

Review Request 21833: Fixed MesosContainerizerExecuteTest.IoRedirection for OSX.

://issues.apache.org/jira/browse/MESOS-1413 Repository: mesos-git Description --- see summary Diffs - src/tests/containerizer_tests.cpp 2f4888d Diff: https://reviews.apache.org/r/21833/diff/ Testing --- make check (OSX and linux) Thanks, Till Toenshoff

[jira] [Assigned] (MESOS-1413) MesosContainerizerExecuteTest.IoRedirection fails on OSX

[ https://issues.apache.org/jira/browse/MESOS-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Toenshoff reassigned MESOS-1413: - Assignee: Till Toenshoff > MesosContainerizerExecuteTest.IoRedirection fails on

first commit and error :(

Sorry everyone, I messed up a little in that I forgot to remove the “see summary” from the review description when committing.

[jira] [Created] (MESOS-1413) MesosContainerizerExecuteTest.IoRedirection fails on OSX

Till Toenshoff created MESOS-1413: - Summary: MesosContainerizerExecuteTest.IoRedirection fails on OSX Key: MESOS-1413 URL: https://issues.apache.org/jira/browse/MESOS-1413 Project: Mesos

[jira] [Comment Edited] (MESOS-1199) Subprocess is "slow" -> gated by process::reap poll interval

[ https://issues.apache.org/jira/browse/MESOS-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14006585#comment-14006585 ] Till Toenshoff edited comment on MESOS-1199 at 5/22/14 11:2

[jira] [Commented] (MESOS-1199) Subprocess is "slow" -> gated by process::reap poll interval

[ https://issues.apache.org/jira/browse/MESOS-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14006585#comment-14006585 ] Till Toenshoff commented on MESOS-1199: --- I would like to express my despe

Re: Review Request 21829: Uninlined large function from usage.hpp

. - Till Toenshoff On May 22, 2014, 9:40 p.m., Dominic Hamon wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 21680: Fixed concurrent destroy invocations on the ExternalContainerizer.

--- make check (on upcoming EC test suite) Thanks, Till Toenshoff

Re: Review Request 20958: Make execute in MesosContainerizer async signal safe.

> On May 20, 2014, 12:34 a.m., Tobias Weingartner wrote: > > src/slave/containerizer/mesos_containerizer.cpp, line 442 > > > > > > Should contain a mode (0666). Aye, that is what is biting us now in MESOS-1402 - Til

[jira] [Commented] (MESOS-1402) Compilation failure on head due to missing open argument

[ https://issues.apache.org/jira/browse/MESOS-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14004508#comment-14004508 ] Till Toenshoff commented on MESOS-1402: --- [~idownes] could you have a look pl

[jira] [Created] (MESOS-1402) Compilation failure on head due to missing open argument

Till Toenshoff created MESOS-1402: - Summary: Compilation failure on head due to missing open argument Key: MESOS-1402 URL: https://issues.apache.org/jira/browse/MESOS-1402 Project: Mesos

Review Request 21695: Added test-containerizer cpp implementation.

applies without them), they still should get committed first to prevent test failures. Thanks, Till Toenshoff

Review Request 21683: Fixed ExecutorInfo handover on the ExternalContainerizer launch.

summary. Diffs - src/slave/containerizer/external_containerizer.cpp f9811c4 Diff: https://reviews.apache.org/r/21683/diff/ Testing --- make check (in upcoming EC test suite) Thanks, Till Toenshoff

Review Request 21681: Fixed ExternalContainerizer wait behavior when getting destroyed.

/slave/containerizer/external_containerizer.cpp f9811c4 Diff: https://reviews.apache.org/r/21681/diff/ Testing --- make check (using the upcoming EC test suite) Thanks, Till Toenshoff

Review Request 21680: Fixed concurrent destroy invocations on the ExternalContainerizer.

summary. Diffs - src/slave/containerizer/external_containerizer.hpp af1 src/slave/containerizer/external_containerizer.cpp f9811c4 Diff: https://reviews.apache.org/r/21680/diff/ Testing --- make check (on upcoming EC test suite) Thanks, Till Toenshoff

Review Request 21678: Added static factory method to ExternalContainerizer.

/external_containerizer.cpp f9811c4 Diff: https://reviews.apache.org/r/21678/diff/ Testing --- make check (in upcoming EC test suite) Thanks, Till Toenshoff

Review Request 21677: Added workaround to allow the ExternalContainerizer containers to get recovered via slave state.

mentioned tickets comes in first. Diffs - src/slave/containerizer/external_containerizer.cpp f9811c4 Diff: https://reviews.apache.org/r/21677/diff/ Testing --- make check (in upcoming EC test suite) Thanks, Till Toenshoff

Review Request 21675: Fixed ExternalContainerizer Subprocess use for non sandboxed invocations.

MESOS-1336. Diffs - src/slave/containerizer/external_containerizer.cpp f9811c4 Diff: https://reviews.apache.org/r/21675/diff/ Testing --- make check (on upcoming test suite) Thanks, Till Toenshoff

Re: Review Request 21424: Fixed orphaned container handling in the ExternalContainerizer recover implementation.

tainerizer/external_containerizer.cpp f9811c4 Diff: https://reviews.apache.org/r/21424/diff/ Testing (updated) --- make check against upcoming SlaveRecoveryTests (enabled locally) Thanks, Till Toenshoff

Re: Review Request 21424: Fixed orphaned container handling in the ExternalContainerizer recover implementation.

> On May 16, 2014, 7:19 p.m., Ben Mahler wrote: > > src/slave/containerizer/external_containerizer.cpp, line 836 > > <https://reviews.apache.org/r/21424/diff/2/?file=583558#file583558line836> > > > > What does according to the internal states mean? > &g

Re: Review Request 21664: Fixed the broken build on OSX caused by cgroups::enabled().

> On May 19, 2014, 9:55 p.m., Till Toenshoff wrote: > > src/tests/environment.cpp, line 137 > > <https://reviews.apache.org/r/21664/diff/2/?file=584703#file584703line137> > > > > Couldn't you drop those outer brackets? Sry, did not mean to raise thi

Re: Review Request 21664: Fixed the broken build on OSX caused by cgroups::enabled().

tps://reviews.apache.org/r/21664/#comment77560> Couldn't you drop those outer brackets? - Till Toenshoff On May 19, 2014, 9:49 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https

[jira] [Commented] (MESOS-1257) ExternalContainerizerTest.Launch is flaky

[ https://issues.apache.org/jira/browse/MESOS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14001299#comment-14001299 ] Till Toenshoff commented on MESOS-1257: --- Quick update; - the MC as ECP shim app

[jira] [Commented] (MESOS-923) Containerizers should persist their own recovery state.

[ https://issues.apache.org/jira/browse/MESOS-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000520#comment-14000520 ] Till Toenshoff commented on MESOS-923: -- I just closed MESOS-1328 as it appears t

[jira] [Closed] (MESOS-1328) Slave should not rely on a checkpointed forkedPid

[ https://issues.apache.org/jira/browse/MESOS-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Toenshoff closed MESOS-1328. - Resolution: Duplicate > Slave should not rely on a checkpointed forked

Re: Review Request 21424: Fixed orphaned container handling in the ExternalContainerizer recover implementation.

ot; << containerId << "' not running according to the slave states."; ? - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21424/#review43244 --

Re: Review Request 21424: Fixed orphaned container handling in the ExternalContainerizer recover implementation.

/ Testing --- make check (note that the tests currently do not cover this scenario) Thanks, Till Toenshoff

Re: Review Request 21424: Fixed orphaned container handling in the ExternalContainerizer recover implementation.

anks, that is a bad one. - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21424/#review43070 --- On May 14, 2014

<    1   2   3   4   5   6   7   8   9   >