Re: Review Request 16150: Containerizer - isolators (part 3)

2014-02-07 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16150/#review33919 --- Ship it! src/slave/containerizer/isolator.hpp

Re: Review Request 16150: Containerizer - isolators (part 3)

2014-02-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16150/#review33864 --- Ship it! Ship It! - Vinod Kone On Feb. 1, 2014, 4:03 a.m., Ian

Re: Review Request 16150: Containerizer - isolators (part 3)

2014-01-31 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16150/ --- (Updated Feb. 1, 2014, 4:03 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 16150: Containerizer - isolators (part 3)

2014-01-28 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16150/#review33022 --- src/slave/containerizer/isolator.hpp

Re: Review Request 16150: Containerizer - isolators (part 3)

2014-01-28 Thread Ian Downes
On Jan. 28, 2014, 7:42 p.m., Vinod Kone wrote: src/slave/containerizer/isolators/posix.hpp, line 36 https://reviews.apache.org/r/16150/diff/5/?file=451176#file451176line36 I'm assuming you don't people to directly use PosixIsolatorProcess but rather its subclasses?

Re: Review Request 16150: Containerizer - isolators (part 3)

2014-01-28 Thread Ian Downes
On Jan. 26, 2014, 8:08 a.m., Adam B wrote: src/slave/container/isolator.cpp, line 99 https://reviews.apache.org/r/16150/diff/4/?file=425490#file425490line99 Needs newline at end of file Not needed for cpp file, and not done by other files in codebase. - Ian

Re: Review Request 16150: Containerizer - isolators (part 3)

2014-01-26 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16150/#review32792 --- Ship it! Looks great! src/slave/container/isolator.hpp

Re: Review Request 16150: Containerizer - isolators (part 3)

2014-01-26 Thread Ian Downes
On Jan. 23, 2014, 6:39 p.m., Niklas Nielsen wrote: src/slave/container/isolator.hpp, line 108 https://reviews.apache.org/r/16150/diff/4/?file=425489#file425489line108 This initialize overshadows initialize in Process. Can use resolve this with 'using

Re: Review Request 16150: Containerizer - isolators (part 3)

2014-01-26 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16150/#review32799 --- src/slave/container/isolator.hpp

Re: Review Request 16150: Containerizer - isolators (part 3)

2014-01-26 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16150/ --- (Updated Jan. 27, 2014, 3:02 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 16150: Containerizer - isolators (part 3)

2014-01-23 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16150/#review32553 --- Ship it! src/Makefile.am

Re: Review Request 16150: Containerizer - isolators (part 3)

2014-01-21 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16150/ --- (Updated Jan. 21, 2014, 7:34 p.m.) Review request for mesos, Benjamin Hindman,