---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16150/#review33919
---
Ship it!
src/slave/containerizer/isolator.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16150/#review33864
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 1, 2014, 4:03 a.m., Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16150/
---
(Updated Feb. 1, 2014, 4:03 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16150/#review33022
---
src/slave/containerizer/isolator.hpp
On Jan. 28, 2014, 7:42 p.m., Vinod Kone wrote:
src/slave/containerizer/isolators/posix.hpp, line 36
https://reviews.apache.org/r/16150/diff/5/?file=451176#file451176line36
I'm assuming you don't people to directly use PosixIsolatorProcess but
rather its subclasses?
On Jan. 26, 2014, 8:08 a.m., Adam B wrote:
src/slave/container/isolator.cpp, line 99
https://reviews.apache.org/r/16150/diff/4/?file=425490#file425490line99
Needs newline at end of file
Not needed for cpp file, and not done by other files in codebase.
- Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16150/#review32792
---
Ship it!
Looks great!
src/slave/container/isolator.hpp
On Jan. 23, 2014, 6:39 p.m., Niklas Nielsen wrote:
src/slave/container/isolator.hpp, line 108
https://reviews.apache.org/r/16150/diff/4/?file=425489#file425489line108
This initialize overshadows initialize in Process. Can use resolve this
with 'using
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16150/#review32799
---
src/slave/container/isolator.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16150/
---
(Updated Jan. 27, 2014, 3:02 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16150/#review32553
---
Ship it!
src/Makefile.am
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16150/
---
(Updated Jan. 21, 2014, 7:34 p.m.)
Review request for mesos, Benjamin Hindman,
12 matches
Mail list logo