epeat=1000 --gtest_break_on_failure
Thanks,
Vinod Kone
> On March 20, 2014, 9:21 p.m., Vinod Kone wrote:
> > src/master/master.hpp, line 421
> > <https://reviews.apache.org/r/19383/diff/1/?file=526626#file526626line421>
> >
> > Why cache instead of a circular buffer?
>
> Ben Mahler wrote:
> Wh
etedFramework) this seems fine. But I would like to do this
also in a different review just to avoid doing too many changes in this review.
Added a TODO.
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
ht
Updated 2 tests to verify the behavior.
make check
./bin/mesos-tests.sh
--gtest_filter="*FaultToleranceTest.FrameworkReregister*:*MasterInfoOnReElection*"
--gtest_repeat=1000 --gtest_break_on_failure
Thanks,
Vinod Kone
="*FaultToleranceTest.FrameworkReregister*:*MasterInfoOnReElection*"
--gtest_repeat=1000 --gtest_break_on_failure
Thanks,
Vinod Kone
src/tests/master_contender_detector_tests.cpp
8da7420e18c7a960b566fae13a5975857eb777ee
Diff: https://reviews.apache.org/r/18730/diff/
Testing
---
make check
Thanks,
Vinod Kone
action (e.g. URL.PUT = {}) or field (e.g. URL.PUT.ips =
> > [])."
I've redone this because the previous iteration was admittedly untuitive.
- Vinod
---
This is an automatically generated e-mail. To repl
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18730/#review37602
-------
On March 21, 2014, 11:44 p.m., Vinod Kone wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19248/#review38321
---
rebase?
- Vinod Kone
On March 24, 2014, 4:37 p.m., Ian Downes
r.cpp
<https://reviews.apache.org/r/19383/#comment70460>
s/unknown/non-activated/ ?
src/master/master.cpp
<https://reviews.apache.org/r/19383/#comment70479>
- Vinod Kone
On March 24, 2014, 7:35 p.m., Ben Mahler wrote:
>
> --
t.hpp
<https://reviews.apache.org/r/19556/#comment70526>
Put each argument on its own line.
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
<https://reviews.apache.org/r/19556/#comment70529>
Kill the TODOO?
- Vinod Kone
On March 24, 2014,
"values":["\/help"]}}]}
[ RUN ] AuthorizationTest.SomeClientsPUTSomeURL
I0325 01:28:10.698837 41814 authorization_tests.cpp:289]
{"puts":[{"clients":{"values":["127.0.0.1","localhost"]},"urls"
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18752/#review38454
---
Ship it!
Ship It!
- Vinod Kone
On March 25, 2014, 3:37 p.m
---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19357/
> ---
>
> (Updated March 24, 2014, 12:51 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs:
s.cpp
<https://reviews.apache.org/r/19602/#comment70680>
not yours but we should include the headers for these.
- Vinod Kone
On March 25, 2014, 5:35 a.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19632/#review38519
---
Ship it!
Ship It!
- Vinod Kone
On March 25, 2014, 8:27 p.m
gt;
Can you show an example in the description like we did for monitor?
- Vinod Kone
On March 26, 2014, 12:22 a.m., Ben Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
Hi folks,
I just tagged 0.18.0-rc5 with some fixes that people have reported after
testing 0.18.0-rc4.
Can you help us out by testing this rc? This will likely be voted upon as
the official 0.18.0 release in a few days unless some major issues crop up.
Thanks,
-- Vinod
you need to use CPPFLAGS and LDFLAGS because AC_CHECK_* uses them?
configure.ac
<https://reviews.apache.org/r/18957/#comment70888>
s/us/us to/
- Vinod Kone
On March 26, 2014, 3:50 p.m., Till Toenshoff wrote:
>
>
ot;HELP", "Owned", "Process",
"Promise", "TLDR", "USAGE"])
['DESCRIPTION', 'Failure', 'Future', 'HELP', 'Owned', 'Process', 'Promise',
'TLDR', 'USAGE']
---
On March 20, 2014, 7:32 p.m., Timothy St. Clair wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19487/
> ---
>
> (Updated March 20, 2014, 7:32 p.m.
tps://reviews.apache.org/r/19361/#comment70934>
Why is this CAPS and snake_case ?
3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp
<https://reviews.apache.org/r/19361/#comment70935>
Why not just
ASSERT_SOME_EQ(childThreads, procThreads);
- Vinod Kone
On March
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19700/#review38672
---
Ship it!
Ship It!
- Vinod Kone
On March 26, 2014, 10:25 p.m
<https://reviews.apache.org/r/19361/#comment70938>
You can combine these two too using ASSERT_SOME_EQ :)
- Vinod Kone
On March 26, 2014, 11:20 p.m., Ian Downes wrote:
>
> ---
> This is an automatically generated e
<https://reviews.apache.org/r/19699/#comment70941>
kill new line.
- Vinod Kone
On March 26, 2014, 10:25 p.m., Ian Downes wrote:
>
> ---
> This is an automatically generated e-mail. To
ests/cluster.hpp
<https://reviews.apache.org/r/19248/#comment70981>
print the cgroup.
- Vinod Kone
On March 26, 2014, 11:51 p.m., Ian Downes wrote:
>
> -
248/#comment70993>
Do we need this now that the flag is optional?
- Vinod Kone
On March 27, 2014, 1:35 a.m., Ian Downes wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
> On March 27, 2014, 4:30 a.m., Vinod Kone wrote:
> > src/local/local.cpp, lines 158-162
> > <https://reviews.apache.org/r/19248/diff/8/?file=538194#file538194line158>
> >
> > Do we need this now that the flag is optional?
nm. i fixed this
d6b070fa4ab3958c1e9302f6a2fc0ca63fc0239a
Diff: https://reviews.apache.org/r/19738/diff/
Testing
---
make
? mesos git:(vinod/tab_fix) ? ./support/mesos-style.py
Checking 403 files...
Total errors found: 0
Thanks,
Vinod Kone
/
Testing
---
? mesos git:(vinod/tab_fix) ? ./support/mesos-style.py
Checking 403 files...
Total errors found: 0
Thanks,
Vinod Kone
/tab_fix) ? ./support/mesos-style.py
Checking 403 files...
Total errors found: 0
Thanks,
Vinod Kone
://reviews.apache.org/r/19740/diff/
Testing
---
? mesos git:(vinod/tab_fix) ? ./support/mesos-style.py
Checking 403 files...
Total errors found: 0
Thanks,
Vinod Kone
ow it looks in my "git
show".
commit 8ed4ae181474f5cae49d178dc50df3e938cc06fe
Author: Vinod Kone
Date: Thu Mar 27 10:55:50 2014 -0700
Fixed tabs in mesos.
Review: https://reviews.apache.org/r/19740
diff --git a/src/master/detector.cpp b/src/master/detector.cpp
index ef9f1f5.
/
Testing
---
Tested mesos-style.py manually.
Thanks,
Vinod Kone
743/#comment71097>
just curious. what are these rules testing?
support/mesos-style.py
<https://reviews.apache.org/r/19743/#comment71096>
why not just
rules_filter = '--filter=-+' + ',+'.join(active_rules)
- Vinod Kone
On March 27, 2014
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19743/#review38831
---
Ship it!
Ship It!
- Vinod Kone
On March 27, 2014, 9:35 p.m
/fault_tolerance_tests.cpp 68280113ca32c4c4e0f335bed11044ba4184c34e
Diff: https://reviews.apache.org/r/19809/diff/
Testing
---
make check
Thanks,
Vinod Kone
eb8cd73e9e8f26a7438070ca2bb078bd2d1ec480
src/master/master.cpp 5d0ddb0a567b1282bf164a5f1abc41a719208269
src/tests/fault_tolerance_tests.cpp 68280113ca32c4c4e0f335bed11044ba4184c34e
Diff: https://reviews.apache.org/r/19809/diff/
Testing
---
make check
Thanks,
Vinod Kone
Please create a jira ticket.
@vinodkone
Sent from my mobile
> On Mar 29, 2014, at 7:29 AM, Bharath Bhushan wrote:
>
> One warning message that I see:
> *** Warning: Linking the shared library libmesos.la against the
> *** static library ../3rdparty/leveldb/libleveldb.a is not portable!
>
> I
nd deserialization of protobufs to files.
See protobuf::write() and protobuf::read().
src/slave/containerizer/external_containerizer.cpp
<https://reviews.apache.org/r/17567/#comment71481>
If we do the above and if we have MESOS-995, can you just leverage
subprocess he
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19834/#review39117
---
Ship it!
Ship It!
- Vinod Kone
On March 31, 2014, 7:09 a.m
t;
thank you.
- Vinod Kone
On April 1, 2014, 2:33 a.m., Tobi Knaup wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19859/
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19820/#review39174
---
Ship it!
Ship It!
- Vinod Kone
On March 29, 2014, 3:35 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19784/#review39175
---
Ship it!
Ship It!
- Vinod Kone
On March 28, 2014, 9:22 a.m
related to your change.
I'll get this committed. Thanks.
- Vinod Kone
On March 28, 2014, 6:35 a.m., Chengwei Yang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
764/#comment71538>
Have you confirmed that the callers of this method are safe with this
change?
src/state/state.hpp
<https://reviews.apache.org/r/19764/#comment71539>
ditto.
- Vinod Kone
On April 1, 2014, 1:13 a.m., Jiang
/state.hpp:20:9: note: '__MESSAGES_STATE_HPP__' is
> defined here; did you mean '__MESSAGE_STATE_HPP__'?
> #define __MESSAGES_STATE_HPP__
> ^~~~~~
> __MESSAGE_STATE_HPP__
> 2 errors generated.
>
> Got to love clang for that! :)
>
> cheers,
> Till
&
://issues.apache.org/jira/browse/MESOS-1176
Repository: mesos-git
Description
---
See summary.
Diffs
-
3rdparty/libprocess/Makefile.am e452ec6256042ce9388e59f4586e1084075fe621
Diff: https://reviews.apache.org/r/19878/diff/
Testing
---
make distcheck
Thanks,
Vinod Kone
fyi
-- Forwarded message --
From:
Date: Tue, Apr 1, 2014 at 11:57 AM
Subject: Git Push Summary
To: comm...@mesos.apache.org
Repository: mesos
Updated Tags: refs/tags/0.18.0-rc6 [created] 185dba5d8
762/#comment71561>
s/;/./
src/master/registrar.cpp
<https://reviews.apache.org/r/19762/#comment71543>
s/hashset/hashset of SlaveIDs/
- Vinod Kone
On April 1, 2014, 1:13 a.m., Jiang Yan Xu wrote:
>
> ---
> Thi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19762/#review39205
---
Ship it!
Ship It!
- Vinod Kone
On April 1, 2014, 1:13 a.m
877/#comment71576>
Can you add a CHECK here to make sure this expectation is valid?
- Vinod Kone
On April 1, 2014, 6:27 p.m., Niklas Nielsen wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
761/#comment71577>
Can you actually implement this TODO? Would be good starting point for us
to write benchmark tests.
- Vinod Kone
On April 1, 2014, 1:13 a.m., Jiang Yan Xu wrote:
>
> ---
> This is an automatically gener
Hi all,
Please vote on releasing the following candidate as Apache Mesos 0.18.0.
0.18.0 includes the following:
* The primary feature of this release is a refactor of the isolation
abstraction to make it easy to a
I changed 'make check' to 'make distcheck' in all our Apache builds. But
the error is interesting..
checking whether or not we can build with JNI... /usr/bin/ld: skipping
incompatible /home/hudson/tools/java/latest1.6/jre/lib/i386/server/libjvm.so
when searching for -ljvm
/usr/bin/ld: cannot find
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18289/#review39314
---
Jie. Can you commit this?
- Vinod Kone
On March 5, 2014, 6:17
os::environ()? That's the only place where it is
used afaict.
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp
<https://reviews.apache.org/r/19948/#comment71679>
this could be
EXPECT_TRUE(environment.contains(key)) if os::environment returns a hashmap.
- Vinod Kone
tps://reviews.apache.org/r/19952/#comment71685>
Also, you can kill this :)
- Vinod Kone
On April 2, 2014, 5:55 p.m., Ian Downes wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19948/#review39338
---
Ship it!
Ship It!
- Vinod Kone
On April 2, 2014, 7:38 p.m
filed: https://issues.apache.org/jira/browse/MESOS-1180
reverted this build to 'make check' in the interim.
@vinodkone
On Wed, Apr 2, 2014 at 1:49 PM, Apache Jenkins Server <
jenk...@builds.apache.org> wrote:
> See <
> https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-
info.isNone() to the if
check at the top and do a CHECK(state.info.isSome()) here.
src/slave/slave.cpp
<https://reviews.apache.org/r/19795/#comment71767>
All you are doing here during recovery is to setup the resources. Just do
it directly instead of calling launched().
sr
aargh. 'make distcheck' creates a directory without write permissions,
which means "git clean -fdx" doesn't work :/
i'll fix this shortly. sorry for the noise.
On Wed, Apr 2, 2014 at 5:41 PM, Apache Jenkins Server <
jenk...@builds.apache.org> wrote:
> See <
> https://builds.apache.org/job/Mesos
---
>
> (Updated April 3, 2014, 6:35 a.m.)
>
>
> Review request for mesos, Ian Downes and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> ---
>
> The only user of os::read(fd, size) that required the seek seman
g/r/19988/#comment71837>
we wrap comments at 70 chars.
- Vinod Kone
On April 3, 2014, 6:26 a.m., Adam B wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
> On April 3, 2014, 5:57 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp, lines 52-58
> > <https://reviews.apache.org/r/19991/diff/2/?file=547563#file547563line52>
> >
> > I'm confused about these semantics. Wh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19991/#review39453
---
Ship it!
Ship It!
- Vinod Kone
On April 3, 2014, 6:35 a.m
submitted).
- Vinod Kone
On April 2, 2014, 10:05 p.m., Ian Downes wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19952/#review39488
---
Ship it!
Ship It!
- Vinod Kone
On April 3, 2014, 10:59 p.m
iew.sh
<https://reviews.apache.org/r/20173/#comment72685>
Also add the pull request url.
e.g:
This closes #13.
Review: https://github.com/apache/mesos/pull/13
support/apply-review.sh
<https://reviews.apache.org/r/20173/#comment72684>
indentati
ms to be the same rule as above?
src/slave/containerizer/containerizer.proto
<https://reviews.apache.org/r/20141/#comment72688>
What about protobufs for Usage, Wait and Destroy?
Should Termination also be pulled into this namespace?
- Vinod Kone
On April 9, 2014, 12:25 a.m
used by libprocess yet?
- Vinod Kone
On April 9, 2014, 7:42 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
-
>
> (Updated April 9, 2014, 7:43 p.m.)
>
>
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> ---
>
> See summary.
>
>
> Diffs
> -
>
> 3rdparty/libproc
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20127/#review39939
---
Also attach the bug?
- Vinod Kone
On April 9, 2014, 7:43 p.m
<https://reviews.apache.org/r/19951/#comment72723>
How about
// Check the test cgroup now only contains all the child threads.
src/linux/cgroups.cpp
<https://reviews.apache.org/r/19951/#comment72722>
woah. i thought this was not supported by kernels < 3.10 !?
-
er/re-register within the timeout/ ?
src/master/master.cpp
<https://reviews.apache.org/r/19857/#comment72734>
How about making this configurable and have the current value as the
default? Maybe another review and/or a TODO?
- Vinod Kone
On Apr
ter will make it easy to write tests for this in the future (when we
have a Testable EXIT).
- Vinod Kone
On April 7, 2014, 8:43 p.m., Ben Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
0), gcc 4.7.2
> >
> >
> > On Wed, Apr 2, 2014 at 10:02 AM, Niklas Nielsen wrote:
> >
> > > +1, built and checked on OS X 10.9.2, clang-503.0.38 & Ubuntu 13.10,
> gcc
> > > 4.8.1
> > >
> &g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20025/#review39961
---
Ship it!
@ian: you can commit this.
- Vinod Kone
On April 8
change and
one for clone?
- Vinod Kone
On April 8, 2014, 8:37 p.m., Ian Downes wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
> On April 9, 2014, 11:28 p.m., Vinod Kone wrote:
> > This review looks like it could really use a split, one for the api change
> > and one for clone?
also re-add the "depends on" to make reviewbot happy. i hate that post-review
auto removes the field on review updat
13098-5050-28035-0/runs/7e2a86e9-5b4c-4a19-940f-0cdd6148d66b/spark-0.9.tar.gz'
>> into
>> '/var/run/mesos/slaves/20140403-103606-1898713098-5050-28035-0/frameworks/20140403-103606-1898713098-5050-28035-/executors/20140403-103606-1898713098-5050-28035-0/runs/7e2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20052/#review39970
---
Ship it!
Ship it modulo adding a comment per benh.
- Vinod Kone
t in the former case we return ResourceStatistics that
doesn't have timestamp set.
- Vinod Kone
On April 7, 2014, 1:59 a.m., Benjamin Hindman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
just in case my previous email from @twitter didn't reach.
On Wed, Apr 9, 2014 at 5:44 PM, Vinod Kone wrote:
> Hi all,
>
> The vote for Mesos 0.18.0 (rc6) has passed with the
> following votes.
>
> +1 (Binding)
> --
> Niklas Neilse
} email)
support/apply-review.sh
<https://reviews.apache.org/r/20173/#comment72774>
new line after this.
- Vinod Kone
On April 10, 2014, 3:31 a.m., Jake Farrell wrote:
>
> ---
> This is an automatically generated e-mai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20127/#review40035
---
Ship it!
Ship It!
- Vinod Kone
On April 10, 2014, 4:57 p.m
.SingleThread
> > [ OK ] ProcTest.SingleThread (1 ms)
> > [ RUN ] ProcTest.MultipleThreads
> > stout/tests/proc_tests.cpp:164: Failure
> > read is NONE
> > [ FAILED ] ProcTest.MultipleThreads (1 ms)
> > [--] 6 tests from ProcTest (4 ms total)
> >
> > [--] Global test envi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20221/#review40054
---
Ship it!
Ship It!
- Vinod Kone
On April 10, 2014, 5:02 p.m
This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20221/
> ---
>
> (Updated April 10, 2014, 5:02 p.m.)
>
>
> Review request for mesos, Ian Downes and Vinod Kone.
>
>
> Repository:
r/18381/#comment73130>
I know this is copy pasted from sched.cpp but can this be
CHECK_NOTNULL(authenticatee)?
src/slave/slave.cpp
<https://reviews.apache.org/r/18381/#comment73131>
s/master.get()/self()/
src/slave/slave.cpp
<https://reviews.apache.org/r/18381/#comment7313
iff: https://reviews.apache.org/r/20284/diff/
Testing
---
Used it post this review.
Thanks,
Vinod Kone
> On April 12, 2014, 2:54 a.m., Vinod Kone wrote:
> > src/master/master.cpp, line 2678
> > <https://reviews.apache.org/r/18381/diff/7/?file=540066#file540066line2678>
> >
> > we should really consolidate 'deactivate' framework and 'disconnect
18730/diff/
Testing
---
make check
Thanks,
Vinod Kone
://issues.apache.org/jira/browse/MESOS-850
Repository: mesos-git
Description
---
See summary.
Diffs
-
support/release.sh 633bbace091bddd582b9fcef5d35b331a0f169f0
Diff: https://reviews.apache.org/r/20298/diff/
Testing
---
Thanks,
Vinod Kone
org/r/20292/#comment73169>
this should be after the C headers.
- Vinod Kone
On April 13, 2014, 11:39 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
174>
what about the header files?
- Vinod Kone
On April 13, 2014, 11:39 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
pp
<https://reviews.apache.org/r/20295/#comment73188>
should these hex values be replaced by static const variables declared
below in private?
- Vinod Kone
On April 13, 2014, 11:45 p.m., Jie Yu wrote:
>
> --
ch is asynchronous.
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20298/#review40235
---
On April 14, 2014, 1:53 a.m.,
> On April 12, 2014, 2:54 a.m., Vinod Kone wrote:
> > src/slave/slave.cpp, line 640
> > <https://reviews.apache.org/r/18381/diff/7/?file=540073#file540073line640>
> >
> > s/master.get()/self()/
>
> Adam B wrote:
> Slave::shutdown() exits with
014, 8:26 p.m., Niklas Nielsen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20221/
> ---
>
> (Updated A
701 - 800 of 3936 matches
Mail list logo
