Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/205
LGTM!
---
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/205
Thanks a lot @q977734161 ... And sorry, I just discovered a few more
changes that I'd like to request :-)
---
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/205#discussion_r245515460
--- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java
---
@@ -797,7 +800,7 @@ public String getIdentifierQuoteString
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/205#discussion_r245515445
--- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java
---
@@ -756,6 +758,7 @@ private String findDefaultSchema(final String
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/205#discussion_r245515556
--- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java
---
@@ -289,6 +289,7 @@ private boolean usesCatalogsAsSchemas
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/205#discussion_r245492858
--- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java
---
@@ -580,6 +587,13 @@ public void close(Connection connection
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/205#discussion_r245492854
--- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java
---
@@ -289,6 +289,13 @@ private boolean usesCatalogsAsSchemas
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/205#discussion_r245492826
--- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java
---
@@ -289,6 +289,13 @@ private boolean usesCatalogsAsSchemas
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/205#discussion_r245492860
--- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java
---
@@ -756,6 +770,9 @@ private String findDefaultSchema(final String
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/205
Hmm. I overspoke - I cannot do that. @q977734161 you'll probably have to
make an empty commit to trigger rebuild:
```
git commit --allow-empty -m "Empty commit to tr
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/205
I'll have Travis rebuild it to see what happens ...
---
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/206
Update hive-jdbc to version 2.3.4, addressing CVE-2018-1314
See https://nvd.nist.gov/vuln/detail/CVE-2018-1314 for details on the
vulnerability in the previous versions.
You can merge
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/200
Hmm it took 3 builds via Travis before the jdk11 build succeeded. Seems
that that particular jdk is "better" at exposing some of our build
instabilities / flaky tests. But I'm
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/200
Marking jaxws-rt as "provided" instead of included
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/metamodel no
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/199
Yay! It built on all 4 JDK installations on Travis CI! This should fully
resolve METAMODEL-1205 then I think.
---
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/199
METAMODEL-1205: Enabled all the Travis JDKs (and solving small build issues)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/198
LGTM! Merging
---
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/198
Oh ... Yuck ... I'm OK with fixing it this way I guess, but isn't there
another possible way, such as making the classes have a shared initializer or
something?
---
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/197
Self-merging this because I accidentally broke the `master` build before
when merging those multiple METAMODEL-1205 PRs.
---
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/197
METAMODEL-1205: Fixed issue with overlapping woodstox JAR files
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kaspersorensen
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/195
I don't think we need additional testing here - the CassandraUnit tests
still run on Travis CI (just not in JDK9 builds)
---
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/194
No I think this is perfect. Thanks again for doing extra due diligence on
the PR. I think we can merge ...
Did you by any chance look at the two other JDK9+ related PRs?
---
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/195
Note the "Update" in my PR description above. A lot more dependencies have
been updated in this MR now to resolve JAR hell conflicts..
---
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/196
Damnit. Seems not to work in Travis CI (I think that's because it's running
JDK 8)... We need a solution that works in BOTH version 8 and above.
Maybe something with different
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/195
D'oh! Seems cassandra unit now _requires_ the use of logback classic.
That's kinda lame, but I'll switch it out for the test scope at least.
---
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/194
I think our tests should cover most of the stuff, but the one thing that I
will admit was somewhat complicated was what I noted in the third commit:
> I ran into an is
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/196
METAMODEL-1205: Updated SugarCRM JAX-WS/WSDL codegen to work in JDK9+
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kaspersorensen
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/195
METAMODEL-1205: Made CassandraUnit based test skip on JDK 9+
It seems that CassandraUnit simply does not work on JDK 9+, see related
comments in the code. For now I've added a JUnit
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/194
METAMODEL-1205: JDK >8 support in core and excel (with POI v 4.0.0)
This is a step along the way to get to resolution of METAMODEL-1205
(supporting builds on JDKs > 8).
Th
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel-membrane/pull/14
self-merging after lazy concensus.
---
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/192
I'm self-merging this since no one seems to object :-)
---
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/191
I'm self-merging this since no one seems to object :-)
---
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel-membrane/pull/16
METAMODEL-1159: Composite datasource / querying
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/metamodel-membrane
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel-membrane/pull/15
Fix newman version @ 3.9.4
This is because newer versions of Newman (4.x) have a couple of changes to
the test results XML which makes our current integration test "grep&q
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel-membrane/pull/14
Upgraded MetaModel dependency to v. 5.1.0 (latest)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/metamodel-membrane
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/190
Hi @jakubneubauer are you still working on this?
---
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/191
Using Travis CI's neo4j 'service' instead of docker container
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kaspersorensen
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/128
I'm closing this PR since I guess the discussion has gone dead. Not sure
what to do about the precision issue here, but I think a discussion/vote would
be more appropriate and then we may
Github user kaspersorensen closed the pull request at:
https://github.com/apache/metamodel/pull/128
---
Github user kaspersorensen closed the pull request at:
https://github.com/apache/metamodel/pull/162
---
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/162
Closing this as I'm not seeing a resolution straight forward.
---
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/156
Hey @tomatophantastico, all,
I made https://github.com/tomatophantastico/metamodel/pull/2 some time ago
to help you fix some of the merge conflicts and minor issues. Are you still
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/190#discussion_r222489367
--- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java
---
@@ -903,4 +905,17 @@ public String getDatabaseProductName
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/190#discussion_r222489903
--- Diff:
jdbc/src/test/java/org/apache/metamodel/jdbc/ConnectionWrapper.java ---
@@ -0,0 +1,286 @@
+/**
+ * Licensed to the Apache
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/190#discussion_r222490606
--- Diff:
jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcUpdateCallback.java ---
@@ -42,18 +43,35 @@
import org.slf4j.Logger;
import
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/190#discussion_r222490126
--- Diff:
jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcUpdateCallback.java ---
@@ -42,18 +43,35 @@
import org.slf4j.Logger;
import
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/190#discussion_r222489649
--- Diff:
jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcUpdateCallback.java ---
@@ -42,18 +43,35 @@
import org.slf4j.Logger;
import
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/190#discussion_r222491235
--- Diff:
jdbc/src/test/java/org/apache/metamodel/jdbc/CloseableConnectionWrapper.java ---
@@ -44,13 +44,12 @@
* closed or not, without
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/189
I'm merging based on lazy concensus.
---
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/189
Fixed several javadoc issues
I was actually trying to prepare a release, but found that these javadoc
issues made my build fail on newer versions of the JDK.
You can merge this pull
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/188
I've created https://issues.apache.org/jira/browse/METAMODEL-1197 for this
patch and will be merging in the change in a moment.
---
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/188
LGTM! I like what you're doing to DataCleaner, too ð® ð
---
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/187#discussion_r215826872
--- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java
---
@@ -513,6 +514,8 @@ protected DataSet executeQuery(Connection
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/187#discussion_r215826834
--- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java
---
@@ -513,6 +514,8 @@ protected DataSet executeQuery(Connection
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/186
Merging based on lazy concensus
---
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/185
OK I'll merge then :-)
---
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/185
LGTM. What about you @arjansh ?
---
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/186
Fixed a typo: This fix is for METAMODEL-1193, not METAMODEL-1116.
---
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/186
METAMODEL-1116: Upgraded parent-pom to enable sha-512 signing.
I believe this fixes METAMODEL-1116 since the new apache parent-pom
contains this plugin configuration
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/185
And finally a small request: Can you please create a JIRA issue for this
improvement. That makes the life of the committer easier so that we (or you)
can add a referenced entry
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/185#discussion_r212811641
--- Diff:
jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcCreateTableBuilder.java ---
@@ -115,21 +115,23 @@ private String createSqlStatement
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/183
You can just make the change in the same branch. The PR will then
auto-update.
---
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/183
Seems like a clean fix to me. Only remark is that you've used tabs instead
of spaces in the Oracle class.
---
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/181
Self-merging this one based on lazy concensus.
---
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/182
Merged.
---
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/182
Oh I think that's a glitch. I've seen that test fail on rare occasions
before. @GerardDellemann you can trigger a new build by making an empty commit
to your branch, like
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/182
Assuming that the build passes now and all that, this all LGTM!
---
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/182
I like what this PR does, but it seems a bit one-off to me. It's nice to
see us supporting on-the-fly column definitions during insert, but the same
principle could also apply for other
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r195409088
--- Diff:
hbase/src/main/java/org/apache/metamodel/hbase/HBaseRowInsertionBuilder.java ---
@@ -0,0 +1,200 @@
+/**
+ * Licensed
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r195406963
--- Diff:
hbase/src/main/java/org/apache/metamodel/hbase/HBaseRowInsertionBuilder.java ---
@@ -0,0 +1,200 @@
+/**
+ * Licensed
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r195406132
--- Diff:
hbase/src/main/java/org/apache/metamodel/hbase/HBaseFamilyMap.java ---
@@ -106,9 +105,9 @@ public String toString
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r195404505
--- Diff:
hbase/src/main/java/org/apache/metamodel/hbase/HBaseDataContext.java ---
@@ -242,17 +240,18 @@ protected DataSet
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r194913069
--- Diff:
hbase/src/main/java/org/apache/metamodel/hbase/HBaseRowInsertionBuilder.java ---
@@ -0,0 +1,200 @@
+/**
+ * Licensed
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r194912619
--- Diff:
hbase/src/main/java/org/apache/metamodel/hbase/HBaseFamilyMap.java ---
@@ -106,9 +105,9 @@ public String toString
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r194912353
--- Diff:
hbase/src/main/java/org/apache/metamodel/hbase/HBaseDataContext.java ---
@@ -242,17 +240,18 @@ protected DataSet
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r194911581
--- Diff: hbase/src/main/java/org/apache/metamodel/hbase/HBaseClient.java
---
@@ -0,0 +1,197 @@
+/**
+ * Licensed to the Apache Software
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r193792898
--- Diff:
hbase/src/main/java/org/apache/metamodel/hbase/HBaseCreateTableBuilder.java ---
@@ -0,0 +1,98 @@
+/**
+ * Licensed to the Apache
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r193618625
--- Diff:
hbase/src/main/java/org/apache/metamodel/hbase/HBaseCreateTableBuilder.java ---
@@ -0,0 +1,98 @@
+/**
+ * Licensed to the Apache
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r193618132
--- Diff: hbase/src/main/java/org/apache/metamodel/hbase/HBaseColumn.java
---
@@ -0,0 +1,124 @@
+/**
+ * Licensed to the Apache Software
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r193618035
--- Diff: hbase/src/main/java/org/apache/metamodel/hbase/HBaseColumn.java
---
@@ -0,0 +1,124 @@
+/**
+ * Licensed to the Apache Software
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r193617943
--- Diff: hbase/src/main/java/org/apache/metamodel/hbase/HBaseColumn.java
---
@@ -0,0 +1,124 @@
+/**
+ * Licensed to the Apache Software
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r193617724
--- Diff:
core/src/main/java/org/apache/metamodel/insert/AbstractRowInsertionBuilder.java
---
@@ -44,6 +44,12 @@ public
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r193617545
--- Diff:
hbase/src/main/java/org/apache/metamodel/hbase/HBaseUpdateCallback.java ---
@@ -0,0 +1,112 @@
+/**
+ * Licensed to the Apache
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/181
Build fixed when I merged in master.
---
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/178
Merging it into master now then.
---
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/181
Don't use Object.finalize()
Since JDK9 the `Object.finalize()` method has been marked as `@Deprecated`.
In this PR I removed references to `Objects`s `finalize` method, and tried to
get
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/178
It's been a while and we didn't really do anything. For now I've added a
copy of the `InterfaceStability` annotations to the project and marked up
`KafkaDataContext` as `Unstable`. Does
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/179#discussion_r190898432
--- Diff:
neo4j/src/main/java/org/apache/metamodel/neo4j/utils/ColumnTypeResolver.java ---
@@ -0,0 +1,126 @@
+/**
+ * Licensed
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/179
Looks good to me, but I think we should do a tiny bit more code hygeine in
terms of centralizing all the string literals in a collection of constants
somewhere.
---
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/179#discussion_r190897592
--- Diff:
neo4j/src/main/java/org/apache/metamodel/neo4j/Neo4jDataContext.java ---
@@ -158,102 +159,127 @@ protected String getMainSchemaName
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/179#discussion_r190897254
--- Diff:
neo4j/src/main/java/org/apache/metamodel/neo4j/utils/ColumnTypeResolver.java ---
@@ -0,0 +1,126 @@
+/**
+ * Licensed
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/178
I like that idea myself. I notice that many projects (such as Hadoop,
Kafka, Guava, Spark) have a `@InterfaceStability` annotation. We could do the
same as them and mark this one
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/178
wrt 1) OK this is a sure improvement point. Do you think it's required at
this point, or can we use this module without it, and add this feature in a
later PR. I might just go ahead and do
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/178#discussion_r164562943
--- Diff:
kafka/src/test/java/org/apache/metamodel/kafka/KafkaDataContextTest.java ---
@@ -0,0 +1,172 @@
+/**
+ * Licensed to the Apache
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/178
To address your two discussion points:
1. Yes it is very typical to store some data structure in Kafka. I
definitely think that a natural improvement here would be to extend
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/178#discussion_r164477791
--- Diff:
kafka/src/test/java/org/apache/metamodel/kafka/KafkaDataContextTest.java ---
@@ -0,0 +1,172 @@
+/**
+ * Licensed to the Apache
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/178
A bit of clarification to answer my own question/worry: It seems that the
`Consumer.unsubscribe(..)` call is the best thing I can reasonably do. This
seems to remove any Zookeeper entry
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/178
A new module for Apache Kafka "querying" using MetaModel
Hi all,
I've been playing around with this idea for a while and decided to try it
out ... I'm curious what
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/177#discussion_r163751042
--- Diff:
elasticsearch/common/src/main/java/org/apache/metamodel/elasticsearch/AbstractElasticSearchDataContext.java
---
@@ -0,0 +1,149
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/177#discussion_r163751523
--- Diff: elasticsearch/rest/pom.xml ---
@@ -52,40 +51,117 @@ under the License.
commons-io
1 - 100 of 584 matches
Mail list logo
