Re: MyFaces Fusion
Arash Rajaeeyan schrieb: oh yes, also conversation scope of Trinidad does you (or any one one else) have access to JSR 299 info? do you which approach are they going to standardize for conversation/dialog/(or what ever they name it)? Btw. speaking of JSR 299, and conversations, isnt jsr299 just a glue specification of marrying ejb3 and jsf so that you can use ejb3 beans as managed beans? Regarding conversations and dialogs: This stuff really belongs into the servlet space just like session and request, which technologies then are built on top of such scoping is an entire issue. Lets face it 90% of all problems most people have in webapps stem from the fact that you cannot keep objects for a longer time without going through the problems a session scope causes for garbage collection and due to the fact that if you do not work on a pure jdbc base but on an orm base you either have to keep an erm open for your entire session with all related problems or you have to open it on request or even works on business case and then run into the usual merge problems most orm layers have (which is not solvable in a satisfying way anyway) The current already big number of various dialog systems which also keep something conversational open for object storage stem from the fact that this is a huge problem or has become a bigger one now that webapps seem to have moved towards orm layers where this problem becomes more problematic. Tackeling it on JEE level has been long overdue in my opinion especially because most of the usage and core patterns basically are tested by now. Craig since you are reading this, any idea if the servlet specs will be opened to scopes/conversations in the next specifications? Werner
Re: MyFaces Fusion
On 2/28/07, Werner Punz [EMAIL PROTECTED] wrote: Arash Rajaeeyan schrieb: oh yes, also conversation scope of Trinidad does you (or any one one else) have access to JSR 299 info? do you which approach are they going to standardize for conversation/dialog/(or what ever they name it)? Btw. speaking of JSR 299, and conversations, isnt jsr299 just a glue specification of marrying ejb3 and jsf so that you can use ejb3 beans as managed beans? JSR299 means whatever the expert group decides to propose to the JCP executive committee for approval. The kinds of things you describe above are definitely within the initial proposal document[1], but I would not place any bets that JSR-299 will limit itself to just what you mentioned. Regarding conversations and dialogs: This stuff really belongs into the servlet space just like session and request, which technologies then are built on top of such scoping is an entire issue. Agreed in general ... the devil is in the details. Consider the RESTafarian attitude that scopes of any kind (other than request scope) are evil. And, consider the fact that, although javax.servlet was one of the earliest extension proposals for the Java language, there have not been any mainstream-adopted solutions on different APIs to adapt HTTP requests to Java business logic (unless, I suppose, you count SOAP mappings via things like JAX-RPC and JAX-WS ... but those still count IMHO as built on *top* of the servlet APi instead of replacing it). Maybe there is some virtue in a simple baseline standard that everyone can adopt? Lets face it 90% of all problems most people have in webapps stem from the fact that you cannot keep objects for a longer time without going through the problems a session scope causes for garbage collection and due to the fact that if you do not work on a pure jdbc base but on an orm base you either have to keep an erm open for your entire session with all related problems or you have to open it on request or even works on business case and then run into the usual merge problems most orm layers have (which is not solvable in a satisfying way anyway) The current already big number of various dialog systems which also keep something conversational open for object storage stem from the fact that this is a huge problem or has become a bigger one now that webapps seem to have moved towards orm layers where this problem becomes more problematic. Tackeling it on JEE level has been long overdue in my opinion especially because most of the usage and core patterns basically are tested by now. Craig since you are reading this, any idea if the servlet specs will be opened to scopes/conversations in the next specifications? It turns out that I've been an internal proponent of dealing with these kinds of issues at the servlet spec level, as my colleagues in the platform group are aware of :-). One of the critical challenges, unfortunately, is econimics -- funding any spec all the way through the JCP process is likely to be a six-figure ($) investment, and the challenge is to optimize our (Sun's) investments. My personal interest in this problem space is actually at a level *below* the servlet API ... hopefully, the recently filed RESTful API JSR can deal with those sorts of things. Things like conversation scope (and even session scope) should be extensions on top of such a basic API, not fundamental features of it. Serv;ets have served us honorably for almost 10 years (only a little less than the lifetime of Java itself) ... but it's time to move forwards. Werner Craig
[jira] Updated: (TOMAHAWK-145) Firefox fails to render autoUpdateDataTable styles specified by the rowClasses attribute
[ https://issues.apache.org/jira/browse/TOMAHAWK-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Kaltepoth updated TOMAHAWK-145: - Status: Patch Available (was: Reopened) Firefox fails to render autoUpdateDataTable styles specified by the rowClasses attribute Key: TOMAHAWK-145 URL: https://issues.apache.org/jira/browse/TOMAHAWK-145 Project: MyFaces Tomahawk Issue Type: Bug Components: AutoUpdateDataTable Environment: Tested on Windows XP, IE 6.0 - nightly build from Sep. 7, 2005 Reporter: Sh Ma Assigned To: Martin Marinschek Priority: Minor Attachments: sandbox.war CSS styles specified by using the rowClasses attribute are not displayed. For example, I have something like: x:autoUpdateDataTable rowClasses=oddRow,evenRow ... Although both oddRow and evenRow are specified in the rendered HTML - for example: tr class=oddRow... ...Firefox doesn't render the rows according to the specified CSS style. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [jira] Created: (MYFACES-1545) UISelectOne validation fails with custom converter
On 27/02/2007 15:23, Dainius Vaznys (JIRA) wrote:
UISelectOne validation fails with custom converter
--
Key: MYFACES-1545
URL: https://issues.apache.org/jira/browse/MYFACES-1545
Project: MyFaces Core
Issue Type: Bug
Affects Versions: 1.1.5
Reporter: Dainius Vaznys
This seems to be closely related with MYFACES-1328.
I have a Converted configured with a UISelectOne which converts between strings
and enum values, i.e. getAsObject() returns an Enum instance. After the
convertion takes place UISelectOne.validateValue() is invoked to check if the
Enum instance is among select items. This code definitely does not work:
Object itemValue = item.getValue();
if (value==itemValue || value.equals(itemValue))
{
return true;
}
as it tries to match an Enum instance against a string.
This sounds a lot like a problem I discovered when I upgraded from 1.1.3
to 1.1.5:
https://javaserverfaces.dev.java.net/servlets/ReadMsg?list=usersmsgNo=175
Short answer: that's how it's supposed to work in JSF 1.1 and I needed
to change my code.
-Guy.
Re: MyFaces Fusion
I think the best way is to extend the bean scopes and add some other scope(s) for conversation or dialogs. I think in first proposal they said they want to take best practices of Seam, Shale, ADF, and other JSF based frameworks and find best practices for web development, and put them in web beans (JSR 299) it can be addressed in low level Servlet API but it can also be addressed in higher levels like JSF frameworks. On 2/28/07, Werner Punz [EMAIL PROTECTED] wrote: Arash Rajaeeyan schrieb: oh yes, also conversation scope of Trinidad does you (or any one one else) have access to JSR 299 info? do you which approach are they going to standardize for conversation/dialog/(or what ever they name it)? Btw. speaking of JSR 299, and conversations, isnt jsr299 just a glue specification of marrying ejb3 and jsf so that you can use ejb3 beans as managed beans? Regarding conversations and dialogs: This stuff really belongs into the servlet space just like session and request, which technologies then are built on top of such scoping is an entire issue. Lets face it 90% of all problems most people have in webapps stem from the fact that you cannot keep objects for a longer time without going through the problems a session scope causes for garbage collection and due to the fact that if you do not work on a pure jdbc base but on an orm base you either have to keep an erm open for your entire session with all related problems or you have to open it on request or even works on business case and then run into the usual merge problems most orm layers have (which is not solvable in a satisfying way anyway) The current already big number of various dialog systems which also keep something conversational open for object storage stem from the fact that this is a huge problem or has become a bigger one now that webapps seem to have moved towards orm layers where this problem becomes more problematic. Tackeling it on JEE level has been long overdue in my opinion especially because most of the usage and core patterns basically are tested by now. Craig since you are reading this, any idea if the servlet specs will be opened to scopes/conversations in the next specifications? Werner -- Arash Rajaeeyan
ServletExternalContextImpl.redirect did not encode URL, so URL-rewriting fail
Hello, I'm using Spring WebFlow (SWF) in combination with MyFaces/Trinidad. I have the problem that the FlowPhaseListener from SWF is calling a method that let ServletExternalContextImpl.redirect be to called. The redirect method is calling a sendRedirect on the response but did not encode the url, so in case of URL-rewriting the jsessionid is not attached! I know that this code-snipplet will solve my problem: ServletExternalContextImpl: String encodedUrl = ((HttpServletResponse)_servletResponse).encodeURL(url); ((HttpServletResponse)_servletResponse).sendRedirect(encodedUrl); Did not no if this is a bug. Hope it is, and my patch will be integrated:) What do you think?! Thanks in advance, Leif
ServletExternalContextImpl.redirect did not encode URL, so URL-rewriting fail
Hello,
I'm using Spring WebFlow (SWF) in combination with MyFaces/Trinidad. I have the
problem that the FlowPhaseListener from SWF is calling a method that triggers
ServletExternalContextImpl.redirect be to called.
ServletExternalContextImpl:
public void redirect(String url) throws IOException
{
if (_servletResponse instanceof HttpServletResponse)
{
((HttpServletResponse)_servletResponse).sendRedirect(url);
FacesContext.getCurrentInstance().responseComplete();
}
else
{
throw new IllegalArgumentException(Only HttpServletResponse
supported);
}
}
The redirect method is calling a sendRedirect on the response but did not
encode the url, so in case of URL-rewriting the jsessionid is not attached!
I know that this code-snipplet will solve my problem:
String encodedUrl = ((HttpServletResponse)_servletResponse).encodeURL(url);
((HttpServletResponse)_servletResponse).sendRedirect(encodedUrl);
Did not no if this is a bug. Hope it is, and my patch will be integrated:)
What do you think?!
Thanks in advance, Leif
Mit freundlichen Grüßen
Leif Hanack
Software Development
Hypoport AG
Klosterstraße 71
D-10179 Berlin
Tel.: +49 (0)30 / 4 20 86 - 292
Fax.: +49 (0)30 / 4 20 86 - 199
E-Mail: [EMAIL PROTECTED] mailto:[EMAIL PROTECTED]
Internet: www.hypoport.de http://www.hypoport.de/
Vorstand: Prof. Dr. Thomas Kretschmar (Co-CEO),
Ronald Slabke (Co-CEO), Marco Kisperth
Aufsichtsrat: Dr. Ottheinz Jung-Senssfelder (Vors.),
Jochen Althoff (stellv. Vors.), Christian Schröder
Handelsregister: HRB 74559, Berlin-Charlottenburg
USt-IdNr.: DE207938067
[ANN] Release of Trinidad's Maven plugins (1.0.0-incubating)
Hi, The Apache Trinidad community is pleased to announce its 1.0.0-incubation release of the Trinidad Maven2 plugins. These Maven2 plugins have been deployed to the Apache Incubator Maven2 repository ([1]). For more informations on the Apache Trinidad podling, please visit our homepage ([2]). For detailed information about what's in this release see our release notes ([3]). [1] http://people.apache.org/repo/m2-incubating-repository/ [2] http://incubator.apache.org/adffaces [3] http://svn.apache.org/viewvc/incubator/adffaces/tags/maven-plugin-parent-1.0.0-incubating/RELEASE_NOTES?revision=512245view=markuppathrev=512245 Incubation Apache Trinidad is an effort undergoing incubation at the Apache Software Foundation (ASF). Incubation is required of all newly accepted projects until a further review indicates that the infrastructure, communications, and decision making process have stabilized in a manner consistent with other successful ASF projects. While incubation status is not necessarily a reflection of the completeness or stability of the code, it does indicate that the project has yet to be fully endorsed by the ASF.
[jira] Updated: (TOMAHAWK-905) s:filterTable and s:sortableColumn missing TLD attributes (FilterTableRenderer)
[ https://issues.apache.org/jira/browse/TOMAHAWK-905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerald Müllan updated TOMAHAWK-905: --- Resolution: Fixed Fix Version/s: 1.1.5-SNAPSHOT Assignee: Gerald Müllan Status: Resolved (was: Patch Available) Many thx to Mike for providing this patch. s:filterTable and s:sortableColumn missing TLD attributes (FilterTableRenderer) --- Key: TOMAHAWK-905 URL: https://issues.apache.org/jira/browse/TOMAHAWK-905 Project: MyFaces Tomahawk Issue Type: Bug Affects Versions: 1.1.5-SNAPSHOT Environment: Tested Tomcat 5.5.17 w/ JDK 1.5.0_10 Reporter: Mike Gillan Assigned To: Gerald Müllan Priority: Trivial Fix For: 1.1.5-SNAPSHOT Attachments: FilterTableRenderer.patch (This is the first issue I've submitted so please be forgiving) The Sandbox s:filterTable and s:sortableColumn components are missing TLD-specified attributes. Specifically: s:filterTable: - styleClass s:sortableColumn - sort - align - valign - format I've created a patch for FilterTableRenderer.java and attempted to render these attributes in the order which matches the dojo FilteringTable widget example found at http://archive.dojotoolkit.org/nightly/tests/widget/test_FilteringTable.html (as of Feb 22, 2007) and I've tested that these attributes are now working. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TOMAHAWK-906) DojoUtils class not handling isAttribute methods in components
[ https://issues.apache.org/jira/browse/TOMAHAWK-906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerald Müllan updated TOMAHAWK-906: --- Resolution: Fixed Fix Version/s: 1.1.5-SNAPSHOT Status: Resolved (was: Patch Available) Many thx to Zdenek Sochor for providing this useful patch. Werner has already committed this stuff but forgotten to resolve. I just resolve it now. DojoUtils class not handling isAttribute methods in components -- Key: TOMAHAWK-906 URL: https://issues.apache.org/jira/browse/TOMAHAWK-906 Project: MyFaces Tomahawk Issue Type: Bug Affects Versions: 1.1.5-SNAPSHOT Reporter: Zdenek Sochor Assigned To: Gerald Müllan Fix For: 1.1.5-SNAPSHOT Attachments: dojo.txt Hi, by looking at org.apache.myfaces.custom.dojoDojoUtils class i found 1 issue, which could block extending usability of dojo. Problem is in static method getAttributeMap(FacesContext, String[] , UIComponent): - it doesn't count with preferred way of declaring get methods dealing with booleans (isAttribute() instead of getAttribute()). Zdenek -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: MyFaces Fusion Naming
I wonder how Kleber sounds for English native speakers? regards, Martin On 2/27/07, Matthias Wessendorf [EMAIL PROTECTED] wrote: +1 for Apache MyFaces Kleber On 2/27/07, Arash Rajaeeyan [EMAIL PROTECTED] wrote: I propose Chasb Chasb means Glue in my native language, we can use other translations of glue like colle colla Kleber lijm κόλλα клей colagem pegamento On 2/28/07, Mario Ivankovits [EMAIL PROTECTED] wrote: Mike, It's up to you, but I'd think using a wiki page would be far easier to manage. You can propose names, and then group them as they're added: I thought that too, and I'll do so tomorrow, for now letz use the jira just to collect the names without any bias. I'll close the jira (maybe tomorrow if no new names follow) and then we should stop proposing new names, at that time I'll take them over to a wiki page and we can start to sort out stuff. I'll maintain the wiki page then; based on ml discussions. Ciao, Mario -- Arash Rajaeeyan -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces
[jira] Updated: (MYFACES-1543) mbean_source.jsp not working
[ https://issues.apache.org/jira/browse/MYFACES-1543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerald Müllan updated MYFACES-1543: --- Resolution: Fixed Fix Version/s: 1.1.6-SNAPSHOT Assignee: Gerald Müllan Status: Resolved (was: Patch Available) Many thx to Martin for providing this patch. mbean_source.jsp not working - Key: MYFACES-1543 URL: https://issues.apache.org/jira/browse/MYFACES-1543 Project: MyFaces Core Issue Type: Bug Components: website Reporter: Martin Haimberger Assigned To: Gerald Müllan Priority: Minor Fix For: 1.1.6-SNAPSHOT Attachments: mbean_patch.patch the mbean_source is not working if for example the myfaces_simple examples are deployed not as docBase. The path the mbean_source.jsp generates is related to the docBase directory. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TOMAHAWK-910) inputSugestAjax onchange JavaScript error
[ https://issues.apache.org/jira/browse/TOMAHAWK-910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerald Müllan updated TOMAHAWK-910: --- Resolution: Fixed Status: Resolved (was: Patch Available) Many thx once again to Stefan for providing this patch. inputSugestAjax onchange JavaScript error - Key: TOMAHAWK-910 URL: https://issues.apache.org/jira/browse/TOMAHAWK-910 Project: MyFaces Tomahawk Issue Type: Bug Components: InputSuggestAjax Affects Versions: 1.1.5-SNAPSHOT Reporter: Stefan Schuster Assigned To: Gerald Müllan Priority: Minor Fix For: 1.1.5-SNAPSHOT Attachments: inputSuggestAjax.patch The JavaScript for the dojo inputSuggestAjax component always tries to call onchange event if no event handler is set for it. This causes javaScript errors. The patch checks if onchange is available and call only if it's available. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: MyFaces Fusion Naming
same like glue sounds to me ... On 2/28/07, Martin Marinschek [EMAIL PROTECTED] wrote: I wonder how Kleber sounds for English native speakers? regards, Martin On 2/27/07, Matthias Wessendorf [EMAIL PROTECTED] wrote: +1 for Apache MyFaces Kleber On 2/27/07, Arash Rajaeeyan [EMAIL PROTECTED] wrote: I propose Chasb Chasb means Glue in my native language, we can use other translations of glue like colle colla Kleber lijm κόλλα клей colagem pegamento On 2/28/07, Mario Ivankovits [EMAIL PROTECTED] wrote: Mike, It's up to you, but I'd think using a wiki page would be far easier to manage. You can propose names, and then group them as they're added: I thought that too, and I'll do so tomorrow, for now letz use the jira just to collect the names without any bias. I'll close the jira (maybe tomorrow if no new names follow) and then we should stop proposing new names, at that time I'll take them over to a wiki page and we can start to sort out stuff. I'll maintain the wiki page then; based on ml discussions. Ciao, Mario -- Arash Rajaeeyan -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com
Re: ServletExternalContextImpl.redirect did not encode URL, so URL-rewriting fail
Please open a jira-issue in our bug-tracker, and attach a patch there
(line-numbers should be included!)
regards,
Martin
On 2/28/07, Hanack, Leif [EMAIL PROTECTED] wrote:
Hello,
I'm using Spring WebFlow (SWF) in combination with MyFaces/Trinidad. I have
the problem that the FlowPhaseListener from SWF is calling a method that
triggers ServletExternalContextImpl.redirect be to called.
ServletExternalContextImpl:
public void redirect(String url) throws IOException
{
if (_servletResponse instanceof HttpServletResponse)
{
((HttpServletResponse)_servletResponse).sendRedirect(url);
FacesContext.getCurrentInstance().responseComplete();
}
else
{
throw new IllegalArgumentException(Only HttpServletResponse
supported);
}
}
The redirect method is calling a sendRedirect on the response but did not
encode the url, so in case of URL-rewriting the jsessionid is not attached!
I know that this code-snipplet will solve my problem:
String encodedUrl =
((HttpServletResponse)_servletResponse).encodeURL(url);
((HttpServletResponse)_servletResponse).sendRedirect(encodedUrl);
Did not no if this is a bug. Hope it is, and my patch will be integrated:)
What do you think?!
Thanks in advance, Leif
Mit freundlichen Grüßen
Leif Hanack
Software Development
Hypoport AG
Klosterstraße 71
D-10179 Berlin
Tel.: +49 (0)30 / 4 20 86 - 292
Fax.: +49 (0)30 / 4 20 86 - 199
E-Mail: [EMAIL PROTECTED]
Internet: www.hypoport.de
Vorstand: Prof. Dr. Thomas Kretschmar (Co-CEO),
Ronald Slabke (Co-CEO), Marco Kisperth
Aufsichtsrat: Dr. Ottheinz Jung-Senssfelder (Vors.),
Jochen Althoff (stellv. Vors.), Christian Schröder
Handelsregister: HRB 74559, Berlin-Charlottenburg
USt-IdNr.: DE207938067
--
http://www.irian.at
Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German
Professional Support for Apache MyFaces
Re: MyFaces Fusion Naming
Hey, I wonder how Kleber sounds for English native speakers? I bet it sounds horrible . I hope so :-) Ciao, Mario
Re: MyFaces Fusion Naming
Well, at times a word means something different in another language, or sounds like a different word? regards, Martin On 2/28/07, Matthias Wessendorf [EMAIL PROTECTED] wrote: same like glue sounds to me ... On 2/28/07, Martin Marinschek [EMAIL PROTECTED] wrote: I wonder how Kleber sounds for English native speakers? regards, Martin On 2/27/07, Matthias Wessendorf [EMAIL PROTECTED] wrote: +1 for Apache MyFaces Kleber On 2/27/07, Arash Rajaeeyan [EMAIL PROTECTED] wrote: I propose Chasb Chasb means Glue in my native language, we can use other translations of glue like colle colla Kleber lijm κόλλα клей colagem pegamento On 2/28/07, Mario Ivankovits [EMAIL PROTECTED] wrote: Mike, It's up to you, but I'd think using a wiki page would be far easier to manage. You can propose names, and then group them as they're added: I thought that too, and I'll do so tomorrow, for now letz use the jira just to collect the names without any bias. I'll close the jira (maybe tomorrow if no new names follow) and then we should stop proposing new names, at that time I'll take them over to a wiki page and we can start to sort out stuff. I'll maintain the wiki page then; based on ml discussions. Ciao, Mario -- Arash Rajaeeyan -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces
[jira] Commented: (MYFACES-1546) Find a new name for Apache MyFaces Fusion
[ https://issues.apache.org/jira/browse/MYFACES-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476577 ] Mario Ivankovits commented on MYFACES-1546: --- direct access Apache MyFaces Pure Apache MyFaces Direct above and beyond: Apache MyFaces Alta Apache MyFaces Sublime from everything a little bit Apache MyFaces Platypus something short Apache MyFaces Brevi (latin - in short time) Find a new name for Apache MyFaces Fusion - Key: MYFACES-1546 URL: https://issues.apache.org/jira/browse/MYFACES-1546 Project: MyFaces Core Issue Type: Task Components: General Reporter: Mario Ivankovits This jira is to collect new names for Apache MyFaces Fusion so far: Apache MyFaces Connections Apache MyFaces Vista Apache MyFaces Salida Apache MyFaces Defender Apache MyFaces Seamless Apache MyFaces Mergence Apache MyFaces Accretion Apache MyFaces Collective Apache MyFaces Aurora Apache MyFaces Concerto Apache MyFaces Orchestra -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[POLL] Sort out of MyFaces Fusion Naming candidates
Hi! Ok, here we go. This is a poll where I hope that we can sort out the most of the names below (shouldn't be that hard ;-), afterwards I hope we are stripped down to max 4 names where we can start a vote then. Thanks for your time! Just remove the names you don't like, I'll try to sum up those decisions on the wiki page then. == Candidates == * Apache MyFaces Connections * Apache MyFaces Vista * Apache MyFaces Salida * Apache MyFaces Defender * Apache MyFaces Seamless * Apache MyFaces Mergence * Apache MyFaces Accretion * Apache MyFaces Collective * Apache MyFaces Aurora * Apache MyFaces Concerto * Apache MyFaces Orchestra * Apache MyFaces ease * Apache MyFaces Snug * Apache MyFaces Rush * Apache MyFaces Salida * Apache MyFaces Piletra * Apache MyFaces Kleber * Apache MyFaces Sepia * Apache MyFaces Chasb * Apache MyFaces Rapid * Apache MyFaces Custos * Apache MyFaces Coire * Apache MyFaces Simplex * Apache MyFaces Transit * Apache MyFaces Tenere * Apache MyFaces Memini * Apache MyFaces Memento * Apache MyFaces Custos * Apache MyFaces Coire * Apache MyFaces Simplex * Apache MyFaces Transit * Apache MyFaces Tenere * Apache MyFaces Memini * Apache MyFaces Memento * Apache MyFaces Pure * Apache MyFaces Direct * Apache MyFaces Alta * Apache MyFaces Sublime * Apache MyFaces Platypus * Apache MyFaces Brevi Ciao, Mario
Re: [POLL] Sort out of MyFaces Fusion Naming candidates
My favorites. * Apache MyFaces Connections * Apache MyFaces Mergence * Apache MyFaces Aurora * Apache MyFaces Concerto * Apache MyFaces ease * Apache MyFaces Snug * Apache MyFaces Custos * Apache MyFaces Simplex * Apache MyFaces Memento * Apache MyFaces Alta * Apache MyFaces Brevi Sorry for the double names - copypaste failure :-(
Re: [POLL] Sort out of MyFaces Fusion Naming candidates
my poll: - Kleber - Chasb - Simplex - Platypus On 2/28/07, Mario Ivankovits [EMAIL PROTECTED] wrote: Hi! Ok, here we go. This is a poll where I hope that we can sort out the most of the names below (shouldn't be that hard ;-), afterwards I hope we are stripped down to max 4 names where we can start a vote then. Thanks for your time! Just remove the names you don't like, I'll try to sum up those decisions on the wiki page then. == Candidates == * Apache MyFaces Connections * Apache MyFaces Vista * Apache MyFaces Salida * Apache MyFaces Defender * Apache MyFaces Seamless * Apache MyFaces Mergence * Apache MyFaces Accretion * Apache MyFaces Collective * Apache MyFaces Aurora * Apache MyFaces Concerto * Apache MyFaces Orchestra * Apache MyFaces ease * Apache MyFaces Snug * Apache MyFaces Rush * Apache MyFaces Salida * Apache MyFaces Piletra * Apache MyFaces Kleber * Apache MyFaces Sepia * Apache MyFaces Chasb * Apache MyFaces Rapid * Apache MyFaces Custos * Apache MyFaces Coire * Apache MyFaces Simplex * Apache MyFaces Transit * Apache MyFaces Tenere * Apache MyFaces Memini * Apache MyFaces Memento * Apache MyFaces Custos * Apache MyFaces Coire * Apache MyFaces Simplex * Apache MyFaces Transit * Apache MyFaces Tenere * Apache MyFaces Memini * Apache MyFaces Memento * Apache MyFaces Pure * Apache MyFaces Direct * Apache MyFaces Alta * Apache MyFaces Sublime * Apache MyFaces Platypus * Apache MyFaces Brevi Ciao, Mario -- Arash Rajaeeyan
Re: [POLL] Sort out of MyFaces Fusion Naming candidates
Kleber On 2/28/07, Arash Rajaeeyan [EMAIL PROTECTED] wrote: my poll: Kleber Chasb Simplex Platypus On 2/28/07, Mario Ivankovits [EMAIL PROTECTED] wrote: Hi! Ok, here we go. This is a poll where I hope that we can sort out the most of the names below (shouldn't be that hard ;-), afterwards I hope we are stripped down to max 4 names where we can start a vote then. Thanks for your time! Just remove the names you don't like, I'll try to sum up those decisions on the wiki page then. == Candidates == * Apache MyFaces Connections * Apache MyFaces Vista * Apache MyFaces Salida * Apache MyFaces Defender * Apache MyFaces Seamless * Apache MyFaces Mergence * Apache MyFaces Accretion * Apache MyFaces Collective * Apache MyFaces Aurora * Apache MyFaces Concerto * Apache MyFaces Orchestra * Apache MyFaces ease * Apache MyFaces Snug * Apache MyFaces Rush * Apache MyFaces Salida * Apache MyFaces Piletra * Apache MyFaces Kleber * Apache MyFaces Sepia * Apache MyFaces Chasb * Apache MyFaces Rapid * Apache MyFaces Custos * Apache MyFaces Coire * Apache MyFaces Simplex * Apache MyFaces Transit * Apache MyFaces Tenere * Apache MyFaces Memini * Apache MyFaces Memento * Apache MyFaces Custos * Apache MyFaces Coire * Apache MyFaces Simplex * Apache MyFaces Transit * Apache MyFaces Tenere * Apache MyFaces Memini * Apache MyFaces Memento * Apache MyFaces Pure * Apache MyFaces Direct * Apache MyFaces Alta * Apache MyFaces Sublime * Apache MyFaces Platypus * Apache MyFaces Brevi Ciao, Mario -- Arash Rajaeeyan -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com
[jira] Created: (MYFACES-1547) ServletExternalContextImpl.redirect did not encode URL, so URL-rewriting fail
ServletExternalContextImpl.redirect did not encode URL, so URL-rewriting fail
-
Key: MYFACES-1547
URL: https://issues.apache.org/jira/browse/MYFACES-1547
Project: MyFaces Core
Issue Type: Bug
Components: General
Affects Versions: 1.1.5
Reporter: Leif Hanack
I'm using Spring WebFlow (SWF) in combination with MyFaces/Trinidad. I have the
problem that the FlowPhaseListener from SWF is calling a method that triggers
ServletExternalContextImpl.redirect be to called.
ServletExternalContextImpl.java
489public void redirect(String url) throws IOException
490{
491if (_servletResponse instanceof HttpServletResponse)
492{
493 ((HttpServletResponse)_servletResponse).sendRedirect(url);
494 FacesContext.getCurrentInstance().responseComplete();
495}
496else
497{
498throw new IllegalArgumentException(Only HttpServletResponse
supported);
499}
500}
The redirect method is calling a sendRedirect on the response but did not
encode the url, so in case of URL-rewriting the jsessionid is not attached!
This patch would solve my problem:
replace line 493 with the following two lines:
String encodedUrl = ((HttpServletResponse)_servletResponse).encodeURL(url);
((HttpServletResponse)_servletResponse).sendRedirect(encodedUrl);
Thanks in advance, Leif
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-1547) ServletExternalContextImpl.redirect did not encode URL, so URL-rewriting fail
[
https://issues.apache.org/jira/browse/MYFACES-1547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leif Hanack updated MYFACES-1547:
-
Status: Patch Available (was: Open)
ServletExternalContextImpl.redirect did not encode URL, so URL-rewriting fail
-
Key: MYFACES-1547
URL: https://issues.apache.org/jira/browse/MYFACES-1547
Project: MyFaces Core
Issue Type: Bug
Components: General
Affects Versions: 1.1.5
Reporter: Leif Hanack
I'm using Spring WebFlow (SWF) in combination with MyFaces/Trinidad. I have
the problem that the FlowPhaseListener from SWF is calling a method that
triggers ServletExternalContextImpl.redirect be to called.
ServletExternalContextImpl.java
489public void redirect(String url) throws IOException
490{
491if (_servletResponse instanceof HttpServletResponse)
492{
493 ((HttpServletResponse)_servletResponse).sendRedirect(url);
494 FacesContext.getCurrentInstance().responseComplete();
495}
496else
497{
498throw new IllegalArgumentException(Only HttpServletResponse
supported);
499}
500}
The redirect method is calling a sendRedirect on the response but did not
encode the url, so in case of URL-rewriting the jsessionid is not attached!
This patch would solve my problem:
replace line 493 with the following two lines:
String encodedUrl = ((HttpServletResponse)_servletResponse).encodeURL(url);
((HttpServletResponse)_servletResponse).sendRedirect(encodedUrl);
Thanks in advance, Leif
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [POLL] Sort out of MyFaces Fusion Naming candidates
Mario, Please include a description of Fusion on the wiki page [1]. With out a good understanding on what the product is, it is hard to name it. Paul Spencer [1] http://wiki.apache.org/myfaces/ApacheMyFacesFusion Mario Ivankovits wrote: Hi! Ok, here we go. This is a poll where I hope that we can sort out the most of the names below (shouldn't be that hard ;-), afterwards I hope we are stripped down to max 4 names where we can start a vote then. Thanks for your time! Just remove the names you don't like, I'll try to sum up those decisions on the wiki page then. == Candidates == * Apache MyFaces Connections * Apache MyFaces Vista * Apache MyFaces Salida * Apache MyFaces Defender * Apache MyFaces Seamless * Apache MyFaces Mergence * Apache MyFaces Accretion * Apache MyFaces Collective * Apache MyFaces Aurora * Apache MyFaces Concerto * Apache MyFaces Orchestra * Apache MyFaces ease * Apache MyFaces Snug * Apache MyFaces Rush * Apache MyFaces Salida * Apache MyFaces Piletra * Apache MyFaces Kleber * Apache MyFaces Sepia * Apache MyFaces Chasb * Apache MyFaces Rapid * Apache MyFaces Custos * Apache MyFaces Coire * Apache MyFaces Simplex * Apache MyFaces Transit * Apache MyFaces Tenere * Apache MyFaces Memini * Apache MyFaces Memento * Apache MyFaces Custos * Apache MyFaces Coire * Apache MyFaces Simplex * Apache MyFaces Transit * Apache MyFaces Tenere * Apache MyFaces Memini * Apache MyFaces Memento * Apache MyFaces Pure * Apache MyFaces Direct * Apache MyFaces Alta * Apache MyFaces Sublime * Apache MyFaces Platypus * Apache MyFaces Brevi Ciao, Mario
[jira] Commented: (MYFACES-1547) ServletExternalContextImpl.redirect did not encode URL, so URL-rewriting fail
[
https://issues.apache.org/jira/browse/MYFACES-1547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476583
]
Matthias Weßendorf commented on MYFACES-1547:
-
please don't add complete files.
use patches instead.
thx
ServletExternalContextImpl.redirect did not encode URL, so URL-rewriting fail
-
Key: MYFACES-1547
URL: https://issues.apache.org/jira/browse/MYFACES-1547
Project: MyFaces Core
Issue Type: Bug
Components: General
Affects Versions: 1.1.5
Reporter: Leif Hanack
Assigned To: Matthias Weßendorf
Attachments: ServletExternalContextImpl.java
I'm using Spring WebFlow (SWF) in combination with MyFaces/Trinidad. I have
the problem that the FlowPhaseListener from SWF is calling a method that
triggers ServletExternalContextImpl.redirect be to called.
ServletExternalContextImpl.java
489public void redirect(String url) throws IOException
490{
491if (_servletResponse instanceof HttpServletResponse)
492{
493 ((HttpServletResponse)_servletResponse).sendRedirect(url);
494 FacesContext.getCurrentInstance().responseComplete();
495}
496else
497{
498throw new IllegalArgumentException(Only HttpServletResponse
supported);
499}
500}
The redirect method is calling a sendRedirect on the response but did not
encode the url, so in case of URL-rewriting the jsessionid is not attached!
This patch would solve my problem:
replace line 493 with the following two lines:
String encodedUrl = ((HttpServletResponse)_servletResponse).encodeURL(url);
((HttpServletResponse)_servletResponse).sendRedirect(encodedUrl);
Thanks in advance, Leif
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1547) ServletExternalContextImpl.redirect did not encode URL, so URL-rewriting fail
[
https://issues.apache.org/jira/browse/MYFACES-1547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476585
]
Leif Hanack commented on MYFACES-1547:
--
sorry, was in a hurry and this is my first experience with jira bug report:)
ServletExternalContextImpl.redirect did not encode URL, so URL-rewriting fail
-
Key: MYFACES-1547
URL: https://issues.apache.org/jira/browse/MYFACES-1547
Project: MyFaces Core
Issue Type: Bug
Components: General
Affects Versions: 1.1.5
Reporter: Leif Hanack
Attachments: ServletExternalContextImpl.java
I'm using Spring WebFlow (SWF) in combination with MyFaces/Trinidad. I have
the problem that the FlowPhaseListener from SWF is calling a method that
triggers ServletExternalContextImpl.redirect be to called.
ServletExternalContextImpl.java
489public void redirect(String url) throws IOException
490{
491if (_servletResponse instanceof HttpServletResponse)
492{
493 ((HttpServletResponse)_servletResponse).sendRedirect(url);
494 FacesContext.getCurrentInstance().responseComplete();
495}
496else
497{
498throw new IllegalArgumentException(Only HttpServletResponse
supported);
499}
500}
The redirect method is calling a sendRedirect on the response but did not
encode the url, so in case of URL-rewriting the jsessionid is not attached!
This patch would solve my problem:
replace line 493 with the following two lines:
String encodedUrl = ((HttpServletResponse)_servletResponse).encodeURL(url);
((HttpServletResponse)_servletResponse).sendRedirect(encodedUrl);
Thanks in advance, Leif
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: ServletExternalContextImpl.redirect did not encode URL, so URL-rewriting fail
I am not sure, if we should do that in general.
In JSF the ExternalContext already contains a
encodeResourceURL() method for that.
On 2/28/07, Martin Marinschek [EMAIL PROTECTED] wrote:
Please open a jira-issue in our bug-tracker, and attach a patch there
(line-numbers should be included!)
regards,
Martin
On 2/28/07, Hanack, Leif [EMAIL PROTECTED] wrote:
Hello,
I'm using Spring WebFlow (SWF) in combination with MyFaces/Trinidad. I have
the problem that the FlowPhaseListener from SWF is calling a method that
triggers ServletExternalContextImpl.redirect be to called.
ServletExternalContextImpl:
public void redirect(String url) throws IOException
{
if (_servletResponse instanceof HttpServletResponse)
{
((HttpServletResponse)_servletResponse).sendRedirect(url);
FacesContext.getCurrentInstance().responseComplete();
}
else
{
throw new IllegalArgumentException(Only HttpServletResponse
supported);
}
}
The redirect method is calling a sendRedirect on the response but did not
encode the url, so in case of URL-rewriting the jsessionid is not attached!
I know that this code-snipplet will solve my problem:
String encodedUrl =
((HttpServletResponse)_servletResponse).encodeURL(url);
((HttpServletResponse)_servletResponse).sendRedirect(encodedUrl);
Did not no if this is a bug. Hope it is, and my patch will be integrated:)
What do you think?!
Thanks in advance, Leif
Mit freundlichen Grüßen
Leif Hanack
Software Development
Hypoport AG
Klosterstraße 71
D-10179 Berlin
Tel.: +49 (0)30 / 4 20 86 - 292
Fax.: +49 (0)30 / 4 20 86 - 199
E-Mail: [EMAIL PROTECTED]
Internet: www.hypoport.de
Vorstand: Prof. Dr. Thomas Kretschmar (Co-CEO),
Ronald Slabke (Co-CEO), Marco Kisperth
Aufsichtsrat: Dr. Ottheinz Jung-Senssfelder (Vors.),
Jochen Althoff (stellv. Vors.), Christian Schröder
Handelsregister: HRB 74559, Berlin-Charlottenburg
USt-IdNr.: DE207938067
--
http://www.irian.at
Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German
Professional Support for Apache MyFaces
--
Matthias Wessendorf
http://tinyurl.com/fmywh
further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com
AW: ServletExternalContextImpl.redirect did not encode URL, so URL-rewriting fail
Mmh, the problem is, that the public method redirect is used from other APIs as
well.
E.g. Spring WebFlow using it directly which is causing my problem so fare.
Here are some details :
http://forum.springframework.org/showthread.php?t=35495highlight=redirect
Maybe it is a Spring WebFlow issue. Nevertheless, why not prevent the client
APIs from handling that problem?!
Thanks, Leif
-Ursprüngliche Nachricht-
Von: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Im Auftrag von Matthias
Wessendorf
Gesendet: Mittwoch, 28. Februar 2007 14:49
An: MyFaces Development
Betreff: Re: ServletExternalContextImpl.redirect did not encode URL, so
URL-rewriting fail
I am not sure, if we should do that in general.
In JSF the ExternalContext already contains a
encodeResourceURL() method for that.
On 2/28/07, Martin Marinschek [EMAIL PROTECTED] wrote:
Please open a jira-issue in our bug-tracker, and attach a patch there
(line-numbers should be included!)
regards,
Martin
On 2/28/07, Hanack, Leif [EMAIL PROTECTED] wrote:
Hello,
I'm using Spring WebFlow (SWF) in combination with MyFaces/Trinidad.
I have the problem that the FlowPhaseListener from SWF is calling a
method that triggers ServletExternalContextImpl.redirect be to called.
ServletExternalContextImpl:
public void redirect(String url) throws IOException
{
if (_servletResponse instanceof HttpServletResponse)
{
((HttpServletResponse)_servletResponse).sendRedirect(url);
FacesContext.getCurrentInstance().responseComplete();
}
else
{
throw new IllegalArgumentException(Only
HttpServletResponse supported);
}
}
The redirect method is calling a sendRedirect on the response but
did not encode the url, so in case of URL-rewriting the jsessionid is not
attached!
I know that this code-snipplet will solve my problem:
String encodedUrl =
((HttpServletResponse)_servletResponse).encodeURL(url);
((HttpServletResponse)_servletResponse).sendRedirect(encodedUrl);
Did not no if this is a bug. Hope it is, and my patch will be
integrated:)
What do you think?!
Thanks in advance, Leif
Mit freundlichen Grüßen
Leif Hanack
Software Development
Hypoport AG
Klosterstraße 71
D-10179 Berlin
Tel.: +49 (0)30 / 4 20 86 - 292
Fax.: +49 (0)30 / 4 20 86 - 199
E-Mail: [EMAIL PROTECTED]
Internet: www.hypoport.de
Vorstand: Prof. Dr. Thomas Kretschmar (Co-CEO), Ronald Slabke
(Co-CEO), Marco Kisperth
Aufsichtsrat: Dr. Ottheinz Jung-Senssfelder (Vors.), Jochen Althoff
(stellv. Vors.), Christian Schröder
Handelsregister: HRB 74559, Berlin-Charlottenburg
USt-IdNr.: DE207938067
--
http://www.irian.at
Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German
Professional Support for Apache MyFaces
--
Matthias Wessendorf
http://tinyurl.com/fmywh
further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com
Re: [POLL] Sort out of MyFaces Fusion Naming candidates
Hi Paul! Please include a description of Fusion on the wiki page [1]. With out a good understanding on what the product is, it is hard to name it. Done, I hope I managed to express things sufficient. Ciao, Mario [1] http://wiki.apache.org/myfaces/ApacheMyFacesFusion
Re: [POLL] Sort out of MyFaces Fusion Naming candidates
Thanks, Now I know what it is. Paul Spencer Mario Ivankovits wrote: Hi Paul! Please include a description of Fusion on the wiki page [1]. With out a good understanding on what the product is, it is hard to name it. Done, I hope I managed to express things sufficient. Ciao, Mario [1] http://wiki.apache.org/myfaces/ApacheMyFacesFusion
Re: MyFaces Fusion Naming
It probably sounds like Clever. It looks like Keebler (a cookie/cracker manufacturer). On 2/28/07, Mario Ivankovits [EMAIL PROTECTED] wrote: Hey, I wonder how Kleber sounds for English native speakers? I bet it sounds horrible . I hope so :-) Ciao, Mario
Re: MyFaces Fusion Naming
Mike Kienenberger schrieb: It probably sounds like Clever. Hmmm I start to like it :-)
Re: [POLL] Sort out of MyFaces Fusion Naming candidates
kleber simplex salida
Re: MyFaces Fusion Naming
Ok, then I like it, and it gets my vote (on the other thread). regards, Martin On 2/28/07, Mario Ivankovits [EMAIL PROTECTED] wrote: Mike Kienenberger schrieb: It probably sounds like Clever. Hmmm I start to like it :-) -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces
Re: [POLL] Sort out of MyFaces Fusion Naming candidates
I like a lot of the names, but Apache MyFaces Kleber is doing exactly what the word means in German ;) regards, Martin On 2/28/07, Paul Spencer [EMAIL PROTECTED] wrote: Thanks, Now I know what it is. Paul Spencer Mario Ivankovits wrote: Hi Paul! Please include a description of Fusion on the wiki page [1]. With out a good understanding on what the product is, it is hard to name it. Done, I hope I managed to express things sufficient. Ciao, Mario [1] http://wiki.apache.org/myfaces/ApacheMyFacesFusion -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces
Re: [jira] Created: (MYFACES-1545) UISelectOne validation fails with custom converter
Guy,
In your particular case, you can try to use
f:selectItem itemValue={1} itemLabel=1 /
On 2/28/07, Guy Coleman [EMAIL PROTECTED] wrote:
On 27/02/2007 15:23, Dainius Vaznys (JIRA) wrote:
UISelectOne validation fails with custom converter
--
Key: MYFACES-1545
URL: https://issues.apache.org/jira/browse/MYFACES-1545
Project: MyFaces Core
Issue Type: Bug
Affects Versions: 1.1.5
Reporter: Dainius Vaznys
This seems to be closely related with MYFACES-1328.
I have a Converted configured with a UISelectOne which converts between
strings and enum values, i.e. getAsObject() returns an Enum instance. After the
convertion takes place UISelectOne.validateValue() is invoked to check if the Enum
instance is among select items. This code definitely does not work:
Object itemValue = item.getValue();
if (value==itemValue || value.equals(itemValue))
{
return true;
}
as it tries to match an Enum instance against a string.
This sounds a lot like a problem I discovered when I upgraded from 1.1.3
to 1.1.5:
https://javaserverfaces.dev.java.net/servlets/ReadMsg?list=usersmsgNo=175
Short answer: that's how it's supposed to work in JSF 1.1 and I needed
to change my code.
-Guy.
Re: MyFaces Fusion Naming
Manfred Geiler wrote: Apache MyFaces Orchestra? --Manfred I like the sound of this for a product. I agree though, that something along the lines of glue would be very intuitive for this particular subproject. btw, Kleber will draw blank stares from us english native-speakers. :D
[jira] Commented: (MYFACES-1546) Find a new name for Apache MyFaces Fusion
[ https://issues.apache.org/jira/browse/MYFACES-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476617 ] Jeff Bischoff commented on MYFACES-1546: Transit is not bad... How about: Apache MyFaces Bistro? Find a new name for Apache MyFaces Fusion - Key: MYFACES-1546 URL: https://issues.apache.org/jira/browse/MYFACES-1546 Project: MyFaces Core Issue Type: Task Components: General Reporter: Mario Ivankovits This jira is to collect new names for Apache MyFaces Fusion so far: Apache MyFaces Connections Apache MyFaces Vista Apache MyFaces Salida Apache MyFaces Defender Apache MyFaces Seamless Apache MyFaces Mergence Apache MyFaces Accretion Apache MyFaces Collective Apache MyFaces Aurora Apache MyFaces Concerto Apache MyFaces Orchestra -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [POLL] Sort out of MyFaces Fusion Naming candidates
Kleber On 2/28/07, Martin Marinschek [EMAIL PROTECTED] wrote: I like a lot of the names, but Apache MyFaces Kleber is doing exactly what the word means in German ;) regards, Martin On 2/28/07, Paul Spencer [EMAIL PROTECTED] wrote: Thanks, Now I know what it is. Paul Spencer Mario Ivankovits wrote: Hi Paul! Please include a description of Fusion on the wiki page [1]. With out a good understanding on what the product is, it is hard to name it. Done, I hope I managed to express things sufficient. Ciao, Mario [1] http://wiki.apache.org/myfaces/ApacheMyFacesFusion -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces
[BUG] javascript error on mozilla when click()
Hello I use javascript to simulate button click and send a postback to the
server. Here is the java script:
document.getElementById('myId').click();
the button defenition in JSF id classic :
h:commandButton id=myId actionListener=#{myListener}
When used with Internet Explorer this code works, when used in Firefox it
complaines that it cannot find the javascript for the submit operation.!
Please give me a workaround, or some way to go ahead thank you.
--
View this message in context:
http://www.nabble.com/-BUG--javascript-error-on-mozilla-when-click%28%29-tf3309636.html#a9206218
Sent from the My Faces - Dev mailing list archive at Nabble.com.
Re: [BUG] javascript error on mozilla when click()
Hi!
Hello I use javascript to simulate button click and send a postback to the
server. Here is the java script:
document.getElementById('myId').click();
If possible have a look at our sandbox component s:submitOnEvent [1]
It solves many of the problems you might have when you try to do it
manually.
Ciao,
Mario
[1] http://wiki.apache.org/myfaces/SubmitOnEvent
Re: [jira] [BUG] javascript error on mozilla when click()
I am not sure how this sendbox component will solve my case. But even if
it can i prefer
to use another workaround because i am currently using combination of
myfaces, facelets and
icefaces and to add aditional component there can be compatability issues.
Do you know some kind of workaround to this problem with mozilla?
Mario Ivankovits wrote:
Hi!
Hello I use javascript to simulate button click and send a postback to
the
server. Here is the java script:
document.getElementById('myId').click();
If possible have a look at our sandbox component s:submitOnEvent [1]
It solves many of the problems you might have when you try to do it
manually.
Ciao,
Mario
[1] http://wiki.apache.org/myfaces/SubmitOnEvent
--
View this message in context:
http://www.nabble.com/-BUG--javascript-error-on-mozilla-when-click%28%29-tf3309636.html#a9206619
Sent from the My Faces - Dev mailing list archive at Nabble.com.
Re: [BUG] javascript error on mozilla when click()
Hi!
document.getElementById('myId').click();
the button defenition in JSF id classic :
h:commandButton id=myId actionListener=#{myListener}
Are you really using just the same id for getElementById and the id
defined for the commandButton?
Its very unlikely that this works, though, should not work with IE too,
as the client id for a jsf comonent is prefixed with the ids of any
parent naming container.
Please double check that you use the correct javascript id by looking at
the generated html.
Anything else looks fine. Maybe have a look at [1] too.
Ciao,
Mario
[1] http://wiki.apache.org/myfaces/SubmitPageOnValueChange
Re: ServletExternalContextImpl.redirect did not encode URL, so URL-rewriting fail
well, I think, if this *really* belongs together, it should be done in
the underlying layer
(servlet/portlet api)
I think your fix is to do the encodeURL() inside the SWF stuff.
Just out of curiosity, any special reason for not using Shale,
since that Dialog stuff from Shale was developed for JSF
(having SWF in mind, of course)
-M
On 2/28/07, Hanack, Leif [EMAIL PROTECTED] wrote:
Mmh, the problem is, that the public method redirect is used from other APIs as
well.
E.g. Spring WebFlow using it directly which is causing my problem so fare.
Here are some details :
http://forum.springframework.org/showthread.php?t=35495highlight=redirect
Maybe it is a Spring WebFlow issue. Nevertheless, why not prevent the client
APIs from handling that problem?!
Thanks, Leif
-Ursprüngliche Nachricht-
Von: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Im Auftrag von Matthias
Wessendorf
Gesendet: Mittwoch, 28. Februar 2007 14:49
An: MyFaces Development
Betreff: Re: ServletExternalContextImpl.redirect did not encode URL, so
URL-rewriting fail
I am not sure, if we should do that in general.
In JSF the ExternalContext already contains a
encodeResourceURL() method for that.
On 2/28/07, Martin Marinschek [EMAIL PROTECTED] wrote:
Please open a jira-issue in our bug-tracker, and attach a patch there
(line-numbers should be included!)
regards,
Martin
On 2/28/07, Hanack, Leif [EMAIL PROTECTED] wrote:
Hello,
I'm using Spring WebFlow (SWF) in combination with MyFaces/Trinidad.
I have the problem that the FlowPhaseListener from SWF is calling a
method that triggers ServletExternalContextImpl.redirect be to called.
ServletExternalContextImpl:
public void redirect(String url) throws IOException
{
if (_servletResponse instanceof HttpServletResponse)
{
((HttpServletResponse)_servletResponse).sendRedirect(url);
FacesContext.getCurrentInstance().responseComplete();
}
else
{
throw new IllegalArgumentException(Only
HttpServletResponse supported);
}
}
The redirect method is calling a sendRedirect on the response but
did not encode the url, so in case of URL-rewriting the jsessionid is not
attached!
I know that this code-snipplet will solve my problem:
String encodedUrl =
((HttpServletResponse)_servletResponse).encodeURL(url);
((HttpServletResponse)_servletResponse).sendRedirect(encodedUrl);
Did not no if this is a bug. Hope it is, and my patch will be
integrated:)
What do you think?!
Thanks in advance, Leif
Mit freundlichen Grüßen
Leif Hanack
Software Development
Hypoport AG
Klosterstraße 71
D-10179 Berlin
Tel.: +49 (0)30 / 4 20 86 - 292
Fax.: +49 (0)30 / 4 20 86 - 199
E-Mail: [EMAIL PROTECTED]
Internet: www.hypoport.de
Vorstand: Prof. Dr. Thomas Kretschmar (Co-CEO), Ronald Slabke
(Co-CEO), Marco Kisperth
Aufsichtsrat: Dr. Ottheinz Jung-Senssfelder (Vors.), Jochen Althoff
(stellv. Vors.), Christian Schröder
Handelsregister: HRB 74559, Berlin-Charlottenburg
USt-IdNr.: DE207938067
--
http://www.irian.at
Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German
Professional Support for Apache MyFaces
--
Matthias Wessendorf
http://tinyurl.com/fmywh
further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com
--
Matthias Wessendorf
http://tinyurl.com/fmywh
further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com
Re: [POLL] Sort out of MyFaces Fusion Naming candidates
I know it is not on the list but how about Apache MyFaces Repartee. The definition [1] is similar to what the product does. [1] http://www.m-w.com/dictionary/repartee Paul Spencer Paul Spencer wrote: Thanks, Now I know what it is. Paul Spencer Mario Ivankovits wrote: Hi Paul! Please include a description of Fusion on the wiki page [1]. With out a good understanding on what the product is, it is hard to name it. Done, I hope I managed to express things sufficient. Ciao, Mario [1] http://wiki.apache.org/myfaces/ApacheMyFacesFusion
RE: MyFaces Fusion Naming
I would pronounce Kleber as klee-ber with a long E sound like cleaver (a large knife or an instrument for cutting things apart, which might be ironic given the word's meaning in German). The word Kleber has no obvious meaning in English. Even after reading the description on the Wiki page, I still have no idea what this stuff is supposed to do or how it is to be used. If it has primarily to do with something called conversations (whatever that means), maybe use a name like conversation or a synonym in some language would be better? Richard J. Barbalace Cambridge, MA, USA -Original Message- From: Mike Kienenberger [mailto:[EMAIL PROTECTED] Sent: Wednesday, February 28, 2007 9:21 AM To: MyFaces Development Subject: Re: MyFaces Fusion Naming It probably sounds like Clever. It looks like Keebler (a cookie/cracker manufacturer). On 2/28/07, Mario Ivankovits [EMAIL PROTECTED] wrote: Hey, I wonder how Kleber sounds for English native speakers? I bet it sounds horrible . I hope so :-) Ciao, Mario The information transmitted in this electronic communication is intended only for the person or entity to whom it is addressed and may contain confidential and/or privileged material. Any review, retransmission, dissemination or other use of or taking of any action in reliance upon this information by persons or entities other than the intended recipient is prohibited. If you received this information in error, please contact the Compliance HelpLine at 800-856-1983 and properly dispose of this information.
[jira] Commented: (MYFACES-1546) Find a new name for Apache MyFaces Fusion
[ https://issues.apache.org/jira/browse/MYFACES-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476636 ] Grant Smith commented on MYFACES-1546: -- The United States of MyFaces Find a new name for Apache MyFaces Fusion - Key: MYFACES-1546 URL: https://issues.apache.org/jira/browse/MYFACES-1546 Project: MyFaces Core Issue Type: Task Components: General Reporter: Mario Ivankovits This jira is to collect new names for Apache MyFaces Fusion so far: Apache MyFaces Connections Apache MyFaces Vista Apache MyFaces Salida Apache MyFaces Defender Apache MyFaces Seamless Apache MyFaces Mergence Apache MyFaces Accretion Apache MyFaces Collective Apache MyFaces Aurora Apache MyFaces Concerto Apache MyFaces Orchestra -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1546) Find a new name for Apache MyFaces Fusion
[ https://issues.apache.org/jira/browse/MYFACES-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476637 ] Grant Smith commented on MYFACES-1546: -- No, but seriously: Apache MyFaces States Apache MyFaces StateConverse Apache MyFaces Converse Apache MyFaces Talk Apache MyFaces StateOrchestra Apache MyFaces Music Apache MyFaces Debate Apache MyFaces Fellowship --- I Like this one Find a new name for Apache MyFaces Fusion - Key: MYFACES-1546 URL: https://issues.apache.org/jira/browse/MYFACES-1546 Project: MyFaces Core Issue Type: Task Components: General Reporter: Mario Ivankovits This jira is to collect new names for Apache MyFaces Fusion so far: Apache MyFaces Connections Apache MyFaces Vista Apache MyFaces Salida Apache MyFaces Defender Apache MyFaces Seamless Apache MyFaces Mergence Apache MyFaces Accretion Apache MyFaces Collective Apache MyFaces Aurora Apache MyFaces Concerto Apache MyFaces Orchestra -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [jira] [BUG] javascript error on mozilla when click()
I found it easier to manually import s:submitOnEvent into my
application. (I'm not using a recent-enough sandbox snapshot to
include it). Then you don't have to worry about the javascript
issues.
On 2/28/07, PeshoChuka [EMAIL PROTECTED] wrote:
Ok maybe example is not very good. Yes i am using the prefix from the
father container.
h:form id=myForm
h:commandButon id=myComand actionListener=#{mylistener}/
/h:form
and the javascript call is:
document.getElementById('myForm:myCommad');
as i said earlier this works on IE7.0 but in Mozilla throws javascript error
because it cannot find
the submit script of the button. The error is Missing resource
Mario Ivankovits wrote:
Hi!
document.getElementById('myId').click();
the button defenition in JSF id classic :
h:commandButton id=myId actionListener=#{myListener}
Are you really using just the same id for getElementById and the id
defined for the commandButton?
Its very unlikely that this works, though, should not work with IE too,
as the client id for a jsf comonent is prefixed with the ids of any
parent naming container.
Please double check that you use the correct javascript id by looking at
the generated html.
Anything else looks fine. Maybe have a look at [1] too.
Ciao,
Mario
[1] http://wiki.apache.org/myfaces/SubmitPageOnValueChange
--
View this message in context:
http://www.nabble.com/-BUG--javascript-error-on-mozilla-when-click%28%29-tf3309636.html#a9207581
Sent from the My Faces - Dev mailing list archive at Nabble.com.
Re: MyFaces Fusion Naming
OK, nix my previous vote. I just added the following to the JIRA: The United States of MyFaces (joke) Apache MyFaces States Apache MyFaces StateConverse Apache MyFaces Converse Apache MyFaces Talk Apache MyFaces StateOrchestra Apache MyFaces Music Apache MyFaces Debate Apache MyFaces Fellowship --- I Like this one -- Grant Smith
Re: [jira] Commented: (MYFACES-1546) Find a new name for Apache MyFaces Fusion
On 2/28/07, Grant Smith (JIRA) dev@myfaces.apache.org wrote: Apache MyFaces Fellowship --- I Like this one I think we should save this one for the future merged Tomahawk/Trinidad/Tobago project :-)
[jira] Created: (TOMAHAWK-913) Layout of DataTable with groups + alternating rowStyles looks really bad
Layout of DataTable with groups + alternating rowStyles looks really bad
Key: TOMAHAWK-913
URL: https://issues.apache.org/jira/browse/TOMAHAWK-913
Project: MyFaces Tomahawk
Issue Type: Improvement
Components: Extended Datatable
Affects Versions: 1.1.3, 1.1.5-SNAPSHOT
Reporter: Paul Palaszewski
Priority: Minor
Hi!
I'm using Extended Data Tables and wanted to use the column's groupBy. Now all
normal tables of this project have rowStyles with alternating
row-background-colors, so I tried to apply them also on the grouped data. It
looks really bad, since the generated row-span messes up the layout.
The rowGroupStyle does not help - it's only useable as group separator style,
therefor I think the name is a litte bit confusing - but that's another issue.
I suggest, that the rowStyles should work on groups rather than on rows. Tried
to patch HtmlTableRenderer accordingly and works fine for me:
HtmlTableRenderer#createColumnInfos
[..]
int currentRowSpan=-1;
int currentRowInfoIndex=-1;
int groupCount = 0; // added by PP
TableContext tableContext=htmlDataTable.getTableContext();
[..]
if(groupEndReached)
{
currentRowSpan=0;
groupEndReached = false;
groupCount++; // added by PP
}
rowInfo.setGroupIndex(groupCount); // added by PP
tableContext.getRowInfos().add(rowInfo);
HtmlTableRenderer#renderRowStyle
String rowStyleClass;
String rowStyle;
if (uiData instanceof HtmlDataTable)
{
HtmlDataTable datatable = (HtmlDataTable) uiData;
rowStyleClass = datatable.getRowStyleClass();
rowStyle = datatable.getRowStyle();
// added by PP
TableContext tableContext = datatable.getTableContext();
if (tableContext != null tableContext.getRowInfos() != null
tableContext.getRowInfos().size() rowStyleIndex) {
RowInfo rowInfo = (RowInfo)
tableContext.getRowInfos().get(rowStyleIndex);
if (rowInfo.getGroupIndex() = 0) rowStyleIndex =
rowInfo.getGroupIndex();
}
RowInfo added
private int _groupIndex = -1;
public int getGroupIndex() {
return _groupIndex;
}
public void setGroupIndex(int groupIndex) {
_groupIndex = groupIndex;
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TOMAHAWK-913) Layout of DataTable with groups + alternating rowStyles looks really bad
[
https://issues.apache.org/jira/browse/TOMAHAWK-913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Palaszewski updated TOMAHAWK-913:
--
Status: Patch Available (was: Open)
Layout of DataTable with groups + alternating rowStyles looks really bad
Key: TOMAHAWK-913
URL: https://issues.apache.org/jira/browse/TOMAHAWK-913
Project: MyFaces Tomahawk
Issue Type: Improvement
Components: Extended Datatable
Affects Versions: 1.1.3, 1.1.5-SNAPSHOT
Reporter: Paul Palaszewski
Priority: Minor
Hi!
I'm using Extended Data Tables and wanted to use the column's groupBy. Now
all normal tables of this project have rowStyles with alternating
row-background-colors, so I tried to apply them also on the grouped data. It
looks really bad, since the generated row-span messes up the layout.
The rowGroupStyle does not help - it's only useable as group separator style,
therefor I think the name is a litte bit confusing - but that's another issue.
I suggest, that the rowStyles should work on groups rather than on rows.
Tried to patch HtmlTableRenderer accordingly and works fine for me:
HtmlTableRenderer#createColumnInfos
[..]
int currentRowSpan=-1;
int currentRowInfoIndex=-1;
int groupCount = 0; // added by PP
TableContext tableContext=htmlDataTable.getTableContext();
[..]
if(groupEndReached)
{
currentRowSpan=0;
groupEndReached = false;
groupCount++; // added by PP
}
rowInfo.setGroupIndex(groupCount); // added by PP
tableContext.getRowInfos().add(rowInfo);
HtmlTableRenderer#renderRowStyle
String rowStyleClass;
String rowStyle;
if (uiData instanceof HtmlDataTable)
{
HtmlDataTable datatable = (HtmlDataTable) uiData;
rowStyleClass = datatable.getRowStyleClass();
rowStyle = datatable.getRowStyle();
// added by PP
TableContext tableContext = datatable.getTableContext();
if (tableContext != null tableContext.getRowInfos() != null
tableContext.getRowInfos().size() rowStyleIndex) {
RowInfo rowInfo = (RowInfo)
tableContext.getRowInfos().get(rowStyleIndex);
if (rowInfo.getGroupIndex() = 0) rowStyleIndex =
rowInfo.getGroupIndex();
}
RowInfo added
private int _groupIndex = -1;
public int getGroupIndex() {
return _groupIndex;
}
public void setGroupIndex(int groupIndex) {
_groupIndex = groupIndex;
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TOMAHAWK-912) HtmlDataTable's column groupBy should work with HtmlCommandLinks ...
[
https://issues.apache.org/jira/browse/TOMAHAWK-912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Palaszewski updated TOMAHAWK-912:
--
Status: Patch Available (was: Open)
HtmlDataTable's column groupBy should work with HtmlCommandLinks ...
Key: TOMAHAWK-912
URL: https://issues.apache.org/jira/browse/TOMAHAWK-912
Project: MyFaces Tomahawk
Issue Type: Improvement
Components: Extended Datatable
Affects Versions: 1.1.3, 1.1.5-SNAPSHOT
Reporter: Paul Palaszewski
Hi!
I'm using the extended data table with groupBy which works fine for
outputText (any ValueHolder derived from UIOutput), but it ignores
commandLinks, which is anoying if the column's value is only displayed as
link.
I've checked versions 1.1.3 and 1.1.5 snapshot ... imho, the issue is in
HtmlTableRenderer#createColumnInfos somewhere around line 286 which looks
like ..
UIComponent currentColumnChild = (UIComponent)
currentColumnChildren.get(j);
if (currentColumnChild.isRendered() currentColumnChild
instanceof ValueHolder)
{
Object value = ((ValueHolder)
currentColumnChild).getValue();
if (value != null) {
Converter converter =
HtmlRendererUtils.findUIOutputConverterFailSafe(facesContext,
currentColumnChild);
currentColumnContent.append(
RendererUtils.getConvertedStringValue(facesContext, currentColumnChild,
converter, value)); // TODO converter
}
}
HtmlCommandLinks are UICommands and not UIOutputs which implement
ValueHolder. To fix this, I tried to patch HtmlCommandLink to implement
ValueHolder, but this results in a class cast exception since some part of
#findUIOutputConverterFailSafe tries to cast the component as UIOutput. So
I've added another instance of, which works fine for me:
UIComponent currentColumnChild = (UIComponent)
currentColumnChildren.get(j);
if (currentColumnChild.isRendered()) {
if (currentColumnChild instanceof ValueHolder)
{
Object value = ((ValueHolder)
currentColumnChild).getValue();
if (value != null) {
Converter converter =
HtmlRendererUtils.findUIOutputConverterFailSafe(facesContext,
currentColumnChild);
currentColumnContent.append(
RendererUtils.getConvertedStringValue(facesContext, currentColumnChild,
converter, value)); // TODO converter
}
} else if (currentColumnChild instanceof UICommand) {
Object value = ((UICommand)
currentColumnChild).getValue();
if (value != null) {
currentColumnContent.append(value);
}
}
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: Proposed changes to t:dataTable regarding the new EL specification
Yeah, looks good - go ahead.
regards,
Martin
On 2/28/07, Jeff Bischoff [EMAIL PROTECTED] wrote:
JSFAttr class has the following attributes incompatible with Facelets:
// dataTable (extended) attributes
String ROW_ID =
org.apache.myfaces.dataTable.ROW_ID;
String ROW_STYLECLASS_ATTR =
org.apache.myfaces.dataTable.ROW_STYLECLASS;
String ROW_STYLE_ATTR =
org.apache.myfaces.dataTable.ROW_STYLE;
I will definately fix StyleClass and Style in this patch. Not sure what
to do about ROW_ID. I don't use it in my app, and not sure what it's
supposed to do or how to test it. Documentation on the attribute is
incomplete (literally, half a sentence in the TLD). I see the attribute
being set in the JSP tag handler, but I don't see this attribute used in
the extended dataTable class anywhere. Therefore, my feeling is to just
leave it and fix the other two. Thoughts?
Regards,
Jeff Bischoff
Kenneth L Kurz Associates, Inc.
Jeff Bischoff wrote:
If there's no objections, I'll open a JIRA and submit a patch. :)
Mike Kienenberger wrote:
This change looks good to me. It's probably more important that the
value binding be able to default to null than to output an empty
string css style.
On 2/22/07, Jeff Bischoff [EMAIL PROTECTED] wrote:
Greets,
After converting my application from JSP to Facelets, I set out to make
my rowStyleClass attribute on t:dataTable work like it used to.
First, I had to get the attribute working in Facelets. With considerable
discussion on the user list (see [1] and [2]) and a lot of help from
Mike, I think we've identified some pretty simple code changes to enable
this and other similar attributes. I plan to introduce a patch for this,
probably tomorrow.
What happened next was that during testing of this change, I could
confirm that the attribute did indeed now work, but I was baffled by
unexpected behaviour. My EL expression which had previously returned
null in certain situations was now returning the empty String. I went to
Facelets list for some clarification on this (see [3]) and it turned out
to be a requirement of the new EL spec to coerce the nulls into empty
string.
Getting an empty String instead of null for this ValueBinding lookup
creates a problem because the extended dataTable treats a null value
differently and goes looking at the more standard style attributes like
rowClasses. With an empty string returned, it assumes it needs to look
no further. As a user, there is no way for me to specify that under
certain conditions, it should fallback to the other style attributes,
e.g. rowClasses.
The best fix we have collectively come up with so far is to coerce the
empty string back into a null in the dataTable, so that the renderer
does the right thing. I don't see too much downside to this approach, as
an empty style string has no relevance in CSS. However, I feel a
proposed change like this requires extra discussion before making a
decision on it. It's another one of those situation where we have to
decide how we want to handle unexpected results due to changes in the
newer specs.
If you review the threads a bit, you can see more of the details of the
issues. I'll post my preliminary proposed code changes at the bottom.
[1] https://facelets.dev.java.net/servlets/ReadMsg?list=usersmsgNo=6875
[2]
http://www.nabble.com/Re%3A-Facelets-support-for-a-Tomahawk-dataTable-trick--tf3236491.html
[3] https://facelets.dev.java.net/servlets/ReadMsg?list=usersmsgNo=6941
Regards,
Jeff Bischoff
Kenneth L Kurz Associates, Inc.
Okay proposed code change in
org.apache.myfaces.component.html.ext.HtmlDataTable
Original Method:
public String getRowStyleClass()
{
if (_rowStyleClass != null)
return _rowStyleClass;
ValueBinding vb = getValueBinding(JSFAttr.ROW_STYLECLASS_ATTR);
return vb != null ? (String) vb.getValue(getFacesContext())
: null;
}
New Method:
public String getRowStyleClass()
{
if (_rowStyleClass != null)
return _rowStyleClass;
// TODO: temporarily support fully-qualified ext. dataTable
attribute names.
ValueBinding vb =
getValueBinding(org.apache.myfaces.dataTable.ROW_STYLECLASS);
if (vb != null)
log.warn(org.apache.myfaces.dataTable.ROW_STYLECLASS is
deprecated. Please use rowStyleClass instead.);
else
vb = getValueBinding(JSFAttr.ROW_STYLECLASS_ATTR);
if(vb == null)
return null;
String bindingValue = (String) vb.getValue(getFacesContext());
if(bindingValue == )
return null; // Fix for JSF 1.2 EL coercing nulls to empty
string
return bindingValue;
}
That, along with the change to JSFAttr to change the constant value from
org.apache.myfaces.dataTable.ROW_STYLECLASS to rowStyleClass. NOTE:
This change affects the shared code!
--
http://www.irian.at
Your
Re: Proposed changes to t:dataTable regarding the new EL specification
JSFAttr class has the following attributes incompatible with Facelets:
// dataTable (extended) attributes
String ROW_ID =
org.apache.myfaces.dataTable.ROW_ID;
String ROW_STYLECLASS_ATTR =
org.apache.myfaces.dataTable.ROW_STYLECLASS;
String ROW_STYLE_ATTR =
org.apache.myfaces.dataTable.ROW_STYLE;
I will definately fix StyleClass and Style in this patch. Not sure what
to do about ROW_ID. I don't use it in my app, and not sure what it's
supposed to do or how to test it. Documentation on the attribute is
incomplete (literally, half a sentence in the TLD). I see the attribute
being set in the JSP tag handler, but I don't see this attribute used in
the extended dataTable class anywhere. Therefore, my feeling is to just
leave it and fix the other two. Thoughts?
Regards,
Jeff Bischoff
Kenneth L Kurz Associates, Inc.
Jeff Bischoff wrote:
If there's no objections, I'll open a JIRA and submit a patch. :)
Mike Kienenberger wrote:
This change looks good to me. It's probably more important that the
value binding be able to default to null than to output an empty
string css style.
On 2/22/07, Jeff Bischoff [EMAIL PROTECTED] wrote:
Greets,
After converting my application from JSP to Facelets, I set out to make
my rowStyleClass attribute on t:dataTable work like it used to.
First, I had to get the attribute working in Facelets. With considerable
discussion on the user list (see [1] and [2]) and a lot of help from
Mike, I think we've identified some pretty simple code changes to enable
this and other similar attributes. I plan to introduce a patch for this,
probably tomorrow.
What happened next was that during testing of this change, I could
confirm that the attribute did indeed now work, but I was baffled by
unexpected behaviour. My EL expression which had previously returned
null in certain situations was now returning the empty String. I went to
Facelets list for some clarification on this (see [3]) and it turned out
to be a requirement of the new EL spec to coerce the nulls into empty
string.
Getting an empty String instead of null for this ValueBinding lookup
creates a problem because the extended dataTable treats a null value
differently and goes looking at the more standard style attributes like
rowClasses. With an empty string returned, it assumes it needs to look
no further. As a user, there is no way for me to specify that under
certain conditions, it should fallback to the other style attributes,
e.g. rowClasses.
The best fix we have collectively come up with so far is to coerce the
empty string back into a null in the dataTable, so that the renderer
does the right thing. I don't see too much downside to this approach, as
an empty style string has no relevance in CSS. However, I feel a
proposed change like this requires extra discussion before making a
decision on it. It's another one of those situation where we have to
decide how we want to handle unexpected results due to changes in the
newer specs.
If you review the threads a bit, you can see more of the details of the
issues. I'll post my preliminary proposed code changes at the bottom.
[1] https://facelets.dev.java.net/servlets/ReadMsg?list=usersmsgNo=6875
[2]
http://www.nabble.com/Re%3A-Facelets-support-for-a-Tomahawk-dataTable-trick--tf3236491.html
[3] https://facelets.dev.java.net/servlets/ReadMsg?list=usersmsgNo=6941
Regards,
Jeff Bischoff
Kenneth L Kurz Associates, Inc.
Okay proposed code change in
org.apache.myfaces.component.html.ext.HtmlDataTable
Original Method:
public String getRowStyleClass()
{
if (_rowStyleClass != null)
return _rowStyleClass;
ValueBinding vb = getValueBinding(JSFAttr.ROW_STYLECLASS_ATTR);
return vb != null ? (String) vb.getValue(getFacesContext())
: null;
}
New Method:
public String getRowStyleClass()
{
if (_rowStyleClass != null)
return _rowStyleClass;
// TODO: temporarily support fully-qualified ext. dataTable
attribute names.
ValueBinding vb =
getValueBinding(org.apache.myfaces.dataTable.ROW_STYLECLASS);
if (vb != null)
log.warn(org.apache.myfaces.dataTable.ROW_STYLECLASS is
deprecated. Please use rowStyleClass instead.);
else
vb = getValueBinding(JSFAttr.ROW_STYLECLASS_ATTR);
if(vb == null)
return null;
String bindingValue = (String) vb.getValue(getFacesContext());
if(bindingValue == )
return null; // Fix for JSF 1.2 EL coercing nulls to empty
string
return bindingValue;
}
That, along with the change to JSFAttr to change the constant value from
org.apache.myfaces.dataTable.ROW_STYLECLASS to rowStyleClass. NOTE:
This change affects the shared code!
[jira] Created: (MYFACES-1548) UIComponent State change if getValueBinding() is called.
UIComponent State change if getValueBinding() is called. Key: MYFACES-1548 URL: https://issues.apache.org/jira/browse/MYFACES-1548 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.2.0-SNAPSHOT Reporter: Martin Haimberger Fix For: 1.2.0-SNAPSHOT The Component State change if getValueBinding() is called and no _valueExpressionMap is present. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-1548) UIComponent State change if getValueBinding() is called.
[ https://issues.apache.org/jira/browse/MYFACES-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Haimberger updated MYFACES-1548: --- Status: Patch Available (was: Open) UIComponent State change if getValueBinding() is called. Key: MYFACES-1548 URL: https://issues.apache.org/jira/browse/MYFACES-1548 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.2.0-SNAPSHOT Reporter: Martin Haimberger Fix For: 1.2.0-SNAPSHOT The Component State change if getValueBinding() is called and no _valueExpressionMap is present. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (TOMAHAWK-912) HtmlDataTable's column groupBy should work with HtmlCommandLinks ...
Paul,
Your logic sounds reasonable to me, but I've never used groupBy.
On 2/28/07, Paul Palaszewski (JIRA) dev@myfaces.apache.org wrote:
[
https://issues.apache.org/jira/browse/TOMAHAWK-912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Palaszewski updated TOMAHAWK-912:
--
Status: Patch Available (was: Open)
HtmlDataTable's column groupBy should work with HtmlCommandLinks ...
Key: TOMAHAWK-912
URL: https://issues.apache.org/jira/browse/TOMAHAWK-912
Project: MyFaces Tomahawk
Issue Type: Improvement
Components: Extended Datatable
Affects Versions: 1.1.3, 1.1.5-SNAPSHOT
Reporter: Paul Palaszewski
Hi!
I'm using the extended data table with groupBy which works fine for
outputText (any ValueHolder derived from UIOutput), but it ignores commandLinks,
which is anoying if the column's value is only displayed as link.
I've checked versions 1.1.3 and 1.1.5 snapshot ... imho, the issue is in
HtmlTableRenderer#createColumnInfos somewhere around line 286 which looks like ..
UIComponent currentColumnChild = (UIComponent)
currentColumnChildren.get(j);
if (currentColumnChild.isRendered() currentColumnChild
instanceof ValueHolder)
{
Object value = ((ValueHolder)
currentColumnChild).getValue();
if (value != null) {
Converter converter =
HtmlRendererUtils.findUIOutputConverterFailSafe(facesContext, currentColumnChild);
currentColumnContent.append(
RendererUtils.getConvertedStringValue(facesContext, currentColumnChild,
converter, value)); // TODO converter
}
}
HtmlCommandLinks are UICommands and not UIOutputs which implement
ValueHolder. To fix this, I tried to patch HtmlCommandLink to implement
ValueHolder, but this results in a class cast exception since some part of
#findUIOutputConverterFailSafe tries to cast the component as UIOutput. So I've
added another instance of, which works fine for me:
UIComponent currentColumnChild = (UIComponent)
currentColumnChildren.get(j);
if (currentColumnChild.isRendered()) {
if (currentColumnChild instanceof ValueHolder)
{
Object value = ((ValueHolder)
currentColumnChild).getValue();
if (value != null) {
Converter converter =
HtmlRendererUtils.findUIOutputConverterFailSafe(facesContext, currentColumnChild);
currentColumnContent.append(
RendererUtils.getConvertedStringValue(facesContext, currentColumnChild,
converter, value)); // TODO converter
}
} else if (currentColumnChild instanceof UICommand) {
Object value = ((UICommand)
currentColumnChild).getValue();
if (value != null) {
currentColumnContent.append(value);
}
}
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1546) Find a new name for Apache MyFaces Fusion
[ https://issues.apache.org/jira/browse/MYFACES-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476707 ] Thomas Spiegl commented on MYFACES-1546: Apache MyFaces Cement Apache MyFaces Plaster Find a new name for Apache MyFaces Fusion - Key: MYFACES-1546 URL: https://issues.apache.org/jira/browse/MYFACES-1546 Project: MyFaces Core Issue Type: Task Components: General Reporter: Mario Ivankovits This jira is to collect new names for Apache MyFaces Fusion so far: Apache MyFaces Connections Apache MyFaces Vista Apache MyFaces Salida Apache MyFaces Defender Apache MyFaces Seamless Apache MyFaces Mergence Apache MyFaces Accretion Apache MyFaces Collective Apache MyFaces Aurora Apache MyFaces Concerto Apache MyFaces Orchestra -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOBAGO-305) Deutsch Umlaut will not be rendered correct for tc:out tag with attribute [escape=false]
[
https://issues.apache.org/jira/browse/TOBAGO-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476706
]
Guido Dubois commented on TOBAGO-305:
-
Hello Volker,
thanks for your answer. I know that it works without escape=false. But in
some cases I use #160; for nbsp; or lt;bgt;for boldlt;/bgt; or lt;br
/gt; for newline. Than I have to use escape=false.
For uuml; I get the following error in eclipse.
The entity uuml was referenced, but not declared.
bbg_tobagoPRJ/trunk/WebContent/bbg-resource/html/standard/standard/property/overview.properties.xml
The properties.xml file is not well formed with this element. In the browser
the character is not rendered.
Deutsch Umlaut will not be rendered correct for tc:out tag with attribute
[escape=false]
Key: TOBAGO-305
URL: https://issues.apache.org/jira/browse/TOBAGO-305
Project: MyFaces Tobago
Issue Type: Bug
Components: Core
Affects Versions: 1.0.9
Environment: winxp prof, tomcat 5.5.20, myfaces 1.1.5 snap
(06.02.2007 04:51), tobago 1.0.10 snap (26.02.2007 5:00)
Reporter: Guido Dubois
The deutsch Umlaut will not be rendered correct.
tc:out value=#{overviewBundle.text}
escape=false /
bundle:
entry key=textBruttobetrag in EUR (abzügl. Sparerfreibetrag und
Werbungskosten)/entry
result looks like this:
Bruttobetrag in EUR (abz�parerfreibetrag und Werbungskosten)
uuml; is not possible and #252; has the same effect
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: MyFaces Fusion Naming
2 more ... Apache MyFaces Cement Apache MyFaces Plaster On 2/28/07, Grant Smith [EMAIL PROTECTED] wrote: OK, nix my previous vote. I just added the following to the JIRA: The United States of MyFaces (joke) Apache MyFaces States Apache MyFaces StateConverse Apache MyFaces Converse Apache MyFaces Talk Apache MyFaces StateOrchestra Apache MyFaces Music Apache MyFaces Debate Apache MyFaces Fellowship --- I Like this one -- Grant Smith -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces
[jira] Created: (TOMAHAWK-914) t:dataTable style attributes don't work with Facelets
t:dataTable style attributes don't work with Facelets - Key: TOMAHAWK-914 URL: https://issues.apache.org/jira/browse/TOMAHAWK-914 Project: MyFaces Tomahawk Issue Type: Bug Components: Extended Datatable Affects Versions: 1.1.4-SNAPSHOT, 1.1.5-SNAPSHOT Environment: MyFaces Core 1.1.5, Facelets 1.1.11 Reporter: Jeff Bischoff Attachments: HtmlDataTable.java.diff, JSFAttr.java.diff Problem: style and styleClass attributes on t:dataTable do not work in Facelets due to use of fully-qualified names in the map. Fix: Patch attached to resolve this by changing the names as stored in the map. Includes code to accept hacks based on the old behaviour, but warns that it is now deprecated. Bonus: Also includes fix for problem in Facelets where the EL can not return a null style. This is due to changes in the EL spec, and prevents the former (very useful) style rollover behaviour. Fix works by converting any empty String returned by the EL in these Style attributes into null. (Reverse Coercion) Background: After converting my application from JSP to Facelets, I set out to make my rowStyleClass attribute on t:dataTable work like it used to. First, I had to get the attribute working in Facelets. With considerable discussion on the user list (see [1] and [2]) and a lot of help from Mike, I think we've identified some pretty simple code changes to enable this and other similar attributes. I plan to introduce a patch for this, probably tomorrow. What happened next was that during testing of this change, I could confirm that the attribute did indeed now work, but I was baffled by unexpected behaviour. My EL expression which had previously returned null in certain situations was now returning the empty String. I went to Facelets list for some clarification on this (see [3]) and it turned out to be a requirement of the new EL spec to coerce the nulls into empty string. Getting an empty String instead of null for this ValueBinding lookup creates a problem because the extended dataTable treats a null value differently and goes looking at the more standard style attributes like rowClasses. With an empty string returned, it assumes it needs to look no further. As a user, there is no way for me to specify that under certain conditions, it should fallback to the other style attributes, e.g. rowClasses. The best fix we have collectively come up with so far is to coerce the empty string back into a null in the dataTable, so that the renderer does the right thing. I don't see too much downside to this approach, as an empty style string has no relevance in CSS. However, I feel a proposed change like this requires extra discussion before making a decision on it. It's another one of those situation where we have to decide how we want to handle unexpected results due to changes in the newer specs. [1] https://facelets.dev.java.net/servlets/ReadMsg?list=usersmsgNo=6875 [2] http://www.nabble.com/Re%3A-Facelets-support-for-a-Tomahawk-dataTable-trick--tf3236491.html [3] https://facelets.dev.java.net/servlets/ReadMsg?list=usersmsgNo=6941 Regards, Jeff Bischoff Kenneth L Kurz Associates, Inc. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TOMAHAWK-914) t:dataTable style attributes don't work with Facelets
[ https://issues.apache.org/jira/browse/TOMAHAWK-914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Bischoff updated TOMAHAWK-914: --- Status: Patch Available (was: Open) t:dataTable style attributes don't work with Facelets - Key: TOMAHAWK-914 URL: https://issues.apache.org/jira/browse/TOMAHAWK-914 Project: MyFaces Tomahawk Issue Type: Bug Components: Extended Datatable Affects Versions: 1.1.4-SNAPSHOT, 1.1.5-SNAPSHOT Environment: MyFaces Core 1.1.5, Facelets 1.1.11 Reporter: Jeff Bischoff Attachments: HtmlDataTable.java.diff, JSFAttr.java.diff Problem: style and styleClass attributes on t:dataTable do not work in Facelets due to use of fully-qualified names in the map. Fix: Patch attached to resolve this by changing the names as stored in the map. Includes code to accept hacks based on the old behaviour, but warns that it is now deprecated. Bonus: Also includes fix for problem in Facelets where the EL can not return a null style. This is due to changes in the EL spec, and prevents the former (very useful) style rollover behaviour. Fix works by converting any empty String returned by the EL in these Style attributes into null. (Reverse Coercion) Background: After converting my application from JSP to Facelets, I set out to make my rowStyleClass attribute on t:dataTable work like it used to. First, I had to get the attribute working in Facelets. With considerable discussion on the user list (see [1] and [2]) and a lot of help from Mike, I think we've identified some pretty simple code changes to enable this and other similar attributes. I plan to introduce a patch for this, probably tomorrow. What happened next was that during testing of this change, I could confirm that the attribute did indeed now work, but I was baffled by unexpected behaviour. My EL expression which had previously returned null in certain situations was now returning the empty String. I went to Facelets list for some clarification on this (see [3]) and it turned out to be a requirement of the new EL spec to coerce the nulls into empty string. Getting an empty String instead of null for this ValueBinding lookup creates a problem because the extended dataTable treats a null value differently and goes looking at the more standard style attributes like rowClasses. With an empty string returned, it assumes it needs to look no further. As a user, there is no way for me to specify that under certain conditions, it should fallback to the other style attributes, e.g. rowClasses. The best fix we have collectively come up with so far is to coerce the empty string back into a null in the dataTable, so that the renderer does the right thing. I don't see too much downside to this approach, as an empty style string has no relevance in CSS. However, I feel a proposed change like this requires extra discussion before making a decision on it. It's another one of those situation where we have to decide how we want to handle unexpected results due to changes in the newer specs. [1] https://facelets.dev.java.net/servlets/ReadMsg?list=usersmsgNo=6875 [2] http://www.nabble.com/Re%3A-Facelets-support-for-a-Tomahawk-dataTable-trick--tf3236491.html [3] https://facelets.dev.java.net/servlets/ReadMsg?list=usersmsgNo=6941 Regards, Jeff Bischoff Kenneth L Kurz Associates, Inc. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: MyFaces Fusion Naming
I like em :D Thomas Spiegl wrote: 2 more ... Apache MyFaces Cement Apache MyFaces Plaster On 2/28/07, Grant Smith [EMAIL PROTECTED] wrote: OK, nix my previous vote. I just added the following to the JIRA: The United States of MyFaces (joke) Apache MyFaces States Apache MyFaces StateConverse Apache MyFaces Converse Apache MyFaces Talk Apache MyFaces StateOrchestra Apache MyFaces Music Apache MyFaces Debate Apache MyFaces Fellowship --- I Like this one -- Grant Smith
[jira] Commented: (TOBAGO-273) Having a tc:command tag for change in tc:in would be useful
[ https://issues.apache.org/jira/browse/TOBAGO-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476709 ] Guido Dubois commented on TOBAGO-273: - It works! Thanks. The only thing: In one case I want to use this in a popup box. When I change the value of the first field, I am able now to update the content of another field. But the cursor jumps into the first editable field of the background form. Having a tc:command tag for change in tc:in would be useful --- Key: TOBAGO-273 URL: https://issues.apache.org/jira/browse/TOBAGO-273 Project: MyFaces Tobago Issue Type: Improvement Components: Core Affects Versions: 1.0.10 Environment: All Reporter: Helmut Swaczinna Assigned To: Bernd Bohmann Fix For: 1.0.10 With a tc:command tag for change in tc:in it would be possible to execute some server side action when the user changes the content of a input field. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
RE: Re: MyFaces Fusion Naming
I would avoid any nouns associated with 'heavy', I think it's contradictory to what Fusion is attempting to do. Stick to: http://thesaurus.reference.com/browse/fusion 2 more ... Apache MyFaces Cement Apache MyFaces Plaster On 2/28/07, Grant Smith [EMAIL PROTECTED] wrote: OK, nix my previous vote. I just added the following to the JIRA: The United States of MyFaces (joke) Apache MyFaces States Apache MyFaces StateConverse Apache MyFaces Converse Apache MyFaces Talk Apache MyFaces StateOrchestra Apache MyFaces Music Apache MyFaces Debate Apache MyFaces Fellowship --- I Like this one -- Grant Smith -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces
Re: MyFaces Fusion Naming
In that case, how about: Apache Myfaces Spider ...as in Spider Webs... obviously, can't use web itself :P [EMAIL PROTECTED] wrote: I would avoid any nouns associated with 'heavy', I think it's contradictory to what Fusion is attempting to do. Stick to: http://thesaurus.reference.com/browse/fusion 2 more ... Apache MyFaces Cement Apache MyFaces Plaster On 2/28/07, Grant Smith [EMAIL PROTECTED] wrote: OK, nix my previous vote. I just added the following to the JIRA: The United States of MyFaces (joke) Apache MyFaces States Apache MyFaces StateConverse Apache MyFaces Converse Apache MyFaces Talk Apache MyFaces StateOrchestra Apache MyFaces Music Apache MyFaces Debate Apache MyFaces Fellowship --- I Like this one -- Grant Smith -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces
MyFaces Fusion Documentation
Hi! I've started the documentation by creating two xdoc files in myfaces/fusion/core/src/site, now when I run mvn site from within myfaces/fusion it creates a site, but only a handful of pages in core/target/site and they do not use our stylesheet. Now: *) Shall I put the documentation into the module directory, or is it fine if I put them directly into fusion? For me its sufficient to have only one place for the documentation for the core and core15 modules. *) Anyway, what can be wrong with the site generation in fusion/core ? *) At last maven fail with [INFO] Generate Checkstyle report. [INFO] [ERROR] BUILD ERROR [INFO] [INFO] Error during page generation Embedded error: Error rendering Maven report: Unable to find configuration file location. Unable to find location 'config/myfaces-checks.xml' as URL, File or Resource. Again, I do not know what can be wrong here. Could one please volunteer help fixing the maven stuff to build a nice site so we can start deploy it to the public? Thanks! Ciao, Mario
Re: MyFaces Fusion Naming
Hi Jeff! Apache Myfaces Spider I like it, though the first hit in google with software spider results in http://www.spider-software.de/ Ciao, Mario
Re: Proposed changes to t:dataTable regarding the new EL specification
Jeff,
In the future, it would be better to add patches to an existing JIRA
issue when one exists rather than opening a new one.
On 2/28/07, Jeff Bischoff [EMAIL PROTECTED] wrote:
JSFAttr class has the following attributes incompatible with Facelets:
// dataTable (extended) attributes
String ROW_ID =
org.apache.myfaces.dataTable.ROW_ID;
String ROW_STYLECLASS_ATTR =
org.apache.myfaces.dataTable.ROW_STYLECLASS;
String ROW_STYLE_ATTR =
org.apache.myfaces.dataTable.ROW_STYLE;
I will definately fix StyleClass and Style in this patch. Not sure what
to do about ROW_ID. I don't use it in my app, and not sure what it's
supposed to do or how to test it. Documentation on the attribute is
incomplete (literally, half a sentence in the TLD). I see the attribute
being set in the JSP tag handler, but I don't see this attribute used in
the extended dataTable class anywhere. Therefore, my feeling is to just
leave it and fix the other two. Thoughts?
Regards,
Jeff Bischoff
Kenneth L Kurz Associates, Inc.
Jeff Bischoff wrote:
If there's no objections, I'll open a JIRA and submit a patch. :)
Mike Kienenberger wrote:
This change looks good to me. It's probably more important that the
value binding be able to default to null than to output an empty
string css style.
On 2/22/07, Jeff Bischoff [EMAIL PROTECTED] wrote:
Greets,
After converting my application from JSP to Facelets, I set out to make
my rowStyleClass attribute on t:dataTable work like it used to.
First, I had to get the attribute working in Facelets. With considerable
discussion on the user list (see [1] and [2]) and a lot of help from
Mike, I think we've identified some pretty simple code changes to enable
this and other similar attributes. I plan to introduce a patch for this,
probably tomorrow.
What happened next was that during testing of this change, I could
confirm that the attribute did indeed now work, but I was baffled by
unexpected behaviour. My EL expression which had previously returned
null in certain situations was now returning the empty String. I went to
Facelets list for some clarification on this (see [3]) and it turned out
to be a requirement of the new EL spec to coerce the nulls into empty
string.
Getting an empty String instead of null for this ValueBinding lookup
creates a problem because the extended dataTable treats a null value
differently and goes looking at the more standard style attributes like
rowClasses. With an empty string returned, it assumes it needs to look
no further. As a user, there is no way for me to specify that under
certain conditions, it should fallback to the other style attributes,
e.g. rowClasses.
The best fix we have collectively come up with so far is to coerce the
empty string back into a null in the dataTable, so that the renderer
does the right thing. I don't see too much downside to this approach, as
an empty style string has no relevance in CSS. However, I feel a
proposed change like this requires extra discussion before making a
decision on it. It's another one of those situation where we have to
decide how we want to handle unexpected results due to changes in the
newer specs.
If you review the threads a bit, you can see more of the details of the
issues. I'll post my preliminary proposed code changes at the bottom.
[1] https://facelets.dev.java.net/servlets/ReadMsg?list=usersmsgNo=6875
[2]
http://www.nabble.com/Re%3A-Facelets-support-for-a-Tomahawk-dataTable-trick--tf3236491.html
[3] https://facelets.dev.java.net/servlets/ReadMsg?list=usersmsgNo=6941
Regards,
Jeff Bischoff
Kenneth L Kurz Associates, Inc.
Okay proposed code change in
org.apache.myfaces.component.html.ext.HtmlDataTable
Original Method:
public String getRowStyleClass()
{
if (_rowStyleClass != null)
return _rowStyleClass;
ValueBinding vb = getValueBinding(JSFAttr.ROW_STYLECLASS_ATTR);
return vb != null ? (String) vb.getValue(getFacesContext())
: null;
}
New Method:
public String getRowStyleClass()
{
if (_rowStyleClass != null)
return _rowStyleClass;
// TODO: temporarily support fully-qualified ext. dataTable
attribute names.
ValueBinding vb =
getValueBinding(org.apache.myfaces.dataTable.ROW_STYLECLASS);
if (vb != null)
log.warn(org.apache.myfaces.dataTable.ROW_STYLECLASS is
deprecated. Please use rowStyleClass instead.);
else
vb = getValueBinding(JSFAttr.ROW_STYLECLASS_ATTR);
if(vb == null)
return null;
String bindingValue = (String) vb.getValue(getFacesContext());
if(bindingValue == )
return null; // Fix for JSF 1.2 EL coercing nulls to empty
string
return bindingValue;
}
That, along with the change to JSFAttr to change the constant value from
org.apache.myfaces.dataTable.ROW_STYLECLASS to rowStyleClass. NOTE:
This
Re: MyFaces Fusion Naming
Glad you liked it. Yeah I figured it would be pretty common name, but at least not as bad as Spyder! (taken by both SP ETF fund and major winter sports gear company) Anyway it's a cool name, but probably too common Mario Ivankovits wrote: Hi Jeff! Apache Myfaces Spider I like it, though the first hit in google with software spider results in http://www.spider-software.de/ Ciao, Mario
Re: Proposed changes to t:dataTable regarding the new EL specification
Hi Mike,
Sorry! I forgot about TOMAHAWK-523. I remembered there were the similar
JIRA issues that affected Tree2, but didn't remember this one existed. I
see you already marked it as part of TOMAHAWK-914, thank you!!
Regards,
Jeff Bischoff
Kenneth L Kurz Associates, Inc.
Mike Kienenberger wrote:
Jeff,
In the future, it would be better to add patches to an existing JIRA
issue when one exists rather than opening a new one.
On 2/28/07, Jeff Bischoff [EMAIL PROTECTED] wrote:
JSFAttr class has the following attributes incompatible with Facelets:
// dataTable (extended) attributes
String ROW_ID =
org.apache.myfaces.dataTable.ROW_ID;
String ROW_STYLECLASS_ATTR =
org.apache.myfaces.dataTable.ROW_STYLECLASS;
String ROW_STYLE_ATTR =
org.apache.myfaces.dataTable.ROW_STYLE;
I will definately fix StyleClass and Style in this patch. Not sure what
to do about ROW_ID. I don't use it in my app, and not sure what it's
supposed to do or how to test it. Documentation on the attribute is
incomplete (literally, half a sentence in the TLD). I see the attribute
being set in the JSP tag handler, but I don't see this attribute used in
the extended dataTable class anywhere. Therefore, my feeling is to just
leave it and fix the other two. Thoughts?
Regards,
Jeff Bischoff
Kenneth L Kurz Associates, Inc.
Jeff Bischoff wrote:
If there's no objections, I'll open a JIRA and submit a patch. :)
Mike Kienenberger wrote:
This change looks good to me. It's probably more important that the
value binding be able to default to null than to output an empty
string css style.
On 2/22/07, Jeff Bischoff [EMAIL PROTECTED] wrote:
Greets,
After converting my application from JSP to Facelets, I set out to
make
my rowStyleClass attribute on t:dataTable work like it used to.
First, I had to get the attribute working in Facelets. With
considerable
discussion on the user list (see [1] and [2]) and a lot of help from
Mike, I think we've identified some pretty simple code changes to
enable
this and other similar attributes. I plan to introduce a patch for
this,
probably tomorrow.
What happened next was that during testing of this change, I could
confirm that the attribute did indeed now work, but I was baffled by
unexpected behaviour. My EL expression which had previously returned
null in certain situations was now returning the empty String. I
went to
Facelets list for some clarification on this (see [3]) and it
turned out
to be a requirement of the new EL spec to coerce the nulls into empty
string.
Getting an empty String instead of null for this ValueBinding lookup
creates a problem because the extended dataTable treats a null value
differently and goes looking at the more standard style attributes
like
rowClasses. With an empty string returned, it assumes it needs to
look
no further. As a user, there is no way for me to specify that under
certain conditions, it should fallback to the other style attributes,
e.g. rowClasses.
The best fix we have collectively come up with so far is to coerce
the
empty string back into a null in the dataTable, so that the renderer
does the right thing. I don't see too much downside to this
approach, as
an empty style string has no relevance in CSS. However, I feel a
proposed change like this requires extra discussion before making a
decision on it. It's another one of those situation where we have to
decide how we want to handle unexpected results due to changes in the
newer specs.
If you review the threads a bit, you can see more of the details
of the
issues. I'll post my preliminary proposed code changes at the bottom.
[1]
https://facelets.dev.java.net/servlets/ReadMsg?list=usersmsgNo=6875
[2]
http://www.nabble.com/Re%3A-Facelets-support-for-a-Tomahawk-dataTable-trick--tf3236491.html
[3]
https://facelets.dev.java.net/servlets/ReadMsg?list=usersmsgNo=6941
Regards,
Jeff Bischoff
Kenneth L Kurz Associates, Inc.
Okay proposed code change in
org.apache.myfaces.component.html.ext.HtmlDataTable
Original Method:
public String getRowStyleClass()
{
if (_rowStyleClass != null)
return _rowStyleClass;
ValueBinding vb =
getValueBinding(JSFAttr.ROW_STYLECLASS_ATTR);
return vb != null ? (String) vb.getValue(getFacesContext())
: null;
}
New Method:
public String getRowStyleClass()
{
if (_rowStyleClass != null)
return _rowStyleClass;
// TODO: temporarily support fully-qualified ext. dataTable
attribute names.
ValueBinding vb =
getValueBinding(org.apache.myfaces.dataTable.ROW_STYLECLASS);
if (vb != null)
log.warn(org.apache.myfaces.dataTable.ROW_STYLECLASS is
deprecated. Please use rowStyleClass instead.);
else
vb = getValueBinding(JSFAttr.ROW_STYLECLASS_ATTR);
if(vb == null)
return null;
String
Heads up re: Apache Geronimo and JavaOne
Just a heads up what's happening in Apache Geronimo. We're currently working to complete a server that passes all required tests before JavaOne. It would be most excellent to be able to get visibility for Apache Geronimo at this industry event. So why am I sending you this note? We are using MyFaces to meet the requirements around JSF. I just wanted to give you a heads up on where were going. We'll need to lock down our release for testing at the end of March (yup, an insane amount of work remains) so if ya'll are interested in helping that would be awesome. Also, I'll let you know in he March / April timeframe for a released or stable version of code. Hopefully that will be possible. Just wanted to get on your radar. Matt Hogstrom
[jira] Commented: (TOBAGO-273) Having a tc:command tag for change in tc:in would be useful
[ https://issues.apache.org/jira/browse/TOBAGO-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476751 ] Bernd Bohmann commented on TOBAGO-273: -- you can configure the focus with the focusId attribute of tc:page http://myfaces.apache.org/tobago/tobago-core/tlddoc/tc/page.html Having a tc:command tag for change in tc:in would be useful --- Key: TOBAGO-273 URL: https://issues.apache.org/jira/browse/TOBAGO-273 Project: MyFaces Tobago Issue Type: Improvement Components: Core Affects Versions: 1.0.10 Environment: All Reporter: Helmut Swaczinna Assigned To: Bernd Bohmann Fix For: 1.0.10 With a tc:command tag for change in tc:in it would be possible to execute some server side action when the user changes the content of a input field. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: MyFaces Fusion Naming
another one ... Apache MyFaces Edge On 2/28/07, Jeff Bischoff [EMAIL PROTECTED] wrote: Glad you liked it. Yeah I figured it would be pretty common name, but at least not as bad as Spyder! (taken by both SP ETF fund and major winter sports gear company) Anyway it's a cool name, but probably too common Mario Ivankovits wrote: Hi Jeff! Apache Myfaces Spider I like it, though the first hit in google with software spider results in http://www.spider-software.de/ Ciao, Mario -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces
[jira] Created: (TOBAGO-308) Tree Rendering Only Root Node
Tree Rendering Only Root Node - Key: TOBAGO-308 URL: https://issues.apache.org/jira/browse/TOBAGO-308 Project: MyFaces Tobago Issue Type: Bug Components: Core Affects Versions: 1.0.9, 1.0.10 Reporter: Mark P. Mullally Fix For: 1.0.10 Only the root node of a tree renders because the TreeOldNode.getRendersChildren() returns true. Susequently, the TreeOldRenderer.getNodesAsJavascript() -- RenderUtil.encode(facesContext, root) method executes component.encodeChildren(faceContext) instead of the the recusive child loop, which relies on the TreeOldNodeRenderer.encodeChildren() method that is NOT OVERRIDDEN and the base implementation is a no-op. Therefore, I don't see how trees ever rendered correctly? I extended the TreeOldNode to return false from getRendersChildren() so that the TreeOldRenderer.getNodesAsJavascript() -- RenderUtil.encode() method executes the recursive child loop FIXING THE ISSUE. Again, HOW DID THIS EVER WORK? AM I MISSING SOMETHING? Also, The Old code is deprecated but no standard in favor of comments exist. What should I be using? MyFaces or Tomahawk tree? btw...I am using the Feb 28 nightly build snapshot for 1.0.10 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOBAGO-286) target and tip attributes for tc:menuitem and tc:tree nodes
[
https://issues.apache.org/jira/browse/TOBAGO-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476789
]
Guido Dubois commented on TOBAGO-286:
-
Hello Udo,
it doesn't work. The PDF doc in the example is opened in the same window. I
used the nightly build from 28.02.2007 5:**
tc:menuItem immediate=true label=#{overviewBundle.menu_table2}
link=/pdf/V5300_Tab2_Pauschalkuerzungen.pdf target=_blank /
In the tc:link tag it works correct. The PDF doc is opened in a new window.
That's what I want...
tc:link immediate=true label=#{overviewBundle.menu_table2}
link=/pdf/V5300_Tab2_Pauschalkuerzungen.pdf target=_blank /
target and tip attributes for tc:menuitem and tc:tree nodes
---
Key: TOBAGO-286
URL: https://issues.apache.org/jira/browse/TOBAGO-286
Project: MyFaces Tobago
Issue Type: Improvement
Affects Versions: 1.0.9
Environment: winxp prof, tomcat 5.5.20, myfaces 1.1.4, tobago 1.0.9 -
same in tobago 1.0.10 snap (15.02.2007 5:10)
Reporter: Guido Dubois
Assigned To: Udo Schnurpfeil
Fix For: 1.0.10
The tc:menuitem and tc:tree (tree nodes) should support a target and a
tip attribute to open a browser window and show a tooltip
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
JSR 299 (Web Beans) in need of new Apache rep
If you are interested, please contact me directly. Thanks you. -- James Mitchell
[jira] Commented: (TOBAGO-286) target and tip attributes for tc:menuitem and tc:tree nodes
[ https://issues.apache.org/jira/browse/TOBAGO-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476852 ] Bernd Bohmann commented on TOBAGO-286: -- The target attribute in menuItem works only for the action attribute. target and tip attributes for tc:menuitem and tc:tree nodes --- Key: TOBAGO-286 URL: https://issues.apache.org/jira/browse/TOBAGO-286 Project: MyFaces Tobago Issue Type: Improvement Affects Versions: 1.0.9 Environment: winxp prof, tomcat 5.5.20, myfaces 1.1.4, tobago 1.0.9 - same in tobago 1.0.10 snap (15.02.2007 5:10) Reporter: Guido Dubois Assigned To: Udo Schnurpfeil Fix For: 1.0.10 The tc:menuitem and tc:tree (tree nodes) should support a target and a tip attribute to open a browser window and show a tooltip -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
