Re: Unit test failing? (was: Re: [VOTE] release for myfaces core 2.0.0)

2010-04-15 Thread Matthias Wessendorf
These two revisions cause the problem: http://svn.apache.org/viewvc?view=revisionrevision=933814 http://svn.apache.org/viewvc?view=revisionrevision=933812 On Thu, Apr 15, 2010 at 7:43 AM, Matthias Wessendorf mat...@apache.org wrote: Yesterday I mentioned the same, on trunk I am on Linux,

Re: Unit test failing? (was: Re: [VOTE] release for myfaces core 2.0.0)

2010-04-15 Thread Leonardo Uribe
Hi In my machine works fine. I compiled sources on both Linux and Windows. regards, Leonardo Uribe 2010/4/15 Matthias Wessendorf mat...@apache.org These two revisions cause the problem: http://svn.apache.org/viewvc?view=revisionrevision=933814

Re: Unit test failing? (was: Re: [VOTE] release for myfaces core 2.0.0)

2010-04-15 Thread Matthias Wessendorf
that's funny :-) What JDK ? 1.5 ? I am on 1.6.x = mat...@woody:~/work/source/Apache/myfaces/trunk$ mvn -v Apache Maven 2.2.1 (r801777; 2009-08-06 21:16:01+0200) Java version: 1.6.0_13 Java home: /java/jdk1.6.0_13/jre Default locale: en_US, platform encoding: UTF-8 OS name: linux version:

Re: svn commit: r934048 - in /myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/jsp: FaceletsOnlyException.java JspViewDeclarationLanguage.java

2010-04-15 Thread Jakob Korherr
No I cannot, because then its message won't be displayed by the ExceptionHandler, because the ExceptionHandler extracts the Exception until it finds the first non-FacesException and then it handles this one. Thus if I would make it a FacesException, the message will be lost. This was the reason I

Re: svn commit: r934048 - in /myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/jsp: FaceletsOnlyException.java JspViewDeclarationLanguage.java

2010-04-15 Thread Matthias Wessendorf
with a delay of 13 hours, it made it. Some gave approval, I guess (it may ended up in the moderation queue) -M On Wed, Apr 14, 2010 at 8:09 PM, Jakob Korherr jak...@apache.org wrote: No I cannot, because then its message won't be displayed by the ExceptionHandler, because the ExceptionHandler

Re: Unit test failing? (was: Re: [VOTE] release for myfaces core 2.0.0)

2010-04-15 Thread Jan-Kees van Andel
I just runned the build on Windows Vista x64: D:\dev\work\myfaces2\core_2_0_0mvn --version Maven version: 2.0.10 Java version: 1.6.0_14 OS name: windows vista version: 6.0 arch: amd64 Family: windows The tests worked fine. @Matthias: Can you see which test method is causing the issue and which

Re: Unit test failing? (was: Re: [VOTE] release for myfaces core 2.0.0)

2010-04-15 Thread Werner Punz
I can reproduce the problem here in OSX, the JDK version might be the problem here, I am on Java6 here. Werner Am 15.04.10 08:55, schrieb Leonardo Uribe: Hi In my machine works fine. I compiled sources on both Linux and Windows. regards, Leonardo Uribe 2010/4/15 Matthias Wessendorf

Re: Unit test failing? (was: Re: [VOTE] release for myfaces core 2.0.0)

2010-04-15 Thread Matthias Wessendorf
Hey Jan, these two new methods: http://svn.apache.org/viewvc?view=revisionrevision=933814 http://svn.apache.org/viewvc?view=revisionrevision=933812 On Thu, Apr 15, 2010 at 9:22 AM, Jan-Kees van Andel jankeesvanan...@gmail.com wrote: I just runned the build on Windows Vista x64:

Re: Unit test failing? (was: Re: [VOTE] release for myfaces core 2.0.0)

2010-04-15 Thread Werner Punz
Ok here is some additional information: testsuite failures=2 time=0.037 errors=0 skipped=0 tests=6 name=org.apache.myfaces.renderkit.html.HtmlTextRendererTest properties property name=java.runtime.name value=Java(TM) SE Runtime Environment/ property name=sun.boot.library.path

[jira] Updated: (TRINIDAD-1785) Table and TreeTable selector links customization

2010-04-15 Thread Catalin Kormos (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Catalin Kormos updated TRINIDAD-1785: - Status: Resolved (was: Patch Available) Fix Version/s: 1.2.14-core

Re: Unit test failing? (was: Re: [VOTE] release for myfaces core 2.0.0)

2010-04-15 Thread Jan-Kees van Andel
Hrm, maybe an encoding issue? Also ran the tests from IntelliJ. Worked fine too... /JK 2010/4/15 Werner Punz werner.p...@gmail.com Ok here is some additional information: testsuite failures=2 time=0.037 errors=0 skipped=0 tests=6 name=org.apache.myfaces.renderkit.html.HtmlTextRendererTest

Re: Unit test failing? (was: Re: [VOTE] release for myfaces core 2.0.0)

2010-04-15 Thread Werner Punz
Ok the affected part is the escape quoting, which had a bug recently which Jakob fixed. inputText.getAttributes().put(onchange, alert('test')); The test checks for following: assertTrue(output.contains(apos;alert(\\apos;test\\apos;)apos;)); but the output string I am getting here is:

Re: Unit test failing? (was: Re: [VOTE] release for myfaces core 2.0.0)

2010-04-15 Thread Werner Punz
Could also be a simple encoding issue which is more likely on a second thought (and as Jan has pointed out), the replaceAll is highly unlikely to be inconsistent in its weird behavior, never encountered that. Anyway as I said I will have a look as soon as it is possible for me (otherwise

impl build fails - Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Ganesh
Sorry for the inconvenience, for me impl build fails on myfaces/current20 (last tried 10 days ago, worked then). It's propably an oversight on my side, but I would have liked to a quick retest with dojofaces for 2.0.0 ... any ideas? [INFO] Compiling 74 source files to

Re: impl build fails - Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Jan-Kees van Andel
I encountered the same error on trunk. You need to change the shared-impl version property to 4.0.1 and then it should work. Regards, Jan-Kees 2010/4/15 Ganesh gan...@j4fry.org Sorry for the inconvenience, for me impl build fails on myfaces/current20 (last tried 10 days ago, worked then).

Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Jan-Kees van Andel
I'm with Werner here. If there's an encoding issue (in the distribution, not the test code) I think doing a release will upset a lot of users. So I'm -1 until we know what causes the test failure... I'm gonna take a look at the failing test, but since I don't have any test failures, I'm not sure

Re: Unit test failing? (was: Re: [VOTE] release for myfaces core 2.0.0)

2010-04-15 Thread Jakob Korherr
On my machine it all works fine. I'm using Mac OS X 10.6.3, Java 1.6.0_17 and Maven 2.2.1. Just a guess in the blue - The changes I applied are on shared. Did you guys remember to rebuild shared before running the test on impl? Regards, Jakob 2010/4/15 Werner Punz werner.p...@gmail.com Could

Re: impl build fails - Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Jakob Korherr
You need to check out shared 4.0.1 in addition to core and run the build on both. The best here is to check out current20. Otherwise you will have old versions of shared which will cause problems like yours. Regards, Jakob 2010/4/15 Jan-Kees van Andel jankeesvanan...@gmail.com I encountered

Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Werner Punz
Ok here it goes officially -1 until we have resolved the issue upon looking at the test, the test is ok and tests correctly, the code causing the test fail is at fault. That should not happen for a release. As I have posted in another mail I currently have to serve a customer if no one else is

Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Jakob Korherr
Again: it works on my machine.. And I guess you may have forgotten to rebuild shared too, because the test tests results of changes on shared. But until this is really sorted out, my vote also is -1. Regards, Jakob 2010/4/15, Werner Punz werner.p...@gmail.com: Ok here it goes officially -1

Re: Unit test failing? (was: Re: [VOTE] release for myfaces core 2.0.0)

2010-04-15 Thread Jan-Kees van Andel
I did some quick debugging, but I don't see any usual suspect. The string replace functions don't use special String methods. It's all hand written and should be platform independent AFAICS. I quess it's an encoding issue or Jakob's dependency suggestion. /JK 2010/4/15 Jakob Korherr

Re: impl build fails - Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Werner Punz
Ok I think I nailed it down, if you checkout current 2.0 you get both, but the test fails, the reason is: MyFaces 2.0 Impl refers to Shared 4.0.1-SNAPSHOT while we already have 4.0.2-SNAPSHOT in the trunk. Now if the 4.0.1-SNAPSHOT is present in the local repo but does not have the fix in the

Re: Unit test failing? (was: Re: [VOTE] release for myfaces core 2.0.0)

2010-04-15 Thread Werner Punz
Hi Jan the problem is in the referenced shared version in the pom of the impl on the trunk! It points to a 4.0.1-SNAPSHOT which some way along the line got the fix in, but if you have an older build lingering around which does not have the fix, the test fails. The problem is it never gets

Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Jan-Kees van Andel
With the issue resolved (the release version is ok AFAICS), I withdraw my -1 and re-vote with a +1. /JK 2010/4/15 Jakob Korherr jakob.korh...@gmail.com Again: it works on my machine.. And I guess you may have forgotten to rebuild shared too, because the test tests results of changes on

Re: impl build fails - Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Jakob Korherr
Many thanks werner for pointing this out! I was sure that the code and the tests I committed were right, so I'm happy we now found the real problem! Regards, Jakob 2010/4/15, Werner Punz werner.p...@gmail.com: Ok I think I nailed it down, if you checkout current 2.0 you get both, but the

Re: impl build fails - Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Werner Punz
Am 15.04.10 11:22, schrieb Jakob Korherr: now found

Re: impl build fails - Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Werner Punz
Actually I had a quick look at the branch for 2.0.0 this one has the version set correctly to 4.0.1, but you cannot really build it from scratch because it refers to test 2.0-beta-3 final and shared 4.0.1 which of course maven cannot fetch yet. Sorry for being so nitpicky, but I have the

Re: impl build fails - Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Matthias Wessendorf
Leo pointed out some other dependencies, you need to build them too... On Thu, Apr 15, 2010 at 10:24 AM, Ganesh gan...@j4fry.org wrote: Sorry for the inconvenience, for me impl build fails on myfaces/current20 (last tried 10 days ago, worked then). It's propably an oversight on my side, but I

Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Matthias Wessendorf
can you post the archived links, so that folks aren't confused ? Thx, Matthias On Thu, Apr 15, 2010 at 11:20 AM, Jan-Kees van Andel jankeesvanan...@gmail.com wrote: With the issue resolved (the release version is ok AFAICS), I withdraw my -1 and re-vote with a +1. /JK 2010/4/15 Jakob

Re: impl build fails - Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Ganesh
Hi, I've updated current20 to rev 934345 and restarted a mvn build, but it still fails (same errors as before). Having already checked in your findings? Best regards, Ganesh Werner Punz schrieb: Actually I had a quick look at the branch for 2.0.0 this one has the version set correctly to

Re: impl build fails - Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Ganesh
I'm building current20, so shared is included in my build. There aren't any other resources I'm aware of. Isn't it rather a mvn issue as Werner pointed out? Matthias Wessendorf schrieb: Leo pointed out some other dependencies, you need to build them too... On Thu, Apr 15, 2010 at 10:24 AM,

Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Jan-Kees van Andel
Sure. Here it is: http://old.nabble.com/Unit-test-failing--%28was%3A-Re%3A--VOTE--release-for-myfaces-core-2.0.0%29-ts28251443.html /JK 2010/4/15 Matthias Wessendorf mat...@apache.org can you post the archived links, so that folks aren't confused ? Thx, Matthias On Thu, Apr 15, 2010 at

Re: impl build fails - Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Werner Punz
Not yet, the reason is I am not sure which shared version we should reference for the impl on the trunk (either 4.0.1 or 4.0.2-SNAPSHOT or we revert our shared version again back to 4.0.1-SNAPSHOT), since Leo is the release manager he has to decide, I guess. Werner Am 15.04.10 11:43,

Re: impl build fails - Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Werner Punz
I think it is the same issue as the failing tests... Werner Am 15.04.10 11:47, schrieb Ganesh: I'm building current20, so shared is included in my build. There aren't any other resources I'm aware of. Isn't it rather a mvn issue as Werner pointed out? Matthias Wessendorf schrieb: Leo

Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Werner Punz
Ok now we have found the problem I am reverting back +1 from my side since it is not a code problem and hence does not affect the generated jars as a bug, but please the final core should be buildable without having to checkout test-beta3 etc... Werner Am 15.04.10 10:34, schrieb Werner

Re: impl build fails - Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Ganesh
Would be cool to have a working build for the release, otherwise it's hard to decide whether it works :-) Werner Punz schrieb: Not yet, the reason is I am not sure which shared version we should reference for the impl on the trunk (either 4.0.1 or 4.0.2-SNAPSHOT or we revert our shared

[jira] Created: (TOBAGO-872) Tab content disappears when tab height is greater than 999px in theme speyside

2010-04-15 Thread Helmut Swaczinna (JIRA)
Tab content disappears when tab height is greater than 999px in theme speyside -- Key: TOBAGO-872 URL: https://issues.apache.org/jira/browse/TOBAGO-872 Project: MyFaces

[jira] Updated: (TOBAGO-872) Tab content disappears when tab height is greater than 999px in theme speyside

2010-04-15 Thread Helmut Swaczinna (JIRA)
[ https://issues.apache.org/jira/browse/TOBAGO-872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Helmut Swaczinna updated TOBAGO-872: Status: Patch Available (was: Open) Tab content disappears when tab height is greater

Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Bruno Aranda
+1 On 15 April 2010 11:00, Werner Punz werner.p...@gmail.com wrote: Ok now we have found the problem I am reverting back +1 from my side since it is not a code problem and hence does not affect the generated jars as a bug, but please the final core should be buildable without having to

Re: impl build fails - Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Matthias Wessendorf
the JARs are in a tmp repo (see Leo's email) ;-) On Thu, Apr 15, 2010 at 12:09 PM, Ganesh gan...@j4fry.org wrote: Would be cool to have a working build for the release, otherwise it's hard to decide whether it works :-) Werner Punz schrieb: Not yet, the reason is I am not sure which shared

Re: impl build fails - Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Werner Punz
I am aware of that, I host my beta files there as well, maybe I have not brought my point through, a new user who wants to checkout the project should be able to do a single mvn clean install and have working jars as an end result, this is currently prevented (hopefully not in the final tag).

Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Gerhard Petracek
+1 regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2010/4/15 Leonardo Uribe lu4...@gmail.com Hi, I was running the needed tasks to get the 2.0.0 release of Apache MyFaces core

[jira] Resolved: (TRINIDAD-744) Update translated message files

2010-04-15 Thread JIRA
[ https://issues.apache.org/jira/browse/TRINIDAD-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Weßendorf resolved TRINIDAD-744. - Fix Version/s: 1.2.14-core 2.0.0.3-core

[jira] Resolved: (TOBAGO-872) Tab content disappears when tab height is greater than 999px in theme speyside

2010-04-15 Thread Bernd Bohmann (JIRA)
[ https://issues.apache.org/jira/browse/TOBAGO-872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bernd Bohmann resolved TOBAGO-872. -- Resolution: Fixed Thanks Helmut Tab content disappears when tab height is greater than 999px

AW: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Mark Struberg
+1 as sidenote: in the tar.gz is a file myfaces-core-assembly-2.0.0.pom which is actually the zip with the sources. So we should somewhen fix the extension of the filename. But that's not blocking the release. LieGrue, strub --- Leonardo Uribe lu4...@gmail.com schrieb am Do, 15.4.2010: Von:

[jira] Created: (TRINIDAD-1787) Combo box with search facility

2010-04-15 Thread Navnath Kumbhar (JIRA)
Combo box with search facility --- Key: TRINIDAD-1787 URL: https://issues.apache.org/jira/browse/TRINIDAD-1787 Project: MyFaces Trinidad Issue Type: New Feature Reporter: Navnath Kumbhar Hi There,

Ext Scripting Quo Vadis

2010-04-15 Thread Werner Punz
Hello I just wanted to know a general opinion here, Ext-Scripting has been in beta stage for a while (while we have tagged one none of us had time to make a full blown release given all our other tasks at hand) But I personally think, since the thing at least for me already works really

Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Leonardo Uribe
Hi 2010/4/15 Mark Struberg strub...@yahoo.de +1 as sidenote: in the tar.gz is a file myfaces-core-assembly-2.0.0.pom which is actually the zip with the sources. So we should somewhen fix the extension of the filename. But that's not blocking the release. Strange, assembly pom.xml does not

Re: impl build fails - Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Leonardo Uribe
Hi The problem is that we don't have nightly builds for shared. I tried to do a manual one today, but people.apache.org snapshot repo returns 403 Forbidden. I would like to have continuum. I try to do manual deploy of shared each time I change the code to prevent that but unfortunately sometimes

Re: impl build fails - Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Werner Punz
Am 15.04.10 21:48, schrieb Leonardo Uribe: Hi The problem is that we don't have nightly builds for shared. I tried to do a manual one today, but people.apache.org http://people.apache.org/ snapshot repo returns 403 Forbidden. I would like to have continuum. I try to do manual deploy of shared

Re: impl build fails - Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Leonardo Uribe
2010/4/15 Werner Punz werner.p...@gmail.com Am 15.04.10 21:48, schrieb Leonardo Uribe: Hi The problem is that we don't have nightly builds for shared. I tried to do a manual one today, but people.apache.org http://people.apache.org/ snapshot repo returns 403 Forbidden. I would like to

Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Grant Smith
+1 On Thu, Apr 15, 2010 at 12:37 PM, Leonardo Uribe lu4...@gmail.com wrote: Hi 2010/4/15 Mark Struberg strub...@yahoo.de +1 as sidenote: in the tar.gz is a file myfaces-core-assembly-2.0.0.pom which is actually the zip with the sources. So we should somewhen fix the extension of the

[jira] Created: (MYFACES-2661) h:link render conversationContext param multiple times

2010-04-15 Thread Leonardo Uribe (JIRA)
h:link render conversationContext param multiple times -- Key: MYFACES-2661 URL: https://issues.apache.org/jira/browse/MYFACES-2661 Project: MyFaces Core Issue Type: Bug

[jira] Resolved: (MYFACES-2661) h:link render conversationContext param multiple times

2010-04-15 Thread Leonardo Uribe (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonardo Uribe resolved MYFACES-2661. - Fix Version/s: 2.0.0 Resolution: Fixed h:link render conversationContext param

Re: [VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Leonardo Uribe
Hi I have regenerated all artifacts to include MYFACES-2661 on the release. I also removed the unwanted artifact on bin assemblies, so we need to vote again (I hope this is the last one but while the vote is open I'll try to find more bugs). regards, Leonardo Uribe 2010/4/15 Grant Smith

[VOTE] release for myfaces core 2.0.0

2010-04-15 Thread Leonardo Uribe
Hi, I was running the needed tasks to get the 2.0.0 release of Apache MyFaces core out. Minor fixes were done since the latest proposed artifacts (MYFACES-2661 and fix bin assembly remove myfaces-core-assembly artifact), so we can continue with the vote. The artifacts passed all TCK tests.

[VOTE] release of myfaces core 2.0.0

2010-04-15 Thread Leonardo Uribe
Hi, I was running the needed tasks to get the 2.0.0 release of Apache MyFaces core out. Minor fixes were done since the latest proposed artifacts (MYFACES-2661 and fix bin assembly remove myfaces-core-assembly artifact), so we can continue with the vote. The artifacts passed all TCK tests.

Re: [VOTE] release of myfaces core 2.0.0

2010-04-15 Thread Leonardo Uribe
+1 2010/4/15 Leonardo Uribe lu4...@gmail.com Hi, I was running the needed tasks to get the 2.0.0 release of Apache MyFaces core out. Minor fixes were done since the latest proposed artifacts (MYFACES-2661 and fix bin assembly remove myfaces-core-assembly artifact), so we can continue