Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/284#discussion_r56507392
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/jwt/JwtService.java
---
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/284#issuecomment-197944422
+1 (with Gilman's last modifications)
Used Gilman's branch to do a contrib check build, reviewed that comments
were addressed and ran through setting up a kerbe
Team,
Ok sooo close. We have 6 tickets remaining.
- Additional functionality/cleanup for SplitText [1]
[status] Still in discussions. Recommend we move this change to 0.7.0.
Solid effort on both code contributor and reviewer side but this is a
tricky one.
- Support Kerberos based authentication
Well deserved! Congrats!
On Mar 16, 2016 13:27, "Joe Percivall"
wrote:
> Congrats Oleg!
> - - - - - -
> Joseph Percivall
> linkedin.com/in/Percivall
> e: joeperciv...@yahoo.com
>
>
>
>
> On Tuesday, March 15, 2016 9:45 PM, Jeremy Dyer wrote:
> Congrats Oleg!
>
> Sent from my iPhone
>
>
> > On M
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/271#discussion_r56508487
--- Diff:
nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextProcessor.java
---
@@ -0,0 +1,392 @@
+
Github user rickysaltzer commented on a diff in the pull request:
https://github.com/apache/nifi/pull/285#discussion_r56421131
--- Diff:
nifi-api/src/main/java/org/apache/nifi/processor/AbstractProcessor.java ---
@@ -27,7 +30,12 @@ public final void onTrigger(final ProcessContext
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/271#discussion_r56446521
--- Diff:
nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextProcessor.java
---
@@ -0,0 +1,392 @@
+
Github user alopresto commented on the pull request:
https://github.com/apache/nifi/pull/284#issuecomment-197610965
I removed all added TODO statements. I created NIFI-1637 to refactor the
duplicated `KerberosUserDetailsService` and
`AlternateKerberosUserDetailsService` to a shared ut
Github user rickysaltzer commented on a diff in the pull request:
https://github.com/apache/nifi/pull/285#discussion_r56420502
--- Diff:
nifi-api/src/main/java/org/apache/nifi/processor/AbstractProcessor.java ---
@@ -27,7 +30,12 @@ public final void onTrigger(final ProcessContext
Github user alopresto commented on the pull request:
https://github.com/apache/nifi/pull/263#issuecomment-198163060
Pulled PR, searched project for the property name, all instances were
updated to `30 secs`. Passes contrib-check. +1.
---
If your project is set up for it, you can rep
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/286
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
+1
On Thu, Mar 17, 2016 at 9:37 PM, Tony Kurc wrote:
> As I was reviewing a pull request, i realized that it actually was a bit
> more mental effort in this instance to review a squashed and rebased set of
> commits than if it was if I could just review the changes in a commit. Does
> anyone obje
+1 Yes please!
Sent from my iPhone
> On Mar 17, 2016, at 9:38 PM, Tony Kurc wrote:
>
> As I was reviewing a pull request, i realized that it actually was a bit
> more mental effort in this instance to review a squashed and rebased set of
> commits than if it was if I could just review the chang
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/271#issuecomment-197621914
Sorry, aside from style check there are still few things I want to do, so
WIP for the next 11 hours ;). But I mainly wanted to see if you can play around
with the sample app
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/271
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/285#discussion_r56419500
--- Diff:
nifi-api/src/main/java/org/apache/nifi/processor/AbstractProcessor.java ---
@@ -27,7 +30,12 @@ public final void onTrigger(final ProcessContext
conte
Github user rickysaltzer commented on the pull request:
https://github.com/apache/nifi/pull/188#issuecomment-198464162
hey @joewitt - not an issue. I haven't actually put this patch into
production yet, but I have a good use case to try it out today / over the
weekend. Let me give th
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/281#discussion_r56410960
--- Diff:
nifi-commons/nifi-hadoop-utils/src/main/java/org/apache/nifi/hadoop/KerberosTicketRenewer.java
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the
Bryan,
all looks ok. I looked into the nifi-home/work/docs folder. There is nothing
but a components folder. Inside there is a folder for my processor:
com.datamelt.nifi.test.TemplateProcessor and inside the folder there is a file
index.html and it contains the code of my additionalDetails.html
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/247
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
Github user mcgilman commented on the pull request:
https://github.com/apache/nifi/pull/286#issuecomment-197997930
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/237
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
Github user rickysaltzer commented on a diff in the pull request:
https://github.com/apache/nifi/pull/285#discussion_r56418891
--- Diff:
nifi-api/src/main/java/org/apache/nifi/processor/AbstractProcessor.java ---
@@ -27,7 +30,12 @@ public final void onTrigger(final ProcessContext
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/283
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
GitHub user olegz opened a pull request:
https://github.com/apache/nifi/pull/283
NIFI-1631 increased timeouts on test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/olegz/nifi NIFI-1631
Alternatively you can review and apply th
Github user mattyb149 closed the pull request at:
https://github.com/apache/nifi/pull/261
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user jskora commented on the pull request:
https://github.com/apache/nifi/pull/252#issuecomment-198408663
@joewitt, the attribute names are created by Tika and seem to be based on
the source file types. The core Tika module was already in the project and the
Tika parsers modul
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/259
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
Github user rickysaltzer commented on the pull request:
https://github.com/apache/nifi/pull/285#issuecomment-197998896
@joewitt posted a new version of the patch. I tested it out on my local
machine and it seems to work as expected. That is, the stacktrace is logged to
the `nifi-app.l
I'm probably on the far end of favoring composibility and processor reuse.
In this case, I would even go one step further and suggest that you're
talking about three separate operations:
1. Split a multi-line CSV input file into individual single line flowfiles.
2. Read columns from a single CSV
Github user mcgilman commented on the pull request:
https://github.com/apache/nifi/pull/284#issuecomment-197860863
Looks really good overall. Found a couple things lingering that I believe
can be removed prior to merging. Additionally, there are a number of
src/test/resources in the n
Github user joewitt commented on the pull request:
https://github.com/apache/nifi/pull/252#issuecomment-198149231
@jskora do the attribute names that come from the media bundles have
anything special to them in terms of how tika handles them or are they purely
as found in the metadata
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/282
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
Github user alopresto commented on a diff in the pull request:
https://github.com/apache/nifi/pull/284#discussion_r56411928
--- Diff:
nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-ui/src/main/java/org/apache/nifi/update/attributes/api/RuleResource.java
---
@@
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/284#discussion_r56511388
--- Diff:
nifi-nar-bundles/nifi-kerberos-iaa-providers-bundle/nifi-kerberos-iaa-providers/src/test/resources/nifi.properties
---
@@ -0,0 +1,185 @@
+# Lice
GitHub user alopresto opened a pull request:
https://github.com/apache/nifi/pull/284
Nifi 1274
Adds support for Kerberos single sign-on via SPNEGO negotiation with
fallback to Kerberos LoginIdentityProvider (similar to LDAP credential login).
Initial PR for review. I am ad
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/285#discussion_r56420228
--- Diff:
nifi-api/src/main/java/org/apache/nifi/processor/AbstractProcessor.java ---
@@ -27,7 +30,12 @@ public final void onTrigger(final ProcessContext
conte
Adam,
thanks again.
I didn't know about the contributors guide - I was always looking in the docs
inside Nifi and there is a reference to the developer guide only.
I will try to make a good processor for velocity first. The next step would
then be to include also freemarker. I will try to keep
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/284#discussion_r56425560
--- Diff:
nifi-nar-bundles/nifi-kerberos-iaa-providers-bundle/nifi-kerberos-iaa-providers/src/main/java/org/apache/nifi/kerberos/KerberosProvider.java
---
@
Devin,
Good stuff. Unless the api call to change the content completes
normally the transformation effectively did not happen. Take a look
at CompressContent [1] for an example.
It reads in the original content and streams out new content. If that
process of transformation fails it routes the
GitHub user trixpan opened a pull request:
https://github.com/apache/nifi/pull/289
NIFI-856 - Implements experimental ListenLumberjack Processor
ListenLumberjack processor should potentially allow NiFi to act as a drop
in replacement
on pipelines using logstash-forwarder and Lo
This sounds pretty cool and definitely think you're both on a good
track design-wise.
On Fri, Mar 18, 2016 at 2:04 PM, Uwe Geercken wrote:
> Adam,
>
> thanks again.
>
> I didn't know about the contributors guide - I was always looking in the docs
> inside Nifi and there is a reference to the dev
Aldrin,
Very cool
On Mar 17, 2016 10:21 PM, "Aldrin Piri" wrote:
> Sounds good to here as well.
>
> Given the increasing number of contributions, which predominantly seem to
> arrive via GitHub PR, I also created NIFI-1615 [1] a little while ago to
> make a GitHub PR template [1]. Would like to
Hello,
my first mailing here. I am a Java developer, using Apache Velocity, Drill,
Tomcat, Ant, Pentaho ETL, MongoDb, Mysql and more and I am very much a data guy.
I have used Nifi for a while now and started yesterday of coding my first
processor. I basically do it to widen my knowledge and l
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/281#issuecomment-198075844
@bbende code looks good, thanks for addressing those few issues. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/263
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
Uwe,
The Developer Guide[1] and Contributor Guide[2] are pretty solid. The
Developer Guide has a section dealing with reading & writing flowfile
attributes. Please check these out, and then if you have any specific
questions, please feel free to reply.
For inclusion in NIFI directly, you'd want
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/285#discussion_r56418107
--- Diff:
nifi-api/src/main/java/org/apache/nifi/processor/AbstractProcessor.java ---
@@ -27,7 +30,12 @@ public final void onTrigger(final ProcessContext
conte
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/280#discussion_r56329206
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/SplitText.java
---
@@ -143,72 +199,
Hello,
my first mailing here. I am a Java developer, using Apache Velocity, Drill,
Tomcat, Ant, Pentaho ETL, MongoDb, Mysql and more and I am very much a data guy.
I have used Nifi for a while now and started yesterday of coding my first
processor. I basically do it to widen my knowledge and
Thank you all!!!
Sent from my iPhone
> On Mar 16, 2016, at 12:03, Joe Skora wrote:
>
> Oleg,
>
> Congratulations, and thanks for all your help, past and future!
>
> Joe
>
> On Wed, Mar 16, 2016 at 10:11 AM, Pierre Villard <
> pierre.villard...@gmail.com> wrote:
>
>> Well deserved! Congrats!
Uwe,
I'll take a look at your code sometime soon. However, just to point you in
the direction, I'd suggest extracting your single line CSV data into
flowfile attributes named as you've demonstrated. i.e. create a processor
which reads each CSV column as a flowfile attribute, using a configured
+1 here as well
My apologies Tony
Sent from my iPhone
> On Mar 17, 2016, at 21:42, Joe Witt wrote:
>
> +1
>
>> On Thu, Mar 17, 2016 at 9:37 PM, Tony Kurc wrote:
>> As I was reviewing a pull request, i realized that it actually was a bit
>> more mental effort in this instance to review a squas
Github user PuspenduBanerjee commented on the pull request:
https://github.com/apache/nifi/pull/271#issuecomment-198245248
@olegz Sorry for the delay in response, I shall look into that during next
week.
---
If your project is set up for it, you can reply to this email and have your
Github user alopresto commented on a diff in the pull request:
https://github.com/apache/nifi/pull/284#discussion_r56436309
--- Diff:
nifi-nar-bundles/nifi-kerberos-iaa-providers-bundle/nifi-kerberos-iaa-providers/src/main/java/org/apache/nifi/kerberos/KerberosProvider.java
---
@@
Hello Paresh,
Just to be sure I understand your use-case correctly, you want to transfer
FlowFiles from one NiFi instance to a NiFi cluster using site to site and you
want to have the FlowFiles go to a certain node in the cluster based on an
application specific strategy.
I have not heard any
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/284#discussion_r56496662
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/NiFiAuthenticationFilter.java
Github user jskora commented on the pull request:
https://github.com/apache/nifi/pull/252#issuecomment-198427593
I don't love all the attribute names, I might have come up with a cleaner
taxonomy myself. But, letting Tika handle it leverages the work done on
another active Apache pro
Github user jskora commented on the pull request:
https://github.com/apache/nifi/pull/280#issuecomment-197388774
I think the issues are all covered now and tests have been expanded to get
all critical logic and edge cases.
---
If your project is set up for it, you can reply to this e
Github user joewitt commented on the pull request:
https://github.com/apache/nifi/pull/261#issuecomment-198147766
@mattyb149 believe this PR is closed but apparently the commit message
didn't reflect it. Can you please close it.
---
If your project is set up for it, you can reply to
Github user mattyb149 commented on the pull request:
https://github.com/apache/nifi/pull/263#issuecomment-198165221
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/285#discussion_r56420919
--- Diff:
nifi-api/src/main/java/org/apache/nifi/processor/AbstractProcessor.java ---
@@ -27,7 +30,12 @@ public final void onTrigger(final ProcessContext
conte
Github user joewitt commented on the pull request:
https://github.com/apache/nifi/pull/253#issuecomment-198146996
Hello @lordjc This ended up being merged and incorporated but the 'This
closes #253' was not added to the commit log so the close hook didn't fire.
Can you please close t
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/282#discussion_r56345659
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/GetKafka.java
---
@@ -297,6 +320,14 @@ protec
Hi Team,
I would like to add processors for rabbitmq in NIFI. Please provide the steps
to do it.
Regards,
Sourav Gulati
NOTE: This message may contain information that is confidential, proprietary,
privileged or otherwise protected by law. The message i
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/284#discussion_r56410434
--- Diff:
nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-ui/src/main/java/org/apache/nifi/update/attributes/api/RuleResource.java
---
@
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/286
NIFI-901: Fixed unit test to verify IP address of Cassandra contact point
The test was checking the IP against getHostName(), but if there were a
DNS/hosts entry for that IP, the test would fail. Th
As I was reviewing a pull request, i realized that it actually was a bit
more mental effort in this instance to review a squashed and rebased set of
commits than if it was if I could just review the changes in a commit. Does
anyone object to me adding in the contributors guide something to the
exte
Github user markobean commented on a diff in the pull request:
https://github.com/apache/nifi/pull/280#discussion_r56328470
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/SplitText.java
---
@@ -143,72 +199
Adam,
interesting and I agree. that sounds very good.
can you give me short tip of how to access attributes from code?
once I have something usable or for testing where would I publish it? just on
my github site? or is there a place for sharing?
greetings
Uwe
Gesendet: Freitag, 18. März
Uwe,
No, the index.html is generated for you. additionalDetails.html is your
responsibility only if you feel like the generated index.html doesn't fully
describe your processor.
I would guess 80% of the included processors do not have
additionalDetails.html. If you haven't browsed here [1]
Github user joewitt commented on the pull request:
https://github.com/apache/nifi/pull/188#issuecomment-198151066
@rickysaltzer hey there. I just realized that this does have a commit
against it post review commentary. My apologies for not engaging. Do you
happen to be using this c
Uwe,
While my usage is surely unrelated to yours, I do exactly this thing
which is to process a CSV producing as many new output flowfiles as
there are lines and the names of these flowfiles are, in my case,
conveniently chosen based on the significant content of each line (so no
problem comi
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/280#discussion_r56327650
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/SplitText.java
---
@@ -143,72 +199,
Github user rickysaltzer commented on the pull request:
https://github.com/apache/nifi/pull/282#issuecomment-197505410
+1 - tested and verified to work with 0.8.0 and 0.9.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user mattyb149 commented on the pull request:
https://github.com/apache/nifi/pull/273#issuecomment-198202258
I merged this but forgot to close the PR, @jfrazee can you do the honors?
Thanks for the contrib!
---
If your project is set up for it, you can reply to this em
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/271#issuecomment-198134497
@olegz - there are a bunch of trailing whitespace and whitespace on blank
lines in the xml and properties files. checkstyle doesn't complain as it checks
the java code only
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/213
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/261#discussion_r56380052
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
---
@@ -0,
Adam,
ok. I got it. This way one can use any flowfile attributes and merge them with
the template.
I have worked all day on the two processors and it does work - very cool. Will
have to do more error testing though.
So the SplitToAttribute processor does the splitting of the flowfile content.
GitHub user trixpan opened a pull request:
https://github.com/apache/nifi/pull/290
NIFI-856 Implements experimental ListenLumberjack Processor
ListenLumberjack processor should allow NiFi to act as a drop in
replacement on pipelines
using logstash-forwarder and Logstash's Lumb
Oleg,
Congratulations, and thanks for all your help, past and future!
Joe
On Wed, Mar 16, 2016 at 10:11 AM, Pierre Villard <
pierre.villard...@gmail.com> wrote:
> Well deserved! Congrats!
> On Mar 16, 2016 13:27, "Joe Percivall"
> wrote:
>
> > Congrats Oleg!
> > - - - - - -
> > Joseph Perciva
Github user mattyb149 commented on the pull request:
https://github.com/apache/nifi/pull/273#issuecomment-198185301
reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/271#discussion_r56445529
--- Diff:
nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextProcessor.java
---
@@ -0,0 +1,392 @@
+
Joe,
For our use case we want to be able to do the following.
1. In certain paths we want to be able to send the same FlowFiles to all
nodes of a remote cluster ( broadcast use case )
2. In another use case send it to one of the nodes of the remote cluster (
regular RPG use case ).
What we are w
GitHub user rickysaltzer opened a pull request:
https://github.com/apache/nifi/pull/285
NIFI-1636: Print Stacktrace When Unepected OnTrigger Exception Caught
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rickysaltzer/nifi NIFI-
GitHub user trkurc opened a pull request:
https://github.com/apache/nifi/pull/291
NIFI-1651 unit tests work on windows. removed contributor name/package from
data and schema
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/trkurc
Github user pvillard31 commented on the pull request:
https://github.com/apache/nifi/pull/272#issuecomment-198776846
Should be OK now :
- Added body property
- Reverted default Content-Type and original unit tests
- Authorized no incoming connection with POST/PUT
- Adde
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/281#discussion_r56520899
--- Diff:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/test/resources/core-site.xml
---
@@ -1,4 +1,5 @@
+
--- End diff --
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/284#discussion_r56496561
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/kerberos/KerberosAuthenticati
Github user jfrazee closed the pull request at:
https://github.com/apache/nifi/pull/273
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/271#issuecomment-198171253
@olegz, I think @joewitt is still looking, but I think the code looks good,
I put it through the paces using several applications. I'm +1
---
If your project is set up for
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/281#discussion_r56411887
--- Diff:
nifi-commons/nifi-hadoop-utils/src/main/java/org/apache/nifi/hadoop/SecurityUtil.java
---
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache S
Dan,
but maybe I have a wrong understanding: do I have to create an index.html file?
Currently I have only created an additionalDetails.html file.
I will also try to reduce the html code to a minimum and see if it is a problem
with my code.
Bye,
Uwe
> Gesendet: Freitag, 18. März 2016 um 19:0
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/271#issuecomment-198126926
Also, the Camel example was added for testing here
https://github.com/olegz/si-demo .@PuspenduBanerjee if/when you get a chance
please check it out.
---
If your project i
Github user apiri commented on the pull request:
https://github.com/apache/nifi/pull/213#issuecomment-197294536
@mans2singh Looks great, thanks for getting those changes together and the
contribution. I'll be merging this into master shortly.
---
If your project is set up for it, yo
Sounds good to here as well.
Given the increasing number of contributions, which predominantly seem to
arrive via GitHub PR, I also created NIFI-1615 [1] a little while ago to
make a GitHub PR template [1]. Would like to distill the contributor guide
down into a few easy steps for folks to check
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/271#discussion_r56446675
--- Diff:
nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextProcessor.java
---
@@ -0,0 +1,392 @@
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/271#issuecomment-197617908
@olegz : checkstyle fails when I build with your latest commit
``
[INFO] --- maven-checkstyle-plugin:2.15:check (check-style) @
nifi-spring-processors ---
[WARNI
Uwe,
When I asked this question a few days ago. What you're doing is rolling
your whole processor into a NAR instead of JARing it first, then rolling
the JAR into a NAR. This doesn't work and still won't work when they fix
it (not just for the reason of /additional//Details.html/ because
ther
1 - 100 of 127 matches
Mail list logo
