Re: Eclipse: Launch External Tool does not save dirty editors regardless of preference setting

2010-03-12 Thread Jacques Le Roux
Actually I did not check, 3.5.2 is available Jacques From: Jacques Le Roux jacques.le.r...@les7arts.com I really do not like this one https://bugs.eclipse.org/bugs/show_bug.cgi?id=282581 But not enough to run all issues with building my own Eclipse (did not try though), I will wait 3.5.2 :/

[jira] Closed: (OFBIZ-3440) Calculation of promotions and price rules should support multi-level GROUP_ROLLUP

2010-03-12 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-3440. -- Resolution: Fixed Fix Version/s: SVN trunk Hi Geir, Your (slightly modified) patch is

Re: add story field also on custRequest header

2010-03-12 Thread Bilgin Ibryam
Scott Gray wrote: Hi Hans, I would recommend using the custRequestItem for the story, the implementation can be simple enough by using a service to create the header and item in a single call and a view entity could could them back to you as a single record. Conceptually what you really

Re: Eclipse: Launch External Tool does not save dirty editors regardless of preference setting

2010-03-12 Thread Jacques Le Roux
Mmm... weird this is not by default, yoy may even automatically update using http://download.eclipse.org/eclipse/updates/3.5 (though I did to 3.5.2 and it did no fix the bug below :/) see also http://wiki.eclipse.org/Eclipse_Project_Update_Sites Jacques From: Jacques Le Roux

Re: add story field also on custRequest header

2010-03-12 Thread Jacques Le Roux
Anyway a sole -1 is enough for reverting code without explanations Needs 3 +1 (and more + than -) for a release. These are Apache rules (inherited from HTTPD project) as it's well explained in the release management document Bruno gave a link) Jacques From: Bilgin Ibryam bibr...@gmail.com

Re: add story field also on custRequest header

2010-03-12 Thread Christian Geisert
I think it makes sense to have a story/text for the header (for all items), but why not using CustRequestNote for this? Christian Scott Gray schrieb: Hi Hans, I would recommend using the custRequestItem for the story, the implementation can be simple enough by using a service to create the

Re: add story field also on custRequest header

2010-03-12 Thread Christian Geisert
Jacques Le Roux schrieb: Anyway a sole -1 is enough for reverting code without explanations Wrong, a veto on code modification without an explanation is invalid! See http://www.apache.org/foundation/voting.html But this shouldn't really be used all the time, it makes a lot more sense to

Re: svn commit: r921274 - /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartItem.java

2010-03-12 Thread Awdesh Parihar
Hello Scott, Following the previous condition; ((this.attributes != null attributes != null) ((this.attributes.size() != attributes.size()) || !(this.attributes.equals(attributes and the information added by Adam, we can see the why these changes needed. The

Re: add story field also on custRequest header

2010-03-12 Thread Jacques Le Roux
From: Christian Geisert christian.geis...@isu-gmbh.de Jacques Le Roux schrieb: Anyway a sole -1 is enough for reverting code without explanations Wrong, a veto on code modification without an explanation is invalid! See http://www.apache.org/foundation/voting.html Yes indeed, thanks for the

Re: add story field also on custRequest header

2010-03-12 Thread Scott Gray
Why would you even bring this up here? No one is talking about commits and definitely no one is talking about reverts. Regards Scott On 12/03/2010, at 2:53 AM, Jacques Le Roux wrote: Anyway a sole -1 is enough for reverting code without explanations Needs 3 +1 (and more + than -) for a

new customerservice component was: add story field also on custRequest header

2010-03-12 Thread Hans Bakker
Hi Bruno yes that was my first intention to integrate it completely with the project manager, look at the 'requests' button there. However i had to change my mind There are two areas: 1. ticket(request) management and the communicationEvents around it 2.

Re: add story field also on custRequest header

2010-03-12 Thread Hans Bakker
Hi Christian, nice to have you back! Sure we can use that too, but the note is meant for some extra info? The main story should be as close to the request as possible. Initially the request was meant to have information at some kind of product list therefore the items so it could be easy

Re: add story field also on custRequest header

2010-03-12 Thread Jacques Le Roux
Simply because I read that in the document Bruno sent us and I was not aware of all details. So I though maybe some other commitets were not and a summary (on this subject) could not hurt. Jacques From: Scott Gray scott.g...@hotwaxmedia.com Why would you even bring this up here? No one is

[jira] Created: (OFBIZ-3553) Send Email link from /humanres/control/EmployeeProfile does not work

2010-03-12 Thread Eric Lofstad (JIRA)
Send Email link from /humanres/control/EmployeeProfile does not work Key: OFBIZ-3553 URL: https://issues.apache.org/jira/browse/OFBIZ-3553 Project: OFBiz Issue Type: Bug

Re: add story field also on custRequest header

2010-03-12 Thread Scott Gray
It just seems rude to me, Hans comes to the list with a discussion, which is a good thing, and people start talking about reverts? Regards Scott On 12/03/2010, at 7:33 AM, Jacques Le Roux wrote: Simply because I read that in the document Bruno sent us and I was not aware of all details. So

Re: svn commit: r922177 - in /ofbiz/trunk/applications: order/src/org/ofbiz/order/shoppingcart/product/ProductPromoWorker.java product/src/org/ofbiz/product/price/PriceServices.java

2010-03-12 Thread Adam Heath
jler...@apache.org wrote: Author: jleroux Date: Fri Mar 12 08:27:42 2010 New Revision: 922177 URL: http://svn.apache.org/viewvc?rev=922177view=rev Log: A slightly modified patch from Geir Ove Grønmo Calculation of promotions and price rules should support multi-level GROUP_ROLLUP

Re: add story field also on custRequest header

2010-03-12 Thread Jacques Le Roux
Ha It was not directed to Hans at all. Just that I thought it could be interesting for everyone. To be clear, I have anything against Hans. He is here for a longer time than me, knows certainly more things than me on OFBiz and his contributions, past and future, are very important. I would

Re: new customerservice component was: add story field also on custRequest header

2010-03-12 Thread Erwan de FERRIERES
Le 12/03/2010 15:28, Hans Bakker a écrit : Hi Bruno yes that was my first intention to integrate it completely with the Hi Hans, we are planning on doing such thing, and merging our forces may create a nice piece of OFBiz contribution ! On the entity part, what have you planned ? using

[jira] Created: (OFBIZ-3554) Delegator removeByXXX do not trigger remove ECA

2010-03-12 Thread Wickersheimer Jeremy (JIRA)
Delegator removeByXXX do not trigger remove ECA --- Key: OFBIZ-3554 URL: https://issues.apache.org/jira/browse/OFBIZ-3554 Project: OFBiz Issue Type: Bug Components: framework Affects

Re: svn commit: r905876 [1/7] - in /ofbiz/trunk: applications/commonext/documents/ specialpurpose/ specialpurpose/ebay/ specialpurpose/ebay/config/ specialpurpose/ebay/data/ specialpurpose/ebay/data

2010-03-12 Thread Ashish Vijaywargiya
Hello Tim, I have already sent my comments before few days: (Sending here once again for your reference) - Hello Hans | Tim, Here are major points for your ready reference that are supported/ present in the eBay component before the introduction of ebaystore component:

Re: svn commit: r905876 [1/7] - in /ofbiz/trunk: applications/commonext/documents/ specialpurpose/ specialpurpose/ebay/ specialpurpose/ebay/config/ specialpurpose/ebay/data/ specialpurpose/ebay/data

2010-03-12 Thread Ashish Vijaywargiya
Hello Tim, I have already sent my comments before few days: (Sending here once again for your reference) - Hello Hans | Tim, Here are major points for your ready reference that are supported/ present in the eBay component before the introduction of ebaystore component:

[jira] Commented: (OFBIZ-3026) Datafile does not catch lack of delimiter if at end of line.

2010-03-12 Thread BJ Freeman (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12844643#action_12844643 ] BJ Freeman commented on OFBIZ-3026: --- to be able to patch I can only provide to release

ShoppingCart has very bad locking

2010-03-12 Thread Adam Heath
Search for synchronized in ShoppingCart. You'll fine a couple of spots that lock on cartLines, a few that lock in the class instance itself. But then no other hits. However, tons of internal variables all need to be kept self-consistent with each other, so locking against just one or the other

[jira] Commented: (OFBIZ-1222) Improvements while creating invoice for order

2010-03-12 Thread Bob Morley (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12844718#action_12844718 ] Bob Morley commented on OFBIZ-1222: --- I know this one is pretty old - but we ran into this

Re: ShoppingCart has very bad locking

2010-03-12 Thread Adrian Crum
--- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Search for synchronized in ShoppingCart.  You'll fine a couple of spots that lock on cartLines, a few that lock in the class instance itself.  But then no other hits. However, tons of internal variables all need to be kept

Re: ShoppingCart has very bad locking

2010-03-12 Thread Adam Heath
Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Search for synchronized in ShoppingCart. You'll fine a couple of spots that lock on cartLines, a few that lock in the class instance itself. But then no other hits. However, tons of internal variables all need

Re: ShoppingCart has very bad locking

2010-03-12 Thread Adrian Crum
--- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Search for synchronized in ShoppingCart.  You'll fine a couple of spots that lock on cartLines, a few that lock in the class instance itself. 

Re: ShoppingCart has very bad locking

2010-03-12 Thread Adam Heath
Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Search for synchronized in ShoppingCart. You'll fine a couple of spots that lock on cartLines, a few that lock in the class

Re: ShoppingCart has very bad locking

2010-03-12 Thread Adrian Crum
--- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Search for synchronized in ShoppingCart.  You'll fine a couple of

Re: ShoppingCart has very bad locking

2010-03-12 Thread Adam Heath
Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Search for synchronized in ShoppingCart. You'll fine a couple of spots that lock on cartLines, a few that lock in the class

Re: ShoppingCart has very bad locking

2010-03-12 Thread Adrian Crum
--- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Search for synchronized in ShoppingCart.  You'll fine a couple of

Re: ShoppingCart has very bad locking

2010-03-12 Thread Adrian Crum
--- On Fri, 3/12/10, Adrian Crum adrian.c...@yahoo.com wrote: Consistent random foreign key violations. Two records would get the same sequence number. Random in that different entities would be affected each time, and consistent in that it happens nearly every time. Try running five or

Re: ShoppingCart has very bad locking

2010-03-12 Thread Adam Heath
Adrian Crum wrote: --- On Fri, 3/12/10, Adrian Crum adrian.c...@yahoo.com wrote: Consistent random foreign key violations. Two records would get the same sequence number. Random in that different entities would be affected each time, and consistent in that it happens nearly every time. Try

production-run-tests.testProductionRunDateChange

2010-03-12 Thread Adam Heath
ah ha! This is just excellent. Has anyone tried running the test suite right now? In the US? The above test fails, because the start date is now, but the end date is in the future *past* when daylight savings time takes place. So the interval is off by one hour, and the assertion fails. Does

Re: production-run-tests.testProductionRunDateChange

2010-03-12 Thread Adrian Crum
--- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: ah ha! This is just excellent. Has anyone tried running the test suite right now?  In the US? The above test fails, because the start date is now, but the end date is in the future *past* when daylight savings time takes

Re: production-run-tests.testProductionRunDateChange

2010-03-12 Thread Adam Heath
Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: ah ha! This is just excellent. Has anyone tried running the test suite right now? In the US? The above test fails, because the start date is now, but the end date is in the future *past* when daylight

Re: production-run-tests.testProductionRunDateChange

2010-03-12 Thread Adrian Crum
--- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: ah ha! This is just excellent. Has anyone tried running the test suite right now?  In the US? The above test fails, because the start date

Re: production-run-tests.testProductionRunDateChange

2010-03-12 Thread Adam Heath
Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: ah ha! This is just excellent. Has anyone tried running the test suite right now? In the US? The above test fails, because the

Re: production-run-tests.testProductionRunDateChange

2010-03-12 Thread Adrian Crum
--- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: ah ha! This is just excellent. Has anyone tried running the

Re: production-run-tests.testProductionRunDateChange

2010-03-12 Thread Adam Heath
Adam Heath wrote: Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: ah ha! This is just excellent. Has anyone tried running the test suite right now? In the US? The above test

Re: production-run-tests.testProductionRunDateChange

2010-03-12 Thread Adam Heath
Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: ah ha! This is just excellent. Has anyone tried

Re: production-run-tests.testProductionRunDateChange

2010-03-12 Thread Adrian Crum
--- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Adam Heath wrote: Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: Adrian Crum wrote: --- On Fri, 3/12/10, Adam Heath doo...@brainfood.com wrote: ah ha! This is just excellent. Has

[jira] Commented: (OFBIZ-3026) Datafile does not catch lack of delimiter if at end of line.

2010-03-12 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12844819#action_12844819 ] Jacques Le Roux commented on OFBIZ-3026: Yes, we can try that... I don't expect

[jira] Reopened: (OFBIZ-3026) Datafile does not catch lack of delimiter if at end of line.

2010-03-12 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-3026: Datafile does not catch lack of delimiter if at end of line.