Re: mainDecoratorLocation was Include of controllers

2007-12-19 Thread Jonathon -- Improov
has some meaning about associated party variables or contexts. - Original Message From: BJ Freeman <[EMAIL PROTECTED]> To: dev@ofbiz.apache.org Sent: Monday, December 17, 2007 4:57:18 PM Subject: Re: mainDecoratorLocation was Include of controllers good point. #1 so I will not put

Re: mainDecoratorLocation was Include of controllers

2007-12-19 Thread Jonathon -- Improov
L PROTECTED]> To: dev@ofbiz.apache.org Sent: Monday, December 17, 2007 3:27:53 PM Subject: Re: mainDecoratorLocation was Include of controllers Why couldn't you supply your own custom mainDecorator? What do the base mainDecorators provide that you can't in your custom app? Scott On 1

mainDecoratorLocation is broken and does not work as designed. was mainDecoratorLocation was Include of controllers

2007-12-17 Thread BJ Freeman
t; Sent: Monday, December 17, 2007 6:39:46 PM > Subject: Re: mainDecoratorLocation was Include of controllers > > > ah gee just found a flaw > the @page value into the context > does that go into the products or application controller. > will that create a backward compatibility p

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread Chris Howe
more specifically... RequestHandler.java after line 608 add: req.setAttribute("_NEXT_PAGE", nextPage); - Original Message From: Chris Howe <[EMAIL PROTECTED]> To: dev@ofbiz.apache.org Sent: Monday, December 17, 2007 6:44:43 PM Subject: Re: mainDecoratorLocation was Includ

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread BJ Freeman
that it puts > that value of page into the context. Then your decorator can pull it out. > > - Original Message > From: BJ Freeman <[EMAIL PROTECTED]> > To: dev@ofbiz.apache.org > Sent: Monday, December 17, 2007 6:39:46 PM > Subject: Re: mainDecoratorLocation wa

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread Chris Howe
ent: Monday, December 17, 2007 6:39:46 PM Subject: Re: mainDecoratorLocation was Include of controllers ah gee just found a flaw the @page value into the context does that go into the products or application controller. will that create a backward compatibility problem? Chris Howe sent the followi

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread BJ Freeman
; - Original Message > From: Chris Howe <[EMAIL PROTECTED]> > To: dev@ofbiz.apache.org > Sent: Monday, December 17, 2007 6:16:14 PM > Subject: Re: mainDecoratorLocation was Include of controllers > > > You'll need to get put the @page value into the conte

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread BJ Freeman
M: > sorry, that should be page.startsWith("component://...") > - Original Message > From: Chris Howe <[EMAIL PROTECTED]> > To: dev@ofbiz.apache.org > Sent: Monday, December 17, 2007 6:16:14 PM > Subject: Re: mainDecoratorLocation was Include of controllers &g

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread Chris Howe
sorry, that should be page.startsWith("component://...") - Original Message From: Chris Howe <[EMAIL PROTECTED]> To: dev@ofbiz.apache.org Sent: Monday, December 17, 2007 6:16:14 PM Subject: Re: mainDecoratorLocation was Include of controllers You'll need to get put

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread BJ Freeman
> > you will have > > etc > > - Original Message > From: BJ Freeman <[EMAIL PROTECTED]> > To: dev@ofbiz.apache.org > Sent: Monday, December 17, 2007 6:07:08 PM > Subject: Re: mainDecoratorLocation was Include of controllers > > > here is an exm

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread BJ Freeman
wn decorator in /myapp/widget/CommonScreens.xml >>>> >>>> create a main-decorator and a global decorator and use modify to >>>> your heart's content >>>> >>>> - Original Message >>>> From: BJ Freeman <[EMAIL PROTEC

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread BJ Freeman
f overhead in maintainence instead of just using the partymgr as is. or like > > - Original Message > From: BJ Freeman <[EMAIL PROTECTED]> > To: dev@ofbiz.apache.org > Sent: Monday, December 17, 2007 5:59:58 PM > Subject: Re: mainDecoratorLocation was Include of

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread Chris Howe
uName="Product"; etc parameters.put("applicationMenuName", applicationMenuName); then in your main-decorator, instead of having you will have etc - Original Message From: BJ Freeman <[EMAIL PROTECTED]> To: dev@ofbiz.apache.org Sent: Monday, December 17, 2007 6:07:08 PM

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread Adrian Crum
TED]> To: dev@ofbiz.apache.org Sent: Monday, December 17, 2007 5:33:01 PM Subject: Re: mainDecoratorLocation was Include of controllers so what is the approach that works? Chris Howe sent the following on 12/17/2007 3:26 PM: That's what I wasn't understanding. Your approach fails

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread Adrian Crum
BJ Freeman wrote: Oh.. well I did. and got all sorts of errors because I has not included what that application expected for its decorator. and I could not find a way to use the app specific information for each app in my main-decorator. which started me down the road to app-mainDecoratorLocati

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread Chris Howe
BJ Freeman <[EMAIL PROTECTED]> To: dev@ofbiz.apache.org Sent: Monday, December 17, 2007 5:59:58 PM Subject: Re: mainDecoratorLocation was Include of controllers Oh.. well I did. and got all sorts of errors because I has not included what that application expected for its decorator. and I

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread BJ Freeman
D]> >> To: dev@ofbiz.apache.org >> Sent: Monday, December 17, 2007 5:33:01 PM >> Subject: Re: mainDecoratorLocation was Include of controllers >> >> >> so what is the approach that works? >> >> >> Chris Howe sent the following on 12/17/2007 3:2

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread BJ Freeman
ssage > From: BJ Freeman <[EMAIL PROTECTED]> > To: dev@ofbiz.apache.org > Sent: Monday, December 17, 2007 5:33:01 PM > Subject: Re: mainDecoratorLocation was Include of controllers > > > so what is the approach that works? > > > Chris Howe sent the following on

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread Chris Howe
ent: Monday, December 17, 2007 5:33:01 PM Subject: Re: mainDecoratorLocation was Include of controllers so what is the approach that works? Chris Howe sent the following on 12/17/2007 3:26 PM: > That's what I wasn't understanding. Your approach fails with that problem. The approac

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread Chris Howe
Make your own decorator - Original Message From: BJ Freeman <[EMAIL PROTECTED]> To: dev@ofbiz.apache.org Sent: Monday, December 17, 2007 5:33:01 PM Subject: Re: mainDecoratorLocation was Include of controllers so what is the approach that works? Chris Howe sent the following

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread BJ Freeman
hat both approaches fail. > > - Original Message > From: BJ Freeman <[EMAIL PROTECTED]> > To: dev@ofbiz.apache.org > Sent: Monday, December 17, 2007 5:21:55 PM > Subject: Re: mainDecoratorLocation was Include of controllers > > > been through this umtee

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread Chris Howe
ofbiz.apache.org Sent: Monday, December 17, 2007 5:21:55 PM Subject: Re: mainDecoratorLocation was Include of controllers been through this umteem times. sigh this is not the case for ftl files only widgets. I access a screen widget in x-app from my custom app. that screen has a decorator which eve

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread BJ Freeman
ent: Monday, December 17, 2007 4:57:18 PM > Subject: Re: mainDecoratorLocation was Include of controllers > > > good point. #1 > so I will not put this to sleep and do it for my releases until, as you > say it become a problem > > However the use of mainDecoratorLocation beyond an app s

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread Chris Howe
- From: BJ Freeman <[EMAIL PROTECTED]> To: dev@ofbiz.apache.org Sent: Monday, December 17, 2007 4:57:18 PM Subject: Re: mainDecoratorLocation was Include of controllers good point. #1 so I will not put this to sleep and do it for my releases until, as you say it become a problem Ho

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread BJ Freeman
rom: BJ Freeman <[EMAIL PROTECTED]> > To: dev@ofbiz.apache.org > Sent: Monday, December 17, 2007 4:27:19 PM > Subject: Re: mainDecoratorLocation was Include of controllers > > > It seems a lot of work for simple solution > how about app-mainDecoratorLocation > then if so

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread Chris Howe
processing the context parameter. I could certainly be wrong. I'm no expert on such things. - Original Message From: BJ Freeman <[EMAIL PROTECTED]> To: dev@ofbiz.apache.org Sent: Monday, December 17, 2007 4:27:19 PM Subject: Re: mainDecoratorLocation was Include of controller

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread BJ Freeman
ay, December 17, 2007 3:57:53 PM > Subject: Re: mainDecoratorLocation was Include of controllers > > > If all BJ wants to do is display an existing screen with its existing > main decorator, then he can > just use the screen's URL. > > Chris Howe wrote: > >

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread Chris Howe
{location}) > 3) render the following screen > > > > > > > > > > > > > > > - Original Message > From: Scott Gray <[EMAIL PROTECTED]> > To: dev@ofbiz.apache.org > Sent: Monday, December 17, 2007

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread Adrian Crum
ollowing screen - Original Message From: Scott Gray <[EMAIL PROTECTED]> To: dev@ofbiz.apache.org Sent: Monday, December 17, 2007 3:27:53 PM Subject: Re: mainDecoratorLocation was Include of controllers Why couldn't you supply your own custom mainDecorator? What d

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread BJ Freeman
did you use two different apps from your app? yes it will work for one app. Adrian Crum sent the following on 12/17/2007 1:49 PM: > The best way to prove it is to code it according to my suggestion and > test it against the original problem you stated in this thread. It > works. How do I know tha

Re: mainDecoratorLocation change to app-mainDecoratorLocation was Include of controllers

2007-12-17 Thread BJ Freeman
Ok so if we just change mainDecoratorLocation to party-mainDecoratorLocation everything will work I can just include in my web.xml one for each app I am using. they will thier own main-decorators and everthing works as it should. very simple fix. BJ Freeman sent the following on 12/17/2007 1:44

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread Chris Howe
2007 3:27:53 PM Subject: Re: mainDecoratorLocation was Include of controllers Why couldn't you supply your own custom mainDecorator? What do the base mainDecorators provide that you can't in your custom app? Scott On 18/12/2007, BJ Freeman <[EMAIL PROTECTED]> wrote: > > Based

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread Adrian Crum
The best way to prove it is to code it according to my suggestion and test it against the original problem you stated in this thread. It works. How do I know that? Because I did it a month ago. -Adrian BJ Freeman wrote: best way to prove this is to have a menu in a new app. point it to two di

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread BJ Freeman
best way to prove this is to have a menu in a new app. point it to two different screens one in each app. try to get both screens to work with out error. even using your code. BJ Freeman sent the following on 12/17/2007 1:39 PM: > you did not say to change > location="${parameters.mainDecoratorLo

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread BJ Freeman
and just to make this a point there can be only one so if I had my own main-decorator it would not work for calling all other apps. BJ Freeman sent the following on 12/17/2007 1:38 PM: > short answer is I can > but that still would not solve the problem. > take the party main-decorator > > >

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread Adrian Crum
No, that's not what I said. BJ Freeman wrote: you did not say to change so even your change will not work. Adrian Crum sent the following on 12/17/2007 1:32 PM: That line wouldn't exist if you made the change I suggested. Make the code changes, THEN tell me what's wrong with it. Telling m

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread Adrian Crum
In that case, activeApp becomes your custom app, and appheaderTemplate points to your custom app header template. The party manager javascript and stylesheet elements would have to be copied over to your main-decorator. BJ Freeman wrote: short answer is I can but that still would not solve t

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread BJ Freeman
you did not say to change so even your change will not work. Adrian Crum sent the following on 12/17/2007 1:32 PM: > That line wouldn't exist if you made the change I suggested. > > Make the code changes, THEN tell me what's wrong with it. Telling me > what's already wrong with it is pointless

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread BJ Freeman
short answer is I can but that still would not solve the problem. take the party main-decorator not these can not be the same ones if I am calling the product main-decorator Scott Gray sent t

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread Adrian Crum
That line wouldn't exist if you made the change I suggested. Make the code changes, THEN tell me what's wrong with it. Telling me what's already wrong with it is pointless - I already know the existing code doesn't work. BJ Freeman wrote: I beg to differ with you. where is

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread BJ Freeman
I beg to differ with you. where is defined where is in the CommonPartyDecorator defined. Adrian Crum sent the following on 12/17/2007 1:03 PM: > ListPartyCommEvents request maps to ListPartyCommEvents view, that maps > to > component://party/widget/partymgr/Commu

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread Scott Gray
Why couldn't you supply your own custom mainDecorator? What do the base mainDecorators provide that you can't in your custom app? Scott On 18/12/2007, BJ Freeman <[EMAIL PROTECTED]> wrote: > > Based on this, I can never see how even if I called from a custom app > different screens in different

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread BJ Freeman
Based on this, I can never see how even if I called from a custom app different screens in different apps how one main-decorator so I am not sure how this feature would work at all. Hence my original suggestion that is apps main-decorator be declared as application-mainDecoratorLocation this way I

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread Adrian Crum
ListPartyCommEvents request maps to ListPartyCommEvents view, that maps to component://party/widget/partymgr/CommunicationScreens.xml#ListPartyCommEvents. The ListPartyCommEvents screen in CommunicationScreens.xml doesn't contain anything specific to the Party Manager's web.xml file. I don't se

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread BJ Freeman
I have a menu, no screens, that calls ListPartyCommEvents this goes to the party controller to resolve. the party controller uses it view for ListPartyCommEvents It can not read the party web.xml so will error even with your changes. so lets say i put in a mainDecoratorLocation in my web xml and d

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread Adrian Crum
1. Move the CommonCommunicationEventDecorator screen to the communicationsscreens.xml file. 2. Change all location="${parameters.mainDecoratorLocation}"> to location="${parameters.communicationEventDecoratorLocation}"> Since parameters.communicationEventDecoratorLocation isn't defined anywhe

Re: mainDecoratorLocation was Include of controllers

2007-12-17 Thread BJ Freeman
I will still get the error since the parameters.mainDecoratorLocation for that is in the web.xml for party. BJ Freeman sent the following on 12/17/2007 12:23 PM: > Ok here is a real situation: > take the party/widgets/partymgr/commicationsscreens.xml > location="${parameters.mainDecoratorLocatio