Re: OWB 2 not firing ProcessAnnotatedType for all bean classes

2017-07-23 Thread Eric Covener
On Sun, Jul 23, 2017 at 8:13 AM, John D. Ament wrote: > We should probably review on cdi-dev. I believe the intention behind > saying "classes discovered" [1] is to indicate that its for all classes, > not just eligible beans. Here's a use case: I have framework specific

Re: rename owb-2.0 to owb-1.5?

2014-08-30 Thread Eric Covener
On Sat, Aug 30, 2014 at 3:01 AM, Mark Struberg strub...@yahoo.de wrote: What about renaming our current trunk to 1.5.0-SNAPSHOT? +1, awfully confusing w/o it. -- Eric Covener cove...@gmail.com

Re: BDA scanning via isBDABeansXmlScanningEnabled

2014-05-11 Thread Eric Covener
On Sun, May 11, 2014 at 4:55 PM, Mark Struberg strub...@yahoo.de wrote: The current impl of isBDABeansXmlScanningEnabled() is pretty much disfunctional. This has to do that the BDA specification in CDI-1.1 is not as clear as it should be. +1. IMO even if 1.1 is still unclear, it stil seems

Re: [VOTE] Release Apache OpenWebBeans-1.2.2

2014-02-20 Thread Eric Covener
err once more with dev@ On Thu, Feb 20, 2014 at 11:19 AM, Eric Covener cove...@gmail.com wrote: Source Release: http://repository.apache.org/content/repositories/orgapacheopenwebbeans-1001/org/apache/openwebbeans/openwebbeans/1.2.2/openwebbeans-1.2.2-source-release.zip +1 -- Eric Covener

Re: targetting CDI-1.1 in trunk

2014-01-26 Thread Eric Covener
I suggest we move the current trunk to an owb_1.2.x branch and move our trunk to target the new CDI-1.1 MR release (as discussed in November already). Then I'll go on and cut an owb-1.2.2 release from the branch. +1

[jira] [Commented] (OWB-771) Invocation​ContextImpl cleans target field if occurs an exception

2013-02-12 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13577118#comment-13577118 ] Eric Covener commented on OWB-771: -- I don't think this assignment accomplishes much

[jira] [Updated] (OWB-568) Decorater for generic Interfaces does not work

2012-12-21 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener updated OWB-568: - Attachment: owb-trunk-generic_decorator.diff I took the approach of removing types from the bean types

[jira] [Commented] (OWB-738) CODI @ConversationScope + @Stateful in a bean = java.lang.StackOverflowError

2012-12-15 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13533043#comment-13533043 ] Eric Covener commented on OWB-738: -- AFAICT WSEjbBean is calling Context.get

[jira] [Commented] (OWB-738) CODI @ConversationScope + @Stateful in a bean = java.lang.StackOverflowError

2012-12-15 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13533046#comment-13533046 ] Eric Covener commented on OWB-738: -- The confusing part is why it needs to call Context.get

Re: [VOTE] release Apache OpenWebBeans 1.1.5

2012-08-09 Thread Eric Covener
Source release: https://repository.apache.org/content/repositories/orgapacheopenwebbeans-126/org/apache/openwebbeans/openwebbeans/1.1.5/openwebbeans-1.1.5-source-release.zip +1

Re: [VOTE] take2 Release Apache OpenWebBeans-1.1.4

2012-04-08 Thread Eric Covener
https://svn.apache.org/repos/asf/openwebbeans/tags/openwebbeans-1.1.4/ Source release: https://repository.apache.org/content/repositories/orgapacheopenwebbeans-007/org/apache/openwebbeans/openwebbeans/1.1.4/openwebbeans-1.1.4-source-release.zip +1

Re: OWB Decorators

2012-04-02 Thread Eric Covener
Is this a bug or is it not allowed to call other methods than the decorated one in the decorator method? I think the behavior he expects is the correct behavior, having not looked at the code, as the stack unwinds we need to back up the decorator we're looking at as next.

Re: [DISCUSS] remove webbeans-openejb module from OWB

2012-03-22 Thread Eric Covener
Thus I'd like to remove the webbeans-openejb module from OWB. +1 on any branch other than 1.0.

[jira] [Commented] (OWB-655) CDI doesn´t inject stateless EJB by abstract class.

2012-03-21 Thread Eric Covener (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OWB-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13234813#comment-13234813 ] Eric Covener commented on OWB-655: -- Does it really require the base class to be abstract

[jira] [Commented] (OWB-655) CDI doesn´t inject stateless EJB by abstract class.

2012-03-21 Thread Eric Covener (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OWB-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13234928#comment-13234928 ] Eric Covener commented on OWB-655: -- We wouldn't inject an abstract class, we'd include

[jira] [Created] (OWB-649) exceptions in EJB's are wrapped in InvocationTargetException

2012-02-23 Thread Eric Covener (Created) (JIRA)
Components: Enterprise Web Beans Affects Versions: 1.1.3 Reporter: Eric Covener Assignee: Eric Covener Fix For: 1.1.4 When an EJB is @Injected and the EjbBeanproxyHandler is used as the javassist MethodHandler, exceptions become wrapped

[jira] [Resolved] (OWB-649) exceptions in EJB's are wrapped in InvocationTargetException

2012-02-23 Thread Eric Covener (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/OWB-649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-649. -- Resolution: Fixed exceptions in EJB's are wrapped in InvocationTargetException

Re: [VOTE] Release Apache OpenWebBeans-1.1.2

2011-10-19 Thread Eric Covener
Source release: https://repository.apache.org/content/repositories/orgapacheopenwebbeans-072/org/apache/openwebbeans/openwebbeans/1.1.2/openwebbeans-1.1.2-source-release.zip +1 for GA

Re: svn commit: r1079926 - /openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/inject/AbstractInjectable.java

2011-06-04 Thread Eric Covener
) +            { +                 ((CreationalContextImpl?)this.injectionOwnerCreationalContext).addDependent(instanceUnderInjection.get(),injectedBean, injected); +            } +        } +         return injected;     } -- Eric Covener cove...@gmail.com

Re: [VOTE] release Apache OpenWebBeans 1.1.0

2011-03-25 Thread Eric Covener
Source release: https://repository.apache.org/content/repositories/orgapacheopenwebbeans-040/org/apache/openwebbeans/openwebbeans/1.1.0/openwebbeans-1.1.0-source-release.zip +1 (sigs, checksums, built and did reasonably well on standalone TCK)

[jira] [Updated] (OWB-479) detect loops in producer beans vs. producer method parameters at deployment time

2011-03-21 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener updated OWB-479: - Fix Version/s: 1.2.0 detect loops in producer beans vs. producer method parameters at deployment time

[jira] [Updated] (OWB-488) move WebBeansConfigurationException messages to message bundles

2011-03-21 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener updated OWB-488: - Fix Version/s: 1.2.0 move WebBeansConfigurationException messages to message bundles

Re: [jira] Commented: (OWB-472) archive centric beans.xml enabling

2011-02-13 Thread Eric Covener
On Sun, Feb 13, 2011 at 4:12 PM, Gerhard gerhard.petra...@gmail.com wrote: yes - it's non-intrusive because i fixed it. Non-intrusive in terms of technical rationale to call for a revert, not non-intrusive in terms of you had to refactor to use trunk in an appserver. however, we have a spi

Re: Yan:: svn commit: r1042754 - /openwebbeans/trunk/webbeans-jsf/src/main/resources/META-INF/faces-config.xml

2010-12-08 Thread Eric Covener
On Wed, Dec 8, 2010 at 1:25 PM, David Jencks david_jen...@yahoo.com wrote: Investigating this is taking longer than I hoped.  There's a tck test for 6.4.3, but it doesn't test most of the requirements in 6.4.3 and it's not clear to me that it has any relevance to how EL would work in a jsp or

[jira] Created: (OWB-488) move WebBeansConfigurationException messages to message bundles

2010-11-04 Thread Eric Covener (JIRA)
Components: Core Affects Versions: 1.0.0 Reporter: Eric Covener Assignee: Gurkan Erdogdu lots of grave WebBeansConfigurationException use string literals for stuff that ought to be translatable. -- This message is automatically generated by JIRA. - You can

[jira] Commented: (OWB-487) Section 5.5.7 restrictions on injecting InjectionPoint not enforced

2010-10-28 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12926028#action_12926028 ] Eric Covener commented on OWB-487: -- I think this is best read as ... qualifiers @Default

[jira] Created: (OWB-485) AmbiguousResolutionException doesn't print details about the injection point

2010-10-26 Thread Eric Covener (JIRA)
Issue Type: Improvement Components: Injection and Lookup Affects Versions: 1.0.0 Reporter: Eric Covener Assignee: Eric Covener Priority: Minor Fix For: 1.1.0 AmbiguousResolutionException doesn't print details about the injection point

[jira] Resolved: (OWB-485) AmbiguousResolutionException doesn't print details about the injection point

2010-10-26 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-485. -- Resolution: Fixed AmbiguousResolutionException doesn't print details about the injection point

[jira] Commented: (OWB-485) AmbiguousResolutionException doesn't print details about the injection point

2010-10-26 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12925226#action_12925226 ] Eric Covener commented on OWB-485: -- thanks, got it in r1027789

[jira] Created: (OWB-479) detect loops in producer beans vs. producer method parameters at deployment time

2010-10-21 Thread Eric Covener (JIRA)
Issue Type: Improvement Components: Injection and Lookup Affects Versions: 1.0.0 Reporter: Eric Covener Assignee: Gurkan Erdogdu Priority: Minor Currently OWB can cause a stack overflow if a parameter on a producer method is satisfied

Re: [VOTE] release Apache OpenWebBeans-1.0.0 2nd try

2010-10-13 Thread Eric Covener
Vote will be open for 72 hours. [ ] +1 approve [ ] +0 no opinion [ ] -1 veto (and reason why) +1

Re: [ANN] Welcome Paul J Reder as new committer!

2010-10-08 Thread Eric Covener
On Fri, Oct 8, 2010 at 12:41 PM, Mark Struberg strub...@yahoo.de wrote: Hi folks! The Apache OpenWebBeans PMC is pleased to announce  that Paul J Reder has accepted our invitation to join OWB as a committer. Congrats Paul! -- Eric Covener cove...@gmail.com

Re: [ANN] Welcome Rohit Kelapure as new committer!

2010-10-08 Thread Eric Covener
On Wed, Oct 6, 2010 at 2:48 AM, Gurkan Erdogdu gurkanerdo...@yahoo.com wrote: All, The OpenWebBeans PMC is pleased to announce  that Rohit Kelapure has accepted our invitation to join OWB as committer. Congrats Rohit!

Re: last TCK run

2010-09-30 Thread Eric Covener
On Thu, Sep 30, 2010 at 8:57 AM, Mark Struberg strub...@yahoo.de wrote: Hi! Before doing a release this afternoon, I'm currently running the TCK again. For standalone, I have one test which fails: DestroyedInstanceReturnedByGetTest Anyone knows anything about it? That's one of three I am

Re: last TCK run

2010-09-30 Thread Eric Covener
On Thu, Sep 30, 2010 at 9:20 AM, Mark Struberg strub...@yahoo.de wrote: and the others? Failed tests: testDestroyedInstanceMustNotBeReturnedByGet(org.jboss.jsr299.tck.tests.context.DestroyedInstanceReturnedByGetTest)

[jira] Resolved: (OWB-465) enhance EJB common code for crude @LocalBean support

2010-09-30 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-465. -- Resolution: Fixed enhance EJB common code for crude @LocalBean support

Re: ambiguous dependencies when using multiple qualifiers

2010-09-29 Thread Eric Covener
, and the ambiguous dependency is called resolvable. The spec says both producers satisfy the injection point, and does not allow it to discard the one with additional qualifiers. -- Eric Covener cove...@gmail.com

Re: [cwiki] owb-committers

2010-09-28 Thread Eric Covener
On Tue, Sep 28, 2010 at 9:07 AM, Gerhard gerhard.petra...@gmail.com wrote: @committers: please post your confluence user-names and i'll add them to the committers-group. Thanks for this -- I just registered with cove...@apache.org as username.

Re: [DISCUSS] releasing owb-1.0.0-alpha-3

2010-09-28 Thread Eric Covener
-openejb/ejb-openejb (or openejb/openejb) it would be less confusing. Of course I have no idea of the conventions in this area, the packaging ramifications, or am able to actually do the work :) -- Eric Covener cove...@gmail.com

[jira] Resolved: (OWB-463) EjbDefinitionUtility.defineEjbBeanProxy() should be able to create proxies for no-interface local beans

2010-09-28 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-463. -- Resolution: Fixed EjbDefinitionUtility.defineEjbBeanProxy() should be able to create proxies

[jira] Commented: (OWB-447) unnecessary contextual/non-contextual distinction in OpenWebBeansEJBIntercpetor

2010-09-21 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913269#action_12913269 ] Eric Covener commented on OWB-447: -- I don't know how I managed it, but I marked

[jira] Created: (OWB-454) ClassUtil.callInstanceMethod() doesn't propogate original exception

2010-09-19 Thread Eric Covener (JIRA)
Components: Core Affects Versions: 1.0.0-alpha-2 Reporter: Eric Covener Assignee: Eric Covener ClassUtil.callInstanceMethod() doesn't propogate original exception up the stack -- This message is automatically generated by JIRA. - You can reply to this email

[jira] Resolved: (OWB-454) ClassUtil.callInstanceMethod() doesn't propogate original exception

2010-09-19 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-454. -- Resolution: Fixed ClassUtil.callInstanceMethod() doesn't propogate original exception

[jira] Created: (OWB-455) IllegalArgument method calling remove method of EJB during destroy

2010-09-19 Thread Eric Covener (JIRA)
Components: Java EE Integration Affects Versions: 1.0.0-alpha-2 Reporter: Eric Covener Assignee: Eric Covener Priority: Minor Fix For: 1.0.0-alpha-3 Caused by: java.lang.IllegalArgumentException: object is not an instance of declaring

[jira] Created: (OWB-453) add a flag to disable context activation in EJB interceptor

2010-09-15 Thread Eric Covener (JIRA)
Versions: 1.0.0-alpha-2 Reporter: Eric Covener Assignee: Eric Covener Fix For: 1.0.0-alpha-3 Some containers might activate contexts in some other way (another dedicated interceptor, or even something else), so make the OpenWebBeansEJBInterceptor conditionally

[jira] Commented: (OWB-318) multiple methods with same EJB @interceptors(foo.class) in same bean class get multiple interceptor instances

2010-09-10 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12908101#action_12908101 ] Eric Covener commented on OWB-318: -- something wrong after applying the patch, mvn -Dtest

[jira] Commented: (OWB-318) multiple methods with same EJB @interceptors(foo.class) in same bean class get multiple interceptor instances

2010-09-10 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12908118#action_12908118 ] Eric Covener commented on OWB-318: -- whoops, I had DEBUG logging set at JRE level for the unit

[jira] Resolved: (OWB-318) multiple methods with same EJB @interceptors(foo.class) in same bean class get multiple interceptor instances

2010-09-10 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-318. -- Fix Version/s: 1.0.0-alpha-3 (was: 1.0.0-alpha-1) Resolution: Fixed

[jira] Reopened: (OWB-318) multiple methods with same EJB @interceptors(foo.class) in same bean class get multiple interceptor instances

2010-09-09 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener reopened OWB-318: -- reopening per Rohit multiple methods with same EJB @interceptors(foo.class) in same bean class get

[jira] Created: (OWB-451) Allow InterceptorUtil#callAroundInvokes to propogate a callers 'creational context key'

2010-09-08 Thread Eric Covener (JIRA)
: OpenWebBeans Issue Type: Improvement Components: Java EE Integration Affects Versions: 1.0.0-alpha-2 Reporter: Eric Covener Assignee: Eric Covener Priority: Minor Fix For: 1.0.0-alpha-3 For EJB's, it's handy to use a key

[jira] Resolved: (OWB-451) Allow InterceptorUtil#callAroundInvokes to propogate a callers 'creational context key'

2010-09-08 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-451. -- Resolution: Fixed Allow InterceptorUtil#callAroundInvokes to propogate a callers 'creational context

[jira] Commented: (OWB-447) unnecessary contextual/non-contextual distinction in OpenWebBeansEJBIntercpetor

2010-09-07 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12906766#action_12906766 ] Eric Covener commented on OWB-447: -- Method invocations on non-contextual EJB's must

[jira] Resolved: (OWB-447) unnecessary contextual/non-contextual distinction in OpenWebBeansEJBIntercpetor

2010-09-07 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-447. -- Resolution: Fixed * We should be managing a CreationalContext for the lifetime of the interceptor

[jira] Created: (OWB-449) EJB interceptor has incorrect/unnecessary use of business method checks

2010-09-07 Thread Eric Covener (JIRA)
: Bug Components: Java EE Integration Affects Versions: 1.0.0-alpha-2 Reporter: Eric Covener Assignee: Eric Covener Priority: Minor EJB interceptor checks in its own @AroundInvoke whether the method is a business method but it: *) only considers

[jira] Resolved: (OWB-449) EJB interceptor has incorrect/unnecessary use of business method checks

2010-09-07 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-449. -- Resolution: Fixed EJB interceptor has incorrect/unnecessary use of business method checks

[jira] Commented: (OWB-447) unnecessary contextual/non-contextual distinction in OpenWebBeansEJBIntercpetor

2010-09-07 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12907018#action_12907018 ] Eric Covener commented on OWB-447: -- re: referencing thread-locals beyond @PostConstrut, we

[jira] Resolved: (OWB-446) EJB lifecycle callbacks not stacked correctly

2010-09-06 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-446. -- Fix Version/s: 1.0.0-alpha-3 Resolution: Fixed EJB lifecycle callbacks not stacked correctly

[jira] Created: (OWB-447) unnecessary contextual/non-contextual distinction in OpenWebBeansEJBIntercpetor

2010-09-06 Thread Eric Covener (JIRA)
Issue Type: Bug Components: Enterprise Web Beans Affects Versions: 1.0.0-alpha-2 Reporter: Eric Covener Assignee: Eric Covener The separation between contextual and non-contextual is wrong/harmful and unnecessary. * We should be managing

[jira] Commented: (OWB-447) unnecessary contextual/non-contextual distinction in OpenWebBeansEJBIntercpetor

2010-09-06 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12906602#action_12906602 ] Eric Covener commented on OWB-447: -- we also need to avoid adding the underlying ejb instance

Re: [VOTE] release Apache OpenWebBeans-1.0.0-alpha-2

2010-09-01 Thread Eric Covener
Source release: https://repository.apache.org/content/repositories/orgapacheopenwebbeans-158/org/apache/openwebbeans/openwebbeans/1.0.0-alpha-2/openwebbeans-1.0.0-alpha-2-source-release.zip +1 for alpha, tested ejb-sample in tomcat+openejb -- Eric Covener cove...@gmail.com

Re: svn commit: r932843 - in /openwebbeans/trunk/webbeans-ejb/src/main/java/org/apache/webbeans/ejb/common: component/BaseEjbBean.java interceptor/OpenWebBeansEjbInterceptor.java proxy/EjbBeanProxyHan

2010-08-29 Thread Eric Covener
-contextual -- in fact I think all the contextual vs non-contextual distinction can go away if we do a little more work in @PostConstruct. (hope to look at it this week) -- Eric Covener cove...@gmail.com

lifecycle interceptors for EJBs

2010-08-25 Thread Eric Covener
this behave like @AroundInvoke and only call the EJB one when we fall off the bottom of our own invocation context? -- Eric Covener cove...@gmail.com

Re: lifecycle interceptors for EJBs

2010-08-25 Thread Eric Covener
On Wed, Aug 25, 2010 at 2:24 PM, Eric Covener cove...@gmail.com wrote: In our OWBEjbInterceptor, we have a disconnect between how @AroundInvoke and @PostConstruct/@PreDestroy are handled. answered offline -- aroundinvoke is right and lifecycles should ultimately behave the same. -- Eric

Re: EJB Bean Stateful Bean Remove Methods

2010-08-19 Thread Eric Covener
by the container unconditionally in Contextual.destroy(), since we always blocked the user from calling it. In a destroy() method is is still possible to check the context to make sure we actually obtained an EJB? -- Eric Covener cove...@gmail.com

[jira] Resolved: (OWB-442) our EJB proxies are broken when multiple local interfaces are used on a single class

2010-08-19 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-442. -- Fix Version/s: 1.0.0-alpha-2 Resolution: Fixed our EJB proxies are broken when multiple local

Re: EJB Bean Stateful Bean Remove Methods

2010-08-19 Thread Eric Covener
it -- in such a case where the method invocation handler was never invoked and never actually obtained an EJB. I think all is well though. -- Eric Covener cove...@gmail.com

[jira] Resolved: (OWB-443) Normal-scoped EJB not removed by container during Contextual.destroy()

2010-08-19 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-443. -- Fix Version/s: 1.0.0-alpha-2 Resolution: Fixed Normal-scoped EJB not removed by container during

jboss-test-harness.properties in both -tck and -porting?

2010-08-18 Thread Eric Covener
Why do we have two copies of jboss-test-harness.properties, one in -tck and one in -porting? Should they always have the same contents? It seems like the harness blows up if these are out of synch. -- Eric Covener cove...@gmail.com

[jira] Created: (OWB-442) our EJB proxies are broken when multiple local interfaces are used on a single class

2010-08-18 Thread Eric Covener (JIRA)
: OpenWebBeans Issue Type: Bug Components: Java EE Integration Affects Versions: 1.0.0-alpha-1 Reporter: Eric Covener Assignee: Eric Covener our javassist proxies for EJB beans only implement the single injected type, but they are stored in a cache keyed

Re: svn commit: r985746 - in /openwebbeans/trunk: webbeans-ejb/src/main/java/org/apache/webbeans/ejb/common/component/ webbeans-ejb/src/main/java/org/apache/webbeans/ejb/common/util/ webbeans-openejb/

2010-08-16 Thread Eric Covener
On Mon, Aug 16, 2010 at 2:06 AM, Gurkan Erdogdu gurkanerdo...@yahoo.com wrote: This proxy internally uses EJB proxy instance that implements all of  local interfaces. This may be internally handled by the OpenEJB. Look org.apache.openejb.core.ivm.EjbHomeProxyHandler class in

Re: svn commit: r985746 - in /openwebbeans/trunk: webbeans-ejb/src/main/java/org/apache/webbeans/ejb/common/component/ webbeans-ejb/src/main/java/org/apache/webbeans/ejb/common/util/ webbeans-openejb/

2010-08-16 Thread Eric Covener
On Mon, Aug 16, 2010 at 11:20 AM, Eric Covener cove...@gmail.com wrote: On Mon, Aug 16, 2010 at 2:06 AM, Gurkan Erdogdu gurkanerdo...@yahoo.com wrote: This proxy internally uses EJB proxy instance that implements all of  local interfaces. This may be internally handled by the OpenEJB. Look

Re: ELContextStore Question

2010-08-12 Thread Eric Covener
slightly off-topic, but Mark I was wondering if you could explain why we need to call destroyELContextStore from both the WebBeansConfigurationListener and from the end of the RequestContext? Is there some path that would only hit one of these callers?

[jira] Commented: (OWB-435) What is the expected result for following 2 decorators?

2010-08-12 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12898041#action_12898041 ] Eric Covener commented on OWB-435: -- #1 seems like very wrong behavior What is the expected

Re: [DISCUSS] releasing owb-1.0.0 next week?

2010-08-10 Thread Eric Covener
commercial products with a 1.0 release number ;) +1, I hope to work on BDA awareness in the scanner service / {Bean,Alternatives,Interceptor}Manager stuff and I don't want to derail 1.0 with it! Would we branch at 1.0, and would 1.0 still be CTR? -- Eric Covener cove...@gmail.com

299 q: AfterBeanDiscovery.addBean()

2010-08-09 Thread Eric Covener
no ways to enable anything for it? I couldn't find an alternative mechanism for enablement. -- Eric Covener cove...@gmail.com

[jira] Commented: (OWB-431) Generic Type Inheritance not resolved correctly

2010-07-29 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12893717#action_12893717 ] Eric Covener commented on OWB-431: -- IMHO the spec could only have meant assignable from

Re: is usage of BaseEjbBean.iface safe?

2010-07-28 Thread Eric Covener
. This is because there is not actually one iface per BaseEjbBean (EJB class), just one per injection point. -- Eric Covener cove...@gmail.com

Re: is usage of BaseEjbBean.iface safe?

2010-07-28 Thread Eric Covener
On Wed, Jul 28, 2010 at 7:55 AM, Eric Covener cove...@gmail.com wrote: On Wed, Jul 28, 2010 at 1:40 AM, Gurkan Erdogdu gurkanerdo...@yahoo.com wrote: Good catch Eric! Not mean that current logic is wrong. Bean API types are  local interfaces of the EJB bean  . We check all injection

is usage of BaseEjbBean.iface safe?

2010-07-27 Thread Eric Covener
with the enterprise bean itself. Does this sound right? -- Eric Covener cove...@gmail.com

Re: svn commit: r979071 - in /openwebbeans/trunk: webbeans-ejb/ webbeans-ejb/src/main/java/org/apache/webbeans/ejb/common/interceptor/ webbeans-impl/ webbeans-impl/src/main/java/org/apache/webbeans/

2010-07-26 Thread Eric Covener
be reverting this due to the EJB dependency leaking into -impl, will take a look this afternoon. I ran standalone with no regression, but must have done something wrong. -- Eric Covener cove...@gmail.com

Re: CIA bot on #openwebbeans?

2010-07-26 Thread Eric Covener
On Sun, Jul 25, 2010 at 4:45 PM, Rohit Kelapure kelap...@gmail.com wrote: +1 On Sun, Jul 25, 2010 at 1:28 PM, Eric Covener cove...@gmail.com wrote: How do people feel / who do we ask to turn on a CIA bot for commit messages in #openwebbeans? I am personally +1 any +/-0? it's third-party

Re: [IMPORTANT] About Big Commits

2010-07-25 Thread Eric Covener
EJB definition tests in the standalone suite -- do you test against a tomcat+openejb that has the integration applied? I don't think we could figure out local interfaces only without that (looking at testcase name only of one of the above) -- Eric Covener cove...@gmail.com

Re: svn commit: r979071 - in /openwebbeans/trunk: webbeans-ejb/ webbeans-ejb/src/main/java/org/apache/webbeans/ejb/common/interceptor/ webbeans-impl/ webbeans-impl/src/main/java/org/apache/webbeans/

2010-07-25 Thread Eric Covener
runInterceptorsForNonContextualEJB or something. -- Eric Covener cove...@gmail.com

[jira] Created: (OWB-421) defined-in-class EJB lifecycle callbacks masked by our Interceptor

2010-07-23 Thread Eric Covener (JIRA)
Components: Java EE Integration Affects Versions: 1.0.0-alpha-1 Reporter: Eric Covener Assignee: Eric Covener defined-in-class EJB lifecycle callbacks masked by our Interceptor, because we fail to call ejbContext.proceed() when we have no 299 lifecycle callbacks

[jira] Resolved: (OWB-421) defined-in-class EJB lifecycle callbacks masked by our Interceptor

2010-07-23 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-421. -- Fix Version/s: 1.0.0-alpha-2 Resolution: Fixed defined-in-class EJB lifecycle callbacks masked

[jira] Created: (OWB-418) EjbBeanProxyHandler must be 1:1 with proxy instances for dependent SFSB

2010-07-22 Thread Eric Covener (JIRA)
: Bug Components: Java EE Integration Affects Versions: 1.0.0-alpha-1 Environment: tomcat+owb integration Reporter: Eric Covener Assignee: Eric Covener EjbBeanProxyHandler must be 1:1 with proxy instances for dependent SFSB, so the handler can

[jira] Closed: (OWB-406) BaseEjbBean.removedStatefulInstance used by multiple instances/EjbBeanProxyHandlers

2010-07-22 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener closed OWB-406. Resolution: Fixed BaseEjbBean.removedStatefulInstance used by multiple instances/EjbBeanProxyHandlers

[jira] Closed: (OWB-415) EjbBeanProxyHandler for dependent ejb must save ejb instance

2010-07-22 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener closed OWB-415. Fix Version/s: 1.0.0-alpha-2 Resolution: Fixed EjbBeanProxyHandler for dependent ejb must save ejb

[jira] Closed: (OWB-416) BaseEJBBean.destroyComponentInstance() tries to call multiple remove methods

2010-07-22 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener closed OWB-416. Fix Version/s: 1.0.0-alpha-2 Resolution: Fixed BaseEJBBean.destroyComponentInstance() tries to call

[jira] Closed: (OWB-418) EjbBeanProxyHandler must be 1:1 with proxy instances for dependent SFSB

2010-07-22 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener closed OWB-418. Fix Version/s: 1.0.0-alpha-2 Resolution: Fixed EjbBeanProxyHandler must be 1:1 with proxy instances

[jira] Reopened: (OWB-406) BaseEjbBean.removedStatefulInstance used by multiple instances/EjbBeanProxyHandlers

2010-07-22 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener reopened OWB-406: -- BaseEjbBean.removedStatefulInstance used by multiple instances/EjbBeanProxyHandlers

[jira] Resolved: (OWB-406) BaseEjbBean.removedStatefulInstance used by multiple instances/EjbBeanProxyHandlers

2010-07-22 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-406. -- Resolution: Fixed BaseEjbBean.removedStatefulInstance used by multiple instances/EjbBeanProxyHandlers

[jira] Reopened: (OWB-415) EjbBeanProxyHandler for dependent ejb must save ejb instance

2010-07-22 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener reopened OWB-415: -- EjbBeanProxyHandler for dependent ejb must save ejb instance

[jira] Reopened: (OWB-418) EjbBeanProxyHandler must be 1:1 with proxy instances for dependent SFSB

2010-07-22 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener reopened OWB-418: -- EjbBeanProxyHandler must be 1:1 with proxy instances for dependent SFSB

[jira] Reopened: (OWB-416) BaseEJBBean.destroyComponentInstance() tries to call multiple remove methods

2010-07-22 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener reopened OWB-416: -- BaseEJBBean.destroyComponentInstance() tries to call multiple remove methods

[jira] Resolved: (OWB-415) EjbBeanProxyHandler for dependent ejb must save ejb instance

2010-07-22 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-415. -- Resolution: Fixed EjbBeanProxyHandler for dependent ejb must save ejb instance

[jira] Created: (OWB-415) EjbBeanProxyHandler for dependent ejb must save ejb instance

2010-07-21 Thread Eric Covener (JIRA)
Components: Enterprise Web Beans Affects Versions: 1.0.0-alpha-1 Reporter: Eric Covener Assignee: Eric Covener If we use a depenent EJB, the EjbBeanProxyHandler will try to acquire an EJB instance from the context each pass through the method handler. Multiple methods

[jira] Created: (OWB-417) BaseEjbBean.destroyComponentInstance() should call direct container remove API, not call an @Remove annotated method

2010-07-21 Thread Eric Covener (JIRA)
://issues.apache.org/jira/browse/OWB-417 Project: OpenWebBeans Issue Type: Bug Components: Java EE Integration Reporter: Eric Covener Assignee: Gurkan Erdogdu BaseEjbBean.destroyComponentInstance() should call direct container remove API

[jira] Assigned: (OWB-406) BaseEjbBean.removedStatefulInstance used by multiple instances/EjbBeanProxyHandlers

2010-07-20 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener reassigned OWB-406: Assignee: Eric Covener (was: Gurkan Erdogdu) self-assigning, this ended up dovetailing into some

[jira] Created: (OWB-406) BaseEjbBean.removedStatefulInstance used by multiple instances/EjbBeanProxyHandlers

2010-07-19 Thread Eric Covener (JIRA)
: OpenWebBeans Issue Type: Bug Components: Enterprise Web Beans Affects Versions: 1.0.0-alpha-1 Environment: OWB + tomcat EJB integration Reporter: Eric Covener Assignee: Gurkan Erdogdu BaseEjbBean.removedStatefulInstance is used by MethodHandlers

  1   2   >