Github user chrajeshbabu closed the pull request at:
https://github.com/apache/phoenix/pull/3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/3#issuecomment-48887938
@ramkrish86 - would you have time to check this in to master? We can add
this minor check in a follow up commit. @chrajeshbabu - will an alternate patch
be required
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14873050
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/ParallelIterators.java ---
@@ -238,7 +240,12 @@ private void
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/3#issuecomment-48941536
@ramkrish86 - just add a .patch to the url for the pull request and you'll
have the patch file to apply against the normal/updatable repo. The github repo
is
Github user chrajeshbabu commented on the pull request:
https://github.com/apache/phoenix/pull/3#issuecomment-48945719
bq. Just add the check to disable creating local indexes on a table with
immutable rows and then let's check this in.
Changed pull request to disallow local
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14897879
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/ExpressionType.java ---
@@ -169,6 +170,7 @@
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14898287
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/DefaultParallelIteratorRegionSplitter.java
---
@@ -140,7 +142,14 @@ public boolean
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14898383
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/DefaultParallelIteratorRegionSplitter.java
---
@@ -140,7 +142,14 @@ public boolean
Github user chrajeshbabu commented on the pull request:
https://github.com/apache/phoenix/pull/3#issuecomment-48949296
Resolved the conflicts after PHOENIX-1002 also.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14858124
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/SkipRangeParallelIteratorRegionSplitter.java
---
@@ -54,7 +55,8 @@ protected
Github user chrajeshbabu commented on the pull request:
https://github.com/apache/phoenix/pull/1#issuecomment-48839233
bq. Cleanest might be to just implement a simple
ParallelIteratorRegionSplitter for use when a local index is used that just
returns all regions:
I will add new
GitHub user chrajeshbabu opened a pull request:
https://github.com/apache/phoenix/pull/3
PHOENIX-933 Local index support to Phoenix
Updated pull request after resolving conflicts and handling James review
comments.
You can merge this pull request into a Git repository by running:
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14860092
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/IndexStatementRewriter.java
---
@@ -96,6 +96,11 @@ public ParseNode
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14860610
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/DefaultParallelIteratorRegionSplitter.java
---
@@ -140,7 +142,14 @@ public boolean
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14852114
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseTenantSpecificViewIndexIT.java
---
@@ -117,26 +139,38 @@ private Connection
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14852129
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexIT.java
---
@@ -51,21 +51,38 @@ public static void doSetup() throws
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14853783
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/ScanRegionObserver.java
---
@@ -100,7 +109,7 @@ public static void
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14854253
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/ScanRegionObserver.java
---
@@ -100,7 +109,7 @@ public static void
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14834867
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/CreateIndexCompiler.java
---
@@ -47,6 +51,21 @@ public MutationPlan compile(final
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14834896
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java
---
@@ -282,7 +286,7 @@ public Expression
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14834954
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/IndexStatementRewriter.java
---
@@ -96,6 +96,12 @@ public ParseNode
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14850777
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java
---
@@ -366,6 +384,21 @@ private RegionScanner
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14762643
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/TrackOrderPreservingExpressionCompiler.java
---
@@ -69,6 +70,7 @@
boolean
23 matches
Mail list logo
