[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2017-11-14 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/281#discussion_r151014001 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/BaseQueryPlan.java --- @@ -500,7 +500,10 @@ public ExplainPlan getExplainPlan() throws

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2017-11-07 Thread maryannxue
GitHub user maryannxue opened a pull request: https://github.com/apache/phoenix/pull/281 PHOENIX-4288 Indexes not used when ordering by primary key 1. Add class Cost. 2. Add method getCost() in QueryPlan. 3. Let QueryOptimizer choose the best plan based on Cost; meanwhile if

[GitHub] phoenix pull request #280: indextool inedxTable is not an index table for da...

2017-11-02 Thread xsq0718
GitHub user xsq0718 opened a pull request: https://github.com/apache/phoenix/pull/280 indextool inedxTable is not an index table for dataTable Phoenix;phoenix-4.8.0-cdh5.8.0 Hbase;1.2.0 Create phoenixTable ; CREATE Table "everAp"(pk VARCHAR PRIMARY KEY,"ba"."ap" varchar,"

[GitHub] phoenix pull request #279: PHOENIX-3757 System mutex table not being created...

2017-10-26 Thread karanmehta93
GitHub user karanmehta93 opened a pull request: https://github.com/apache/phoenix/pull/279 PHOENIX-3757 System mutex table not being created in SYSTEM namespace… … when namespace mapping is enabled Backport of https://github.com/apache/phoenix/pull/277 PR @twdsilva P

[GitHub] phoenix pull request #278: PHOENIX-4322 DESC primary key column with variabl...

2017-10-25 Thread maryannxue
GitHub user maryannxue opened a pull request: https://github.com/apache/phoenix/pull/278 PHOENIX-4322 DESC primary key column with variable length does not work in SkipScanFilter Changes: Avoid adding an extra trailing separator to the key You can merge this pull request into a

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146998114 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2526,8 +2541,14 @@ private void createOtherSystemT

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread aertoria
Github user aertoria commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146990595 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2526,8 +2541,14 @@ private void createOtherSystemT

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146986800 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2526,8 +2541,14 @@ private void createOtherSys

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146985453 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,68 @@ void ensureSystemTablesUpgr

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146974246 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2526,8 +2541,14 @@ private void createOtherSys

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146973563 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,68 @@ void ensureSystemTablesUpgrade

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146973010 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3086,12 +3103,18 @@ private void restoreFromSna

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146973086 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2514,7 +2529,7 @@ private void createSysMutexTa

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146972984 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,72 @@ void ensureSystemTablesUpgr

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146972829 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3195,6 +3255,18 @@ public boolean releaseUpgrad

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146968511 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,68 @@ void ensureSystemTablesUpgr

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146967826 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,72 @@ void ensureSystemTablesUpgr

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146967462 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,72 @@ void ensureSystemTablesUpgr

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146928850 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,68 @@ void ensureSystemTablesUpgrade

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146928345 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2514,7 +2529,7 @@ private void createSysMutexTa

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146928295 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,68 @@ void ensureSystemTablesUpgr

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146924391 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,68 @@ void ensureSystemTablesUpgr

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146921986 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,68 @@ void ensureSystemTablesUpgr

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146921855 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/MigrateSystemTablesToSystemNamespaceIT.java --- @@ -0,0 +1,399 @@ +/* + * Licens

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146908767 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,72 @@ void ensureSystemTablesUpgraded

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146902970 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,72 @@ void ensureSystemTablesUpgrade

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146903705 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,68 @@ void ensureSystemTablesUpgrade

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146902673 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3086,12 +3103,18 @@ private void restoreFromSnapsh

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146902373 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2526,8 +2541,14 @@ private void createOtherSystem

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146904748 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3195,6 +3255,18 @@ public boolean releaseUpgradeMu

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146904346 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,68 @@ void ensureSystemTablesUpgrade

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146901856 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2514,7 +2529,7 @@ private void createSysMutexTable

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-24 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146698425 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,68 @@ void ensureSystemTablesUpgr

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-24 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146697994 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,68 @@ void ensureSystemTablesUpgr

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-24 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146695798 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2905,14 +2918,18 @@ public void upgradeSystemTa

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-24 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146695278 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataProtocol.java --- @@ -95,6 +97,7 @@ // Key is the SYSTEM.CATALOG

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-24 Thread aertoria
Github user aertoria commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146687243 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,68 @@ void ensureSystemTablesUpgraded

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-24 Thread aertoria
Github user aertoria commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146682331 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,68 @@ void ensureSystemTablesUpgraded

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-24 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146663164 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,68 @@ void ensureSystemTablesUpgraded

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-24 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146662118 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2905,14 +2918,18 @@ public void upgradeSystemTables

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-24 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146660595 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataProtocol.java --- @@ -95,6 +97,7 @@ // Key is the SYSTEM.CATALOG time

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-24 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146659434 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/MigrateSystemTablesToSystemNamespaceIT.java --- @@ -0,0 +1,399 @@ +/* + * Licensed t

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-23 Thread karanmehta93
GitHub user karanmehta93 opened a pull request: https://github.com/apache/phoenix/pull/277 PHOENIX-3757 System mutex table not being created in SYSTEM namespace… … when namespace mapping is enabled On fresh cluster with system table namespace mapping enabled, SYSMUTEX will b

[GitHub] phoenix pull request #276: update

2017-10-20 Thread ChPi
Github user ChPi closed the pull request at: https://github.com/apache/phoenix/pull/276 ---

[GitHub] phoenix pull request #276: update

2017-10-20 Thread ChPi
GitHub user ChPi opened a pull request: https://github.com/apache/phoenix/pull/276 update cdh You can merge this pull request into a Git repository by running: $ git pull https://github.com/ChPi/phoenix 4.11-HBase-1.2 Alternatively you can review and apply these changes as the

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-19 Thread snakhoda-sfdc
Github user snakhoda-sfdc commented on a diff in the pull request: https://github.com/apache/phoenix/pull/275#discussion_r145747600 --- Diff: phoenix-core/src/main/java/com/ibm/icu/impl/jdkadapter/NumberFormatICU.java --- @@ -0,0 +1,229 @@ +// © 2016 and later: Unicode, Inc. a

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-19 Thread solzy
Github user solzy commented on a diff in the pull request: https://github.com/apache/phoenix/pull/275#discussion_r145639624 --- Diff: phoenix-core/src/main/java/com/ibm/icu/impl/jdkadapter/NumberFormatICU.java --- @@ -0,0 +1,229 @@ +// © 2016 and later: Unicode, Inc. and other

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-18 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/275#discussion_r145475530 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/expression/function/CollationKeyFunctionTest.java --- @@ -0,0 +1,143 @@ +/* + * Licens

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-18 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/275#discussion_r145475423 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/expression/function/CollationKeyFunctionTest.java --- @@ -0,0 +1,143 @@ +/* + * Licens

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-18 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/275#discussion_r145474350 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/CollationKeyFunction.java --- @@ -0,0 +1,230 @@ +/* + * Licensed t

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-18 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/275#discussion_r145473757 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/CollationKeyFunction.java --- @@ -0,0 +1,230 @@ +/* + * Licensed t

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-18 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/275#discussion_r145473581 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/CollationKeyFunction.java --- @@ -0,0 +1,230 @@ +/* + * Licensed t

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-17 Thread snakhoda-sfdc
Github user snakhoda-sfdc commented on a diff in the pull request: https://github.com/apache/phoenix/pull/275#discussion_r145257151 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/expression/function/CollationKeyFunctionTest.java --- @@ -96,33 +96,35 @@ private static bool

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-17 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/275#discussion_r145247898 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/CollationKeyFunction.java --- @@ -0,0 +1,221 @@ +package org.apache.ph

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-17 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/275#discussion_r145247513 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/CollationKeyFunction.java --- @@ -0,0 +1,221 @@ +package org.apache.ph

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-17 Thread snakhoda-sfdc
Github user snakhoda-sfdc commented on a diff in the pull request: https://github.com/apache/phoenix/pull/275#discussion_r145245002 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/CollationKeyFunction.java --- @@ -0,0 +1,221 @@ +package org.apache.p

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-17 Thread snakhoda-sfdc
Github user snakhoda-sfdc commented on a diff in the pull request: https://github.com/apache/phoenix/pull/275#discussion_r145243623 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/CollationKeyFunction.java --- @@ -0,0 +1,221 @@ +package org.apache.p

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-17 Thread snakhoda-sfdc
Github user snakhoda-sfdc commented on a diff in the pull request: https://github.com/apache/phoenix/pull/275#discussion_r145243141 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/CollationKeyFunction.java --- @@ -0,0 +1,221 @@ +package org.apache.p

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-17 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/275#discussion_r145233589 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/CollationKeyFunction.java --- @@ -0,0 +1,221 @@ +package org.apache.ph

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-17 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/275#discussion_r145232581 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixConnection.java --- @@ -336,6 +338,7 @@ public ReadOnlyProps getProps() {

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-17 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/275#discussion_r145232171 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/expression/function/CollationKeyFunctionTest.java --- @@ -96,33 +96,35 @@ private static boole

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-17 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/275#discussion_r145230960 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/CollationKeyFunction.java --- @@ -0,0 +1,221 @@ +package org.apache.ph

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-17 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/275#discussion_r145230698 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/CollationKeyFunction.java --- @@ -0,0 +1,221 @@ +package org.apache.ph

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-13 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/275#discussion_r144620511 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/CollationKeyFunction.java --- @@ -0,0 +1,233 @@ +package org.apache.ph

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-13 Thread shehzaadn-vd
Github user shehzaadn-vd commented on a diff in the pull request: https://github.com/apache/phoenix/pull/275#discussion_r144604412 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/CollationKeyFunction.java --- @@ -0,0 +1,233 @@ +package org.apache.ph

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-13 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/275#discussion_r144600094 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/CollationKeyFunction.java --- @@ -0,0 +1,233 @@ +package org.apache.ph

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-13 Thread snakhoda-sfdc
Github user snakhoda-sfdc commented on a diff in the pull request: https://github.com/apache/phoenix/pull/275#discussion_r144483837 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/CollationKeyFunction.java --- @@ -0,0 +1,233 @@ +package org.apache.p

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-12 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/275#discussion_r144416251 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/CollationKeyFunction.java --- @@ -0,0 +1,233 @@ +package org.apache.ph

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-12 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/275#discussion_r144415724 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/expression/function/CollationKeyFunctionTest.java --- @@ -0,0 +1,134 @@ +package org.apach

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-12 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/275#discussion_r144414821 --- Diff: phoenix-core/src/main/java/com/force/db/i18n/OracleUpper.java --- @@ -0,0 +1,66 @@ +/* --- End diff -- Yup! You got it right, J

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-12 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/275#discussion_r144414623 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/CollationKeyFunction.java --- @@ -0,0 +1,233 @@ +package org.apache.ph

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-12 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/275#discussion_r144413717 --- Diff: phoenix-core/src/main/java/com/force/db/i18n/OracleUpper.java --- @@ -0,0 +1,66 @@ +/* --- End diff -- @joshelser - my take,

[GitHub] phoenix pull request #241: PHOENIX-3556 upgrade guava library to version 20

2017-10-11 Thread zinking
Github user zinking closed the pull request at: https://github.com/apache/phoenix/pull/241 ---

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-04 Thread shehzaadn
GitHub user shehzaadn opened a pull request: https://github.com/apache/phoenix/pull/275 PHOENIX-4237: Add function to calculate Java collation keys Here we implement a generalized solution for calculating Java collation keys by creating Java collators based on a user locale. These c

[GitHub] phoenix pull request #274: 4.8 h base 1.2 cdh5.8

2017-09-26 Thread daiamo
GitHub user daiamo opened a pull request: https://github.com/apache/phoenix/pull/274 4.8 h base 1.2 cdh5.8 You can merge this pull request into a Git repository by running: $ git pull https://github.com/chiastic-security/phoenix-for-cloudera 4.8-HBase-1.2-cdh5.8 Alternativel

[GitHub] phoenix pull request #178: [PHOENIX-3061] IndexTool exits 0 even if bulkload...

2017-09-26 Thread SsnL
Github user SsnL closed the pull request at: https://github.com/apache/phoenix/pull/178 ---

[GitHub] phoenix pull request #185: [PHOENIX-3097] Incompatibilities with HBase 0.98....

2017-09-26 Thread SsnL
Github user SsnL closed the pull request at: https://github.com/apache/phoenix/pull/185 ---

[GitHub] phoenix pull request #273: Add equals verification test

2017-09-19 Thread TheRealHaui
GitHub user TheRealHaui opened a pull request: https://github.com/apache/phoenix/pull/273 Add equals verification test Adds an equals verification Unit Test. You can merge this pull request into a Git repository by running: $ git pull https://github.com/TheRealHaui/phoenix add

[GitHub] phoenix pull request #272: avoid-equals-null-problem

2017-09-19 Thread TheRealHaui
GitHub user TheRealHaui opened a pull request: https://github.com/apache/phoenix/pull/272 avoid-equals-null-problem Avoids NullPointerException in any case. You can merge this pull request into a Git repository by running: $ git pull https://github.com/TheRealHaui/phoenix maste

[GitHub] phoenix pull request #271: PHOENIX-4180 - Modify tests to generate unique ta...

2017-09-13 Thread rhshriva
GitHub user rhshriva opened a pull request: https://github.com/apache/phoenix/pull/271 PHOENIX-4180 - Modify tests to generate unique table names and not us… The following tests was changed. ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ArrayIT.java ./phoenix

[GitHub] phoenix pull request #268: PHOENIX-4010 Hash Join cache may not be send to a...

2017-09-07 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/268#discussion_r137629055 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseJoinIT.java --- @@ -30,14 +30,19 @@ import java.util.Map; import java.util.

[GitHub] phoenix pull request #268: PHOENIX-4010 Hash Join cache may not be send to a...

2017-09-07 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/268#discussion_r137628509 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java --- @@ -109,12 +110,16 @@ /** Expose

[GitHub] phoenix pull request #270: `DEFAULT_TIME_ZONE_ID` should take value from `Ti...

2017-08-26 Thread szq80140
GitHub user szq80140 opened a pull request: https://github.com/apache/phoenix/pull/270 `DEFAULT_TIME_ZONE_ID` should take value from `TimeZone.getDefault().getID()` instead of constant `GMT` `DEFAULT_TIME_ZONE_ID` should take value from `TimeZone.getDefault().getID()` instead o

[GitHub] phoenix pull request #269: PHOENIX-2460 Implement scrutiny command to valida...

2017-08-22 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/269#discussion_r134632114 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/mapreduce/util/TestIndexColumnNames.java --- @@ -0,0 +1,74 @@ +/* + * Licensed to the

[GitHub] phoenix pull request #269: PHOENIX-2460 Implement scrutiny command to valida...

2017-08-22 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/269#discussion_r134624315 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexScrutinyMapper.java --- @@ -0,0 +1,349 @@ +/* + * Licensed to the

[GitHub] phoenix pull request #269: PHOENIX-2460 Implement scrutiny command to valida...

2017-08-22 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/269#discussion_r134632028 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/mapreduce/index/TestIndexScrutinyTableOutput.java --- @@ -0,0 +1,93 @@ +/* + * License

[GitHub] phoenix pull request #269: PHOENIX-2460 Implement scrutiny command to valida...

2017-08-22 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/269#discussion_r134631925 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/mapreduce/index/TestIndexScrutinyTableOutput.java --- @@ -0,0 +1,93 @@ +/* + * License

[GitHub] phoenix pull request #236: PHOENIX-3654 Load Balancer for thin client

2017-08-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/phoenix/pull/236 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] phoenix pull request #269: PHOENIX-2460 Implement scrutiny command to valida...

2017-08-17 Thread vincentpoon
GitHub user vincentpoon opened a pull request: https://github.com/apache/phoenix/pull/269 PHOENIX-2460 Implement scrutiny command to validate whether or not an… … index is in sync with the data table You can merge this pull request into a Git repository by running: $ git pu

[GitHub] phoenix pull request #266: PHOENIX-3769 - Fix OnDuplicateKeyIT failure on pp...

2017-08-07 Thread snehakpersistent
Github user snehakpersistent closed the pull request at: https://github.com/apache/phoenix/pull/266 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] phoenix pull request #236: PHOENIX-3654 Load Balancer for thin client

2017-08-01 Thread rahulsIOT
Github user rahulsIOT commented on a diff in the pull request: https://github.com/apache/phoenix/pull/236#discussion_r130728526 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java --- @@ -284,14 +288,18 @@ public static final int DEFAUL

[GitHub] phoenix pull request #236: PHOENIX-3654 Load Balancer for thin client

2017-08-01 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/236#discussion_r130726475 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java --- @@ -284,14 +288,18 @@ public static final int DEFAUL

[GitHub] phoenix pull request #236: PHOENIX-3654 Load Balancer for thin client

2017-08-01 Thread rahulsIOT
Github user rahulsIOT commented on a diff in the pull request: https://github.com/apache/phoenix/pull/236#discussion_r130725729 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java --- @@ -284,14 +288,18 @@ public static final int DEFAUL

[GitHub] phoenix pull request #268: PHOENIX-4010 Hash Join cache may not be send to a...

2017-07-26 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/268#discussion_r129601553 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java --- @@ -804,6 +804,7 @@ public Long getEstimatedBytesToScan() throw

[GitHub] phoenix pull request #268: PHOENIX-4010 Hash Join cache may not be send to a...

2017-07-26 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/phoenix/pull/268#discussion_r129589111 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java --- @@ -804,6 +804,7 @@ public Long getEstimatedBytesToScan() throw

[GitHub] phoenix pull request #268: PHOENIX-4010 Hash Join cache may not be send to a...

2017-07-24 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/268#discussion_r129188027 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java --- @@ -108,6 +126,10 @@ public TableResultIterator(MutationS

[GitHub] phoenix pull request #268: PHOENIX-4010 Hash Join cache may not be send to a...

2017-07-24 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/268#discussion_r129187485 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java --- @@ -804,6 +804,7 @@ public Long getEstimatedBytesToScan() throw

[GitHub] phoenix pull request #268: PHOENIX-4010 Hash Join cache may not be send to a...

2017-07-24 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/268#discussion_r129187099 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/cache/ServerCacheClient.java --- @@ -303,73 +318,84 @@ public TaskExecutionMetricsHolder getTa

[GitHub] phoenix pull request #268: PHOENIX-4010 Hash Join cache may not be send to a...

2017-07-24 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/268#discussion_r129186906 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/cache/ServerCacheClient.java --- @@ -303,73 +318,84 @@ public TaskExecutionMetricsHolder getTa

[GitHub] phoenix pull request #268: PHOENIX-4010 Hash Join cache may not be send to a...

2017-07-24 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/268#discussion_r129185736 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java --- @@ -163,8 +185,38 @@ public Tuple next() throws SQLExcept

<    1   2   3   4   5   6   7   8   9   10   >