Re: Review Request 63874: SENTRY-1812 - Provide interactive Sentry CLI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63874/#review191688 --- Fix it, then Ship it! LGTM, a few nits below. bin/sentryCli

Re: Review Request 63974: SENTRY-2062: Support the new Hive 2.3.2 DbNotificationListener

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63974/#review191686 --- Code looks good overall. I have some questions/clarifications

Re: Review Request 63402: SENTRY-2021 MR session ACLs in Hive binding does not handle all types of ACLs

> On Nov. 21, 2017, 3:21 p.m., Sergio Pena wrote: > > For some reason I cannot see the most updated file nor download it. > > Could you submit the file with a different version number? The latest revision of the patch is SENTRY-2021.patch (revision 3) on this link

Re: Review Request 63424: SENTRY-2024: Specify Char Set for AUTHZ_OBJ_NAME

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63424/ --- (Updated Nov. 21, 2017, 11:46 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 63424: SENTRY-2024: Specify Char Set for AUTHZ_OBJ_NAME

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63424/ --- (Updated Nov. 21, 2017, 11:44 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 63974: SENTRY-2062: Support the new Hive 2.3.2 DbNotificationListener

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63974/ --- (Updated Nov. 21, 2017, 10:14 p.m.) Review request for sentry, Alexander

Re: Review Request 63975: SENTRY-2066: DB name is not set for AlterTable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63975/#review191659 --- Ship it! Ship It! - Arjun Mishra On Nov. 21, 2017, 9:27

Re: Review Request 63878: [SENTRY-1480] Solr/Sentry permissions migration tool

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63878/#review191657 --- Ship it! Ship It! - kalyan kumar kalvagadda On Nov. 21,

Re: Review Request 63975: SENTRY-2066: DB name is not set for AlterTable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63975/#review191656 --- Ship it! Ship It! - Sergio Pena On Nov. 21, 2017, 9:27

Re: Review Request 63878: [SENTRY-1480] Solr/Sentry permissions migration tool

> On Nov. 16, 2017, 10 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/PermissionsMigrationToolCommon.java > > Lines 236 (patched) > >

Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS notification processing.

> On Nov. 20, 2017, 11:43 p.m., Sergio Pena wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java > > Lines 52-54 (patched) > > > > > > Can we

Re: Review Request 63975: SENTRY-2066: DB name is not set for AlterTable

> On Nov. 21, 2017, 8:09 p.m., Arjun Mishra wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > > Line 265 (original), 265 (patched) > > > > > > Is

Re: Review Request 63975: SENTRY-2066: DB name is not set for AlterTable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63975/ --- (Updated Nov. 21, 2017, 9:27 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 63993: SENTRY-2046: Create a full snapshot if AUTHZ_PATHS_SNAPSHOT_ID is empty, even if HMS and Sentry Notifications are in sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63993/#review191649 --- Ship it! Ship It! - Na Li On Nov. 21, 2017, 7:56 p.m.,

Re: Review Request 64002: SENTRY-2068: Disable HTTP TRACE method from the Sentry Web Server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64002/#review191647 --- what test have you done for this update? - Na Li On Nov. 21,

Re: Review Request 63993: SENTRY-2046: Create a full snapshot if AUTHZ_PATHS_SNAPSHOT_ID is empty, even if HMS and Sentry Notifications are in sync

> On Nov. 21, 2017, 8:41 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 257 (patched) > > > > > > the logging level can be info to

Review Request 64002: SENTRY-2068: Disable HTTP TRACE method from the Sentry Web Server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64002/ --- Review request for sentry. Bugs: sentry-2068

Re: Review Request 63993: SENTRY-2046: Create a full snapshot if AUTHZ_PATHS_SNAPSHOT_ID is empty, even if HMS and Sentry Notifications are in sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63993/#review191640 ---

Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS notification processing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63958/#review191638 ---

Re: Review Request 63993: SENTRY-2046: Create a full snapshot if AUTHZ_PATHS_SNAPSHOT_ID is empty, even if HMS and Sentry Notifications are in sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63993/#review191636 --- Ship it! Ship It! - Sergio Pena On Nov. 21, 2017, 7:56

Re: Review Request 63993: SENTRY-2046: Create a full snapshot if AUTHZ_PATHS_SNAPSHOT_ID is empty, even if HMS and Sentry Notifications are in sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63993/ --- (Updated Nov. 21, 2017, 7:54 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 63878: [SENTRY-1480] Solr/Sentry permissions migration tool

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63878/ --- (Updated Nov. 21, 2017, 7:08 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 63878: [SENTRY-1480] Solr/Sentry permissions migration tool

> On Nov. 16, 2017, 10 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/PermissionsMigrationToolCommon.java > > Lines 236 (patched) > >

Re: Review Request 63996: SENTRY-2059: Fix the tests to use transaction listeners for handling HMS Notifications.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63996/#review191622 --- Ship it! Ship It! - Arjun Mishra On Nov. 21, 2017, 6:34

Re: Review Request 63975: SENTRY-2066: DB name is not set for AlterTable

> On Nov. 21, 2017, 7:51 a.m., Alexander Kolbasov wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > > Lines 283 (patched) > > > > > > Why do we

Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS notification processing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63958/#review191619 ---

Re: Review Request 63975: SENTRY-2066: DB name is not set for AlterTable

> On Nov. 21, 2017, 7:51 a.m., Alexander Kolbasov wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > > Lines 283 (patched) > > > > > > Why do we

Re: Review Request 63996: SENTRY-2059: Fix the tests to use transaction listeners for handling HMS Notifications.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63996/#review191617 --- Ship it! Ship It! - Sergio Pena On Nov. 21, 2017, 6:34

Re: Review Request 63993: SENTRY-2046: Create a full snapshot if AUTHZ_PATHS_SNAPSHOT_ID is empty, even if HMS and Sentry Notifications are in sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63993/ --- (Updated Nov. 21, 2017, 6:35 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 63993: SENTRY-2046: Create a full snapshot if AUTHZ_PATHS_SNAPSHOT_ID is empty, even if HMS and Sentry Notifications are in sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63993/ --- (Updated Nov. 21, 2017, 6:34 p.m.) Review request for sentry, kalyan kumar

Review Request 63996: SENTRY-2059: Fix the tests to use transaction listeners for handling HMS Notifications.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63996/ --- Review request for sentry and Sergio Pena. Bugs: SENTRY-2059

Re: Review Request 63993: SENTRY-2046: Create a full snapshot if AUTHZ_PATHS_SNAPSHOT_ID is empty, even if HMS and Sentry Notifications are in sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63993/#review191615 ---

Re: Review Request 63993: SENTRY-2046: Create a full snapshot if AUTHZ_PATHS_SNAPSHOT_ID is empty, even if HMS and Sentry Notifications are in sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63993/#review191604 ---

Re: Review Request 63878: [SENTRY-1480] Solr/Sentry permissions migration tool

> On Nov. 16, 2017, 10 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/PermissionsMigrationToolCommon.java > > Lines 218 (patched) > >

Re: Several unit tests failing on Sentry

Sergio, Thanks for the summary. It's very helpful. Lina On Tue, Nov 21, 2017 at 9:08 AM, Sergio Pena wrote: > Lina, > > There were some leads on the Jenkins side about the issues. > 1. All the tests were failing because the Hive/MR job couldn't find a file > on the

Review Request 63993: SENTRY-2046: Create a full snapshot if AUTHZ_PATHS_SNAPSHOT_ID is empty, even if HMS and Sentry Notifications are in sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63993/ --- Review request for sentry, kalyan kumar kalvagadda, Na Li, Sergio Pena, and

Re: Review Request 63975: SENTRY-2066: DB name is not set for AlterTable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63975/ --- (Updated Nov. 21, 2017, 5:08 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 63975: SENTRY-2066: DB name is not set for AlterTable

> On Nov. 21, 2017, 7:30 a.m., Vadim Spector wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSentryOnFailureHookLoading.java > > Line 265 (original), 265 (patched) > >

Re: Review Request 63975: SENTRY-2066: DB name is not set for AlterTable

> On Nov. 21, 2017, 7:51 a.m., Alexander Kolbasov wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > > Lines 283 (patched) > > > > > > Why do we

Re: Review Request 63402: SENTRY-2021 MR session ACLs in Hive binding does not handle all types of ACLs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63402/#review191581 --- For some reason I cannot see the most updated file nor download

Re: Several unit tests failing on Sentry

Lina, There were some leads on the Jenkins side about the issues. 1. All the tests were failing because the Hive/MR job couldn't find a file on the /tmp directory. 2. All the tests were failing only during the day (they were passing at night). 3. Reverting too old patches were sometimes passing

Review Request 63985: SENTRY-2056: Display test-patch.py output on the standard console to see progress on Jenkins

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63985/ --- Review request for sentry. Bugs: sentry-2056