Re: about rename table across database

2018-04-10 Thread Alexander Kolbasov
I think you are right - there is no reason to do that. I am not sure whether we can actually have changed DB name in ALTER TABLE event at all. On Tue, Apr 10, 2018 at 12:58 PM, Na Li wrote: > Sasha, > > > In FullUpdateModifier.alterTable(), why did you have the section

Re: about rename table across database

2018-04-11 Thread Alexander Kolbasov
--- >> >> On Tue, Apr 10, 2018 at 6:49 PM, Na Li <lina...@cloudera.com> wrote: >> >> > Sasha, >> > >> > We can. And I added the test case in e2e tests, and it works. >> > >> > On Tue, Apr 10, 2018 at 5:34 PM

Re: Using a different Command line tool

2018-04-12 Thread Alexander Kolbasov
I think this should be fine as long as we don't use both. BTW, do you know that there is also an interactive CLI - it would be nice if you add support there as well. - Alex On Mon, Apr 9, 2018 at 11:05 AM, Stephen Moist wrote: > Hey all, I’ve been prototyping out the ABAC

Re: about rename table across database

2018-04-10 Thread Alexander Kolbasov
on Facebook] <https://www.facebook.com/cloudera> [image: >> Cloudera >> on LinkedIn] <https://www.linkedin.com/company/cloudera> >> ------ >> >> On Tue, Apr 10, 2018 at 6:49 PM, Na Li <lina...@cloudera.com> wrote: >> >&g

Re: sentry-provider-db and circular dependencies

2018-04-18 Thread Alexander Kolbasov
It was done earlier as sentry-1205. The code is still in the got history. We didn't include the change - it was too difficult to merge with ha branch. > On Apr 18, 2018, at 12:57, Stephen Moist wrote: > > Great, I’ll get started on that. Is there a better name I should

Re: sentry-provider-db and circular dependencies

2018-04-18 Thread Alexander Kolbasov
In my experience IntelliJ is your friend here - it is really good at this kind of refactoring. On Wed, Apr 18, 2018 at 1:54 PM, Stephen Moist <mo...@cloudera.com> wrote: > Ok, I’ll work against that idea then with the sentry-service module. > > > On Apr 18, 2018, at 3:45 PM,

Hive changes to object ownership

2018-03-26 Thread Alexander Kolbasov
Just saw this: https://issues.apache.org/jira/browse/HIVE-19058 May be this has some relevance for FGP.

Re: Separating thrift api out (SENTRY-2188)

2018-03-27 Thread Alexander Kolbasov
I have some concerns there. It is, indeed, a problem every time you need to do thrift changes, but so fat this was usually a rare event. Having thrift as a requirement makes life inconvenient - for example the thrift version that I have on my laptop is 0.11.0 and I have to do something special to

Re: Review Request 66336: SENTRY-2190: Have verbose debug logs in CounterWait class

2018-03-28 Thread Alexander Kolbasov
ning from wait for {}"? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/CounterWait.java Line 243 (original), 249 (patched) <https://reviews.apache.org/r/66336/#comment280795> What's wrong with the original message? - Alexander Kol

Re: Review Request 66336: SENTRY-2190: Have verbose debug logs in CounterWait class

2018-03-29 Thread Alexander Kolbasov
r-db/src/main/java/org/apache/sentry/provider/db/service/persistent/CounterWait.java Line 213 (original), 216 (patched) <https://reviews.apache.org/r/66336/#comment280878> Again, "returning from wait 125" is confusing message. - Alexander Kolbasov On March 29, 2018, 5:

Re: Fine grained privilege changes in Apache Sentry

2018-03-26 Thread Alexander Kolbasov
available in Sentry 2.1, I think it makes sense to > continue with that path unless there are other features planned for 2.1 and > we cannot guarantee to have FGP ready by 2.1? > > On Mon, Mar 26, 2018 at 4:28 PM, Alexander Kolbasov <ak...@cloudera.com> > wrote: > > > T

Fine grained privilege changes in Apache Sentry

2018-03-26 Thread Alexander Kolbasov
There is one thing I'd like to clarify. What is the plan for all the work around introducing fine-grained permissions managed by Sentry - do you intend to do the work in a feature branch and merge the whole thing when it is ready - similar to the way Sentry HA was done or you intend to directly

Re: Review Request 66146: SENTRY-2184: Performance Issue: MPath is queried for each MAuthzPathsMapping in full snapshot

2018-03-21 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66146/#review199698 --- Ship it! Ship It! - Alexander Kolbasov On March 21, 2018, 4

Alternative Sentry architecture

2018-03-05 Thread Alexander Kolbasov
I was thinking about possible alternatives to the way Sentry works with HMS. What do people think of Sentry being a proxy to HMS thrift protocol? This way it can see all HMS requests and responses and can enforce HMS-level privileges without any plugins (Hiveserver2 still needs plugins) and it

Re: Review Request 66787: SENTRY-2212 smart-apply-patch.sh isn't so smart, won't apply changes when files have been moved or renamed

2018-04-25 Thread Alexander Kolbasov
> On April 25, 2018, 4:07 p.m., Anthony Young-Garner wrote: > > dev-support/smart-apply-patch.sh > > Line 44 (original) > > > > > > Do we not still want to detect this situation (only new files) and try > > applying

Re: HMS catalogs and Sentry

2018-04-25 Thread Alexander Kolbasov
ttps://www.cloudera.com/> > > [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image: > Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: Cloudera > on LinkedIn] <https://www.linkedin.com/company/cloudera> > --

HMS catalogs and Sentry

2018-04-25 Thread Alexander Kolbasov
Hive 3 introduced the notion of catalog. What do people think about supporting it in Sentry as well? At some point we will move to Hive-3 and then it will become a requirement I guess. - Alex

Re: [ANNOUNCE] Apache Sentry 2.1.0 released

2018-10-02 Thread Alexander Kolbasov
Fantastic! Thank you Lina for doing the release! > On Oct 2, 2018, at 08:57, Na Li wrote: > > The Apache Sentry team is happy to announce the release of version 2.1.0. > Apache Sentry is a system to enforce fine grained role based authorization > to data and metadata stored on a Hadoop cluster.

Re: Review Request 68831: SENTRY-2417: fix LocalGroupMappingService INI format class docs

2018-09-24 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68831/#review208979 --- Ship it! Ship It! - Alexander Kolbasov On Sept. 24, 2018

<    3   4   5   6   7   8