svn commit: r708 - /release/shindig/2.5.0-beta2/

2012-06-26 Thread rbaxter85
Author: rbaxter85 Date: Wed Jun 27 00:30:17 2012 New Revision: 708 Log: 2.5.0-beta2 war file Added: release/shindig/2.5.0-beta2/shindig-server-2.5.0-beta2.war (with props) release/shindig/2.5.0-beta2/shindig-server-2.5.0-beta2.war.asc release/shindig/2.5.0-beta2/shindig-server-2.5.0

Re: SHINDIG-1809 and Uri encoding/decoding

2012-06-26 Thread Henry Saputra
Hmm looks like the code has not been updated for a while. My guess is that the server code assume that the iframe and JS URIs will be generated by Shindig with the non encoded format so there is no need to decode the incoming URLs But looks like a bug to me. - Henry On Mon, Jun 25, 2012 at 5:24

Re: Review Request: Enable access to OS Templates defined in template libraries from client API

2012-06-26 Thread Chris Geer
> On June 26, 2012, 11:25 p.m., Henry Saputra wrote: > > Correct me if I am wrong, but the issue about templates defined in the > > module inline are no longer available to the client apis happen regardless > > of this patch right? I dont see how this patch affect the inline template. Henry, y

Re: Review Request: Enable access to OS Templates defined in template libraries from client API

2012-06-26 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5600/#review8645 --- Correct me if I am wrong, but the issue about templates defined in the

Re: Review Request: Enable access to OS Templates defined in template libraries from client API

2012-06-26 Thread Chris Geer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5600/ --- (Updated June 26, 2012, 11:21 p.m.) Review request for shindig. Changes --

Review Request: Enable access to OS Templates defined in template libraries from client API

2012-06-26 Thread Chris Geer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5600/ --- Review request for shindig. Description --- OS Templates that were defined

Re: Review Request: OAuth2TokenPersistence setSecret fails if no encrypter

2012-06-26 Thread Brian Lillie
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5497/ --- (Updated June 26, 2012, 8:33 p.m.) Review request for shindig. Changes ---

Re: Review Request: Additional OAuth2 Logging Filters

2012-06-26 Thread Brian Lillie
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5592/#review8632 --- We are already converting the message parameters from the original obj

Re: Review Request: The sample Media.xml gadget does not support multiple instances in IE8

2012-06-26 Thread Dan Dumont
> On June 26, 2012, 7:15 p.m., Dan Dumont wrote: > > Ship It! Already committed :)Will close. - Dan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2358/#review8629 --

Re: Review Request: The sample Media.xml gadget does not support multiple instances in IE8

2012-06-26 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2358/#review8629 --- Ship it! Ship It! - Dan Dumont On Oct. 12, 2011, 3:28 p.m., Michae

Re: Review Request: CMIS Folders & Documents in Apache Shindig

2012-06-26 Thread ddumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3192/ --- (Updated June 26, 2012, 7:13 p.m.) Review request for shindig. Description ---

Re: Review Request: Add a set title handler to the example common container

2012-06-26 Thread Dan Dumont
> On June 26, 2012, 7:06 p.m., superddumont wrote: > > Patch might need an update. So old :) Pay no attention to the man behind the curtain. - Dan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.o

Re: Review Request: Add a set title handler to the example common container

2012-06-26 Thread ddumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1684/#review8626 --- Ship it! Patch might need an update. So old :) - superddumont On

Re: Review Request: Large refactoring of Shindig caching functionality

2012-06-26 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3396/#review8625 --- Hi Paul. Any chance we could break this up into smaller reviews? It

Re: Review Request: Additional OAuth2 Logging Filters

2012-06-26 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5592/#review8624 --- Ship it! Ship It! - Dan Dumont On June 26, 2012, 6:50 p.m., Adam C

Re: Review Request: Add "rpctoken" url fragment to support flash transport if not available in the url metadata when generating gadget iframe url

2012-06-26 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4703/#review8623 --- Hey Henry, what's the status of this review? Committed? Not needed?

Re: Review Request: Add code to handle OpenSocial Embedded Experience data model context extension per http://docs.opensocial.org/display/OSD/More+precision+for+EE+data+model for OpenSocial 2.5

2012-06-26 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4976/#review8622 --- Hey Henry, what's the status of this review? Committed? Not needed?

Re: Review Request: Simplify the ContentRewriterFeature.Factory to reduce number of public methods to get Config object

2012-06-26 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2798/#review8621 --- Hey Henry, what's the status of this review? Committed? Not needed?

Review Request: Additional OAuth2 Logging Filters

2012-06-26 Thread Adam Clarke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5592/ --- Review request for shindig, Stanton Sievers and Brian Lillie. Description --

Re: Review Request: OAuth 2.0 service provider implementation in Apache Shindig.

2012-06-26 Thread ddumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1940/ --- (Updated June 26, 2012, 6:46 p.m.) Review request for shindig. Description ---

Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX is disabled".

2012-06-26 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5589/#review8620 --- Ship it! Ship It! - Stanton Sievers On June 26, 2012, 5:59 p.m., M

Re: Review Request: Refactor DefaultRequestPipeline to be eaiser to be overridden by breaking the long execute method to small protected methods

2012-06-26 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4706/#review8619 --- Hey Henry, what's the status of this review? Committed? Not needed?

Re: Review Request: Bug fix for openEE implementation in open-views feature and change the scrolling settings in container.url feature

2012-06-26 Thread ddumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1505/ --- (Updated June 26, 2012, 6:27 p.m.) Review request for shindig and Ryan Baxter.

Re: Review Request: Gadget URI value incorrect on rewritten URLs and on Gadget blacklist call

2012-06-26 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1692/#review8618 --- Hey Brian, what's the status of this review? Committed? Not needed?

Re: Review Request: Need to expose OAuth2 metadata to the container

2012-06-26 Thread ddumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3571/ --- (Updated June 26, 2012, 6:15 p.m.) Review request for shindig and Henry Saputra.

Re: Review Request: opensearch implementation in sample container doesn't work.

2012-06-26 Thread ddumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3528/ --- (Updated June 26, 2012, 6:12 p.m.) Review request for shindig and Dan Dumont.

Re: Review Request: SHINDIG-1678 The flash transport to support RPC for IE7 has problem with multiple gadgets in a single container

2012-06-26 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3566/#review8616 --- Hey Henry, what's the status of this review? Committed? Not needed?

Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX is disabled".

2012-06-26 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5589/#review8615 --- Ship it! Ship It! - Dan Dumont On June 26, 2012, 5:59 p.m., Matthe

Re: Review Request: Cleanup the sites and holder close flow to delegate removing iframe of the gadget wrapper element to the holder from site responsibility

2012-06-26 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4486/#review8614 --- Hey Henry, what's the status of this review? Committed? Not needed?

Re: Review Request: Fix the actions-contributions feature param by wrapping it with tag to avoid DOM parser error to follow OpenSocial 2.0 specs

2012-06-26 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4626/#review8613 --- Hey Henry, what's the status of this review? Committed? Not needed?

Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX is disabled".

2012-06-26 Thread Matthew Reiter
> On June 26, 2012, 5:51 p.m., Dan Dumont wrote: > > /trunk/features/src/main/javascript/features/core.io/io.js, line 226 > > > > > > I'm not sure that we want to throw here. > > We should probably be constructing a

Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX is disabled".

2012-06-26 Thread Matthew Reiter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5589/ --- (Updated June 26, 2012, 5:59 p.m.) Review request for shindig. Changes ---

Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX is disabled".

2012-06-26 Thread Matthew Reiter
> On June 26, 2012, 4:57 p.m., Stanton Sievers wrote: > > Do you know why the exception gets thrown when ActiveX is disabled? > > ActiveX is disabled yet ActiveXObject != 'undefined'? I didn't see any > > mention of an exception on the msdn site: > > http://blogs.msdn.com/b/ie/archive/2011/0

Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX is disabled".

2012-06-26 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5589/#review8609 --- /trunk/features/src/main/javascript/features/core.io/io.js

Re: Review Request: X-Shindig-St behaves differently when the security token is null between Firefox and WebKit browsers

2012-06-26 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5568/#review8608 --- Ship it! Committed revision 1354132. - Stanton Sievers On June 25,

Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX is disabled".

2012-06-26 Thread Matthew Reiter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5589/ --- (Updated June 26, 2012, 5:43 p.m.) Review request for shindig. Changes ---

Re: Review Request: Enhance AuthenticationServletFilter to be more easily overrideable

2012-06-26 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5539/#review8604 --- Ship it! Committed revision 1354114. - Stanton Sievers On June 23,

Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX is disabled".

2012-06-26 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5589/#review8602 --- Do you know why the exception gets thrown when ActiveX is disabled? A

Re: Horoscope gadget and the common container

2012-06-26 Thread daviesd
Ryan, Thanks for getting beta2 out there. I've integrated it into our project and it looks good. In the meantime I'm just patching our files to get around the makeRequest issue. July 6th should be good for us moving to beta3. Thanks for getting us on a timely schedule. doug On 6/26/12 8:57 A

Re: Review Request: X-Shindig-St behaves differently when the security token is null between Firefox and WebKit browsers

2012-06-26 Thread Doug Davies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5568/#review8603 --- Ship it! Ship It! - Doug Davies On June 25, 2012, 10:07 p.m., Stan

Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX is disabled".

2012-06-26 Thread Matthew Reiter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5589/ --- Review request for shindig. Description --- Code review for my proposed sol

Re: Review Request: X-Shindig-St behaves differently when the security token is null between Firefox and WebKit browsers

2012-06-26 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5568/#review8591 --- Ship it! Ship It! - Dan Dumont On June 25, 2012, 10:07 p.m., Stant

Re: Review Request: Per latest OAuth2 spec, handle 400 from refresh_token response

2012-06-26 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5330/#review8590 --- Ship it! Committed a while ago and this is in beta2. 18/Jun/12 20:10

Re: Review Request: Enhance AuthenticationServletFilter to be more easily overrideable

2012-06-26 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5539/#review8588 --- Ship it! Ship It! - Ryan Baxter On June 23, 2012, 8:02 p.m., Stant

Re: Review Request: Per latest OAuth2 spec, handle 400 from refresh_token response

2012-06-26 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5330/#review8587 --- Ship it! Ship It! - Ryan Baxter On June 1, 2012, 1:56 p.m., Adam C

Re: Review Request: X-Shindig-St behaves differently when the security token is null between Firefox and WebKit browsers

2012-06-26 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5568/#review8586 --- Ship it! Ship It! - Ryan Baxter On June 25, 2012, 10:07 p.m., Stan

[RESULT] Shindig 2.5.0-beta2 RC3 - Third Time Is A Charm

2012-06-26 Thread Ryan J Baxter
Hi, The vote has passed with the following result : +1 (binding): Paul, Ryan, Henry, Stanton +1 (non binding): None I have promoted the artifacts to the centra repo [1] and checked them in to the Apache distribution site [2]. [1] https://repository.apache.org/content/repositories/releases/org/

Re: Horoscope gadget and the common container

2012-06-26 Thread Ryan J Baxter
Doug I released 2.5.0-beta2 last night so recutting beta2 is not an option now :) Since I want to try to stick to the monthly release process we agreed upon I was planning on cutting beta3 RC1 early next week with a targeted release date of 7/6. Will that work for you? -Ryan From: davie

Re: undescribe

2012-06-26 Thread Ryan J Baxter
Please sent an email to dev-unsubscr...@shindig.apache.org to unsubscribe from the mailing list. -Ryan From: Sangil Jung To: dev@shindig.apache.org, Date: 06/25/2012 09:48 PM Subject:undescribe undescribe plz