---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4698/#review6852
---
Ship it!
LGTM
- Jesse
On 2012-04-11 16:22:00, Ryan Baxter wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3768/#review5011
---
Ship it!
LGTM
- Jesse
On 2012-02-08 20:29:31, Dan Dumont wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3695/#review4830
---
Ship it!
LGTM
I applied the patch, ran the SVN move commands and
, Henry Saputra, Ryan Baxter, li xu, Jesse
Ciancetta, and Stanton Sievers.
Summary
---
Initial review of 1st change. Allowing common container to manage container
token refreshes. Also, refresh of gadget security tokens will now wait for
valid container security token before trying
On 2011-12-23 14:36:01, Jesse Ciancetta wrote:
I'm trying to respond to the questions Dan posted with his last update but
I dont see a way to comment there -- so I guess I'll just put my comments
here... Going to copy/paste Dan's questions and respond to them inline
below
and reading this code is kind of difficult, so anything we can do to
make it more strait forward would be good.
Jesse Ciancetta wrote:
Agreed -- I think having two functions would make the implementation
simpler, which was actually another motivator for my comment about breaking
the function
, Jesse Ciancetta wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1632/
---
(Updated 2011-12-14 21:13:40)
Review request
/3180/
---
(Updated 2011-12-14 16:35:00)
Review request for shindig, Henry Saputra, Ryan Baxter, li xu, Jesse
Ciancetta, and Stanton Sievers.
Summary
---
Initial review of 1st change. Allowing common container to manage
---
On 2011-12-14 21:13:40, Jesse Ciancetta wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1632
generated e-mail. To reply, visit:
https://reviews.apache.org/r/3180/
---
(Updated 2011-12-14 16:35:00)
Review request for shindig, Ryan Baxter, li xu, Jesse Ciancetta, Henry
Saputra, and Stanton Sievers.
Summary
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1632/
---
(Updated 2011-12-14 21:13:40.309607)
Review request for shindig.
Changes
On 2011-12-08 15:24:35, Jesse Ciancetta wrote:
Sorry for being late to the review -- this is the first chance I've had to
really look this over. I have a few concerns with this approach that make
me wonder if an alternate approach might be more appropriate -- although
the alternate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3037/#review3779
---
Ship it!
LGTM
This is an interesting capability -- its too bad we
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3037/#review3739
---
Sorry for being late to the review -- this is the first chance I've
://reviews.apache.org/r/3006/
---
(Updated 2011-12-04 21:04:16)
Review request for shindig, Jesse Ciancetta and Brian Lillie.
Summary
---
After we return from doFetchConcatResources(..) we set the status in doGet.
So lets say
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3006/
---
(Updated 2011-12-04 21:04:16)
Review request for shindig, Jesse
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2950/#review3554
---
Ship it!
Nevermind my comment about the new default.domain.*
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2950/#review3543
---
http://svn.apache.org/repos/asf/shindig/trunk/config/container.js
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2616/#review3391
---
Ship it!
LGTM
- Jesse
On 2011-11-18 21:56:17, Ryan Baxter wrote:
, Jesse Ciancetta wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2824/
---
(Updated 2011-11-14 20:46:51)
Review request
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2824/
---
Review request for shindig.
Summary
---
Update the ContainerConfig stack
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2824/
---
(Updated 2011-11-14 20:46:51.179593)
Review request for shindig.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2824/#review3210
---
On 2011-11-14 20:46:51, Jesse Ciancetta wrote
On 2011-11-01 19:00:41, Jesse Ciancetta wrote:
This looks good to me, however if we're going to go this route I wouldn't
mind seeing the BlobCrypterSecurityTokenCodec changed to always expect to
get the actual token key from ContainerConfig -- and then making the code
that parses
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2648/#review2993
---
Ship it!
This looks good to me, however if we're going to go this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2475/#review2722
---
Ship it!
Found a few small items which I noted -- other than those
, Eric Woods, li xu, Jesse
Ciancetta, and Stanton Sievers.
Summary
---
Long diffs... but before I make any more progress, I want to make sure that
everyone agrees that this cleanup is sound.
Major things of note:
SecurityToken interface has token expiration built into it, yet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1632/#review2310
---
On 2011-09-28 19:36:42, Jesse Ciancetta wrote
, johnfargo, Ryan Baxter, Jesse
Ciancetta, and Stanton Sievers.
Summary
---
Sorry for the crazy diffs here. Much stuff has moved around.
This is the cleanup part of the patch, I want a few good eyes first before I
move on to the feature work.
Some highlights
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1632/
---
(Updated 2011-08-31 14:48:03.017899)
Review request for shindig.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1632/
---
(Updated 2011-08-26 15:34:00.521113)
Review request for shindig.
Changes
://reviews.apache.org/r/1563/#review1639
---
On 2011-08-17 18:13:23, Jesse Ciancetta wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1563
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1563/
---
(Updated 2011-08-25 15:32:43.908637)
Review request for shindig.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1632/
---
Review request for shindig.
Summary
---
Common container currently doesn't
On 2011-08-16 17:24:01, Henry Saputra wrote:
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.util.onload/onload.js,
line 47
https://reviews.apache.org/r/1525/diff/1/?file=32902#file32902line47
Why does the definition registerOnLoadHandler
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1563/
---
Review request for shindig.
Summary
---
Common container currently
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1564/
---
Review request for shindig.
Summary
---
Currently the common container is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1480/
---
Review request for shindig.
Summary
---
Patch to enable loading security
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1278/#review1281
---
On 2011-08-03 19:43:41, Jesse Ciancetta wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1278/
---
Review request for shindig.
Summary
---
Please make the decrypt method in
40 matches
Mail list logo
