[jira] [Commented] (STORM-1095) Tuple.getSourceGlobalStreamid() has wrong camel-case naming

2015-10-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947601#comment-14947601 ] ASF GitHub Bot commented on STORM-1095: --- GitHub user mjsax opened a pull request:

[jira] [Commented] (STORM-1095) Tuple.getSourceGlobalStreamid() has wrong camel-case naming

2015-10-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947717#comment-14947717 ] ASF GitHub Bot commented on STORM-1095: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: [STORM-1095] Tuple.getSourceGlobalStreamid() h...

2015-10-07 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/storm/pull/786#issuecomment-146361062 Just updated this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm pull request: [STORM-1095] Tuple.getSourceGlobalStreamid() h...

2015-10-07 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/786#issuecomment-146351227 @ptgoetz @mjsax In order to keep backward compatibility, I think we need to decide when to break backward compatibility. After Storm 0.9.3, seems like

[jira] [Created] (STORM-1096) UI tries to impersonate wrong user when getting topology conf for authorization, impersonation is allowed by default

2015-10-07 Thread Robert Joseph Evans (JIRA)
Robert Joseph Evans created STORM-1096: -- Summary: UI tries to impersonate wrong user when getting topology conf for authorization, impersonation is allowed by default Key: STORM-1096 URL:

[jira] [Updated] (STORM-1093) Launching Workers with resources specified in resource-aware schedulers

2015-10-07 Thread Zhuo Liu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuo Liu updated STORM-1093: Description: Currently, we have Resource Aware Scheduler (STORM-894) in nimbus, which can allocate

[jira] [Commented] (STORM-1096) UI tries to impersonate wrong user when getting topology conf for authorization, impersonation is allowed by default

2015-10-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947647#comment-14947647 ] ASF GitHub Bot commented on STORM-1096: --- GitHub user revans2 opened a pull request:

[jira] [Commented] (STORM-1096) UI tries to impersonate wrong user when getting topology conf for authorization, impersonation is allowed by default

2015-10-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947648#comment-14947648 ] ASF GitHub Bot commented on STORM-1096: --- GitHub user revans2 opened a pull request:

[jira] [Commented] (STORM-1095) Tuple.getSourceGlobalStreamid() has wrong camel-case naming

2015-10-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947646#comment-14947646 ] ASF GitHub Bot commented on STORM-1095: --- Github user ptgoetz commented on the pull request:

[GitHub] storm pull request: STORM-1096: Fix some issues with impersonation...

2015-10-07 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/787 STORM-1096: Fix some issues with impersonation on the UI Conflicts: storm-core/src/clj/backtype/storm/ui/core.clj You can merge this pull request into a Git repository by running: $ git

[GitHub] storm pull request: [STORM-1095] Tuple.getSourceGlobalStreamid() h...

2015-10-07 Thread mjsax
GitHub user mjsax opened a pull request: https://github.com/apache/storm/pull/786 [STORM-1095] Tuple.getSourceGlobalStreamid() has wrong camel-case naming You can merge this pull request into a Git repository by running: $ git pull https://github.com/mjsax/storm storm-1095

[jira] [Updated] (STORM-1093) Launching Workers with resources specified in resource-aware schedulers

2015-10-07 Thread Zhuo Liu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuo Liu updated STORM-1093: Description: Currently, we have Resource Aware Scheduler (STORM-894) in nimbus, which can allocate

[jira] [Updated] (STORM-1093) Launching Workers with resources specified in resource-aware schedulers

2015-10-07 Thread Zhuo Liu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuo Liu updated STORM-1093: Description: Currently, we have Resource Aware Scheduler (STORM-894) in nimbus, which can allocate

[jira] [Updated] (STORM-1093) Launching Workers with resources specified in resource-aware schedulers

2015-10-07 Thread Zhuo Liu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuo Liu updated STORM-1093: Description: Currently, we have Resource Aware Scheduler (STORM-894) in nimbus, which can allocate

[jira] [Updated] (STORM-1093) Launching Workers with resources specified in resource-aware schedulers

2015-10-07 Thread Zhuo Liu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuo Liu updated STORM-1093: Description: Currently, we have Resource Aware Scheduler (STORM-894) in nimbus, which can allocate

[jira] [Commented] (STORM-1095) Tuple.getSourceGlobalStreamid() has wrong camel-case naming

2015-10-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947773#comment-14947773 ] ASF GitHub Bot commented on STORM-1095: --- Github user mjsax commented on the pull request:

[jira] [Updated] (STORM-1093) Launching Workers with resources specified in resource-aware schedulers

2015-10-07 Thread Zhuo Liu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuo Liu updated STORM-1093: Description: Currently, we have Resource Aware Scheduler (STORM-894) in nimbus, which can allocate

[GitHub] storm pull request: [STORM-1095] Tuple.getSourceGlobalStreamid() h...

2015-10-07 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/786#issuecomment-146341025 Should we consider overloading and deprecating vs. renaming to preserve backwards compatibility for the short term? --- If your project is set up for it, you can reply

[GitHub] storm pull request: STORM-1096: Fix some issues with impersonation...

2015-10-07 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/788 STORM-1096: Fix some issues with impersonation on the UI You can merge this pull request into a Git repository by running: $ git pull https://github.com/revans2/incubator-storm STORM-1096

[GitHub] storm pull request: [STORM-1095] Tuple.getSourceGlobalStreamid() h...

2015-10-07 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/storm/pull/786#issuecomment-146343033 It's up to you. I had this issues in mind, too... API breaking changes might be inconvenient/problematic. Just let me know your decision. --- If your project is set up

[jira] [Commented] (STORM-1095) Tuple.getSourceGlobalStreamid() has wrong camel-case naming

2015-10-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947662#comment-14947662 ] ASF GitHub Bot commented on STORM-1095: --- Github user mjsax commented on the pull request:

[jira] [Commented] (STORM-1080) Compiler SQL literals to LLVM constants

2015-10-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14946452#comment-14946452 ] ASF GitHub Bot commented on STORM-1080: --- Github user asfgit closed the pull request at:

[GitHub] storm pull request: STORM-1080. Compiler SQL literals to LLVM cons...

2015-10-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/778 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: add cgroup function that can limit cpu share o...

2015-10-07 Thread caishize
Github user caishize commented on the pull request: https://github.com/apache/storm/pull/667#issuecomment-146106627 Yes,there's an update haven't been submitted, but it still only works on an Linux operating system which has the cgroup installed.. Sent from my iPhone

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-10-07 Thread erikdw
Github user erikdw commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r41366483 --- Diff: storm-core/src/jvm/backtype/storm/networktopography/DNSToSwitchMapping.java --- @@ -0,0 +1,50 @@ +/** + * Licensed to the Apache Software

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-10-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14946537#comment-14946537 ] ASF GitHub Bot commented on STORM-893: -- Github user erikdw commented on a diff in the pull request:

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-10-07 Thread erikdw
Github user erikdw commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r41366160 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/IStrategy.java --- @@ -0,0 +1,37 @@ +/** + * Licensed to the Apache Software

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-10-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14946528#comment-14946528 ] ASF GitHub Bot commented on STORM-893: -- Github user erikdw commented on a diff in the pull request:

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-10-07 Thread erikdw
Github user erikdw commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r41366711 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/Cluster.java --- @@ -438,6 +451,35 @@ public SupervisorDetails getSupervisorById(String nodeId) {

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-10-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14946544#comment-14946544 ] ASF GitHub Bot commented on STORM-893: -- Github user erikdw commented on a diff in the pull request:

[jira] [Commented] (STORM-718) Ip Clearence for JStorm related contributions

2015-10-07 Thread Eee Wang (JIRA)
[ https://issues.apache.org/jira/browse/STORM-718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14946531#comment-14946531 ] Eee Wang commented on STORM-718: seems that storm.taobao.org has a zk error which causes the cluster page

[jira] [Updated] (STORM-1015) Store Kafka offsets with Kafka's consumer offset management api

2015-10-07 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated STORM-1015: -- Assignee: Hang Sun > Store Kafka offsets with Kafka's consumer offset

[jira] [Updated] (STORM-825) As a storm developer I’d like consistent, structured exception handling

2015-10-07 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated STORM-825: - Assignee: Hugo Louro > As a storm developer I’d like consistent, structured

[jira] [Updated] (STORM-824) As a storm developer I’d like all loggers to be private

2015-10-07 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated STORM-824: - Assignee: Hugo Louro > As a storm developer I’d like all loggers to be private >

[jira] [Updated] (STORM-650) Storm-Kafka Refactoring and Improvements

2015-10-07 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated STORM-650: - Assignee: Hugo Louro > Storm-Kafka Refactoring and Improvements >

[jira] [Commented] (STORM-822) As a storm developer I’d like to use the new kafka consumer API (0.8.3) to reduce dependencies and use long term supported kafka apis

2015-10-07 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14948022#comment-14948022 ] Sriharsha Chintalapani commented on STORM-822: -- hi [~wurstmeister] , are you actively working

[jira] [Updated] (STORM-823) As a storm developer I’d like to use ITuple interface consistently to avoid duplication

2015-10-07 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated STORM-823: - Assignee: Hugo Louro > As a storm developer I’d like to use ITuple interface

[jira] [Created] (STORM-1095) Tuple.getSourceGlobalStreamid() has wrong camel-case naming

2015-10-07 Thread Matthias J. Sax (JIRA)
Matthias J. Sax created STORM-1095: -- Summary: Tuple.getSourceGlobalStreamid() has wrong camel-case naming Key: STORM-1095 URL: https://issues.apache.org/jira/browse/STORM-1095 Project: Apache Storm

[jira] [Created] (STORM-1092) Writing issue on https://storm.apache.org/about/fault-tolerant.html

2015-10-07 Thread NickXu (JIRA)
NickXu created STORM-1092: - Summary: Writing issue on https://storm.apache.org/about/fault-tolerant.html Key: STORM-1092 URL: https://issues.apache.org/jira/browse/STORM-1092 Project: Apache Storm

[GitHub] storm pull request: advance kafka offset when deserializer yields ...

2015-10-07 Thread Crim
Github user Crim commented on the pull request: https://github.com/apache/storm/pull/758#issuecomment-146187081 +1 running into this issue as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (STORM-1084) Improve Storm config validation process to use java annotations instead of *_SCHEMA format

2015-10-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14946972#comment-14946972 ] ASF GitHub Bot commented on STORM-1084: --- Github user jerrypeng commented on a diff in the pull

[GitHub] storm pull request: [STORM-1084] - Improve Storm config validation...

2015-10-07 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/785#discussion_r41399786 --- Diff: storm-core/src/jvm/backtype/storm/validation/ConfigValidation.java --- @@ -0,0 +1,359 @@ +package backtype.storm.validation; + +import

[GitHub] storm pull request: [STORM-1084] - Improve Storm config validation...

2015-10-07 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/785#discussion_r41397418 --- Diff: storm-core/src/jvm/backtype/storm/validation/ConfigValidation.java --- @@ -0,0 +1,359 @@ +package backtype.storm.validation; --- End diff --

[jira] [Commented] (STORM-1084) Improve Storm config validation process to use java annotations instead of *_SCHEMA format

2015-10-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14946944#comment-14946944 ] ASF GitHub Bot commented on STORM-1084: --- Github user revans2 commented on a diff in the pull

[jira] [Commented] (STORM-1084) Improve Storm config validation process to use java annotations instead of *_SCHEMA format

2015-10-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14946968#comment-14946968 ] ASF GitHub Bot commented on STORM-1084: --- Github user jerrypeng commented on a diff in the pull

[GitHub] storm pull request: [STORM-1084] - Improve Storm config validation...

2015-10-07 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/785#discussion_r41399571 --- Diff: storm-core/src/jvm/backtype/storm/validation/ConfigValidation.java --- @@ -0,0 +1,359 @@ +package backtype.storm.validation; --- End diff

[jira] [Updated] (STORM-1093) Launching Workers with resources specified in resource-aware schedulers

2015-10-07 Thread Zhuo Liu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuo Liu updated STORM-1093: Description: Currently, we have Resource Aware Scheduler (STORM-894) in nimbus, which can allocate

[jira] [Commented] (STORM-1084) Improve Storm config validation process to use java annotations instead of *_SCHEMA format

2015-10-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14946946#comment-14946946 ] ASF GitHub Bot commented on STORM-1084: --- Github user revans2 commented on a diff in the pull

[jira] [Updated] (STORM-1093) Launching Workers with resources specified in resource-aware schedulers

2015-10-07 Thread Zhuo Liu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuo Liu updated STORM-1093: Description: Currently, we have Resource Aware Scheduler (STORM-894) in nimbus, which can allocate

[jira] [Updated] (STORM-1093) Launching Workers with resources specified in resource-aware schedulers

2015-10-07 Thread Zhuo Liu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuo Liu updated STORM-1093: Description: Currently, we have Resource Aware Scheduler (STORM-894) in nimbus, which can allocate

[GitHub] storm pull request: advance kafka offset when deserializer yields ...

2015-10-07 Thread prokopowicz
Github user prokopowicz commented on the pull request: https://github.com/apache/storm/pull/758#issuecomment-146227524 I issued this JIRA regarding the bug: https://issues.apache.org/jira/browse/STORM-1094 On Tue, Oct 6, 2015 at 3:40 PM, Jungtaek Lim

[jira] [Created] (STORM-1094) kafka offset does not advance when deserializer yields no object

2015-10-07 Thread Pete Prokopowicz (JIRA)
Pete Prokopowicz created STORM-1094: --- Summary: kafka offset does not advance when deserializer yields no object Key: STORM-1094 URL: https://issues.apache.org/jira/browse/STORM-1094 Project:

[jira] [Commented] (STORM-1094) kafka offset does not advance when deserializer yields no object

2015-10-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947006#comment-14947006 ] ASF GitHub Bot commented on STORM-1094: --- Github user prokopowicz commented on the pull request:

[jira] [Commented] (STORM-1084) Improve Storm config validation process to use java annotations instead of *_SCHEMA format

2015-10-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947251#comment-14947251 ] ASF GitHub Bot commented on STORM-1084: --- Github user jerrypeng commented on the pull request:

[GitHub] storm pull request: [STORM-1084] - Improve Storm config validation...

2015-10-07 Thread jerrypeng
Github user jerrypeng commented on the pull request: https://github.com/apache/storm/pull/785#issuecomment-146272172 @revans2 your suggestion are great, but the parameters passed into java annotations have to declared to be a specific type thus we could not have:

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-10-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947098#comment-14947098 ] ASF GitHub Bot commented on STORM-893: -- Github user jerrypeng commented on a diff in the pull request:

[jira] [Commented] (STORM-1084) Improve Storm config validation process to use java annotations instead of *_SCHEMA format

2015-10-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947135#comment-14947135 ] ASF GitHub Bot commented on STORM-1084: --- Github user revans2 commented on the pull request:

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-10-07 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r41412262 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/Cluster.java --- @@ -438,6 +451,35 @@ public SupervisorDetails getSupervisorById(String nodeId) {

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-10-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947147#comment-14947147 ] ASF GitHub Bot commented on STORM-893: -- Github user jerrypeng commented on a diff in the pull request:

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-10-07 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r41409816 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/IStrategy.java --- @@ -0,0 +1,37 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-10-07 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r41410090 --- Diff: storm-core/src/jvm/backtype/storm/networktopography/DNSToSwitchMapping.java --- @@ -0,0 +1,50 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request: [STORM-1084] - Improve Storm config validation...

2015-10-07 Thread jerrypeng
Github user jerrypeng commented on the pull request: https://github.com/apache/storm/pull/785#issuecomment-146248606 Well for some for annotations I call a common validator and just pass in the type that needs to be validated, such as @String @Boolean validators. --- If your

[jira] [Commented] (STORM-1084) Improve Storm config validation process to use java annotations instead of *_SCHEMA format

2015-10-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947123#comment-14947123 ] ASF GitHub Bot commented on STORM-1084: --- Github user jerrypeng commented on the pull request:

[GitHub] storm pull request: [STORM-1084] - Improve Storm config validation...

2015-10-07 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/785#issuecomment-146249930 Could we use nested annotations for the complex types? https://blogs.oracle.com/toddfast/entry/creating_nested_complex_java_annotations ```

[jira] [Commented] (STORM-1084) Improve Storm config validation process to use java annotations instead of *_SCHEMA format

2015-10-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947130#comment-14947130 ] ASF GitHub Bot commented on STORM-1084: --- Github user revans2 commented on the pull request:

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-10-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947101#comment-14947101 ] ASF GitHub Bot commented on STORM-893: -- Github user jerrypeng commented on a diff in the pull request:

[GitHub] storm pull request: [STORM-1084] - Improve Storm config validation...

2015-10-07 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/785#issuecomment-146246638 @jerrypeng I keep going back and forth on how we want the annotations to work. Right now they are more or less a one to one translation of what we had before.

[jira] [Commented] (STORM-1084) Improve Storm config validation process to use java annotations instead of *_SCHEMA format

2015-10-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947104#comment-14947104 ] ASF GitHub Bot commented on STORM-1084: --- Github user revans2 commented on the pull request:

[GitHub] storm pull request: [STORM-1084] - Improve Storm config validation...

2015-10-07 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/785#issuecomment-146250340 @jerrypeng I agree that we want a base set of annotations, and we can adjust what they do. I am just concerned about making that base set as flexible and complete as

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-10-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947229#comment-14947229 ] ASF GitHub Bot commented on STORM-893: -- Github user jerrypeng commented on the pull request:

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-10-07 Thread jerrypeng
Github user jerrypeng commented on the pull request: https://github.com/apache/storm/pull/746#issuecomment-146266179 @erikdw thank you for your review. I reformated some of the files based on your suggestions --- If your project is set up for it, you can reply to this email and