Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2465
@srdo I am working on making unit tests pass and then will squash and
create master PR. Can you take another look in the meantime. Thanks.
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157350411
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -225,6 +237,23 @@ private long doSeek(TopicPartition tp
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2465
@hmcl Great, thanks.
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157350384
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -225,6 +237,23 @@ private long doSeek(TopicPartition tp
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2465
@srdo I created the PR here because some topologies with latest master were
not working for me and I worked off 1.x-branch to be able to make progress. I
will submit a PR for master as well.
---
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157349870
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutRetryExponentialBackoff.java
---
@@ -290,8 +291,8 @@ public int read
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157349862
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -399,14 +429,16 @@ private void emitIfWaitingNotEmitted
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157349864
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutMessageId.java
---
@@ -18,36 +18,88 @@
package org.apache
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157349857
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -225,6 +237,23 @@ private long doSeek(TopicPartition tp
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157349852
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -225,6 +237,23 @@ private long doSeek(TopicPartition tp
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2465
@hmcl I don't know that there's a hard rule that it has to be that way, but
it seems like a good way to me to ensure that master is the "most fixed"/best
state of the code. It's been done this way in th
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157349435
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutRetryExponentialBackoff.java
---
@@ -290,8 +291,8 @@ public int read
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157349402
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -225,6 +237,23 @@ private long doSeek(TopicPartition tp
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157349371
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -225,6 +237,23 @@ private long doSeek(TopicPartition tp
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2465
@srdo I plan on submitting a patch to master, but why does the patch need
to go on master first? For example, there could be bugs in 1.x that no longer
exist in master because of other changes, and in t
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157347438
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -225,6 +237,23 @@ private long doSeek(TopicPartition tp
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157347412
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutRebalanceTest.java
---
@@ -181,16 +181,16 @@ public void
spoutMustI
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157347380
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutRetryExponentialBackoff.java
---
@@ -290,8 +291,8 @@ public int read
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157347281
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -225,6 +237,23 @@ private long doSeek(TopicPartition tp
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157346946
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutRebalanceTest.java
---
@@ -181,16 +181,16 @@ public void
spoutMustI
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157346877
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -225,6 +237,23 @@ private long doSeek(TopicPartition tp
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157346366
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -225,6 +237,23 @@ private long doSeek(TopicPartition tp
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157346574
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutMessageId.java
---
@@ -18,36 +18,88 @@
package org.apache
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157346484
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -399,14 +429,16 @@ private void emitIfWaitingNotEmitted
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157346634
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutMessageId.java
---
@@ -18,36 +18,88 @@
package org.apache
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157346294
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -225,6 +237,23 @@ private long doSeek(TopicPartition tp
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157346509
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutRetryExponentialBackoff.java
---
@@ -290,8 +291,8 @@ public int read
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157346228
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -225,6 +237,23 @@ private long doSeek(TopicPartition tp
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2465
@srdo can you please do a first pass review. In the meantime I will address
the 2 or 3 TODO with minor cleanups. The following tests are also failing. I am
working on fixing them, but if you know from t
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/2465
STORM-2844: KafkaSpout Throws IllegalStateException After Committing to
Kafka When First Poll Strategy Set to EARLIEST
- Serialize KafkaSpoutMessageId to JSON and add it as part of
OffsetAndMeta
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2454
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2454
Thanks for reviewing.
---
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2464
STORM-2847 1.x
1.x for https://github.com/apache/storm/pull/2454
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/storm STORM-2847-1.x
Alternat
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2460
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2453
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2453
Thanks for the reviews.
---
36 matches
Mail list logo
