Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50896559
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Time.java ---
@@ -102,6 +102,14 @@ public static long currentTimeMillis() {
public static int
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50896659
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -530,6 +559,10 @@ private static boolean
downloadResourcesAsSupervisorAttempt
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50896874
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50897000
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50897241
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50897502
--- Diff: storm-core/src/clj/org/apache/storm/util.clj ---
@@ -48,21 +48,21 @@
(:require [ring.util.codec :as codec])
(:use [org.apache.storm
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50897886
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50898011
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50897100
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50898231
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50898272
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50898419
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50898350
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50898579
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50898645
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50898732
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50899023
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50899194
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50899355
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50899281
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50900303
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50900498
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50901067
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50900760
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50902361
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1050,6 +1083,12 @@ public String getBackupConnectionString() throws
Exception
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50902614
--- Diff: storm-core/test/clj/org/apache/storm/logviewer_test.clj ---
@@ -360,23 +367,24 @@
;; match.
exp-offset-fn #(- (/ logviewer
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50903820
--- Diff: storm-core/test/clj/org/apache/storm/supervisor_test.clj ---
@@ -545,13 +569,14 @@
(stubbing [uptime-computer nil
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1043#issuecomment-175242193
Finished with my first pass through the code. For the most part things are
looking very good.
---
If your project is set up for it, you can reply to this email and
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1049#issuecomment-175263760
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1047#discussion_r50989965
--- Diff: storm-core/test/jvm/org/apache/storm/blobstore/BlobStoreTest.java
---
@@ -1,3 +1,4 @@
+
--- End diff --
Not sure about this one
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1047#discussion_r50989943
--- Diff: storm-core/test/clj/org/apache/storm/nimbus_test.clj ---
@@ -30,6 +30,7 @@
(:import [java.util HashMap])
(:import [java.io File
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1047#discussion_r50990747
--- Diff: storm-core/test/clj/org/apache/storm/cluster_test.clj ---
@@ -308,11 +309,11 @@
(deftest test-cluster-state-default-acls
(testing
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1047#discussion_r50990989
--- Diff: storm-core/test/clj/org/apache/storm/cluster_test.clj ---
@@ -308,11 +309,11 @@
(deftest test-cluster-state-default-acls
(testing
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1047#discussion_r50992981
--- Diff: storm-core/src/clj/org/apache/storm/testing.clj ---
@@ -288,11 +289,11 @@
(defmacro with-inprocess-zookeeper
[port-sym &
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1047#discussion_r50993291
--- Diff: storm-core/src/clj/org/apache/storm/testing.clj ---
@@ -134,7 +135,7 @@
(defnk mk-local-storm-cluster [:supervisors 2 :ports-per-supervisor 3
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1047#discussion_r50994203
--- Diff: storm-core/test/clj/org/apache/storm/nimbus_test.clj ---
@@ -30,6 +30,7 @@
(:import [java.util HashMap])
(:import [java.io File
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1047#discussion_r50994369
--- Diff: storm-core/test/clj/org/apache/storm/nimbus_test.clj ---
@@ -30,6 +30,7 @@
(:import [java.util HashMap])
(:import [java.io File
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1047#discussion_r50997086
--- Diff: storm-core/src/clj/org/apache/storm/zookeeper.clj ---
@@ -57,15 +46,15 @@
:auth-conf nil]
(let [fk (Utils/newCurator conf servers
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1047#issuecomment-175689962
Even with all of those changes to make the tests compile I am seeing test
failures. Please make sure that
```
mvn clean -Prat -Pall-test integration-test
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1052#discussion_r51045767
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/common/AvroGenericSerializer.java
---
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1051#issuecomment-176204284
@hustfxj, I probably was not clear enough in my review comments that
spawned this JIRA. I was thinking along the lines of @HeartSaVioR. Once the
majority of the code
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1052#discussion_r51127995
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/common/AvroGenericSerializer.java
---
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1053#issuecomment-176227654
Rat is complaining about some of your files not having the correct license.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51133599
--- Diff: conf/defaults.yaml ---
@@ -281,3 +281,16 @@ pacemaker.thread.timeout: 10
pacemaker.childopts: "-Xmx1024m"
pacemaker.auth.met
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51133883
--- Diff: storm-core/src/clj/org/apache/storm/util.clj ---
@@ -541,6 +541,7 @@
(.redirectErrorStream builder true)
(doseq [[k v] environment
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51133971
--- Diff: storm-core/src/jvm/org/apache/storm/Config.java ---
@@ -2359,4 +2417,24 @@ public void setTopologyStrategy(Class clazz) {
this.put
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51134075
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,238 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1038#discussion_r51133208
--- Diff:
external/storm-mongodb/src/main/java/org/apache/storm/mongodb/trident/state/MongoState.java
---
@@ -0,0 +1,97 @@
+/**
+ * Licensed to the
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51134290
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,238 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51134812
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,238 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51134752
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,238 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51134861
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,238 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51135122
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,238 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51135424
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,238 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1054#discussion_r51135789
--- Diff: documentation/cgroups_in_storm.md ---
@@ -0,0 +1,61 @@
+# CGroups in Storm
+
+CGroups are used by Storm to limit the resource usage of
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1054#discussion_r51136522
--- Diff: documentation/cgroups_in_storm.md ---
@@ -0,0 +1,61 @@
+# CGroups in Storm
+
+CGroups are used by Storm to limit the resource usage of
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51138519
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCommonOperation.java
---
@@ -0,0 +1,47 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51138697
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupUtils.java ---
@@ -0,0 +1,174 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51139248
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupUtils.java ---
@@ -0,0 +1,174 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51140226
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupUtils.java ---
@@ -0,0 +1,174 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51145886
--- Diff: storm-core/test/jvm/org/apache/storm/TestCGroup.java ---
@@ -0,0 +1,94 @@
+package org.apache.storm;
--- End diff --
Needs Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51145929
--- Diff: storm-core/test/jvm/org/apache/storm/TestCGroup.java ---
@@ -0,0 +1,94 @@
+package org.apache.storm;
+
+import org.junit.Assert
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1047#discussion_r51168731
--- Diff: storm-core/test/clj/org/apache/storm/cluster_test.clj ---
@@ -308,11 +309,11 @@
(deftest test-cluster-state-default-acls
(testing
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1047#discussion_r51174346
--- Diff: storm-core/test/clj/org/apache/storm/cluster_test.clj ---
@@ -308,11 +309,11 @@
(deftest test-cluster-state-default-acls
(testing
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1047#issuecomment-176777482
The changes look good to me now and I am +1 on merging them in.
But because I helped contribute some of the code I want at least one other
committer to also
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1056#discussion_r51264908
--- Diff: external/storm-kafka/src/jvm/storm/kafka/KafkaSpout.java ---
@@ -78,9 +82,11 @@ public void open(Map conf, final TopologyContext
context, final
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1056#discussion_r51265457
--- Diff: external/storm-kafka/src/jvm/storm/kafka/ZkState.java ---
@@ -33,20 +32,29 @@
import java.util.Map;
public class ZkState
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1056#discussion_r51266910
--- Diff:
external/storm-kafka/src/test/storm/kafka/KafkaTopologySpoutTestClient.java ---
@@ -0,0 +1,106 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1055#issuecomment-176786634
Please upmerge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1055#discussion_r51267736
--- Diff:
examples/storm-starter/src/clj/org/apache/storm/starter/clj/word_count.clj ---
@@ -60,18 +61,22 @@
(defn mk-topology
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1055#discussion_r51267758
--- Diff: storm-core/src/clj/org/apache/storm/clojure.clj ---
@@ -16,7 +16,7 @@
(ns org.apache.storm.clojure
(:use [org.apache.storm util
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1055#discussion_r51269204
--- Diff: storm-core/src/jvm/org/apache/storm/Thrift.java ---
@@ -0,0 +1,343 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1055#discussion_r51269024
--- Diff: storm-core/src/jvm/org/apache/storm/Thrift.java ---
@@ -0,0 +1,343 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1038#issuecomment-176802552
+1 the changes look good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51286347
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupManager.java ---
@@ -0,0 +1,176 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1047#discussion_r51290582
--- Diff: storm-core/src/clj/org/apache/storm/testing.clj ---
@@ -288,11 +289,11 @@
(defmacro with-inprocess-zookeeper
[port-sym &
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1047#issuecomment-177268238
A line of white space is simple enough for me to do as I check it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1039#issuecomment-177273828
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/1059
STORM-1242: migrate backtype.storm.command.config-value to java
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1057#issuecomment-177287696
+1, this is an issue with 1.x too
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1052#discussion_r51350285
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/avro/AvroUtils.java ---
@@ -0,0 +1,18 @@
+package org.apache.storm.hdfs.avro
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1052#discussion_r51350300
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/avro/ConfluentAvroSerializer.java
---
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1052#discussion_r51350311
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/avro/ConfluentAvroSerializer.java
---
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1052#issuecomment-177294606
Done with a first pass. You need to upmerge. We have moved to
org.apache.storm from backtype.storm and the CI is failing because of it.
---
If your project is set up
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1052#discussion_r51475643
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/AvroGenericRecordBolt.java
---
@@ -17,8 +17,9 @@
*/
package
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1052#issuecomment-178174157
The build is complaining that
`external/storm-hdfs/src/test/resources/FixedAvroSerializer.config` does not
have an apache license header in it.
Because it
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1031#issuecomment-178618849
+1 the change looks fine to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1031#issuecomment-178624815
@mjsax is there a JIRA associated with this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1052#issuecomment-178637591
@dossett
storm-starter failed the same way in travis for both JDK8 and JDK7
something odd with logging. I will try to reproduce it and see if it is just a
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1052#issuecomment-178645013
@dossett yes I have been able to reproduce the error, and it appears to
somehow be related to this pull request.
```
mvn clean install -DskipTests
cd
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1052#issuecomment-178649925
@dossett I did a difference for running mvn dependency:tree between master
and this pull just in storm starter and this is what showed up.
```
-[INFO
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1055#discussion_r51587377
--- Diff: storm-clojure/src/main/clj/org.apache.storm/clojure.clj ---
@@ -0,0 +1,201 @@
+;; Licensed to the Apache Software Foundation (ASF) under one
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1055#discussion_r51587449
--- Diff: storm-clojure/src/main/clj/org.apache.storm/thrift.clj ---
@@ -38,6 +38,7 @@
args (map (memfn getFieldValue) (.get_args_list obj
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1055#discussion_r51588295
--- Diff: storm-core/src/clj/org/apache/storm/internal/thrift.clj ---
@@ -0,0 +1,291 @@
+;; Licensed to the Apache Software Foundation (ASF) under one
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1055#discussion_r51593940
--- Diff: storm-core/src/clj/org/apache/storm/internal/thrift.clj ---
@@ -0,0 +1,291 @@
+;; Licensed to the Apache Software Foundation (ASF) under one
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1055#discussion_r51601967
--- Diff: storm-core/src/jvm/org/apache/storm/Thrift.java ---
@@ -0,0 +1,351 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1055#discussion_r51603260
--- Diff: storm-core/src/clj/org/apache/storm/internal/thrift.clj ---
@@ -0,0 +1,291 @@
+;; Licensed to the Apache Software Foundation (ASF) under one
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1055#discussion_r51604477
--- Diff: storm-core/src/jvm/org/apache/storm/Thrift.java ---
@@ -0,0 +1,351 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1055#discussion_r51604676
--- Diff: storm-core/src/jvm/org/apache/storm/Thrift.java ---
@@ -0,0 +1,351 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1055#discussion_r51604769
--- Diff: storm-core/src/clj/org/apache/storm/internal/thrift.clj ---
@@ -0,0 +1,291 @@
+;; Licensed to the Apache Software Foundation (ASF) under one
401 - 500 of 1957 matches
Mail list logo
