GitHub user rfarivar opened a pull request:
https://github.com/apache/storm/pull/1043
Storm 1226
This is translating util.clj into java functions mostly in
utils/Utils.java.
Translation is half way done, passing all unit tests. Putting the pull
request up to get reviews.
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50743788
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asU
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50745533
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asU
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50748875
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asU
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50748974
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asU
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50749149
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asU
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50749227
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asU
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50750102
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asU
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50750687
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asU
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50752006
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asU
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50752250
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asU
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50752527
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asU
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50753665
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asU
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50753833
--- Diff: storm-core/test/clj/org/apache/storm/nimbus_test.clj ---
@@ -352,6 +372,7 @@
(is (= 2 (storm-num-workers state "mystorm"))) ;; because onl
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50754051
--- Diff: storm-core/test/clj/org/apache/storm/nimbus_test.clj ---
@@ -1198,21 +1220,23 @@
(let [expected-name topology-name
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50754345
--- Diff: storm-core/test/clj/org/apache/storm/security/auth/auth_test.clj
---
@@ -14,27 +14,28 @@
;; See the License for the specific language governing
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50754397
--- Diff:
storm-core/test/clj/org/apache/storm/security/serialization/BlowfishTupleSerializer_test.clj
---
@@ -15,7 +15,7 @@
;; limitations under the Li
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50754732
--- Diff: storm-core/src/clj/org/apache/storm/util.clj ---
@@ -48,21 +48,21 @@
(:require [ring.util.codec :as codec])
(:use [org.apache.storm log
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1043#issuecomment-175205323
First off RAT is complaining about 3 files. Please take a look into that.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50893250
--- Diff:
storm-core/src/clj/org/apache/storm/cluster_state/zookeeper_state_factory.clj
---
@@ -90,7 +91,7 @@
(if (zk/exists zk-writer path false
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50893638
--- Diff: storm-core/src/clj/org/apache/storm/config.clj ---
@@ -91,25 +91,25 @@
(let [storm-home (System/getProperty "storm.home")
path (c
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50893784
--- Diff: storm-core/src/clj/org/apache/storm/converter.clj ---
@@ -80,6 +83,17 @@
(fn [list-of-executors]
(into [] list-of-executo
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50893744
--- Diff: storm-core/src/clj/org/apache/storm/converter.clj ---
@@ -71,6 +72,8 @@
(:worker->res
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50893895
--- Diff: storm-core/src/clj/org/apache/storm/converter.clj ---
@@ -131,6 +151,9 @@
(if (:num-workers rebalance-options)
(.set_num_work
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50893939
--- Diff: storm-core/src/clj/org/apache/storm/converter.clj ---
@@ -178,18 +201,25 @@
(.set_enable (get options :enable false))
(.set_samplin
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50893972
--- Diff: storm-core/src/clj/org/apache/storm/converter.clj ---
@@ -201,17 +231,28 @@
(.get_owner storm-base)
(clojurify-topology-action-
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50893958
--- Diff: storm-core/src/clj/org/apache/storm/converter.clj ---
@@ -201,17 +231,28 @@
(.get_owner storm-base)
(clojurify-topology-action-
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50894007
--- Diff: storm-core/src/clj/org/apache/storm/converter.clj ---
@@ -201,17 +231,28 @@
(.get_owner storm-base)
(clojurify-topology-action-
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50894044
--- Diff: storm-core/src/clj/org/apache/storm/converter.clj ---
@@ -201,17 +231,28 @@
(.get_owner storm-base)
(clojurify-topology-action-
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50894025
--- Diff: storm-core/src/clj/org/apache/storm/converter.clj ---
@@ -201,17 +231,28 @@
(.get_owner storm-base)
(clojurify-topology-action-
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50894663
--- Diff: storm-core/src/clj/org/apache/storm/local_state.clj ---
@@ -104,17 +105,24 @@
(->executor-list (.get_executors thrift-local-assignment))
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50894670
--- Diff: storm-core/src/clj/org/apache/storm/local_state.clj ---
@@ -104,17 +105,24 @@
(->executor-list (.get_executors thrift-local-assignment))
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50894778
--- Diff:
storm-core/src/clj/org/apache/storm/scheduler/IsolationScheduler.clj ---
@@ -41,6 +51,7 @@
(map vector (repeat-seq (range (.getNumWorker
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50894857
--- Diff: storm-core/src/clj/org/apache/storm/stats.clj ---
@@ -702,11 +713,16 @@
:acked (sum-or-0 (:acked acc-spout-stats) (:acked spout-stats))
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50895014
--- Diff: storm-core/src/clj/org/apache/storm/testing.clj ---
@@ -519,10 +556,12 @@
;; TODO: the idea of mocking for transactional topologies should be
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50895133
--- Diff: storm-core/src/clj/org/apache/storm/util.clj ---
@@ -48,21 +48,21 @@
(:require [ring.util.codec :as codec])
(:use [org.apache.storm log
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50895476
--- Diff: storm-core/src/jvm/org/apache/storm/utils/IFn.java ---
@@ -0,0 +1,8 @@
+package org.apache.storm.utils;
+
+/**
+ * Created by rfariva
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50895500
--- Diff: storm-core/src/jvm/org/apache/storm/utils/IPredicate.java ---
@@ -0,0 +1,8 @@
+package org.apache.storm.utils;
--- End diff --
Apach
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50896029
--- Diff: storm-core/src/jvm/org/apache/storm/utils/IPredicate.java ---
@@ -0,0 +1,8 @@
+package org.apache.storm.utils;
+
+/**
+ * Created by
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50896065
--- Diff: storm-core/src/jvm/org/apache/storm/utils/StaticMockable.java ---
@@ -0,0 +1,6 @@
+package org.apache.storm.utils;
--- End diff --
A
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50896559
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Time.java ---
@@ -102,6 +102,14 @@ public static long currentTimeMillis() {
public static int curr
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50896659
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -530,6 +559,10 @@ private static boolean
downloadResourcesAsSupervisorAttempt(ClientBlob
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50896874
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asUs
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50897000
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asUs
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50897241
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asUs
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50897502
--- Diff: storm-core/src/clj/org/apache/storm/util.clj ---
@@ -48,21 +48,21 @@
(:require [ring.util.codec :as codec])
(:use [org.apache.storm log
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50897886
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asUs
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50898011
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asUs
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50897100
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asUs
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50898231
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asUs
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50898272
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asUs
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50898419
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asUs
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50898350
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asUs
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50898579
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asUs
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50898645
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asUs
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50898732
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asUs
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50899023
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asUs
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50899194
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asUs
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50899355
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asUs
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50899281
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asUs
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50900303
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asUs
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50900498
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asUs
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50901067
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asUs
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50900760
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asUs
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50902361
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1050,6 +1083,12 @@ public String getBackupConnectionString() throws
Exception {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50902614
--- Diff: storm-core/test/clj/org/apache/storm/logviewer_test.clj ---
@@ -360,23 +367,24 @@
;; match.
exp-offset-fn #(- (/ logviewer/
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50903820
--- Diff: storm-core/test/clj/org/apache/storm/supervisor_test.clj ---
@@ -545,13 +569,14 @@
(stubbing [uptime-computer nil
cl
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1043#issuecomment-175242193
Finished with my first pass through the code. For the most part things are
looking very good.
---
If your project is set up for it, you can reply to this email and hav
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1043#issuecomment-176296318
Also, will you kindly edit the title of this PR so it follows protocol?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1043#issuecomment-178148350
It would be good to move `MockedUtils.java` into
`org/apache/storm/testing/staticmocking` where the other mocking stuff is.
---
If your project is set up for it, you c
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/1043#issuecomment-178178677
Let's rename the title of this pull request so it describes the work being
done. Something about translating the utils namespace to Java.
---
If your project is set up for
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r51616229
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String
name, String asU
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1043#issuecomment-179485969
Should close this PR because of #1074
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1074
STORM-1226: Port backtype.storm.util to java
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knusbaum/incubator-storm util-conversion
Alternat
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1074#issuecomment-181495697
Squashed the commits.
Contributors were @rfarivar, @d2r, and myself.
Test failures are unrelated as far as I can tell. There appear to be test
problems affe
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52206422
--- Diff: storm-core/pom.xml ---
@@ -42,6 +42,10 @@
This is here as a work around to place it at the beginning of
the classpath
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52206540
--- Diff: storm-core/src/clj/org/apache/storm/cluster.clj ---
@@ -274,7 +281,9 @@
LOGCONFIG-ROOT (issue-map-callback!
log-config
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52207624
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52208015
--- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
@@ -262,13 +266,16 @@
:task->component (:task->component worker)
:str
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52208583
--- Diff: storm-core/src/clj/org/apache/storm/daemon/nimbus.clj ---
@@ -643,10 +650,13 @@
topology (read-storm-topology-as-nimbus storm-id blob-st
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52209160
--- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
@@ -262,13 +266,16 @@
:task->component (:task->component worker)
:st
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52211458
--- Diff: storm-core/src/clj/org/apache/storm/command/dev_zookeeper.clj ---
@@ -14,6 +14,7 @@
;; See the License for the specific language gover
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52211622
--- Diff: storm-core/src/clj/org/apache/storm/converter.clj ---
@@ -71,6 +72,8 @@
(:w
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52211853
--- Diff: storm-core/src/clj/org/apache/storm/converter.clj ---
@@ -203,6 +214,8 @@
(convert-to-symbol-from-status (.get_prev_status storm
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52214175
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -106,8 +158,23 @@
public static Object newInstance(String klass)
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52214520
--- Diff:
storm-core/src/jvm/org/apache/storm/serialization/SerializationFactory.java ---
@@ -141,7 +141,8 @@ public IdDictionary(StormTopology topology) {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52214673
--- Diff: storm-core/src/jvm/org/apache/storm/utils/IPredicate.java ---
@@ -15,20 +15,8 @@
* See the License for the specific language governing permissi
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52214747
--- Diff: storm-core/src/jvm/org/apache/storm/utils/StaticMockable.java ---
@@ -0,0 +1,21 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52215061
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Time.java ---
@@ -98,10 +104,25 @@ public static long currentTimeMillis() {
return System.
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52215149
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Time.java ---
@@ -98,10 +104,25 @@ public static long currentTimeMillis() {
return System.
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52215246
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Time.java ---
@@ -98,10 +104,25 @@ public static long currentTimeMillis() {
return System.
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52215700
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52215606
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Time.java ---
@@ -98,10 +104,25 @@ public static long currentTimeMillis() {
return System.
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52215816
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -106,8 +158,23 @@
public static Object newInstance(String klass) {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52215990
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -106,8 +158,23 @@
public static Object newInstance(String klass) {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52216050
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -106,8 +158,23 @@
public static Object newInstance(String klass) {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52216072
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -106,8 +158,23 @@
public static Object newInstance(String klass) {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52216501
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -580,20 +655,23 @@ public static void restrictPermissions(String
baseDir) {
}
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52216875
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52217269
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1370,9 +1469,974 @@ public static int toPositive(int number) {
public static Ru
1 - 100 of 188 matches
Mail list logo
